Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2024-01-11 Thread via GitHub
jeyhunkarimov commented on code in PR #23612: URL: https://github.com/apache/flink/pull/23612#discussion_r1449994298 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java: ## @@ -0,0 +1,51 @@ +/* + *

[jira] [Resolved] (FLINK-34047) Inject GitHub Actions/Azure Pipelines env variables in uploading_watchdog.sh

2024-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34047. --- Fix Version/s: 1.19.0 1.18.1 Resolution: Fixed master: [f29ee07f5

Re: [PR] [BP-1.18][FLINK-34047][ci] Makes uploading_watchdog.sh support Azure Pipelines and GitHub Actions [flink]

2024-01-11 Thread via GitHub
XComp merged PR #24063: URL: https://github.com/apache/flink/pull/24063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-34047][ci] Make CI scripts agnostic to CI environment [flink]

2024-01-11 Thread via GitHub
XComp merged PR #24061: URL: https://github.com/apache/flink/pull/24061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-11 Thread via GitHub
flinkbot commented on PR #24078: URL: https://github.com/apache/flink/pull/24078#issuecomment-1888578089 ## CI report: * 547c3c10e8bb800244d18ce1c4cc23642bc460bf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33268][rest] Skip unknown fields in REST response deserialization [flink]

2024-01-11 Thread via GitHub
gaborgsomogyi commented on PR #23930: URL: https://github.com/apache/flink/pull/23930#issuecomment-1888577653 The change looks good, but timeout happened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-33268][rest] Skip unknown fields in REST response deserialization [flink]

2024-01-11 Thread via GitHub
gaborgsomogyi commented on PR #23930: URL: https://github.com/apache/flink/pull/23930#issuecomment-1888576964 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
XComp commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449977361 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
XComp commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449977361 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-11 Thread via GitHub
flinkbot commented on PR #24077: URL: https://github.com/apache/flink/pull/24077#issuecomment-1888570663 ## CI report: * d78dc4459252f1f105d0bc4337fa64726b834665 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
XComp commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449977361 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

[jira] [Resolved] (FLINK-34040) ScalaSerializersMigrationTest.testStableAnonymousClassnameGeneration fails in GHA with JDK 17 and 21

2024-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34040. --- Resolution: Fixed The error was, indeed caused by a wrong setup of the {{github-actions}} pr

[PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-11 Thread via GitHub
SinBex opened a new pull request, #24078: URL: https://github.com/apache/flink/pull/24078 ## What is the purpose of the change Currently, for JobVertices without parallelism configured, the AdaptiveBatchScheduler dynamically infers the vertex parallelism based on the volume of input

[jira] [Commented] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-01-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805915#comment-17805915 ] Hangxiang Yu commented on FLINK-34050: -- Thanks [~lijinzhong] and [~mayuehappy] prov

[jira] [Updated] (FLINK-33768) Support dynamic source parallelism inference for batch jobs

2024-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33768: --- Labels: pull-request-available (was: ) > Support dynamic source parallelism inference for b

[jira] [Resolved] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-34036. --- Resolution: Fixed Yup, it was caused by what I described in my comment above. Thanks for the

[PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-01-11 Thread via GitHub
swuferhong opened a new pull request, #24077: URL: https://github.com/apache/flink/pull/24077 ## What is the purpose of the change This pr is aims to update the query hint docs to clarify the resolution of conflicts in kv hint and list hint. ## Brief change log

[jira] [Updated] (FLINK-34034) When kv hint and list hint handle duplicate query hints, the results are different.

2024-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34034: --- Labels: pull-request-available (was: ) > When kv hint and list hint handle duplicate query

Re: [PR] [FLINK-33705] Upgrade to flink-shaded 18.0 [flink]

2024-01-11 Thread via GitHub
snuyanzin commented on PR #23838: URL: https://github.com/apache/flink/pull/23838#issuecomment-1888545344 Thanks for having a look I will rebase to the latest branch and split it in 2 commits: one for adopting jackson breaking change mentioned in description and another for the actual updat

[jira] [Resolved] (FLINK-33946) RocksDb sets setAvoidFlushDuringShutdown to true to speed up Task Cancel

2024-01-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-33946. -- Resolution: Fixed merged aa0c1b5e into master > RocksDb sets setAvoidFlushDuringShutdown to t

Re: [PR] [FLINK-33946] [rocksdb] set AvoidFlushDuringShutdown to true for avoiding Flush when Cancel Task [flink]

2024-01-11 Thread via GitHub
masteryhx closed pull request #24069: [FLINK-33946] [rocksdb] set AvoidFlushDuringShutdown to true for avoiding Flush when Cancel Task URL: https://github.com/apache/flink/pull/24069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Resolved] (FLINK-34051) Fix equals/hashCode/toString for SavepointRestoreSettings

2024-01-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-34051. -- Fix Version/s: 1.19.0 Resolution: Fixed merged 7745ef83 and ecb68704 into master > Fix

Re: [PR] [FLINK-34051][checkpoint] Fix equals/hashCode/toString for SavepointRestoreSettings [flink]

2024-01-11 Thread via GitHub
masteryhx closed pull request #24066: [FLINK-34051][checkpoint] Fix equals/hashCode/toString for SavepointRestoreSettings URL: https://github.com/apache/flink/pull/24066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-34067] Fix javacc warnings in flink-sql-parser [flink]

2024-01-11 Thread via GitHub
flinkbot commented on PR #24076: URL: https://github.com/apache/flink/pull/24076#issuecomment-1888409523 ## CI report: * 319b84aca99ca02d59dbfb7139a92472d0b19fd3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34066][table-planner] Fix LagFunction throw NPE when input argument are not null [flink]

2024-01-11 Thread via GitHub
flinkbot commented on PR #24075: URL: https://github.com/apache/flink/pull/24075#issuecomment-1888405606 ## CI report: * a1aa7a2284cee539e17b951a585962a416360104 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34067) Fix javacc warnings in flink-sql-parser

2024-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34067: --- Labels: pull-request-available (was: ) > Fix javacc warnings in flink-sql-parser >

[PR] [FLINK-34067] Fix javacc warnings in flink-sql-parser [flink]

2024-01-11 Thread via GitHub
jnh5y opened a new pull request, #24076: URL: https://github.com/apache/flink/pull/24076 ## What is the purpose of the change Address the two warnings in the build for the Flink SQL Parser: ``` [INFO] — javacc:2.4:javacc (javacc) @ flink-sql-parser ---

[jira] [Updated] (FLINK-34067) Fix javacc warnings in flink-sql-parser

2024-01-11 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes updated FLINK-34067: --- Description: While extending the Flink SQL parser, I noticed these two warnings: ``` [INFO] — javacc

[jira] [Created] (FLINK-34067) Fix javacc warnings in flink-sql-parser

2024-01-11 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-34067: -- Summary: Fix javacc warnings in flink-sql-parser Key: FLINK-34067 URL: https://issues.apache.org/jira/browse/FLINK-34067 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34066: --- Labels: pull-request-available (was: ) > LagFunction throw NPE when input argument are not

[jira] [Updated] (FLINK-34067) Fix javacc warnings in flink-sql-parser

2024-01-11 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes updated FLINK-34067: --- Affects Version/s: 1.19.0 > Fix javacc warnings in flink-sql-parser > --

[PR] [FLINK-34066][table-planner] Fix LagFunction throw NPE when input argument are not null [flink]

2024-01-11 Thread via GitHub
swuferhong opened a new pull request, #24075: URL: https://github.com/apache/flink/pull/24075 ## What is the purpose of the change Fix LagFunction throw NPE when input argument are not null. ## Brief change log - Fix LagFunction throw NPE when input argument are n

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-11 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805871#comment-17805871 ] Yang Wang commented on FLINK-34007: --- [~mapohl] Could you please confirm that whether "

[jira] [Created] (FLINK-34066) LagFunction throw NPE when input argument are not null

2024-01-11 Thread Yunhong Zheng (Jira)
Yunhong Zheng created FLINK-34066: - Summary: LagFunction throw NPE when input argument are not null Key: FLINK-34066 URL: https://issues.apache.org/jira/browse/FLINK-34066 Project: Flink Issu

Re: [PR] [FLINK-33576][core] Introduce new Flink conf file 'config.yaml' supporting standard YAML syntax. [flink]

2024-01-11 Thread via GitHub
JunRuiLee commented on PR #23852: URL: https://github.com/apache/flink/pull/23852#issuecomment-1888377286 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33929][jdbc-connector] Support JDBC String field read Fragment read [flink-connector-jdbc]

2024-01-11 Thread via GitHub
zhilinli123 commented on PR #87: URL: https://github.com/apache/flink-connector-jdbc/pull/87#issuecomment-1888373294 > @zhilinli123 I still don't understand the Jira ticket, so I can't really review it. Perhaps @snuyanzin or @eskabetxe understand the goal of this PR. hi~ @MartijnViss

Re: [PR] [FLINK-33958] Implement restore tests for IntervalJoin node [flink]

2024-01-11 Thread via GitHub
bvarghese1 commented on PR #24009: URL: https://github.com/apache/flink/pull/24009#issuecomment-1888372875 > From reading the code for `StreamExecIntervalJoin`, I noticed pad/filter-left/right transformations. Seems like those can be produced when the `TABLE_EXEC_LEGACY_TRANSFORMATION_UIDS`

Re: [PR] [FLINK-34051][checkpoint] Fix equals/hashCode/toString for SavepointRestoreSettings [flink]

2024-01-11 Thread via GitHub
ljz2051 commented on PR #24066: URL: https://github.com/apache/flink/pull/24066#issuecomment-1888366794 Thanks for the update, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2024-01-11 Thread via GitHub
zoudan commented on PR #23984: URL: https://github.com/apache/flink/pull/23984#issuecomment-1888360571 @lsyldliu I have updated my code, please have a took when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [FLINK-31788][table] TableAggregateFunction supports emitUpdateWithRetract [flink]

2024-01-11 Thread via GitHub
flinkbot commented on PR #24074: URL: https://github.com/apache/flink/pull/24074#issuecomment-1888345731 ## CI report: * 970e31067f5a893ea90b3f8a33064051e597bfe3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
1996fanrui commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1449726286 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/state/JobStateView.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the

[jira] [Created] (FLINK-34065) Design AbstractAutoscalerStateStore to support serialize State to String

2024-01-11 Thread Rui Fan (Jira)
Rui Fan created FLINK-34065: --- Summary: Design AbstractAutoscalerStateStore to support serialize State to String Key: FLINK-34065 URL: https://issues.apache.org/jira/browse/FLINK-34065 Project: Flink

Re: [PR] [FLINK-33930] Canceled stop job status exception [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
hunter-cloud09 commented on code in PR #740: URL: https://github.com/apache/flink-kubernetes-operator/pull/740#discussion_r1449726381 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -369,16 +370,17 @@ prot

[PR] [FLINK-31788][table] TableAggregateFunction supports emitUpdateWithRetract [flink]

2024-01-11 Thread via GitHub
LadyForest opened a new pull request, #24074: URL: https://github.com/apache/flink/pull/24074 ## What is the purpose of the change This PR is cherry-picked from https://github.com/apache/flink/pull/24051 ## Brief change log - Planning phase: Check whether the `emitUpdateW

[jira] [Updated] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2024-01-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-31788: -- Affects Version/s: 1.18.1 > Add back Support emitValueWithRetract for TableAggregateFunction > ---

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2024-01-11 Thread via GitHub
zoudan commented on PR #23984: URL: https://github.com/apache/flink/pull/23984#issuecomment-1888301428 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Updated] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2024-01-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-31788: -- Affects Version/s: 1.17.2 1.16.3 1.17.1

[jira] [Commented] (FLINK-31788) Add back Support emitValueWithRetract for TableAggregateFunction

2024-01-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805853#comment-17805853 ] Jane Chan commented on FLINK-31788: --- Fixed in master 01569644aedb56f792c7f7e04f84612d4

Re: [PR] [FLINK-31788][table] TableAggregateFunction supports emitUpdateWithRetract [flink]

2024-01-11 Thread via GitHub
LadyForest merged PR #24051: URL: https://github.com/apache/flink/pull/24051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Resolved] (FLINK-20281) Window aggregation supports changelog stream input

2024-01-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan resolved FLINK-20281. --- Fix Version/s: 1.19.0 Resolution: Fixed > Window aggregation supports changelog stream input

[jira] [Closed] (FLINK-20281) Window aggregation supports changelog stream input

2024-01-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-20281. - > Window aggregation supports changelog stream input > -- >

[jira] [Commented] (FLINK-20281) Window aggregation supports changelog stream input

2024-01-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805852#comment-17805852 ] Jane Chan commented on FLINK-20281: --- Fixed in master df2ecdc77b23e0e40fe151ed8a7350a6d

Re: [PR] [FLINK-33879] Avoids the potential hang of Hybrid Shuffle during redistribution [flink]

2024-01-11 Thread via GitHub
jiangxin369 commented on PR #23957: URL: https://github.com/apache/flink/pull/23957#issuecomment-1888280011 @reswqa Seems that the CI failed but the cause is related to python rather than this PR. Could you help merge it? -- This is an automated message from the Apache Git Service. To res

Re: [PR] [FLINK-20281][table] support consuming cdc stream about window tvf aggregate [flink]

2024-01-11 Thread via GitHub
LadyForest merged PR #24030: URL: https://github.com/apache/flink/pull/24030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[PR] [hotfix] Correct release date for flink-shaded 18.0 [flink-web]

2024-01-11 Thread via GitHub
snuyanzin opened a new pull request, #710: URL: https://github.com/apache/flink-web/pull/710 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Add flink-shaded 18.0 release [flink-web]

2024-01-11 Thread via GitHub
snuyanzin merged PR #701: URL: https://github.com/apache/flink-web/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-11 Thread via GitHub
flinkbot commented on PR #24073: URL: https://github.com/apache/flink/pull/24073#issuecomment-1888126956 ## CI report: * 03494cb182c4f0e3fa4e407dc1f3b06dc9db40b9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-11 Thread via GitHub
jnh5y opened a new pull request, #24073: URL: https://github.com/apache/flink/pull/24073 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on e

[jira] [Updated] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-11 Thread Ivan Burmistrov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Burmistrov updated FLINK-34063: Priority: Critical (was: Major) > When snapshot compression is enabled, rescaling of a so

[jira] [Updated] (FLINK-34064) Expose JobManagerOperatorMetrics via REST API

2024-01-11 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-34064: --- Affects Version/s: 1.18.0 > Expose JobManagerOperatorMetrics via REST API >

[jira] [Updated] (FLINK-34064) Expose JobManagerOperatorMetrics via REST API

2024-01-11 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-34064: --- Component/s: Runtime / REST > Expose JobManagerOperatorMetrics via REST API > --

[jira] [Created] (FLINK-34064) Expose JobManagerOperatorMetrics via REST API

2024-01-11 Thread Mason Chen (Jira)
Mason Chen created FLINK-34064: -- Summary: Expose JobManagerOperatorMetrics via REST API Key: FLINK-34064 URL: https://issues.apache.org/jira/browse/FLINK-34064 Project: Flink Issue Type: Improve

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-11 Thread via GitHub
mas-chen commented on PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#issuecomment-1887855854 one-pager docs are here: docs/content/docs/connectors/datastream/dynamic-kafka.md. Marked with experimental status. Also copied this into the chinese doc directory. -

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805739#comment-17805739 ] Piotr Nowojski commented on FLINK-33856: In that case [~hejufang001] it would be

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-11 Thread via GitHub
mxm commented on PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#issuecomment-1887622480 A brief one-pager of the feature would be good. We can expand on it later. Just to have something in the web docs. -- This is an automated message from the Apache Git Service. To

[jira] [Created] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-11 Thread Ivan Burmistrov (Jira)
Ivan Burmistrov created FLINK-34063: --- Summary: When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost Key: FLINK-34063 URL: https://issues.apache.org/jira/browse/F

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-11 Thread via GitHub
mas-chen commented on PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#issuecomment-1887602638 Are the Javadocs sufficient in the bare minimum case? Otherwise, I'll just write the documentation into this PR -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-11 Thread via GitHub
mxm commented on PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#issuecomment-1887599176 Sounds good. Can we get a bare-minimum version of the documentation into this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-11 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1887600132 @snuyanzin I have left this with multiple commits for now . Should we squash to one commit and put you as a co author in the commit message? If so how would you like me to id

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-11 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1449155934 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicatePlanTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to th

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-11 Thread via GitHub
mas-chen commented on PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#issuecomment-1887586297 Thanks @tzulitai @mxm for your review! I've addressed all the comments and squashed the commits. Can you please merge it at your convenience? I'll start on the docs imme

Re: [PR] [FLINK-34027] Introduces AsyncScalarFunction as a new UDF type [flink]

2024-01-11 Thread via GitHub
twalthr commented on code in PR #23975: URL: https://github.com/apache/flink/pull/23975#discussion_r1449149984 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/AsyncUtil.java: ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805708#comment-17805708 ] Matthias Pohl edited comment on FLINK-34036 at 1/11/24 4:55 PM: --

[jira] [Commented] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805708#comment-17805708 ] Matthias Pohl commented on FLINK-34036: --- The problem seems to be that we're not bu

Re: [PR] [FLINK-34027] Introduces AsyncScalarFunction as a new UDF type [flink]

2024-01-11 Thread via GitHub
twalthr commented on code in PR #23975: URL: https://github.com/apache/flink/pull/23975#discussion_r1449138779 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecAsyncCalc.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed t

Re: [PR] [FLINK-34027] Introduces AsyncScalarFunction as a new UDF type [flink]

2024-01-11 Thread via GitHub
twalthr commented on code in PR #23975: URL: https://github.com/apache/flink/pull/23975#discussion_r1449134322 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionMappingExtractor.java: ## @@ -208,6 +249,32 @@ static MethodVerification

[jira] [Commented] (FLINK-32006) AsyncWaitOperatorTest.testProcessingTimeWithTimeoutFunctionOrderedWithRetry times out on Azure

2024-01-11 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805698#comment-17805698 ] Junrui Li commented on FLINK-32006: --- https://dev.azure.com/apache-flink/apache-flink/_

Re: [PR] [FLINK-34027] Introduces AsyncScalarFunction as a new UDF type [flink]

2024-01-11 Thread via GitHub
twalthr commented on code in PR #23975: URL: https://github.com/apache/flink/pull/23975#discussion_r1449130065 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java: ## @@ -67,6 +67,8 @@ public final class UserDefinedFunc

Re: [PR] [FLINK-34020] Bump CI flink version on flink-connector-rabbitmq [flink-connector-rabbitmq]

2024-01-11 Thread via GitHub
snuyanzin commented on code in PR #22: URL: https://github.com/apache/flink-connector-rabbitmq/pull/22#discussion_r1449084708 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java: ## @@ -22,6 +22,7 @@ import org.apache.flink.a

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
XComp commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449060542 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

[jira] [Updated] (FLINK-30252) Publish flink-shaded pom

2024-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30252: --- Fix Version/s: shaded-19.0 (was: shaded-18.0) > Publish flink-shaded

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
XComp commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449024195 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
zentol commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449020160 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
zentol commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449015851 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
zentol commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449014250 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
zentol commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449015851 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] [FLINK-33915][ci] Adds nightly workflow for the master branch [flink]

2024-01-11 Thread via GitHub
zentol commented on code in PR #23971: URL: https://github.com/apache/flink/pull/23971#discussion_r1449014250 ## .github/actions/select_workflow_configs/action.yml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[jira] [Commented] (FLINK-31977) If scaling.effectiveness.detection.enabled is false, the call to the detectIneffectiveScaleUp() function is unnecessary

2024-01-11 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805650#comment-17805650 ] Maximilian Michels commented on FLINK-31977: I think this is related to FLIN

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2024-01-11 Thread via GitHub
patricklucas commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1887371839 My suspicion is that there's an extremely small chance of that but I have no way to quantify it. In our case it was actually the other way around: we set this option and were

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-11 Thread via GitHub
mxm commented on code in PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#discussion_r1448982380 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/DynamicKafkaSource.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805636#comment-17805636 ] Matthias Pohl commented on FLINK-34036: --- The test failures can be reproduced local

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
mxm commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1448978956 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -59,4 +64,47 @@ private

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
mxm commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1448978630 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/state/JobStateView.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33771] Add cluster capacity awareness to autoscaler [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
1996fanrui commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1448948315 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -247,6 +254,69 @@ private boolean isJobUnderMemoryPressure

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
1996fanrui commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1448941925 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/state/JobStateView.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
1996fanrui commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1448928730 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -59,4 +64,47 @@ p

Re: [PR] [FLINK-33771] Add cluster capacity awareness to autoscaler [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
1996fanrui commented on code in PR #751: URL: https://github.com/apache/flink-kubernetes-operator/pull/751#discussion_r1448858318 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/resources/ResourceCheck.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
mxm commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1448905911 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -59,4 +64,47 @@ private

Re: [PR] DO_NOT_MERGE_YET[FLINK-33268][rest] Skip unknown fields in REST response deserialization [flink]

2024-01-11 Thread via GitHub
gaborgsomogyi commented on PR #23930: URL: https://github.com/apache/flink/pull/23930#issuecomment-1887214969 The approach looks fine though not fully executed the full pipeline so added an automated test to enforce `ErrorResponseBody` structure. -- This is an automated message from the A

Re: [PR] [FLINK-33930] Canceled stop job status exception [flink-kubernetes-operator]

2024-01-11 Thread via GitHub
gyfora commented on code in PR #740: URL: https://github.com/apache/flink-kubernetes-operator/pull/740#discussion_r1448906275 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -369,16 +370,17 @@ protected vo

  1   2   >