[jira] [Commented] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804621#comment-17804621 ] Matthias Pohl commented on FLINK-34036: --- It could be that it's a configuration iss

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
xuyangzhong commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445736898 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/hints/stream/StateTtlHintTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804615#comment-17804615 ] Matthias Pohl commented on FLINK-34036: --- The error for {{testInsertDirectory}} loo

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804616#comment-17804616 ] Sergey Nuyanzin commented on FLINK-33414: - I don't know it appeared only today d

[jira] [Commented] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804617#comment-17804617 ] Matthias Pohl commented on FLINK-34036: --- {{testNullLiteralAsArgument}} sounds like

[jira] [Created] (FLINK-34037) FLIP-398: Improve Serialization Configuration And Usage In Flink

2024-01-08 Thread Fang Yong (Jira)
Fang Yong created FLINK-34037: - Summary: FLIP-398: Improve Serialization Configuration And Usage In Flink Key: FLINK-34037 URL: https://issues.apache.org/jira/browse/FLINK-34037 Project: Flink I

[jira] [Updated] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34036: -- Description: The following {{HiveDialectQueryITCase}} tests fail consistently in the FLINK-27

[jira] [Updated] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34036: -- Description: The following {{HiveDialectQueryITCase}} tests fail consistently in the FLINK-27

[jira] [Updated] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34036: -- Description: The following {{HiveDialectQueryITCase}} tests fail consistently in the FLINK-27

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
xuyangzhong commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445732928 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -116,13 +123,27 @@ class

[jira] [Commented] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804614#comment-17804614 ] Matthias Pohl commented on FLINK-34036: --- [~yuxia] Do you have an idea about the ca

[jira] [Created] (FLINK-34036) Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled

2024-01-08 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34036: - Summary: Various HiveDialectQueryITCase tests fail in GitHub Actions workflow with Hadoop 3.1.3 enabled Key: FLINK-34036 URL: https://issues.apache.org/jira/browse/FLINK-34036

[jira] [Comment Edited] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2024-01-08 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804610#comment-17804610 ] Jiang Xin edited comment on FLINK-33414 at 1/9/24 7:44 AM: --- [~

[jira] [Commented] (FLINK-34034) When kv hint and list hint handle duplicate query hints, the results are different.

2024-01-08 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804611#comment-17804611 ] xuyang commented on FLINK-34034: Hi, [~qingyue] Our documentation currently seems not t

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2024-01-08 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804610#comment-17804610 ] Jiang Xin commented on FLINK-33414: --- [~Sergey Nuyanzin] Is it can be consistently repr

Re: [PR] [FLINK-33879] Avoids the potential hang of Hybrid Shuffle during redistribution [flink]

2024-01-08 Thread via GitHub
reswqa commented on code in PR #23957: URL: https://github.com/apache/flink/pull/23957#discussion_r1445651286 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java: ## @@ -244,6 +251,58 @@ public vo

[jira] [Commented] (FLINK-33233) Null point exception when non-native udf used in join condition

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804607#comment-17804607 ] Matthias Pohl commented on FLINK-33233: --- Out of curiosity: Is this really an impro

[jira] [Updated] (FLINK-34035) when flinksql with group by partition some errors field occured in jobmanager.log

2024-01-08 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-34035: - Description: flink.version=1.17.1 kyuubi.version=1.8.0 hive.version=3.1.2 when run some hive sql as foll

[jira] [Updated] (FLINK-34035) when flinksql with group by partition some errors field occured in jobmanager.log

2024-01-08 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-34035: - Description: flink.version=1.17.1 kyuubi.version=1.8.0 hive.version=3.1.2 when run some hive sql as foll

[jira] [Updated] (FLINK-34035) when flinksql with group by partition some errors field occured in jobmanager.log

2024-01-08 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-34035: - Description: flink.version=1.17.1 kyuubi.version=1.8.0 hive.version=3.1.2 when run some hive sql as foll

[jira] [Updated] (FLINK-34035) when flinksql with group by partition some errors field occured in jobmanager.log

2024-01-08 Thread hansonhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hansonhe updated FLINK-34035: - Description: flink.version=1.17.1 kyuubi.version=1.8.0 hive.version=3.1.2 when run some hive sql as foll

Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]

2024-01-08 Thread via GitHub
qinf commented on PR #24040: URL: https://github.com/apache/flink/pull/24040#issuecomment-1882535964 Thank you @1996fanrui for your contribution, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (FLINK-34035) when flinksql with group by partition some errors field occured in jobmanager.log

2024-01-08 Thread hansonhe (Jira)
hansonhe created FLINK-34035: Summary: when flinksql with group by partition some errors field occured in jobmanager.log Key: FLINK-34035 URL: https://issues.apache.org/jira/browse/FLINK-34035 Project: Fl

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804604#comment-17804604 ] Sergey Nuyanzin commented on FLINK-27756: - https://dev.azure.com/apache-flink/ap

[jira] [Reopened] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-33414: - I fear I have to reopen this issue since now testHandleStreamingJobsWhenNotEnoughSlot start

[jira] [Closed] (FLINK-32570) Deprecate API that uses Flink's Time implementation (related to FLINK-14638)

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-32570. - Release Note: Flink's Time classes are deprecated now and will be subject to deletion with the r

[jira] [Commented] (FLINK-34034) When kv hint and list hint handle duplicate query hints, the results are different.

2024-01-08 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804601#comment-17804601 ] Jane Chan commented on FLINK-34034: --- Hi [~xuyangzhong], thanks for reporting this issu

[jira] [Reopened] (FLINK-32570) Deprecate API that uses Flink's Time implementation (related to FLINK-14638)

2024-01-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-32570: --- > Deprecate API that uses Flink's Time implementation (related to FLINK-14638) > ---

[jira] [Commented] (FLINK-33325) FLIP-375: Built-in cross-platform powerful java profiler

2024-01-08 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804598#comment-17804598 ] Zhanghao Chen commented on FLINK-33325: --- Looking forward to the feature~ > FLIP-3

[jira] [Closed] (FLINK-33938) Correct implicit coercions in relational operators to adopt typescript 5.0

2024-01-08 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-33938. Resolution: Fixed - master (1.19): e07545e458bd22099244a353ac29477ca3a13811 - release-1.18: 12463f

[jira] [Commented] (FLINK-33681) Display source/sink numRecordsIn/Out & numBytesIn/Out on UI

2024-01-08 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804596#comment-17804596 ] Zhanghao Chen commented on FLINK-33681: --- [~renqs] Kindly remind~ Would you mind ta

Re: [PR] [FLINK-33938][runtime-web] Correct implicit coercions in relational operators to adopt typescript 5.0 [flink]

2024-01-08 Thread via GitHub
xintongsong closed pull request #23999: [FLINK-33938][runtime-web] Correct implicit coercions in relational operators to adopt typescript 5.0 URL: https://github.com/apache/flink/pull/23999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Updated] (FLINK-34034) When kv hint and list hint handle duplicate query hints, the results are different.

2024-01-08 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34034: --- Component/s: Table SQL / Planner > When kv hint and list hint handle duplicate query hints, the results are

[jira] [Assigned] (FLINK-34034) When kv hint and list hint handle duplicate query hints, the results are different.

2024-01-08 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34034: - Assignee: xuyang > When kv hint and list hint handle duplicate query hints, the results are >

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804591#comment-17804591 ] Sergey Nuyanzin commented on FLINK-31472: - Converting to critical since it start

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804590#comment-17804590 ] Sergey Nuyanzin commented on FLINK-31472: - Thanks for looking into thi [~chalixa

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804589#comment-17804589 ] Sergey Nuyanzin commented on FLINK-31472: - https://dev.azure.com/apache-flink/ap

[jira] [Updated] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-31472: Priority: Critical (was: Major) > AsyncSinkWriterThrottlingTest failed with Illegal mailb

[jira] [Created] (FLINK-34034) When kv hint and list hint handle duplicate query hints, the results are different.

2024-01-08 Thread xuyang (Jira)
xuyang created FLINK-34034: -- Summary: When kv hint and list hint handle duplicate query hints, the results are different. Key: FLINK-34034 URL: https://issues.apache.org/jira/browse/FLINK-34034 Project: Flin

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-08 Thread via GitHub
JunRuiLee commented on PR #24025: URL: https://github.com/apache/flink/pull/24025#issuecomment-1882495740 > Hi @JunRuiLee , would you mind rebaseing the master branch to fix the CI? thanks~ Hi @1996fanrui , I am currently waiting for the merge of https://github.com/apache/flink/pull/

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
LadyForest commented on PR #23752: URL: https://github.com/apache/flink/pull/23752#issuecomment-1882495417 1. Change state metadata time unit to adapt changes introduced by https://github.com/apache/flink/pull/23873 2. Cope with duplicate hints/hint KV options -- This is an automated m

Re: [PR] fix: missing serialVersionUID of serializable classes [flink]

2024-01-08 Thread via GitHub
flinkbot commented on PR #24047: URL: https://github.com/apache/flink/pull/24047#issuecomment-1882480603 ## CI report: * 57136eb1fbcb1eb408d7abe73200a468cf026a10 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] fix: missing serialVersionUID of serializable classes [flink]

2024-01-08 Thread via GitHub
rng70-or opened a new pull request, #24047: URL: https://github.com/apache/flink/pull/24047 ## What is the purpose of the change In several files there are some classes that are serializable but they do not contain any serialVersionUID field. The compiler generates one by defa

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2024-01-08 Thread via GitHub
yunfengzhou-hub commented on PR #23927: URL: https://github.com/apache/flink/pull/23927#issuecomment-1882465840 Hi @reswqa Could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
LadyForest commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445599937 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/hints/stream/StateTtlHintTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same sub project field.

2024-01-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804577#comment-17804577 ] Benchao Li commented on FLINK-33996: bq. In addition, what I would like to ask is wh

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2024-01-08 Thread via GitHub
jeyhunkarimov commented on PR #23612: URL: https://github.com/apache/flink/pull/23612#issuecomment-1882424567 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-08 Thread via GitHub
1996fanrui commented on PR #24025: URL: https://github.com/apache/flink/pull/24025#issuecomment-1882410385 Hi @JunRuiLee , would you mind rebaseing the master branch to fix the CI? thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (FLINK-34032) Cleanup local-recovery dir when switching local-recovery from enabled to disabled

2024-01-08 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804570#comment-17804570 ] Jinzhong Li commented on FLINK-34032: - Hi [~masteryhx] , would you please clarify th

Re: [PR] [hotfix] Extract common preparing directory code into one function [flink-benchmarks]

2024-01-08 Thread via GitHub
masteryhx closed pull request #84: [hotfix] Extract common preparing directory code into one function URL: https://github.com/apache/flink-benchmarks/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [hotfix] Extract common preparing directory code into one function [flink-benchmarks]

2024-01-08 Thread via GitHub
masteryhx commented on PR #84: URL: https://github.com/apache/flink-benchmarks/pull/84#issuecomment-1882394452 merged 8b0b1c62 into master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Commented] (FLINK-33950) Update max aggregate functions to new type system

2024-01-08 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804569#comment-17804569 ] Jacky Lau commented on FLINK-33950: --- hi [~martijnvisser] what is your opinion? > Upda

[jira] [Created] (FLINK-34033) flink json supports raw type

2024-01-08 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-34033: - Summary: flink json supports raw type Key: FLINK-34033 URL: https://issues.apache.org/jira/browse/FLINK-34033 Project: Flink Issue Type: Bug Components:

[jira] [Reopened] (FLINK-32978) Deprecate RichFunction#open(Configuration parameters)

2024-01-08 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reopened FLINK-32978: -- Reopening the ticket to fix the unexpected breaking changes. > Deprecate RichFunction#open(Config

[jira] [Commented] (FLINK-32978) Deprecate RichFunction#open(Configuration parameters)

2024-01-08 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804566#comment-17804566 ] Xintong Song commented on FLINK-32978: -- Thanks for reporting this, [~Sergey Nuyanzi

[jira] [Commented] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2024-01-08 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804564#comment-17804564 ] Xintong Song commented on FLINK-33728: -- Thanks for pulling me in. I'm also concern

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
LadyForest commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445602009 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -116,13 +123,27 @@ class

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
LadyForest commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445599937 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/hints/stream/StateTtlHintTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-08 Thread via GitHub
mas-chen commented on PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#issuecomment-1882369061 @tzulitai Thanks for the review. I would like get some more input from at least another reviewer from merging this and I agree this should be included in the 3.1.0 release. Pe

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-08 Thread via GitHub
mas-chen commented on code in PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#discussion_r1445596890 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/DynamicKafkaSource.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-34032) Cleanup local-recovery dir when switching local-recovery from enabled to disabled

2024-01-08 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-34032: - Summary: Cleanup local-recovery dir when switching local-recovery from enabled to disabled (was

[jira] [Created] (FLINK-34032) Cleanup local=recovery dir when switching local-recovery from enabled to disabled

2024-01-08 Thread Hangxiang Yu (Jira)
Hangxiang Yu created FLINK-34032: Summary: Cleanup local=recovery dir when switching local-recovery from enabled to disabled Key: FLINK-34032 URL: https://issues.apache.org/jira/browse/FLINK-34032 Pro

[jira] [Created] (FLINK-34031) Hive table sources report statistics in various formats

2024-01-08 Thread hanjie (Jira)
hanjie created FLINK-34031: -- Summary: Hive table sources report statistics in various formats Key: FLINK-34031 URL: https://issues.apache.org/jira/browse/FLINK-34031 Project: Flink Issue Type: Impro

[jira] [Updated] (FLINK-34031) Hive table sources report statistics in various formats

2024-01-08 Thread hanjie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hanjie updated FLINK-34031: --- Component/s: Connectors / Hive (was: Table SQL / API) > Hive table sources report stati

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2024-01-08 Thread via GitHub
zoudan commented on PR #23984: URL: https://github.com/apache/flink/pull/23984#issuecomment-1882328998 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2024-01-08 Thread via GitHub
zoudan commented on code in PR #23984: URL: https://github.com/apache/flink/pull/23984#discussion_r1445558740 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/LongHashJoinGenerator.scala: ## @@ -87,10 +90,11 @@ object LongHashJoinGenerator

[jira] [Commented] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same sub project field.

2024-01-08 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804557#comment-17804557 ] Feng Jin commented on FLINK-33996: -- [~libenchao] [~qingyue]  If it can be reused during

[jira] [Updated] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same sub project field.

2024-01-08 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-33996: - Description: When multiple top projects reference the same bottom project, project rewrite rules may re

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-08 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1445576114 ## pom.xml: ## @@ -2301,6 +2301,8 @@ under the License. org.apache.flink.streaming.api.environment.S

[jira] [Assigned] (FLINK-33879) Hybrid Shuffle may hang during redistribution

2024-01-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-33879: -- Assignee: Jiang Xin > Hybrid Shuffle may hang during redistribution > ---

Re: [PR] [FLINK-33938][runtime-web] Correct implicit coercions in relational operators to adopt typescript 5.0 [flink]

2024-01-08 Thread via GitHub
WencongLiu commented on PR #23999: URL: https://github.com/apache/flink/pull/23999#issuecomment-1882250920 These two modifications prevent the code from relying on implicit type conversions. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2024-01-08 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804553#comment-17804553 ] xiaogang zhou commented on FLINK-33728: --- [~mapohl] I think your concern is really

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
xuyangzhong commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445560825 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/jsonplan/ConfigureOperatorLevelStateTtlJsonITCase.java: ## @@ -43,6 +

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
xuyangzhong commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445559559 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/hints/stream/StateTtlHintTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to th

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
xuyangzhong commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445548152 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -116,13 +123,27 @@ class

Re: [PR] [FLINK-34030][changelog] Introduce periodic-materialize.enabled to enable/disable periodic materialization [flink]

2024-01-08 Thread via GitHub
flinkbot commented on PR #24046: URL: https://github.com/apache/flink/pull/24046#issuecomment-1882187313 ## CI report: * ebd87ccef19fb417e320bba6b9c2e54cf4d94b52 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34030][changelog] Introduce periodic-materialize.enabled to enable/disable periodic materialization [flink]

2024-01-08 Thread via GitHub
masteryhx commented on PR #24046: URL: https://github.com/apache/flink/pull/24046#issuecomment-1882178534 @JunRuiLee @fredia Could you help to take a review ? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Updated] (FLINK-34030) Avoid using negative value for periodic-materialize.interval

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34030: --- Labels: pull-request-available (was: ) > Avoid using negative value for periodic-materializ

[PR] [FLINK-34030][changelog] Introduce periodic-materialize.enabled to enable/disable periodic materialization [flink]

2024-01-08 Thread via GitHub
masteryhx opened a new pull request, #24046: URL: https://github.com/apache/flink/pull/24046 ## What is the purpose of the change Similar to [FLINK-32023](https://issues.apache.org/jira/browse/FLINK-32023), a nagative value doesn't work for Duration Type like periodic-materia

[jira] [Assigned] (FLINK-34013) ProfilingServiceTest.testRollingDeletion is unstable on AZP

2024-01-08 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-34013: Assignee: Yu Chen (was: Yu Chen) > ProfilingServiceTest.testRollingDeletion is unstable on AZP >

[jira] [Assigned] (FLINK-34013) ProfilingServiceTest.testRollingDeletion is unstable on AZP

2024-01-08 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-34013: Assignee: Yu Chen > ProfilingServiceTest.testRollingDeletion is unstable on AZP > ---

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
xuyangzhong commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445548152 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -116,13 +123,27 @@ class

[jira] [Created] (FLINK-34030) Avoid using negative value for periodic-materialize.interval

2024-01-08 Thread Hangxiang Yu (Jira)
Hangxiang Yu created FLINK-34030: Summary: Avoid using negative value for periodic-materialize.interval Key: FLINK-34030 URL: https://issues.apache.org/jira/browse/FLINK-34030 Project: Flink

Re: [PR] [FLINK-32416] initial implementation of DynamicKafkaSource with bound… [flink-connector-kafka]

2024-01-08 Thread via GitHub
mas-chen commented on code in PR #44: URL: https://github.com/apache/flink-connector-kafka/pull/44#discussion_r1445538272 ## flink-connector-kafka/src/test/resources/log4j2-test.properties: ## @@ -36,3 +36,12 @@ logger.zookeeper.name = org.apache.zookeeper logger.zookeeper.lev

Re: [PR] [FLINK-33583][table-planner] Support state ttl hint for regular join [flink]

2024-01-08 Thread via GitHub
xuyangzhong commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1445536689 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/QueryHintsResolver.java: ## @@ -84,6 +85,12 @@ protected RelNode visit

[jira] [Created] (FLINK-34029) Support different profiling mode on Flink WEB

2024-01-08 Thread Yu Chen (Jira)
Yu Chen created FLINK-34029: --- Summary: Support different profiling mode on Flink WEB Key: FLINK-34029 URL: https://issues.apache.org/jira/browse/FLINK-34029 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-34013][runtime] Remove duplicated stopProfiling() in `ProfilingService` [flink]

2024-01-08 Thread via GitHub
flinkbot commented on PR #24045: URL: https://github.com/apache/flink/pull/24045#issuecomment-1882116192 ## CI report: * 237bddb2c138acf773d79fda697c66ca82896ec2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34013) ProfilingServiceTest.testRollingDeletion is unstable on AZP

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34013: --- Labels: pull-request-available test-stability (was: test-stability) > ProfilingServiceTest.

[PR] [FLINK-34013][runtime] Remove duplicated stopProfiling() in `ProfilingService` [flink]

2024-01-08 Thread via GitHub
yuchen-ecnu opened a new pull request, #24045: URL: https://github.com/apache/flink/pull/24045 ## What is the purpose of the change Remove the duplicated `stopProfiling()` call in `ProfilingService` to avoid profiling instances stopped unexpectedly when repeating profiling quickly

Re: [PR] [FLINK-34027] Introduces AsyncScalarFunction as a new UDF type [flink]

2024-01-08 Thread via GitHub
AlanConfluent commented on PR #23975: URL: https://github.com/apache/flink/pull/23975#issuecomment-1882073976 @twalthr Thanks Timo for the in-depth review! I think I was able to respond to everything you mentioned, no real straggling issues. Please take another look. -- This is an auto

[jira] [Updated] (FLINK-34027) Create initial PR for FLIP-400

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34027: --- Labels: pull-request-available (was: ) > Create initial PR for FLIP-400 > -

Re: [PR] [FLINK-33611] [flink-protobuf] Support Large Protobuf Schemas [flink]

2024-01-08 Thread via GitHub
sharath1709 commented on PR #23937: URL: https://github.com/apache/flink/pull/23937#issuecomment-1882015968 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-08 Thread via GitHub
snuyanzin commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1882007369 @libenchao since you are participated in jira, could you also have a look please? I'm also asking since now there are commits from both David and me and it would be great t

[jira] [Commented] (FLINK-24024) Support session Window TVF

2024-01-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804517#comment-17804517 ] Sergey Nuyanzin commented on FLINK-24024: - [~xuyangzhong] thanks a lot for worki

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2024-01-08 Thread via GitHub
rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445467435 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/WithPreWriteTopology.java: ## @@ -21,18 +21,9 @@ import org.apache.flink.annota

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2024-01-08 Thread via GitHub
rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445464969 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/SupportsWriterState.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2024-01-08 Thread via GitHub
rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445465244 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/SupportsWriterState.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2024-01-08 Thread via GitHub
rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445463214 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/StatefulSink.java: ## @@ -36,49 +34,43 @@ * @param The type of the sink writer's state */ @Pub

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

2024-01-08 Thread via GitHub
rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445462324 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/Sink.java: ## @@ -52,11 +54,30 @@ public interface Sink extends Serializable { * @param contex

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2024-01-08 Thread via GitHub
jeyhunkarimov commented on PR #23612: URL: https://github.com/apache/flink/pull/23612#issuecomment-1881965798 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

  1   2   3   >