Re: [PR] [FLINK-27529] Fix Intger Comparison For Source Index in Hybrid Source [flink]

2023-12-02 Thread via GitHub
varun1729DD commented on PR #23703: URL: https://github.com/apache/flink/pull/23703#issuecomment-1837396406 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-33210][core] Introduce job status changed listener for lineage [flink]

2023-12-02 Thread via GitHub
JingGe commented on PR #23695: URL: https://github.com/apache/flink/pull/23695#issuecomment-1837390803 @FangYongs are you still working on this PR? FYI: Flink doc needs to be generated again after new configOption is introduced. -- This is an automated message from the Apache Git Service.

[jira] [Commented] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2023-12-02 Thread Yuexin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792489#comment-17792489 ] Yuexin Chen commented on FLINK-22014: - [~mason6345] Is it caused by this issue FLINK

[jira] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2023-12-02 Thread Yuexin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014 ] Yuexin Chen deleted comment on FLINK-22014: - was (Author: JIRAUSER295713): [~mason6345] Is it caused by this issue  issues.apache.org/jira/browse/FLINK-33011, we use flink-kubernetes-operator

[jira] [Commented] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2023-12-02 Thread Yuexin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792488#comment-17792488 ] Yuexin Chen commented on FLINK-22014: - [~mason6345] Is it caused by this issue  issu

[jira] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2023-12-02 Thread Yuexin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014 ] Yuexin Chen deleted comment on FLINK-22014: - was (Author: JIRAUSER295713): [~mason6345] [~novakov.alex] have you found the issue of the problem? > Flink JobManager failed to restart after fa

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-02 Thread via GitHub
JingGe commented on code in PR #23858: URL: https://github.com/apache/flink/pull/23858#discussion_r1413009264 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -142,7 +142,7 @@ public class Join

[jira] [Commented] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2023-12-02 Thread chenyuexin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792483#comment-17792483 ] chenyuexin commented on FLINK-22014: [~mason6345] [~novakov.alex] have you found the

[jira] [Commented] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2023-12-02 Thread chenyuexin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792482#comment-17792482 ] chenyuexin commented on FLINK-22014: The same issue in my case with flink-1.15.4, we

[jira] [Comment Edited] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792458#comment-17792458 ] Sergey Nuyanzin edited comment on FLINK-33727 at 12/2/23 11:29 PM: ---

Re: [PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-02 Thread via GitHub
flinkbot commented on PR #23858: URL: https://github.com/apache/flink/pull/23858#issuecomment-1837279346 ## CI report: * da62de304dcaeef07bda7d8da7bfc082737b14fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33710] Prevent triggering cluster upgrades for permutations of the same overrides [flink-kubernetes-operator]

2023-12-02 Thread via GitHub
gyfora commented on code in PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1412894510 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -186,7

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792458#comment-17792458 ] Sergey Nuyanzin commented on FLINK-33727: - Seems these {{MySink}} is kind of "st

[jira] [Comment Edited] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792458#comment-17792458 ] Sergey Nuyanzin edited comment on FLINK-33727 at 12/2/23 11:23 PM: ---

[jira] [Updated] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33727: --- Labels: pull-request-available test-stability (was: test-stability) > JoinRestoreTest is fa

[PR] [FLINK-33727][table] Use different sink names for restore tests [flink]

2023-12-02 Thread via GitHub
snuyanzin opened a new pull request, #23858: URL: https://github.com/apache/flink/pull/23858 ## What is the purpose of the change In restore tests there is `MySink` name for sinks and it seems to be the problem for restore tests. For more details see jira. The PR just renames

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792449#comment-17792449 ] Sergey Nuyanzin commented on FLINK-33727: - I don't think it is related to concur

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-02 Thread via GitHub
jnh5y commented on PR #23680: URL: https://github.com/apache/flink/pull/23680#issuecomment-1837217788 > @dawidwys @jnh5y after merging this ci on master failed 4 times out of 6 e.g. > > ``` > Dec 02 04:42:26 04:42:26.408 [ERROR] Failures: > Dec 02 04:42:26 04:42:26.408 [ERROR]

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792413#comment-17792413 ] Jim Hughes commented on FLINK-33727: >From a quick look, the data is coming from `De

[jira] [Updated] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33727: Description: Since {{JoinRestoreTest}} was introduced in FLINK-33470 it seems to be a reas

[jira] [Commented] (FLINK-32986) The new createTemporaryFunction has some regression of type inference compare to the deprecated registerFunction

2023-12-02 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792406#comment-17792406 ] Jeyhun Karimov commented on FLINK-32986: Hi [~lincoln.86xy]  could you please as

[jira] [Commented] (FLINK-31481) Support enhanced show databases syntax

2023-12-02 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792404#comment-17792404 ] Jeyhun Karimov commented on FLINK-31481: Hi [~taoran] could you please assign th

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2023-12-02 Thread via GitHub
flinkbot commented on PR #23857: URL: https://github.com/apache/flink/pull/23857#issuecomment-1837186832 ## CI report: * b7f62e249f5ad4280b0a994bf87ef64323d2dee3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2023-12-02 Thread via GitHub
JingGe opened a new pull request, #23857: URL: https://github.com/apache/flink/pull/23857 ## What is the purpose of the change refactoring to template method to separate concerns ## Verifying this change This change is already covered by existing tests, such as TableauSty

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-02 Thread via GitHub
JingGe commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1412809280 ## docs/content.zh/docs/deployment/filesystems/gcs.md: ## @@ -44,7 +44,10 @@ env.readTextFile("gs:///"); stream.writeAsText("gs:///"); // Use GCS as checkpoint stora

[jira] [Commented] (FLINK-33240) Generate docs for deprecated options as well

2023-12-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792394#comment-17792394 ] Jing Ge commented on FLINK-33240: - please check FLINK-30862 for some objections. > Gene

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792391#comment-17792391 ] Sergey Nuyanzin commented on FLINK-33727: - [~dwysakowicz], [~jhughes] could you

[jira] [Created] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-02 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33727: --- Summary: JoinRestoreTest is failing on AZP Key: FLINK-33727 URL: https://issues.apache.org/jira/browse/FLINK-33727 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-02 Thread via GitHub
snuyanzin commented on PR #23680: URL: https://github.com/apache/flink/pull/23680#issuecomment-1837157958 @dawidwys @jnh5y after merging this ci on master failed 4 times out of 6 e.g. ``` Dec 02 04:42:26 04:42:26.408 [ERROR] Failures: Dec 02 04:42:26 04:42:26.408 [ERROR] JoinR

[jira] [Commented] (FLINK-33190) [Umbrella]Externalized Connectors should directly depend on 3rd-party libs instead of shaded repo

2023-12-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792386#comment-17792386 ] Jing Ge commented on FLINK-33190: - [~martijnvisser] thanks for the hint! > [Umbrella]Ex

[jira] [Closed] (FLINK-33193) JDBC Connector should directly depend on 3rd-party libs instead of flink-shaded repo

2023-12-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge closed FLINK-33193. --- Resolution: Won't Fix > JDBC Connector should directly depend on 3rd-party libs instead of > flink-shaded r

[jira] [Closed] (FLINK-33195) ElasticSearch Connector should directly depend on 3rd-party libs instead of flink-shaded repo

2023-12-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge closed FLINK-33195. --- Resolution: Won't Fix > ElasticSearch Connector should directly depend on 3rd-party libs instead of > flink

[jira] [Updated] (FLINK-33698) Fix the backoff time calculation in ExponentialBackoffDelayRetryStrategy

2023-12-02 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33698: - Description: The backoff time calculation in `ExponentialBackoffDelayRetryStrategy` is problema

[jira] [Updated] (FLINK-33698) Fix the backoff time calculation in ExponentialBackoffDelayRetryStrategy

2023-12-02 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33698: - Description: The backoff time calculation in `ExponentialBackoffDelayRetryStrategy` should cons

Re: [PR] [FLINK-33710] Prevent triggering cluster upgrades for permutations of the same overrides [flink-kubernetes-operator]

2023-12-02 Thread via GitHub
afedulov commented on code in PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1412799765 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -180

[jira] [Updated] (FLINK-33684) Improve the retry strategy in CollectResultFetcher

2023-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33684: --- Labels: pull-request-available (was: ) > Improve the retry strategy in CollectResultFetcher

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-02 Thread via GitHub
1996fanrui commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1412799696 ## docs/content/docs/ops/state/task_failure_recovery.md: ## @@ -117,11 +116,11 @@ The fixed delay restart strategy can also be set programmatically: {{< tabs "73f5

Re: [PR] [FLINK-33684] Use IncrementalDelayRetryStrategy in CollectResultFetcher [flink]

2023-12-02 Thread via GitHub
flinkbot commented on PR #23856: URL: https://github.com/apache/flink/pull/23856#issuecomment-1837148341 ## CI report: * 7a0b6a4637b823329768e45f0f156051dfa05356 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Flink 33684 [flink]

2023-12-02 Thread via GitHub
xiangyuf opened a new pull request, #23856: URL: https://github.com/apache/flink/pull/23856 ## What is the purpose of the change Currently `CollectResultFetcher` uses a fixed retry interval. This can be improved with `IncrementalDelayRetryStrategy`. `IncrementalDelayRetryStrateg

Re: [PR] [FLINK-33669][doc] Update the documentation for RestartStrategy, Checkpoint Storage, and State Backend. [flink]

2023-12-02 Thread via GitHub
1996fanrui commented on code in PR #23847: URL: https://github.com/apache/flink/pull/23847#discussion_r1412797465 ## docs/content.zh/docs/ops/state/task_failure_recovery.md: ## @@ -49,20 +49,18 @@ Flink 作业如果没有定义重启策略,则会遵循集群启动时加载 {{< generated/restart_strategy_configuration >}}

Re: [PR] [FLINK-33536] Fix Flink Table API CSV streaming sink fails with IOException: Stream closed [flink]

2023-12-02 Thread via GitHub
Samrat002 commented on PR #23725: URL: https://github.com/apache/flink/pull/23725#issuecomment-1837144127 @PrabhuJoseph Please review whenever time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-16175][table sql/ api][WIP]Add config option to switch case sensitive for column names in SQL [flink]

2023-12-02 Thread via GitHub
leonardBang closed pull request #11535: [FLINK-16175][table sql/ api][WIP]Add config option to switch case sensitive for column names in SQL URL: https://github.com/apache/flink/pull/11535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (FLINK-33625) FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-12-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33625. - Resolution: Fixed > FLIP-390: Support System out and err to be redirected to LOG or discarded >

[jira] [Commented] (FLINK-33625) FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-12-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792364#comment-17792364 ] Rui Fan commented on FLINK-33625: - Merged master<1.19.0> via: 186ed0eb0449a7bf3c21606779

Re: [PR] [FLINK-33625][runtime] Support System out and err to be redirected to LOG or discarded [flink]

2023-12-02 Thread via GitHub
1996fanrui merged PR #23800: URL: https://github.com/apache/flink/pull/23800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-12-02 Thread via GitHub
MartijnVisser commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-1837112592 I'll run the S3 tests locally before merging it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Updated] (FLINK-33726) Print cost time for stream queries in SQL Client

2023-12-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33726: Description: The time cost information is expected when executing stream queries in SQL CLI.  For example

[jira] [Created] (FLINK-33726) Print cost time for stream queries in SQL Client

2023-12-02 Thread Jing Ge (Jira)
Jing Ge created FLINK-33726: --- Summary: Print cost time for stream queries in SQL Client Key: FLINK-33726 URL: https://issues.apache.org/jira/browse/FLINK-33726 Project: Flink Issue Type: Improvemen

[jira] [Commented] (FLINK-33600) Print cost time for batch queries in SQL Client

2023-12-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792356#comment-17792356 ] Jing Ge commented on FLINK-33600: - master: c20c13fb5cb78eff2cbd08ea48f1cb7cf9a1981c > P

[jira] [Resolved] (FLINK-33600) Print cost time for batch queries in SQL Client

2023-12-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33600. - Resolution: Fixed > Print cost time for batch queries in SQL Client > --

Re: [PR] FLINK-33600][table] print the query time cost for batch query in cli [flink]

2023-12-02 Thread via GitHub
JingGe merged PR #23809: URL: https://github.com/apache/flink/pull/23809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-33534) PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar submission request

2023-12-02 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792351#comment-17792351 ] Gyula Fora commented on FLINK-33534: I assigned it to you! I haven’t tried to repro

[jira] [Assigned] (FLINK-33534) PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar submission request

2023-12-02 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33534: -- Assignee: Yunfeng Zhou > PipelineOptions.PARALLELISM_OVERRIDES is not picked up from jar subm