[jira] [Commented] (FLINK-32807) when i use emitUpdateWithRetract of udtagg,bug error

2023-11-08 Thread yong yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784307#comment-17784307 ] yong yang commented on FLINK-32807: --- yes it is duplicated > when i use emitUpdateWith

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-08 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1383243917 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResource

Re: [PR] [FLINK-33023][table-planner][JUnit5 Migration] Module: flink-table-planner (TableTestBase) [flink]

2023-11-08 Thread via GitHub
xuyangzhong commented on PR #23349: URL: https://github.com/apache/flink/pull/23349#issuecomment-1803283116 LGTM. cc @leonardBang for the final check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-08 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387577165 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java: ## @@ -842,6 +844,85 @@ private void disposeSavepoint( logAndSysout("Savepoint '"

[jira] [Updated] (FLINK-33490) Validate the name conflicts when creating view

2023-11-08 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-33490: -- Description: We should forbid ``` CREATE VIEW id_view AS SELECT id, uid AS id FROM id_table

[jira] [Created] (FLINK-33490) Validate the name conflicts when creating view

2023-11-08 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-33490: - Summary: Validate the name conflicts when creating view Key: FLINK-33490 URL: https://issues.apache.org/jira/browse/FLINK-33490 Project: Flink Issue Type:

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-08 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387573143 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java: ## @@ -611,6 +636,22 @@ public static void printHelpForSavepoint(Collection customCo

Re: [PR] [FLINK-6755][CLI] Support manual checkpoints triggering [flink]

2023-11-08 Thread via GitHub
Zakelly commented on code in PR #23679: URL: https://github.com/apache/flink/pull/23679#discussion_r1387572052 ## docs/content.zh/docs/deployment/cli.md: ## @@ -153,6 +153,35 @@ $ ./bin/flink savepoint \ Triggering the savepoint disposal through the `savepoint` action does not

[jira] [Commented] (FLINK-32807) when i use emitUpdateWithRetract of udtagg,bug error

2023-11-08 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784297#comment-17784297 ] xuyang commented on FLINK-32807: Hi, [~luca.yang] . I think this issue is duplicated wit

Re: [PR] [FLINK-33358][sql] Fix Flink SQL Client fail to start in Flink on YARN [flink]

2023-11-08 Thread via GitHub
PrabhuJoseph commented on PR #23629: URL: https://github.com/apache/flink/pull/23629#issuecomment-1803208444 @fsk119 Please review this patch when you have time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (FLINK-33262) Extend source provider interfaces with the new parallelism provider interface

2023-11-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33262. Fix Version/s: 1.19.0 Resolution: Implemented merged via 55162dcc5cca6db6aeedddb30d80dd9f9b

Re: [PR] [FLINK-33262][table-api] Extend source provider interfaces with the new parallelism provider interface [flink]

2023-11-08 Thread via GitHub
libenchao closed pull request #23663: [FLINK-33262][table-api] Extend source provider interfaces with the new parallelism provider interface URL: https://github.com/apache/flink/pull/23663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-11-08 Thread via GitHub
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1803157270 rebased. @Zakelly Could you also help to take a look ? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-20672) notifyCheckpointAborted RPC failure can fail JM

2023-11-08 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784274#comment-17784274 ] Zakelly Lan commented on FLINK-20672: - [~yunta] A fatal exit for uncaught exception

Re: [PR] [FLINK-33489][table-planner] forbid generating partial-final agg with LISTAGG to avoid wrong result [flink]

2023-11-08 Thread via GitHub
flinkbot commented on PR #23688: URL: https://github.com/apache/flink/pull/23688#issuecomment-1803149601 ## CI report: * 36da81aa605a7d8f29f80ceac070b7f673ccead6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33489) LISTAGG with generating partial-final agg will cause wrong result

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33489: --- Labels: pull-request-available (was: ) > LISTAGG with generating partial-final agg will cau

[PR] [FLINK-33489][table-planner] forbid generating partial-final agg with LISTAGG to avoid wrong result [flink]

2023-11-08 Thread via GitHub
xuyangzhong opened a new pull request, #23688: URL: https://github.com/apache/flink/pull/23688 ## What is the purpose of the change Currently LISTAGG with splitting original agg to final-partial agg will cause wrong result. This pr is for a quick fix to avoid splitting with it.

[jira] [Assigned] (FLINK-33489) LISTAGG with generating partial-final agg will cause wrong result

2023-11-08 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-33489: - Assignee: xuyang > LISTAGG with generating partial-final agg will cause wrong result >

Re: [PR] [FLINK-33023][table-planner][JUnit5 Migration] Module: flink-table-planner (TableTestBase) [flink]

2023-11-08 Thread via GitHub
Jiabao-Sun commented on PR #23349: URL: https://github.com/apache/flink/pull/23349#issuecomment-1803143808 > Thank for your huge contribution about replacing junit4 with junit5 in table-planner module. The whole pr looks good to me. I mainly have two confusion. > > 1. Is it a good ti

[jira] [Updated] (FLINK-33489) LISTAGG with generating partial-final agg will cause wrong result

2023-11-08 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-33489: --- Summary: LISTAGG with generating partial-final agg will cause wrong result (was: LISTAGG with generating pa

[jira] [Commented] (FLINK-33489) LISTAGG with generating partial-final agg will case wrong result

2023-11-08 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784273#comment-17784273 ] xuyang commented on FLINK-33489: For a quick fix, we can forbid generating final-partial

[jira] [Created] (FLINK-33489) LISTAGG with generating partial-final agg will case wrong result

2023-11-08 Thread xuyang (Jira)
xuyang created FLINK-33489: -- Summary: LISTAGG with generating partial-final agg will case wrong result Key: FLINK-33489 URL: https://issues.apache.org/jira/browse/FLINK-33489 Project: Flink Issue T

Re: [PR] [FLINK-19931] Do not emit intermediate results for reduce operation BATCH execution mode [flink]

2023-11-08 Thread via GitHub
WencongLiu commented on code in PR #13890: URL: https://github.com/apache/flink/pull/13890#discussion_r1387456047 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BatchGroupedReduceOperator.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache So

Re: [PR] [FLINK-26694][table] Support lookup join via a multi-level inheritance of TableFunction [flink]

2023-11-08 Thread via GitHub
YesOrNo828 commented on PR #23684: URL: https://github.com/apache/flink/pull/23684#issuecomment-1803119191 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-11-08 Thread via GitHub
xuyangzhong commented on PR #23519: URL: https://github.com/apache/flink/pull/23519#issuecomment-1803115628 @snuyanzin Hi, could you do the final check about this pr if you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-33488] Implement restore tests for Deduplicate node [flink]

2023-11-08 Thread via GitHub
jnh5y commented on code in PR #23686: URL: https://github.com/apache/flink/pull/23686#discussion_r1387440826 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/DeduplicationTestPrograms.java: ## @@ -0,0 +1,151 @@ +/* + * Licens

Re: [PR] [FLINK-33398][runtime] Support switching from batch to stream mode for one input stream operator [flink]

2023-11-08 Thread via GitHub
yunfengzhou-hub commented on code in PR #23521: URL: https://github.com/apache/flink/pull/23521#discussion_r1387397501 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordAttributesValve.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Softw

[jira] [Resolved] (FLINK-26585) State Processor API: Loading a state set buffers the whole state set in memory before starting to process

2023-11-08 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-26585. -- Fix Version/s: 1.19.0 Resolution: Fixed merged eb4ae5d4 into master > State Processor

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-08 Thread via GitHub
masteryhx closed pull request #23239: [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation URL: https://github.com/apache/flink/pull/23239 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-11-08 Thread via GitHub
masteryhx closed pull request #23683: fixup! [FLINK-33060][state] Fix the javadoc of ListState interfaces about not allowing null value URL: https://github.com/apache/flink/pull/23683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Comment Edited] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-08 Thread xiang1 yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783891#comment-17783891 ] xiang1 yu edited comment on FLINK-25538 at 11/9/23 2:09 AM:

[jira] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-08 Thread xiang1 yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25538 ] xiang1 yu deleted comment on FLINK-25538: --- was (Author: JIRAUSER302279):  I just submit a PR of this issue.If you have time, could you please help review it?  https://github.com/apache/flink-c

Re: [PR] [FLINK-27286] Add infra to support training high dimension models [flink-ml]

2023-11-08 Thread via GitHub
zhipeng93 closed pull request #251: [FLINK-27286] Add infra to support training high dimension models URL: https://github.com/apache/flink-ml/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2023-11-08 Thread xiang1 yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784245#comment-17784245 ] xiang1 yu commented on FLINK-25538: ---  I just submit a PR of this issue.If you have tim

[PR] [FLINK-25538][flink-connector-kafka] JUnit5 Migration [flink-connector-kafka]

2023-11-08 Thread via GitHub
victor09091 opened a new pull request, #66: URL: https://github.com/apache/flink-connector-kafka/pull/66 ## What is the purpose of the change * [JUnit5 Migration] Module: flink-connector-kafka. * ## Brief change log - *Updated simple junit 4 test packages to

Re: [PR] [FLINK-25538][flink-connector-kafka] JUnit5 Migration [flink-connector-kafka]

2023-11-08 Thread via GitHub
boring-cyborg[bot] commented on PR #66: URL: https://github.com/apache/flink-connector-kafka/pull/66#issuecomment-1803027215 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

Re: [PR] [FLINK-33402] Hybrid Source Concurrency Race Condition Fixes and Related Bugs Results in Data Loss [flink]

2023-11-08 Thread via GitHub
varun1729DD commented on PR #23687: URL: https://github.com/apache/flink/pull/23687#issuecomment-1802979312 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Commented] (FLINK-33402) Hybrid Source Concurrency Race Condition Fixes and Related Bugs Results in Data Loss

2023-11-08 Thread Varun Narayanan Chakravarthy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784240#comment-17784240 ] Varun Narayanan Chakravarthy commented on FLINK-33402: -- Created a P

Re: [PR] [FLINK-33402] Hybrid Source Concurrency Race Condition Fixes and Related Bugs Results in Data Loss [flink]

2023-11-08 Thread via GitHub
flinkbot commented on PR #23687: URL: https://github.com/apache/flink/pull/23687#issuecomment-1802964699 ## CI report: * 49b72ea82160e6c20daf10c4391ace307349317c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33402) Hybrid Source Concurrency Race Condition Fixes and Related Bugs Results in Data Loss

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33402: --- Labels: pull-request-available (was: ) > Hybrid Source Concurrency Race Condition Fixes and

[PR] [FLINK-33402] Hybrid Source Concurrency Race Condition Fixes and Related Bugs Results in Data Loss [flink]

2023-11-08 Thread via GitHub
varun1729DD opened a new pull request, #23687: URL: https://github.com/apache/flink/pull/23687 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring the

[jira] [Updated] (FLINK-33132) Flink Connector Redshift Sink Implementation

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33132: --- Labels: in-progress pull-request-available (was: in-progress) > Flink Connector Redshift Si

[PR] [WIP][FLINK-33132] Flink Connector Redshift Sink Implementation [flink-connector-aws]

2023-11-08 Thread via GitHub
Samrat002 opened a new pull request, #114: URL: https://github.com/apache/flink-connector-aws/pull/114 ## Purpose of the change Flink Connector Redshift Sink Implementation ## Verifying this change - To Do ## Significant changes *(Please check any boxes [x] if t

[jira] [Updated] (FLINK-33132) Flink Connector Redshift Sink Implementation

2023-11-08 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-33132: --- Labels: (was: pull-request-available) > Flink Connector Redshift Sink Implementation > --

[jira] [Updated] (FLINK-33132) Flink Connector Redshift Sink Implementation

2023-11-08 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-33132: --- Labels: in-progress (was: ) > Flink Connector Redshift Sink Implementation > -

[jira] [Updated] (FLINK-33132) Flink Connector Redshift Sink Implementation

2023-11-08 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-33132: --- Component/s: Connectors / AWS > Flink Connector Redshift Sink Implementation >

Re: [PR] [FLINK-33488] Implement restore tests for Deduplicate node [flink]

2023-11-08 Thread via GitHub
flinkbot commented on PR #23686: URL: https://github.com/apache/flink/pull/23686#issuecomment-1802808057 ## CI report: * 9a3424757010142c5a5cea666861b31277a06f41 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33488) Implement restore tests for Deduplicate node

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33488: --- Labels: pull-request-available (was: ) > Implement restore tests for Deduplicate node > ---

[PR] [FLINK-33488] Implement restore tests for Deduplicate node [flink]

2023-11-08 Thread via GitHub
jnh5y opened a new pull request, #23686: URL: https://github.com/apache/flink/pull/23686 ## What is the purpose of the change Implement restore tests for Deduplicate node ## Verifying this change This change added tests and can be verified as follows: * Added resto

[jira] [Updated] (FLINK-33402) Hybrid Source Concurrency Race Condition Fixes and Related Bugs Results in Data Loss

2023-11-08 Thread Varun Narayanan Chakravarthy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Narayanan Chakravarthy updated FLINK-33402: - Priority: Critical (was: Blocker) > Hybrid Source Concurrency R

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-08 Thread via GitHub
tagarr commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1802587767 Hi @gaborgsomogyi I didn't appreciate that there could be 100's or more of FlinkDeployments running on a cluster. If that's the case then my solution wouldn't be the best.

[jira] [Created] (FLINK-33488) Implement restore tests for Deduplicate node

2023-11-08 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33488: -- Summary: Implement restore tests for Deduplicate node Key: FLINK-33488 URL: https://issues.apache.org/jira/browse/FLINK-33488 Project: Flink Issue Type: Sub-task

[jira] [Comment Edited] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-08 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784174#comment-17784174 ] Trystan edited comment on FLINK-29288 at 11/8/23 7:37 PM: -- Yes,

[jira] [Comment Edited] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-08 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784174#comment-17784174 ] Trystan edited comment on FLINK-29288 at 11/8/23 7:36 PM: -- Yes,

[jira] [Created] (FLINK-33487) Add the new Snowflake connector to supported list

2023-11-08 Thread Mohsen Rezaei (Jira)
Mohsen Rezaei created FLINK-33487: - Summary: Add the new Snowflake connector to supported list Key: FLINK-33487 URL: https://issues.apache.org/jira/browse/FLINK-33487 Project: Flink Issue Typ

[jira] [Updated] (FLINK-33487) Add the new Snowflake connector to supported list

2023-11-08 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohsen Rezaei updated FLINK-33487: -- Description: Code was contributed in FLINK-32737. Add this new connector to the list of suppo

[jira] [Commented] (FLINK-29288) Can't start a job with a jar in the system classpath

2023-11-08 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784174#comment-17784174 ] Trystan commented on FLINK-29288: - Yes, two different kinds of errors. flink-kubernetes-

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-08 Thread via GitHub
jnh5y commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1386993678 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-08 Thread via GitHub
jnh5y commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1386985040 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to

Re: [PR] [FLINK-33469] Implement restore tests for Limit node [flink]

2023-11-08 Thread via GitHub
jnh5y commented on PR #23675: URL: https://github.com/apache/flink/pull/23675#issuecomment-1802331893 Responded to comments and moved the new tests to the package `org.apache.flink.table.planner.plan.nodes.exec.stream`. (Relative to the discussion over on https://github.com/apache/flink/pu

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-08 Thread via GitHub
jnh5y commented on PR #23660: URL: https://github.com/apache/flink/pull/23660#issuecomment-1802323981 > > Can we reuse org.apache.flink.table.planner.plan.nodes.exec.stream since we are removing tests from that package? > > Yes, let's do that Should the Programs and Tests go in

[jira] [Created] (FLINK-33486) Pulsar Client Send Timeout Terminates TaskManager

2023-11-08 Thread Jason Kania (Jira)
Jason Kania created FLINK-33486: --- Summary: Pulsar Client Send Timeout Terminates TaskManager Key: FLINK-33486 URL: https://issues.apache.org/jira/browse/FLINK-33486 Project: Flink Issue Type: B

[jira] [Closed] (FLINK-33295) Separate SinkV2 and SinkV1Adapter tests

2023-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-33295. -- Resolution: Implemented [{{92951a0}}|https://github.com/apache/flink/commit/92951a05127f1e0e2a

[jira] [Updated] (FLINK-33295) Separate SinkV2 and SinkV1Adapter tests

2023-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi updated FLINK-33295: --- Fix Version/s: 1.19.0 > Separate SinkV2 and SinkV1Adapter tests > --

Re: [PR] [FLINK-33295] Separate SinkV2 and SinkV1Adapter tests [flink]

2023-11-08 Thread via GitHub
mbalassi merged PR #23541: URL: https://github.com/apache/flink/pull/23541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-33059] Support transparent compression for file-connector for all file input formats [flink]

2023-11-08 Thread via GitHub
echauchot commented on PR #23443: URL: https://github.com/apache/flink/pull/23443#issuecomment-1802266251 @ferenc-csaky thanks for reviewing this PR ! I have addressed your comments, do I have your LGTM when the tests pass ? -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-33059] Support transparent compression for file-connector for all file input formats [flink]

2023-11-08 Thread via GitHub
echauchot commented on PR #23443: URL: https://github.com/apache/flink/pull/23443#issuecomment-1802261114 > The added logic makes sense IMO. > > Added 2 comments, but in general I would consider separating the whole `INFLATER_INPUT_STREAM_FACTORIES` into a new class as there are a cou

Re: [PR] [FLINK-26203] Add docs for the table connector [flink-connector-pulsar]

2023-11-08 Thread via GitHub
tisonkun merged PR #63: URL: https://github.com/apache/flink-connector-pulsar/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [FLINK-33059] Support transparent compression for file-connector for all file input formats [flink]

2023-11-08 Thread via GitHub
echauchot commented on code in PR #23443: URL: https://github.com/apache/flink/pull/23443#discussion_r1386887535 ## flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java: ## @@ -136,6 +138,26 @@ public static String createTempFileDirExtension( return f.

Re: [PR] [FLINK-33059] Support transparent compression for file-connector for all file input formats [flink]

2023-11-08 Thread via GitHub
echauchot commented on code in PR #23443: URL: https://github.com/apache/flink/pull/23443#discussion_r1386874406 ## flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java: ## @@ -157,6 +157,10 @@ protected static InflaterInputStreamFactory getInflaterInput

Re: [PR] [FLINK-33059] Support transparent compression for file-connector for all file input formats [flink]

2023-11-08 Thread via GitHub
echauchot commented on code in PR #23443: URL: https://github.com/apache/flink/pull/23443#discussion_r1386875062 ## flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java: ## @@ -157,6 +157,10 @@ protected static InflaterInputStreamFactory getInflaterInput

Re: [PR] [FLINK-33059] Support transparent compression for file-connector for all file input formats [flink]

2023-11-08 Thread via GitHub
ferenc-csaky commented on code in PR #23443: URL: https://github.com/apache/flink/pull/23443#discussion_r1386659760 ## flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java: ## @@ -157,6 +157,10 @@ protected static InflaterInputStreamFactory getInflaterIn

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-08 Thread via GitHub
dawidwys commented on PR #23660: URL: https://github.com/apache/flink/pull/23660#issuecomment-1801918003 > Can we reuse org.apache.flink.table.planner.plan.nodes.exec.stream since we are removing tests from that package? Yes, let's do that -- This is an automated message from the A

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-11-08 Thread via GitHub
dawidwys commented on code in PR #23680: URL: https://github.com/apache/flink/pull/23680#discussion_r1386592611 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/JoinJsonPlanTest.java: ## @@ -1,144 +0,0 @@ -/* - * Licensed to

Re: [PR] [FLINK-33485][table] Optimize exists subqueries by looking at metadata rowcount [flink]

2023-11-08 Thread via GitHub
flinkbot commented on PR #23685: URL: https://github.com/apache/flink/pull/23685#issuecomment-1801904915 ## CI report: * 2bcb47ade877cb2fba533001c3ce7c9d3788c9dc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 1:33 PM: --- Bu

[jira] [Updated] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-33483: - Attachment: reproduce.log > Why is “UNDEFINED” defined in the Flink task status? > -

[PR] [FLINK-33485][table] Optimize exists subqueries by looking at metadata rowcount [flink]

2023-11-08 Thread via GitHub
snuyanzin opened a new pull request, #23685: URL: https://github.com/apache/flink/pull/23685 ## What is the purpose of the change The idea is to look at metadata rowcount for `EXISTS` subqueries and based on this take a decision whether it could be optimized to `TRUE`/`FALSE` #

[jira] [Updated] (FLINK-33485) Optimize the EXISTS sub-query by Metadata RowCount

2023-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33485: --- Labels: pull-request-available (was: ) > Optimize the EXISTS sub-query by Metadata RowCount

[jira] [Assigned] (FLINK-33485) Optimize the EXISTS sub-query by Metadata RowCount

2023-11-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33485: --- Assignee: Sergey Nuyanzin > Optimize the EXISTS sub-query by Metadata RowCount > --

[jira] [Created] (FLINK-33485) Optimize the EXISTS sub-query by Metadata RowCount

2023-11-08 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33485: --- Summary: Optimize the EXISTS sub-query by Metadata RowCount Key: FLINK-33485 URL: https://issues.apache.org/jira/browse/FLINK-33485 Project: Flink Issu

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784027#comment-17784027 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:50 PM:

[jira] [Commented] (FLINK-20672) notifyCheckpointAborted RPC failure can fail JM

2023-11-08 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784035#comment-17784035 ] Yun Tang commented on FLINK-20672: -- [~Zakelly] Thanks for the information. If so, I hav

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:48 PM:

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:47 PM:

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:45 PM:

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784001#comment-17784001 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:44 PM:

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784027#comment-17784027 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:41 PM:

[jira] [Commented] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784027#comment-17784027 ] Xin Chen commented on FLINK-33483: -- *Biggest confusion is why Flink needs to design UND

Re: [PR] [FLINK-33469] Implement restore tests for Limit node [flink]

2023-11-08 Thread via GitHub
dawidwys commented on code in PR #23675: URL: https://github.com/apache/flink/pull/23675#discussion_r1386539479 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/LimitTestPrograms.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:28 PM:

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:27 PM:

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-08 Thread via GitHub
dawidwys commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1386534891 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:13 PM:

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:11 PM:

Re: [PR] [FLINK-32738][formats] PROTOBUF format supports projection push down [flink]

2023-11-08 Thread via GitHub
zhougit86 commented on PR #23323: URL: https://github.com/apache/flink/pull/23323#issuecomment-1801762669 > @zhougit86 Sorry, I'm a little busy recently. You can take a look at this [PR](https://github.com/apache/flink/pull/23162). There are some modifications to the logic of codegen and th

[jira] [Comment Edited] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen edited comment on FLINK-33483 at 11/8/23 12:06 PM:

[jira] [Commented] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784007#comment-17784007 ] Xin Chen commented on FLINK-33483: -- But in another scenario in production practice, UN

[jira] [Updated] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-33483: - Attachment: container_e15_1693914709123_8498_01_01_8042 > Why is “UNDEFINED” defined in the Flink ta

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-08 Thread via GitHub
Jiabao-Sun commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1801742466 Thanks @xuyangzhong and @leonardBang for the review. Could you help review it again when you have time? -- This is an automated message from the Apache Git Service. To

  1   2   >