[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779364#comment-17779364 ] Yun Tang commented on FLINK-33355: -- I think this is because you forgot to set the uid f

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779358#comment-17779358 ] Yun Tang commented on FLINK-33355: -- [~edmond_j] How did you assign the parallelism, by

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779359#comment-17779359 ] zhang commented on FLINK-33355: --- [~yunta] yes > can't reduce the parallelism from 'n' to

Re: [PR] [FLINK-32107] [Tests] Kubernetes test failed because ofunable to establish ssl connection to github on AZP [flink]

2023-10-24 Thread via GitHub
victor9309 commented on PR #23528: URL: https://github.com/apache/flink/pull/23528#issuecomment-1778610263 Thanks @XComp for the review. I test to execute the next attempt when it fails > can you double-check that wget works properly (i.e. returns an non-zero exit code) if ac

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779352#comment-17779352 ] zhang commented on FLINK-33355: --- [~yunta]  {code:java} StreamExecutionEnvironment env = S

[PR] Update iteration.md | Spelling [flink-ml]

2023-10-24 Thread via GitHub
as1605 opened a new pull request, #257: URL: https://github.com/apache/flink-ml/pull/257 Minor spelling and grammar change ## What is the purpose of the change Fixes spelling errors in the documentation ## Brief change log - `tarnsmitted` to `transmitted`

Re: [PR] add announcement blog post for Flink 1.18 [flink-web]

2023-10-24 Thread via GitHub
luoyuxia commented on code in PR #680: URL: https://github.com/apache/flink-web/pull/680#discussion_r1371212872 ## docs/content/posts/2023-10-10-release-1.18.0.md: ## @@ -0,0 +1,572 @@ +--- +authors: +- JingGe: + name: "Jing Ge" + twitter: jingengineer +- KonstantinKnauf: + n

Re: [PR] [FLINK-33357] add Apache Software License 2 [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
caicancai commented on PR #688: URL: https://github.com/apache/flink-kubernetes-operator/pull/688#issuecomment-177853 https://github.com/apache/flink-kubernetes-operator/assets/77189278/817ec9f0-eb8a-4ea3-bb56-99a4f3131b43";> Perform mvn clean install -DskipTests -Pgenerate-docs Th

Re: [PR] [FLINK-33357] add Apache Software License 2 [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
tisonkun commented on PR #688: URL: https://github.com/apache/flink-kubernetes-operator/pull/688#issuecomment-1778582314 ``` [INFO] [INFO] Reactor Summary for Flink Kubernetes: 1.7-SNAPSHOT: [INFO] [INFO]

Re: [PR] [FLINK-33357] add Apache Software License 2 [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
caicancai commented on PR #688: URL: https://github.com/apache/flink-kubernetes-operator/pull/688#issuecomment-1778580734 I am working on this cli issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779345#comment-17779345 ] Lijie Wang commented on FLINK-33356: [~Wencong Liu] Assigned to you. > The navigati

[jira] [Assigned] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-33356: -- Assignee: Wencong Liu > The navigation bar on Flink’s official website is messed up. > --

[jira] [Commented] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779341#comment-17779341 ] Junrui Li commented on FLINK-33356: --- [~Wencong Liu] Thank you for your volunteering, [

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779340#comment-17779340 ] Yun Tang commented on FLINK-33355: -- [~edmond_j] could you please share the code to repr

[jira] [Comment Edited] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779330#comment-17779330 ] Wencong Liu edited comment on FLINK-33356 at 10/25/23 5:58 AM: ---

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779336#comment-17779336 ] zhang commented on FLINK-33355: --- [~yunta]   I know that modifying the max parallelism is n

Re: [PR] [FLINK-30768] [Project Website] flink-web version cleanup [flink-web]

2023-10-24 Thread via GitHub
victor9309 commented on PR #683: URL: https://github.com/apache/flink-web/pull/683#issuecomment-1778542189 Thanks @XComp for the review. Thank you very much for your advice. ``` $ cat foo-utils.sh function foo() { echo 'foo...' >&2 exit 1 } $ cat foo-main.sh

[jira] [Assigned] (FLINK-33357) add Apache Software License 2

2023-10-24 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-33357: - Assignee: 蔡灿材 > add Apache Software License 2 > - > >

[jira] [Created] (FLINK-33358) Flink SQL Client fails to start in Flink on YARN

2023-10-24 Thread Prabhu Joseph (Jira)
Prabhu Joseph created FLINK-33358: - Summary: Flink SQL Client fails to start in Flink on YARN Key: FLINK-33358 URL: https://issues.apache.org/jira/browse/FLINK-33358 Project: Flink Issue Type

[jira] [Updated] (FLINK-33358) Flink SQL Client fails to start in Flink on YARN

2023-10-24 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph updated FLINK-33358: -- Description: Flink SQL Client fails to start in Flink on YARN with below error {code:java} fli

[jira] [Commented] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779330#comment-17779330 ] Wencong Liu commented on FLINK-33356: - Hello [~JunRuiLi] , I found this case is due

[jira] [Updated] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wencong Liu updated FLINK-33356: Attachment: image-2023-10-25-12-34-22-790.png > The navigation bar on Flink’s official website is

Re: [PR] [FLINK-33090][checkpointing] CheckpointsCleaner clean individual chec… [flink]

2023-10-24 Thread via GitHub
yigress commented on PR #23425: URL: https://github.com/apache/flink/pull/23425#issuecomment-1778479885 @pnowojski I rebased and it kicked off a rerun successfully. I also run some job for a day without problem. if looks good can you help merge it too? thank you so much! -- This is an au

[jira] [Updated] (FLINK-33357) add Apache Software License 2

2023-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33357: --- Labels: pull-request-available (was: ) > add Apache Software License 2 > --

[PR] [FLINK-33357] add Apache Software License 2 [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
caicancai opened a new pull request, #688: URL: https://github.com/apache/flink-kubernetes-operator/pull/688 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment` cu

[jira] [Created] (FLINK-33357) add Apache Software License 2

2023-10-24 Thread Jira
蔡灿材 created FLINK-33357: --- Summary: add Apache Software License 2 Key: FLINK-33357 URL: https://issues.apache.org/jira/browse/FLINK-33357 Project: Flink Issue Type: Improvement Components: Kub

[jira] [Commented] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779315#comment-17779315 ] Yun Tang commented on FLINK-33355: -- Changing the max-parallelism (instead of parallelis

[jira] [Closed] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-33355. Resolution: Information Provided > can't reduce the parallelism from 'n' to '1' when recovering through a

[jira] [Created] (FLINK-33356) The navigation bar on Flink’s official website is messed up.

2023-10-24 Thread Junrui Li (Jira)
Junrui Li created FLINK-33356: - Summary: The navigation bar on Flink’s official website is messed up. Key: FLINK-33356 URL: https://issues.apache.org/jira/browse/FLINK-33356 Project: Flink Issue

Re: [PR] [FLINK-33316][runtime] Avoid unnecessary heavy getStreamOperatorFactory [flink]

2023-10-24 Thread via GitHub
1996fanrui commented on code in PR #23550: URL: https://github.com/apache/flink/pull/23550#discussion_r1371104358 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java: ## @@ -368,7 +373,8 @@ public void setStreamOperator(StreamOperator ope

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module [flink]

2023-10-24 Thread via GitHub
Jiabao-Sun commented on PR #23572: URL: https://github.com/apache/flink/pull/23572#issuecomment-1778455547 Hi @RocMarshal, please help review it when you have time. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime [flink]

2023-10-24 Thread via GitHub
RocMarshal commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1778448738 > This PR is too huge to review. I will split it into multiple PRs. SGTM +1. Looking forward to it~ -- This is an automated message from the Apache Git Service. To respond t

[jira] [Created] (FLINK-33355) can't reduce the parallelism from 'n' to '1' when recovering through a savepoint.

2023-10-24 Thread zhang (Jira)
zhang created FLINK-33355: - Summary: can't reduce the parallelism from 'n' to '1' when recovering through a savepoint. Key: FLINK-33355 URL: https://issues.apache.org/jira/browse/FLINK-33355 Project: Flink

[jira] [Created] (FLINK-33354) Reuse the TaskInformation for multiple slots

2023-10-24 Thread Rui Fan (Jira)
Rui Fan created FLINK-33354: --- Summary: Reuse the TaskInformation for multiple slots Key: FLINK-33354 URL: https://issues.apache.org/jira/browse/FLINK-33354 Project: Flink Issue Type: Sub-task

[jira] [Comment Edited] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779300#comment-17779300 ] Xin Chen edited comment on FLINK-26603 at 10/25/23 2:58 AM:

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779300#comment-17779300 ] Xin Chen commented on FLINK-26603: -- [~luoyuxia] Ok,thank you very much. :D(y) > [Umbre

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779299#comment-17779299 ] luoyuxia commented on FLINK-26603: -- [~xinchen147] Yes, you're right. Nothing special to

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime [flink]

2023-10-24 Thread via GitHub
Jiabao-Sun closed pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime URL: https://github.com/apache/flink/pull/23200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-33315) Optimize memory usage of large StreamOperator

2023-10-24 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33315: Component/s: Runtime / Task > Optimize memory usage of large StreamOperator >

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime [flink]

2023-10-24 Thread via GitHub
Jiabao-Sun commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1778414947 This PR is too huge to review. I will split it into multiple PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-10-24 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779298#comment-17779298 ] Xin Chen commented on FLINK-26603: -- Hi, [~luoyuxia] Thank you. Yes, as the table-plann

[jira] [Updated] (FLINK-33315) Optimize memory usage of large StreamOperator

2023-10-24 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33315: Attachment: 130f436613b52b321bd9bd0211dd109f0b010220e860f292a13c0702016976850466192b.png > Optimize m

[jira] [Updated] (FLINK-33315) Optimize memory usage of large StreamOperator

2023-10-24 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33315: Description: Some of our batch jobs are upgraded from flink-1.15 to flink-1.17, and TM always fail with j

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
afedulov commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1778150546 > That being said, @afedulov, do you think it's worthwhile bringing up the new feature on the mailing list to discuss? This was my initial thought, yes. Ideally we do not want to i

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1778137755 @zentol thanks a lot for the review!! I addressed all comments from your first pass, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370875073 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* + *

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370869459 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OutputTypeConfigurable.java: ## @@ -27,7 +27,10 @@ * at {@link org.apache.flink.stream

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370869459 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OutputTypeConfigurable.java: ## @@ -27,7 +27,10 @@ * at {@link org.apache.flink.stream

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757489 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java: ## @@ -566,15 +567,15 @@ public void testMaxParallelismWithCo

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-24 Thread via GitHub
snuyanzin commented on PR #23519: URL: https://github.com/apache/flink/pull/23519#issuecomment-1778108982 thanks for the contribution in general it looks ok from my side i left a couple of minor comments -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-24 Thread via GitHub
snuyanzin commented on code in PR #23519: URL: https://github.com/apache/flink/pull/23519#discussion_r1370858120 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlRowOperator.java: ## @@ -66,12 +70,17 @@ * * * - * Once Flink applies sam

Re: [PR] [FLINK-20539][table-planner] fix type mismatch when using ROW in computed column [flink]

2023-10-24 Thread via GitHub
snuyanzin commented on code in PR #23519: URL: https://github.com/apache/flink/pull/23519#discussion_r1370857278 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlRowOperator.java: ## @@ -66,12 +70,17 @@ * * * - * Once Flink applies sam

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757728 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* + *

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370845998 ## flink-tests/pom.xml: ## @@ -284,6 +284,13 @@ under the License. test + + org.apache.

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370845998 ## flink-tests/pom.xml: ## @@ -284,6 +284,13 @@ under the License. test + + org.apache.

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370841305 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java: ## @@ -123,7 +12

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370841305 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java: ## @@ -123,7 +12

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370832543 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1188,14 +1191,14 @@ void testChainingOfOperators

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370824409 ## flink-formats/flink-parquet/src/test/resources/avro/user.avsc: ## @@ -1,9 +0,0 @@ -{ - "namespace": "org.apache.flink.connector.datagen.source.generated", - "type

Re: [PR] [FLINK-33121] Failed precondition in JobExceptionsHandler due to concurrent global failures [flink]

2023-10-24 Thread via GitHub
pgaref commented on PR #23440: URL: https://github.com/apache/flink/pull/23440#issuecomment-1778042754 Hey @dmvk -- thanks for the comments! 1. Was debating about that, however testing e2e would require to add the mocked AdaptiveScheduler dependency (like `ExceptionHistoryTester`) to

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1778020433 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1777990170 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370765358 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1161,9 +1163,10 @@ void testYieldingOperatorCha

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370762519 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* + *

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370762519 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* + *

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757864 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* + *

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757728 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,211 @@ +/* + *

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-10-24 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1370757489 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java: ## @@ -566,15 +567,15 @@ public void testMaxParallelismWithCo

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-10-24 Thread via GitHub
jeyhunkarimov commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1777952204 Hi @snuyanzin Could you please review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-33321][hotfix] VertexFlameGraphFactoryTest#verifyRecursively doesn't work on java 21 [flink]

2023-10-24 Thread via GitHub
snuyanzin merged PR #23583: URL: https://github.com/apache/flink/pull/23583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-32896][Runtime/Coordination] Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity [flink]

2023-10-24 Thread via GitHub
tzy-0x7cf commented on PR #23518: URL: https://github.com/apache/flink/pull/23518#issuecomment-1777866572 > Could squash the commits and rebase the branch to most-recent `master`? We don't want have merge commits cluttering the git history. > > The Flink CI bot is know

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on PR #23395: URL: https://github.com/apache/flink/pull/23395#issuecomment-1777847541 Thanks for the reviews - much appreciated 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on code in PR #23395: URL: https://github.com/apache/flink/pull/23395#discussion_r1370689647 ## flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowDataDeSerializationSchemaTest.java: ## @@ -222,12 +234,14 @@ void testSerializeDeseriali

Re: [PR] [FLINK-33058][formats] Add encoding option to Avro format [flink]

2023-10-24 Thread via GitHub
dalelane commented on code in PR #23395: URL: https://github.com/apache/flink/pull/23395#discussion_r1370649857 ## flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroDeserializationSchemaTest.java: ## @@ -37,46 +38,56 @@ class AvroDeserializationSchemaTest

Re: [PR] [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data [flink-connector-kafka]

2023-10-24 Thread via GitHub
tzulitai closed pull request #52: [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data URL: https://github.com/apache/flink-connector-kafka/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (FLINK-33187) Don't record duplicate event if no change

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779195#comment-17779195 ] Gyula Fora commented on FLINK-33187: merged to main faaff564e1bb3d8ca51c939d34dd4165

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
gyfora merged PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370455045 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -201,8 +201,8 @@ private static ConfigOptions.OptionB

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779150#comment-17779150 ] Jing Ge edited comment on FLINK-33301 at 10/24/23 3:45 PM: --- Th

[jira] [Updated] (FLINK-31863) Add 'Hostname' enum val to k8s NodeAddress type.

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31863: -- Fix Version/s: (was: 1.17.2) > Add 'Hostname' enum val to k8s NodeAddress type. >

[jira] [Updated] (FLINK-31601) While waiting for resources, resources check might be scheduled unlimited number of times (Adaptive Scheduler)

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31601: -- Fix Version/s: (was: 1.17.2) > While waiting for resources, resources check might be sched

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779101#comment-17779101 ] Jing Ge edited comment on FLINK-33301 at 10/24/23 3:45 PM: --- Th

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779150#comment-17779150 ] Jing Ge edited comment on FLINK-33301 at 10/24/23 3:44 PM: --- Th

[jira] [Updated] (FLINK-31875) OSS throwns NoClassDefFoundError due to old hadoop-common version

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31875: -- Fix Version/s: (was: 1.16.3) (was: 1.17.2) > OSS throwns NoClassDef

[jira] [Updated] (FLINK-30219) Fetch results api in sql gateway return error result.

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30219: -- Fix Version/s: (was: 1.16.3) > Fetch results api in sql gateway return error result. > ---

[jira] [Updated] (FLINK-33089) Drop Flink 1.13 and 1.14 support for the operator

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-33089: --- Description: As agreed with the community we will only support the last 4 stable Flink minor versio

[jira] [Updated] (FLINK-33089) Drop Flink 1.13 and 1.14 support for the operator

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-33089: --- Summary: Drop Flink 1.13 and 1.14 support for the operator (was: Drop Flink 1.13 support) > Drop F

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779150#comment-17779150 ] Jing Ge commented on FLINK-33301: - The value(my intention) is to fail faster before mave

[jira] [Created] (FLINK-33353) SQL fails because "TimestampType.kind" is not serialized

2023-10-24 Thread Ferenc Csaky (Jira)
Ferenc Csaky created FLINK-33353: Summary: SQL fails because "TimestampType.kind" is not serialized Key: FLINK-33353 URL: https://issues.apache.org/jira/browse/FLINK-33353 Project: Flink Iss

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
gyfora commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370421339 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventUtils.java: ## @@ -197,4 +198,19 @@ private static Event buil

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370421148 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -201,8 +201,8 @@ private static ConfigOptions.OptionB

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1370420200 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventUtils.java: ## @@ -197,4 +198,19 @@ private static Event buil

[jira] [Closed] (FLINK-33306) Use observed true processing rate when source metrics are incorrect

2023-10-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33306. -- Resolution: Fixed merged to main cc680e142bb8d52c4db215658ee7f4c4159a0fe4 > Use observed true process

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2023-10-24 Thread via GitHub
gyfora merged PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-33274][release] Add release note for version 1.18 [flink]

2023-10-24 Thread via GitHub
JingGe merged PR #23527: URL: https://github.com/apache/flink/pull/23527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-33341) Use available local state for rescaling

2023-10-24 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779129#comment-17779129 ] Stefan Richter commented on FLINK-33341: FYI, here is a link to the development

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779122#comment-17779122 ] Matthias Pohl commented on FLINK-33301: --- {quote} Yes, using pom to control the ver

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779122#comment-17779122 ] Matthias Pohl edited comment on FLINK-33301 at 10/24/23 2:52 PM: -

[jira] [Commented] (FLINK-33341) Use available local state for rescaling

2023-10-24 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779124#comment-17779124 ] Stefan Richter commented on FLINK-33341: [~Yanfei Lei], yes only the previous lo

Re: [PR] [FLINK-33352][rest][docs] Add schema mappings to discriminator properties [flink]

2023-10-24 Thread via GitHub
flinkbot commented on PR #23588: URL: https://github.com/apache/flink/pull/23588#issuecomment-1777387430 ## CI report: * 7a802e3654a0e6f2d68cad0deb6af0c4557f082b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   3   >