[GitHub] [flink] flinkbot commented on pull request #23002: Mark dataset related classes deprecated

flinkbot commented on PR #23002: URL: https://github.com/apache/flink/pull/23002#issuecomment-1636991057 ## CI report: * 3f12496c058303a194bcc38a0e5388f10634e1ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] WencongLiu opened a new pull request, #23002: Mark dataset related classes deprecated

WencongLiu opened a new pull request, #23002: URL: https://github.com/apache/flink/pull/23002 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Commented] (FLINK-32592) (Stream)ExEnv#initializeContextEnvironment isn't thread-safe

[ https://issues.apache.org/jira/browse/FLINK-32592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743495#comment-17743495 ] Fabio Wanner commented on FLINK-32592: -- Hey! Sorry for my late response and thanks

[GitHub] [flink] WencongLiu commented on pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on PR #22341: URL: https://github.com/apache/flink/pull/22341#issuecomment-1636989057 Thanks for your careful review 😄 @XComp. Sorry for the first round of pull request because it's a bit rough. Please take a look when you have time. -- This is an automated message fr

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264612108 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -575,12 +576,13 @@ private boolean isDuplicateJob(JobID jobId) throws Flin

[GitHub] [flink] 1996fanrui commented on pull request #22761: [FLINK-32298][network] Fix the bug that totalWrittenBytes of BufferWritingResultPartition misses some data

1996fanrui commented on PR #22761: URL: https://github.com/apache/flink/pull/22761#issuecomment-1636823753 Hi @akalash , I have followed the benchmark result, and I didn't found this pr effects them. And I will follow it again next week. -- This is an automated message from the Apa

[GitHub] [flink] flinkbot commented on pull request #23001: [FLINK-32578][table-planner] Fix wrong plan which group by window time columns on a proctime window operator may result hang for ever

flinkbot commented on PR #23001: URL: https://github.com/apache/flink/pull/23001#issuecomment-1636815553 ## CI report: * c9b752dc2f5c106e513ce1dc23da914e8fc2b180 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32578) Cascaded group by window time columns on a proctime window aggregate may result hang for ever

[ https://issues.apache.org/jira/browse/FLINK-32578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32578: --- Labels: pull-request-available (was: ) > Cascaded group by window time columns on a proctim

[GitHub] [flink] lincoln-lil opened a new pull request, #23001: [FLINK-32578][table-planner] Fix wrong plan which group by window time columns on a proctime window operator may result hang for ever

lincoln-lil opened a new pull request, #23001: URL: https://github.com/apache/flink/pull/23001 ## What is the purpose of the change Currently when group by window time columns on a proctime window operator result will get a wrong plan which may result hang for ever in runtime(this only h

[jira] [Created] (FLINK-32594) Use blocking ResultPartitionType if operator only outputs records on EOF (FLIP-331)

Dong Lin created FLINK-32594: Summary: Use blocking ResultPartitionType if operator only outputs records on EOF (FLIP-331) Key: FLINK-32594 URL: https://issues.apache.org/jira/browse/FLINK-32594 Project:

[GitHub] [flink] Myasuka commented on a diff in pull request #22767: [FLINK-31535][table] Extend watermark-related features for SQL

Myasuka commented on code in PR #22767: URL: https://github.com/apache/flink/pull/22767#discussion_r1264367897 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java: ## @@ -146,7 +146,18 @@ public final class FactoryUtil {

[GitHub] [flink] flinkbot commented on pull request #23000: [runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

flinkbot commented on PR #23000: URL: https://github.com/apache/flink/pull/23000#issuecomment-1636722337 ## CI report: * 56609726e9384710c192eeaa851525c574059515 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] RanJinh opened a new pull request, #23000: [runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

RanJinh opened a new pull request, #23000: URL: https://github.com/apache/flink/pull/23000 ## What is the purpose of the change This pull request allows using blocking ResultPartitionType in streaming execution mode if operator only outputs records on end of input. ## Brie

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264367896 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1251,7 +1253,20 @@ private CompletableFuture removeJob(JobID jobId, Clean

[jira] [Commented] (FLINK-23484) Add benchmarks for the ChangelogStateBackend

[ https://issues.apache.org/jira/browse/FLINK-23484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743364#comment-17743364 ] Yun Tang commented on FLINK-23484: -- merged on flink side: e59373443300b8eee348ee56adf

[GitHub] [flink] Myasuka merged pull request #22801: [FLINK-23484][benchmark] Supports base benchmark for ChangelogStateBackend

Myasuka merged PR #22801: URL: https://github.com/apache/flink/pull/22801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264365814 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreContractTest.java: ## @@ -35,6 +35,6 @@ public class FileSystemJobRe

[GitHub] [flink] lincoln-lil commented on a diff in pull request #22981: [FLINK-28743][table-planner] Supports validating the determinism for StreamPhysicalMatchRecognize

lincoln-lil commented on code in PR #22981: URL: https://github.com/apache/flink/pull/22981#discussion_r1264365364 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/NonDeterministicDagTest.scala: ## @@ -1582,6 +1582,87 @@ class Non

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264364274 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -548,7 +557,10 @@ public void testFatalErrorIfJobCannot

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264364321 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -579,10 +591,17 @@ public void testErrorHandlingIfJobCa

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264363969 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -332,11 +332,16 @@ public void testJobBeingMarkedAsDirty

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264363723 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -332,11 +332,16 @@ public void testJobBeingMarkedAsDirty

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264363543 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +43,67 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264363422 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java: ## @@ -44,64 +45,87 @@ public abstract class Abstract

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264361955 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -181,37 +188,70 @@ public void markResultAsCleanInterna

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264360912 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -181,37 +188,70 @@ public void markResultAsCleanInterna

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264360249 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java: ## @@ -77,7 +78,14 @@ public JobDispatcherLe

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264360150 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## Review Comment: Fixed. -- This is an

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264360094 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java: ## @@ -101,14 +109,9 @@ public static JobDis

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264360081 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +43,67 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264360063 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +43,67 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264359072 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +43,67 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264359023 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java: ## @@ -103,8 +103,8 @@ public static JobDisp

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1264354843 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java: ## @@ -44,64 +45,84 @@ public abstract class Abstract