[GitHub] [flink] luoyuxia commented on a diff in pull request #22977: [FLINK-32569][table] Fix the incomplete serialization of ResolvedCatalogTable caused by the newly introduced time travel interface

2023-07-13 Thread via GitHub
luoyuxia commented on code in PR #22977: URL: https://github.com/apache/flink/pull/22977#discussion_r1263367999 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPropertiesUtil.java: ## @@ -79,6 +80,11 @@ public static Map serializeCatalogTab

[jira] [Resolved] (FLINK-32020) Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288

2023-07-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-32020. --- Resolution: Fixed > Enable Dynamic Partition Discovery by Default in Kafka Source based on

[jira] [Resolved] (FLINK-31953) FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source

2023-07-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-31953. --- Resolution: Fixed > FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source

[jira] [Commented] (FLINK-32020) Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288

2023-07-13 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743029#comment-17743029 ] Qingsheng Ren commented on FLINK-32020: --- Merged to main: 811716c5155e82fa3bfc47ced

[GitHub] [flink-connector-kafka] PatrickRen closed pull request #40: [FLINK-32020] Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288

2023-07-13 Thread via GitHub
PatrickRen closed pull request #40: [FLINK-32020] Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288 URL: https://github.com/apache/flink-connector-kafka/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] jiaoqingbo commented on pull request #22992: [hotfix] Fix typo in JobManagerOptions

2023-07-13 Thread via GitHub
jiaoqingbo commented on PR #22992: URL: https://github.com/apache/flink/pull/22992#issuecomment-1635348356 My modification does not seem to be related to the CI error ,please cc @wanglijie95 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (FLINK-32335) Fix the Flink ML unittest failure

2023-07-13 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743010#comment-17743010 ] Dong Lin commented on FLINK-32335: -- Merged to apache/flink-ml master branch 892fb4714c6

[jira] [Resolved] (FLINK-32335) Fix the Flink ML unittest failure

2023-07-13 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved FLINK-32335. -- Resolution: Fixed > Fix the Flink ML unittest failure > - > >

[jira] [Commented] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743009#comment-17743009 ] Yunhong Zheng commented on FLINK-32579: --- Hi, [~jasonliangyc] . I got it. For ques

[jira] [Assigned] (FLINK-32335) Fix the Flink ML unittest failure

2023-07-13 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-32335: Assignee: Jiang Xin > Fix the Flink ML unittest failure > - > >

[GitHub] [flink-ml] lindong28 merged pull request #247: [FLINK-32335] Fix the ConcurrentModificationException in the unittest

2023-07-13 Thread via GitHub
lindong28 merged PR #247: URL: https://github.com/apache/flink-ml/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] lindong28 commented on pull request #247: [FLINK-32335] Fix the ConcurrentModificationException in the unittest

2023-07-13 Thread via GitHub
lindong28 commented on PR #247: URL: https://github.com/apache/flink-ml/pull/247#issuecomment-1635252080 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Created] (FLINK-32590) Fail to read flink parquet filesystem table stored in hive metastore service.

2023-07-13 Thread Guozhen Yang (Jira)
Guozhen Yang created FLINK-32590: Summary: Fail to read flink parquet filesystem table stored in hive metastore service. Key: FLINK-32590 URL: https://issues.apache.org/jira/browse/FLINK-32590 Project

[GitHub] [flink] flinkbot commented on pull request #22994: [FLINK-32354][table] Supports executing call procedure statement

2023-07-13 Thread via GitHub
flinkbot commented on PR #22994: URL: https://github.com/apache/flink/pull/22994#issuecomment-1635219756 ## CI report: * c7abe7f02a916120208e6f9b80513bf6b6385b9a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32354) Support to execute the call procedure operation

2023-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32354: --- Labels: pull-request-available (was: ) > Support to execute the call procedure operation >

[GitHub] [flink] luoyuxia opened a new pull request, #22994: [FLINK-32354][table] Supports executing call procedure statement

2023-07-13 Thread via GitHub
luoyuxia opened a new pull request, #22994: URL: https://github.com/apache/flink/pull/22994 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1263236647 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogOptions.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1263235270 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogOptions.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1263235270 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogOptions.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1263235270 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalogOptions.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1263233465 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/constants/AWSGlueConfigConstants.java: ## @@ -0,0 +1,48 @@ +/*

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1263232863 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/constants/AWSGlueConfigConstants.java: ## @@ -0,0 +1,48 @@ +/*

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1263232863 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/constants/AWSGlueConfigConstants.java: ## @@ -0,0 +1,48 @@ +/*

[jira] [Resolved] (FLINK-28743) Support validating the determinism for StreamPhysicalMatchRecognize

2023-07-13 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee resolved FLINK-28743. - Resolution: Fixed fixed in master: 8829b5e60a71b871462d1d2bb849c926b0de9b80 > Support validatin

[GitHub] [flink] lincoln-lil merged pull request #22981: [FLINK-28743][table-planner] Supports validating the determinism for StreamPhysicalMatchRecognize

2023-07-13 Thread via GitHub
lincoln-lil merged PR #22981: URL: https://github.com/apache/flink/pull/22981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] jiaoqingbo commented on pull request #22992: [hotfix] Fix typo in JobManagerOptions

2023-07-13 Thread via GitHub
jiaoqingbo commented on PR #22992: URL: https://github.com/apache/flink/pull/22992#issuecomment-1635163141 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Resolved] (FLINK-32481) Support type inference for procedure

2023-07-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-32481. -- Resolution: Fixed master: e5324c085f627df2f8e452b0aec3264fe0c6f6f6 > Support type inference for proc

[GitHub] [flink] luoyuxia merged pull request #22904: [FLINK-32481][table] Support type inference for procedure

2023-07-13 Thread via GitHub
luoyuxia merged PR #22904: URL: https://github.com/apache/flink/pull/22904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] luoyuxia commented on pull request #22904: [FLINK-32481][table] Support type inference for procedure

2023-07-13 Thread via GitHub
luoyuxia commented on PR #22904: URL: https://github.com/apache/flink/pull/22904#issuecomment-1635130068 @LadyForest Thanks for reviewing. Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Closed] (FLINK-32587) The results returned from the CDC sql query are null or the value was changed unexpectly

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jasonliangyc closed FLINK-32587. Resolution: Cannot Reproduce > The results returned from the CDC sql query are null or the value w

[jira] [Commented] (FLINK-31830) Coalesce on nested fields with different nullabilities will get wrong plan

2023-07-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742968#comment-17742968 ] Sergey Nuyanzin commented on FLINK-31830: - Thanks for the very detailed investig

[jira] [Closed] (FLINK-32585) Filter javax.xml.bind:jaxb-api false positive for Pulsar connector

2023-07-13 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-32585. - Resolution: Fixed master via d7a3b3847dc5c680b32d1997d448b7dac44e529c > Filter javax.xml.bind:jaxb-api

[GitHub] [flink] tisonkun merged pull request #22989: [FLINK-32585] Filter javax.xml.bind:jaxb-api false positive for Pulsar connector

2023-07-13 Thread via GitHub
tisonkun merged PR #22989: URL: https://github.com/apache/flink/pull/22989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] tisonkun commented on pull request #22989: [FLINK-32585] Filter javax.xml.bind:jaxb-api false positive for Pulsar connector

2023-07-13 Thread via GitHub
tisonkun commented on PR #22989: URL: https://github.com/apache/flink/pull/22989#issuecomment-1634654818 Emm..I think I should merge it now so that the SNAPSHOT can be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [flink] tisonkun commented on pull request #22989: [FLINK-32585] Filter javax.xml.bind:jaxb-api false positive for Pulsar connector

2023-07-13 Thread via GitHub
tisonkun commented on PR #22989: URL: https://github.com/apache/flink/pull/22989#issuecomment-1634653552 I'm going to merge this patch tomorrow and check if the Pulsar connector can pass with this patch. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [flink] flinkbot commented on pull request #22993: Bump okio from 1.17.2 to 3.4.0 in /flink-end-to-end-tests/flink-end-to-end-tests-sql

2023-07-13 Thread via GitHub
flinkbot commented on PR #22993: URL: https://github.com/apache/flink/pull/22993#issuecomment-1634603561 ## CI report: * c1ebb259b21f391fb12eae4d1dd2647e1dd90350 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] dependabot[bot] opened a new pull request, #22993: Bump okio from 1.17.2 to 3.4.0 in /flink-end-to-end-tests/flink-end-to-end-tests-sql

2023-07-13 Thread via GitHub
dependabot[bot] opened a new pull request, #22993: URL: https://github.com/apache/flink/pull/22993 Bumps [okio](https://github.com/square/okio) from 1.17.2 to 3.4.0. Changelog Sourced from https://github.com/square/okio/blob/master/CHANGELOG.md";>okio's changelog. Version 3.

[jira] [Commented] (FLINK-32589) Carry over parallelism overrides to prevent users from clearing them on updates

2023-07-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742887#comment-17742887 ] Gyula Fora commented on FLINK-32589: I think this would be a good improvement but we

[jira] [Commented] (FLINK-32589) Carry over parallelism overrides to prevent users from clearing them on updates

2023-07-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742886#comment-17742886 ] Gyula Fora commented on FLINK-32589: So just to be clear, do you suggest adding a ne

[jira] [Updated] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

2023-07-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-32420: --- Release Note: This performance improvement would be good to mention in the release blog post

[jira] [Commented] (FLINK-32589) Carry over parallelism overrides to prevent users from clearing them on updates

2023-07-13 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742865#comment-17742865 ] Maximilian Michels commented on FLINK-32589: We handle this in our applicati

[GitHub] [flink] XComp commented on a diff in pull request #22987: [FLINK-32583][rest] Fix deadlock in RestClient

2023-07-13 Thread via GitHub
XComp commented on code in PR #22987: URL: https://github.com/apache/flink/pull/22987#discussion_r1262773979 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java: ## @@ -501,6 +501,22 @@ private CompletableFuture submitRequest( }

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #630: [hotfix] Fix in-place rescaling for removed overrides

2023-07-13 Thread via GitHub
gyfora merged PR #630: URL: https://github.com/apache/flink-kubernetes-operator/pull/630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

2023-07-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742849#comment-17742849 ] Rui Fan commented on FLINK-32420: - Thanks [~pnowojski] for update the performance change

[jira] [Commented] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

2023-07-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742846#comment-17742846 ] Piotr Nowojski commented on FLINK-32420: Yeah... no need for further comments :)

[jira] [Updated] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

2023-07-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-32420: --- Attachment: Screenshot 2023-07-13 at 17.19.11.png Screenshot 2023-07-13 at 17

[jira] [Commented] (FLINK-32589) Carry over parallelism overrides to prevent users from clearing them on updates

2023-07-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742840#comment-17742840 ] Gyula Fora commented on FLINK-32589: I think this is not necessarily something that

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1262718932 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java: ## @@ -0,0 +1,1188 @@ +/* + * Licensed to the

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22861: [FLINK-32387][runtime] InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times

2023-07-13 Thread via GitHub
wanglijie95 commented on code in PR #22861: URL: https://github.com/apache/flink/pull/22861#discussion_r1262696361 ## flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputGateDeploymentDescriptor.java: ## @@ -139,53 +139,67 @@ public IndexRange getConsumedSubpart

[jira] [Comment Edited] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742834#comment-17742834 ] jasonliangyc edited comment on FLINK-32579 at 7/13/23 3:09 PM: ---

[jira] [Comment Edited] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742834#comment-17742834 ] jasonliangyc edited comment on FLINK-32579 at 7/13/23 3:06 PM: ---

[jira] [Comment Edited] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742834#comment-17742834 ] jasonliangyc edited comment on FLINK-32579 at 7/13/23 3:05 PM: ---

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1262700429 ## flink-catalog-aws/flink-catalog-aws-glue/pom.xml: ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/200

[jira] [Commented] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742834#comment-17742834 ] jasonliangyc commented on FLINK-32579: -- Hi [~337361...@qq.com]. Yes, I'm using the

[GitHub] [flink] akalash commented on a diff in pull request #22761: [FLINK-32298][network] Fix the bug that totalWrittenBytes of BufferWritingResultPartition misses some data

2023-07-13 Thread via GitHub
akalash commented on code in PR #22761: URL: https://github.com/apache/flink/pull/22761#discussion_r1262673283 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java: ## @@ -65,7 +65,7 @@ public abstract class BufferWriting

[jira] [Updated] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jasonliangyc updated FLINK-32579: - Attachment: test_case.sql > The filter criteria on the lookup table of Lookup join has no effect

[jira] [Updated] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jasonliangyc updated FLINK-32579: - Attachment: image-2023-07-13-22-43-45-957.png > The filter criteria on the lookup table of Looku

[jira] [Updated] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jasonliangyc updated FLINK-32579: - Attachment: image-2023-07-13-22-43-24-213.png > The filter criteria on the lookup table of Looku

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1262663157 ## flink-catalog-aws/flink-catalog-aws-glue/pom.xml: ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/200

[jira] [Updated] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jasonliangyc updated FLINK-32579: - Attachment: image-2023-07-13-22-38-16-709.png > The filter criteria on the lookup table of Looku

[jira] [Updated] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread jasonliangyc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jasonliangyc updated FLINK-32579: - Attachment: image-2023-07-13-22-35-35-696.png > The filter criteria on the lookup table of Looku

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-07-13 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1262655614 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operator/GlueFunctionOperator.java: ## @@ -0,0 +1,277 @@ +/* +

[jira] [Created] (FLINK-32589) Carry over parallelism overrides to prevent users from clearing them on updates

2023-07-13 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-32589: -- Summary: Carry over parallelism overrides to prevent users from clearing them on updates Key: FLINK-32589 URL: https://issues.apache.org/jira/browse/FLINK-32589

[GitHub] [flink] XComp commented on pull request #22988: [FLINK-32157] Replaces LeaderConnectionInfo with LeaderInformation

2023-07-13 Thread via GitHub
XComp commented on PR #22988: URL: https://github.com/apache/flink/pull/22988#issuecomment-1634351279 (sorry for not approving the PR before merging :innocent: ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (FLINK-32157) Replaces LeaderConnectionInfo with LeaderInformation

2023-07-13 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32157. --- Fix Version/s: 1.18.0 Resolution: Fixed master: f37d41cf557e9acd113a063dbee442a3a92bf

[GitHub] [flink] XComp merged pull request #22988: [FLINK-32157] Replaces LeaderConnectionInfo with LeaderInformation

2023-07-13 Thread via GitHub
XComp merged PR #22988: URL: https://github.com/apache/flink/pull/22988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] XComp commented on pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-07-13 Thread via GitHub
XComp commented on PR #22010: URL: https://github.com/apache/flink/pull/22010#issuecomment-1634336399 > In https://github.com/apache/flink/pull/21971 we added SequenceGeneratorTest, I think we can add the corresponding test method in https://github.com/apache/flink/pull/21971 I'm not

[GitHub] [flink] luoyuxia commented on a diff in pull request #22939: [FLINK-32474][table] Support time travel in table planner

2023-07-13 Thread via GitHub
luoyuxia commented on code in PR #22939: URL: https://github.com/apache/flink/pull/22939#discussion_r1262460439 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -380,7 +380,28 @@ public Optional getTable(ObjectIdentifie

[GitHub] [flink] liuyongvs commented on pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-07-13 Thread via GitHub
liuyongvs commented on PR #22745: URL: https://github.com/apache/flink/pull/22745#issuecomment-1634235602 Hi @snuyanzin do you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink] XComp commented on pull request #22984: [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes

2023-07-13 Thread via GitHub
XComp commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1634211308 Yup, I agree. I feel like it makes sense to summarize everything in a FLIP. I created [FLIP-335](https://cwiki.apache.org/confluence/display/FLINK/FLIP-335%3A+removing+flink's+time+classes)

[GitHub] [flink] zentol commented on pull request #22984: [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes

2023-07-13 Thread via GitHub
zentol commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1634202032 > I assumed the [discussion mentioned in FLINK-14068](https://lists.apache.org/thread/76yywnwf3lk8qn4dby0vz7yoqx7f7pkj) and [FLINK-14068](https://issues.apache.org/jira/browse/FLINK-14068)

[GitHub] [flink] fredia commented on pull request #22890: [FLINK-32072][checkpoint] Create and wire FileMergingSnapshotManager with TaskManagerServices

2023-07-13 Thread via GitHub
fredia commented on PR #22890: URL: https://github.com/apache/flink/pull/22890#issuecomment-1634170838 @AlexYinHan Thanks for the review and suggestion, I have addressed your comments. It could be very nice if you could take another look. -- This is an automated message from the Apache G

[GitHub] [flink] fredia commented on a diff in pull request #22890: [FLINK-32072][checkpoint] Create and wire FileMergingSnapshotManager with TaskManagerServices

2023-07-13 Thread via GitHub
fredia commented on code in PR #22890: URL: https://github.com/apache/flink/pull/22890#discussion_r1262496038 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageWorkerView.java: ## @@ -75,4 +77,14 @@ CheckpointStreamFactory resolveCheckpointStorageLoc

[GitHub] [flink] fredia commented on a diff in pull request #22890: [FLINK-32072][checkpoint] Create and wire FileMergingSnapshotManager with TaskManagerServices

2023-07-13 Thread via GitHub
fredia commented on code in PR #22890: URL: https://github.com/apache/flink/pull/22890#discussion_r1262494966 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsMergingCheckpointStorageAccess.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [flink] lsyldliu commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-13 Thread via GitHub
lsyldliu commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1262402227 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/batch/runtimefilter/BatchPhysicalGlobalRuntimeFilterBuilder.java: #

[GitHub] [flink-web] Limookiplimo opened a new pull request, #663: Refactor grammar on flink-architecture markdown

2023-07-13 Thread via GitHub
Limookiplimo opened a new pull request, #663: URL: https://github.com/apache/flink-web/pull/663 Updated grammar on the markdown to improve clarity and accuracy. Added the preposition "with" after "work well" and changed "each of" to "with each of" for consistency. -- This is an automated

[jira] [Resolved] (FLINK-32049) CoordinatedSourceRescaleITCase.testDownscaling fails on AZP

2023-07-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-32049. - Fix Version/s: 1.18.0 1.17.2 Assignee: Rui Fan (was: Qingsheng Ren) R

[jira] [Commented] (FLINK-32049) CoordinatedSourceRescaleITCase.testDownscaling fails on AZP

2023-07-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742758#comment-17742758 ] Rui Fan commented on FLINK-32049: - Hi [~Sergey Nuyanzin][~renqs], thanks for the reporti

[jira] [Comment Edited] (FLINK-32049) CoordinatedSourceRescaleITCase.testDownscaling fails on AZP

2023-07-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742689#comment-17742689 ] Rui Fan edited comment on FLINK-32049 at 7/13/23 10:27 AM: --- Me

[GitHub] [flink] 1996fanrui merged pull request #22991: [FLINK-32049][checkpoint] Fix thread-safe bug of channel state executor when some subtasks are closed while other subtasks are starting

2023-07-13 Thread via GitHub
1996fanrui merged PR #22991: URL: https://github.com/apache/flink/pull/22991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] 1996fanrui commented on pull request #22991: [FLINK-32049][checkpoint] Fix thread-safe bug of channel state executor when some subtasks are closed while other subtasks are starting

2023-07-13 Thread via GitHub
1996fanrui commented on PR #22991: URL: https://github.com/apache/flink/pull/22991#issuecomment-1633970439 Thanks for the review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink] luoyuxia commented on pull request #22904: [FLINK-32481][table] Support type inference for procedure

2023-07-13 Thread via GitHub
luoyuxia commented on PR #22904: URL: https://github.com/apache/flink/pull/22904#issuecomment-1633962951 @LadyForest Thanks for your reviewing. I have addressed your comment in this [commit](https://github.com/apache/flink/pull/22904/commits/35a62a159cd1fa45aaa250218f013cd43d8d31d1). -- T

[GitHub] [flink-kubernetes-operator] darenwkt commented on a diff in pull request #620: [FLINK-32317] Enrich metadata in CR error field

2023-07-13 Thread via GitHub
darenwkt commented on code in PR #620: URL: https://github.com/apache/flink-kubernetes-operator/pull/620#discussion_r1262342704 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -129,26 +144,56 @@ publi

[GitHub] [flink] luoyuxia commented on a diff in pull request #22904: [FLINK-32481][table] Support type inference for procedure

2023-07-13 Thread via GitHub
luoyuxia commented on code in PR #22904: URL: https://github.com/apache/flink/pull/22904#discussion_r1262339392 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionTemplate.java: ## @@ -133,10 +149,19 @@ private static class DefaultAnn

[GitHub] [flink] PatrickRen commented on a diff in pull request #22924: [FLINK-32404][table] Add catalog modification listener interface and create listener for catalog manager

2023-07-13 Thread via GitHub
PatrickRen commented on code in PR #22924: URL: https://github.com/apache/flink/pull/22924#discussion_r1262307415 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/EnvironmentTest.java: ## @@ -25,14 +25,22 @@ import org.apache.flink.streaming.api.envir

[jira] [Created] (FLINK-32588) Flink ML unittest BoundedPerRoundStreamIterationITCase failed

2023-07-13 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-32588: - Summary: Flink ML unittest BoundedPerRoundStreamIterationITCase failed Key: FLINK-32588 URL: https://issues.apache.org/jira/browse/FLINK-32588 Project: Flink Issu

[GitHub] [flink] LadyForest commented on a diff in pull request #22904: [FLINK-32481][table] Support type inference for procedure

2023-07-13 Thread via GitHub
LadyForest commented on code in PR #22904: URL: https://github.com/apache/flink/pull/22904#discussion_r1262153293 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionTemplate.java: ## @@ -146,6 +171,15 @@ private static T defaultAsNul

[jira] [Updated] (FLINK-32481) Support type inference for procedure

2023-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32481: --- Labels: pull-request-available (was: ) > Support type inference for procedure > ---

[GitHub] [flink] LadyForest commented on a diff in pull request #22904: [FLINK-32481][table] Support type inference for procedure

2023-07-13 Thread via GitHub
LadyForest commented on code in PR #22904: URL: https://github.com/apache/flink/pull/22904#discussion_r1259336884 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/extraction/TypeInferenceExtractorTest.java: ## @@ -577,6 +839,18 @@ static TestSpec forT

[jira] [Created] (FLINK-32587) The results returned from the CDC sql query are null or the value was changed unexpectly

2023-07-13 Thread jasonliangyc (Jira)
jasonliangyc created FLINK-32587: Summary: The results returned from the CDC sql query are null or the value was changed unexpectly Key: FLINK-32587 URL: https://issues.apache.org/jira/browse/FLINK-32587

[GitHub] [flink] PatrickRen commented on a diff in pull request #22869: [FLINK-32403][table] Add database related operations in CatalogManager

2023-07-13 Thread via GitHub
PatrickRen commented on code in PR #22869: URL: https://github.com/apache/flink/pull/22869#discussion_r1262279404 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/AlterDatabaseOperation.java: ## @@ -70,10 +69,13 @@ public String asSummarySt

[GitHub] [flink] flinkbot commented on pull request #22992: [hotfix] Fix typo in JobManagerOptions

2023-07-13 Thread via GitHub
flinkbot commented on PR #22992: URL: https://github.com/apache/flink/pull/22992#issuecomment-1633890956 ## CI report: * 72e8439ce49f3ebfe275a653d6ed41b6977de0ee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32586) Enable input locality in SimpleExecutionSlotAllocator

2023-07-13 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742730#comment-17742730 ] Lijie Wang commented on FLINK-32586: Thanks your proposal, make sense to me, assigne

[jira] [Assigned] (FLINK-32586) Enable input locality in SimpleExecutionSlotAllocator

2023-07-13 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-32586: -- Assignee: xingbe > Enable input locality in SimpleExecutionSlotAllocator > --

[jira] [Updated] (FLINK-32577) Avoid memory fragmentation when running CI for flink-table-planner module

2023-07-13 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-32577: -- Description: This issue is a sub-issue of FLINK-18356.     was:This issue is a sub-issue

[GitHub] [flink] jiaoqingbo opened a new pull request, #22992: [hotfix] Fix typo in JobManagerOptions

2023-07-13 Thread via GitHub
jiaoqingbo opened a new pull request, #22992: URL: https://github.com/apache/flink/pull/22992 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Commented] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742728#comment-17742728 ] Yunhong Zheng commented on FLINK-32579: --- Hi [~jasonliangyc] . Are you using Flink

[jira] [Updated] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-13 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-32579: -- Attachment: image-2023-07-13-17-19-26-972.png > The filter criteria on the lookup table of Loo

[jira] [Created] (FLINK-32586) Enable input locality in SimpleExecutionSlotAllocator

2023-07-13 Thread xingbe (Jira)
xingbe created FLINK-32586: -- Summary: Enable input locality in SimpleExecutionSlotAllocator Key: FLINK-32586 URL: https://issues.apache.org/jira/browse/FLINK-32586 Project: Flink Issue Type: Improve

[jira] [Commented] (FLINK-32049) CoordinatedSourceRescaleITCase.testDownscaling fails on AZP

2023-07-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742689#comment-17742689 ] Rui Fan commented on FLINK-32049: - Merged via: bc4c21e47040360aab5bcb0f2c18b907b60e7838

  1   2   >