[GitHub] [flink] flinkbot commented on pull request #22900: [FLINK-32478][connectors/common] Fix the bug that the shared thread pool causes the source alignment unit test to fail

2023-06-28 Thread via GitHub
flinkbot commented on PR #22900: URL: https://github.com/apache/flink/pull/22900#issuecomment-1612515856 ## CI report: * 46be6d6adabb920baa0de80403cea863f0adc0c6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] pnowojski commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-28 Thread via GitHub
pnowojski commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1246174618 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[jira] [Updated] (FLINK-32478) SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails

2023-06-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32478: --- Labels: pull-request-available (was: ) > SourceCoordinatorAlignmentTest.testAnnounceCombine

[GitHub] [flink] 1996fanrui opened a new pull request, #22900: [FLINK-32478][connectors/common] Fix the bug that the shared thread pool causes the source alignment unit test to fail

2023-06-28 Thread via GitHub
1996fanrui opened a new pull request, #22900: URL: https://github.com/apache/flink/pull/22900 ## What is the purpose of the change SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails Root cause: multiple sources share the same thread pool, and the sec

[jira] [Commented] (FLINK-32478) SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails

2023-06-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738375#comment-17738375 ] Rui Fan commented on FLINK-32478: - All of Flink master, release-1.16 and release-1.17 ha

[GitHub] [flink] pnowojski commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-28 Thread via GitHub
pnowojski commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1246174618 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[GitHub] [flink] pnowojski commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-28 Thread via GitHub
pnowojski commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1246174618 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[jira] [Commented] (FLINK-32478) SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails

2023-06-28 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738373#comment-17738373 ] Feifan Wang commented on FLINK-32478: - https://dev.azure.com/apache-flink/apache-fli

[jira] [Created] (FLINK-32478) SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails

2023-06-28 Thread Rui Fan (Jira)
Rui Fan created FLINK-32478: --- Summary: SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails Key: FLINK-32478 URL: https://issues.apache.org/jira/browse/FLINK-32478 Project: Flink

[GitHub] [flink-connector-jdbc] baxinyu opened a new pull request, #66: [FLINK-32477] Fixed missing words in documentation

2023-06-28 Thread via GitHub
baxinyu opened a new pull request, #66: URL: https://github.com/apache/flink-connector-jdbc/pull/66 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22674: [FLINK-32201][runtime]Automatically determine if the shuffle descriptor needs to be offloaded by the blob server based on the n

2023-06-28 Thread via GitHub
wanglijie95 commented on code in PR #22674: URL: https://github.com/apache/flink/pull/22674#discussion_r1246130385 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -717,6 +717,18 @@ public boolean isOnlyConsumeFinishedPartition() {

[jira] [Commented] (FLINK-32447) table hints lost when they inside a view referenced by an external query

2023-06-28 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738359#comment-17738359 ] lincoln lee commented on FLINK-32447: - fixed in 1.17: 8da3785d798cc6111f463ee1665ff

[jira] [Closed] (FLINK-32447) table hints lost when they inside a view referenced by an external query

2023-06-28 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32447. --- > table hints lost when they inside a view referenced by an external query > ---

[GitHub] [flink] lincoln-lil merged pull request #22896: [FLINK-32447][table-planner] Fix missing table hints when they inside a view referenced by an external query

2023-06-28 Thread via GitHub
lincoln-lil merged PR #22896: URL: https://github.com/apache/flink/pull/22896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] flinkbot commented on pull request #22899: [FLINK-30596][coordination] Fix duplicate jobs when submitting with the same jobId

2023-06-28 Thread via GitHub
flinkbot commented on PR #22899: URL: https://github.com/apache/flink/pull/22899#issuecomment-1612406491 ## CI report: * 0c19bafde27a471d3d72cfdd30eae9efe435cbba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22898: [FLINK-30596][coordination] Fix duplicate jobs when submitting with the same jobId

2023-06-28 Thread via GitHub
flinkbot commented on PR #22898: URL: https://github.com/apache/flink/pull/22898#issuecomment-1612406045 ## CI report: * 10c6617d03fccd44144d1d80ddc58ca0d52fc733 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-30596) Multiple POST /jars/:jarid/run requests with the same jobId, runs duplicate jobs

2023-06-28 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738358#comment-17738358 ] Mohsen Rezaei edited comment on FLINK-30596 at 6/29/23 4:12 AM: --

[jira] [Commented] (FLINK-30596) Multiple POST /jars/:jarid/run requests with the same jobId, runs duplicate jobs

2023-06-28 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738358#comment-17738358 ] Mohsen Rezaei commented on FLINK-30596: --- I've backported the fix for 1.17 and 1.16

[GitHub] [flink] mohsenrezaeithe commented on pull request #22899: [FLINK-30596][coordination] Fix duplicate jobs when submitting with the same jobId

2023-06-28 Thread via GitHub
mohsenrezaeithe commented on PR #22899: URL: https://github.com/apache/flink/pull/22899#issuecomment-1612404438 @zentol PTAL for 1.16 backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] mohsenrezaeithe opened a new pull request, #22899: [FLINK-30596][coordination] Fix duplicate jobs when submitting with the same jobId

2023-06-28 Thread via GitHub
mohsenrezaeithe opened a new pull request, #22899: URL: https://github.com/apache/flink/pull/22899 Related to https://github.com/apache/flink/pull/22898, backporting to Flink 1.16 release. (cherry picked from commit b528d9b81c03345c0415490fc41e27968313e5f0) ## What is the purpose o

[GitHub] [flink] mohsenrezaeithe commented on pull request #22898: [FLINK-30596][coordination] Fix duplicate jobs when submitting with the same jobId

2023-06-28 Thread via GitHub
mohsenrezaeithe commented on PR #22898: URL: https://github.com/apache/flink/pull/22898#issuecomment-1612401870 @zentol PTAL for 1.17 backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] mohsenrezaeithe opened a new pull request, #22898: [FLINK-30596][coordination] Fix duplicate jobs when submitting with the same jobId

2023-06-28 Thread via GitHub
mohsenrezaeithe opened a new pull request, #22898: URL: https://github.com/apache/flink/pull/22898 Related to https://github.com/apache/flink/pull/21849, backporting to Flink 1.17 release. (cherry picked from commit b528d9b81c03345c0415490fc41e27968313e5f0) ## What is the purpose o

[GitHub] [flink] TanYuxin-tyx commented on pull request #22833: [FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

2023-06-28 Thread via GitHub
TanYuxin-tyx commented on PR #22833: URL: https://github.com/apache/flink/pull/22833#issuecomment-1612392096 @xintongsong @reswqa Thanks for the careful review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-28 Thread via GitHub
LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1246058742 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246058692 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksNativeFullSnapshotStrategy.java: ## @@ -219,3

[jira] [Closed] (FLINK-17398) Filesystem support regex path reading

2023-06-28 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-17398. Resolution: Fixed master: ccb8e9f291dd3fa8cab845d2dc6dc78a761a6cb6 Thanks [~ruanhang1993] for thr pr. N

[jira] [Updated] (FLINK-17398) Filesystem support regex path reading

2023-06-28 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-17398: - Summary: Filesystem support regex path reading (was: Filesystem support flexible path reading) > Files

[GitHub] [flink] luoyuxia commented on pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-28 Thread via GitHub
luoyuxia commented on PR #22249: URL: https://github.com/apache/flink/pull/22249#issuecomment-1612381479 Thanks all. Merge it now. Feel free to left comment if you have other concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-32234) Support execute truncate table statement

2023-06-28 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-32234. Resolution: Fixed master: 300902016bd41961f28dacdd9b5fd028b8edb925 f8df2d608aff7cfa4a592532cfe280139a296

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246048717 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -390,23 +3

[GitHub] [flink] flinkbot commented on pull request #22897: [FLINK-32476][runtime] Support configuring object-reuse for internal operators

2023-06-28 Thread via GitHub
flinkbot commented on PR #22897: URL: https://github.com/apache/flink/pull/22897#issuecomment-1612374730 ## CI report: * 96a57bc9a2afa4e8af42fdcb9a454b96dfef6055 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] FangYongs commented on a diff in pull request #22882: [FLINK-32370][runtime] Don't print error log which will cause sql gateway e2e test to fail due to the .out file is not empty

2023-06-28 Thread via GitHub
FangYongs commented on code in PR #22882: URL: https://github.com/apache/flink/pull/22882#discussion_r1246045200 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java: ## @@ -268,10 +266,7 @@ private CompletableFuture handleException(

[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-28 Thread via GitHub
chucheng92 commented on PR #21442: URL: https://github.com/apache/flink/pull/21442#issuecomment-1612372450 @MartijnVisser hi, Martijn, https://issues.apache.org/jira/browse/FLINK-30859 has been resolved. Can you help me to check this pr? -- This is an automated message from the Apache Gi

[jira] [Updated] (FLINK-32477) flink-connector-jdbc  Fixed missing words in documentation

2023-06-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32477: --- Labels: pull-request-available (was: ) > flink-connector-jdbc  Fixed missing words in docum

[GitHub] [flink-connector-jdbc] baxinyu closed pull request #65: [FLINK-32477] Fixed missing words in documentation

2023-06-28 Thread via GitHub
baxinyu closed pull request #65: [FLINK-32477] Fixed missing words in documentation URL: https://github.com/apache/flink-connector-jdbc/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Updated] (FLINK-32476) Support configuring object-reuse for internal operators

2023-06-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32476: --- Labels: pull-request-available (was: ) > Support configuring object-reuse for internal oper

[GitHub] [flink] Sxnan opened a new pull request, #22897: [FLINK-32476][runtime] Support configuring object-reuse for internal operators

2023-06-28 Thread via GitHub
Sxnan opened a new pull request, #22897: URL: https://github.com/apache/flink/pull/22897 ## What is the purpose of the change This PR allows the internal operators to report whether the operators will modify the input so that Flink can decide whether to enable object-reuse for the op

[GitHub] [flink] luoyuxia commented on pull request #22696: [FLINK-32234][table] Support execute truncate table statement

2023-06-28 Thread via GitHub
luoyuxia commented on PR #22696: URL: https://github.com/apache/flink/pull/22696#issuecomment-1612369534 @Tartarus0zm Thanks for reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] luoyuxia closed pull request #22696: [FLINK-32234][table] Support execute truncate table statement

2023-06-28 Thread via GitHub
luoyuxia closed pull request #22696: [FLINK-32234][table] Support execute truncate table statement URL: https://github.com/apache/flink/pull/22696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246040024 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java: ## @@ -334,

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246040024 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java: ## @@ -334,

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246033453 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java: ## @@ -334,

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246032593 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -390,23 +3

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246031733 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandle.java: ## @@ -32,9 +36,62 @@ public interface IncrementalKeyedStateHandle

[jira] [Closed] (FLINK-32283) Implement SortBufferAccumulator

2023-06-28 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-32283. -- Resolution: Done master(1.18) via 7466df0c3c52851b7b1b9bca9c441dda22d66d2f. > Implement SortBufferAcc

[GitHub] [flink] reswqa merged pull request #22833: [FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

2023-06-28 Thread via GitHub
reswqa merged PR #22833: URL: https://github.com/apache/flink/pull/22833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246030055 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -122,37 +121,20 @@ public StreamStateHandle registerReference(

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-28 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1246030055 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -122,37 +121,20 @@ public StreamStateHandle registerReference(

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-28 Thread via GitHub
LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1246023522 ## flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java: ## @@ -131,6 +133,34 @@ void testWatermarkAlignmentWith

[jira] [Created] (FLINK-32477) flink-connector-jdbc  Fixed missing words in documentation

2023-06-28 Thread baxinyu (Jira)
baxinyu created FLINK-32477: --- Summary: flink-connector-jdbc  Fixed missing words in documentation Key: FLINK-32477 URL: https://issues.apache.org/jira/browse/FLINK-32477 Project: Flink Issue Type:

[jira] [Created] (FLINK-32476) Support configuring object-reuse for internal operators

2023-06-28 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-32476: -- Summary: Support configuring object-reuse for internal operators Key: FLINK-32476 URL: https://issues.apache.org/jira/browse/FLINK-32476 Project: Flink Issue Typ

[GitHub] [flink] luoyuxia commented on pull request #22821: [FLINK-32351][table] Introduce base interfaces for call procedure

2023-06-28 Thread via GitHub
luoyuxia commented on PR #22821: URL: https://github.com/apache/flink/pull/22821#issuecomment-1612350519 @LadyForest Thanks for your reviewing. I have addressed you comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Resolved] (FLINK-32411) SourceCoordinator thread leaks when job recovers from checkpoint

2023-06-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-32411. - Fix Version/s: 1.18.0 1.16.3 1.17.2 Resolution: Fixed > Sou

[jira] [Commented] (FLINK-32411) SourceCoordinator thread leaks when job recovers from checkpoint

2023-06-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738344#comment-17738344 ] Rui Fan commented on FLINK-32411: - Merged 876b1ec262f6c442e4bf87c9a5f83811e90e2805 1.

[GitHub] [flink] luoyuxia commented on a diff in pull request #22821: [FLINK-32351][table] Introduce base interfaces for call procedure

2023-06-28 Thread via GitHub
luoyuxia commented on code in PR #22821: URL: https://github.com/apache/flink/pull/22821#discussion_r1246020576 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/ProcedureHint.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] fredia commented on a diff in pull request #22801: [FLINK-23484][benchmark] Supports base benchmark for ChangelogStateBackend

2023-06-28 Thread via GitHub
fredia commented on code in PR #22801: URL: https://github.com/apache/flink/pull/22801#discussion_r1246014010 ## flink-test-utils-parent/flink-test-utils/pom.xml: ## @@ -133,6 +133,19 @@ under the License. + +

[GitHub] [flink] luoyuxia commented on a diff in pull request #22821: [FLINK-32351][table] Introduce base interfaces for call procedure

2023-06-28 Thread via GitHub
luoyuxia commented on code in PR #22821: URL: https://github.com/apache/flink/pull/22821#discussion_r1246019486 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/procedures/Procedure.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [flink] 1996fanrui merged pull request #22845: [FLINK-32411][connector/common] Fix the bug about SourceCoordinator thread leaks

2023-06-28 Thread via GitHub
1996fanrui merged PR #22845: URL: https://github.com/apache/flink/pull/22845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] 1996fanrui commented on pull request #22845: [FLINK-32411][connector/common] Fix the bug about SourceCoordinator thread leaks

2023-06-28 Thread via GitHub
1996fanrui commented on PR #22845: URL: https://github.com/apache/flink/pull/22845#issuecomment-1612345898 Thanks @pnowojski and @RocMarshal 's review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] TanYuxin-tyx commented on pull request #22833: [FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

2023-06-28 Thread via GitHub
TanYuxin-tyx commented on PR #22833: URL: https://github.com/apache/flink/pull/22833#issuecomment-1612313953 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Updated] (FLINK-32457) update current documentation of JSON_OBJECTAGG/JSON_ARRAYAGG to clarify the limitation

2023-06-28 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-32457: Fix Version/s: 1.18.0 > update current documentation of JSON_OBJECTAGG/JSON_ARRAYAGG to clarify th

[GitHub] [flink] liuyongvs commented on pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-06-28 Thread via GitHub
liuyongvs commented on PR #22745: URL: https://github.com/apache/flink/pull/22745#issuecomment-1612310881 @snuyanzin fix your reviews, thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Assigned] (FLINK-32473) Introduce base interfaces for time travel

2023-06-28 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-32473: Assignee: Feng Jin > Introduce base interfaces for time travel >

[GitHub] [flink] hanyuzheng7 commented on pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-28 Thread via GitHub
hanyuzheng7 commented on PR #22730: URL: https://github.com/apache/flink/pull/22730#issuecomment-1612263031 @dawidwys, I have address the two minor comments and rebase on top of the current master. It's ready to merge. Thank you. -- This is an automated message from the Apache Git Servic

[GitHub] [flink] snuyanzin commented on a diff in pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-06-28 Thread via GitHub
snuyanzin commented on code in PR #22745: URL: https://github.com/apache/flink/pull/22745#discussion_r1245830466 ## docs/data/sql_functions.yml: ## @@ -658,6 +658,9 @@ collection: - sql: MAP_FROM_ARRAYS(array_of_keys, array_of_values) table: mapFromArrays(array_of_keys,

[GitHub] [flink] snuyanzin commented on a diff in pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-06-28 Thread via GitHub
snuyanzin commented on code in PR #22745: URL: https://github.com/apache/flink/pull/22745#discussion_r1245789357 ## docs/data/sql_functions.yml: ## @@ -658,6 +658,9 @@ collection: - sql: MAP_FROM_ARRAYS(array_of_keys, array_of_values) table: mapFromArrays(array_of_keys,

[jira] [Commented] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-06-28 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738294#comment-17738294 ] Hanyu Zheng commented on FLINK-32261: - [~Sergey Nuyanzin] I have already updated the

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-28 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1612077473 thanks I will have a look tomorrow from the changed fileset it seems that this comment was missed >There should be added doc to chinese version of doc -- This is an automated

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-28 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1612074689 @snuyanzin I have already solve all the comments, could you please do the second code review. Thank you. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [flink] snuyanzin commented on pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-28 Thread via GitHub
snuyanzin commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-1612073732 @zhougit86 sorry for the late response I have a question: could you please clarify it it seems your change is inside condition ```scala if (codeGeneratorCastRule.canFail(i

[GitHub] [flink] snuyanzin merged pull request #22876: [FLINK-24911][table] Enable line numbers in SQL Client

2023-06-28 Thread via GitHub
snuyanzin merged PR #22876: URL: https://github.com/apache/flink/pull/22876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-32260) Add ARRAY_SLICE support in SQL & Table API

2023-06-28 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32260: Description: Implement the array_slice function to extract a subset of elements from an array. Th

[GitHub] [flink] snuyanzin commented on pull request #22876: [FLINK-24911][table] Enable line numbers in SQL Client

2023-06-28 Thread via GitHub
snuyanzin commented on PR #22876: URL: https://github.com/apache/flink/pull/22876#issuecomment-1612017197 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (FLINK-32260) Add ARRAY_SLICE support in SQL & Table API

2023-06-28 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32260: Description: Implement the array_slice function to extract a subset of elements from an array. R

[jira] [Updated] (FLINK-32260) Add ARRAY_SLICE support in SQL & Table API

2023-06-28 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32260: Description: Implement the array_slice function to extract a subset of elements from an array. R

[GitHub] [flink] snuyanzin commented on pull request #22892: [FLINK-32466] Replace STRING with CHARACTER for functions that don't support binary strings

2023-06-28 Thread via GitHub
snuyanzin commented on PR #22892: URL: https://github.com/apache/flink/pull/22892#issuecomment-1611983845 thanks for notifying. I checked it against our internal projects, also checked it against flink-connectors (cherry-picked to 1.15 where most of connectors still were in same repo). L

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22852: [FLINK-32420][connectors/common] Improve the watermark aggregation performance

2023-06-28 Thread via GitHub
1996fanrui commented on code in PR #22852: URL: https://github.com/apache/flink/pull/22852#discussion_r1245546244 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -631,8 +631,9 @@ private void ensureStarted() { }

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22852: [FLINK-32420][connectors/common] Improve the watermark aggregation performance

2023-06-28 Thread via GitHub
1996fanrui commented on code in PR #22852: URL: https://github.com/apache/flink/pull/22852#discussion_r1245546244 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -631,8 +631,9 @@ private void ensureStarted() { }

[GitHub] [flink] pnowojski commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-28 Thread via GitHub
pnowojski commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1245507575 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[jira] [Commented] (FLINK-32428) Introduce base interfaces for CatalogStore

2023-06-28 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738208#comment-17738208 ] Feng Jin commented on FLINK-32428: -- [~Leonard] I would like to take this, please assign

[jira] [Commented] (FLINK-32473) Introduce base interfaces for time travel

2023-06-28 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738207#comment-17738207 ] Feng Jin commented on FLINK-32473: -- [~luoyuxia] I would like to take this, please assi

[jira] [Created] (FLINK-32475) Add doc for time travel

2023-06-28 Thread Feng Jin (Jira)
Feng Jin created FLINK-32475: Summary: Add doc for time travel Key: FLINK-32475 URL: https://issues.apache.org/jira/browse/FLINK-32475 Project: Flink Issue Type: Sub-task Reporter: Fe

[jira] [Created] (FLINK-32474) Support time travel in table planner

2023-06-28 Thread Feng Jin (Jira)
Feng Jin created FLINK-32474: Summary: Support time travel in table planner Key: FLINK-32474 URL: https://issues.apache.org/jira/browse/FLINK-32474 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32473) Introduce base interfaces for time travel

2023-06-28 Thread Feng Jin (Jira)
Feng Jin created FLINK-32473: Summary: Introduce base interfaces for time travel Key: FLINK-32473 URL: https://issues.apache.org/jira/browse/FLINK-32473 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32472) FLIP-308: Support Time Travel

2023-06-28 Thread Feng Jin (Jira)
Feng Jin created FLINK-32472: Summary: FLIP-308: Support Time Travel Key: FLINK-32472 URL: https://issues.apache.org/jira/browse/FLINK-32472 Project: Flink Issue Type: New Feature Compo

[jira] [Commented] (FLINK-32260) Add ARRAY_SLICE support in SQL & Table API

2023-06-28 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738199#comment-17738199 ] Hanyu Zheng commented on FLINK-32260: - Google cloud's array_slice is 0-base, so our

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
hanyuzheng7 commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245458862 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to th

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
hanyuzheng7 commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245439050 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayOfStringArgumentTypeStrategy.java: ## @@ -0,0 +1,72 @@ +/* +

[jira] [Closed] (FLINK-32465) KerberosLoginProvider.isLoginPossible does accidental login with keytab

2023-06-28 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-32465. - Fix Version/s: 1.18.0 1.17.2 Resolution: Fixed > KerberosLoginProvider

[jira] [Comment Edited] (FLINK-32465) KerberosLoginProvider.isLoginPossible does accidental login with keytab

2023-06-28 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738124#comment-17738124 ] Gabor Somogyi edited comment on FLINK-32465 at 6/28/23 3:51 PM: --

[GitHub] [flink] gaborgsomogyi merged pull request #22889: [FLINK-32465][runtime][security] Fix KerberosLoginProvider.isLoginPossible accidental login with keytab

2023-06-28 Thread via GitHub
gaborgsomogyi merged PR #22889: URL: https://github.com/apache/flink/pull/22889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Comment Edited] (FLINK-30596) Multiple POST /jars/:jarid/run requests with the same jobId, runs duplicate jobs

2023-06-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738183#comment-17738183 ] Chesnay Schepler edited comment on FLINK-30596 at 6/28/23 3:46 PM: ---

[jira] [Commented] (FLINK-30596) Multiple POST /jars/:jarid/run requests with the same jobId, runs duplicate jobs

2023-06-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738183#comment-17738183 ] Chesnay Schepler commented on FLINK-30596: -- master: b528d9b81c03345c0415490fc41

[GitHub] [flink] zentol merged pull request #21849: [FLINK-30596][Runtime/REST] Fix duplicate jobs when submitting with the same jobId

2023-06-28 Thread via GitHub
zentol merged PR #21849: URL: https://github.com/apache/flink/pull/21849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-28 Thread via GitHub
hanyuzheng7 commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1245417236 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayComparableElementTypeStrategy.java: ## @@ -0,0 +1,147 @@ +/*

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-28 Thread via GitHub
hanyuzheng7 commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1245392043 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ComparabilityUtils.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to t

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-28 Thread via GitHub
hanyuzheng7 commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1245391760 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategyTest.java: ## @@ -0,0 +1,43 @@ +/* +

[jira] [Commented] (FLINK-32260) Add ARRAY_SLICE support in SQL & Table API

2023-06-28 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738170#comment-17738170 ] Sergey Nuyanzin commented on FLINK-32260: - if it's clearly mentioned in doc i'm

[GitHub] [flink] zentol commented on a diff in pull request #22883: [FLINK-31476] AdaptiveScheduler respects minimum parallelism

2023-06-28 Thread via GitHub
zentol commented on code in PR #22883: URL: https://github.com/apache/flink/pull/22883#discussion_r1245368209 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java: ## @@ -78,31 +80,54 @@ public ResourceCounter calcula

[GitHub] [flink] XComp commented on a diff in pull request #22661: [FLINK-31783][runtime] Migrates DefaultLeaderElectionService from LeaderElectionDriver to the MultipleComponentLeaderElectionDriver i

2023-06-28 Thread via GitHub
XComp commented on code in PR #22661: URL: https://github.com/apache/flink/pull/22661#discussion_r1245365276 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -19,147 +19,347 @@ package org.apache.flink.runtime.leader

  1   2   3   >