[jira] [Updated] (FLINK-17484) [FLIP-154] Enable type coercion

2023-06-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-17484: --- Summary: [FLIP-154] Enable type coercion (was: Enable type coercion) > [FLIP-154] Enable ty

[jira] [Closed] (FLINK-23288) Inserting (1.378593404E9) (0.6047707965147558) to a double type, it will generate CodeGenException

2023-06-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-23288. -- Resolution: Duplicate > Inserting (1.378593404E9) (0.6047707965147558) to a double type, it wi

[jira] [Closed] (FLINK-18234) Implicit type conversion in join condition

2023-06-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-18234. -- Resolution: Duplicate > Implicit type conversion in join condition > -

[jira] [Closed] (FLINK-27795) SqlValidatorException when insert null value

2023-06-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-27795. -- Resolution: Duplicate > SqlValidatorException when insert null value > ---

[jira] [Closed] (FLINK-28132) Should we remove type validations when using lookup-key join ?

2023-06-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-28132. -- Resolution: Duplicate > Should we remove type validations when using lookup-key join ? > -

[jira] [Closed] (FLINK-24914) Support implicit type conversion in SQL like "select int_field = varchar_field"

2023-06-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-24914. -- Resolution: Duplicate > Support implicit type conversion in SQL like "select int_field = > va

[jira] [Closed] (FLINK-32363) calcite 1.21 supports type coercion but flink don't enable it in validate

2023-06-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-32363. -- Resolution: Duplicate > calcite 1.21 supports type coercion but flink don't enable it in valid

[jira] [Commented] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-06-15 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733349#comment-17733349 ] Cai Liuyang commented on FLINK-32362: - Two ways: # the simple way code like: {code:

[jira] [Comment Edited] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-06-15 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733349#comment-17733349 ] Cai Liuyang edited comment on FLINK-32362 at 6/16/23 6:38 AM:

[GitHub] [flink] reswqa commented on pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-15 Thread via GitHub
reswqa commented on PR #22798: URL: https://github.com/apache/flink/pull/22798#issuecomment-1594179898 Thanks for the improvement, @SinBex would you mind showing the benchmark result after this changes? -- This is an automated message from the Apache Git Service. To respond to the message

[jira] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-06-15 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362 ] Cai Liuyang deleted comment on FLINK-32362: - was (Author: cailiuyang): [~fanrui] Two ways: > SourceAlignment announceCombinedWatermark period task maybe lost > --

[jira] [Commented] (FLINK-31804) ITCase MiniCluster test architecture rule should accept MiniClusterTestEnvironment

2023-06-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733346#comment-17733346 ] Weijie Guo commented on FLINK-31804: It seems that more than one connector has encou

[jira] [Commented] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-06-15 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733345#comment-17733345 ] Cai Liuyang commented on FLINK-32362: - [~fanrui] Two ways: > SourceAlignment announ

[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-15 Thread via GitHub
reswqa commented on code in PR #78: URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231826289 ## flink-connector-aws-kinesis-firehose/archunit-violations/a6cbd99c-b115-447a-8f19-43c1094db549: ## @@ -2,5 +2,11 @@ org.apache.flink.connector.firehose.sink.

[jira] [Commented] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-15 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733343#comment-17733343 ] Rui Fan commented on FLINK-32137: - Hi [~netvl] , do you have any progress? If you are bu

[GitHub] [flink] huwh commented on pull request #22674: [FLINK-32201][runtime]Automatically determine if the shuffle descriptor needs to be offloaded by the blob server based on the number of ShuffleD

2023-06-15 Thread via GitHub
huwh commented on PR #22674: URL: https://github.com/apache/flink/pull/22674#issuecomment-1594164840 @Thesharing, @wanglijie95 , I have rebase this to the master branch. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-15 Thread via GitHub
reswqa commented on code in PR #78: URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231821319 ## flink-connector-aws-kinesis-firehose/archunit-violations/a6cbd99c-b115-447a-8f19-43c1094db549: ## @@ -2,5 +2,11 @@ org.apache.flink.connector.firehose.sink.

[GitHub] [flink] huwh commented on a diff in pull request #22674: [FLINK-32201][runtime]Automatically determine if the shuffle descriptor needs to be offloaded by the blob server based on the number o

2023-06-15 Thread via GitHub
huwh commented on code in PR #22674: URL: https://github.com/apache/flink/pull/22674#discussion_r1231819871 ## flink-runtime/src/main/java/org/apache/flink/runtime/deployment/CachedShuffleDescriptors.java: ## @@ -104,4 +119,30 @@ public void markPartitionFinished(IntermediateRe

[jira] [Commented] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-06-15 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733340#comment-17733340 ] Rui Fan commented on FLINK-32362: - Hi [~cailiuyang] , thanks for the report. It's reall

[GitHub] [flink] LoveHeat closed pull request #21015: [FLINK-29577][State Backends] Disable rocksdb wal when restore from full snapshot

2023-06-15 Thread via GitHub
LoveHeat closed pull request #21015: [FLINK-29577][State Backends] Disable rocksdb wal when restore from full snapshot URL: https://github.com/apache/flink/pull/21015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-15 Thread via GitHub
reswqa commented on code in PR #78: URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231815332 ## .github/workflows/nightly.yml: ## @@ -17,9 +17,7 @@ name: "flink-connec

[jira] [Commented] (FLINK-31030) Support more binary classification evaluation metrics.

2023-06-15 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1776#comment-1776 ] xingyuan cheng commented on FLINK-31030: I am interested in this, and I will sta

[GitHub] [flink] snuyanzin commented on pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-15 Thread via GitHub
snuyanzin commented on PR #22717: URL: https://github.com/apache/flink/pull/22717#issuecomment-1594156602 Thanks for addressin comments it looks good from one side could you please rebase to the latest master's commit and squash commits after that I think we are ready to merge

[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-15 Thread via GitHub
reswqa commented on code in PR #78: URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231815332 ## .github/workflows/nightly.yml: ## @@ -17,9 +17,7 @@ name: "flink-connec

[GitHub] [flink-connector-aws] snuyanzin commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-15 Thread via GitHub
snuyanzin commented on code in PR #78: URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231812320 ## flink-connector-aws-kinesis-firehose/archunit-violations/a6cbd99c-b115-447a-8f19-43c1094db549: ## @@ -2,5 +2,11 @@ org.apache.flink.connector.firehose.si

[GitHub] [flink-connector-aws] snuyanzin commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations

2023-06-15 Thread via GitHub
snuyanzin commented on code in PR #78: URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231811552 ## .github/workflows/nightly.yml: ## @@ -17,9 +17,7 @@ name: "flink-con

[jira] [Assigned] (FLINK-32316) Duplicated announceCombinedWatermark task maybe scheduled if jobmanager failover

2023-06-15 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-32316: --- Assignee: Cai Liuyang > Duplicated announceCombinedWatermark task maybe scheduled if jobmanager >

[jira] [Assigned] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-06-15 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-32362: --- Assignee: Cai Liuyang > SourceAlignment announceCombinedWatermark period task maybe lost >

[GitHub] [flink] WencongLiu commented on pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-15 Thread via GitHub
WencongLiu commented on PR #22733: URL: https://github.com/apache/flink/pull/22733#issuecomment-1594148200 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] flinkbot commented on pull request #22802: [FLINK-32136][python] Fix the issue that Pyflink gateway server launch fails when purelib != platlib

2023-06-15 Thread via GitHub
flinkbot commented on PR #22802: URL: https://github.com/apache/flink/pull/22802#issuecomment-1594127378 ## CI report: * 67e235c9e11ac97161e1be6e2780efbd0f535b65 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32136) Pyflink gateway server launch fails when purelib != platlib

2023-06-15 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733327#comment-17733327 ] Dian Fu commented on FLINK-32136: - [~wash] I have submitted a PR. Could you help to revi

[jira] [Comment Edited] (FLINK-32136) Pyflink gateway server launch fails when purelib != platlib

2023-06-15 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733327#comment-17733327 ] Dian Fu edited comment on FLINK-32136 at 6/16/23 5:25 AM: -- [~wa

[jira] [Updated] (FLINK-32136) Pyflink gateway server launch fails when purelib != platlib

2023-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32136: --- Labels: pull-request-available (was: ) > Pyflink gateway server launch fails when purelib !

[GitHub] [flink] dianfu opened a new pull request, #22802: [FLINK-32136][python] Fix the issue that Pyflink gateway server launch fails when purelib != platlib

2023-06-15 Thread via GitHub
dianfu opened a new pull request, #22802: URL: https://github.com/apache/flink/pull/22802 ## What is the purpose of the change *This pull request fixes the issue that Pyflink gateway server launch fails when purelib != platlib.* ## Brief change log - * Call _find_flink

[jira] [Updated] (FLINK-32363) calcite 1.21 supports type coercion but flink don't enable it in validate

2023-06-15 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-32363: --- Fix Version/s: (was: 1.18.0) > calcite 1.21 supports type coercion but flink don't enable it in

[jira] [Updated] (FLINK-32363) calcite 1.21 supports type coercion but flink don't enable it in validate

2023-06-15 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-32363: --- Affects Version/s: (was: 1.18.0) > calcite 1.21 supports type coercion but flink don't enable it

[jira] [Commented] (FLINK-32363) calcite 1.21 supports type coercion but flink don't enable it in validate

2023-06-15 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733320#comment-17733320 ] Benchao Li commented on FLINK-32363: [FLIP-154|https://cwiki.apache.org/confluence/d

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-06-15 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733317#comment-17733317 ] Tomoyuki NAKAMURA commented on FLINK-30093: --- I would like to see this change b

[jira] [Assigned] (FLINK-23485) Add a benchmark for the Changelog DFS writer

2023-06-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu reassigned FLINK-23485: Assignee: Hangxiang Yu > Add a benchmark for the Changelog DFS writer > -

[jira] [Assigned] (FLINK-23484) Add benchmarks for the ChangelogStateBackend

2023-06-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu reassigned FLINK-23484: Assignee: Hangxiang Yu > Add benchmarks for the ChangelogStateBackend > -

[jira] [Assigned] (FLINK-23485) Add a benchmark for the Changelog DFS writer

2023-06-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu reassigned FLINK-23485: Assignee: (was: Hangxiang Yu) > Add a benchmark for the Changelog DFS writer > --

[GitHub] [flink-training] ness-marichamyramachandran closed pull request #64: Flk 1036 module 1

2023-06-15 Thread via GitHub
ness-marichamyramachandran closed pull request #64: Flk 1036 module 1 URL: https://github.com/apache/flink-training/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Created] (FLINK-32364) Add Rescaling benchmark for ChangelogStateBackend

2023-06-15 Thread Hangxiang Yu (Jira)
Hangxiang Yu created FLINK-32364: Summary: Add Rescaling benchmark for ChangelogStateBackend Key: FLINK-32364 URL: https://issues.apache.org/jira/browse/FLINK-32364 Project: Flink Issue Type:

[GitHub] [flink] flinkbot commented on pull request #22801: [FLINK-23484][benchmark] Supports base benchmark for ChangelogStateBackend

2023-06-15 Thread via GitHub
flinkbot commented on PR #22801: URL: https://github.com/apache/flink/pull/22801#issuecomment-1594070143 ## CI report: * 1fb603a50f419af2aca44deb22bdc74181867e19 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-benchmarks] masteryhx opened a new pull request, #75: [FLINK-23484] Supports to test ChangelogStateBackend

2023-06-15 Thread via GitHub
masteryhx opened a new pull request, #75: URL: https://github.com/apache/flink-benchmarks/pull/75 See [FLINK-23484](https://issues.apache.org/jira/browse/FLINK-23484) for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-23484) Add benchmarks for the ChangelogStateBackend

2023-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23484: --- Labels: pull-request-available (was: ) > Add benchmarks for the ChangelogStateBackend > ---

[GitHub] [flink] masteryhx opened a new pull request, #22801: [FLINK-23484][benchmark] Supports base benchmark for ChangelogStateBackend

2023-06-15 Thread via GitHub
masteryhx opened a new pull request, #22801: URL: https://github.com/apache/flink/pull/22801 ## What is the purpose of the change - Supports ChanglogStateBackend Benchmark. Will also prepare a related pr in flink-benchmarks repo. ## Brief change log - Move be

[GitHub] [flink] flinkbot commented on pull request #22800: [FLINK-23411][checkpoint] Expose Checkpoint metrics in task level

2023-06-15 Thread via GitHub
flinkbot commented on PR #22800: URL: https://github.com/apache/flink/pull/22800#issuecomment-1594051566 ## CI report: * 772dc5ca7bc2df3bab66e82fc0477013dca1dfc7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-23411) Expose Flink checkpoint details metrics

2023-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23411: --- Labels: pull-request-available (was: ) > Expose Flink checkpoint details metrics >

[GitHub] [flink] masteryhx opened a new pull request, #22800: [FLINK-23411][checkpoint] Expose Checkpoint metrics in task level

2023-06-15 Thread via GitHub
masteryhx opened a new pull request, #22800: URL: https://github.com/apache/flink/pull/22800 ## What is the purpose of the change - Expose task level checkpoint metircs that just like what shows in Flink UI. ## Brief change log - Introduce CheckpointMetricsG

[GitHub] [flink] masteryhx commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

2023-06-15 Thread via GitHub
masteryhx commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1231733767 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -196,6 +204,23 @@ public void markTaskStart() { this.tas

[jira] [Commented] (FLINK-32346) JdbcNumericBetweenParametersProvider Sharding key boundaries large storage long integer overflow, use BigDecimal instead Long

2023-06-15 Thread zhilinli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733295#comment-17733295 ] zhilinli commented on FLINK-32346: --  such as:Mysql ddl : *id bigint(30) unsigned NOT NU

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2023-06-15 Thread via GitHub
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1594034092 Hi @Sergey, I am on vacation and will be back in July. I can continue after that. Thanks Ashmeet On Tue, Jun 6, 2023, 13:11 Sergey Nuyanzin ***@***.*

[GitHub] [flink-training] ytlw opened a new pull request, #63: Fix Chinese readme links

2023-06-15 Thread via GitHub
ytlw opened a new pull request, #63: URL: https://github.com/apache/flink-training/pull/63 links should jump to chinese version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Created] (FLINK-32363) calcite 1.21 supports type coercion but flink don't enable it in validate

2023-06-15 Thread jackylau (Jira)
jackylau created FLINK-32363: Summary: calcite 1.21 supports type coercion but flink don't enable it in validate Key: FLINK-32363 URL: https://issues.apache.org/jira/browse/FLINK-32363 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #22799: [FLINK-25872][state/changelog] Hotfix! Fix the description of Changel…

2023-06-15 Thread via GitHub
flinkbot commented on PR #22799: URL: https://github.com/apache/flink/pull/22799#issuecomment-1594025822 ## CI report: * 65ef406d23814acaa54ba9f450cf806a42fb9c9b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fredia opened a new pull request, #22799: [FLINK-25872][state/changelog] Hotfix! Fix the description of Changel…

2023-06-15 Thread via GitHub
fredia opened a new pull request, #22799: URL: https://github.com/apache/flink/pull/22799 …ogCompatibilityITCase ## What is the purpose of the change Fix the description of ChangelogCompatibilityITCase, recovering from non-changelog checkpoints in claim mode is support

[GitHub] [flink] gaoyunhaii commented on pull request #22344: [FLINK-31721][core] Move JobStatusHook to flink-core module

2023-06-15 Thread via GitHub
gaoyunhaii commented on PR #22344: URL: https://github.com/apache/flink/pull/22344#issuecomment-1594019408 Will merge after the pipeline get green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink] reswqa merged pull request #22790: [hotfix][state] Fix incorrect comments of channel input state redistribution.

2023-06-15 Thread via GitHub
reswqa merged PR #22790: URL: https://github.com/apache/flink/pull/22790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-32288) Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32288: --- Labels: pull-request-available (was: ) > Improve the scheduling performance of AdaptiveBatc

[GitHub] [flink] SinBex commented on pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-15 Thread via GitHub
SinBex commented on PR #22798: URL: https://github.com/apache/flink/pull/22798#issuecomment-1594017814 @zhuzhurk Could you please help me review the code when you have free time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot commented on pull request #22798: Adaptive batch improve

2023-06-15 Thread via GitHub
flinkbot commented on PR #22798: URL: https://github.com/apache/flink/pull/22798#issuecomment-1594016362 ## CI report: * 4dbf25760c9ff0e17aed65ab351622468ceb0858 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] SinBex opened a new pull request, #22798: Adaptive batch improve

2023-06-15 Thread via GitHub
SinBex opened a new pull request, #22798: URL: https://github.com/apache/flink/pull/22798 ## What is the purpose of the change After adding the benchmark of AdaptiveBatchScheduler in [FLINK-30480](https://issues.apache.org/jira/browse/FLINK-30480), we noticed a regression in

[jira] [Comment Edited] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-06-15 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733285#comment-17733285 ] Benchao Li edited comment on FLINK-30093 at 6/16/23 2:30 AM: -

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-06-15 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733285#comment-17733285 ] Benchao Li commented on FLINK-30093: Usually the "bugfix" which fixes the functional

[GitHub] [flink] fredia commented on pull request #22787: [FLINK-24402][metric] Add a metric for back-pressure from the ChangelogStateBackend

2023-06-15 Thread via GitHub
fredia commented on PR #22787: URL: https://github.com/apache/flink/pull/22787#issuecomment-1594000304 Hi @rkhachatryan, could you please help take a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (FLINK-32316) Duplicated announceCombinedWatermark task maybe scheduled if jobmanager failover

2023-06-15 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-32316: Description: When we try SourceAlignment feature, we found there will be a duplicated announceCom

[jira] [Updated] (FLINK-32316) Duplicated announceCombinedWatermark task maybe scheduled if jobmanager failover

2023-06-15 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-32316: Description: When we try SourceAlignment feature, we found there will be a duplicated announceCom

[jira] [Created] (FLINK-32362) SourceAlignment announceCombinedWatermark period task maybe lost

2023-06-15 Thread Cai Liuyang (Jira)
Cai Liuyang created FLINK-32362: --- Summary: SourceAlignment announceCombinedWatermark period task maybe lost Key: FLINK-32362 URL: https://issues.apache.org/jira/browse/FLINK-32362 Project: Flink

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-15 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1231704047 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/tables/TableBuilder.java: ## @@ -51,4 +52,8 @@ private static TableField cre

[jira] [Created] (FLINK-32361) error after replace dependent jar file

2023-06-15 Thread Spongebob (Jira)
Spongebob created FLINK-32361: - Summary: error after replace dependent jar file Key: FLINK-32361 URL: https://issues.apache.org/jira/browse/FLINK-32361 Project: Flink Issue Type: Bug Co

[jira] [Commented] (FLINK-32316) Duplicated announceCombinedWatermark task maybe scheduled if jobmanager failover

2023-06-15 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733278#comment-17733278 ] Cai Liuyang commented on FLINK-32316: - [~fanrui] OK,please assign to me,thks~ > Dup

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231666089 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java: ## @@ -355,6 +360,17 @@ public KafkaSourceBuilder se

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231665787 ## docs/content/docs/connectors/datastream/kafka.md: ## @@ -466,6 +466,28 @@ client dependencies in the job JAR, so you may need to rewrite it with the act

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231665170 ## docs/content/docs/connectors/datastream/kafka.md: ## @@ -466,6 +466,28 @@ client dependencies in the job JAR, so you may need to rewrite it with the act

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231664562 ## docs/content/docs/connectors/datastream/kafka.md: ## @@ -466,6 +466,28 @@ client dependencies in the job JAR, so you may need to rewrite it with the act

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231663375 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReaderTest.java: ## @@ -319,6 +321,51 @@ public voi

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231663206 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java: ## @@ -80,11 +80,20 @@ public KafkaPar

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231661170 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java: ## @@ -98,20 +98,24 @@ private final KafkaRecordDeseri

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-06-15 Thread via GitHub
mas-chen commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231661170 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java: ## @@ -98,20 +98,24 @@ private final KafkaRecordDeseri

[GitHub] [flink] flinkbot commented on pull request #22797: [FLINK-30859][DO NOT MERGE] [WIP] Remove all Kafka connector code from main repo

2023-06-15 Thread via GitHub
flinkbot commented on PR #22797: URL: https://github.com/apache/flink/pull/22797#issuecomment-1593889404 ## CI report: * b554f0fd9846295fed4874b3675b19328ba37119 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-kafka] mas-chen commented on pull request #24: [FLINK-30859] Sync kafka related examples from apache/flink:master

2023-06-15 Thread via GitHub
mas-chen commented on PR #24: URL: https://github.com/apache/flink-connector-kafka/pull/24#issuecomment-1593889326 Discussed offline to refactor to remove Kafka dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink-connector-kafka] mas-chen closed pull request #24: [FLINK-30859] Sync kafka related examples from apache/flink:master

2023-06-15 Thread via GitHub
mas-chen closed pull request #24: [FLINK-30859] Sync kafka related examples from apache/flink:master URL: https://github.com/apache/flink-connector-kafka/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink-connector-kafka] mas-chen closed pull request #25: [FLINK-30859] Sync flink sql client test

2023-06-15 Thread via GitHub
mas-chen closed pull request #25: [FLINK-30859] Sync flink sql client test URL: https://github.com/apache/flink-connector-kafka/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink-connector-kafka] mas-chen commented on pull request #25: [FLINK-30859] Sync flink sql client test

2023-06-15 Thread via GitHub
mas-chen commented on PR #25: URL: https://github.com/apache/flink-connector-kafka/pull/25#issuecomment-1593889106 Discussed offline to allow pinning versions with test scope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [flink] mas-chen opened a new pull request, #22797: [FLINK-30859][DO NOT MERGE] [WIP] Remove all Kafka connector code from main repo #22700

2023-06-15 Thread via GitHub
mas-chen opened a new pull request, #22797: URL: https://github.com/apache/flink/pull/22797 This is WIP, DO NOT MERGE! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [flink] hanyuzheng7 commented on pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-15 Thread via GitHub
hanyuzheng7 commented on PR #22717: URL: https://github.com/apache/flink/pull/22717#issuecomment-1593832899 @snuyanzin Do you think it is ok for merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] hanyuzheng7 commented on pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-15 Thread via GitHub
hanyuzheng7 commented on PR #22717: URL: https://github.com/apache/flink/pull/22717#issuecomment-1593824046 @snuyanzin Thank you for your reply. In fact, I can use Chinese. So I will update it in Chinese. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink] snuyanzin commented on pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-15 Thread via GitHub
snuyanzin commented on PR #22717: URL: https://github.com/apache/flink/pull/22717#issuecomment-1593811831 Thanks for addressing comments, seems I forget to mention it, sorry could you please also update chinese version of doc `sql_functions_zh.yml` You could do it in english -

[jira] [Resolved] (FLINK-32337) SQL array_union could return wrong result

2023-06-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-32337. - Fix Version/s: 1.18.0 Resolution: Fixed > SQL array_union could return wrong resu

[jira] [Closed] (FLINK-32337) SQL array_union could return wrong result

2023-06-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-32337. --- > SQL array_union could return wrong result > - > >

[jira] [Commented] (FLINK-32337) SQL array_union could return wrong result

2023-06-15 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733257#comment-17733257 ] Sergey Nuyanzin commented on FLINK-32337: - Merged as [9bcebe7db3abfae6474e9dc4f

[GitHub] [flink] snuyanzin closed pull request #22779: [FLINK-32337][table] ARRAY_UNION's element getter should respect not only first arg's nullability

2023-06-15 Thread via GitHub
snuyanzin closed pull request #22779: [FLINK-32337][table] ARRAY_UNION's element getter should respect not only first arg's nullability URL: https://github.com/apache/flink/pull/22779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Updated] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-15 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-31990: Description: *What* Use the Flink Configuration object to standardise the method of speci

[jira] [Commented] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-15 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733249#comment-17733249 ] Hong Liang Teoh commented on FLINK-31990: - Thanks for flagging, Danny! I did so

[GitHub] [flink-connector-aws] hlteoh37 commented on pull request #81: [FLINK-31923] Run nightly builds against multiple branches and Flink versions

2023-06-15 Thread via GitHub
hlteoh37 commented on PR #81: URL: https://github.com/apache/flink-connector-aws/pull/81#issuecomment-1593738671 Hmm, I can't seem to replicate the build error locally. Could we try re-running the checks? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [flink] flinkbot commented on pull request #22796: [hotfix] Fix typo in setMaxParallelism() when create iteration sink

2023-06-15 Thread via GitHub
flinkbot commented on PR #22796: URL: https://github.com/apache/flink/pull/22796#issuecomment-1593727929 ## CI report: * f0ca84d77cf495811621b8f4302f2716b68dde49 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] qqibrow opened a new pull request, #22796: [hotfix] Fix typo in setMaxParallelism() when create iteration sink

2023-06-15 Thread via GitHub
qqibrow opened a new pull request, #22796: URL: https://github.com/apache/flink/pull/22796 This diff fixes the bug that a flink job containing iterator operator cannot resume from last checkpoint when parallelism changes. -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-15 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1231535045 ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java: ## @@ -231,6 +231,27 @@ public class YarnConfigOptions {

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-06-15 Thread Ben Augarten (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733211#comment-17733211 ] Ben Augarten commented on FLINK-30093: -- Thanks [~libenchao], at first I thought tha

  1   2   3   4   >