[jira] [Reopened] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2023-04-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-27756: - Reopen since there is a new reproduction on 1.17 https://dev.azure.com/apache-flink/apache-f

[jira] [Updated] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2023-04-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-27756: Affects Version/s: 1.17.0 > Fix intermittently failing test in > AsyncSinkWriterTest.chec

[GitHub] [flink] flinkbot commented on pull request #22413: [FLINK-31832][runtime] Add benchmarks for end to end restarting tasks

2023-04-17 Thread via GitHub
flinkbot commented on PR #22413: URL: https://github.com/apache/flink/pull/22413#issuecomment-1512499669 ## CI report: * 61dafd67a5c9e476ed32489def385fd0c826697c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169539973 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,13 +182,16 @@

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169539973 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,13 +182,16 @@

[jira] [Updated] (FLINK-31831) TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure is unstable

2023-04-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-31831: Affects Version/s: 1.18.0 > TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFa

[jira] [Updated] (FLINK-31832) Add benchmarks for end to end  restarting tasks

2023-04-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31832: --- Labels: pull-request-available (was: ) > Add benchmarks for end to end  restarting tasks >

[GitHub] [flink] huwh opened a new pull request, #22413: [FLINK-31832][runtime] Add benchmarks for end to end restarting tasks

2023-04-17 Thread via GitHub
huwh opened a new pull request, #22413: URL: https://github.com/apache/flink/pull/22413 ## What is the purpose of the change Add benchmarks for end to end restarting tasks ## Brief change log - *start scheduling tasks and then trigger global failover to restart all tasks*

[jira] [Created] (FLINK-31832) Add benchmarks for end to end  restarting tasks

2023-04-17 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-31832: - Summary: Add benchmarks for end to end  restarting tasks Key: FLINK-31832 URL: https://issues.apache.org/jira/browse/FLINK-31832 Project: Flink Issue Type: Improve

[jira] [Closed] (FLINK-31255) OperatorUtils#createWrappedOperatorConfig should update input and sideOutput serializers

2023-04-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed FLINK-31255. Resolution: Fixed > OperatorUtils#createWrappedOperatorConfig should update input and sideOutput > serial

[jira] [Assigned] (FLINK-31255) OperatorUtils#createWrappedOperatorConfig should update input and sideOutput serializers

2023-04-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-31255: Assignee: Jiang Xin > OperatorUtils#createWrappedOperatorConfig should update input and sideOutpu

[jira] [Commented] (FLINK-31255) OperatorUtils#createWrappedOperatorConfig should update input and sideOutput serializers

2023-04-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713397#comment-17713397 ] Dong Lin commented on FLINK-31255: -- Merged to apache/flink-ml master branch 894685455d

[jira] [Updated] (FLINK-31255) OperatorUtils#createWrappedOperatorConfig should update input and sideOutput serializers

2023-04-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31255: - Summary: OperatorUtils#createWrappedOperatorConfig should update input and sideOutput serializers (was:

[GitHub] [flink-ml] lindong28 merged pull request #229: [FLINK-31255] OperatorUtils#createWrappedOperatorConfig should update input and sideOutput serializers

2023-04-17 Thread via GitHub
lindong28 merged PR #229: URL: https://github.com/apache/flink-ml/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Updated] (FLINK-31255) OperatorUtils should update input and sideOutput serializers

2023-04-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31255: - Summary: OperatorUtils should update input and sideOutput serializers (was: OperatorUtils#createWrapped

[GitHub] [flink-ml] lindong28 commented on pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-17 Thread via GitHub
lindong28 commented on PR #229: URL: https://github.com/apache/flink-ml/pull/229#issuecomment-1512467383 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-31831) TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure is unstable

2023-04-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-31831: Priority: Critical (was: Major) > TaskManagerDisconnectOnShutdownITCase.testTaskManagerPr

[jira] [Created] (FLINK-31831) TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure is unstable

2023-04-17 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-31831: --- Summary: TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure is unstable Key: FLINK-31831 URL: https://issues.apache.org/jira/browse/FLINK-31831

[jira] [Commented] (FLINK-31823) RestHandlerConfigurationTest.testWebRescaleFeatureFlagWithReactiveMode is unstable

2023-04-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713394#comment-17713394 ] Sergey Nuyanzin commented on FLINK-31823: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-31820) Support data source sub-database and sub-table

2023-04-17 Thread Zhilong Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713385#comment-17713385 ] Zhilong Hong commented on FLINK-31820: -- According to this [reference|https://www.e

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169464509 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private OperatorMetricGr

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169459719 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private OperatorMetricGr

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169459719 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private OperatorMetricGr

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
zhipeng93 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1169459719 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -269,125 +279,136 @@ private OperatorMetricGr

[GitHub] [flink] luoyuxia commented on a diff in pull request #22294: [FLINK-31398][sql-gateway] OperationExecutor is no longer set context classloader when executing statement.

2023-04-17 Thread via GitHub
luoyuxia commented on code in PR #22294: URL: https://github.com/apache/flink/pull/22294#discussion_r1169457878 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -182,23 +181,17 @@ public ResultFetcher c

[jira] [Commented] (FLINK-31830) Coalesce on nested fields with different nullabilities will get wrong plan

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713364#comment-17713364 ] Weijie Guo commented on FLINK-31830: We'd better make sure, if 1.15 and later have n

[jira] [Assigned] (FLINK-31830) Coalesce on nested fields with different nullabilities will get wrong plan

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31830: -- Assignee: Jane Chan (was: Bi Jane Jia) > Coalesce on nested fields with different nullabilit

[jira] [Assigned] (FLINK-31830) Coalesce on nested fields with different nullabilities will get wrong plan

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31830: -- Assignee: Bi Jane Jia > Coalesce on nested fields with different nullabilities will get wrong

[GitHub] [flink-ml] jiangxin369 commented on pull request #233: [FLINK-31373] Fix NPE thrown in ProxyOutput

2023-04-17 Thread via GitHub
jiangxin369 commented on PR #233: URL: https://github.com/apache/flink-ml/pull/233#issuecomment-1512378341 @zhipeng93 Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Assigned] (FLINK-31829) Conversion to relational algebra failed to preserve datatypes' nullabilities

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31829: -- Assignee: Jane Chan > Conversion to relational algebra failed to preserve datatypes' nullabi

[GitHub] [flink] Shenjiaqi commented on pull request #22335: [FLINK-31708][API / Type Serialization System] make DataInputView#read(byte[], int, int) return 0 if len is 0.

2023-04-17 Thread via GitHub
Shenjiaqi commented on PR #22335: URL: https://github.com/apache/flink/pull/22335#issuecomment-1512371213 Thanks @gaoyunhaii for review. Now code is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Comment Edited] (FLINK-27130) unable to pass custom System properties through command line

2023-04-17 Thread Adrian Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520455#comment-17520455 ] Adrian Zhong edited comment on FLINK-27130 at 4/18/23 3:01 AM: ---

[jira] [Comment Edited] (FLINK-27130) unable to pass custom System properties through command line

2023-04-17 Thread Adrian Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520455#comment-17520455 ] Adrian Zhong edited comment on FLINK-27130 at 4/18/23 2:59 AM: ---

[jira] [Closed] (FLINK-31649) [Connectors/Jdbc] Fix archunit violations

2023-04-17 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-31649. -- Resolution: Fixed > [Connectors/Jdbc] Fix archunit violations > --

[jira] [Commented] (FLINK-31649) [Connectors/Jdbc] Fix archunit violations

2023-04-17 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713356#comment-17713356 ] Lijie Wang commented on FLINK-31649: Fix in main: 508b152bf7ee50643b6b3844f20289b646

[jira] [Comment Edited] (FLINK-31649) [Connectors/Jdbc] Fix archunit violations

2023-04-17 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713356#comment-17713356 ] Lijie Wang edited comment on FLINK-31649 at 4/18/23 2:58 AM: -

[GitHub] [flink-connector-jdbc] wanglijie95 merged pull request #31: [FLINK-31649] Fix archunit violations

2023-04-17 Thread via GitHub
wanglijie95 merged PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (FLINK-31830) Coalesce on nested fields with different nullabilities will get wrong plan

2023-04-17 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713353#comment-17713353 ] Jane Chan commented on FLINK-31830: --- I'd like to take this ticket. cc [~lincoln.86xy] 

[jira] [Commented] (FLINK-31829) Conversion to relational algebra failed to preserve datatypes' nullabilities

2023-04-17 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713352#comment-17713352 ] Jane Chan commented on FLINK-31829: --- Sure. I'd like to take this ticket. I reproduced

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-17 Thread via GitHub
lindong28 commented on code in PR #229: URL: https://github.com/apache/flink-ml/pull/229#discussion_r1168688436 ## flink-ml-iteration/src/test/java/org/apache/flink/iteration/operator/OperatorUtilsTest.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-17 Thread via GitHub
lindong28 commented on code in PR #229: URL: https://github.com/apache/flink-ml/pull/229#discussion_r1169428050 ## flink-ml-tests/src/test/java/org/apache/flink/test/iteration/UnboundedStreamIterationITCase.java: ## @@ -152,6 +160,39 @@ public void testVariableAndConstantBounded

[GitHub] [flink] yangjf2019 closed pull request #22274: [FLINK-31617] Upgrade the SnakeYaml and fabric8 version

2023-04-17 Thread via GitHub
yangjf2019 closed pull request #22274: [FLINK-31617] Upgrade the SnakeYaml and fabric8 version URL: https://github.com/apache/flink/pull/22274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Commented] (FLINK-31829) Conversion to relational algebra failed to preserve datatypes' nullabilities

2023-04-17 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713345#comment-17713345 ] lincoln lee commented on FLINK-31829: - The similar case in 1.14.6 encounter another

[jira] [Created] (FLINK-31830) Coalesce on nested fields with different nullabilities will get wrong plan

2023-04-17 Thread lincoln lee (Jira)
lincoln lee created FLINK-31830: --- Summary: Coalesce on nested fields with different nullabilities will get wrong plan Key: FLINK-31830 URL: https://issues.apache.org/jira/browse/FLINK-31830 Project: Fli

[jira] [Commented] (FLINK-31829) Conversion to relational algebra failed to preserve datatypes' nullabilities

2023-04-17 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713337#comment-17713337 ] lincoln lee commented on FLINK-31829: - [~qingyue] would you like to take over this j

[jira] [Created] (FLINK-31829) Conversion to relational algebra failed to preserve datatypes' nullabilities

2023-04-17 Thread lincoln lee (Jira)
lincoln lee created FLINK-31829: --- Summary: Conversion to relational algebra failed to preserve datatypes' nullabilities Key: FLINK-31829 URL: https://issues.apache.org/jira/browse/FLINK-31829 Project:

[GitHub] [flink] FangYongs commented on pull request #22360: [FLINK-31741][jdbc-driver] Support data converter for value in statement result

2023-04-17 Thread via GitHub
FangYongs commented on PR #22360: URL: https://github.com/apache/flink/pull/22360#issuecomment-1512288840 Thanks @libenchao DONE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Created] (FLINK-31828) List field in a POJO data stream results in table program compilation failure

2023-04-17 Thread Vladimir Matveev (Jira)
Vladimir Matveev created FLINK-31828: Summary: List field in a POJO data stream results in table program compilation failure Key: FLINK-31828 URL: https://issues.apache.org/jira/browse/FLINK-31828

[jira] [Assigned] (FLINK-28946) Remove RexSimplify together with calcite upgrade

2023-04-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-28946: --- Assignee: Sergey Nuyanzin > Remove RexSimplify together with calcite upgrade >

[GitHub] [flink] flinkbot commented on pull request #22412: [FLINK-31778][table-planner] Fix RowToRowCastRule

2023-04-17 Thread via GitHub
flinkbot commented on PR #22412: URL: https://github.com/apache/flink/pull/22412#issuecomment-1512033965 ## CI report: * 19dd086e1c5f720a5352b2548d0e06dc0e75e29c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] soin08 opened a new pull request, #22412: [FLINK-31778][table-planner] Fix RowToRowCastRule

2023-04-17 Thread via GitHub
soin08 opened a new pull request, #22412: URL: https://github.com/apache/flink/pull/22412 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink] soin08 closed pull request #22411: [FLINK-31778][table-planner] Fix RowToRowCastRule

2023-04-17 Thread via GitHub
soin08 closed pull request #22411: [FLINK-31778][table-planner] Fix RowToRowCastRule URL: https://github.com/apache/flink/pull/22411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (FLINK-31778) Casting array of rows produces incorrect result

2023-04-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31778: --- Labels: pull-request-available (was: ) > Casting array of rows produces incorrect result >

[GitHub] [flink] soin08 opened a new pull request, #22411: [FLINK-31778][table-planner] Fix RowToRowCastRule

2023-04-17 Thread via GitHub
soin08 opened a new pull request, #22411: URL: https://github.com/apache/flink/pull/22411 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

2023-04-17 Thread via GitHub
XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169042058 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation getLeaderInformat

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

2023-04-17 Thread via GitHub
XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169042058 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation getLeaderInformat

[GitHub] [flink] XComp commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the driver

2023-04-17 Thread via GitHub
XComp commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1169023770 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java: ## @@ -772,7 +773,11 @@ void testJobMasterServiceLeadershipR

[jira] [Commented] (FLINK-31769) Add percentiles to aggregated metrics

2023-04-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713204#comment-17713204 ] Gyula Fora commented on FLINK-31769: I think this would be a great addition if we ca

[jira] [Commented] (FLINK-31827) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713197#comment-17713197 ] Gyula Fora commented on FLINK-31827: Exactly, like: target.\{jobvertexId}.numRecord

[GitHub] [flink] reswqa commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the drive

2023-04-17 Thread via GitHub
reswqa commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1168903359 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -37,35 +37,58 @@ * Default implementation for leader el

[jira] [Commented] (FLINK-31827) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713192#comment-17713192 ] Zhanghao Chen commented on FLINK-31827: --- Thanks [~gyfora]. By "target jobvertex le

[GitHub] [flink] Myasuka commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-04-17 Thread via GitHub
Myasuka commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1168984233 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,14 +52,15 @@ * Store the meta of files

[jira] [Commented] (FLINK-31827) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713181#comment-17713181 ] Gyula Fora commented on FLINK-31827: The same issue can also be easily reproduced wi

[jira] [Commented] (FLINK-31826) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713178#comment-17713178 ] Gyula Fora commented on FLINK-31826: The same issue can also be easily reproduced wi

[jira] [Closed] (FLINK-31826) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen closed FLINK-31826. - Resolution: Duplicate > Incorrect estimation of the target data rate of a vertex when only a sub

[jira] [Commented] (FLINK-31826) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713165#comment-17713165 ] Zhanghao Chen commented on FLINK-31826: --- I'm sorry that I created duplicated issue

[jira] [Created] (FLINK-31827) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-31827: - Summary: Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed Key: FLINK-31827 URL: https://issues.apache.org/

[jira] [Created] (FLINK-31826) Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed

2023-04-17 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-31826: - Summary: Incorrect estimation of the target data rate of a vertex when only a subset of its upstream vertex's output is consumed Key: FLINK-31826 URL: https://issues.apache.org/

[jira] [Closed] (FLINK-31818) parsing error of 'security.kerberos.access.hadoopFileSystems' in flink-conf.yaml

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31818. -- Fix Version/s: 1.18.0 1.17.1 Resolution: Fixed > parsing error of 'security.

[jira] [Comment Edited] (FLINK-31818) parsing error of 'security.kerberos.access.hadoopFileSystems' in flink-conf.yaml

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713139#comment-17713139 ] Weijie Guo edited comment on FLINK-31818 at 4/17/23 3:16 PM: -

[jira] [Assigned] (FLINK-31649) [Connectors/Jdbc] Fix archunit violations

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31649: -- Assignee: João Boto > [Connectors/Jdbc] Fix archunit violations > ---

[jira] [Commented] (FLINK-31818) parsing error of 'security.kerberos.access.hadoopFileSystems' in flink-conf.yaml

2023-04-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713139#comment-17713139 ] Weijie Guo commented on FLINK-31818: master(1.18) via fe8ff46123ee2f9278066c80122841

[GitHub] [flink] reswqa merged pull request #22409: [FLINK-31818][docs, Runtime / Configuration] Replace 'comma-seperated' -> 'semicolon-seperated' of security.kerberos.access.hadoopFileSystems in do

2023-04-17 Thread via GitHub
reswqa merged PR #22409: URL: https://github.com/apache/flink/pull/22409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] dmvk commented on pull request #22408: [FLINK-31803] Harden UpdateJobResourceRequirementsRecoveryITCase.

2023-04-17 Thread via GitHub
dmvk commented on PR #22408: URL: https://github.com/apache/flink/pull/22408#issuecomment-1511537581 > Which terminal state did the job enter, and why? FAILED because during TM disconnect, the task failed, and the NoRestartStrategy tore the job down. > I think this is pr

[GitHub] [flink] dmvk commented on a diff in pull request #22408: [FLINK-31803] Harden UpdateJobResourceRequirementsRecoveryITCase.

2023-04-17 Thread via GitHub
dmvk commented on code in PR #22408: URL: https://github.com/apache/flink/pull/22408#discussion_r1168855893 ## flink-tests/src/test/java/org/apache/flink/test/recovery/UpdateJobResourceRequirementsRecoveryITCase.java: ## @@ -61,15 +64,25 @@ class UpdateJobResourceRequirementsRec

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #42: [FLINK-31820] Support data source sub-database and sub-table

2023-04-17 Thread via GitHub
MartijnVisser commented on PR #42: URL: https://github.com/apache/flink-connector-jdbc/pull/42#issuecomment-1511509388 > I have explained the changes according to the community contribution manual. Please check the commit naming convention. Also, see my remark in the original Jira t

[GitHub] [flink] zentol commented on a diff in pull request #22380: [FLINK-31773][runtime] Separate DefaultLeaderElectionService.start(LeaderContender) into two separate methods for starting the drive

2023-04-17 Thread via GitHub
zentol commented on code in PR #22380: URL: https://github.com/apache/flink/pull/22380#discussion_r1168724716 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java: ## @@ -70,22 +77,37 @@ public LeaderInformation getLeaderInforma

[GitHub] [flink-web] echauchot commented on a diff in pull request #631: Add blog article: Howto migrate a real-life batch pipeline from the DataSet API to the DataStream API

2023-04-17 Thread via GitHub
echauchot commented on code in PR #631: URL: https://github.com/apache/flink-web/pull/631#discussion_r1168766496 ## docs/content/posts/2023-04-12-howto-migrate-to-datastream.md: ## @@ -0,0 +1,190 @@ +--- +title: "Howto migrate a real-life batch pipeline from the DataSet API to

[GitHub] [flink] XComp commented on a diff in pull request #22384: [FLINK-31776][runtime] Introduces LeaderElection sub-interface

2023-04-17 Thread via GitHub
XComp commented on code in PR #22384: URL: https://github.com/apache/flink/pull/22384#discussion_r1168749109 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionService.java: ## @@ -53,24 +50,35 @@ public interface LeaderElectionService { vo

[jira] [Commented] (FLINK-31824) flink sql TO_TIMESTAMP error

2023-04-17 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713105#comment-17713105 ] Feng Jin commented on FLINK-31824: -- [~leishuiyu]  You can try this :  {code:java} //代码占

[jira] [Commented] (FLINK-30772) Update Flink Shaded dependencies to the latest versions

2023-04-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713097#comment-17713097 ] Matthias Pohl commented on FLINK-30772: --- Great, let me know if I can help in any w

[GitHub] [flink] SML0127 closed pull request #22409: [FLINK-31818][docs, Runtime / Configuration] Replace 'comma-seperated' -> 'semicolon-seperated' of security.kerberos.access.hadoopFileSystems in d

2023-04-17 Thread via GitHub
SML0127 closed pull request #22409: [FLINK-31818][docs, Runtime / Configuration] Replace 'comma-seperated' -> 'semicolon-seperated' of security.kerberos.access.hadoopFileSystems in docs and edit comma to semicolon in example of SecurityOptions.java URL: https://github.com/apache/flink/pull/22

[jira] [Commented] (FLINK-30772) Update Flink Shaded dependencies to the latest versions

2023-04-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713096#comment-17713096 ] Martijn Visser commented on FLINK-30772: [~mapohl] Yes, it's on my list :D > U

[GitHub] [flink] zentol commented on a diff in pull request #22408: [FLINK-31803] Harden UpdateJobResourceRequirementsRecoveryITCase.

2023-04-17 Thread via GitHub
zentol commented on code in PR #22408: URL: https://github.com/apache/flink/pull/22408#discussion_r1168703853 ## flink-tests/src/test/java/org/apache/flink/test/recovery/UpdateJobResourceRequirementsRecoveryITCase.java: ## @@ -61,15 +64,25 @@ class UpdateJobResourceRequirementsR

[jira] [Created] (FLINK-31825) Stopping minikube fails with timeout

2023-04-17 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-31825: --- Summary: Stopping minikube fails with timeout Key: FLINK-31825 URL: https://issues.apache.org/jira/browse/FLINK-31825 Project: Flink Issue Type: Bug

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #229: [FLINK-31255] Wraps the operator config about serializer

2023-04-17 Thread via GitHub
lindong28 commented on code in PR #229: URL: https://github.com/apache/flink-ml/pull/229#discussion_r1168688436 ## flink-ml-iteration/src/test/java/org/apache/flink/iteration/operator/OperatorUtilsTest.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
lindong28 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168661638 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/operator/AbstractBroadcastWrapperOperator.java: ## @@ -169,13 +182,16 @@

[jira] [Commented] (FLINK-30772) Update Flink Shaded dependencies to the latest versions

2023-04-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713078#comment-17713078 ] Matthias Pohl commented on FLINK-30772: --- [~martijnvisser] will you work on releasi

[GitHub] [flink] snuyanzin commented on pull request #22257: [FLINK-31593][tests] Upgraded migration test data

2023-04-17 Thread via GitHub
snuyanzin commented on PR #22257: URL: https://github.com/apache/flink/pull/22257#issuecomment-1511294073 I verified version updates it looks ok from my side. The only comment I have is about RocksDB option files -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink] snuyanzin commented on a diff in pull request #22257: [FLINK-31593][tests] Upgraded migration test data

2023-04-17 Thread via GitHub
snuyanzin commented on code in PR #22257: URL: https://github.com/apache/flink/pull/22257#discussion_r1168654827 ## flink-tests/src/test/resources/new-stateful-broadcast-udf-migration-itcase-flink1.17-rocksdb-checkpoint/0193581b-bd07-4b9d-b5d3-a6c986164fa4: ## @@ -0,0 +1,362 @@

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
lindong28 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168650339 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/BroadcastUtils.java: ## @@ -152,41 +155,52 @@ private static DataStream cacheBroadcastVariables(

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #215: [FLINK-31160] Support join/cogroup in BroadcastUtils.withBroadcastStream

2023-04-17 Thread via GitHub
lindong28 commented on code in PR #215: URL: https://github.com/apache/flink-ml/pull/215#discussion_r1168444551 ## flink-ml-core/src/main/java/org/apache/flink/ml/common/broadcast/BroadcastUtils.java: ## @@ -116,19 +119,19 @@ public static DataStream withBroadcastStream( }

[jira] [Updated] (FLINK-31824) flink sql TO_TIMESTAMP error

2023-04-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31824: --- Fix Version/s: (was: 1.8.4) > flink sql TO_TIMESTAMP error > ---

[GitHub] [flink] pnowojski commented on a diff in pull request #22392: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type after aligned barrier timeout to unaligned barrier on PipelinedSu

2023-04-17 Thread via GitHub
pnowojski commented on code in PR #22392: URL: https://github.com/apache/flink/pull/22392#discussion_r1168635822 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -381,7 +383,7 @@ private void registerAlig

[GitHub] [flink] pnowojski commented on a diff in pull request #22392: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type after aligned barrier timeout to unaligned barrier on PipelinedSu

2023-04-17 Thread via GitHub
pnowojski commented on code in PR #22392: URL: https://github.com/apache/flink/pull/22392#discussion_r1168635822 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java: ## @@ -381,7 +383,7 @@ private void registerAlig

[jira] [Updated] (FLINK-31373) PerRoundWrapperOperator should carry epoch information in watermark

2023-04-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31373: --- Labels: pull-request-available (was: ) > PerRoundWrapperOperator should carry epoch informa

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #233: [FLINK-31373] Fix NPE thrown in ProxyOutput

2023-04-17 Thread via GitHub
jiangxin369 opened a new pull request, #233: URL: https://github.com/apache/flink-ml/pull/233 ## What is the purpose of the change Fix NPE thrown in ProxyOutput ## Brief change log - Fix NPE thrown in ProxyOutput. ## Does this pull request potentially aff

[jira] [Commented] (FLINK-31772) AsyncSinkWriter Performance regression due to AIMD rate limiting strategy

2023-04-17 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713067#comment-17713067 ] Ahmed Hamdy commented on FLINK-31772: - Thanks [~dannycranmer] I have published a fi

[jira] [Updated] (FLINK-31772) AsyncSinkWriter Performance regression due to AIMD rate limiting strategy

2023-04-17 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-31772: Attachment: Screenshot 2023-04-17 at 13.03.34-1.png > AsyncSinkWriter Performance regression due t

[GitHub] [flink] libenchao commented on a diff in pull request #22360: [FLINK-31741][jdbc-driver] Support data converter for value in statement result

2023-04-17 Thread via GitHub
libenchao commented on code in PR #22360: URL: https://github.com/apache/flink/pull/22360#discussion_r1168600675 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/utils/DefaultDataConverter.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache So

  1   2   >