[GitHub] [flink] Aitozi commented on pull request #22369: [FLINK-31755][planner] Make SqlRowOperator to create row with PEEK_FIELDS_NO_EXPAND struct type

2023-04-07 Thread via GitHub
Aitozi commented on PR #22369: URL: https://github.com/apache/flink/pull/22369#issuecomment-1500774206 CC @lincoln-lil Can you please also help review this PR, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (FLINK-31588) The unaligned checkpoint type is wrong at subtask level

2023-04-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709823#comment-17709823 ] Rui Fan commented on FLINK-31588: - Thanks for your feedback. {quote} If checkpoint was u

[GitHub] [flink] slfan1989 commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-04-07 Thread via GitHub
slfan1989 commented on code in PR #22207: URL: https://github.com/apache/flink/pull/22207#discussion_r1160998952 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1945,8 +1938,4 @@ Map generateApplicationMasterEnv( Utils.setupYarnClass

[jira] [Commented] (FLINK-31588) The unaligned checkpoint type is wrong at subtask level

2023-04-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709783#comment-17709783 ] Piotr Nowojski commented on FLINK-31588: Sorry for late response, I've just foun

[jira] [Comment Edited] (FLINK-21949) Support collect to array aggregate function

2023-04-07 Thread Roland Johann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709755#comment-17709755 ] Roland Johann edited comment on FLINK-21949 at 4/7/23 6:50 PM: ---

[jira] [Commented] (FLINK-21949) Support collect to array aggregate function

2023-04-07 Thread Roland Johann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709755#comment-17709755 ] Roland Johann commented on FLINK-21949: --- Is someone working on this one? If someon

[GitHub] [flink] flinkbot commented on pull request #22370: [hotfix] Fix typos of comment

2023-04-07 Thread via GitHub
flinkbot commented on PR #22370: URL: https://github.com/apache/flink/pull/22370#issuecomment-1500531387 ## CI report: * 2d915808770bc98569b6c084f48bbbcddc74e88f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] hustonic opened a new pull request, #22370: [hotfix] Fix typos of comment

2023-04-07 Thread via GitHub
hustonic opened a new pull request, #22370: URL: https://github.com/apache/flink/pull/22370 ## What is the purpose of the change Fix typos of comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink] hustonic closed pull request #22368: [hotfix] Fix incorrect comment.

2023-04-07 Thread via GitHub
hustonic closed pull request #22368: [hotfix] Fix incorrect comment. URL: https://github.com/apache/flink/pull/22368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [flink-connector-kafka] jeremy-degroot commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-04-07 Thread via GitHub
jeremy-degroot commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1160854136 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReaderTest.java: ## @@ -319,6 +321,51 @@ publ

[jira] [Updated] (FLINK-31755) ROW function can not work with RewriteIntersectAllRule

2023-04-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31755: --- Labels: pull-request-available (was: ) > ROW function can not work with RewriteIntersectAll

[GitHub] [flink] flinkbot commented on pull request #22369: [FLINK-31755][planner] Make SqlRowOperator to create row with PEEK_FIELDS_NO_EXPAND struct type

2023-04-07 Thread via GitHub
flinkbot commented on PR #22369: URL: https://github.com/apache/flink/pull/22369#issuecomment-1500478242 ## CI report: * b2d7c2f3c959d62f48cc64f4b3c898ebfbacbf15 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Aitozi opened a new pull request, #22369: aupdate

2023-04-07 Thread via GitHub
Aitozi opened a new pull request, #22369: URL: https://github.com/apache/flink/pull/22369 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink] flinkbot commented on pull request #22368: [hotfix] Fix incorrect comment.

2023-04-07 Thread via GitHub
flinkbot commented on PR #22368: URL: https://github.com/apache/flink/pull/22368#issuecomment-1500461161 ## CI report: * 79facde5ed44dc1ffa2277ef53cb736602e20bd1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] hustonic opened a new pull request, #22368: [hotfix] Fix incorrect comment.

2023-04-07 Thread via GitHub
hustonic opened a new pull request, #22368: URL: https://github.com/apache/flink/pull/22368 ## What is the purpose of the change Fix typos of comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] Aitozi commented on pull request #22363: [FLINK-31301][planner] Add support of nested columns in column list o…

2023-04-07 Thread via GitHub
Aitozi commented on PR #22363: URL: https://github.com/apache/flink/pull/22363#issuecomment-1500451435 @lincoln-lil please take a look when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [flink] reswqa commented on a diff in pull request #21527: [FLINK-27925] [kubernetes]Performance optimization when watch tm pod and list pod.

2023-04-07 Thread via GitHub
reswqa commented on code in PR #21527: URL: https://github.com/apache/flink/pull/21527#discussion_r1160799424 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java: ## @@ -191,7 +192,12 @@ public Optional getRestEndpoint(String clu

[GitHub] [flink-connector-kafka] jeremy-degroot commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-04-07 Thread via GitHub
jeremy-degroot commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1160774759 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java: ## @@ -80,11 +80,20 @@ public Ka

[GitHub] [flink] reswqa commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-04-07 Thread via GitHub
reswqa commented on code in PR #22207: URL: https://github.com/apache/flink/pull/22207#discussion_r1160752449 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1945,8 +1938,4 @@ Map generateApplicationMasterEnv( Utils.setupYarnClassPat

[GitHub] [flink] reswqa commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-04-07 Thread via GitHub
reswqa commented on code in PR #22207: URL: https://github.com/apache/flink/pull/22207#discussion_r1160743167 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1945,8 +1938,4 @@ Map generateApplicationMasterEnv( Utils.setupYarnClassPat

[GitHub] [flink] reswqa commented on a diff in pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-04-07 Thread via GitHub
reswqa commented on code in PR #22207: URL: https://github.com/apache/flink/pull/22207#discussion_r1160743167 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1945,8 +1938,4 @@ Map generateApplicationMasterEnv( Utils.setupYarnClassPat

[GitHub] [flink-connector-kafka] jeremy-degroot commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

2023-04-07 Thread via GitHub
jeremy-degroot commented on code in PR #20: URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1160718505 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReaderTest.java: ## @@ -319,6 +321,51 @@ publ

[GitHub] [flink] huwh commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-04-07 Thread via GitHub
huwh commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1160704473 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster( if (

[jira] [Updated] (FLINK-31755) ROW function can not work with RewriteIntersectAllRule

2023-04-07 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-31755: --- Description: Reproduce case: {code:java} create table row_sink ( `b` ROW ) with ( 'connector' = 'value

[jira] [Created] (FLINK-31755) ROW function can not work with RewriteIntersectAllRule

2023-04-07 Thread Aitozi (Jira)
Aitozi created FLINK-31755: -- Summary: ROW function can not work with RewriteIntersectAllRule Key: FLINK-31755 URL: https://issues.apache.org/jira/browse/FLINK-31755 Project: Flink Issue Type: Bug

[GitHub] [flink-ml] lindong28 commented on pull request #230: [FLINK-31753] Support DataStream CoGroup in stream mode with similar performance as DataSet CoGroup

2023-04-07 Thread via GitHub
lindong28 commented on PR #230: URL: https://github.com/apache/flink-ml/pull/230#issuecomment-1500262051 @zhipeng93 Can you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (FLINK-31754) Build flink master error with Error in ASM processing class org/apache/calcite/sql/validate/SqlValidatorImpl$NavigationExpander.class: 19

2023-04-07 Thread dragon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dragon updated FLINK-31754: --- Description: maven 3.25 jdk 1.8 scala 2.12 window 10 [E:\Project\flink\flink\flink-table\flink-table-pla

[jira] [Updated] (FLINK-31754) Build flink master error with Error in ASM processing class org/apache/calcite/sql/validate/SqlValidatorImpl$NavigationExpander.class: 19

2023-04-07 Thread dragon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dragon updated FLINK-31754: --- Description: maven 3.25 jdk 1.8 window 10 [E:\Project\flink\flink\flink-table\flink-table-planner]$ mvn p

[jira] [Updated] (FLINK-31753) Support DataStream CoGroup in stream Mode with similar performance as DataSet CoGroup

2023-04-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31753: --- Labels: pull-request-available (was: ) > Support DataStream CoGroup in stream Mode with sim

[GitHub] [flink-ml] lindong28 opened a new pull request, #230: [FLINK-31753] Support DataStream CoGroup in stream Mode with similar performance as DataSet CoGroup

2023-04-07 Thread via GitHub
lindong28 opened a new pull request, #230: URL: https://github.com/apache/flink-ml/pull/230 ## What is the purpose of the change Add util methods that allow algorithm developers to co-group two DataStreams with the same semantics and similar performance as `DataSet#coGroup(...)`

[jira] [Updated] (FLINK-31754) Build flink master error with Error in ASM processing class org/apache/calcite/sql/validate/SqlValidatorImpl$NavigationExpander.class: 19

2023-04-07 Thread dragon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dragon updated FLINK-31754: --- Affects Version/s: 1.18.0 > Build flink master error with Error in ASM processing class > org/apache/calcit

[GitHub] [flink] slfan1989 commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-04-07 Thread via GitHub
slfan1989 commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1160653403 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster(

[jira] [Comment Edited] (FLINK-31603) Line break should be removed in create table with-clauses, load module with-clauses and table hints for both keys and values

2023-04-07 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709664#comment-17709664 ] Jark Wu edited comment on FLINK-31603 at 4/7/23 11:36 AM: -- Hi [

[jira] [Commented] (FLINK-31603) Line break should be removed in create table with-clauses, load module with-clauses and table hints for both keys and values

2023-04-07 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709664#comment-17709664 ] Jark Wu commented on FLINK-31603: - Hi [~paul8263], this is an expected behavior in SQL,

[jira] [Created] (FLINK-31754) Build flink master error with Error in ASM processing class org/apache/calcite/sql/validate/SqlValidatorImpl$NavigationExpander.class: 19

2023-04-07 Thread zhenlong dong (Jira)
zhenlong dong created FLINK-31754: - Summary: Build flink master error with Error in ASM processing class org/apache/calcite/sql/validate/SqlValidatorImpl$NavigationExpander.class: 19 Key: FLINK-31754 URL: https:/

[GitHub] [flink] slfan1989 commented on pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-04-07 Thread via GitHub
slfan1989 commented on PR #22207: URL: https://github.com/apache/flink/pull/22207#issuecomment-1500183076 @reswqa Can you help review this PR again? Thank you very much! I explained the reason for possible negative numbers. -- This is an automated message from the Apache Git Service. To r

[GitHub] [flink] huwh commented on a diff in pull request #21527: [FLINK-27925] [kubernetes]Performance optimization when watch tm pod and list pod.

2023-04-07 Thread via GitHub
huwh commented on code in PR #21527: URL: https://github.com/apache/flink/pull/21527#discussion_r1160572180 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java: ## @@ -191,7 +192,12 @@ public Optional getRestEndpoint(String clust

[GitHub] [flink] pltbkd commented on a diff in pull request #22291: [FLINK-31632] Fix maxAllowedWatermark arithmetic overflow when the source is idle

2023-04-07 Thread via GitHub
pltbkd commented on code in PR #22291: URL: https://github.com/apache/flink/pull/22291#discussion_r1160621805 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -178,9 +178,16 @@ void announceCombinedWatermark() {

[jira] [Updated] (FLINK-31753) Support DataStream CoGroup in stream Mode with similar performance as DataSet CoGroup

2023-04-07 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31753: - Description: DataSet has been deprecated and will be removed from Flink. However, DataStream CoCroup is

[jira] [Updated] (FLINK-31753) Support DataStream CoGroup in stream Mode with similar performance as DataSet CoGroup

2023-04-07 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31753: - Description: DataSet has been deprecated and will be removed from Flink. However, DataStream CoCroup is

[jira] [Created] (FLINK-31753) Support DataStream CoGroup in stream Mode with similar performance as DataSet CoGroup

2023-04-07 Thread Dong Lin (Jira)
Dong Lin created FLINK-31753: Summary: Support DataStream CoGroup in stream Mode with similar performance as DataSet CoGroup Key: FLINK-31753 URL: https://issues.apache.org/jira/browse/FLINK-31753 Project

[GitHub] [flink] gj199575 commented on pull request #22103: [FLINK-28825] Add K8S pod scheduler into Kubernetes options [FLINK-28829] Support prepreparing K8S resources before JM creation [FLINK-28831

2023-04-07 Thread via GitHub
gj199575 commented on PR #22103: URL: https://github.com/apache/flink/pull/22103#issuecomment-1500120459 > We are still using flink1.12. What should I do to use this pr in 1.12 or 1.15? I tried to merge this pr in 1.12 and found that the difference is too big and it is difficult to merge. I

[jira] [Commented] (FLINK-31752) SourceOperatorStreamTask increments numRecordsOut twice

2023-04-07 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709633#comment-17709633 ] Dong Lin commented on FLINK-31752: -- [~huwh] Thanks for reporting this bug. I will look

[jira] [Assigned] (FLINK-31752) SourceOperatorStreamTask increments numRecordsOut twice

2023-04-07 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-31752: Assignee: Dong Lin > SourceOperatorStreamTask increments numRecordsOut twice > --

[jira] [Closed] (FLINK-31726) PyFlink module java.base does not "opens java.lang" to unnamed module

2023-04-07 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang closed FLINK-31726. Resolution: Not A Problem Flink doesn't support JDK 19, you can try to use jdk 8 or jdk 11. > PyF

[jira] [Commented] (FLINK-30989) Configuration table.exec.spill-compression.block-size not take effect in batch job

2023-04-07 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709623#comment-17709623 ] dalongliu commented on FLINK-30989: --- [~Weijie Guo] Yes, we need to pick it back to rel

[jira] [Updated] (FLINK-31752) SourceOperatorStreamTask increments numRecordsOut twice

2023-04-07 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-31752: -- Description: The counter of numRecordsOut was introduce to ChainingOutput to reduce the function call

[jira] [Updated] (FLINK-31752) SourceOperatorStreamTask increments numRecordsOut twice

2023-04-07 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-31752: -- Description: The counter of numRecordsOut was introduce to ChainingOutput to reduce the function call

[jira] [Created] (FLINK-31752) SourceOperatorStreamTask increments numRecordsOut twice

2023-04-07 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-31752: - Summary: SourceOperatorStreamTask increments numRecordsOut twice Key: FLINK-31752 URL: https://issues.apache.org/jira/browse/FLINK-31752 Project: Flink Issue Type:

[jira] [Commented] (FLINK-31751) array return type SpecificTypeStrategies.ARRAY and ifThenElse return type is not correct

2023-04-07 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709612#comment-17709612 ] jackylau commented on FLINK-31751: -- hi [~twalthr] [~jark] what do you think? > array r

[jira] [Created] (FLINK-31751) array return type SpecificTypeStrategies.ARRAY and ifThenElse return type is not correct

2023-04-07 Thread jackylau (Jira)
jackylau created FLINK-31751: Summary: array return type SpecificTypeStrategies.ARRAY and ifThenElse return type is not correct Key: FLINK-31751 URL: https://issues.apache.org/jira/browse/FLINK-31751 Proj