[GitHub] [flink] WencongLiu opened a new pull request, #21645: [FLINK-30556] Improve the logic for enumerating splits for Hive source to avoid potential OOM

2023-01-10 Thread GitBox
WencongLiu opened a new pull request, #21645: URL: https://github.com/apache/flink/pull/21645 ## What is the purpose of the change Improve the logic for enumerating splits for Hive source to avoid potential OOM ## Brief change log - *Introduce the HiveSourc

[GitHub] [flink-connector-pulsar] tisonkun merged pull request #16: [BK-3.0][FLINK-30552][Connector/Pulsar] drop batch message size assertion, better set the cursor position.

2023-01-10 Thread GitBox
tisonkun merged PR #16: URL: https://github.com/apache/flink-connector-pulsar/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [flink] xintongsong commented on a diff in pull request #21603: [FLINK-30332] HsFileDataIndex supports caching and spilling index entry

2023-01-10 Thread GitBox
xintongsong commented on code in PR #21603: URL: https://github.com/apache/flink/pull/21603#discussion_r1065378796 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsFileDataIndexSpilledRegionManagerImpl.java: ## @@ -0,0 +1,288 @@ +/* + * Licen

[jira] [Assigned] (FLINK-14023) Support accessing job parameters in Python user-defined functions

2023-01-10 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-14023: --- Assignee: Dian Fu > Support accessing job parameters in Python user-defined functions > ---

[GitHub] [flink] flinkbot commented on pull request #21644: [FLINK-14023][python] Support accessing job parameters in Python user-defined functions

2023-01-10 Thread GitBox
flinkbot commented on PR #21644: URL: https://github.com/apache/flink/pull/21644#issuecomment-1378346642 ## CI report: * ece5fc636eff04178c8b0f13c43799eefb08189b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30612) ObjectArrayConverter is not thread-safe,raised by reuseArray、reuseWriter

2023-01-10 Thread guoxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] guoxin updated FLINK-30612: --- Component/s: Table SQL / API Table SQL / Runtime > ObjectArrayConverter is not thread-safe,

[jira] [Updated] (FLINK-14023) Support accessing job parameters in Python user-defined functions

2023-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14023: --- Labels: pull-request-available (was: ) > Support accessing job parameters in Python user-de

[GitHub] [flink] dianfu opened a new pull request, #21644: [FLINK-14023][python] Support accessing job parameters in Python user-defined functions

2023-01-10 Thread GitBox
dianfu opened a new pull request, #21644: URL: https://github.com/apache/flink/pull/21644 ## What is the purpose of the change *This pull request allows to access the job parameters defined in Python user-defined functions* ## Verifying this change Please make su

[GitHub] [flink] ruanhang1993 commented on pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-01-10 Thread GitBox
ruanhang1993 commented on PR #21589: URL: https://github.com/apache/flink/pull/21589#issuecomment-1378316766 @lindong28 @PatrickRen Could you help to review this PR? Thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1066577618 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/OnlineStandardScalerTest.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] zhipeng93 commented on pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on PR #196: URL: https://github.com/apache/flink-ml/pull/196#issuecomment-1378314881 > @zhipeng93 Thanks for the PR, left some comments. Thanks @jiangxin369 for the review. I have addressed your comments in the latest commit. Please take a look. -- This is an au

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1066632174 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/standardscaler/OnlineStandardScalerParams.java: ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software F

[jira] [Updated] (FLINK-30615) Refactor ReadWriteTableITCase to get rid of Managed Table

2023-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30615: --- Labels: pull-request-available (was: ) > Refactor ReadWriteTableITCase to get rid of Manage

[GitHub] [flink-table-store] yuzelin opened a new pull request, #478: [FLINK-30615] Refactor ReadWriteTableITCase to get rid of Managed Table and introduce new AbstractTestBase

2023-01-10 Thread GitBox
yuzelin opened a new pull request, #478: URL: https://github.com/apache/flink-table-store/pull/478 1. Split Kafka log related cases into a new test class. 2. `testQueryContainsDefaultFieldName` & `testSuccessiveWriteAndRead` in `ReadWriteTableITCase` seems trivial so I remove them. 3.

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #475: [FLINK-30620] Table Store Hive catalog supports specifying custom Hive metastore client

2023-01-10 Thread GitBox
tsreaper commented on code in PR #475: URL: https://github.com/apache/flink-table-store/pull/475#discussion_r1066610241 ## flink-table-store-hive/flink-table-store-hive-catalog/src/main/java/org/apache/flink/table/store/hive/HiveCatalogOptions.java: ## @@ -0,0 +1,34 @@ +/* + * L

[GitHub] [flink] swuferhong commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-01-10 Thread GitBox
swuferhong commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1066609115 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/SubplanReuseTest.scala: ## @@ -248,6 +248,44 @@ class SubplanReuseTe

[GitHub] [flink] swuferhong commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-01-10 Thread GitBox
swuferhong commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1066608228 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/SubplanReuseTest.scala: ## @@ -334,6 +334,44 @@ class SubplanReuseTes

[GitHub] [flink] fsk119 commented on a diff in pull request #21581: [FLINK-30538][SQL gateway/client] Improve error handling of stop job operation

2023-01-10 Thread GitBox
fsk119 commented on code in PR #21581: URL: https://github.com/apache/flink/pull/21581#discussion_r1066602543 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -487,23 +487,22 @@ public ResultFetcher cal

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #471: [FLINK-30608] support rename table

2023-01-10 Thread GitBox
zhangjun0x01 commented on code in PR #471: URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1066603066 ## flink-table-store-hive/flink-table-store-hive-catalog/src/test/java/org/apache/flink/table/store/hive/HiveCatalogITCase.java: ## @@ -276,6 +279,36 @@ pu

[GitHub] [flink] fsk119 commented on a diff in pull request #21582: [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway

2023-01-10 Thread GitBox
fsk119 commented on code in PR #21582: URL: https://github.com/apache/flink/pull/21582#discussion_r1066565533 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -524,6 +533,47 @@ private ResultFetcher bui

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #471: [FLINK-30608] support rename table

2023-01-10 Thread GitBox
JingsongLi commented on code in PR #471: URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1066593633 ## flink-table-store-hive/flink-table-store-hive-catalog/src/test/java/org/apache/flink/table/store/hive/HiveCatalogITCase.java: ## @@ -276,6 +279,36 @@ publ

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #475: [FLINK-30620] Table Store Hive catalog supports specifying custom Hive metastore client

2023-01-10 Thread GitBox
JingsongLi commented on code in PR #475: URL: https://github.com/apache/flink-table-store/pull/475#discussion_r1066589722 ## docs/layouts/shortcodes/generated/hive_catalog_configuration.html: ## @@ -0,0 +1,18 @@ + + + +Key +Default +

[jira] [Commented] (FLINK-30168) PyFlink Deserialization Error with Object Array

2023-01-10 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657083#comment-17657083 ] Dian Fu commented on FLINK-30168: - [~yunfengzhou] Could you share some code snippets whi

[GitHub] [flink] lindong28 commented on a diff in pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-10 Thread GitBox
lindong28 commented on code in PR #21621: URL: https://github.com/apache/flink/pull/21621#discussion_r1066582414 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BootstrapStreamTask.java: ## @@ -82,16 +86,14 @@ protected void init() t

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #502: [FLINK-30574] Detect ineffective scale up operations to avoid scaling further

2023-01-10 Thread GitBox
gyfora commented on code in PR #502: URL: https://github.com/apache/flink-kubernetes-operator/pull/502#discussion_r1066577710 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobVertexScaler.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed t

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1066577618 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/OnlineStandardScalerTest.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1066575361 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/standardscaler/OnlineStandardScaler.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #502: [FLINK-30574] Detect ineffective scale up operations to avoid scaling further

2023-01-10 Thread GitBox
gyfora commented on code in PR #502: URL: https://github.com/apache/flink-kubernetes-operator/pull/502#discussion_r1066574644 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobVertexScaler.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed t

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1066574806 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/standardscaler/OnlineStandardScaler.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1066574806 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/standardscaler/OnlineStandardScaler.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #502: [FLINK-30574] Detect ineffective scale up operations to avoid scaling further

2023-01-10 Thread GitBox
gyfora commented on code in PR #502: URL: https://github.com/apache/flink-kubernetes-operator/pull/502#discussion_r1066574644 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobVertexScaler.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed t

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #502: [FLINK-30574] Detect ineffective scale up operations to avoid scaling further

2023-01-10 Thread GitBox
gyfora commented on code in PR #502: URL: https://github.com/apache/flink-kubernetes-operator/pull/502#discussion_r1066572069 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobVertexScaler.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed t

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #502: [FLINK-30574] Detect ineffective scale up operations to avoid scaling further

2023-01-10 Thread GitBox
gyfora commented on code in PR #502: URL: https://github.com/apache/flink-kubernetes-operator/pull/502#discussion_r1066571479 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobVertexScaler.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed t

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #471: [FLINK-30608] support rename table

2023-01-10 Thread GitBox
zhangjun0x01 commented on code in PR #471: URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1066569592 ## flink-table-store-hive/flink-table-store-hive-catalog/src/test/java/org/apache/flink/table/store/hive/HiveCatalogITCase.java: ## @@ -276,6 +279,36 @@ pu

[jira] [Commented] (FLINK-30609) Add ephemeral storage to CRD

2023-01-10 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657076#comment-17657076 ] Gyula Fora commented on FLINK-30609: +1 from my part, this indeed seems to be a comm

[jira] [Commented] (FLINK-30609) Add ephemeral storage to CRD

2023-01-10 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657075#comment-17657075 ] Gyula Fora commented on FLINK-30609: Are you suggesting simply adding: ``` ephemeral

[GitHub] [flink-table-store] JingsongLi commented on pull request #471: [FLINK-30608] support rename table

2023-01-10 Thread GitBox
JingsongLi commented on PR #471: URL: https://github.com/apache/flink-table-store/pull/471#issuecomment-1378230909 > The point is: there is only one implementation for `Catalog.getTableLocation`, that is `AbstractCatalog.getTableLocation` -- This is an automated message from the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #471: [FLINK-30608] support rename table

2023-01-10 Thread GitBox
JingsongLi commented on code in PR #471: URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1066564740 ## flink-table-store-hive/flink-table-store-hive-catalog/src/test/java/org/apache/flink/table/store/hive/HiveCatalogITCase.java: ## @@ -276,6 +279,36 @@ publ

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #477: [FLINK-30628] Kerberos in HiveCatalog is not work

2023-01-10 Thread GitBox
JingsongLi opened a new pull request, #477: URL: https://github.com/apache/flink-table-store/pull/477 We should read kerberos keytab from catalog options and doAs for hive metastore client. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (FLINK-30628) Kerberos in HiveCatalog is not work

2023-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30628: --- Labels: pull-request-available (was: ) > Kerberos in HiveCatalog is not work >

[jira] [Created] (FLINK-30628) Kerberos in HiveCatalog is not work

2023-01-10 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-30628: Summary: Kerberos in HiveCatalog is not work Key: FLINK-30628 URL: https://issues.apache.org/jira/browse/FLINK-30628 Project: Flink Issue Type: Bug

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #476: [FLINK-30628] Kerberos in HiveCatalog is not work

2023-01-10 Thread GitBox
JingsongLi opened a new pull request, #476: URL: https://github.com/apache/flink-table-store/pull/476 We should read kerberos keytab from catalog options and doAs for hive metastore client. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066558831 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/common/JoinReorderTestBase.scala: ## @@ -121,6 +121,8 @@ abstract class JoinReo

[GitHub] [flink] fsk119 commented on a diff in pull request #20822: [FLINK-25447][table-planner] Fix batch query cannot generate plan when a sorted view into multi sinks

2023-01-10 Thread GitBox
fsk119 commented on code in PR #20822: URL: https://github.com/apache/flink/pull/20822#discussion_r1066546132 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdDistribution.scala: ## @@ -87,6 +87,10 @@ class FlinkRelMdDistri

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-10 Thread GitBox
zhuzhurk commented on code in PR #21621: URL: https://github.com/apache/flink/pull/21621#discussion_r106677 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BootstrapStreamTask.java: ## @@ -82,16 +86,14 @@ protected void init() th

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #196: [FLINK-30541] Add Transformer and Estimator for OnlineStandardScaler

2023-01-10 Thread GitBox
zhipeng93 commented on code in PR #196: URL: https://github.com/apache/flink-ml/pull/196#discussion_r1066549248 ## flink-ml-python/pyflink/ml/lib/param.py: ## @@ -581,3 +581,48 @@ def get_flatten(self) -> bool: @property def flatten(self): return self.get(self

[jira] [Resolved] (FLINK-30401) Add Estimator and Transformer for MinHashLSH

2023-01-10 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang resolved FLINK-30401. --- Resolution: Fixed > Add Estimator and Transformer for MinHashLSH > -

[GitHub] [flink] flinkbot commented on pull request #21643: [hotfix][docs][table] Fix broken links in determinism.md

2023-01-10 Thread GitBox
flinkbot commented on PR #21643: URL: https://github.com/apache/flink/pull/21643#issuecomment-1378194575 ## CI report: * e1edb1263219a587b5eb67c9ee1c7aa8642b8037 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] zhangjun0x01 commented on pull request #471: [FLINK-30608] support rename table

2023-01-10 Thread GitBox
zhangjun0x01 commented on PR #471: URL: https://github.com/apache/flink-table-store/pull/471#issuecomment-1378191610 > Thanks @zhangjun0x01 for the contribution. > > Maybe there is a problem here. You didn't rename the entire table file directory. Our current design has determined th

[GitHub] [flink] LadyForest opened a new pull request, #21643: [hotfix][docs][table] Fix broken links in determinism.md

2023-01-10 Thread GitBox
LadyForest opened a new pull request, #21643: URL: https://github.com/apache/flink/pull/21643 ## What is the purpose of the change This is a trivial change to fix the broken link in page [determinism/#3-determinism-in-streaming-processing](https://nightlies.apache.org/flink/flink-docs

[GitHub] [flink] lindong28 commented on a diff in pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-10 Thread GitBox
lindong28 commented on code in PR #21621: URL: https://github.com/apache/flink/pull/21621#discussion_r1066536879 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BootstrapStreamTask.java: ## @@ -82,16 +86,14 @@ protected void init() t

[GitHub] [flink-ml] zhipeng93 merged pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2023-01-10 Thread GitBox
zhipeng93 merged PR #191: URL: https://github.com/apache/flink-ml/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] zhipeng93 commented on pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2023-01-10 Thread GitBox
zhipeng93 commented on PR #191: URL: https://github.com/apache/flink-ml/pull/191#issuecomment-1378185006 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] yuchuanchen commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of colum

2023-01-10 Thread GitBox
yuchuanchen commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1066533653 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemConnectorOptions.java: ## @@ -68,6 +70,22 @@ public class Fi

[GitHub] [flink] fsk119 commented on a diff in pull request #21502: [FLINK-29950] Refactor ResultSet to an interface

2023-01-10 Thread GitBox
fsk119 commented on code in PR #21502: URL: https://github.com/apache/flink/pull/21502#discussion_r1066514320 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java: ## @@ -506,24 +521,16 @@ public ResultFetcher cal

[GitHub] [flink] libenchao commented on pull request #21613: [FLINK-30093][formats] Fix compile errors for google.protobuf.Timestamp type

2023-01-10 Thread GitBox
libenchao commented on PR #21613: URL: https://github.com/apache/flink/pull/21613#issuecomment-1378176914 @maosuhan I will, but I've been a little busy lately. To manage your expectation, it won't be quick. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Closed] (FLINK-30607) Table.to_pandas doesn't support Map type

2023-01-10 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-30607. --- Fix Version/s: 1.17.0 Assignee: Dian Fu Resolution: Fixed Merged to master via b781a13dd615e

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066524471 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/join/JoinReorderITCase.java: ## @@ -0,0 +1,465 @@ +/* + * Licensed

[GitHub] [flink] dianfu closed pull request #21639: [FLINK-30607][python] Support MapType for Pandas UDF

2023-01-10 Thread GitBox
dianfu closed pull request #21639: [FLINK-30607][python] Support MapType for Pandas UDF URL: https://github.com/apache/flink/pull/21639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066523167 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/join/JoinReorderITCase.java: ## @@ -0,0 +1,465 @@ +/* + * Licensed

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066523057 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/join/JoinReorderITCase.java: ## @@ -0,0 +1,465 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #21642: [FLINK-30617][hive] fix wrong data type for cast null literal with Hive dialect

2023-01-10 Thread GitBox
flinkbot commented on PR #21642: URL: https://github.com/apache/flink/pull/21642#issuecomment-1378160576 ## CI report: * 663a5d85ff5189fbea1470eee8b333245cf30315 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30617) Wrong data type for null literal with cast in Hive dialect

2023-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30617: --- Labels: pull-request-available (was: ) > Wrong data type for null literal with cast in Hive

[GitHub] [flink] luoyuxia opened a new pull request, #21642: [FLINK-30617][hive] fix wrong data type for cast null literal with Hive dialect

2023-01-10 Thread GitBox
luoyuxia opened a new pull request, #21642: URL: https://github.com/apache/flink/pull/21642 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[jira] [Comment Edited] (FLINK-30592) The unsupported hive version is not deleted on the hive overview document

2023-01-10 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655878#comment-17655878 ] Jark Wu edited comment on FLINK-30592 at 1/11/23 2:09 AM: -- Fixe

[jira] [Updated] (FLINK-30592) The unsupported hive version is not deleted on the hive overview document

2023-01-10 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-30592: Fix Version/s: 1.16.1 > The unsupported hive version is not deleted on the hive overview document > --

[GitHub] [flink] wuchong merged pull request #21625: [BP-1.16][FLINK-30592][doc] remove unsupported hive version in hive overview document

2023-01-10 Thread GitBox
wuchong merged PR #21625: URL: https://github.com/apache/flink/pull/21625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066506235 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066506352 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066506235 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] lindong28 commented on pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-10 Thread GitBox
lindong28 commented on PR #21621: URL: https://github.com/apache/flink/pull/21621#issuecomment-1378140166 Thanks for the PR! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066501816 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] flinkbot commented on pull request #21641: [FLINK-30006][table-planner](do not merge) Make all pure dynamic functions non-deterministic in streaming mode to avoid wrong plans

2023-01-10 Thread GitBox
flinkbot commented on PR #21641: URL: https://github.com/apache/flink/pull/21641#issuecomment-1378137900 ## CI report: * debc2e12062d3ec0924438eb18cdd1a08f80cf53 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] yuchuanchen commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of colum

2023-01-10 Thread GitBox
yuchuanchen commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1066500768 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/DataTypeUtils.java: ## @@ -94,6 +99,217 @@ public static DataType projectRow(Data

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066499832 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] lsyldliu commented on pull request #21596: [FLINK-29719][hive] Supports native count function for hive dialect

2023-01-10 Thread GitBox
lsyldliu commented on PR #21596: URL: https://github.com/apache/flink/pull/21596#issuecomment-1378134535 cc @beyond1920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-30006) Cannot remove columns that are incorrectly considered constants from an Aggregate In Streaming

2023-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30006: --- Labels: pull-request-available (was: ) > Cannot remove columns that are incorrectly conside

[GitHub] [flink] lincoln-lil opened a new pull request, #21641: [FLINK-30006][table-planner](do not merge) Make all pure dynamic functions non-deterministic in streaming mode to avoid wrong plans

2023-01-10 Thread GitBox
lincoln-lil opened a new pull request, #21641: URL: https://github.com/apache/flink/pull/21641 ## What is the purpose of the change Make all pure dynamic functions non-deterministic in streaming mode to avoid wrong plans ## Brief change log * change all pure dynamic functions no

[GitHub] [flink] lsyldliu commented on pull request #21601: [FLINK-27920][hive] Supports native avg function for hive dialect

2023-01-10 Thread GitBox
lsyldliu commented on PR #21601: URL: https://github.com/apache/flink/pull/21601#issuecomment-1378134200 cc @beyond1920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] lsyldliu commented on pull request #21605: [FLINK-29722][hive] Supports native hive max function for hive dialect

2023-01-10 Thread GitBox
lsyldliu commented on PR #21605: URL: https://github.com/apache/flink/pull/21605#issuecomment-1378133936 cc @beyond1920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066499085 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[jira] [Updated] (FLINK-30006) Cannot remove columns that are incorrectly considered constants from an Aggregate In Streaming

2023-01-10 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-30006: Description: In Streaming, columns generated by dynamic functions are incorrectly considered cons

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066494317 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066493761 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066492728 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066492364 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066491418 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066490734 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066490161 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBushyJoinReorderRule.java: ## @@ -0,0 +1,634 @@ +/* + * Licen

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-01-10 Thread GitBox
swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1066489338 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/join/JoinReorderITCase.java: ## @@ -0,0 +1,276 @@ +/* + * Licensed

[jira] [Assigned] (FLINK-30601) Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

2023-01-10 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-30601: Assignee: Lijie Wang > Omit "setKeyContextElement" call for non-keyed stream/operators to improve

[GitHub] [flink-kubernetes-operator] VinodAnandan commented on a diff in pull request #503: [FLINK-30599][build] Publish SBOM artifacts

2023-01-10 Thread GitBox
VinodAnandan commented on code in PR #503: URL: https://github.com/apache/flink-kubernetes-operator/pull/503#discussion_r1066466074 ## pom.xml: ## @@ -402,6 +402,20 @@ under the License. + + +org.

[GitHub] [flink] MartijnVisser closed pull request #15140: [FLINK-20628][connectors/rabbitmq2] RabbitMQ connector using new connector API

2023-01-10 Thread GitBox
MartijnVisser closed pull request #15140: [FLINK-20628][connectors/rabbitmq2] RabbitMQ connector using new connector API URL: https://github.com/apache/flink/pull/15140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] MartijnVisser commented on pull request #15140: [FLINK-20628][connectors/rabbitmq2] RabbitMQ connector using new connector API

2023-01-10 Thread GitBox
MartijnVisser commented on PR #15140: URL: https://github.com/apache/flink/pull/15140#issuecomment-1378032498 Closing this PR since the connector has been moved to https://github.com/apache/flink-connector-rabbitmq and this PR is now available at https://github.com/apache/flink-connector-ra

[GitHub] [flink] MartijnVisser closed pull request #17524: Update rabbitmq.md

2023-01-10 Thread GitBox
MartijnVisser closed pull request #17524: Update rabbitmq.md URL: https://github.com/apache/flink/pull/17524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [flink] MartijnVisser commented on pull request #17524: Update rabbitmq.md

2023-01-10 Thread GitBox
MartijnVisser commented on PR #17524: URL: https://github.com/apache/flink/pull/17524#issuecomment-1378031895 Closed since the connector code has been moved to https://github.com/apache/flink-connector-rabbitmq -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] MartijnVisser commented on pull request #21630: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink

2023-01-10 Thread GitBox
MartijnVisser commented on PR #21630: URL: https://github.com/apache/flink/pull/21630#issuecomment-1377897663 > Why don't we remove everything at once? That was the original idea, but I chatted offline with @JingsongLi and there is work to be done on `FileSystemTableSink` in order to

[jira] [Created] (FLINK-30627) Refactor FileSystemTableSink to use FileSink instead of StreamingFileSink

2023-01-10 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-30627: -- Summary: Refactor FileSystemTableSink to use FileSink instead of StreamingFileSink Key: FLINK-30627 URL: https://issues.apache.org/jira/browse/FLINK-30627 Project

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2023-01-10 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1377887404 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (FLINK-30626) RabbitMQ connector has dependency convergence error for org.junit.jupiter:junit-jupiter

2023-01-10 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30626: --- Description: https://github.com/apache/flink-connector-rabbitmq/actions/runs/3773487890/jobs

  1   2   3   >