[GitHub] [flink] luoyuxia commented on pull request #21602: [FLINK-30567][hive] Fix wrong behavior for insert overwrite with Hive dialect when the table contains uppercase character

2023-01-06 Thread GitBox
luoyuxia commented on PR #21602: URL: https://github.com/apache/flink/pull/21602#issuecomment-1374407021 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] laughingman7743 commented on a diff in pull request #21613: [FLINK-30093][Formats] Fix compile errors for google.protobuf.Timestamp type

2023-01-06 Thread GitBox
laughingman7743 commented on code in PR #21613: URL: https://github.com/apache/flink/pull/21613#discussion_r1063962702 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/TimestampToRowTest.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Soft

[GitHub] [flink] laughingman7743 commented on a diff in pull request #21613: [FLINK-30093][Formats] Fix compile errors for google.protobuf.Timestamp type

2023-01-06 Thread GitBox
laughingman7743 commented on code in PR #21613: URL: https://github.com/apache/flink/pull/21613#discussion_r1063962702 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/TimestampToRowTest.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Soft

[jira] [Updated] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27246: --- Labels: pull-request-available (was: ) > Code of method > "processElement(Lorg/apache/flin

[GitHub] [flink] kristoffSC commented on pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-06 Thread GitBox
kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1374392355 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] flinkbot commented on pull request #21614: [FLINK-30584][docs] Document flame graph at the subtask level

2023-01-06 Thread GitBox
flinkbot commented on PR #21614: URL: https://github.com/apache/flink/pull/21614#issuecomment-1374391484 ## CI report: * 33659c525648aa797bc711ebe9b382e544a6022e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30584) Update the flame graph doc of subtask level

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30584: --- Labels: pull-request-available (was: ) > Update the flame graph doc of subtask level >

[GitHub] [flink] 1996fanrui opened a new pull request, #21614: [FLINK-30584][docs] Document flame graph at the subtask level

2023-01-06 Thread GitBox
1996fanrui opened a new pull request, #21614: URL: https://github.com/apache/flink/pull/21614 ## What is the purpose of the change Document flame graph at the subtask level. ## Brief change log Document flame graph at the subtask level. https://user-images.githubus

[GitHub] [flink] laughingman7743 commented on pull request #21613: [FLINK-30093][Formats] Fix compile errors for google.protobuf.Timestamp type

2023-01-06 Thread GitBox
laughingman7743 commented on PR #21613: URL: https://github.com/apache/flink/pull/21613#issuecomment-1374386063 Related: https://github.com/apache/flink/pull/21436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-01-06 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655652#comment-17655652 ] Tomoyuki NAKAMURA commented on FLINK-30093: --- [~maosuhan] I have created a pull

[GitHub] [flink] laughingman7743 commented on a diff in pull request #21613: [FLINK-30093][Formats] Fix compile errors for google.protobuf.Timestamp type

2023-01-06 Thread GitBox
laughingman7743 commented on code in PR #21613: URL: https://github.com/apache/flink/pull/21613#discussion_r1063957334 ## flink-formats/flink-protobuf/src/test/proto/test_map.proto: ## @@ -22,16 +22,14 @@ option java_package = "org.apache.flink.formats.protobuf.testproto"; opt

[GitHub] [flink] flinkbot commented on pull request #21613: [FLINK-30093][Formats] Fix compile errors for google.protobuf.Timestamp type

2023-01-06 Thread GitBox
flinkbot commented on PR #21613: URL: https://github.com/apache/flink/pull/21613#issuecomment-1374385481 ## CI report: * f06c17ee50dcb39403f14a8f47109e5b09b2b66b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] laughingman7743 opened a new pull request, #21613: [FLINK-30093][Formats] Fix compile errors for google.protobuf.Timestamp type

2023-01-06 Thread GitBox
laughingman7743 opened a new pull request, #21613: URL: https://github.com/apache/flink/pull/21613 ## What is the purpose of the change The current implementation does not take into consideration the case where another package is imported and used for a message, so it seems th

[GitHub] [flink] link3280 commented on pull request #21582: [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway

2023-01-06 Thread GitBox
link3280 commented on PR #21582: URL: https://github.com/apache/flink/pull/21582#issuecomment-1374371258 Please kindly take a look @fsk119 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Closed] (FLINK-30414) Add unit test time out when run ci.

2023-01-06 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aiden Gong closed FLINK-30414. -- Resolution: Won't Do > Add unit test time out when run ci. > --- > >

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2023-01-06 Thread Suhan Mao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655630#comment-17655630 ] Suhan Mao commented on FLINK-30093: --- [~laughingman7743] Thanks for your code. It looks

[jira] [Assigned] (FLINK-30581) Deprecate FileStoreTableITCase and use CatalogITCaseBase

2023-01-06 Thread Feng Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Wang reassigned FLINK-30581: - Assignee: Feng Wang > Deprecate FileStoreTableITCase and use CatalogITCaseBase > --

[jira] [Commented] (FLINK-30419) Allow tuning of transaction timeout

2023-01-06 Thread Alex Sorokoumov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655593#comment-17655593 ] Alex Sorokoumov commented on FLINK-30419: - The 1h default comes from [FlinkKafk

[jira] [Created] (FLINK-30596) Multiple POST /jars/:jarid/run requests with the same jobId, runs duplicate jobs

2023-01-06 Thread Mohsen Rezaei (Jira)
Mohsen Rezaei created FLINK-30596: - Summary: Multiple POST /jars/:jarid/run requests with the same jobId, runs duplicate jobs Key: FLINK-30596 URL: https://issues.apache.org/jira/browse/FLINK-30596 Pr

[jira] [Commented] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2023-01-06 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655573#comment-17655573 ] Krzysztof Chmielewski commented on FLINK-27246: --- Hi [~TsReaper], [~twalthr

[jira] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2023-01-06 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246 ] Krzysztof Chmielewski deleted comment on FLINK-27246: --- was (Author: kristoffsc): Hi [~TsReaper], [~twalthr] and [~jingge] I have finally finished working on my PR for this issue. Th

[jira] [Comment Edited] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2023-01-06 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655572#comment-17655572 ] Krzysztof Chmielewski edited comment on FLINK-27246 at 1/6/23 8:16 PM: ---

[jira] [Comment Edited] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2023-01-06 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655572#comment-17655572 ] Krzysztof Chmielewski edited comment on FLINK-27246 at 1/6/23 8:12 PM: ---

[jira] [Commented] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2023-01-06 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655572#comment-17655572 ] Krzysztof Chmielewski commented on FLINK-27246: --- Hi [~TsReaper] I have fin

[jira] [Commented] (FLINK-30594) Update Java version because of JDK bug in the operator

2023-01-06 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655533#comment-17655533 ] Gabor Somogyi commented on FLINK-30594: --- In the meantime I've realized that the fo

[GitHub] [flink-table-store] wuyouwuyoulian opened a new pull request, #468: [hotfix] fix typo

2023-01-06 Thread GitBox
wuyouwuyoulian opened a new pull request, #468: URL: https://github.com/apache/flink-table-store/pull/468 Change Logs fix typo Impact fix typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-table-store] wuyouwuyoulian closed pull request #466: [hotfix] fix typo

2023-01-06 Thread GitBox
wuyouwuyoulian closed pull request #466: [hotfix] fix typo URL: https://github.com/apache/flink-table-store/pull/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #12: [FLINK-25686][Connector/Pulsar] Support schema evolution for Pulsar source and sink.

2023-01-06 Thread GitBox
tisonkun commented on code in PR #12: URL: https://github.com/apache/flink-connector-pulsar/pull/12#discussion_r1063580365 ## docs/content/docs/connectors/datastream/pulsar.md: ## @@ -213,6 +213,8 @@ If only the raw payload of a message (message data in bytes) is needed, you

[GitHub] [flink-table-store] wuyouwuyoulian closed pull request #466: [hotfix] fix typo

2023-01-06 Thread GitBox
wuyouwuyoulian closed pull request #466: [hotfix] fix typo URL: https://github.com/apache/flink-table-store/pull/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[jira] [Updated] (FLINK-30595) support create table like

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30595: --- Labels: pull-request-available (was: ) > support create table like > --

[GitHub] [flink-table-store] zhangjun0x01 opened a new pull request, #467: [FLINK-30595] support create table like

2023-01-06 Thread GitBox
zhangjun0x01 opened a new pull request, #467: URL: https://github.com/apache/flink-table-store/pull/467 support create table like for flink table store -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (FLINK-30595) support create table like

2023-01-06 Thread Jun Zhang (Jira)
Jun Zhang created FLINK-30595: - Summary: support create table like Key: FLINK-30595 URL: https://issues.apache.org/jira/browse/FLINK-30595 Project: Flink Issue Type: Improvement Repor

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

2023-01-06 Thread GitBox
MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1373827479 > @MartijnVisser I hope its fine that I asked @gunnarmorling to take a look at this change :) > +1 to wait until we know that Hive still works. @rmetzger If you can have an

[GitHub] [flink] flinkbot commented on pull request #21612: [FLINK-30471][network] Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils

2023-01-06 Thread GitBox
flinkbot commented on PR #21612: URL: https://github.com/apache/flink/pull/21612#issuecomment-1373791217 ## CI report: * 644fd042dfc327567ab2e43ec2b48ffb38179b71 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30471) Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30471: --- Labels: pull-request-available (was: ) > Optimize the enriching network memory process in

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #21612: [FLINK-30471][network] Optimize the enriching network memory process in SsgNetworkMemoryCalculationUtils

2023-01-06 Thread GitBox
TanYuxin-tyx opened a new pull request, #21612: URL: https://github.com/apache/flink/pull/21612 ## What is the purpose of the change In SsgNetworkMemoryCalculationUtils#enrichNetworkMemory, getting PartitionTypes is run in a separate loop, which is not friendly to perf

[jira] [Commented] (FLINK-30594) Update Java version because of JDK bug in the operator

2023-01-06 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655475#comment-17655475 ] Gabor Somogyi commented on FLINK-30594: --- I've double checked and the latest maven:

[jira] [Updated] (FLINK-30594) Update Java version because of JDK bug in the operator

2023-01-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30594: --- Priority: Critical (was: Blocker) > Update Java version because of JDK bug in the operator > --

[jira] [Updated] (FLINK-30594) Update Java version because of JDK bug in the operator

2023-01-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30594: --- Fix Version/s: kubernetes-operator-1.4.0 > Update Java version because of JDK bug in the operator >

[jira] [Created] (FLINK-30594) Update Java version because of JDK bug in the operator

2023-01-06 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30594: - Summary: Update Java version because of JDK bug in the operator Key: FLINK-30594 URL: https://issues.apache.org/jira/browse/FLINK-30594 Project: Flink Issu

[GitHub] [flink] TanYuxin-tyx closed pull request #21610: Only for triggering test

2023-01-06 Thread GitBox
TanYuxin-tyx closed pull request #21610: Only for triggering test URL: https://github.com/apache/flink/pull/21610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [flink-table-store] wuyouwuyoulian opened a new pull request, #466: [hotfix] fix typo

2023-01-06 Thread GitBox
wuyouwuyoulian opened a new pull request, #466: URL: https://github.com/apache/flink-table-store/pull/466 fix typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, Logi

2023-01-06 Thread GitBox
lindong28 commented on code in PR #197: URL: https://github.com/apache/flink-ml/pull/197#discussion_r1063496759 ## flink-ml-benchmark/src/main/resources/linearregression-benchmark.json: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +/

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, Logi

2023-01-06 Thread GitBox
lindong28 commented on code in PR #197: URL: https://github.com/apache/flink-ml/pull/197#discussion_r1063496759 ## flink-ml-benchmark/src/main/resources/linearregression-benchmark.json: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +/

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, Logi

2023-01-06 Thread GitBox
lindong28 commented on code in PR #197: URL: https://github.com/apache/flink-ml/pull/197#discussion_r1063496759 ## flink-ml-benchmark/src/main/resources/linearregression-benchmark.json: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +/

[GitHub] [flink-table-store] wangfengpro opened a new pull request, #465: [FLINK-30581] Deprecate FileStoreTableITCase and use CatalogITCaseBase

2023-01-06 Thread GitBox
wangfengpro opened a new pull request, #465: URL: https://github.com/apache/flink-table-store/pull/465 We recommend users to use Catalog tables instead managed tables. Managed tables should be deprecated. Now we already did not expose managed in documentation. We can remove it. Before

[GitHub] [flink] chrismartin823 commented on a diff in pull request #21611: [hotfix][docs] Fix typo in hive connector Chinese overview documentation

2023-01-06 Thread GitBox
chrismartin823 commented on code in PR #21611: URL: https://github.com/apache/flink/pull/21611#discussion_r1063460661 ## docs/content.zh/docs/connectors/table/hive/overview.md: ## @@ -41,7 +41,7 @@ Flink 与 Hive 的集成包含两个层面。 ## 支持的Hive版本 -Flink 支持一下的 Hive 版本。 +Flink 支持以下的 Hive

[GitHub] [flink] chrismartin823 commented on a diff in pull request #21611: [hotfix][docs] Fix typo in hive connector Chinese overview documentation

2023-01-06 Thread GitBox
chrismartin823 commented on code in PR #21611: URL: https://github.com/apache/flink/pull/21611#discussion_r1063459818 ## docs/content.zh/docs/connectors/table/hive/overview.md: ## @@ -41,7 +41,7 @@ Flink 与 Hive 的集成包含两个层面。 ## 支持的Hive版本 -Flink 支持一下的 Hive 版本。 +Flink 支持以下的 Hive

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21604: [FLINK-30425][runtime][security] Generalize token receive side

2023-01-06 Thread GitBox
gaborgsomogyi commented on code in PR #21604: URL: https://github.com/apache/flink/pull/21604#discussion_r1063420746 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/hadoop/HadoopDelegationTokenReceiver.java: ## @@ -19,46 +19,43 @@ package org.apache.flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #21611: [hotfix][docs] Fix typo in hive connector Chinese overview documentation

2023-01-06 Thread GitBox
luoyuxia commented on code in PR #21611: URL: https://github.com/apache/flink/pull/21611#discussion_r1063415616 ## docs/content.zh/docs/connectors/table/hive/overview.md: ## @@ -41,7 +41,7 @@ Flink 与 Hive 的集成包含两个层面。 ## 支持的Hive版本 -Flink 支持一下的 Hive 版本。 +Flink 支持以下的 Hive 版本。

[GitHub] [flink] luoyuxia commented on a diff in pull request #21611: [hotfix][docs] Fix typo in hive connector Chinese overview documentation

2023-01-06 Thread GitBox
luoyuxia commented on code in PR #21611: URL: https://github.com/apache/flink/pull/21611#discussion_r1063414854 ## docs/content.zh/docs/connectors/table/hive/overview.md: ## @@ -41,7 +41,7 @@ Flink 与 Hive 的集成包含两个层面。 ## 支持的Hive版本 -Flink 支持一下的 Hive 版本。 +Flink 支持以下的 Hive 版本。

[GitHub] [flink] pvary commented on a diff in pull request #21604: [FLINK-30425][runtime][security] Generalize token receive side

2023-01-06 Thread GitBox
pvary commented on code in PR #21604: URL: https://github.com/apache/flink/pull/21604#discussion_r1063410971 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/hadoop/HadoopDelegationTokenReceiver.java: ## @@ -19,46 +19,43 @@ package org.apache.flink.runtime

[GitHub] [flink] gaborgsomogyi commented on pull request #21604: [FLINK-30425][runtime][security] Generalize token receive side

2023-01-06 Thread GitBox
gaborgsomogyi commented on PR #21604: URL: https://github.com/apache/flink/pull/21604#issuecomment-1373577228 There is an end-to-end test for HDFS but for HBase we don't have anything. Honestly it's horror complex to setup everything within a single process, like KDC, HDFS, HBase, Flink app

[jira] [Updated] (FLINK-30575) Autoscaler doesn't scale down on 0 load

2023-01-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30575: --- Component/s: Autoscaler > Autoscaler doesn't scale down on 0 load >

[jira] [Updated] (FLINK-30571) Compute scale parallelism based on observed scalability

2023-01-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30571: --- Component/s: Autoscaler > Compute scale parallelism based on observed scalability > ---

[jira] [Updated] (FLINK-30574) Do not scale further up if last scaling was ineffective

2023-01-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30574: --- Component/s: Autoscaler > Do not scale further up if last scaling was ineffective >

[jira] [Created] (FLINK-30593) Determine restart time on the fly for Autoscaler

2023-01-06 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30593: -- Summary: Determine restart time on the fly for Autoscaler Key: FLINK-30593 URL: https://issues.apache.org/jira/browse/FLINK-30593 Project: Flink Issue Type: New

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #12: [FLINK-25686][Connector/Pulsar] Support schema evolution for Pulsar source and sink.

2023-01-06 Thread GitBox
tisonkun commented on code in PR #12: URL: https://github.com/apache/flink-connector-pulsar/pull/12#discussion_r1063389538 ## docs/content/docs/connectors/datastream/pulsar.md: ## @@ -213,6 +213,8 @@ If only the raw payload of a message (message data in bytes) is needed, you

[GitHub] [flink] pvary commented on pull request #21604: [FLINK-30425][runtime][security] Generalize token receive side

2023-01-06 Thread GitBox
pvary commented on PR #21604: URL: https://github.com/apache/flink/pull/21604#issuecomment-1373553600 Do we have test cases for the specific providers/receivers, like HBase/HadoopFS? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (FLINK-30414) Add unit test time out when run ci.

2023-01-06 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655416#comment-17655416 ] Nicholas Jiang commented on FLINK-30414: [~Aiden Gong], it isn't needed to add t

[GitHub] [flink] chrismartin823 commented on pull request #21611: [hotfix][docs] Fix typo in hive connector Chinese overview documentation

2023-01-06 Thread GitBox
chrismartin823 commented on PR #21611: URL: https://github.com/apache/flink/pull/21611#issuecomment-1373538092 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Comment Edited] (FLINK-30590) Remove set default value manually for table options

2023-01-06 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655414#comment-17655414 ] Nicholas Jiang edited comment on FLINK-30590 at 1/6/23 11:54 AM: -

[jira] [Commented] (FLINK-30590) Remove set default value manually for table options

2023-01-06 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655414#comment-17655414 ] Nicholas Jiang commented on FLINK-30590: [~zjureel], IMO, it's needed for users

[GitHub] [flink] flinkbot commented on pull request #21611: [hotfix][docs] Fix typo in hive connector Chinese overview documentation

2023-01-06 Thread GitBox
flinkbot commented on PR #21611: URL: https://github.com/apache/flink/pull/21611#issuecomment-1373535828 ## CI report: * 6fd3b4c38f0ce7d84fc06fd9581f6c899c8ecab6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] chrismartin823 opened a new pull request, #21611: [hotfix] [docs] Fix typo in hive connector overview

2023-01-06 Thread GitBox
chrismartin823 opened a new pull request, #21611: URL: https://github.com/apache/flink/pull/21611 ## What is the purpose of the change *hotfix typo for hive connector overview Chinese documentation.* ## Brief change log - *hotfix typo for hive connector over

[jira] [Commented] (FLINK-30561) ChangelogStreamHandleReaderWithCache cause FileNotFoundException

2023-01-06 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655410#comment-17655410 ] Feifan Wang commented on FLINK-30561: - Hi [~Yanfei Lei] , ChangelogStreamHandleReade

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2023-01-06 Thread GitBox
weibozhao commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1063369892 ## flink-ml-lib/src/test/java/org/apache/flink/ml/recommendation/SwingTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [flink] Tartarus0zm commented on pull request #21608: [FLINK-29721][hive] Supports native hive min function for hive dialect

2023-01-06 Thread GitBox
Tartarus0zm commented on PR #21608: URL: https://github.com/apache/flink/pull/21608#issuecomment-1373486759 @lsyldliu @beyond1920 hello, please take a look, if you have time, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Created] (FLINK-30592) The unsupported hive version is not deleted on the hive overview document

2023-01-06 Thread chrismartin (Jira)
chrismartin created FLINK-30592: --- Summary: The unsupported hive version is not deleted on the hive overview document Key: FLINK-30592 URL: https://issues.apache.org/jira/browse/FLINK-30592 Project: Flin

[GitHub] [flink] flinkbot commented on pull request #21610: Only for triggering test

2023-01-06 Thread GitBox
flinkbot commented on PR #21610: URL: https://github.com/apache/flink/pull/21610#issuecomment-1373448769 ## CI report: * 1459a009b1da3eb139dc1feb9e257c48db6d16c7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #21610: Only for triggering test

2023-01-06 Thread GitBox
TanYuxin-tyx opened a new pull request, #21610: URL: https://github.com/apache/flink/pull/21610 ## What is the purpose of the change This is only for triggering test. ## Brief change log *(for example:)* - *The TaskInfo is stored in the blob store on job

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2023-01-06 Thread GitBox
weibozhao commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1063198634 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/SwingParams.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (FLINK-30591) Stateful functions SDK for Flink DataStream Integration example is not available

2023-01-06 Thread Utopia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Utopia updated FLINK-30591: --- Description:   [https://nightlies.apache.org/flink/flink-statefun-docs-release-3.2/docs/sdk/flink-datastrea

[GitHub] [flink] link3280 commented on pull request #21582: [FLINK-28655][SQL gateway] Support show jobs operation in SqlGateway

2023-01-06 Thread GitBox
link3280 commented on PR #21582: URL: https://github.com/apache/flink/pull/21582#issuecomment-1373415088 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-30591) Stateful functions SDK for Flink DataStream Integration example is not available

2023-01-06 Thread Utopia (Jira)
Utopia created FLINK-30591: -- Summary: Stateful functions SDK for Flink DataStream Integration example is not available Key: FLINK-30591 URL: https://issues.apache.org/jira/browse/FLINK-30591 Project: Flink

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #198: [FLINK-30568] Add benchmark for PolyNomialExpansion, Normalizer, Binarizer, Interaction, MaxAbsScaler, VectorSlicer, ElementWise

2023-01-06 Thread GitBox
zhipeng93 commented on code in PR #198: URL: https://github.com/apache/flink-ml/pull/198#discussion_r1063286609 ## flink-ml-benchmark/src/main/resources/binarizer-benchmark.json: ## @@ -0,0 +1,62 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contr

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21570: [FLINK-29666][runtime] Let adaptive batch scheduler divide subpartition range according to amount of data

2023-01-06 Thread GitBox
zhuzhurk commented on code in PR #21570: URL: https://github.com/apache/flink/pull/21570#discussion_r1063284441 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ## @@ -163,27 +169,30 @@ int decideP

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #197: [FLINK-30566] Add benchmark for AgglomerativeClustering, HashingTF, IDF, KBinsDiscretizer, LinearRegression, LinearSVC, Logi

2023-01-06 Thread GitBox
zhipeng93 commented on code in PR #197: URL: https://github.com/apache/flink-ml/pull/197#discussion_r1063284030 ## flink-ml-benchmark/src/main/resources/linearregression-benchmark.json: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +/

[jira] [Commented] (FLINK-25421) Port JDBC Sink to new Unified Sink API (FLIP-143)

2023-01-06 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655355#comment-17655355 ] Lijie Wang commented on FLINK-25421: In the offline discussion with [~eskabetxe] , w

[jira] [Updated] (FLINK-30590) Remove set default value manually for table options

2023-01-06 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shammon updated FLINK-30590: Summary: Remove set default value manually for table options (was: Remove set default value manual for ta

[jira] [Created] (FLINK-30590) Remove set default value manual for table options

2023-01-06 Thread Shammon (Jira)
Shammon created FLINK-30590: --- Summary: Remove set default value manual for table options Key: FLINK-30590 URL: https://issues.apache.org/jira/browse/FLINK-30590 Project: Flink Issue Type: Improveme

[jira] [Commented] (FLINK-25421) Port JDBC Sink to new Unified Sink API (FLIP-143)

2023-01-06 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655351#comment-17655351 ] Lijie Wang commented on FLINK-25421: [~eskabetxe] Let us continue the discussion her

[jira] [Updated] (FLINK-30589) Snapshot expiration should be skipped in Table Store dedicated writer jobs

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30589: --- Labels: pull-request-available (was: ) > Snapshot expiration should be skipped in Table Sto

[GitHub] [flink-table-store] tsreaper opened a new pull request, #464: [FLINK-30589] Snapshot expiration should be skipped in Table Store dedicated writer jobs

2023-01-06 Thread GitBox
tsreaper opened a new pull request, #464: URL: https://github.com/apache/flink-table-store/pull/464 Currently Table Store dedicated writer jobs will also expire snapshots. This may cause conflicts when multiple writer jobs are running. We should expire snapshots only in dedicated comp

[jira] [Closed] (FLINK-30582) Flink-avro Flink-orc free for flink-table-store-format

2023-01-06 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30582. Resolution: Fixed master: b3474aff36a661677e22d56e627ef227390c2689 > Flink-avro Flink-orc free fo

[jira] [Updated] (FLINK-30582) Flink-avro Flink-orc free for flink-table-store-format

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30582: --- Labels: pull-request-available (was: ) > Flink-avro Flink-orc free for flink-table-store-fo

[GitHub] [flink-table-store] JingsongLi merged pull request #461: [FLINK-30582] Flink-avro Flink-orc free for flink-table-store-format

2023-01-06 Thread GitBox
JingsongLi merged PR #461: URL: https://github.com/apache/flink-table-store/pull/461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink-ml] jiangxin369 commented on pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2023-01-06 Thread GitBox
jiangxin369 commented on PR #191: URL: https://github.com/apache/flink-ml/pull/191#issuecomment-1373391113 @Fanoid Thanks for the updates, LGTM. @yunfengzhou-hub Would you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Updated] (FLINK-30581) Deprecate FileStoreTableITCase and use CatalogITCaseBase

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30581: --- Labels: pull-request-available (was: ) > Deprecate FileStoreTableITCase and use CatalogITCa

[GitHub] [flink-table-store] zjureel opened a new pull request, #463: [FLINK-30581] Remove FileStoreTableITCase and use CatalogITCaseBase

2023-01-06 Thread GitBox
zjureel opened a new pull request, #463: URL: https://github.com/apache/flink-table-store/pull/463 Remove `FileStoreTableITCase` and use `CatalogITCaseBase` as the base test class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2023-01-06 Thread GitBox
swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1063265717 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -137,6 +140,20 @@ private static RelNo

[jira] [Created] (FLINK-30589) Snapshot expiration should be skipped in Table Store dedicated writer jobs

2023-01-06 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-30589: --- Summary: Snapshot expiration should be skipped in Table Store dedicated writer jobs Key: FLINK-30589 URL: https://issues.apache.org/jira/browse/FLINK-30589 Project: Fli

[jira] [Commented] (FLINK-30583) Provide the flame graph to the subtask level

2023-01-06 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655344#comment-17655344 ] Rui Fan commented on FLINK-30583: - Thanks, I will finish the subtask2 asap:) > Provide

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2023-01-06 Thread GitBox
swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1063260676 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkDynamicPartitionPruningProgram.java: ## @@ -0,0 +1,151 @@

[jira] [Updated] (FLINK-30587) Validate primary key in an append-only table in ddl

2023-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30587: --- Labels: pull-request-available (was: ) > Validate primary key in an append-only table in dd

[GitHub] [flink-table-store] zjureel opened a new pull request, #462: [FLINK-30587] Validate primary key in append-only table in ddl

2023-01-06 Thread GitBox
zjureel opened a new pull request, #462: URL: https://github.com/apache/flink-table-store/pull/462 Cannot define any primary key in an append-only table -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-30583) Provide the flame graph to the subtask level

2023-01-06 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655342#comment-17655342 ] Xintong Song commented on FLINK-30583: -- Sounds good to me. > Provide the flame gra

[jira] [Commented] (FLINK-30583) Provide the flame graph to the subtask level

2023-01-06 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655339#comment-17655339 ] Rui Fan commented on FLINK-30583: - Hi [~xtsong] , thanks for your quick feedback.   Th

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

2023-01-06 Thread GitBox
swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1063258059 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkDynamicPartitionPruningProgram.java: ## @@ -0,0 +1,151 @@

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21570: [FLINK-29666][runtime] Let adaptive batch scheduler divide subpartition range according to amount of data

2023-01-06 Thread GitBox
zhuzhurk commented on code in PR #21570: URL: https://github.com/apache/flink/pull/21570#discussion_r1063214490 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ## @@ -233,6 +235,8 @@ private Paral

  1   2   >