[GitHub] [flink-kubernetes-operator] pvary commented on pull request #464: [FLINK-30268] HA metadata and other cluster submission related errors should not throw DeploymentFailedException

2022-12-02 Thread GitBox
pvary commented on PR #464: URL: https://github.com/apache/flink-kubernetes-operator/pull/464#issuecomment-1336091361 > @pvary please also rebase it to the latest containing @gaborgsomogyi's e2e changes @morhidi: I am not sure I understand this comment. You might refer to my refacto

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-02 Thread GitBox
morhidi commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335943207 Please also rebase to the latest main version, e2es has been fixed recently -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink] liuml07 commented on pull request #21266: [FLINK-29940] ExecutionGraph logs job state change at ERROR level when job fails

2022-12-02 Thread GitBox
liuml07 commented on PR #21266: URL: https://github.com/apache/flink/pull/21266#issuecomment-1335922599 Thank you very much @rmetzger ! As I posted in the JIRA comment, I do believe this adds value for users to quickly find the root cause, instead of knowing which substring to search in too

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator

2022-12-02 Thread GitBox
morhidi commented on code in PR #420: URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1033671472 ## helm/flink-kubernetes-operator/templates/flink-operator.yaml: ## @@ -79,7 +79,9 @@ spec: {{- end }} env: - name:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #464: [FLINK-30268] HA metadata and other cluster submission related errors should not throw DeploymentFailedException

2022-12-02 Thread GitBox
gyfora commented on code in PR #464: URL: https://github.com/apache/flink-kubernetes-operator/pull/464#discussion_r1038512952 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/exception/RecoverableDeploymentFailureException.java: ## @@ -0,0 +1,25 @

[jira] [Updated] (FLINK-30287) Configmaps get cleaned up when upgrading standalone Flink cluster

2022-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30287: --- Labels: pull-request-available (was: ) > Configmaps get cleaned up when upgrading standalon

[GitHub] [flink-kubernetes-operator] stevenpyzhang opened a new pull request, #468: [FLINK-30287] Delete job manager deployment first when cleaning up standalone cluster

2022-12-02 Thread GitBox
stevenpyzhang opened a new pull request, #468: URL: https://github.com/apache/flink-kubernetes-operator/pull/468 ## What is the purpose of the change Delete the Job manager resources first when deleting a standalone Flink cluster as part of an upgrade in order to prevent HA configmaps

[jira] [Updated] (FLINK-30287) Configmaps get cleaned up when upgrading standalone Flink cluster

2022-12-02 Thread Steven Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhang updated FLINK-30287: - Description: I started up a Standalone session Flink cluster and ran one job on it. I checked t

[jira] [Updated] (FLINK-30287) Configmaps get cleaned up when upgrading standalone Flink cluster

2022-12-02 Thread Steven Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhang updated FLINK-30287: - Description: I started up a Standalone session Flink cluster and ran one job on it. I checked t

[jira] [Updated] (FLINK-30287) Configmaps get cleaned up when upgrading standalone Flink cluster

2022-12-02 Thread Steven Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhang updated FLINK-30287: - Description: I started up a Standalone session Flink cluster and ran one job on it. I checked t

[jira] [Created] (FLINK-30287) Configmaps get cleaned up when upgrading standalone Flink cluster

2022-12-02 Thread Steven Zhang (Jira)
Steven Zhang created FLINK-30287: Summary: Configmaps get cleaned up when upgrading standalone Flink cluster Key: FLINK-30287 URL: https://issues.apache.org/jira/browse/FLINK-30287 Project: Flink

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #464: [FLINK-30268] HA metadata and other cluster submission related errors should not throw DeploymentFailedException

2022-12-02 Thread GitBox
morhidi commented on PR #464: URL: https://github.com/apache/flink-kubernetes-operator/pull/464#issuecomment-1335708826 @pvary please also rebase it to the latest containing @gaborgsomogyi's e2e changes -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-02 Thread GitBox
morhidi commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335706012 > Hi @morhidi thanks for review! Which base image would you recommend ? I've no preference, use whatever you feel is the best fit for these scripts to run properly.

[GitHub] [flink-kubernetes-operator] morhidi merged pull request #467: [FLINK-30281] Parsing for log4j error entry instead of plain error string in e2e tests

2022-12-02 Thread GitBox
morhidi merged PR #467: URL: https://github.com/apache/flink-kubernetes-operator/pull/467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Closed] (FLINK-30275) TaskExecutorTest.testSharedResourcesLifecycle fails

2022-12-02 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan closed FLINK-30275. - Resolution: Fixed Thanks for reporting [~mapohl] . Fixed in 6b68bc6ccc159e980f8f77e1ab7

[GitHub] [flink] rkhachatryan merged pull request #21444: [FLINK-30275][tests] Fix off-by-one error in TaskExecutorTest.testSharedResourcesLifecycle

2022-12-02 Thread GitBox
rkhachatryan merged PR #21444: URL: https://github.com/apache/flink/pull/21444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-02 Thread GitBox
tedhtchang commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335624431 Hi @morhidi thanks for review! Which base image would you recommend ? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator

2022-12-02 Thread GitBox
morhidi commented on PR #458: URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335617227 Thanks @tedhtchang for the PR. I checked and it seems the scripts are not platform independent unfortunately. We cannot use them:/ We should probably aim to build a docke

[GitHub] [flink] flinkbot commented on pull request #21446: [FLINK-30286][build] Run rat-plugin in validate phase

2022-12-02 Thread GitBox
flinkbot commented on PR #21446: URL: https://github.com/apache/flink/pull/21446#issuecomment-1335610965 ## CI report: * 796650db330b80f6aa7baa25d67c5af820e01a95 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30286) Run rat plugin in validate phase

2022-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30286: --- Labels: pull-request-available (was: ) > Run rat plugin in validate phase > ---

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
gyfora commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335593501 I agree with @morhidi , the current logic has been working very robustly for basically every new user so far when installing with Helm. -- This is an automated message f

[GitHub] [flink] zentol opened a new pull request, #21446: [FLINK-30286][build] Run rat-plugin in validate phase

2022-12-02 Thread GitBox
zentol opened a new pull request, #21446: URL: https://github.com/apache/flink/pull/21446 Run the plugin before the shade-plugin to not be affected by the shade-plugin changing the basedir, breaking relative paths in exclusions. -- This is an automated message from the Apache Git Service.

[jira] [Created] (FLINK-30285) Inline checkstyle config into pom

2022-12-02 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30285: Summary: Inline checkstyle config into pom Key: FLINK-30285 URL: https://issues.apache.org/jira/browse/FLINK-30285 Project: Flink Issue Type: Technic

[jira] [Created] (FLINK-30286) Run rat plugin in validate phase

2022-12-02 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30286: Summary: Run rat plugin in validate phase Key: FLINK-30286 URL: https://issues.apache.org/jira/browse/FLINK-30286 Project: Flink Issue Type: Technica

[jira] [Created] (FLINK-30284) Make datadog reporter url configurable

2022-12-02 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30284: Summary: Make datadog reporter url configurable Key: FLINK-30284 URL: https://issues.apache.org/jira/browse/FLINK-30284 Project: Flink Issue Type: Ne

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #32: [FLINK-29907][Connectors/AWS] Externalize KDS/KDF and AWS base from Flink repo

2022-12-02 Thread GitBox
dannycranmer commented on code in PR #32: URL: https://github.com/apache/flink-connector-aws/pull/32#discussion_r1038374702 ## flink-sql-connector-aws-kinesis-firehose/src/main/resources/META-INF/NOTICE: ## @@ -0,0 +1,47 @@ +flink-sql-connector-aws-kinesis-firehose + +Copyright

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #464: [FLINK-30268] HA metadata and other cluster submission related errors should not throw DeploymentFailedException

2022-12-02 Thread GitBox
gyfora commented on PR #464: URL: https://github.com/apache/flink-kubernetes-operator/pull/464#issuecomment-1335572073 I would not necessarily call missing HA metadata exceptions recoverable. In most cases they are actually fatal and as many error msgs suggest, they require deletion and re

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
morhidi commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335563158 > @morhidi @tweise What do you think about getting rid of the `append` flag and simply putting the default config in the ConfigMap volume. Users can modify the default co

[jira] [Commented] (FLINK-29549) Add Aws Glue Catalog support in Flink

2022-12-02 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642612#comment-17642612 ] Samrat Deb commented on FLINK-29549: Associated [FLIP-277|https://cwiki.apache.org/

[GitHub] [flink-connector-aws] hlteoh37 commented on a diff in pull request #32: [FLINK-29907][Connectors/AWS] Externalize KDS/KDF and AWS base from Flink repo

2022-12-02 Thread GitBox
hlteoh37 commented on code in PR #32: URL: https://github.com/apache/flink-connector-aws/pull/32#discussion_r1038306670 ## pom.xml: ## @@ -102,6 +109,50 @@ under the License. test + +org.assertj +assertj-core +

[GitHub] [flink] flinkbot commented on pull request #21445: [FLINK-30278][streaming] Unset parallelism in the SinkTransformationTranslator if it wasn't set before

2022-12-02 Thread GitBox
flinkbot commented on PR #21445: URL: https://github.com/apache/flink/pull/21445#issuecomment-1335510408 ## CI report: * 92f2bf0f0d056ef266e7a8ac0b19b92d3960f0ee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30278) Unexpected config mutation in SinkTransformationTranslator

2022-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30278: --- Labels: pull-request-available (was: ) > Unexpected config mutation in SinkTransformationTr

[GitHub] [flink] pnowojski opened a new pull request, #21445: [FLINK-30278][streaming] Unset parallelism in the SinkTransformationTranslator if it wasn't set before

2022-12-02 Thread GitBox
pnowojski opened a new pull request, #21445: URL: https://github.com/apache/flink/pull/21445 PoC of the fix ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e.

[jira] [Created] (FLINK-30283) Evaluate operator error log entry: Error while patching status

2022-12-02 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30283: - Summary: Evaluate operator error log entry: Error while patching status Key: FLINK-30283 URL: https://issues.apache.org/jira/browse/FLINK-30283 Project: Flink

[GitHub] [flink] pnowojski commented on pull request #21440: [FLINK-28766][tests] Safe iterate over checkpoint files in order to avoid exception during parallel savepoint deletion

2022-12-02 Thread GitBox
pnowojski commented on PR #21440: URL: https://github.com/apache/flink/pull/21440#issuecomment-1335491691 LGTM assuming green azure. Can you ping me once it's green? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
mxm commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335473057 Another caveat is that `append` applies to flink config, Flink logging config, and operator logging config. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-30275) TaskExecutorTest.testSharedResourcesLifecycle fails

2022-12-02 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-30275: -- Fix Version/s: 1.17.0 > TaskExecutorTest.testSharedResourcesLifecycle fails >

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
mxm commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335454419 @morhidi @tweise What do you think about getting rid of the `append` flag and simply putting the default config in the ConfigMap volume. Users can modify the default config a

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
mxm commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335436354 Looks like we set `defaultConfiguration.append` to `false` in our overlay. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
mxm commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335422102 The ConfigMap volumes are mounted by default. This is the relevant content of the `flink-operator-config` ConfigMap: ``` log4j-operator.properties: # Flin

[jira] [Updated] (FLINK-30275) TaskExecutorTest.testSharedResourcesLifecycle fails

2022-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30275: --- Labels: pull-request-available test-stability (was: test-stability) > TaskExecutorTest.test

[GitHub] [flink] flinkbot commented on pull request #21444: [FLINK-30275][tests] Fix off-by-one error in TaskExecutorTest.testSharedResourcesLifecycle

2022-12-02 Thread GitBox
flinkbot commented on PR #21444: URL: https://github.com/apache/flink/pull/21444#issuecomment-1335411834 ## CI report: * 6a28471cd535e9473f47592f706743cc99053ed6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] morhidi merged pull request #465: [FLINK-30266] Roll back change to HA metadata check logic

2022-12-02 Thread GitBox
morhidi merged PR #465: URL: https://github.com/apache/flink-kubernetes-operator/pull/465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink] akalash commented on a diff in pull request #21440: [FLINK-28766][tests] Safe iterate over checkpoint files in order to avoid exception during parallel savepoint deletion

2022-12-02 Thread GitBox
akalash commented on code in PR #21440: URL: https://github.com/apache/flink/pull/21440#discussion_r1038238028 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointStressITCase.java: ## @@ -559,4 +551,30 @@ public Record map(Record value) throws Ex

[jira] [Updated] (FLINK-30281) Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count

2022-12-02 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-30281: -- Description: Error which came up: [https://github.com/gaborgsomogyi/flink-kubernetes-operator

[GitHub] [flink-kubernetes-operator] tweise commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
tweise commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335361447 The setting that guards the config map creation: `.Values.defaultConfiguration.append` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-02 Thread GitBox
1996fanrui commented on code in PR #21368: URL: https://github.com/apache/flink/pull/21368#discussion_r1038217820 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java: ## @@ -36,52 +35,49 @@ import static org.apache.flink

[GitHub] [flink-kubernetes-operator] tweise commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
tweise commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335342783 https://github.com/apache/flink-kubernetes-operator/blob/8c0de99fd25d2bbf99ea0742fb6e2607b8799d80/helm/flink-kubernetes-operator/values.yaml#L93 -- This is an automated

[jira] [Updated] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-30282: -- Description: h3. Issue History This is not a new issue, FLINK-13604 has tracked it before, and FLINK-

[jira] [Commented] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642559#comment-17642559 ] Jane Chan commented on FLINK-30282: --- Hi [~twalthr],  [~shengkai] could you help to ver

[GitHub] [flink-kubernetes-operator] tweise commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
tweise commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335339491 Are the volume mounts created by default? If not, then we cannot assume the file to be present. At the very least we can add a few comments so the setup is easier to

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #467: [FLINK-30281] Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count

2022-12-02 Thread GitBox
gaborgsomogyi commented on PR #467: URL: https://github.com/apache/flink-kubernetes-operator/pull/467#issuecomment-1335336434 Makes sense, changing the approach... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Updated] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-30282: -- Description: h3. Issue History This is not a new issue, FLINK-13604 has tracked it before, and FLINK-

[jira] [Updated] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-30282: -- Parent: FLINK-12251 Issue Type: Sub-task (was: Bug) > Logical type ROW lost inner field's nul

[jira] [Updated] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-30282: -- Description: h3. Issue History This is not a new issue, FLINK-13604 has tracked it before, and FLINK-

[jira] [Updated] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-30282: -- Description: h3. Issue History This is not a new issue, FLINK-13604 has tracked it before, and FLINK-

[jira] [Updated] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-30282: -- Description: h3. Issue History This is not a new issue, FLINK-13604 has tracked it before, and FLINK-

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #467: [FLINK-30281] Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count

2022-12-02 Thread GitBox
morhidi commented on PR #467: URL: https://github.com/apache/flink-kubernetes-operator/pull/467#issuecomment-1335317416 There can be all sort of `ERROR.Count` like metrics in the log, not just `JmDeploymentStatus.ERROR.Count`. I simple don't understand why don't we check only the ERROR lev

[jira] [Created] (FLINK-30282) Logical type ROW lost inner field's nullability after convert to RelDataType

2022-12-02 Thread Jane Chan (Jira)
Jane Chan created FLINK-30282: - Summary: Logical type ROW lost inner field's nullability after convert to RelDataType Key: FLINK-30282 URL: https://issues.apache.org/jira/browse/FLINK-30282 Project: Flink

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-02 Thread GitBox
1996fanrui commented on code in PR #21368: URL: https://github.com/apache/flink/pull/21368#discussion_r1038195124 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java: ## @@ -36,52 +35,49 @@ import static org.apache.flink

[jira] [Commented] (FLINK-25438) KafkaProducerExactlyOnceITCase.testMultipleSinkOperators failed due to topic 'exactlyTopicCustomOperator20' already exists

2022-12-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642548#comment-17642548 ] Matthias Pohl commented on FLINK-25438: --- Ok, I was too fast in judging without loo

[jira] [Updated] (FLINK-30281) Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count

2022-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30281: --- Labels: pull-request-available (was: ) > Add operator error log whitelist entry for JmDeplo

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #467: [FLINK-30281] Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count

2022-12-02 Thread GitBox
gaborgsomogyi commented on PR #467: URL: https://github.com/apache/flink-kubernetes-operator/pull/467#issuecomment-1335311996 cc @morhidi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-02 Thread GitBox
1996fanrui commented on code in PR #21368: URL: https://github.com/apache/flink/pull/21368#discussion_r1038195124 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java: ## @@ -36,52 +35,49 @@ import static org.apache.flink

[GitHub] [flink-kubernetes-operator] gaborgsomogyi opened a new pull request, #467: [FLINK-30281] Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count

2022-12-02 Thread GitBox
gaborgsomogyi opened a new pull request, #467: URL: https://github.com/apache/flink-kubernetes-operator/pull/467 ## What is the purpose of the change The operator log error parser identified the metric as error which is definitely false positive: ``` Found error in log files.

[GitHub] [flink-kubernetes-operator] mbalassi closed pull request #438: [FLINK-29974] Not allowing the cancelling the which are already in the completed state.

2022-12-02 Thread GitBox
mbalassi closed pull request #438: [FLINK-29974] Not allowing the cancelling the which are already in the completed state. URL: https://github.com/apache/flink-kubernetes-operator/pull/438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #438: [FLINK-29974] Not allowing the cancelling the which are already in the completed state.

2022-12-02 Thread GitBox
mbalassi commented on PR #438: URL: https://github.com/apache/flink-kubernetes-operator/pull/438#issuecomment-1335308924 Closing in favor of #459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-29830) PulsarSinkITCase$DeliveryGuaranteeTest.writeRecordsToPulsar failed

2022-12-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29830: -- Fix Version/s: 1.16.1 1.15.4 > PulsarSinkITCase$DeliveryGuaranteeTest.write

[jira] [Resolved] (FLINK-29830) PulsarSinkITCase$DeliveryGuaranteeTest.writeRecordsToPulsar failed

2022-12-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-29830. --- Fix Version/s: 1.17.0 Resolution: Fixed master: f8b3b33ce1c2b36aa8e0011131a1ba74f5400

[jira] [Commented] (FLINK-30277) Allow PYTHONPATH of Python Worker configurable

2022-12-02 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642542#comment-17642542 ] Prabhu Joseph commented on FLINK-30277: --- Thanks [~dannycranmer]  > Allow PYTHONPA

[GitHub] [flink] XComp commented on pull request #21412: [BP-1.15][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

2022-12-02 Thread GitBox
XComp commented on PR #21412: URL: https://github.com/apache/flink/pull/21412#issuecomment-1335302664 Merging after @syhily gave thumbs up on the other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] XComp merged pull request #21412: [BP-1.15][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

2022-12-02 Thread GitBox
XComp merged PR #21412: URL: https://github.com/apache/flink/pull/21412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] XComp merged pull request #21411: [BP-1.16][FLINK-29830][Connector/Pulsar] Create the topic with schema before consuming messages in PulsarSinkITCase. (#21252)

2022-12-02 Thread GitBox
XComp merged PR #21411: URL: https://github.com/apache/flink/pull/21411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-02 Thread GitBox
1996fanrui commented on code in PR #21368: URL: https://github.com/apache/flink/pull/21368#discussion_r1038186940 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java: ## @@ -135,100 +134,98 @@ public void testAbortOldAndStar

[GitHub] [flink] XComp commented on a diff in pull request #21416: [FLINK-30202][tests] Do not assert on checkpointId

2022-12-02 Thread GitBox
XComp commented on code in PR #21416: URL: https://github.com/apache/flink/pull/21416#discussion_r1038158237 ## flink-connectors/flink-connector-datagen/src/test/java/org/apache/flink/connector/datagen/source/DataGeneratorSourceTest.java: ## @@ -99,23 +100,48 @@ void testReaderC

[jira] [Updated] (FLINK-30281) Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count

2022-12-02 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-30281: -- Summary: Add operator error log whitelist entry for JmDeploymentStatus.ERROR.Count (was: Add

[jira] [Commented] (FLINK-30281) Turn off operator metrics for e2e tests

2022-12-02 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642535#comment-17642535 ] Gabor Somogyi commented on FLINK-30281: --- OK, then adding a whitelist entry. > Tur

[jira] [Updated] (FLINK-30281) Add operator error log whitelist entry for

2022-12-02 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-30281: -- Summary: Add operator error log whitelist entry for (was: Turn off operator metrics for e2e

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
morhidi commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335281369 The Helm generates the file and refers it in the template. It doesn't have to be backed in the image. -- This is an automated message from the Apache Git Service. To re

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
morhidi commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335279354 > Have you checked the contents of this file? It is empty, hence the logging breaks. Unless we duplicate the default logging file which is already included in the operato

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
mxm commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335270930 Have you checked the contents of this file? It is empty, hence the logging breaks. Unless we duplicate the default logging file which is already included in the operator jar,

[GitHub] [flink-kubernetes-operator] mbalassi closed pull request #462: [FLINK-30266] Roll back change to HA metadata check logic

2022-12-02 Thread GitBox
mbalassi closed pull request #462: [FLINK-30266] Roll back change to HA metadata check logic URL: https://github.com/apache/flink-kubernetes-operator/pull/462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #462: [FLINK-30266] Roll back change to HA metadata check logic

2022-12-02 Thread GitBox
mbalassi commented on PR #462: URL: https://github.com/apache/flink-kubernetes-operator/pull/462#issuecomment-1335270825 Closing in favor of #465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (FLINK-30272) Introduce a Predicate Visitor

2022-12-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30272. Resolution: Fixed master: 69ebaa2a861da54dd21e62778a9e9eab73f72c18 > Introduce a Predicate Visito

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-02 Thread GitBox
1996fanrui commented on code in PR #21368: URL: https://github.com/apache/flink/pull/21368#discussion_r1038169829 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java: ## @@ -36,52 +35,49 @@ import static org.apache.flink

[GitHub] [flink-table-store] JingsongLi merged pull request #417: [FLINK-30272] Introduce a Predicate Visitor

2022-12-02 Thread GitBox
JingsongLi merged PR #417: URL: https://github.com/apache/flink-table-store/pull/417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
morhidi commented on PR #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466#issuecomment-1335260981 @max the file in question is mounted by the Helm chart, this PR makes no sense to me. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Updated] (FLINK-30280) Default operator logging configuration is broken

2022-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30280: --- Labels: pull-request-available (was: ) > Default operator logging configuration is broken >

[GitHub] [flink-kubernetes-operator] mxm opened a new pull request, #466: [FLINK-30280] Default operator logging configuration is broken

2022-12-02 Thread GitBox
mxm opened a new pull request, #466: URL: https://github.com/apache/flink-kubernetes-operator/pull/466 The default logging configuration is set here: https://github.com/apache/flink-kubernetes-operator/blob/ea01e294cf1b68d597244d0a11b3c81822a163e7/helm/flink-kubernetes-operator/templates/fli

[jira] [Commented] (FLINK-30281) Turn off operator metrics for e2e tests

2022-12-02 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642519#comment-17642519 ] Matyas Orhidi commented on FLINK-30281: --- The metrics must be enabled, Gabor. The E

[jira] [Updated] (FLINK-30281) Turn off operator metrics for e2e tests

2022-12-02 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-30281: -- Description: The metrics are adding no value but it can randomly blow up tests: [https://gith

[jira] [Assigned] (FLINK-30281) Turn off operator metrics for e2e tests

2022-12-02 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-30281: - Assignee: Gabor Somogyi > Turn off operator metrics for e2e tests > ---

[jira] [Created] (FLINK-30281) Turn off operator metrics for e2e tests

2022-12-02 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30281: - Summary: Turn off operator metrics for e2e tests Key: FLINK-30281 URL: https://issues.apache.org/jira/browse/FLINK-30281 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-30280) Default operator logging configuration is broken

2022-12-02 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642517#comment-17642517 ] Matyas Orhidi commented on FLINK-30280: --- The Helm installs the default configs it

[GitHub] [flink] flinkbot commented on pull request #21443: [FLINK-30213] Change ForwardPartitioner to RebalancePartitioner on parallelism changes

2022-12-02 Thread GitBox
flinkbot commented on PR #21443: URL: https://github.com/apache/flink/pull/21443#issuecomment-1335250901 ## CI report: * d265ebca00eca3ee03f7a60e0e366f1d7a6f6879 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30213) The edge is wrong when the vertex parallelism is changed

2022-12-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30213: --- Labels: pull-request-available (was: ) > The edge is wrong when the vertex parallelism is c

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #465: [FLINK-30266] Roll back change to HA metadata check logic

2022-12-02 Thread GitBox
morhidi commented on PR #465: URL: https://github.com/apache/flink-kubernetes-operator/pull/465#issuecomment-1335248312 @mbalassi I've rebased this revert on the reverted e2es :) , please merge it once the CI is finished and green. -- This is an automated message from the Apache Git Serv

[GitHub] [flink] mxm opened a new pull request, #21443: [FLINK-30213] Change ForwardPartitioner to RebalancePartitioner on parallelism changes

2022-12-02 Thread GitBox
mxm opened a new pull request, #21443: URL: https://github.com/apache/flink/pull/21443 ## What is the purpose of the change In case of parallelism changes to the JobGraph, as done via the AdaptiveScheduler or through providing JobVertexId overrides in PipelineOptions#PARALLELISM_OVER

[jira] [Commented] (FLINK-30277) Allow PYTHONPATH of Python Worker configurable

2022-12-02 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642510#comment-17642510 ] Danny Cranmer commented on FLINK-30277: --- Thanks [~prabhujoseph] , this makes sense

[jira] [Assigned] (FLINK-30277) Allow PYTHONPATH of Python Worker configurable

2022-12-02 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-30277: - Assignee: Prabhu Joseph > Allow PYTHONPATH of Python Worker configurable >

  1   2   3   >