[GitHub] [flink] slfan1989 closed pull request #21424: [FLINK-30243] Remove duplicate commas.

2022-11-29 Thread GitBox
slfan1989 closed pull request #21424: [FLINK-30243] Remove duplicate commas. URL: https://github.com/apache/flink/pull/21424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] slfan1989 commented on pull request #21424: [FLINK-30243] Remove duplicate commas.

2022-11-29 Thread GitBox
slfan1989 commented on PR #21424: URL: https://github.com/apache/flink/pull/21424#issuecomment-1331767186 > Thanks for this but I do question the value of this PR vs the resources it costs to build the PR: this can be fixed if someone touches on this code, but there's no value in creating a

[jira] [Closed] (FLINK-30243) Remove duplicate commas

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30243. -- Resolution: Invalid Per https://flink.apache.org/contributing/code-style-and-quality-pull-req

[jira] [Created] (FLINK-30246) Registering the same metric object with different name and group will conflict in metric reporter

2022-11-29 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-30246: - Summary: Registering the same metric object with different name and group will conflict in metric reporter Key: FLINK-30246 URL: https://issues.apache.org/jira/browse/FLINK-3024

[jira] [Commented] (FLINK-30242) Push localHashAggregate pass the union node

2022-11-29 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1764#comment-1764 ] Aitozi commented on FLINK-30242: Hi [~Runking], Sorry I have not noticed that. If you ha

[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

2022-11-29 Thread GitBox
fredia commented on PR #21405: URL: https://github.com/apache/flink/pull/21405#issuecomment-1331735494 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035602663 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkTable.java: ## @@ -76,4 +93,30 @@ public Transform[] partitioning() {

[jira] [Created] (FLINK-30245) NPE thrown when filtering decimal(18, 4) values after calling DecimalDataUtils.subtract method

2022-11-29 Thread Wei Zhong (Jira)
Wei Zhong created FLINK-30245: - Summary: NPE thrown when filtering decimal(18, 4) values after calling DecimalDataUtils.subtract method Key: FLINK-30245 URL: https://issues.apache.org/jira/browse/FLINK-30245

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035600618 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkRowData.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035598799 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkRowData.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-30242) Push localHashAggregate pass the union node

2022-11-29 Thread Runkang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641107#comment-17641107 ] Runkang He commented on FLINK-30242: We have already done this work, and have a pres

[jira] [Updated] (FLINK-29601) Add Estimator and Transformer for UnivariateFeatureSelector

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29601: --- Labels: pull-request-available (was: ) > Add Estimator and Transformer for UnivariateFeatur

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #187: [FLINK-29601] Add Estimator and Transformer for UnivariateFeatureSelector

2022-11-29 Thread GitBox
jiangxin369 opened a new pull request, #187: URL: https://github.com/apache/flink-ml/pull/187 ## What is the purpose of the change Add Estimator and Transformer for UnivariateFeatureSelector ## Brief change log - Adds Transformer and Estimator implementation of

[jira] [Commented] (FLINK-30138) BlobServerCleanupTest utilizes failsWithin with a quite low timeout which might result in test instabilities

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641105#comment-17641105 ] Matthias Pohl commented on FLINK-30138: --- https://dev.azure.com/apache-flink/apache

[jira] [Updated] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-11-29 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AlexHu updated FLINK-30244: --- Component/s: Kubernetes Operator Runtime / Task > When task using udf/udtf with jni, on k8s

[jira] [Closed] (FLINK-30206) Allow FileStoreScan to read incremental changes from OVERWRITE snapshot in Table Store

2022-11-29 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-30206. --- Resolution: Fixed master: c7bc1fb9d1d656dd93fafe66dbef185b560a33c2 > Allow FileStoreScan to read in

[jira] [Updated] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-11-29 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AlexHu updated FLINK-30244: --- Attachment: image-2022-11-30-15-05-29-120.png image-2022-11-30-15-04-45-696.png

[jira] [Commented] (FLINK-28177) Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPrimaryKey failed with 503 Service Unavailable

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641103#comment-17641103 ] Matthias Pohl commented on FLINK-28177: --- https://dev.azure.com/apache-flink/apache

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-28440: -- Affects Version/s: 1.17.0 > EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed wi

[GitHub] [flink-table-store] tsreaper merged pull request #406: [FLINK-30206] Allow FileStoreScan to read incremental changes from OVERWRITE snapshot in Table Store

2022-11-29 Thread GitBox
tsreaper merged PR #406: URL: https://github.com/apache/flink-table-store/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641100#comment-17641100 ] Matthias Pohl commented on FLINK-28440: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-29461) ProcessDataStreamStreamingTests.test_process_function unstable

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641099#comment-17641099 ] Matthias Pohl commented on FLINK-29461: --- No worries. Thanks for picking it up. :)

[jira] [Commented] (FLINK-30202) RateLimitedSourceReader may emit one more record than permitted

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641096#comment-17641096 ] Matthias Pohl commented on FLINK-30202: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-29830) PulsarSinkITCase$DeliveryGuaranteeTest.writeRecordsToPulsar failed

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641094#comment-17641094 ] Matthias Pohl commented on FLINK-29830: --- I moved this under the Umbrella Pulsar st

[jira] [Commented] (FLINK-29755) PulsarSourceUnorderedE2ECase.testSavepoint failed because of missing TaskManagers

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641095#comment-17641095 ] Matthias Pohl commented on FLINK-29755: --- I moved this under the Umbrella ticket fo

[jira] [Updated] (FLINK-29755) PulsarSourceUnorderedE2ECase.testSavepoint failed because of missing TaskManagers

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29755: -- Parent: FLINK-28352 Issue Type: Sub-task (was: Bug) > PulsarSourceUnorderedE2ECase.te

[jira] [Commented] (FLINK-29836) PulsarUnorderedSourceITCase failed due to an expected job restart not happening

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641093#comment-17641093 ] Matthias Pohl commented on FLINK-29836: --- I moved the issue under the Pulsar stabil

[jira] [Updated] (FLINK-29830) PulsarSinkITCase$DeliveryGuaranteeTest.writeRecordsToPulsar failed

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29830: -- Parent: FLINK-28352 Issue Type: Sub-task (was: Bug) > PulsarSinkITCase$DeliveryGuaran

[jira] [Updated] (FLINK-29836) PulsarUnorderedSourceITCase failed due to an expected job restart not happening

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29836: -- Parent: FLINK-28352 Issue Type: Sub-task (was: Bug) > PulsarUnorderedSourceITCase fai

[jira] [Updated] (FLINK-29835) NoClassDefFoundError in PulsarSourceUnorderedE2ECase

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29835: -- Component/s: Connectors / Pulsar > NoClassDefFoundError in PulsarSourceUnorderedE2ECase >

[jira] [Commented] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-11-29 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641092#comment-17641092 ] AlexHu commented on FLINK-30244: Sorry, now I have given more details about my problem. 

[jira] [Updated] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-11-29 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AlexHu updated FLINK-30244: --- Attachment: (was: image-2022-11-30-14-46-28-034.png) > When task using udf/udtf with jni, on k8s session

[jira] [Updated] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-11-29 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AlexHu updated FLINK-30244: --- Attachment: image-2022-11-30-14-47-50-923.png > When task using udf/udtf with jni, on k8s session the old TM

[jira] [Updated] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-11-29 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AlexHu updated FLINK-30244: --- Description: We face a problem when we try to use flink on k8s to execute task with udf/udtf. When we finis

[jira] [Updated] (FLINK-30244) When task using udf/udtf with jni, on k8s session the old TM will shut down and create new TM or the task will fail

2022-11-29 Thread AlexHu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AlexHu updated FLINK-30244: --- Attachment: image-2022-11-30-14-46-28-034.png Component/s: Deployment / Kubernetes Affec

[jira] [Commented] (FLINK-30244) When task using udf/udtf with jni, flink on k8s session the old

2022-11-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641089#comment-17641089 ] Gyula Fora commented on FLINK-30244: Could you please provide a proper title and des

[GitHub] [flink] flinkbot commented on pull request #21424: [FLINK-30243] Remove duplicate commas.

2022-11-29 Thread GitBox
flinkbot commented on PR #21424: URL: https://github.com/apache/flink/pull/21424#issuecomment-1331709963 ## CI report: * a84ebda92cd11441c676fb742fc8aeaa9c4fd5d0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-30244) When task using udf/udtf with jni, flink on k8s session the old

2022-11-29 Thread AlexHu (Jira)
AlexHu created FLINK-30244: -- Summary: When task using udf/udtf with jni, flink on k8s session the old Key: FLINK-30244 URL: https://issues.apache.org/jira/browse/FLINK-30244 Project: Flink Issue Ty

[jira] [Updated] (FLINK-30243) Remove duplicate commas

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30243: --- Labels: pull-request-available (was: ) > Remove duplicate commas > ---

[GitHub] [flink-table-store] JingsongLi merged pull request #409: [hotfix] Methods in AbstractFileStoreScan should be thread safe

2022-11-29 Thread GitBox
JingsongLi merged PR #409: URL: https://github.com/apache/flink-table-store/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] slfan1989 opened a new pull request, #21424: [FLINK-30243] Remove duplicate commas.

2022-11-29 Thread GitBox
slfan1989 opened a new pull request, #21424: URL: https://github.com/apache/flink/pull/21424 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Created] (FLINK-30243) Remove duplicate commas

2022-11-29 Thread Shilun Fan (Jira)
Shilun Fan created FLINK-30243: -- Summary: Remove duplicate commas Key: FLINK-30243 URL: https://issues.apache.org/jira/browse/FLINK-30243 Project: Flink Issue Type: Improvement Compone

[jira] [Commented] (FLINK-27518) Refactor migration tests to support version update automatically

2022-11-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641081#comment-17641081 ] Matthias Pohl commented on FLINK-27518: --- That's alright. Let me know if you need h

[jira] [Commented] (FLINK-27518) Refactor migration tests to support version update automatically

2022-11-29 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641079#comment-17641079 ] Yun Gao commented on FLINK-27518: - Hi [~mapohl] sorry I'm a bit bound in recent weeks an

[jira] [Created] (FLINK-30242) Push localHashAggregate pass the union node

2022-11-29 Thread Aitozi (Jira)
Aitozi created FLINK-30242: -- Summary: Push localHashAggregate pass the union node Key: FLINK-30242 URL: https://issues.apache.org/jira/browse/FLINK-30242 Project: Flink Issue Type: Improvement

[GitHub] [flink-table-store] JingsongLi merged pull request #408: [hotfix] Fix test unstable: use MergeFunctionFactory in TestFileStore

2022-11-29 Thread GitBox
JingsongLi merged PR #408: URL: https://github.com/apache/flink-table-store/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink-table-store] JingsongLi commented on pull request #408: [hotfix] Fix test unstable: use MergeFunctionFactory in TestFileStore

2022-11-29 Thread GitBox
JingsongLi commented on PR #408: URL: https://github.com/apache/flink-table-store/pull/408#issuecomment-1331689518 Validate by `FileStoreExpireTest.testNeverExpire`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035563500 ## flink-table-store-spark/src/test/java/org/apache/flink/table/store/spark/SparkWriteITCase.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035563191 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkTable.java: ## @@ -76,4 +94,47 @@ public Transform[] partitioning() {

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035562595 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkSource.java: ## @@ -69,7 +70,8 @@ public Table getTable( C

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035561248 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkCatalog.java: ## @@ -201,7 +202,9 @@ public Identifier[] listTables(String[]

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035562138 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkCatalog.java: ## @@ -201,7 +202,9 @@ public Identifier[] listTables(String[]

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035561248 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkCatalog.java: ## @@ -201,7 +202,9 @@ public Identifier[] listTables(String[]

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035560520 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkRowData.java: ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software F

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
JingsongLi commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035559675 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/SerializableCommittable.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apa

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #409: [hotfix] Methods in AbstractFileStoreScan should be thread safe

2022-11-29 Thread GitBox
JingsongLi opened a new pull request, #409: URL: https://github.com/apache/flink-table-store/pull/409 We already have tests in `FileStoreScanTest`, but it looks like JDK 8 can not reproduce failure. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [flink] wanglijie95 commented on pull request #21111: [FLINK-29664][runtime] Collect subpartition sizes of blocking result partitions

2022-11-29 Thread GitBox
wanglijie95 commented on PR #2: URL: https://github.com/apache/flink/pull/2#issuecomment-1331673275 I measured the space usage of `AllToAllBlockingResultInfo` on a real cluster. For an A -> B test job, where A -> B is an all-to-all edge, we test the space occupancy of `1024*1024`(10

[GitHub] [flink-kubernetes-operator] rgsriram commented on a diff in pull request #438: [FLINK-29974] Not allowing the cancelling the which are already in the completed state.

2022-11-29 Thread GitBox
rgsriram commented on code in PR #438: URL: https://github.com/apache/flink-kubernetes-operator/pull/438#discussion_r1035545283 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -362,11 +362,22 @@ public voi

[GitHub] [flink] liuml07 closed pull request #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by reusing resources

2022-11-29 Thread GitBox
liuml07 closed pull request #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by reusing resources URL: https://github.com/apache/flink/pull/21146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] liuml07 commented on pull request #21146: [FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by reusing resources

2022-11-29 Thread GitBox
liuml07 commented on PR #21146: URL: https://github.com/apache/flink/pull/21146#issuecomment-1331654767 Moved to apache/flink-connector-jdbc#4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #4: [FLINK-29750][Connector/JDBC] Improve PostgresCatalog#listTables() by reusing resources

2022-11-29 Thread GitBox
boring-cyborg[bot] commented on PR #4: URL: https://github.com/apache/flink-connector-jdbc/pull/4#issuecomment-1331653893 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an a

[GitHub] [flink-connector-jdbc] liuml07 opened a new pull request, #4: [FLINK-29750][Connector/JDBC] Improve PostgresCatalog#listTables() by reusing resources

2022-11-29 Thread GitBox
liuml07 opened a new pull request, #4: URL: https://github.com/apache/flink-connector-jdbc/pull/4 ## What is the purpose of the change Currently the `PostgresCatalog#listTables()` creates a new connection and prepared statement for every schema and table when listing tables. This can

[GitHub] [flink-ml] lindong28 commented on pull request #186: [hotfix] Add Python quickstart link in README

2022-11-29 Thread GitBox
lindong28 commented on PR #186: URL: https://github.com/apache/flink-ml/pull/186#issuecomment-1331639878 @zhipeng93 Can you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [flink-ml] lindong28 opened a new pull request, #186: [hotfix] Add Python quickstart link in README

2022-11-29 Thread GitBox
lindong28 opened a new pull request, #186: URL: https://github.com/apache/flink-ml/pull/186 ## What is the purpose of the change Add Python quickstart link in README ## Brief change log Added Python quickstart link in README ## Does this pull request potentially af

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

2022-11-29 Thread GitBox
yangjf2019 commented on PR #451: URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1331638731 Okay, thanks, I'll take a look as soon as I can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (FLINK-30168) PyFlink Deserialization Error with Object Array

2022-11-29 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641051#comment-17641051 ] Yunfeng Zhou commented on FLINK-30168: -- Apart from the proposed solution mentioned

[GitHub] [flink] flinkbot commented on pull request #21423: [1.15] [FLINK-27341][runtime] Remove LOOPBACK from TaskManager findConnectingAddress.

2022-11-29 Thread GitBox
flinkbot commented on PR #21423: URL: https://github.com/apache/flink/pull/21423#issuecomment-1331608254 ## CI report: * efee1392fd5936a99f8e21967875933aa6aa65e0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] lindong28 merged pull request #182: [FLINK-30160] Add Transformer for FValueTest

2022-11-29 Thread GitBox
lindong28 merged PR #182: URL: https://github.com/apache/flink-ml/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] lindong28 commented on pull request #182: [FLINK-30160] Add Transformer for FValueTest

2022-11-29 Thread GitBox
lindong28 commented on PR #182: URL: https://github.com/apache/flink-ml/pull/182#issuecomment-1331607135 Thanks for the PR! Thanks @yunfengzhou-hub for the review. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] gaoyunhaii opened a new pull request, #21423: [1.15] [FLINK-27341][runtime] Remove LOOPBACK from TaskManager findConnectingAddress.

2022-11-29 Thread GitBox
gaoyunhaii opened a new pull request, #21423: URL: https://github.com/apache/flink/pull/21423 Picks https://github.com/apache/flink/pull/21319 to 1.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot commented on pull request #21422: [1.16] [FLINK-27341][runtime] Remove LOOPBACK from TaskManager findConnectingAddress.

2022-11-29 Thread GitBox
flinkbot commented on PR #21422: URL: https://github.com/apache/flink/pull/21422#issuecomment-1331600271 ## CI report: * 5c6db8caf26e6698c354fa676f955ae099c2b9ba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaoyunhaii opened a new pull request, #21422: [1.16] [FLINK-27341][runtime] Remove LOOPBACK from TaskManager findConnectingAddress.

2022-11-29 Thread GitBox
gaoyunhaii opened a new pull request, #21422: URL: https://github.com/apache/flink/pull/21422 This PR picks https://github.com/apache/flink/pull/21319 to flink 1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #182: [FLINK-30160] Add Transformer for FValueTest

2022-11-29 Thread GitBox
yunfengzhou-hub commented on PR #182: URL: https://github.com/apache/flink-ml/pull/182#issuecomment-1331596109 Thanks for the update. It LGTM. @lindong28 Could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Comment Edited] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-11-29 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641045#comment-17641045 ] dalongliu edited comment on FLINK-29729 at 11/30/22 3:08 AM: -

[jira] [Comment Edited] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-11-29 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641045#comment-17641045 ] dalongliu edited comment on FLINK-29729 at 11/30/22 3:08 AM: -

[jira] [Commented] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-11-29 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641045#comment-17641045 ] dalongliu commented on FLINK-29729: --- [~stayrascal] [~qinjunjerry] Sorry for the late r

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035471430 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkWrite.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035471537 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkWrite.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035471430 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkWrite.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035471236 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkWrite.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035470172 ## flink-table-store-spark/src/test/java/org/apache/flink/table/store/spark/SparkWriteITCase.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Softw

[jira] [Updated] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-11-29 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-29729: Fix Version/s: 1.17.0 > Support including the configured properties from flink-conf.yaml during > create

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035465488 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkTable.java: ## @@ -76,4 +94,47 @@ public Transform[] partitioning() {

[jira] [Commented] (FLINK-30221) Fix the bug of sum(try_cast(string as bigint)) return null when partial elements can't convert to bigint

2022-11-29 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641039#comment-17641039 ] dalongliu commented on FLINK-30221: --- [~tonyzhu] you can try it, and pull the pr. > Fi

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035464138 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkSource.java: ## @@ -69,7 +70,8 @@ public Table getTable(

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035463434 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkCatalog.java: ## @@ -201,7 +202,9 @@ public Identifier[] listTables(String[

[jira] [Commented] (FLINK-30221) Fix the bug of sum(try_cast(string as bigint)) return null when partial elements can't convert to bigint

2022-11-29 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641038#comment-17641038 ] dalongliu commented on FLINK-30221: --- [~martijnvisser] I know TRY_CAST will return a NU

[GitHub] [flink] tisonkun closed pull request #21207: [FLINK-25686][Connector/Pulsar] Add schema evolution support for Pulsar connector

2022-11-29 Thread GitBox
tisonkun closed pull request #21207: [FLINK-25686][Connector/Pulsar] Add schema evolution support for Pulsar connector URL: https://github.com/apache/flink/pull/21207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink] tisonkun commented on pull request #21207: [FLINK-25686][Connector/Pulsar] Add schema evolution support for Pulsar connector

2022-11-29 Thread GitBox
tisonkun commented on PR #21207: URL: https://github.com/apache/flink/pull/21207#issuecomment-1331557250 Closing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [flink] tisonkun commented on pull request #21207: [FLINK-25686][Connector/Pulsar] Add schema evolution support for Pulsar connector

2022-11-29 Thread GitBox
tisonkun commented on PR #21207: URL: https://github.com/apache/flink/pull/21207#issuecomment-1331557183 @MartijnVisser Thanks for your help! Sounds good :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035458908 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkRowData.java: ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035457157 ## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkRowData.java: ## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035455519 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/SerializableCommittable.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Ap

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #394: [FLINK-29614] Introduce Spark writer for table store

2022-11-29 Thread GitBox
SteNicholas commented on code in PR #394: URL: https://github.com/apache/flink-table-store/pull/394#discussion_r1035455519 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/SerializableCommittable.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Ap

[jira] [Created] (FLINK-30241) Flink ML Iteration ConcurrentModificationException

2022-11-29 Thread Yunfeng Zhou (Jira)
Yunfeng Zhou created FLINK-30241: Summary: Flink ML Iteration ConcurrentModificationException Key: FLINK-30241 URL: https://issues.apache.org/jira/browse/FLINK-30241 Project: Flink Issue Type

[jira] [Closed] (FLINK-30054) Move existing Pulsar connector code from Flink repo to dedicated Pulsar repo

2022-11-29 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30054. -- Fix Version/s: pulsar-3.0.0 Assignee: Martijn Visser (was: Yufan Sheng) Resolu

[GitHub] [flink-connector-pulsar] MartijnVisser merged pull request #1: [FLINK-30054][Connector/Pulsar] Move existing Pulsar connector code

2022-11-29 Thread GitBox
MartijnVisser merged PR #1: URL: https://github.com/apache/flink-connector-pulsar/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink-connector-pulsar] boring-cyborg[bot] commented on pull request #1: [FLINK-30054][Connector/Pulsar] Move existing Pulsar connector code

2022-11-29 Thread GitBox
boring-cyborg[bot] commented on PR #1: URL: https://github.com/apache/flink-connector-pulsar/pull/1#issuecomment-1331195854 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [flink] flinkbot commented on pull request #21421: [FLINK-30240][table]Fix doc error reference to TableKind#MANAGED

2022-11-29 Thread GitBox
flinkbot commented on PR #21421: URL: https://github.com/apache/flink/pull/21421#issuecomment-1331188723 ## CI report: * 6fdeff542559ec28b570873446e303c60d17e00b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30240) Fix Doc error pointing to TableKind#MANAGED

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30240: --- Labels: pull-request-available (was: ) > Fix Doc error pointing to TableKind#MANAGED > ---

  1   2   3   4   >