[jira] [Closed] (FLINK-30223) Refactor Lock to provide Lock.Factory

2022-11-27 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-30223. --- Resolution: Fixed master: 6886303b2f482f2f31c7b98221691a650c1e67d3 > Refactor Lock to provide Lock.

[GitHub] [flink-table-store] tsreaper merged pull request #405: [FLINK-30223] Refactor Lock to provide Lock.Factory

2022-11-27 Thread GitBox
tsreaper merged PR #405: URL: https://github.com/apache/flink-table-store/pull/405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[GitHub] [flink] Zakelly commented on a diff in pull request #21362: [FLINK-29430] Add sanity check when setCurrentKeyGroupIndex

2022-11-27 Thread GitBox
Zakelly commented on code in PR #21362: URL: https://github.com/apache/flink/pull/21362#discussion_r1033205960 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java: ## @@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey) {

[jira] [Assigned] (FLINK-30185) Provide the flame graph to the subtask level

2022-11-27 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-30185: Assignee: Rui Fan > Provide the flame graph to the subtask level > --

[jira] [Commented] (FLINK-30185) Provide the flame graph to the subtask level

2022-11-27 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639837#comment-17639837 ] Xintong Song commented on FLINK-30185: -- [~fanrui], Sounds good to me. You are assi

[jira] [Updated] (FLINK-30206) Allow FileStoreScan to read incremental changes from OVERWRITE snapshot in Table Store

2022-11-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30206: --- Labels: pull-request-available (was: ) > Allow FileStoreScan to read incremental changes fr

[GitHub] [flink-table-store] tsreaper opened a new pull request, #406: [FLINK-30206] Allow FileStoreScan to read incremental changes from OVERWRITE snapshot in Table Store

2022-11-27 Thread GitBox
tsreaper opened a new pull request, #406: URL: https://github.com/apache/flink-table-store/pull/406 Currently `AbstractFileStoreScan` can only read incremental changes from APPEND snapshots. However in OVERWRITE snapshots, users will also append new records to table. These changes must be d

[GitHub] [flink] shuiqiangchen commented on pull request #20745: [FLINK-28988] Don't push filters down into the right table for temporal join

2022-11-27 Thread GitBox
shuiqiangchen commented on PR #20745: URL: https://github.com/apache/flink/pull/20745#issuecomment-1328639959 @lincoln-lil Thanks for your detailed explanation in online and offline discussions. I have simplified the implementation with the consensus we had reached. -- This is an automat

[jira] [Commented] (FLINK-30221) Fix the bug of sum(try_cast(string as bigint)) return null when partial elements can't convert to bigint

2022-11-27 Thread Tony Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639823#comment-17639823 ] Tony Zhu commented on FLINK-30221: -- Could you assign to me and I'd like to try the fix.

[jira] [Commented] (FLINK-30158) [Flink SQL][Protobuf] NullPointerException when querying Kafka topic using repeated or map attributes

2022-11-27 Thread Tony Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639822#comment-17639822 ] Tony Zhu commented on FLINK-30158: -- [~jamesmcguirepro]  could you provide more info? I'

[jira] [Closed] (FLINK-29987) PartialUpdateITCase.testForeignKeyJo is unstable

2022-11-27 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29987. Resolution: Fixed master: cd0870bab446ad8e91dab3ddd3b3b6e7ef71612f > PartialUpdateITCase.testFore

[GitHub] [flink-table-store] JingsongLi merged pull request #404: [FLINK-29987] Use Awaitility in PartialUpdateITCase#testForeignKeyJoin

2022-11-27 Thread GitBox
JingsongLi merged PR #404: URL: https://github.com/apache/flink-table-store/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #405: [FLINK-30223] Refactor Lock to provide Lock.Factory

2022-11-27 Thread GitBox
JingsongLi commented on code in PR #405: URL: https://github.com/apache/flink-table-store/pull/405#discussion_r1033178800 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/Lock.java: ## @@ -31,13 +32,57 @@ public interface Lock extends AutoClose

[jira] [Closed] (FLINK-30205) Modify compact interface for TableWrite and FileStoreWrite to support normal compaction in Table Store

2022-11-27 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30205. Resolution: Fixed master: e6e62699ef42a90d9eb2ca73b10460eb2764a586 > Modify compact interface for

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #403: [FLINK-30205] Modify compact interface for TableWrite and FileStoreWrite to support normal compaction in Table Store

2022-11-27 Thread GitBox
JingsongLi commented on code in PR #403: URL: https://github.com/apache/flink-table-store/pull/403#discussion_r1033177161 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RecordWriter.java: ## @@ -34,10 +34,12 @@ void write(T record) throws Ex

[GitHub] [flink-table-store] JingsongLi merged pull request #403: [FLINK-30205] Modify compact interface for TableWrite and FileStoreWrite to support normal compaction in Table Store

2022-11-27 Thread GitBox
JingsongLi merged PR #403: URL: https://github.com/apache/flink-table-store/pull/403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (FLINK-30185) Provide the flame graph to the subtask level

2022-11-27 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639816#comment-17639816 ] Rui Fan commented on FLINK-30185: - Hi [~xtsong] , thanks for your reply. The improvemen

[jira] [Updated] (FLINK-30185) Provide the flame graph to the subtask level

2022-11-27 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-30185: Attachment: image-2022-11-28-14-48-20-462.png > Provide the flame graph to the subtask level > ---

[jira] [Updated] (FLINK-30185) Provide the flame graph to the subtask level

2022-11-27 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-30185: Attachment: image-2022-11-28-14-38-47-145.png > Provide the flame graph to the subtask level > ---

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21362: [FLINK-29430] Add sanity check when setCurrentKeyGroupIndex

2022-11-27 Thread GitBox
rkhachatryan commented on code in PR #21362: URL: https://github.com/apache/flink/pull/21362#discussion_r1033165454 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperatorTest.java: ## @@ -556,9 +559,27 @@ public void testSc

[jira] [Updated] (FLINK-15635) Allow passing a ClassLoader to EnvironmentSettings

2022-11-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-15635: -- Release Note: TableEnvironment introduces a user class loader to have a consistent class loading beha

[GitHub] [flink] Myasuka commented on a diff in pull request #21362: [FLINK-29430] Add sanity check when setCurrentKeyGroupIndex

2022-11-27 Thread GitBox
Myasuka commented on code in PR #21362: URL: https://github.com/apache/flink/pull/21362#discussion_r1033158877 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java: ## @@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey) {

[jira] [Updated] (FLINK-14055) Add advanced function DDL syntax "USING JAR"

2022-11-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-14055: -- Release Note: In 1.16, we introduced the `CREATE FUNCTION ... USING JAR` syntax to support the dynami

[jira] [Closed] (FLINK-30184) Save TM/JM thread stack periodically

2022-11-27 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan closed FLINK-30184. --- Resolution: Won't Do > Save TM/JM thread stack periodically > > >

[jira] (FLINK-30184) Save TM/JM thread stack periodically

2022-11-27 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30184 ] Rui Fan deleted comment on FLINK-30184: - was (Author: fanrui): Hi [~xtsong] , please help take a look in your free time. And if it makes sense, please assign it to me, thanks~ > Save TM/JM thre

[jira] [Commented] (FLINK-30184) Save TM/JM thread stack periodically

2022-11-27 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639802#comment-17639802 ] Rui Fan commented on FLINK-30184: - Hi [~xtsong] , thanks for your explanation. It sound

[GitHub] [flink] 1996fanrui commented on pull request #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

2022-11-27 Thread GitBox
1996fanrui commented on PR #21398: URL: https://github.com/apache/flink/pull/21398#issuecomment-1328573385 Hi @gyfora @mxm As we know, when the flink job run on IDEA, it will use the MiniCluster. And `PerJobMiniClusterFactory#getMiniClusterConfig` generate the `numSlotsPerTaskManage

[GitHub] [flink] SmirAlex commented on pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-27 Thread GitBox
SmirAlex commented on PR #20919: URL: https://github.com/apache/flink/pull/20919#issuecomment-1328553285 Hi @XComp, thanks for the review! I answered on your comments and added a commit with fix. Have a look when you will be available, please. -- This is an automated message from the Apac

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-27 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1033131501 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -107,7

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-27 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1033131501 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -107,7

[GitHub] [flink] flinkbot commented on pull request #21406: [FLINK-30088][runtime] Fix excessive state updates for TtlMapState and TtlListState

2022-11-27 Thread GitBox
flinkbot commented on PR #21406: URL: https://github.com/apache/flink/pull/21406#issuecomment-1328531809 ## CI report: * cf8b7c1de5e3dfbe83106a4de89423e17e36e50e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30088) Excessive state updates for TtlMapState and TtlListState

2022-11-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30088: --- Labels: pull-request-available (was: ) > Excessive state updates for TtlMapState and TtlLis

[GitHub] [flink] rovboyko opened a new pull request, #21406: [FLINK-30088][runtime] Fix excessive state updates for TtlMapState and TtlListState

2022-11-27 Thread GitBox
rovboyko opened a new pull request, #21406: URL: https://github.com/apache/flink/pull/21406 …d TtlListState ## What is the purpose of the change Avoid unnecessary state updates for TtlMapState and TtlListState in case they are not changed. This affects only HashMapStateBack

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-11-27 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1033120828 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/inputformat/InputFormatCacheLoader.java: ## @@ -39,12

[jira] [Commented] (FLINK-30185) Provide the flame graph to the subtask level

2022-11-27 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639778#comment-17639778 ] Xintong Song commented on FLINK-30185: -- I think this makes a nice improvement. Coul

[jira] [Commented] (FLINK-23035) Add explicit method to StateChangelogWriter to write metadata

2022-11-27 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639777#comment-17639777 ] Yanfei Lei commented on FLINK-23035: [~binh] of course, welcome to help review.😊 >

[jira] [Commented] (FLINK-30184) Save TM/JM thread stack periodically

2022-11-27 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639775#comment-17639775 ] Xintong Song commented on FLINK-30184: -- [~fanrui], sorry for the late response. I

[jira] [Commented] (FLINK-23035) Add explicit method to StateChangelogWriter to write metadata

2022-11-27 Thread Xinbin Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639773#comment-17639773 ] Xinbin Huang commented on FLINK-23035: -- hey [~Yanfei Lei] , sorry I missed the mess

[jira] [Commented] (FLINK-24870) Cannot cast "java.util.Date" to "java.time.Instant"

2022-11-27 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639769#comment-17639769 ] dalongliu commented on FLINK-24870: --- [~wangbaohua] I pull your code from gitee, but te

[GitHub] [flink] Zakelly commented on a diff in pull request #21362: [FLINK-29430] Add sanity check when setCurrentKeyGroupIndex

2022-11-27 Thread GitBox
Zakelly commented on code in PR #21362: URL: https://github.com/apache/flink/pull/21362#discussion_r1033104544 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java: ## @@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey) {

[GitHub] [flink] flinkbot commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

2022-11-27 Thread GitBox
flinkbot commented on PR #21405: URL: https://github.com/apache/flink/pull/21405#issuecomment-1328493977 ## CI report: * fdc39492b315dbecc5b4cff8f222caa53eebee87 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-23035) Add explicit method to StateChangelogWriter to write metadata

2022-11-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23035: --- Labels: pull-request-available (was: ) > Add explicit method to StateChangelogWriter to wri

[GitHub] [flink] fredia opened a new pull request, #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

2022-11-27 Thread GitBox
fredia opened a new pull request, #21405: URL: https://github.com/apache/flink/pull/21405 ## What is the purpose of the change Add explicit append() to StateChangelogWriter to write metadata. ## Brief change log - Add explicit `StateChange(byte[] value)`

[GitHub] [flink] fsk119 commented on a diff in pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-11-27 Thread GitBox
fsk119 commented on code in PR #21133: URL: https://github.com/apache/flink/pull/21133#discussion_r1033065242 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java: ## @@ -79,6 +79,23 @@ public void closeSession(SessionH

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #403: [FLINK-30205] Modify compact interface for TableWrite and FileStoreWrite to support normal compaction in Table Store

2022-11-27 Thread GitBox
tsreaper commented on code in PR #403: URL: https://github.com/apache/flink-table-store/pull/403#discussion_r1033078213 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RecordWriter.java: ## @@ -34,10 +34,12 @@ void write(T record) throws Exce

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #405: [FLINK-30223] Refactor Lock to provide Lock.Factory

2022-11-27 Thread GitBox
tsreaper commented on code in PR #405: URL: https://github.com/apache/flink-table-store/pull/405#discussion_r1033077832 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/Lock.java: ## @@ -31,13 +32,57 @@ public interface Lock extends AutoCloseab

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #403: [FLINK-30205] Modify compact interface for TableWrite and FileStoreWrite to support normal compaction in Table Store

2022-11-27 Thread GitBox
JingsongLi commented on code in PR #403: URL: https://github.com/apache/flink-table-store/pull/403#discussion_r1033075278 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RecordWriter.java: ## @@ -34,10 +34,12 @@ void write(T record) throws Ex

[GitHub] [flink-table-store] JingsongLi commented on pull request #405: [FLINK-30223] Refactor Lock to provide Lock.Factory

2022-11-27 Thread GitBox
JingsongLi commented on PR #405: URL: https://github.com/apache/flink-table-store/pull/405#issuecomment-1328450069 This is second refactor PR for https://github.com/apache/flink-table-store/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Updated] (FLINK-30223) Refactor Lock to provide Lock.Factory

2022-11-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30223: --- Labels: pull-request-available (was: ) > Refactor Lock to provide Lock.Factory > --

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #405: [FLINK-30223] Refactor Lock to provide Lock.Factory

2022-11-27 Thread GitBox
JingsongLi opened a new pull request, #405: URL: https://github.com/apache/flink-table-store/pull/405 For the core, it should not see too many Flink Table concepts, such as database and tableName. It only needs to create a Lock. -- This is an automated message from the Apache Git Service.

[jira] [Created] (FLINK-30223) Refactor Lock to provide Lock.Factory

2022-11-27 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-30223: Summary: Refactor Lock to provide Lock.Factory Key: FLINK-30223 URL: https://issues.apache.org/jira/browse/FLINK-30223 Project: Flink Issue Type: Improvement

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

2022-11-27 Thread GitBox
yangjf2019 commented on PR #451: URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1328445247 Hi, @gyfora The central repository has generated the corresponding dependencies, please trigger the CI again, thank you! -- This is an automated message from the Apa

[jira] [Commented] (FLINK-30164) Expose BucketComputer from SupportsWrite

2022-11-27 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639748#comment-17639748 ] Caizhi Weng commented on FLINK-30164: - master: d8eb796f035f35e1ac85ff3f657452dd2a41e

[jira] [Updated] (FLINK-30164) Expose BucketComputer from SupportsWrite

2022-11-27 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-30164: Release Note: (was: master: d8eb796f035f35e1ac85ff3f657452dd2a41e644) > Expose BucketComputer fr

[jira] [Closed] (FLINK-30164) Expose BucketComputer from SupportsWrite

2022-11-27 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-30164. --- Release Note: master: d8eb796f035f35e1ac85ff3f657452dd2a41e644 Resolution: Fixed > Expose Buck

[GitHub] [flink-table-store] tsreaper merged pull request #400: [FLINK-30164] Expose BucketComputer from SupportsWrite

2022-11-27 Thread GitBox
tsreaper merged PR #400: URL: https://github.com/apache/flink-table-store/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[jira] [Assigned] (FLINK-29987) PartialUpdateITCase.testForeignKeyJo is unstable

2022-11-27 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-29987: Assignee: Alex Sorokoumov > PartialUpdateITCase.testForeignKeyJo is unstable > --

[GitHub] [flink] 1996fanrui commented on pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-11-27 Thread GitBox
1996fanrui commented on PR #21368: URL: https://github.com/apache/flink/pull/21368#issuecomment-1328427197 Hi @XComp @snuyanzin , I have addressed all comments, please help take a look, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] sethsaperstein-lyft commented on a diff in pull request #20844: [FLINK-29099][connectors/kinesis] Update global watermark for idle subtask

2022-11-27 Thread GitBox
sethsaperstein-lyft commented on code in PR #20844: URL: https://github.com/apache/flink/pull/20844#discussion_r1033036319 ## flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/JobManagerWatermarkTracker.java: ## @@ -92,6 +1

[GitHub] [flink] flinkbot commented on pull request #21404: [hotfix][docs] Update Zookeper version infromation

2022-11-27 Thread GitBox
flinkbot commented on PR #21404: URL: https://github.com/apache/flink/pull/21404#issuecomment-1328366465 ## CI report: * 1f3ac78db1fb4ae3562196f4a9bd8d51b4c383a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] t0560r91 opened a new pull request, #21404: [hotfix][docs] Update Zookeper version infromation

2022-11-27 Thread GitBox
t0560r91 opened a new pull request, #21404: URL: https://github.com/apache/flink/pull/21404 Updating the doc as Flink 1.15.2 ships with Zookeeper 3.5.9 in `lib` and 3.6.3 in `opt` folder in reality. And removing a sentence making notes about Zookeeper 3.4 not being compatible with 3.5 be

[jira] [Comment Edited] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-27 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639718#comment-17639718 ] Steven Zhen Wu edited comment on FLINK-30035 at 11/27/22 10:02 PM: ---

[GitHub] [flink] sethsaperstein-lyft commented on pull request #20844: [FLINK-29099][connectors/kinesis] Update global watermark for idle subtask

2022-11-27 Thread GitBox
sethsaperstein-lyft commented on PR #20844: URL: https://github.com/apache/flink/pull/20844#issuecomment-1328347988 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Comment Edited] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-27 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639718#comment-17639718 ] Steven Zhen Wu edited comment on FLINK-30035 at 11/27/22 8:56 PM:

[jira] [Comment Edited] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-27 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639718#comment-17639718 ] Steven Zhen Wu edited comment on FLINK-30035 at 11/27/22 8:55 PM:

[jira] [Comment Edited] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-27 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639718#comment-17639718 ] Steven Zhen Wu edited comment on FLINK-30035 at 11/27/22 8:55 PM:

[jira] [Comment Edited] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-27 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639718#comment-17639718 ] Steven Zhen Wu edited comment on FLINK-30035 at 11/27/22 8:54 PM:

[jira] [Comment Edited] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-27 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639718#comment-17639718 ] Steven Zhen Wu edited comment on FLINK-30035 at 11/27/22 8:53 PM:

[jira] [Commented] (FLINK-30035) ./bin/sql-client.sh won't import external jar into the session

2022-11-27 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639718#comment-17639718 ] Steven Zhen Wu commented on FLINK-30035: [~fsk119] here are the steps to reprodu

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032994738 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/splitter/MongoSampleSplitter.java: ## @@ -0,0 +1,131 @@ +/*

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032991900 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoRowDataLookupFunction.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed t

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032644671 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSink.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032989565 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSink.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032983609 ## flink-connector-mongodb-e2e-tests/src/test/java/org/apache/flink/tests/util/mongodb/MongoE2ECase.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apa

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032983150 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoScanSourceSplitReader.java: ## @@ -0,0 +1,201 @@ +/*

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032983150 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoScanSourceSplitReader.java: ## @@ -0,0 +1,201 @@ +/*

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032977743 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/assigner/MongoSplitAssigner.java: ## @@ -0,0 +1,58 @@ +/* +

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032971595 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/splitter/MongoShardedSplitter.java: ## @@ -0,0 +1,117 @@ +/*

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032963748 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/splitter/MongoShardedSplitter.java: ## @@ -0,0 +1,117 @@ +/*

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032957642 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/splitter/MongoShardedSplitter.java: ## @@ -0,0 +1,117 @@ +/*

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-27 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1032955663 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoScanSourceSplitReader.java: ## @@ -0,0 +1,201 @@ +/*

[GitHub] [flink] flinkbot commented on pull request #21403: [FLINK-29984][flink-metrics] Prometheus histogram minmax

2022-11-27 Thread GitBox
flinkbot commented on PR #21403: URL: https://github.com/apache/flink/pull/21403#issuecomment-1328234175 ## CI report: * d916abd22d6bb510b39df1c51b04f74ad92c8d59 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] qingwei91 commented on a diff in pull request #21403: [FLINK-29984][flink-metrics] Prometheus histogram minmax

2022-11-27 Thread GitBox
qingwei91 commented on code in PR #21403: URL: https://github.com/apache/flink/pull/21403#discussion_r1032920245 ## flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java: ## @@ -378,6 +390,22 @@ private void addS

[jira] [Updated] (FLINK-29984) Flink Histogram not emitting min and max when using Prometheus Reporter

2022-11-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29984: --- Labels: pull-request-available (was: ) > Flink Histogram not emitting min and max when usin

[GitHub] [flink] qingwei91 opened a new pull request, #21403: [FLINK-29984][flink-metrics] Prometheus histogram minmax

2022-11-27 Thread GitBox
qingwei91 opened a new pull request, #21403: URL: https://github.com/apache/flink/pull/21403 ## What is the purpose of the change Expose Histogram min and max when exporting to Prometheus, the data is already available, we just need to export it. This is enabled in both Prometheus

[jira] [Updated] (FLINK-30222) Suspended a job in last-state mode bug

2022-11-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30222: --- Priority: Blocker (was: Major) > Suspended a job in last-state mode bug > -

[jira] [Updated] (FLINK-30222) Suspended a job in last-state mode bug

2022-11-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30222: --- Fix Version/s: kubernetes-operator-1.3.0 > Suspended a job in last-state mode bug >

[jira] [Commented] (FLINK-30222) Suspended a job in last-state mode bug

2022-11-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639640#comment-17639640 ] Gyula Fora commented on FLINK-30222: Good catch! Would you like to work on this tick

[jira] [Created] (FLINK-30222) Suspended a job in last-state mode bug

2022-11-27 Thread tanjialiang (Jira)
tanjialiang created FLINK-30222: --- Summary: Suspended a job in last-state mode bug Key: FLINK-30222 URL: https://issues.apache.org/jira/browse/FLINK-30222 Project: Flink Issue Type: Bug