[GitHub] [flink] fsk119 merged pull request #21134: [FLINK-29677] Prevent dropping the current catalog

2022-10-23 Thread GitBox
fsk119 merged PR #21134: URL: https://github.com/apache/flink/pull/21134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] flinkbot commented on pull request #21136: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-23 Thread GitBox
flinkbot commented on PR #21136: URL: https://github.com/apache/flink/pull/21136#issuecomment-1288505413 ## CI report: * 0cc2200f45faddcddeaf90eaa4aceb31b9bcab2f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-23 Thread GitBox
gyfora commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1002929772 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkResourceExceptionUtils.java: ## @@ -0,0 +1,118 @@ +/* + * Lic

[GitHub] [flink] fredia opened a new pull request, #21136: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-23 Thread GitBox
fredia opened a new pull request, #21136: URL: https://github.com/apache/flink/pull/21136 ## What is the purpose of the change Improve logging in SharedStateRegistry and make the conditional logic more clear. This PR is copied from https://github.com/apache/flink/pull/207

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29733: - Labels: pull-request-available test-stability (was: pull-request-available) > Error Flink conne

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29733: - Component/s: Connectors / Hive > Error Flink connector hive Test failing > -

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-29733: - Affects Version/s: 1.17.0 > Error Flink connector hive Test failing > --

[GitHub] [flink-kubernetes-operator] rgsriram commented on a diff in pull request #408: Added improvements on the flink python example Dockerfile

2022-10-23 Thread GitBox
rgsriram commented on code in PR #408: URL: https://github.com/apache/flink-kubernetes-operator/pull/408#discussion_r1002928530 ## examples/flink-python-example/Dockerfile: ## @@ -36,7 +36,7 @@ apt-get clean && \ rm -rf /var/lib/apt/lists/* # install PyFlink -RUN pip3 insta

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-23 Thread GitBox
gyfora commented on code in PR #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409#discussion_r1002927900 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/AbstractFlinkSpec.java: ## @@ -57,6 +57,9 @@ public abstract cl

[GitHub] [flink] jiangjiguang commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-23 Thread GitBox
jiangjiguang commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1288495452 @luoyuxia packer is made by this.packer = Packer.LITTLE_ENDIAN.newBytePacker(bitWidth); so it impossible to run the abstract parent class BytePacker'method ![image](https:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #408: Added improvements on the flink python example Dockerfile

2022-10-23 Thread GitBox
gyfora commented on code in PR #408: URL: https://github.com/apache/flink-kubernetes-operator/pull/408#discussion_r1002926848 ## examples/flink-python-example/Dockerfile: ## @@ -36,7 +36,7 @@ apt-get clean && \ rm -rf /var/lib/apt/lists/* # install PyFlink -RUN pip3 install

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #407: [FLINK-29713] Kubernetes operator should restart failed jobs

2022-10-23 Thread GitBox
gyfora commented on code in PR #407: URL: https://github.com/apache/flink-kubernetes-operator/pull/407#discussion_r1002922589 ## docs/content/docs/custom-resource/job-management.md: ## @@ -241,6 +241,21 @@ In order this feature to work one must enable [recovery of missing job

[GitHub] [flink] flinkbot commented on pull request #21135: [FLINK-29733][hotfix/test] fix error caused due to FLINK-29478

2022-10-23 Thread GitBox
flinkbot commented on PR #21135: URL: https://github.com/apache/flink/pull/21135#issuecomment-1288493675 ## CI report: * 4230e8f92af3ef533028295688fe1a0fd68e9591 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fredia commented on a diff in pull request #21050: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-23 Thread GitBox
fredia commented on code in PR #21050: URL: https://github.com/apache/flink/pull/21050#discussion_r997761529 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -95,60 +95,78 @@ public StreamStateHandle registerReference(

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29733: --- Labels: pull-request-available (was: ) > Error Flink connector hive Test failing >

[GitHub] [flink] Samrat002 opened a new pull request, #21135: [FLINK-29733][hotfix/test] fix error caused due to FLINK-29478

2022-10-23 Thread GitBox
Samrat002 opened a new pull request, #21135: URL: https://github.com/apache/flink/pull/21135 ## What is the purpose of the change This is a quick fix missed due to FLINK-29478. *(For example: This pull request makes task deployment go through the blob server, rather than th

[jira] [Created] (FLINK-29734) Support authentication in the Flink SQL Gateway

2022-10-23 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-29734: - Summary: Support authentication in the Flink SQL Gateway Key: FLINK-29734 URL: https://issues.apache.org/jira/browse/FLINK-29734 Project: Flink Issue Type:

[jira] [Updated] (FLINK-29733) Error Flink connector hive Test failing

2022-10-23 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-29733: --- Summary: Error Flink connector hive Test failing (was: Error Flink connector hive ) > Error Flink

[jira] [Created] (FLINK-29733) Error Flink connector hive

2022-10-23 Thread Samrat Deb (Jira)
Samrat Deb created FLINK-29733: -- Summary: Error Flink connector hive Key: FLINK-29733 URL: https://issues.apache.org/jira/browse/FLINK-29733 Project: Flink Issue Type: Bug Reporter:

[GitHub] [flink] jiangjiguang commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-23 Thread GitBox
jiangjiguang commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1288481471 ![image](https://user-images.githubusercontent.com/12368495/197461285-91ad97a8-7c56-4037-ae31-39383dac4fe9.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] jiangjiguang commented on pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-23 Thread GitBox
jiangjiguang commented on PR #20830: URL: https://github.com/apache/flink/pull/20830#issuecomment-1288480519 ![image](https://user-images.githubusercontent.com/12368495/197461152-ede7d0cb-cd71-4f41-82f6-37947f350ddd.png) -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] jiangjiguang commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-23 Thread GitBox
jiangjiguang commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1002916628 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[jira] [Commented] (FLINK-29478) Flink sql Connector hive to support 3.1.3

2022-10-23 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622976#comment-17622976 ] Samrat Deb commented on FLINK-29478: Looking into it [~hxb] !  > Flink sql Connecto

[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622973#comment-17622973 ] Xingbo Huang commented on FLINK-29405: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622971#comment-17622971 ] Xingbo Huang commented on FLINK-24119: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622969#comment-17622969 ] Xingbo Huang commented on FLINK-29405: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Commented] (FLINK-29478) Flink sql Connector hive to support 3.1.3

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622967#comment-17622967 ] Xingbo Huang commented on FLINK-29478: -- [https://dev.azure.com/apache-flink/apache-

[jira] [Commented] (FLINK-29387) IntervalJoinITCase.testIntervalJoinSideOutputRightLateData failed with AssertionError

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622965#comment-17622965 ] Xingbo Huang commented on FLINK-29387: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Commented] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-10-23 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622964#comment-17622964 ] Xingbo Huang commented on FLINK-24119: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Updated] (FLINK-29684) [UI] Upgrade runtime web Angular framework and associated deps to v14

2022-10-23 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-29684: Fix Version/s: 1.17.0 > [UI] Upgrade runtime web Angular framework and associated deps to v14 > --

[jira] [Comment Edited] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-23 Thread Zhiping Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622955#comment-17622955 ] Zhiping Wu edited comment on FLINK-29729 at 10/24/22 5:28 AM:

[jira] [Comment Edited] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-23 Thread Zhiping Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622955#comment-17622955 ] Zhiping Wu edited comment on FLINK-29729 at 10/24/22 5:26 AM:

[jira] [Comment Edited] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-23 Thread Zhiping Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622955#comment-17622955 ] Zhiping Wu edited comment on FLINK-29729 at 10/24/22 5:25 AM:

[jira] [Commented] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-23 Thread Zhiping Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622955#comment-17622955 ] Zhiping Wu commented on FLINK-29729: Hi [~lsy], thanks for looking at this case. >F

[jira] [Commented] (FLINK-29692) Support early/late fires for Windowing TVFs

2022-10-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622950#comment-17622950 ] Benchao Li commented on FLINK-29692: Regarding "early-fire with window" versus "unbo

[jira] [Commented] (FLINK-29728) TablePlanner prevents Flink from starting is working directory is a symbolic link

2022-10-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622948#comment-17622948 ] Weijie Guo commented on FLINK-29728: [~angelok] Thanks for reporting this, the code

[GitHub] [flink] fredia commented on a diff in pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-23 Thread GitBox
fredia commented on code in PR #20965: URL: https://github.com/apache/flink/pull/20965#discussion_r1002873597 ## flink-state-backends/flink-statebackend-common/src/main/java/org/apache/flink/state/common/ChangelogMaterializationMetricGroup.java: ## @@ -51,14 +57,17 @@ public Cha

[GitHub] [flink] luoyuxia commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

2022-10-23 Thread GitBox
luoyuxia commented on code in PR #20830: URL: https://github.com/apache/flink/pull/20830#discussion_r1002872635 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java: ## @@ -265,8 +265,16 @@ void readNextGroup() {

[jira] [Comment Edited] (FLINK-29692) Support early/late fires for Windowing TVFs

2022-10-23 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622940#comment-17622940 ] Jing Zhang edited comment on FLINK-29692 at 10/24/22 4:21 AM:

[jira] [Commented] (FLINK-29692) Support early/late fires for Windowing TVFs

2022-10-23 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622940#comment-17622940 ] Jing Zhang commented on FLINK-29692: Sorry for late response. I'm still wondering w

[GitHub] [flink-table-store] SteNicholas commented on pull request #327: [FLINK-29252] Support create table-store table with 'connector'='table-store'

2022-10-23 Thread GitBox
SteNicholas commented on PR #327: URL: https://github.com/apache/flink-table-store/pull/327#issuecomment-1288397838 @JingsongLi, could you add this way that creates table in the `Create Table` document? -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [flink] zoltar9264 commented on a diff in pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-23 Thread GitBox
zoltar9264 commented on code in PR #20965: URL: https://github.com/apache/flink/pull/20965#discussion_r1002868608 ## flink-state-backends/flink-statebackend-common/src/main/java/org/apache/flink/state/common/ChangelogMaterializationMetricGroup.java: ## @@ -51,14 +57,17 @@ public

[GitHub] [flink] luoyuxia commented on a diff in pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-10-23 Thread GitBox
luoyuxia commented on code in PR #21128: URL: https://github.com/apache/flink/pull/21128#discussion_r1002865693 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -39,6 +39,11 @@ under the License. 0.9.8 10.10.2.0 1.8.2 +

[GitHub] [flink] flinkbot commented on pull request #21134: [FLINK-29677] Prevent dropping the current catalog

2022-10-23 Thread GitBox
flinkbot commented on PR #21134: URL: https://github.com/apache/flink/pull/21134#issuecomment-1288372336 ## CI report: * e637df006f28bfd7c27b570561b43c0a7c0f015f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LadyForest opened a new pull request, #21134: [FLINK-29677] Prevent dropping the current catalog

2022-10-23 Thread GitBox
LadyForest opened a new pull request, #21134: URL: https://github.com/apache/flink/pull/21134 ## What is the purpose of the change This pull request fixes the issue that when dropping a catalog in use, the following SHOW CURRENT CATALOG still displays the dropped catalog by preventing

[jira] [Updated] (FLINK-29677) Prevent dropping the current catalog

2022-10-23 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-29677: -- Summary: Prevent dropping the current catalog (was: DROP CATALOG statement does not reset current cat

[jira] [Updated] (FLINK-29677) DROP CATALOG statement does not reset current catalog

2022-10-23 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-29677: -- Affects Version/s: 1.16.0 > DROP CATALOG statement does not reset current catalog > -

[GitHub] [flink] flinkbot commented on pull request #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-10-23 Thread GitBox
flinkbot commented on PR #21133: URL: https://github.com/apache/flink/pull/21133#issuecomment-1288356742 ## CI report: * c6c7fe02c0c3b17bd3dd8231c25cbe279b600a5a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29732) Support configuring session with SQL statement

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29732: --- Labels: pull-request-available (was: ) > Support configuring session with SQL statement > -

[GitHub] [flink] yuzelin opened a new pull request, #21133: [FLINK-29732][sql-gateway] support configuring session with SQL statement.

2022-10-23 Thread GitBox
yuzelin opened a new pull request, #21133: URL: https://github.com/apache/flink/pull/21133 …h sql statement. ## What is the purpose of the change Implement `SqlGatewayService#configureSession` described in [FLIP-91](https://cwiki.apache.org/confluence/display/FLINK/FLIP-91%

[jira] [Updated] (FLINK-29732) Support configuring session with SQL statement

2022-10-23 Thread yuzelin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzelin updated FLINK-29732: Description: Implement SqlGatewayService#configureSession described in [FLIP-91|https://cwiki.apache.org/c

[jira] [Created] (FLINK-29732) Support configuring session with SQL statement

2022-10-23 Thread yuzelin (Jira)
yuzelin created FLINK-29732: --- Summary: Support configuring session with SQL statement Key: FLINK-29732 URL: https://issues.apache.org/jira/browse/FLINK-29732 Project: Flink Issue Type: Sub-task

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #326: [FLINK-29702] Add micro benchmarks module and merge tree reader/writer benchmarks

2022-10-23 Thread GitBox
JingsongLi commented on code in PR #326: URL: https://github.com/apache/flink-table-store/pull/326#discussion_r1002844838 ## flink-table-store-benchmark/flink-table-store-micro-benchmarks/src/main/java/org/apache/flink/table/store/benchmark/file/mergetree/MergeTreeWriterBenchmark.java:

[jira] [Comment Edited] (FLINK-29646) SQL Gateway should return a simpler error message

2022-10-23 Thread yuzelin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622923#comment-17622923 ] yuzelin edited comment on FLINK-29646 at 10/24/22 2:47 AM: --- Th

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #328: [FLINK-29714] Merge TableWrite and TableCompact into one interface

2022-10-23 Thread GitBox
JingsongLi commented on code in PR #328: URL: https://github.com/apache/flink-table-store/pull/328#discussion_r1002843817 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/CompactStrategy.java: ## @@ -37,4 +37,7 @@ public interface Compa

[jira] [Commented] (FLINK-29646) SQL Gateway should return a simpler error message

2022-10-23 Thread yuzelin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622923#comment-17622923 ] yuzelin commented on FLINK-29646: - Thanks for your suggestion. As [~fsk119] said, recent

[GitHub] [flink] fredia commented on a diff in pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-23 Thread GitBox
fredia commented on code in PR #20965: URL: https://github.com/apache/flink/pull/20965#discussion_r1002841563 ## flink-state-backends/flink-statebackend-common/src/main/java/org/apache/flink/state/common/ChangelogMaterializationMetricGroup.java: ## @@ -51,14 +57,17 @@ public Cha

[jira] [Commented] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-23 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622913#comment-17622913 ] dalongliu commented on FLINK-29729: --- Do we can configure the aws credential info at th

[jira] [Closed] (FLINK-28256) Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-23 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-28256. Resolution: Fixed master: 9cf4f76b736000a2ccd31a937551c0bca1c2e557 2d0562329615727cb0406cb9afd18cc

[jira] [Updated] (FLINK-28796) Add Statement Completement API for sql gateway rest endpoint

2022-10-23 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-28796: -- Parent: FLINK-29073 Issue Type: Sub-task (was: Improvement) > Add Statement Completem

[jira] [Commented] (FLINK-28914) Could not find any factories that implement

2022-10-23 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622908#comment-17622908 ] Shengkai Fang commented on FLINK-28914: --- Yes. Thanks for the mention. I think it s

[GitHub] [flink-table-store] JingsongLi closed pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-23 Thread GitBox
JingsongLi closed pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite URL: https://github.com/apache/flink-table-store/pull/305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-table-store] JingsongLi commented on pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

2022-10-23 Thread GitBox
JingsongLi commented on PR #305: URL: https://github.com/apache/flink-table-store/pull/305#issuecomment-1288308960 Merged in 9cf4f76b736000a2ccd31a937551c0bca1c2e557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (FLINK-29188) The option `sql-gateway.endpint.hiveserver2.catalog.hive-conf-dir` should be requried

2022-10-23 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-29188. - Fix Version/s: 1.16.0 (was: 1.17.0) Resolution: Fixed > The option

[jira] [Updated] (FLINK-29731) Protobuf-confluent format

2022-10-23 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-29731: -- Component/s: Formats (JSON, Avro, Parquet, ORC, SequenceFile) (was: Table

[jira] [Commented] (FLINK-29731) Protobuf-confluent format

2022-10-23 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622906#comment-17622906 ] Shengkai Fang commented on FLINK-29731: --- Is it same to the confluent avro format[1

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

2022-10-23 Thread GitBox
fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1288285590 Sorry for the late response. I will take a look this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-29731) Protobuf-confluent format

2022-10-23 Thread Krish Narukulla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krish Narukulla updated FLINK-29731: Description: Flink needs to integrate with Confluent for protobuf format, to able to lever

[jira] [Commented] (FLINK-29708) Enrich Flink Kubernetes Operator CRD error field

2022-10-23 Thread Daren Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622894#comment-17622894 ] Daren Wong commented on FLINK-29708: Hi Gyula, thanks for the feedback, have updated

[jira] [Updated] (FLINK-29708) Enrich Flink Kubernetes Operator CRD error field

2022-10-23 Thread Daren Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daren Wong updated FLINK-29708: --- Description: h1. Problem Statement: FlinkDeployment and FlinkSessionJob CRD has a CommonStatus erro

[jira] [Updated] (FLINK-29708) Enrich Flink Kubernetes Operator CRD error field

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29708: --- Labels: pull-request-available (was: ) > Enrich Flink Kubernetes Operator CRD error field >

[GitHub] [flink-kubernetes-operator] darenwkt opened a new pull request, #409: [FLINK-29708] Convert CR Error field to JSON with enriched exception …

2022-10-23 Thread GitBox
darenwkt opened a new pull request, #409: URL: https://github.com/apache/flink-kubernetes-operator/pull/409 ## What is the purpose of the change This PR aims to: - Store exception metadata in JSON format under existing CR Error field. Metadata includes: exception type, mess

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-23 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1288189339 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] qingwei91 commented on pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-23 Thread GitBox
qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1288133847 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] 1996fanrui commented on pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-23 Thread GitBox
1996fanrui commented on PR #21131: URL: https://github.com/apache/flink/pull/21131#issuecomment-1288125009 Hi @pnowojski , please help take a look this PR in your free time. This PR can simplify the `ChannelStateWriteRequestDispatcherImpl`, and it is useful for FLINK-29730. Af

[jira] [Commented] (FLINK-29729) Support including the configured properties from flink-conf.yaml during create ParquetReader

2022-10-23 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622806#comment-17622806 ] dalongliu commented on FLINK-29729: --- Thanks for opening this ticket, I will take a loo

[jira] [Created] (FLINK-29731) Protobuf-confluent format

2022-10-23 Thread Krishnaiah Narukulla (Jira)
Krishnaiah Narukulla created FLINK-29731: Summary: Protobuf-confluent format Key: FLINK-29731 URL: https://issues.apache.org/jira/browse/FLINK-29731 Project: Flink Issue Type: New Fea

[GitHub] [flink] RocMarshal commented on pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2022-10-23 Thread GitBox
RocMarshal commented on PR #20990: URL: https://github.com/apache/flink/pull/20990#issuecomment-1288099447 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Resolved] (FLINK-22402) Add hive dialect test in sql-client

2022-10-23 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-22402. -- Resolution: Invalid Close it since we have hive dialect test in sql-clinet > Add hive dialect test in

[GitHub] [flink] qingwei91 commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-23 Thread GitBox
qingwei91 commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r1002679105 ## flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSourceITCase.java: ## @@ -264,6 +264,146 @@ void testLimi

[GitHub] [flink] 1996fanrui commented on pull request #21131: [FLINK-29730][checkpoint] Simplify the ChannelStateWriteRequestDispatcherImpl due to not supported concurrent unaligned checkpoint

2022-10-23 Thread GitBox
1996fanrui commented on PR #21131: URL: https://github.com/apache/flink/pull/21131#issuecomment-1288068334 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] qingwei91 commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-23 Thread GitBox
qingwei91 commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r1002677936 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownPreparedStatementVisitor.java: ## @@ -0,0 +1,178 @@ +/*

[GitHub] [flink] flinkbot commented on pull request #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-23 Thread GitBox
flinkbot commented on PR #21132: URL: https://github.com/apache/flink/pull/21132#issuecomment-1288064935 ## CI report: * 5bb906442bd4ec76b04600149131412e70386ae7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29134) fetch metrics may cause oom(ThreadPool task pile up)

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29134: --- Labels: pull-request-available (was: ) > fetch metrics may cause oom(ThreadPool task pile u

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #21132: [FLINK-29134][metrics] Do not repeatedly add useless metric updating tasks to avoid wasting resources

2022-10-23 Thread GitBox
TanYuxin-tyx opened a new pull request, #21132: URL: https://github.com/apache/flink/pull/21132 ## What is the purpose of the change In https://issues.apache.org/jira/projects/FLINK/issues/FLINK-29134, the OOM issue is caused by adding too many useless updating metric task

[GitHub] [flink] zoltar9264 commented on pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-23 Thread GitBox
zoltar9264 commented on PR #20965: URL: https://github.com/apache/flink/pull/20965#issuecomment-1288046005 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] libenchao commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-10-23 Thread GitBox
libenchao commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r1002654132 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownPreparedStatementVisitor.java: ## @@ -0,0 +1,178 @@ +/*