[GitHub] [flink] Sxnan commented on a diff in pull request #20147: [FLINK-27524][datastream] Introduce cache API to DataStream

2022-08-02 Thread GitBox
Sxnan commented on code in PR #20147: URL: https://github.com/apache/flink/pull/20147#discussion_r936303287 ## flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/CachedDataStream.scala: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (FLINK-28786) Cannot run PyFlink 1.16 on MacOS with M1 chip

2022-08-02 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-28786: Component/s: API / Python > Cannot run PyFlink 1.16 on MacOS with M1 chip > --

[jira] [Commented] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2022-08-02 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574543#comment-17574543 ] Maciej BryƄski commented on FLINK-26051: [~qingyue] Waiting for it :) > one sql

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #334: [hotfix] Clean up warnings and unnecessary code in tests

2022-08-02 Thread GitBox
gyfora commented on PR #334: URL: https://github.com/apache/flink-kubernetes-operator/pull/334#issuecomment-1203553673 I will take a look into some extra rules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Created] (FLINK-28786) Cannot run PyFlink 1.16 on MacOS with M1 chip

2022-08-02 Thread Ran Tao (Jira)
Ran Tao created FLINK-28786: --- Summary: Cannot run PyFlink 1.16 on MacOS with M1 chip Key: FLINK-28786 URL: https://issues.apache.org/jira/browse/FLINK-28786 Project: Flink Issue Type: Bug Affec

[jira] [Updated] (FLINK-28785) Hybrid shuffle consumer thread and upstream thread may have dead lock

2022-08-02 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-28785: --- Description: In hybrid shuffle mode, subpartition view lock will be acquired by consumer thread, an

[jira] [Updated] (FLINK-28785) Hybrid shuffle consumer thread and upstream thread may have dead lock

2022-08-02 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-28785: --- Description: In hybrid shuffle mode, subpartition view lock will be acquired by consumer thread, an

[jira] [Created] (FLINK-28785) Hybrid shuffle consumer thread and upstream thread may have dead lock

2022-08-02 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-28785: -- Summary: Hybrid shuffle consumer thread and upstream thread may have dead lock Key: FLINK-28785 URL: https://issues.apache.org/jira/browse/FLINK-28785 Project: Flink

[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #334: [hotfix] Clean up warnings and unnecessary code in tests

2022-08-02 Thread GitBox
Aitozi commented on PR #334: URL: https://github.com/apache/flink-kubernetes-operator/pull/334#issuecomment-1203546068 @morhidi I think we have already use the same checkstyle from the flink project. But there are still some are not enforced eg: the deprecated junit.assert use, because the

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #332: [FLINK-28625] Guard against changing target session deployment for sessionjob

2022-08-02 Thread GitBox
Aitozi commented on code in PR #332: URL: https://github.com/apache/flink-kubernetes-operator/pull/332#discussion_r936285972 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -430,16 +420,24 @@ private Option

[jira] [Commented] (FLINK-27217) Support partition filter push down when there exists default_parition

2022-08-02 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574525#comment-17574525 ] luoyuxia commented on FLINK-27217: -- When the filter expressions contains some expressio

[GitHub] [flink] lindong28 commented on a diff in pull request #20275: [FLINK-28606][Runtime/Checkpointing] Preserve consistency of OperatorEvent from OperatorCoordinator to subtasks

2022-08-02 Thread GitBox
lindong28 commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r936161829 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/CoordinatorEventsToStreamOperatorRecipientExactlyOnceITCase.java: ## @@ -0,0 +1,559 @@ +

[GitHub] [flink] PatrickRen commented on pull request #20414: [FLINK-28418][table] Add runtime provider interfaces for partial caching lookup

2022-08-02 Thread GitBox
PatrickRen commented on PR #20414: URL: https://github.com/apache/flink/pull/20414#issuecomment-1203535477 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] PatrickRen commented on pull request #20382: [FLINK-28419][table] Add runtime provider interface for full caching lookup + implement Periodic and Timed cache reload triggers

2022-08-02 Thread GitBox
PatrickRen commented on PR #20382: URL: https://github.com/apache/flink/pull/20382#issuecomment-1203535088 @SmirAlex Yeah we have to wait for a green CI run. It should be running now so let's wait for a while. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #334: [hotfix] Clean up warnings and unnecessary code in tests

2022-08-02 Thread GitBox
morhidi commented on PR #334: URL: https://github.com/apache/flink-kubernetes-operator/pull/334#issuecomment-1203532261 yeah +1 :) Do you think guys we could/should enable some warning elimination mechanism also on the project or it's too ambitious? -- This is an automated message from t

[GitHub] [flink] SmirAlex commented on pull request #20382: [FLINK-28419][table] Add runtime provider interface for full caching lookup + implement Periodic and Timed cache reload triggers

2022-08-02 Thread GitBox
SmirAlex commented on PR #20382: URL: https://github.com/apache/flink/pull/20382#issuecomment-1203527747 @PatrickRen I resolved your comments and rebased. Additionally I changed error messages and config descriptions, so they now correspond to the ones for partial caching. You can have a lo

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #333: [hotfix][docs] Minor doc improvements/corrections

2022-08-02 Thread GitBox
gyfora merged PR #333: URL: https://github.com/apache/flink-kubernetes-operator/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #334: [hotfix] Clean up warnings and unnecessary code in tests

2022-08-02 Thread GitBox
gyfora merged PR #334: URL: https://github.com/apache/flink-kubernetes-operator/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #332: [FLINK-28625] Guard against changing target session deployment for sessionjob

2022-08-02 Thread GitBox
gyfora commented on code in PR #332: URL: https://github.com/apache/flink-kubernetes-operator/pull/332#discussion_r936271130 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -430,16 +420,24 @@ private Option

[GitHub] [flink] SmirAlex commented on a diff in pull request #20382: [FLINK-28419][table] Add runtime provider interface for full caching lookup + implement Periodic and Timed cache reload triggers

2022-08-02 Thread GitBox
SmirAlex commented on code in PR #20382: URL: https://github.com/apache/flink/pull/20382#discussion_r936269235 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/lookup/LookupOptions.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache So

[GitHub] [flink] pltbkd commented on a diff in pull request #20388: [FLINK-28708][table-planner] Introduce planner rules to optimize dpp pattern

2022-08-02 Thread GitBox
pltbkd commented on code in PR #20388: URL: https://github.com/apache/flink/pull/20388#discussion_r936267384 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/DynamicPartitionPruningRule.java: ## @@ -0,0 +1,920 @@ +/* + * L

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936266590 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SessionCaseITTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936266416 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SessionCaseITTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936266252 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SessionCaseITTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936265792 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SessionCaseITTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936265448 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SessionCaseITTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936265194 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/RestAPIITTestBase.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936264708 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/RestAPIITTestBase.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936263515 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/RestAPIITTestBase.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936264126 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/RestAPIITTestBase.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936257349 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/RestAPIITTestBase.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] GOODBOY008 commented on pull request #20427: [FLINK-28783] [flink-core] Class ConfigOptions's example code have error.

2022-08-02 Thread GitBox
GOODBOY008 commented on PR #20427: URL: https://github.com/apache/flink/pull/20427#issuecomment-1203510467 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936257349 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/RestAPIITTestBase.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936255953 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/RestAPIITTestBase.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #332: [FLINK-28625] Guard against changing target session deployment for sessionjob

2022-08-02 Thread GitBox
Aitozi commented on PR #332: URL: https://github.com/apache/flink-kubernetes-operator/pull/332#issuecomment-1203479669 cc @gyfora -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink] liuyongvs commented on pull request #20424: [FLINK-28780][docs] fix incorrect description of function dayofmonth.

2022-08-02 Thread GitBox
liuyongvs commented on PR #20424: URL: https://github.com/apache/flink/pull/20424#issuecomment-1203473658 hi @snuyanzin ci passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] PatrickRen commented on a diff in pull request #20382: [FLINK-28419][table] Add runtime provider interface for full caching lookup + implement Periodic and Timed cache reload triggers

2022-08-02 Thread GitBox
PatrickRen commented on code in PR #20382: URL: https://github.com/apache/flink/pull/20382#discussion_r936217253 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/lookup/cache/trigger/PeriodicCacheReloadTrigger.java: ## @@ -0,0 +1,131 @@ +/*

[jira] [Resolved] (FLINK-28611) Add Transformer for ElementwiseProduct

2022-08-02 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang resolved FLINK-28611. --- Resolution: Fixed fixed via 0f1ad10b0760abea9c3551f9985f9fdd2a077f54 > Add Transformer for

[GitHub] [flink-ml] zhipeng93 merged pull request #135: [FLINK-28611] Add Transformer for ElementwiseProduct

2022-08-02 Thread GitBox
zhipeng93 merged PR #135: URL: https://github.com/apache/flink-ml/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] zhipeng93 commented on pull request #135: [FLINK-28611] Add Transformer for ElementwiseProduct

2022-08-02 Thread GitBox
zhipeng93 commented on PR #135: URL: https://github.com/apache/flink-ml/pull/135#issuecomment-1203459485 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20393: [FLINK-28570][table-planner] Introduces a StreamNonDeterministicPlanResolver to validate and try to solve (lookup join only) t

2022-08-02 Thread GitBox
lincoln-lil commented on code in PR #20393: URL: https://github.com/apache/flink/pull/20393#discussion_r935658039 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalIncrementalGroupAggregate.scala: ## @@ -62,

[GitHub] [flink] pltbkd commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-02 Thread GitBox
pltbkd commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r936212347 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/DynamicFilteringData.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936209901 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/util/RestClientUtils.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (FLINK-28784) ParameterTool support read and parse program arguments from yml file

2022-08-02 Thread Aiden Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574474#comment-17574474 ] Aiden Gong commented on FLINK-28784: [~Leonard] What do you think about this ? If ne

[jira] [Closed] (FLINK-23174) Log improvement in Task throws Error

2022-08-02 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-23174. --- Resolution: Won't Fix Close due to inactive and no response. > Log improvement in Task throws Error > -

[GitHub] [flink] zhuzhurk closed pull request #16315: FLINK-23174 Log improvement in Task throws Error

2022-08-02 Thread GitBox
zhuzhurk closed pull request #16315: FLINK-23174 Log improvement in Task throws Error URL: https://github.com/apache/flink/pull/16315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [flink] zhuzhurk closed pull request #9688: [FLINK-13056][runtime] Introduce FastRestartPipelinedRegionStrategy

2022-08-02 Thread GitBox
zhuzhurk closed pull request #9688: [FLINK-13056][runtime] Introduce FastRestartPipelinedRegionStrategy URL: https://github.com/apache/flink/pull/9688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zhuzhurk commented on pull request #9688: [FLINK-13056][runtime] Introduce FastRestartPipelinedRegionStrategy

2022-08-02 Thread GitBox
zhuzhurk commented on PR #9688: URL: https://github.com/apache/flink/pull/9688#issuecomment-1203448923 The change is already covered in the performance improvements of scheduler and this PR is not needed. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink] zhuzhurk closed pull request #10283: [1.9][FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2022-08-02 Thread GitBox
zhuzhurk closed pull request #10283: [1.9][FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10283 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [flink] zhuzhurk closed pull request #10284: [1.8][FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2022-08-02 Thread GitBox
zhuzhurk closed pull request #10284: [1.8][FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10284 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [flink] zhuzhurk closed pull request #10462: [FLINK-15031][runtime] Calculate required shuffle memory before allocating slots if resources are specified

2022-08-02 Thread GitBox
zhuzhurk closed pull request #10462: [FLINK-15031][runtime] Calculate required shuffle memory before allocating slots if resources are specified URL: https://github.com/apache/flink/pull/10462 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Created] (FLINK-28784) ParameterTool support read and parse program arguments from yml file

2022-08-02 Thread Aiden Gong (Jira)
Aiden Gong created FLINK-28784: -- Summary: ParameterTool support read and parse program arguments from yml file Key: FLINK-28784 URL: https://issues.apache.org/jira/browse/FLINK-28784 Project: Flink

[jira] [Closed] (FLINK-28151) Allow to cancel the Operation for the HiveServer2 Endpoint

2022-08-02 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-28151. - Resolution: Implemented Implemented in the master: 69df7a46bf439fc94ad1074b0d9ea9b3503632b1 > A

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936200616 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpoint.java: ## @@ -37,6 +46,7 @@ public class SqlGatewayRestEndpo

[GitHub] [flink] fsk119 closed pull request #20402: [FLINK-28151]Allow to cancel the Operation for the HiveServer2 Endpoint.

2022-08-02 Thread GitBox
fsk119 closed pull request #20402: [FLINK-28151]Allow to cancel the Operation for the HiveServer2 Endpoint. URL: https://github.com/apache/flink/pull/20402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] chaozwn commented on pull request #20402: [FLINK-28151]Allow to cancel the Operation for the HiveServer2 Endpoint.

2022-08-02 Thread GitBox
chaozwn commented on PR #20402: URL: https://github.com/apache/flink/pull/20402#issuecomment-1203436727 > I add a commit to fix the mentioned problem. Could you take a look when CI test passes, @chaozwn ? LGTM -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] pltbkd commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-02 Thread GitBox
pltbkd commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r936198465 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/dynamicfiltering/DynamicFilteringDataCollectorOperatorCoordinator.java: ## @@ -0

[GitHub] [flink] pltbkd commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-02 Thread GitBox
pltbkd commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r936197852 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/dynamicfiltering/DynamicFilteringDataCollectorOperator.java: ## @@ -0,0 +1,180 @

[jira] [Closed] (FLINK-28765) Create a doc for protobuf format

2022-08-02 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-28765. -- Resolution: Implemented > Create a doc for protobuf format > > >

[jira] [Commented] (FLINK-28765) Create a doc for protobuf format

2022-08-02 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574466#comment-17574466 ] Benchao Li commented on FLINK-28765: fixed via 92ec61a54df2a66183633c57944eac774dd48

[GitHub] [flink] libenchao closed pull request #20408: [FLINK-28765] Create a doc for protobuf format

2022-08-02 Thread GitBox
libenchao closed pull request #20408: [FLINK-28765] Create a doc for protobuf format URL: https://github.com/apache/flink/pull/20408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] flinkbot commented on pull request #20429: [FLINK-28701][runtime] Minimize the explosion range during failover for hybrid shuffle

2022-08-02 Thread GitBox
flinkbot commented on PR #20429: URL: https://github.com/apache/flink/pull/20429#issuecomment-1203433349 ## CI report: * 60b8ecee4cd67c440fae57844e15e0a4454354b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] pltbkd commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-02 Thread GitBox
pltbkd commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r936196209 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/dynamicfiltering/DynamicFilteringDataCollectorOperator.java: ## @@ -0,0 +1,180 @

[GitHub] [flink] pltbkd commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-02 Thread GitBox
pltbkd commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r936194502 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/DynamicFilteringData.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] pltbkd commented on a diff in pull request #20374: [FLINK-28709] Implement dynamic filtering operators

2022-08-02 Thread GitBox
pltbkd commented on code in PR #20374: URL: https://github.com/apache/flink/pull/20374#discussion_r936194342 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/DynamicFilteringData.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936192015 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/handler/session/TriggerSessionHeartbeatHandler.java: ## @@ -0,0 +1,70 @@ +/* + * Li

[jira] [Updated] (FLINK-28429) Reduce pyflink tests time

2022-08-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-28429: - Priority: Major (was: Critical) > Reduce pyflink tests time > - > >

[jira] [Updated] (FLINK-28701) Minimize the explosion range during failover for hybrid shuffle

2022-08-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28701: --- Labels: pull-request-available (was: ) > Minimize the explosion range during failover for h

[GitHub] [flink] reswqa opened a new pull request, #20429: [FLINK-28701][runtime] Minimize the explosion range during failover for hybrid shuffle

2022-08-02 Thread GitBox
reswqa opened a new pull request, #20429: URL: https://github.com/apache/flink/pull/20429 ## What is the purpose of the change *In hybrid shuffle mode, there are currently two strategies to control spilling. For the full spilling strategy, the data is guaranteed to be persistent to t

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936188945 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/session/TriggerSessionHeartbeatHeaders.java: ## @@ -0,0 +1,79 @@ +/* + * Lic

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936188761 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/session/CloseSessionHeaders.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to th

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936188564 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/handler/session/OpenSessionHandler.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to th

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20350: [FLINK-28663][runtime] Allow multiple downstream consumer job vertices sharing the same intermediate dataset at scheduler side

2022-08-02 Thread GitBox
TanYuxin-tyx commented on code in PR #20350: URL: https://github.com/apache/flink/pull/20350#discussion_r936187326 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java: ## @@ -73,7 +75,7 @@ public class JobVertex implements java.io.Serializable {

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20351: [FLINK-28380][runtime] Produce one intermediate dataset for multiple consumer job vertices consuming the same data

2022-08-02 Thread GitBox
TanYuxin-tyx commented on code in PR #20351: URL: https://github.com/apache/flink/pull/20351#discussion_r936177240 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java: ## @@ -73,7 +75,7 @@ public class JobVertex implements java.io.Serializable {

[jira] [Closed] (FLINK-28771) Assign speculative execution attempt with correct CREATED timestamp

2022-08-02 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-28771. --- Resolution: Fixed Fixed via e1a74df4427e99f4b0f3aaa4e8f4f5ff7cbd044e > Assign speculative execution attempt

[GitHub] [flink] pltbkd commented on pull request #20415: [FLINK-28711] Hive connector implements SupportsDynamicFiltering interface

2022-08-02 Thread GitBox
pltbkd commented on PR #20415: URL: https://github.com/apache/flink/pull/20415#issuecomment-1203419700 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] zhuzhurk closed pull request #20411: [FLINK-28771][runtime] Assign speculative execution attempt with correct CREATED timestamp

2022-08-02 Thread GitBox
zhuzhurk closed pull request #20411: [FLINK-28771][runtime] Assign speculative execution attempt with correct CREATED timestamp URL: https://github.com/apache/flink/pull/20411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20351: [FLINK-28380][runtime] Produce one intermediate dataset for multiple consumer job vertices consuming the same data

2022-08-02 Thread GitBox
TanYuxin-tyx commented on code in PR #20351: URL: https://github.com/apache/flink/pull/20351#discussion_r936177240 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java: ## @@ -73,7 +75,7 @@ public class JobVertex implements java.io.Serializable {

[GitHub] [flink] flinkbot commented on pull request #20428: [FLINK-28782][python][connector/filesystem] Support FileSink compaction

2022-08-02 Thread GitBox
flinkbot commented on PR #20428: URL: https://github.com/apache/flink/pull/20428#issuecomment-1203418726 ## CI report: * 4c993ddfc4076d35437e39fb6a11755cd1013736 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936183769 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/message/session/OpenSessionRequestBody.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed t

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936183621 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/session/OpenSessionHeaders.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-28529) ChangelogPeriodicMaterializationSwitchStateBackendITCase.testSwitchFromDisablingToEnablingInClaimMode failed with CheckpointException: Checkpoint expired before completi

2022-08-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-28529: - Fix Version/s: 1.16.0 > ChangelogPeriodicMaterializationSwitchStateBackendITCase.testSwitchFromD

[GitHub] [flink] WencongLiu commented on a diff in pull request #20418: [FLINK-28161][sql-gateway]Introduce the session related API for REST endpoint

2022-08-02 Thread GitBox
WencongLiu commented on code in PR #20418: URL: https://github.com/apache/flink/pull/20418#discussion_r936182278 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/handler/session/OpenSessionHandler.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to th

[GitHub] [flink] zhuzhurk commented on pull request #20411: [FLINK-28771][runtime] Assign speculative execution attempt with correct CREATED timestamp

2022-08-02 Thread GitBox
zhuzhurk commented on PR #20411: URL: https://github.com/apache/flink/pull/20411#issuecomment-1203414563 Thanks for reviewing! @wanglijie95 Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot commented on pull request #20427: [FLINK-28783] [flink-core] Class ConfigOptions's example code have error.

2022-08-02 Thread GitBox
flinkbot commented on PR #20427: URL: https://github.com/apache/flink/pull/20427#issuecomment-1203413662 ## CI report: * f622ca2c58a49bfd68ee0adc9a52e9ee20c72583 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28627) KafkaITCase.testBrokerFailure failed with TestTimedOutException: test timed out after 60000 milliseconds

2022-08-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-28627: - Fix Version/s: 1.16.0 > KafkaITCase.testBrokerFailure failed with TestTimedOutException: test ti

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-08-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-28440: - Fix Version/s: 1.16.0 > EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with res

[GitHub] [flink] hehuiyuan commented on pull request #20425: [FLINK-28750][Hive]Add field comment parse for hive ddl

2022-08-02 Thread GitBox
hehuiyuan commented on PR #20425: URL: https://github.com/apache/flink/pull/20425#issuecomment-1203413188 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] fredia commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-02 Thread GitBox
fredia commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r936181068 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingOutputStreamWithPos.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (FLINK-28766) UnalignedCheckpointStressITCase.runStressTest failed with NoSuchFileException

2022-08-02 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-28766: - Fix Version/s: 1.16.0 > UnalignedCheckpointStressITCase.runStressTest failed with NoSuchFileExce

[jira] [Updated] (FLINK-28782) Support FileSink compaction in PyFlink

2022-08-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28782: --- Labels: pull-request-available (was: ) > Support FileSink compaction in PyFlink > -

[GitHub] [flink] Vancior opened a new pull request, #20428: [FLINK-28782][python][connector/filesystem] Support FileSink compaction

2022-08-02 Thread GitBox
Vancior opened a new pull request, #20428: URL: https://github.com/apache/flink/pull/20428 ## What is the purpose of the change This PR supports using several convenient compactors in FileSink in PyFlink. ## Verifying this change This change added tests and can be ver

[GitHub] [flink] reswqa commented on pull request #20333: [FLINK-28623][network] Optimize the use of off heap memory by blocking and hybrid shuffle reader

2022-08-02 Thread GitBox
reswqa commented on PR #20333: URL: https://github.com/apache/flink/pull/20333#issuecomment-1203410969 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] GOODBOY008 commented on pull request #20427: [FLINK-28783] [flink-core] Class ConfigOptions's example code have error.

2022-08-02 Thread GitBox
GOODBOY008 commented on PR #20427: URL: https://github.com/apache/flink/pull/20427#issuecomment-1203410695 @PatrickRen Please cc, if you are avalible.Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [flink] fredia commented on pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-08-02 Thread GitBox
fredia commented on PR #20217: URL: https://github.com/apache/flink/pull/20217#issuecomment-1203410468 Hi @rkhachatryan, I updated this PR to handle "the last checkpoint(s) aborted and then job terminated" case, and added `LocalStateRegistryTest`. Could you please take a look again? -- T

[jira] [Updated] (FLINK-28783) Class ConfigOptions's example code have error.

2022-08-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28783: --- Labels: pull-request-available (was: ) > Class ConfigOptions's example code have error. > -

[GitHub] [flink] GOODBOY008 opened a new pull request, #20427: [FLINK-28783] [flink-core] Class ConfigOptions's example code have error.

2022-08-02 Thread GitBox
GOODBOY008 opened a new pull request, #20427: URL: https://github.com/apache/flink/pull/20427 ## What is the purpose of the change https://issues.apache.org/jira/browse/FLINK-28783 ## Does this pull request potentially affect one of the following parts:

[jira] [Resolved] (FLINK-28417) Add interface and default implementation for cache in lookup table

2022-08-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-28417. --- Fix Version/s: 1.16.0 Resolution: Implemented > Add interface and default implementat

[jira] [Commented] (FLINK-28417) Add interface and default implementation for cache in lookup table

2022-08-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574450#comment-17574450 ] Qingsheng Ren commented on FLINK-28417: --- Merged to master: ed8870e602d2ee91e57dec5

[jira] [Created] (FLINK-28783) Class ConfigOptions's example code have error.

2022-08-02 Thread Aiden Gong (Jira)
Aiden Gong created FLINK-28783: -- Summary: Class ConfigOptions's example code have error. Key: FLINK-28783 URL: https://issues.apache.org/jira/browse/FLINK-28783 Project: Flink Issue Type: Bug

  1   2   3   >