[GitHub] [flink-ml] weibozhao commented on a diff in pull request #133: [FLINK-28601] Support FeatureHasher in FlinkML

2022-07-20 Thread GitBox
weibozhao commented on code in PR #133: URL: https://github.com/apache/flink-ml/pull/133#discussion_r926319801 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/featurehasher/FeatureHasherParams.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #133: [FLINK-28601] Support FeatureHasher in FlinkML

2022-07-20 Thread GitBox
weibozhao commented on code in PR #133: URL: https://github.com/apache/flink-ml/pull/133#discussion_r926317019 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/featurehasher/FeatureHasherParams.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] TanYuxin-tyx commented on pull request #20320: [FLINK-28519][network] Fix the bug that SortMergeResultPartitionReadScheduler may not read data sequentially

2022-07-20 Thread GitBox
TanYuxin-tyx commented on PR #20320: URL: https://github.com/apache/flink/pull/20320#issuecomment-1191110379 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20320: [FLINK-28519][network] Fix the bug that SortMergeResultPartitionReadScheduler may not read data sequentially

2022-07-20 Thread GitBox
TanYuxin-tyx commented on code in PR #20320: URL: https://github.com/apache/flink/pull/20320#discussion_r926313613 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartitionReadScheduler.java: ## @@ -152,12 +160,34 @@ class SortMergeRes

[GitHub] [flink] WencongLiu commented on pull request #20236: [FLINK-27769][sql-gateway]Introduce the REST endpoint framework

2022-07-20 Thread GitBox
WencongLiu commented on PR #20236: URL: https://github.com/apache/flink/pull/20236#issuecomment-1191108352 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #20320: [FLINK-28519][network] Fix the bug that SortMergeResultPartitionReadScheduler may not read data sequentially

2022-07-20 Thread GitBox
TanYuxin-tyx commented on code in PR #20320: URL: https://github.com/apache/flink/pull/20320#discussion_r926310001 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartitionReadScheduler.java: ## @@ -283,13 +284,26 @@ private void mayNo

[GitHub] [flink] fsk119 commented on a diff in pull request #19894: [FLINK-27931][sql-gateway] Introduce the SqlGateway to assemble all components

2022-07-20 Thread GitBox
fsk119 commented on code in PR #19894: URL: https://github.com/apache/flink/pull/19894#discussion_r926308243 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/SqlGateway.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [flink] TanYuxin-tyx commented on pull request #20315: [FLINK-28512][network] Select HashBasedDataBuffer and SortBasedDataBuffer dynamically based on the number of network buffers that can be

2022-07-20 Thread GitBox
TanYuxin-tyx commented on PR #20315: URL: https://github.com/apache/flink/pull/20315#issuecomment-1191100957 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] fredia commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
fredia commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r926305448 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java: ## @@ -464,7 +452,7 @@ private void pruneCheckpoints(LongPredicate pruningChec

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema

2022-07-20 Thread GitBox
ruanhang1993 commented on code in PR #20164: URL: https://github.com/apache/flink/pull/20164#discussion_r926303607 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchema.java: ## @@ -48,6 +48,12 @@ default voi

[GitHub] [flink] swuferhong commented on pull request #20303: [FLINK-28599][table-planner] Adding FlinkJoinToMultiJoinRule to support translating left/right outer join to multi join

2022-07-20 Thread GitBox
swuferhong commented on PR #20303: URL: https://github.com/apache/flink/pull/20303#issuecomment-1191090191 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink-ml] weibozhao opened a new pull request, #135: Support ElementwiseProduct in FlinkML

2022-07-20 Thread GitBox
weibozhao opened a new pull request, #135: URL: https://github.com/apache/flink-ml/pull/135 #What is the purpose of the change Add Transformer for ElementwiseProduct in Flink ML. #Brief change log Add Transformer for ElementwiseProduct in Flink ML (Java & Python). Add unit tes

[jira] [Updated] (FLINK-28619) flink sql window aggregation using early fire will produce empty data

2022-07-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28619: --- Fix Version/s: (was: 1.15.2) > flink sql window aggregation using early fire will produc

[GitHub] [flink] fredia commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
fredia commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r926288182 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Commented] (FLINK-28502) Add Transformer for RegexTokenizer

2022-07-20 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569280#comment-17569280 ] Zhipeng Zhang commented on FLINK-28502: --- fixed via f9f802125d604f0155221804237fd41

[GitHub] [flink] flinkbot commented on pull request #20323: [FLINK-26944][Table SQL/API] Add ADD_MONTHS supported in SQL and Table API

2022-07-20 Thread GitBox
flinkbot commented on PR #20323: URL: https://github.com/apache/flink/pull/20323#issuecomment-1191075553 ## CI report: * bed854175ec29e5b9144d1ace66738a53e6d294e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Sxnan commented on pull request #20147: [FLINK-27524][datastream] Introduce cache API to DataStream

2022-07-20 Thread GitBox
Sxnan commented on PR #20147: URL: https://github.com/apache/flink/pull/20147#issuecomment-1191070807 Hi @gaoyunhaii! Thanks for your review! I made changes according to your comments. Could you please take another look? -- This is an automated message from the Apache Git Service. To resp

[jira] [Updated] (FLINK-26944) Add ADD_MONTHS supported in SQL and Table API

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26944: --- Labels: pull-request-available (was: ) > Add ADD_MONTHS supported in SQL and Table API > --

[GitHub] [flink] zzzzzzzs opened a new pull request, #20323: [FLINK-26944][Table SQL/API] Add ADD_MONTHS supported in SQL and Table API

2022-07-20 Thread GitBox
zzzs opened a new pull request, #20323: URL: https://github.com/apache/flink/pull/20323 ## What is the purpose of the change Add add_months(startDate, numMonths) SQL function. Examples: ```sql > SELECT add_months('2016-08-31', 1); 2016-09-30 > SELECT add

[GitHub] [flink] TanYuxin-tyx commented on pull request #20315: [FLINK-28512][network] Select HashBasedDataBuffer and SortBasedDataBuffer dynamically based on the number of network buffers that can be

2022-07-20 Thread GitBox
TanYuxin-tyx commented on PR #20315: URL: https://github.com/apache/flink/pull/20315#issuecomment-1191057362 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926266725 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -308,6 +335,26 @@ private void checkpointCoo

[GitHub] [flink] dongjoon-hyun commented on pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-20 Thread GitBox
dongjoon-hyun commented on PR #19844: URL: https://github.com/apache/flink/pull/19844#issuecomment-1191056678 Could you review this when you have some time, @mbalassi and @gyfora ? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [flink] dongjoon-hyun commented on pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-20 Thread GitBox
dongjoon-hyun commented on PR #19844: URL: https://github.com/apache/flink/pull/19844#issuecomment-1191055489 For a record, to reviewers, ORC-1198 is already shipped via Apache ORC 1.7.5 and included in this PR. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [flink] Tartarus0zm commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-20 Thread GitBox
Tartarus0zm commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r926251262 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [flink] TanYuxin-tyx commented on pull request #20315: [FLINK-28512][network] Select HashBasedDataBuffer and SortBasedDataBuffer dynamically based on the number of network buffers that can be

2022-07-20 Thread GitBox
TanYuxin-tyx commented on PR #20315: URL: https://github.com/apache/flink/pull/20315#issuecomment-1191030734 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] TanYuxin-tyx commented on pull request #20315: [FLINK-28512][network] Select HashBasedDataBuffer and SortBasedDataBuffer dynamically based on the number of network buffers that can be

2022-07-20 Thread GitBox
TanYuxin-tyx commented on PR #20315: URL: https://github.com/apache/flink/pull/20315#issuecomment-1191023869 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] fredia commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
fredia commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r926233838 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Resolved] (FLINK-28514) Remove data flush in SortMergeResultPartition

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao resolved FLINK-28514. - Resolution: Fixed Merged into master via 9a141441cb96837d92c4bd348b4c05617100e14b > Remove data

[jira] [Comment Edited] (FLINK-28619) flink sql window aggregation using early fire will produce empty data

2022-07-20 Thread zhouli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569257#comment-17569257 ] zhouli edited comment on FLINK-28619 at 7/21/22 3:56 AM: - when u

[jira] [Commented] (FLINK-28619) flink sql window aggregation using early fire will produce empty data

2022-07-20 Thread zhouli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569257#comment-17569257 ] zhouli commented on FLINK-28619: when using upsert-kafka as a sink, it  will write DELET

[GitHub] [flink] wsry merged pull request #20294: [FLINK-28514][network] Remove data flush in SortMergeResultPartition

2022-07-20 Thread GitBox
wsry merged PR #20294: URL: https://github.com/apache/flink/pull/20294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.o

[GitHub] [flink] wsry commented on pull request #20294: [FLINK-28514][network] Remove data flush in SortMergeResultPartition

2022-07-20 Thread GitBox
wsry commented on PR #20294: URL: https://github.com/apache/flink/pull/20294#issuecomment-1191009568 @TanYuxin-tyx Thanks for the change. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #131: [FLINK-28563] Add Transformer for VectorSlicer

2022-07-20 Thread GitBox
zhipeng93 commented on code in PR #131: URL: https://github.com/apache/flink-ml/pull/131#discussion_r926208138 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/vectorslicer/VectorSlicer.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (FLINK-28619) flink sql window aggregation using early fire will produce empty data

2022-07-20 Thread simenliuxing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569256#comment-17569256 ] simenliuxing commented on FLINK-28619: -- [~Zsigner] [~Leo Zhou] [~jark] can you take

[jira] [Updated] (FLINK-28151) Introduce the operation-related API for HiveServer2 Endpoint

2022-07-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-28151: -- Summary: Introduce the operation-related API for HiveServer2 Endpoint (was: Introduce the ses

[jira] [Updated] (FLINK-28151) Allow to cancel the Operation for the HiveServer2 Endpoint

2022-07-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-28151: -- Description: (was: Allow to cancel the ope) > Allow to cancel the Operation for the HiveSe

[jira] [Updated] (FLINK-28151) Introduce the operation-related API for HiveServer2 Endpoint

2022-07-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-28151: -- Description: Allow to cancel the ope (was: Allow to open/close/configure the session using th

[jira] [Updated] (FLINK-28151) Allow to cancel the Operation for the HiveServer2 Endpoint

2022-07-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-28151: -- Summary: Allow to cancel the Operation for the HiveServer2 Endpoint (was: Introduce the opera

[jira] [Assigned] (FLINK-28519) Fix the bug that SortMergeResultPartitionReadScheduler may not read data sequentially

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-28519: --- Assignee: Yuxin Tan > Fix the bug that SortMergeResultPartitionReadScheduler may not read d

[jira] [Created] (FLINK-28619) flink sql window aggregation using early fire will produce empty data

2022-07-20 Thread simenliuxing (Jira)
simenliuxing created FLINK-28619: Summary: flink sql window aggregation using early fire will produce empty data Key: FLINK-28619 URL: https://issues.apache.org/jira/browse/FLINK-28619 Project: Flink

[jira] [Closed] (FLINK-28565) Create NOTICE file for flink-table-store-hive-catalog

2022-07-20 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-28565. Fix Version/s: table-store-0.3.0 Resolution: Fixed master: d169a125c97180bf1c6f4ac47a4b66ae

[jira] [Assigned] (FLINK-28376) Restrict the number of threads for sort-shuffle data read

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-28376: --- Assignee: Yuxin Tan > Restrict the number of threads for sort-shuffle data read > -

[jira] [Resolved] (FLINK-28376) Restrict the number of threads for sort-shuffle data read

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao resolved FLINK-28376. - Resolution: Fixed Merged into master via 2f76a30569332728def4df0c316ee1a4f3409aa9 > Restrict th

[GitHub] [flink-table-store] JingsongLi merged pull request #220: [FLINK-28565] Create `NOTICE` file for `flink-table-store-hive-catalog`

2022-07-20 Thread GitBox
JingsongLi merged PR #220: URL: https://github.com/apache/flink-table-store/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [flink] wsry merged pull request #20308: [FLINK-28376][network] Restrict the number of threads for sort-shuffle data read

2022-07-20 Thread GitBox
wsry merged PR #20308: URL: https://github.com/apache/flink/pull/20308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.o

[GitHub] [flink] wsry commented on pull request #20308: [FLINK-28376][network] Restrict the number of threads for sort-shuffle data read

2022-07-20 Thread GitBox
wsry commented on PR #20308: URL: https://github.com/apache/flink/pull/20308#issuecomment-1190994642 @TanYuxin-tyx Thanks for the change. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (FLINK-28152) Introduce the statement-related API for HiveServer2 Endpoint

2022-07-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-28152: - Assignee: Shengkai Fang > Introduce the statement-related API for HiveServer2 Endpoint

[jira] [Assigned] (FLINK-28514) Remove data flush in SortMergeResultPartition

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-28514: --- Assignee: Yuxin Tan > Remove data flush in SortMergeResultPartition > -

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926212897 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CloseableSubtaskGateway.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-28618) Cannot use hive.dialect on master

2022-07-20 Thread liubo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubo updated FLINK-28618: -- Description: I build the newest master flink and copy \{hive-exec-2.3.9.jar;flink-sql-connector-hive-2.3.9_2.

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926212561 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorEventDispatcherImpl.java: ## @@ -82,6 +83,10 @@ public void registerEventH

[jira] [Created] (FLINK-28618) Cannot use hive.dialect on master

2022-07-20 Thread liubo (Jira)
liubo created FLINK-28618: - Summary: Cannot use hive.dialect on master Key: FLINK-28618 URL: https://issues.apache.org/jira/browse/FLINK-28618 Project: Flink Issue Type: Bug Components: Co

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926212101 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -277,29 +300,33 @@ private void checkpointCo

[GitHub] [flink] wsry commented on pull request #20294: [FLINK-28514][network] Remove data flush in SortMergeResultPartition

2022-07-20 Thread GitBox
wsry commented on PR #20294: URL: https://github.com/apache/flink/pull/20294#issuecomment-1190986105 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926211762 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -277,29 +300,33 @@ private void checkpointCo

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926211546 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CloseableSubtaskGateway.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926210901 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -236,7 +240,20 @@ public void notifyCheckpoi

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926210804 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CloseableSubtaskGateway.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926210207 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CloseableSubtaskGateway.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (FLINK-28550) Remove the unused field in SortMergeSubpartitionReader

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao resolved FLINK-28550. - Resolution: Fixed Merged into master via 5923c510f24269a83e9886f96f62571602c448e7 > Remove the

[jira] [Updated] (FLINK-28547) Add IT cases for SpeculativeScheduler

2022-07-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-28547: Component/s: Tests > Add IT cases for SpeculativeScheduler > - > >

[jira] [Closed] (FLINK-28547) Add IT cases for SpeculativeScheduler

2022-07-20 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-28547. --- Resolution: Done Done via fd763672b858e74b24760e5c98ff9af22caa8a14 > Add IT cases for SpeculativeScheduler

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #20275: [FLINK-26029][Runtime/Checkpointing] Generalize the checkpoint protocol of OperatorCoordinator

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r926209447 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/CloseableSubtaskGateway.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [flink] zhuzhurk closed pull request #20271: [FLINK-28547][runtime] Add IT cases for SpeculativeScheduler.

2022-07-20 Thread GitBox
zhuzhurk closed pull request #20271: [FLINK-28547][runtime] Add IT cases for SpeculativeScheduler. URL: https://github.com/apache/flink/pull/20271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] wsry merged pull request #20295: [FLINK-28550][network] Remove the unused field in SortMergeSubpartitionReader

2022-07-20 Thread GitBox
wsry merged PR #20295: URL: https://github.com/apache/flink/pull/20295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.o

[jira] [Closed] (FLINK-28446) Expose more information in PartitionDescriptor to support more optimized Shuffle Service

2022-07-20 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan closed FLINK-28446. - > Expose more information in PartitionDescriptor to support more optimized > Shuffle Service >

[GitHub] [flink] wsry commented on pull request #20295: [FLINK-28550][network] Remove the unused field in SortMergeSubpartitionReader

2022-07-20 Thread GitBox
wsry commented on PR #20295: URL: https://github.com/apache/flink/pull/20295#issuecomment-1190979018 @TanYuxin-tyx Thanks for the change. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (FLINK-28446) Expose more information in PartitionDescriptor to support more optimized Shuffle Service

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao resolved FLINK-28446. - Resolution: Fixed Merged into master via e630778eb8b500148b01583d34ec195a80c99c3f > Expose more

[GitHub] [flink] Myracle commented on pull request #20319: [hotfix][API/Core] Modify spelling error in SplitEnumerator's annotation

2022-07-20 Thread GitBox
Myracle commented on PR #20319: URL: https://github.com/apache/flink/pull/20319#issuecomment-1190977997 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-24434) PyFlink YARN per-job on Docker test fails on Azure

2022-07-20 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569247#comment-17569247 ] Huang Xingbo commented on FLINK-24434: -- {code:java} 2022-07-20T13:36:55.8006262Z C

[jira] [Updated] (FLINK-28177) Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPrimaryKey failed with 503 Service Unavailable

2022-07-20 Thread KurtDing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KurtDing updated FLINK-28177: - Attachment: image-2022-07-21-10-48-33-213.png > Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPr

[jira] [Commented] (FLINK-28177) Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPrimaryKey failed with 503 Service Unavailable

2022-07-20 Thread KurtDing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569244#comment-17569244 ] KurtDing commented on FLINK-28177: -- I think this is because of the connection loss of e

[jira] [Assigned] (FLINK-28550) Remove the unused field in SortMergeSubpartitionReader

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-28550: --- Assignee: Yuxin Tan > Remove the unused field in SortMergeSubpartitionReader >

[jira] [Commented] (FLINK-28177) Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPrimaryKey failed with 503 Service Unavailable

2022-07-20 Thread KurtDing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569245#comment-17569245 ] KurtDing commented on FLINK-28177: -- !image-2022-07-21-10-48-33-213.png! > Elasticsearc

[GitHub] [flink] link3280 commented on pull request #20159: [FLINK-28360][SQL Client] Support stop job statement in SQL client

2022-07-20 Thread GitBox
link3280 commented on PR #20159: URL: https://github.com/apache/flink/pull/20159#issuecomment-1190976770 New ticket https://issues.apache.org/jira/browse/FLINK-28617. I'll open tickets/PRs for the gateway separately for the rest statements. -- This is an automated message from the

[GitHub] [flink] jjiey commented on pull request #20316: [FLINK-27292][docs-zh] Translate the "Data Type Extraction" section of "Data Types" to Chinese

2022-07-20 Thread GitBox
jjiey commented on PR #20316: URL: https://github.com/apache/flink/pull/20316#issuecomment-1190976473 > @jjiey could you a add picture of the part you translate? Just like [#19496 (comment)](https://github.com/apache/flink/pull/19496#issuecomment-1115132533) @ChengkaiYang2022 fine. h

[jira] [Created] (FLINK-28617) Support stop job statement in SqlGatewayService

2022-07-20 Thread Paul Lin (Jira)
Paul Lin created FLINK-28617: Summary: Support stop job statement in SqlGatewayService Key: FLINK-28617 URL: https://issues.apache.org/jira/browse/FLINK-28617 Project: Flink Issue Type: Sub-task

[GitHub] [flink] luoyuxia commented on pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-20 Thread GitBox
luoyuxia commented on PR #20211: URL: https://github.com/apache/flink/pull/20211#issuecomment-1190972490 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-28530) Improvement of extraction of conditions that can be pushed into join inputs

2022-07-20 Thread Alexander Trushev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569238#comment-17569238 ] Alexander Trushev commented on FLINK-28530: --- Please assign this ticket to me

[GitHub] [flink] fredia commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
fredia commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r92622 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskLocalStateStoreImpl.java: ## @@ -409,39 +405,31 @@ private void discardLocalStateForCheckpoint(long che

[GitHub] [flink] fsk119 commented on pull request #20159: [FLINK-28360][SQL Client] Support stop job statement in SQL client

2022-07-20 Thread GitBox
fsk119 commented on PR #20159: URL: https://github.com/apache/flink/pull/20159#issuecomment-1190968837 > > Thanks for your contribution. Currently the `SqlGatewayService` already supported executeSql, could you also support this feature in the SQL Gateway? > > @fsk119 `SqlGatewayServi

[jira] [Updated] (FLINK-24434) PyFlink YARN per-job on Docker test fails on Azure

2022-07-20 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-24434: - Affects Version/s: 1.16.0 > PyFlink YARN per-job on Docker test fails on Azure > ---

[GitHub] [flink] Sxnan commented on a diff in pull request #20147: [FLINK-27524][datastream] Introduce cache API to DataStream

2022-07-20 Thread GitBox
Sxnan commented on code in PR #20147: URL: https://github.com/apache/flink/pull/20147#discussion_r926192780 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -2203,13 +2199,21 @@ public StreamGraph getStreamGr

[jira] [Assigned] (FLINK-24434) PyFlink YARN per-job on Docker test fails on Azure

2022-07-20 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo reassigned FLINK-24434: Assignee: Huang Xingbo > PyFlink YARN per-job on Docker test fails on Azure > ---

[jira] [Updated] (FLINK-24434) PyFlink YARN per-job on Docker test fails on Azure

2022-07-20 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-24434: - Priority: Critical (was: Major) > PyFlink YARN per-job on Docker test fails on Azure >

[GitHub] [flink] link3280 commented on pull request #20159: [FLINK-28360][SQL Client] Support stop job statement in SQL client

2022-07-20 Thread GitBox
link3280 commented on PR #20159: URL: https://github.com/apache/flink/pull/20159#issuecomment-1190954677 > Thanks for your contribution. Currently the `SqlGatewayService` already supported executeSql, could you also support this feature in the SQL Gateway? @fsk119 `SqlGatewayService`

[jira] [Commented] (FLINK-24434) PyFlink YARN per-job on Docker test fails on Azure

2022-07-20 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569232#comment-17569232 ] Huang Xingbo commented on FLINK-24434: -- https://dev.azure.com/apache-flink/apache-f

[jira] [Commented] (FLINK-24434) PyFlink YARN per-job on Docker test fails on Azure

2022-07-20 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569231#comment-17569231 ] Huang Xingbo commented on FLINK-24434: -- https://dev.azure.com/apache-flink/apache-f

[GitHub] [flink] zzzzzzzs commented on pull request #20310: [FLINK-26949][Table SQL/API] Add NVL supported in SQL & Table API

2022-07-20 Thread GitBox
zzzs commented on PR #20310: URL: https://github.com/apache/flink/pull/20310#issuecomment-1190951809 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-27691) RankHarnessTest. testUpdateRankWithRowNumberSortKeyDropsToNotLast test failed with result mismatch

2022-07-20 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569228#comment-17569228 ] Yingjie Cao commented on FLINK-27691: - [https://dev.azure.com/kevin-flink/flink/_bui

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #133: [FLINK-28601] Support FeatureHasher in FlinkML

2022-07-20 Thread GitBox
yunfengzhou-hub commented on code in PR #133: URL: https://github.com/apache/flink-ml/pull/133#discussion_r926165477 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/featurehasher/FeatureHasherParams.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-26949) Add NVL supported in SQL & Table API

2022-07-20 Thread zhaoshuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569219#comment-17569219 ] zhaoshuo commented on FLINK-26949: -- [~lsy] I've made a pull request. Please take a revi

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-07-20 Thread GitBox
rkhachatryan commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r926152251 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendLocalHandle.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
rkhachatryan commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r926149940 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-07-20 Thread GitBox
rkhachatryan commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r926143658 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -329,14 +343,28 @@ public void confirm(SequenceNumber fr

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20217: [FLINK-27693][state] Support local recovery for non-materialized part

2022-07-20 Thread GitBox
rkhachatryan commented on code in PR #20217: URL: https://github.com/apache/flink/pull/20217#discussion_r926143502 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingOutputStreamWithPos.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] wanglijie95 commented on pull request #20218: [FLINK-28145][runtime] Let ResourceManager supports blocklist

2022-07-20 Thread GitBox
wanglijie95 commented on PR #20218: URL: https://github.com/apache/flink/pull/20218#issuecomment-1190888225 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
rkhachatryan commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r926126113 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
rkhachatryan commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r926125810 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-20 Thread GitBox
rkhachatryan commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r926124747 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Founda

  1   2   3   4   >