[GitHub] [flink] flinkbot edited a comment on pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17842: URL: https://github.com/apache/flink/pull/17842#issuecomment-974310249 ## CI report: * 007d765a862fc6c288d08516cc06640f4e6e85ea Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-13550) Support for CPU FlameGraphs in web UI

2021-11-22 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-13550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447820#comment-17447820 ] David Morávek commented on FLINK-13550: --- [~jackylau] that's the line number. It's

[GitHub] [flink] flinkbot edited a comment on pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17842: URL: https://github.com/apache/flink/pull/17842#issuecomment-974310249 ## CI report: * 007d765a862fc6c288d08516cc06640f4e6e85ea Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17822: Release 1.14 kafka3.0 bug

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17822: URL: https://github.com/apache/flink/pull/17822#issuecomment-971696959 ## CI report: * 4315c1be1f94367058c85be82e89d1bd623c63a7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17875: [BP-1.14][FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17875: URL: https://github.com/apache/flink/pull/17875#issuecomment-976151167 ## CI report: * 3c8b9142f5707820507d61fc71784f7ed4bc07f1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17811: [FLINK-24754] Implement CHAR/VARCHAR length validation for sinks

2021-11-22 Thread GitBox
slinkydeveloper commented on a change in pull request #17811: URL: https://github.com/apache/flink/pull/17811#discussion_r754861749 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sink/ConstraintEnforcer.java ## @@ -188,14 +

[GitHub] [flink] flinkbot edited a comment on pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17670: URL: https://github.com/apache/flink/pull/17670#issuecomment-960539433 ## CI report: * 9f14fb2c282614088363960f23af3d6c5770ff15 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17876: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17876: URL: https://github.com/apache/flink/pull/17876#issuecomment-976152397 ## CI report: * 9b4fa70d5e2f6a31bbb7ad1b84fb8334ac24a46d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17842: URL: https://github.com/apache/flink/pull/17842#issuecomment-974310249 ## CI report: * 007d765a862fc6c288d08516cc06640f4e6e85ea Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17842: URL: https://github.com/apache/flink/pull/17842#issuecomment-974310249 ## CI report: * c847ce6f383ebe2588f1ca020b0865ba226d1dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] YesOrNo828 commented on a change in pull request #17831: [FLINK-15825][Table SQL/API] Add renameDatabase() to Catalog

2021-11-22 Thread GitBox
YesOrNo828 commented on a change in pull request #17831: URL: https://github.com/apache/flink/pull/17831#discussion_r754853810 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java ## @@ -398,6 +398,34 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17842: URL: https://github.com/apache/flink/pull/17842#issuecomment-974310249 ## CI report: * c847ce6f383ebe2588f1ca020b0865ba226d1dd5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17792: [FLINK-24763][fs-connector] LimitableReader should swallow exception when reached limit

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17792: URL: https://github.com/apache/flink/pull/17792#issuecomment-968524862 ## CI report: * eca2f327e5f0f82afd0ae6e89ce04545b7d1cab4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] gmzz123 edited a comment on pull request #17843: [FLINK-24879][core] All ReducingStateDescriptor constructor should check reduceFunction is not a richFunction.

2021-11-22 Thread GitBox
gmzz123 edited a comment on pull request #17843: URL: https://github.com/apache/flink/pull/17843#issuecomment-976213242 @azagrebin @StephanEwen could you help to review it? thanks! And I have create [FLINK-24994](https://issues.apache.org/jira/projects/FLINK/issues/FLINK-24994) also

[GitHub] [flink] gmzz123 commented on pull request #17843: [FLINK-24879][core] All ReducingStateDescriptor constructor should check reduceFunction is not a richFunction.

2021-11-22 Thread GitBox
gmzz123 commented on pull request #17843: URL: https://github.com/apache/flink/pull/17843#issuecomment-976213242 @azagrebin @Stephan Ewen could you help to review it? thanks! And I have create [FLINK-24994](https://issues.apache.org/jira/projects/FLINK/issues/FLINK-24994) also about

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 2aa66ef4a13a091a4c6c1b5638e9ed557ab1cf6b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 2aa66ef4a13a091a4c6c1b5638e9ed557ab1cf6b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] gmzz123 commented on pull request #17838: [FLINK-24915] [DataStream] fix StreamElementSerializer#deserialize(reuse, source) forgets to handle tag == TAG_STREAM_STATUS.

2021-11-22 Thread GitBox
gmzz123 commented on pull request #17838: URL: https://github.com/apache/flink/pull/17838#issuecomment-976209663 @AHeise Could you help review it? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * 2aa66ef4a13a091a4c6c1b5638e9ed557ab1cf6b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] lindong28 commented on a change in pull request #28: [Flink-24556] Add Estimator and Transformer for logistic regression

2021-11-22 Thread GitBox
lindong28 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r754839066 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasL2.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] lindong28 commented on a change in pull request #28: [Flink-24556] Add Estimator and Transformer for logistic regression

2021-11-22 Thread GitBox
lindong28 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r754833974 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/linear/HasPredictionDetailCol.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the A

[GitHub] [flink-ml] zhipeng93 commented on a change in pull request #28: [Flink-24556] Add Estimator and Transformer for logistic regression

2021-11-22 Thread GitBox
zhipeng93 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r754834016 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/linear/LogisticRegressionModel.java ## @@ -0,0 +1,220 @@ +/* + * Licensed to t

[GitHub] [flink] flinkbot commented on pull request #17877: [FLINK-24495][python][tests] Upgrade virtualenv version

2021-11-22 Thread GitBox
flinkbot commented on pull request #17877: URL: https://github.com/apache/flink/pull/17877#issuecomment-976201704 ## CI report: * 78eee6205acd3e09c5ba404c4880dd9aee9c813a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17877: [FLINK-24495][python][tests] Upgrade virtualenv version

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17877: URL: https://github.com/apache/flink/pull/17877#issuecomment-976201704 ## CI report: * 78eee6205acd3e09c5ba404c4880dd9aee9c813a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17877: [FLINK-24495][python][tests] Upgrade virtualenv version

2021-11-22 Thread GitBox
flinkbot commented on pull request #17877: URL: https://github.com/apache/flink/pull/17877#issuecomment-976202050 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-24495) Python installdeps hangs

2021-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24495: --- Labels: pull-request-available test-stability (was: test-stability) > Python installdeps ha

[GitHub] [flink] HuangXingBo opened a new pull request #17877: [FLINK-24495][python][tests] Upgrade virtualenv version

2021-11-22 Thread GitBox
HuangXingBo opened a new pull request #17877: URL: https://github.com/apache/flink/pull/17877 ## What is the purpose of the change *This pull request will upgrade `virtualenv` version.* ## Brief change log - *Upgrade `virtualenv` version to `20.10.0`* ##

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] lindong28 commented on a change in pull request #28: [Flink-24556] Add Estimator and Transformer for logistic regression

2021-11-22 Thread GitBox
lindong28 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r754831435 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasEpsilon.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17670: URL: https://github.com/apache/flink/pull/17670#issuecomment-960539433 ## CI report: * 9f14fb2c282614088363960f23af3d6c5770ff15 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] lindong28 commented on a change in pull request #28: [Flink-24556] Add Estimator and Transformer for logistic regression

2021-11-22 Thread GitBox
lindong28 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r754825324 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasEpsilon.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-24915) StreamElementSerializer#deserialize(StreamElement reuse, DataInputView source) forgets to handle tag == TAG_STREAM_STATUS

2021-11-22 Thread bx123 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447797#comment-17447797 ] bx123 commented on FLINK-24915: --- [~arvid]  [#FLINK-5017] introduced StreamStatus support

[GitHub] [flink] flinkbot edited a comment on pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17670: URL: https://github.com/apache/flink/pull/17670#issuecomment-960539433 ## CI report: * 9f14fb2c282614088363960f23af3d6c5770ff15 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] beyond1920 commented on pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-22 Thread GitBox
beyond1920 commented on pull request #17670: URL: https://github.com/apache/flink/pull/17670#issuecomment-976196981 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [flink] hililiwei commented on a change in pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify

2021-11-22 Thread GitBox
hililiwei commented on a change in pull request #17749: URL: https://github.com/apache/flink/pull/17749#discussion_r754827593 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/DefaultPartTimeExtractor.java ## @@ -77,29 +79,49 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17838: [FLINK-24915] [DataStream] fix StreamElementSerializer#deserialize(reuse, source) forgets to handle tag == TAG_STREAM_STATUS.

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17838: URL: https://github.com/apache/flink/pull/17838#issuecomment-974023420 ## CI report: * c8204684d4268cad534759a6c7bb487e17fdbb05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17838: [FLINK-24915] [DataStream] fix StreamElementSerializer#deserialize(reuse, source) forgets to handle tag == TAG_STREAM_STATUS.

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17838: URL: https://github.com/apache/flink/pull/17838#issuecomment-974023420 ## CI report: * c8204684d4268cad534759a6c7bb487e17fdbb05 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] lindong28 commented on a change in pull request #28: [Flink-24556] Add Estimator and Transformer for logistic regression

2021-11-22 Thread GitBox
lindong28 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r754825324 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasEpsilon.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] flinkbot edited a comment on pull request #17874: [FLINK-24046] Refactor the EmbeddedRocksDBStateBackend configuration logic

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17874: URL: https://github.com/apache/flink/pull/17874#issuecomment-976109395 ## CI report: * 95f6020ca7df973e5a50a0eab36fa2bd1a33878c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17823: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17823: URL: https://github.com/apache/flink/pull/17823#issuecomment-972474977 ## CI report: * fe017595cf990c90cf53deea9c11288e77c7565a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] lindong28 commented on a change in pull request #28: [Flink-24556] Add Estimator and Transformer for logistic regression

2021-11-22 Thread GitBox
lindong28 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r754820934 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasEpsilon.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
YuvalItzchakov commented on a change in pull request #17845: URL: https://github.com/apache/flink/pull/17845#discussion_r754823553 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/LookupJoinTest.scala ## @@ -525,7

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #17845: [FLINK-24352] [flink-table-planner] Add null check for temporal table check on SqlSnapshot

2021-11-22 Thread GitBox
YuvalItzchakov commented on a change in pull request #17845: URL: https://github.com/apache/flink/pull/17845#discussion_r754823553 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/LookupJoinTest.scala ## @@ -525,7

[jira] [Commented] (FLINK-24948) Special character in column names breaks JDBC statement parsing

2021-11-22 Thread Paul Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447789#comment-17447789 ] Paul Lin commented on FLINK-24948: -- Yes, I'm working on it. May I ask your opinion on t

[GitHub] [flink] flinkbot edited a comment on pull request #17813: [FLINK-24802][Table SQL/Planner] Improve cast ROW to STRING

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17813: URL: https://github.com/apache/flink/pull/17813#issuecomment-970956527 ## CI report: * d4a10bc3d83bb43c839ae7b54e8bd41a65b94925 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify DateTi

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17749: URL: https://github.com/apache/flink/pull/17749#issuecomment-965029957 ## CI report: * b87090dace76f1298934c25b6fdb892853376bb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-12941) Translate "Amazon AWS Kinesis Streams Connector" page into Chinese

2021-11-22 Thread ZhuoYu Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447787#comment-17447787 ] ZhuoYu Chen commented on FLINK-12941: - Hi [~jark] I am very interested in this,and I

[GitHub] [flink] hililiwei commented on a change in pull request #17749: [FLINK-24758][Connectors / FileSystem] filesystem sink: add partitiontime-extractor.formatter-pattern to allow user to speify

2021-11-22 Thread GitBox
hililiwei commented on a change in pull request #17749: URL: https://github.com/apache/flink/pull/17749#discussion_r754819067 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemConnectorOptions.java ## @@ -156,6 +156,22 @@

[jira] [Commented] (FLINK-24696) Translate how to configure unaligned checkpoints into Chinese

2021-11-22 Thread ZhuoYu Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447786#comment-17447786 ] ZhuoYu Chen commented on FLINK-24696: - Hi [~pnowojski]  , I am very interested in th

[jira] [Commented] (FLINK-13550) Support for CPU FlameGraphs in web UI

2021-11-22 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447783#comment-17447783 ] jackylau commented on FLINK-13550: -- hi [~arvid]  [~dmvk] , i have a question. [https:/

[jira] [Comment Edited] (FLINK-13550) Support for CPU FlameGraphs in web UI

2021-11-22 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447783#comment-17447783 ] jackylau edited comment on FLINK-13550 at 11/23/21, 5:36 AM: -

[jira] [Updated] (FLINK-13550) Support for CPU FlameGraphs in web UI

2021-11-22 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau updated FLINK-13550: - Attachment: image-2021-11-23-13-36-03-269.png > Support for CPU FlameGraphs in web UI >

[jira] [Commented] (FLINK-24975) Add hooks and extension points to FlinkSQL

2021-11-22 Thread junbiao chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447778#comment-17447778 ] junbiao chen commented on FLINK-24975: -- I will start a discussion about this issue

[GitHub] [flink] flinkbot edited a comment on pull request #17822: Release 1.14 kafka3.0 bug

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17822: URL: https://github.com/apache/flink/pull/17822#issuecomment-971696959 ## CI report: * 3719c0402ec979c619371fcde9f2e7d2c46d69ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17822: Release 1.14 kafka3.0 bug

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17822: URL: https://github.com/apache/flink/pull/17822#issuecomment-971696959 ## CI report: * 3719c0402ec979c619371fcde9f2e7d2c46d69ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] godfreyhe commented on pull request #17805: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-22 Thread GitBox
godfreyhe commented on pull request #17805: URL: https://github.com/apache/flink/pull/17805#issuecomment-976162994 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Closed] (FLINK-24708) `ConvertToNotInOrInRule` has a bug which leads to wrong result

2021-11-22 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-24708. -- Resolution: Fixed Fixed in: 1.15.0: 90e850301e672fc0da293abc55eb446f7ec68ffa 1.14.1: 4315c1be1f9436705

[GitHub] [flink] godfreyhe closed pull request #17805: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-22 Thread GitBox
godfreyhe closed pull request #17805: URL: https://github.com/apache/flink/pull/17805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[jira] [Created] (FLINK-25011) Introduce VertexParallelismDecider

2021-11-22 Thread Lijie Wang (Jira)
Lijie Wang created FLINK-25011: -- Summary: Introduce VertexParallelismDecider Key: FLINK-25011 URL: https://issues.apache.org/jira/browse/FLINK-25011 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-24997) count(null) not supported in flink sql query

2021-11-22 Thread zouyunhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447767#comment-17447767 ] zouyunhe commented on FLINK-24997: -- OK [~icshuo]  > count(null) not supported in flink

[jira] [Commented] (FLINK-24997) count(null) not supported in flink sql query

2021-11-22 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447766#comment-17447766 ] Shuo Cheng commented on FLINK-24997: [~zouyunhe] you can follow the similar Jira FLI

[jira] [Created] (FLINK-25010) Speed up hive's createMRSplits by multi thread

2021-11-22 Thread Liu (Jira)
Liu created FLINK-25010: --- Summary: Speed up hive's createMRSplits by multi thread Key: FLINK-25010 URL: https://issues.apache.org/jira/browse/FLINK-25010 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-25010) Speed up hive's createMRSplits by multi thread

2021-11-22 Thread Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu updated FLINK-25010: Component/s: Connectors / Hive > Speed up hive's createMRSplits by multi thread >

[GitHub] [flink] godfreyhe commented on a change in pull request #17666: [FLINK-21327][table-planner-blink] Support window TVF in batch mode

2021-11-22 Thread GitBox
godfreyhe commented on a change in pull request #17666: URL: https://github.com/apache/flink/pull/17666#discussion_r754795448 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/WindowTableFunctionTest.scala ## @@ -0,0 +1,

[GitHub] [flink] godfreyhe commented on a change in pull request #17670: [FLINK-24760][docs] Update user document for batch window tvf

2021-11-22 Thread GitBox
godfreyhe commented on a change in pull request #17670: URL: https://github.com/apache/flink/pull/17670#discussion_r754793897 ## File path: docs/content.zh/docs/dev/table/sql/queries/window-agg.md ## @@ -40,7 +40,9 @@ Unlike other aggregations on continuous tables, window aggr

[jira] [Commented] (FLINK-24997) count(null) not supported in flink sql query

2021-11-22 Thread zouyunhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447765#comment-17447765 ] zouyunhe commented on FLINK-24997: -- [~jark] [~icshuo] the calcite can not deduce the ty

[jira] [Commented] (FLINK-24997) count(null) not supported in flink sql query

2021-11-22 Thread zouyunhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447764#comment-17447764 ] zouyunhe commented on FLINK-24997: -- [~icshuo] it works by use `select count(cast(null a

[jira] [Commented] (FLINK-24446) Casting from STRING to TIMESTAMP_LTZ looses fractional seconds

2021-11-22 Thread Shen Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447763#comment-17447763 ] Shen Zhu commented on FLINK-24446: -- Hey [~matriv] , I'm interested in working on this t

[GitHub] [flink] godfreyhe closed pull request #17806: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-22 Thread GitBox
godfreyhe closed pull request #17806: URL: https://github.com/apache/flink/pull/17806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [flink] flinkbot edited a comment on pull request #17876: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17876: URL: https://github.com/apache/flink/pull/17876#issuecomment-976152397 ## CI report: * 9b4fa70d5e2f6a31bbb7ad1b84fb8334ac24a46d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17876: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot commented on pull request #17876: URL: https://github.com/apache/flink/pull/17876#issuecomment-976152397 ## CI report: * 9b4fa70d5e2f6a31bbb7ad1b84fb8334ac24a46d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #17875: [BP-1.14][FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17875: URL: https://github.com/apache/flink/pull/17875#issuecomment-976151167 ## CI report: * 3c8b9142f5707820507d61fc71784f7ed4bc07f1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17876: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot commented on pull request #17876: URL: https://github.com/apache/flink/pull/17876#issuecomment-976152309 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot commented on pull request #17875: [BP-1.14][FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot commented on pull request #17875: URL: https://github.com/apache/flink/pull/17875#issuecomment-976151287 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot commented on pull request #17875: [BP-1.14][FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot commented on pull request #17875: URL: https://github.com/apache/flink/pull/17875#issuecomment-976151167 ## CI report: * 3c8b9142f5707820507d61fc71784f7ed4bc07f1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #17823: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17823: URL: https://github.com/apache/flink/pull/17823#issuecomment-972474977 ## CI report: * fc2c92648891940ca961617c5a7715d3e8137689 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wangyang0918 opened a new pull request #17876: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
wangyang0918 opened a new pull request #17876: URL: https://github.com/apache/flink/pull/17876 Backport #17823 to 1.14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-24997) count(null) not supported in flink sql query

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447762#comment-17447762 ] Jark Wu commented on FLINK-24997: - I agree with [~icshuo]. But the exception can be impr

[jira] [Commented] (FLINK-24948) Special character in column names breaks JDBC statement parsing

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447761#comment-17447761 ] Jark Wu commented on FLINK-24948: - Thanks [~Paul Lin], do you want to provide a fix for

[GitHub] [flink] flinkbot edited a comment on pull request #17823: [FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
flinkbot edited a comment on pull request #17823: URL: https://github.com/apache/flink/pull/17823#issuecomment-972474977 ## CI report: * fc2c92648891940ca961617c5a7715d3e8137689 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wangyang0918 opened a new pull request #17875: [BP-1.14][FLINK-24937][e2e] Return correct exit code in build_image

2021-11-22 Thread GitBox
wangyang0918 opened a new pull request #17875: URL: https://github.com/apache/flink/pull/17875 Backport #17823 to 1.14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-21415) JDBC connector should support to disable caching missing key

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447760#comment-17447760 ] Jark Wu commented on FLINK-21415: - [~liliwei], yes, you can add a config option {{looku

[jira] [Commented] (FLINK-24997) count(null) not supported in flink sql query

2021-11-22 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447758#comment-17447758 ] Shuo Cheng commented on FLINK-24997: Flink use Calcite to parse SQL, and Calcite has

[jira] [Updated] (FLINK-24966) Fix spelling errors in the project

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-24966: Summary: Fix spelling errors in the project (was: Typo fix) > Fix spelling errors in the project > --

[GitHub] [flink] wuchong commented on a change in pull request #17842: [FLINK-24966] [docs] Fix spelling errors in the project

2021-11-22 Thread GitBox
wuchong commented on a change in pull request #17842: URL: https://github.com/apache/flink/pull/17842#discussion_r754787598 ## File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/query/query44.sql ## @@ -1,5 +1,5 @@ -- start query 1 in stream 0 using template ../que

[jira] [Commented] (FLINK-21583) Allow comments in CSV format without having to ignore parse errors

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447755#comment-17447755 ] Jark Wu commented on FLINK-21583: - [~nkruber], could you help to check that? It seems we

[GitHub] [flink] RocMarshal commented on a change in pull request #17789: [FLINK-24351][docs] Translate "JSON Function" pages into Chinese

2021-11-22 Thread GitBox
RocMarshal commented on a change in pull request #17789: URL: https://github.com/apache/flink/pull/17789#discussion_r754785987 ## File path: docs/data/sql_functions_zh.yml ## @@ -908,15 +897,14 @@ json: - sql: JSON_OBJECTAGG([KEY] key VALUE value [ { NULL | ABSENT } ON NULL

[jira] [Commented] (FLINK-24975) Add hooks and extension points to FlinkSQL

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447753#comment-17447753 ] Jark Wu commented on FLINK-24975: - Yes, this one deserves a FLIP. Btw, this may also rel

[jira] [Closed] (FLINK-24976) sink utils not check the schema info between query and sink table

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-24976. --- Resolution: Not A Problem This is a SQL standard that not valid field names when INSERT INTO. If you want t

[jira] [Commented] (FLINK-24002) Support count window with the window TVF

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447749#comment-17447749 ] Jark Wu commented on FLINK-24002: - Thanks [~jingzhang] for hte summary. Your proposed sy

[GitHub] [flink] RocMarshal removed a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-22 Thread GitBox
RocMarshal removed a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-962460877 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (FLINK-25008) Improve behaviour of NotNullEnforcer when dropping records

2021-11-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447748#comment-17447748 ] Jark Wu commented on FLINK-25008: - Sounds good to me. > Improve behaviour of NotNullEn

  1   2   3   4   5   6   7   8   >