[GitHub] [flink] JingGe edited a comment on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-20 Thread GitBox
JingGe edited a comment on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-948313648 @tsreaper > > > For point 1, the uncompressed data size should be controlled by `StreamFormat.FETCH_IO_SIZE`. It might not be very precise to control the heap

[GitHub] [flink] JingGe commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-20 Thread GitBox
JingGe commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-948313648 > @JingGe > > > For point 1, the uncompressed data size should be controlled by `StreamFormat.FETCH_IO_SIZE`. It might not be very precise to control the heap size, since

[jira] [Updated] (FLINK-24596) Bugs in sink.buffer-flush before upsert-kafka

2021-10-20 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-24596: Priority: Critical (was: Blocker) > Bugs in sink.buffer-flush before upsert-kafka > -

[jira] [Comment Edited] (FLINK-15352) develop MySQLCatalog to connect Flink with MySQL tables and ecosystem

2021-10-20 Thread Yuepeng Pan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409327#comment-17409327 ] Yuepeng Pan edited comment on FLINK-15352 at 10/21/21, 6:47 AM: --

[jira] [Created] (FLINK-24608) Sinks built with the unified sink framework do not receive timestamps when used in Table API

2021-10-20 Thread Fabian Paul (Jira)
Fabian Paul created FLINK-24608: --- Summary: Sinks built with the unified sink framework do not receive timestamps when used in Table API Key: FLINK-24608 URL: https://issues.apache.org/jira/browse/FLINK-24608

[GitHub] [flink-ml] guoweiM commented on a change in pull request #8: [FLINK-4][iteration] Add operator wrapper for all-round iterations.

2021-10-20 Thread GitBox
guoweiM commented on a change in pull request #8: URL: https://github.com/apache/flink-ml/pull/8#discussion_r733358268 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/progresstrack/OperatorEpochWatermarkTracker.java ## @@ -0,0 +1,145 @@ +/* + * Licens

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-20 Thread GitBox
slinkydeveloper commented on a change in pull request #17520: URL: https://github.com/apache/flink/pull/17520#discussion_r733354416 ## File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroFileFormatFactory.java ## @@ -20,39 +20,135 @@ import o

[GitHub] [flink] flinkbot edited a comment on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227 ## CI report: * bf7f144b587313f1ab5cd706c52a25587151b923 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-24606) AvroDeserializationSchema buffer is not clean

2021-10-20 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432219#comment-17432219 ] Nicholas Jiang commented on FLINK-24606: [~douheyu], IMO, the decoder in AvroDes

[GitHub] [flink] flinkbot edited a comment on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227 ## CI report: * bf7f144b587313f1ab5cd706c52a25587151b923 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 4be189160a729c2814f3e2400300632d97e76470 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] RocMarshal commented on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-10-20 Thread GitBox
RocMarshal commented on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-948292117 Could someone help me to advance it ? Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink] flinkbot edited a comment on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 4be189160a729c2814f3e2400300632d97e76470 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17436: URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830 ## CI report: * c4fd4fc12dddf7d9a37bf111429158d158f32b2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17531: [FLINK-24598][table-runtime] Fix test problem that the current IT cas…

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17531: URL: https://github.com/apache/flink/pull/17531#issuecomment-948196975 ## CI report: * 4de4de84a971dbba3b6701922d083359a732b4f2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-23062) FLIP-129: Register sources/sinks in Table API

2021-10-20 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Bürk closed FLINK-23062. - Fix Version/s: 1.14.0 Resolution: Fixed > FLIP-129: Register sources/sinks in Table API > ---

[jira] [Commented] (FLINK-23062) FLIP-129: Register sources/sinks in Table API

2021-10-20 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432204#comment-17432204 ] Ingo Bürk commented on FLINK-23062: --- Yes, sorry. Will close it and move the FLIP. > F

[jira] [Commented] (FLINK-22096) ServerTransportErrorHandlingTest.testRemoteClose fail

2021-10-20 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432202#comment-17432202 ] Yuxin Tan commented on FLINK-22096: --- In the test case, a `{{BindException`}} may be th

[GitHub] [flink] flinkbot edited a comment on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-948251540 ## CI report: * dd8d7b161f71cef2099c746f4e54cb62d4b881dd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-10-20 Thread GitBox
flinkbot commented on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-948252161 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-22096) ServerTransportErrorHandlingTest.testRemoteClose fail

2021-10-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22096: --- Labels: pull-request-available test-stability (was: test-stability) > ServerTransportErrorH

[GitHub] [flink] flinkbot commented on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-10-20 Thread GitBox
flinkbot commented on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-948251540 ## CI report: * dd8d7b161f71cef2099c746f4e54cb62d4b881dd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] TanYuxin-tyx opened a new pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-10-20 Thread GitBox
TanYuxin-tyx opened a new pull request #17532: URL: https://github.com/apache/flink/pull/17532 ## What is the purpose of the change Fix port conflict in `ServerTransportErrorHandlingTest#testRemoteClose`. In the test case, a `BindException` may be thrown when init Ne

[jira] [Commented] (FLINK-21068) Add new timeout options for Elasticsearch connector

2021-10-20 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432192#comment-17432192 ] Yangze Guo commented on FLINK-21068: I think it is a valid improvement. However, it

[jira] [Commented] (FLINK-24501) Unexpected behavior of cumulate window aggregate for late event after recover from sp/cp

2021-10-20 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432190#comment-17432190 ] Wenlong Lyu commented on FLINK-24501: - I think it may be better to make sure that wa

[jira] [Commented] (FLINK-24072) Add support for setting default headers in elasticsearch connector

2021-10-20 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432186#comment-17432186 ] Yangze Guo commented on FLINK-24072: [~hackergin] I'm not an expert on Elasticsearch

[jira] [Created] (FLINK-24607) SourceCoordinator may miss to close SplitEnumerator when failover frequently

2021-10-20 Thread Jark Wu (Jira)
Jark Wu created FLINK-24607: --- Summary: SourceCoordinator may miss to close SplitEnumerator when failover frequently Key: FLINK-24607 URL: https://issues.apache.org/jira/browse/FLINK-24607 Project: Flink

[jira] [Updated] (FLINK-24606) AvroDeserializationSchema buffer is not clean

2021-10-20 Thread heyu dou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] heyu dou updated FLINK-24606: - Description:  org.apache.flink.formats.avro.AvroDeserializationSchema Decoder want reuse  org.apache.avr

[jira] [Created] (FLINK-24606) AvroDeserializationSchema buffer is not clean

2021-10-20 Thread heyu dou (Jira)
heyu dou created FLINK-24606: Summary: AvroDeserializationSchema buffer is not clean Key: FLINK-24606 URL: https://issues.apache.org/jira/browse/FLINK-24606 Project: Flink Issue Type: Bug

[GitHub] [flink] fsk119 commented on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for avro formats

2021-10-20 Thread GitBox
fsk119 commented on pull request #1: URL: https://github.com/apache/flink/pull/1#issuecomment-948210311 I am recently busy working in the inner branch. I think I have no time to finish this PR -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17436: URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830 ## CI report: * 8e7cadf33f0414a07b1496cabe0c8d7088f870c2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17436: URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830 ## CI report: * 8e7cadf33f0414a07b1496cabe0c8d7088f870c2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] tsreaper edited a comment on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-20 Thread GitBox
tsreaper edited a comment on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-948202218 @JingGe > For point 1, the uncompressed data size should be controlled by `StreamFormat.FETCH_IO_SIZE`. It might not be very precise to control the heap size, si

[GitHub] [flink] tsreaper commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-20 Thread GitBox
tsreaper commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-948202218 @JingGe > For point 1, the uncompressed data size should be controlled by `StreamFormat.FETCH_IO_SIZE`. It might not be very precise to control the heap size, since the

[jira] [Commented] (FLINK-24539) ChangelogNormalize operator tooks too long time to INITIALIZING until failed

2021-10-20 Thread vmaster.cc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432172#comment-17432172 ] vmaster.cc commented on FLINK-24539: [~pnowojski] Thank you very much, i have subscr

[jira] [Commented] (FLINK-24539) ChangelogNormalize operator tooks too long time to INITIALIZING until failed

2021-10-20 Thread vmaster.cc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432171#comment-17432171 ] vmaster.cc commented on FLINK-24539: [~twalthr] Yeah, there is no partitioned, becau

[GitHub] [flink] flinkbot commented on pull request #17531: [FLINK-24598][table-runtime] Fix test problem that the current IT cas…

2021-10-20 Thread GitBox
flinkbot commented on pull request #17531: URL: https://github.com/apache/flink/pull/17531#issuecomment-948198035 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot edited a comment on pull request #17531: [FLINK-24598][table-runtime] Fix test problem that the current IT cas…

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17531: URL: https://github.com/apache/flink/pull/17531#issuecomment-948196975 ## CI report: * 4de4de84a971dbba3b6701922d083359a732b4f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #17531: [FLINK-24598][table-runtime] Fix test problem that the current IT cas…

2021-10-20 Thread GitBox
flinkbot commented on pull request #17531: URL: https://github.com/apache/flink/pull/17531#issuecomment-948196975 ## CI report: * 4de4de84a971dbba3b6701922d083359a732b4f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Updated] (FLINK-24598) Current IT case do not cover fallback path for hash aggregate

2021-10-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24598: --- Labels: pull-request-available (was: ) > Current IT case do not cover fallback path for has

[GitHub] [flink] RocMarshal edited a comment on pull request #17508: [FLINK-24351][docs] Translate "JSON Function" pages into Chinese

2021-10-20 Thread GitBox
RocMarshal edited a comment on pull request #17508: URL: https://github.com/apache/flink/pull/17508#issuecomment-948196371 @MonsterChenzhuo Thanks for the update. Maybe you should rebase from latest master branch for your branch and resolve the conflicting file before next review . -- T

[GitHub] [flink] cshuo opened a new pull request #17531: [FLINK-24598][table-runtime] Fix test problem that the current IT cas…

2021-10-20 Thread GitBox
cshuo opened a new pull request #17531: URL: https://github.com/apache/flink/pull/17531 …e do not cover fallback path for hash aggregate ## What is the purpose of the change Test data in AggregateITCaseBase#testBigData is not big enough to trigger hash agg to sort and

[GitHub] [flink] RocMarshal commented on pull request #17508: [FLINK-24351][docs] Translate "JSON Function" pages into Chinese

2021-10-20 Thread GitBox
RocMarshal commented on pull request #17508: URL: https://github.com/apache/flink/pull/17508#issuecomment-948196371 @MonsterChenzhuo Maybe you should rebase from latest master branch for your branch and resolve the conflicting file before next review . -- This is an automated message fro

[GitHub] [flink] RocMarshal commented on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-20 Thread GitBox
RocMarshal commented on pull request #17352: URL: https://github.com/apache/flink/pull/17352#issuecomment-948195266 @wuchong I really appreciate it. I make some change based on your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Updated] (FLINK-23997) Improvement for SQL windowing table-valued function

2021-10-20 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-23997: --- Fix Version/s: 1.15.0 > Improvement for SQL windowing table-valued function > --

[GitHub] [flink] godfreyhe commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-20 Thread GitBox
godfreyhe commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r732918626 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java ## @@ -867,27 +885,118

[GitHub] [flink] godfreyhe commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-20 Thread GitBox
godfreyhe commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r732920524 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java ## @@ -867,27 +885,118

[jira] [Created] (FLINK-24605) org.apache.flink.kafka.shaded.org.apache.kafka.clients.consumer.NoOffsetForPartitionException: Undefined offset with no reset policy for partitions

2021-10-20 Thread Abhijit Talukdar (Jira)
Abhijit Talukdar created FLINK-24605: Summary: org.apache.flink.kafka.shaded.org.apache.kafka.clients.consumer.NoOffsetForPartitionException: Undefined offset with no reset policy for partitions Key: FLINK-24605

[GitHub] [flink] flinkbot edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17352: URL: https://github.com/apache/flink/pull/17352#issuecomment-926627700 ## CI report: * d45a1f76630a03ec6a0efd3d38044ab925ab7533 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-23062) FLIP-129: Register sources/sinks in Table API

2021-10-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431431#comment-17431431 ] Martijn Visser commented on FLINK-23062: [~airblader] Should this ticket be clos

[GitHub] [flink] flinkbot edited a comment on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 4be189160a729c2814f3e2400300632d97e76470 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17518: [FLINK-24018][build] Remove Scala dependencies from Java APIs

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17518: URL: https://github.com/apache/flink/pull/17518#issuecomment-946526433 ## CI report: * a177b8b7a724a0de1c4f76326c55753eabcc417b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-20578) Cannot create empty array using ARRAY[]

2021-10-20 Thread Saad Ur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431414#comment-17431414 ] Saad Ur Rahman commented on FLINK-20578: Hello, I would like to try and resolve

[GitHub] [flink] flinkbot edited a comment on pull request #17522: [FLINK-24462][table] Introduce CastRule interface to reorganize casting code

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17522: URL: https://github.com/apache/flink/pull/17522#issuecomment-94673 ## CI report: * d16cc0f9e2290406d788453db9f771fe6cbc8637 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-24604) Failing tests for casting decimals to boolean

2021-10-20 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-24604. Fix Version/s: 1.15.0 Resolution: Fixed Fixed in master: 474b241eb1257f978a83aac934cf660157

[GitHub] [flink] twalthr closed pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
twalthr closed pull request #17530: URL: https://github.com/apache/flink/pull/17530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink] flinkbot edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17352: URL: https://github.com/apache/flink/pull/17352#issuecomment-926627700 ## CI report: * 3d03869b64cad0b1051bd0c07427a5a158320668 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Assigned] (FLINK-24331) PartiallyFinishedSourcesITCase fails with "No downstream received 0 from xxx;"

2021-10-20 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov reassigned FLINK-24331: - Assignee: Anton Kalashnikov > PartiallyFinishedSourcesITCase fails with "No dow

[GitHub] [flink] flinkbot edited a comment on pull request #17352: [FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17352: URL: https://github.com/apache/flink/pull/17352#issuecomment-926627700 ## CI report: * 3d03869b64cad0b1051bd0c07427a5a158320668 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17529: [FLINK-24563][table-planner] Fix NullPointerException when comparing timestamp_ltz with random string

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17529: URL: https://github.com/apache/flink/pull/17529#issuecomment-947630768 ## CI report: * f1a2a94b889d9645505ec351d434c0c9b7e095f8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] JingGe edited a comment on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-20 Thread GitBox
JingGe edited a comment on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-947822402 > @slinkydeveloper There are four reasons why I did not choose `StreamFormat`. > > 1. The biggest concern is that `StreamFormatAdapter.Reader#readBatch` stores all

[GitHub] [flink] JingGe commented on pull request #17520: [FLINK-24565][avro] Port avro file format factory to BulkReaderFormatFactory

2021-10-20 Thread GitBox
JingGe commented on pull request #17520: URL: https://github.com/apache/flink/pull/17520#issuecomment-947822402 > @slinkydeveloper There are four reasons why I did not choose `StreamFormat`. > > 1. The biggest concern is that `StreamFormatAdapter.Reader#readBatch` stores all results

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] godfreyhe commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-20 Thread GitBox
godfreyhe commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r732638497 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalHashAggIntoScanRule.java

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17522: [FLINK-24462][table] Introduce CastRule interface to reorganize casting code

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17522: URL: https://github.com/apache/flink/pull/17522#issuecomment-94673 ## CI report: * 2cacbb5c9e9c01e5d047c4a65116c2df43b8ebbf Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17528: [FLINK-24563][table-planner] Fix NullPointerException when comparing timestamp_ltz with random string

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17528: URL: https://github.com/apache/flink/pull/17528#issuecomment-947612146 ## CI report: * 61f8472269a74ee2dc391272a9b2a7b4244b44f3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 658994fafd3947a2a9a49fa91d3c7e4fce3e52b5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 658994fafd3947a2a9a49fa91d3c7e4fce3e52b5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17503: [FLINK-24334][Deployment/Kubernetes] Configuration 'kubernetes.flink.log.dir' compatible

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17503: URL: https://github.com/apache/flink/pull/17503#issuecomment-945138587 ## CI report: * a1619682d1eeaefeaec347c646e12f2b4ed7feb9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17518: [FLINK-24018][build] Remove Scala dependencies from Java APIs

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17518: URL: https://github.com/apache/flink/pull/17518#issuecomment-946526433 ## CI report: * fc128a1c856f13f484bd2582b7d2d7c6958bb8ec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] JingGe commented on a change in pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-10-20 Thread GitBox
JingGe commented on a change in pull request #17501: URL: https://github.com/apache/flink/pull/17501#discussion_r732881890 ## File path: flink-formats/flink-avro/pom.xml ## @@ -26,7 +26,7 @@ under the License. org.apache.flink flink-formats

[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17518: [FLINK-24018][build] Remove Scala dependencies from Java APIs

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17518: URL: https://github.com/apache/flink/pull/17518#issuecomment-946526433 ## CI report: * fc128a1c856f13f484bd2582b7d2d7c6958bb8ec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] JingGe commented on a change in pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-10-20 Thread GitBox
JingGe commented on a change in pull request #17501: URL: https://github.com/apache/flink/pull/17501#discussion_r732878761 ## File path: flink-formats/flink-avro/pom.xml ## @@ -26,7 +26,7 @@ under the License. org.apache.flink flink-formats

[GitHub] [flink] flinkbot commented on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot commented on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947759705 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] matriv commented on a change in pull request #17522: [FLINK-24462][table] Introduce CastRule interface to reorganize casting code

2021-10-20 Thread GitBox
matriv commented on a change in pull request #17522: URL: https://github.com/apache/flink/pull/17522#discussion_r732876782 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/data/casting/CastRuleProvider.java ## @@ -0,0 +1,155 @@ +/* + * License

[GitHub] [flink] flinkbot commented on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
flinkbot commented on pull request #17530: URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131 ## CI report: * 44a40ae5521cc5684ef7a809f6f772c25cb3d779 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Updated] (FLINK-24604) Failing tests for casting decimals to boolean

2021-10-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24604: --- Labels: pull-request-available (was: ) > Failing tests for casting decimals to boolean > --

[GitHub] [flink] matriv opened a new pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast

2021-10-20 Thread GitBox
matriv opened a new pull request #17530: URL: https://github.com/apache/flink/pull/17530 The decimal->boolean cast has been dropped but another PR added some tests using this cast, removing the casts, and keep only the ones that cast integer numerics to boolean. Follows: #32f7cc

[jira] [Created] (FLINK-24604) Failing tests for casting decimals to boolean

2021-10-20 Thread Marios Trivyzas (Jira)
Marios Trivyzas created FLINK-24604: --- Summary: Failing tests for casting decimals to boolean Key: FLINK-24604 URL: https://issues.apache.org/jira/browse/FLINK-24604 Project: Flink Issue Typ

[GitHub] [flink] JingGe commented on a change in pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-10-20 Thread GitBox
JingGe commented on a change in pull request #17501: URL: https://github.com/apache/flink/pull/17501#discussion_r732865726 ## File path: flink-formats/flink-avro/pom.xml ## @@ -26,7 +26,7 @@ under the License. org.apache.flink flink-formats

[GitHub] [flink] flinkbot edited a comment on pull request #17472: [FLINK-24486][rest] Make async result store duration configurable

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17472: URL: https://github.com/apache/flink/pull/17472#issuecomment-943076656 ## CI report: * f7c2d004a9d29fb2c3445445ed32ba9e9bb74e78 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-18568) Add Support for Azure Data Lake Store Gen 2 in Streaming File Sink

2021-10-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431292#comment-17431292 ] Martijn Visser commented on FLINK-18568: [~psrinivasulu] Hi! I wanted to check i

[GitHub] [flink] flinkbot edited a comment on pull request #17522: [FLINK-24462][table] Introduce CastRule interface to reorganize casting code

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17522: URL: https://github.com/apache/flink/pull/17522#issuecomment-94673 ## CI report: * c5310e9d376b11af0bdbb9d3f420129a5cec7975 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #17522: [FLINK-24462][table] Introduce CastRule interface to reorganize casting code

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17522: URL: https://github.com/apache/flink/pull/17522#issuecomment-94673 ## CI report: * c5310e9d376b11af0bdbb9d3f420129a5cec7975 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17522: [FLINK-24462][table] Introduce CastRule interface to reorganize casting code

2021-10-20 Thread GitBox
slinkydeveloper commented on a change in pull request #17522: URL: https://github.com/apache/flink/pull/17522#discussion_r732842077 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/data/casting/CastRuleProvider.java ## @@ -0,0 +1,155 @@ +/* +

[GitHub] [flink] twalthr closed pull request #17405: [FLINK-21456][table] Copy DateTimeUtils from avatica-core and introduce StringUtils

2021-10-20 Thread GitBox
twalthr closed pull request #17405: URL: https://github.com/apache/flink/pull/17405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink] flinkbot edited a comment on pull request #17464: [FLINK-24413] Casting to a CHAR() and VARCHAR() doesn't trim the stri…

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17464: URL: https://github.com/apache/flink/pull/17464#issuecomment-942309521 ## CI report: * 172ccce01b7019a637a5730c0cd76422cac94f89 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17518: [FLINK-24018][build] Remove Scala dependencies from Java APIs

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17518: URL: https://github.com/apache/flink/pull/17518#issuecomment-946526433 ## CI report: * fc128a1c856f13f484bd2582b7d2d7c6958bb8ec Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17527: [docs] Add link from README.md to 'Building Flink from Source'

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #17527: URL: https://github.com/apache/flink/pull/17527#issuecomment-947535485 ## CI report: * d65d5d3d68e46a5649d762c45a3b973602586607 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-10-20 Thread GitBox
flinkbot edited a comment on pull request #16606: URL: https://github.com/apache/flink/pull/16606#issuecomment-887431748 ## CI report: * f09d671bd530b29cfc8ed31c1300179a97698576 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-24577) Support cast from BINARY/VARBINARY/BYTES to of RAW()

2021-10-20 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431252#comment-17431252 ] Marios Trivyzas commented on FLINK-24577: - Sorry, didn't get, what do you mean p

[jira] [Assigned] (FLINK-24385) Add TRY_CAST function to be able to handle errors

2021-10-20 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marios Trivyzas reassigned FLINK-24385: --- Assignee: Marios Trivyzas > Add TRY_CAST function to be able to handle errors > ---

  1   2   3   4   >