[jira] [Commented] (FLINK-22815) Disable unaligned checkpoints for broadcast partitioning

2021-05-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354879#comment-17354879 ] Till Rohrmann commented on FLINK-22815: --- We shipped UC with Flink {{1.11.0}}, righ

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354878#comment-17354878 ] Timo Walther commented on FLINK-22737: -- After thinking about this topic again, also

[jira] [Updated] (FLINK-22815) Disable unaligned checkpoints for broadcast partitioning

2021-05-31 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-22815: --- Priority: Blocker (was: Critical) > Disable unaligned checkpoints for broadcast partitionin

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354876#comment-17354876 ] Leonard Xu commented on FLINK-22737: * -1 for using *NULL* which will bring the thre

[GitHub] [flink] luoyuxia commented on a change in pull request #16015: FLINK-22789 Support Hive version 2.3.7

2021-05-31 Thread GitBox
luoyuxia commented on a change in pull request #16015: URL: https://github.com/apache/flink/pull/16015#discussion_r642821594 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimLoader.java ## @@ -49,6 +49,7 @@

[GitHub] [flink] luoyuxia commented on a change in pull request #16015: FLINK-22789 Support Hive version 2.3.7

2021-05-31 Thread GitBox
luoyuxia commented on a change in pull request #16015: URL: https://github.com/apache/flink/pull/16015#discussion_r642821594 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimLoader.java ## @@ -49,6 +49,7 @@

[jira] [Commented] (FLINK-22789) Support Hive version 2.3.7

2021-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354857#comment-17354857 ] luoyuxia commented on FLINK-22789: -- [~tigerhou] Thanks for your contribution,  but ther

[jira] [Updated] (FLINK-22484) Built-in functions for collections

2021-05-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Bürk updated FLINK-22484: -- Summary: Built-in functions for collections (was: Buit-in functions for collections) > Built-in func

[GitHub] [flink] flinkbot commented on pull request #16037: [FLINK-22812][hive] Fix HiveConf, HiveMetaStoreClient and upgrade avr…

2021-05-31 Thread GitBox
flinkbot commented on pull request #16037: URL: https://github.com/apache/flink/pull/16037#issuecomment-851863905 ## CI report: * 41d093ec05780cbaad85e6789abac24f6fa0af95 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #15885: [FLINK-22376][runtime] RecoveredChannelStateHandler recycles the buffer if it was created inside and doesn't recycle if it was passed

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #15885: URL: https://github.com/apache/flink/pull/15885#issuecomment-837001445 ## CI report: * 4c1a9dbb3034eb0ac880db84954b2c40fed365c2 UNKNOWN * fc4cedd8a305e6cb1947d3ecdbced6c879b536e3 Azure: [FAILURE](https://dev.azure.com/apache-fl

[jira] [Updated] (FLINK-22817) About flink1.13 hive integration Kafka SQL

2021-05-31 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xingyuan cheng updated FLINK-22817: --- Description: Hello everyone At present, there are codes that depend on hive in many places

[GitHub] [flink] twalthr edited a comment on pull request #16037: [FLINK-22812][hive] Fix HiveConf, HiveMetaStoreClient and upgrade avr…

2021-05-31 Thread GitBox
twalthr edited a comment on pull request #16037: URL: https://github.com/apache/flink/pull/16037#issuecomment-851859090 @lirui-apache Yes, having two commits would be better to review. I think we are also disable spotless for Calcite copied classes. Ideally, we can also have one commit for

[GitHub] [flink] twalthr commented on pull request #16037: [FLINK-22812][hive] Fix HiveConf, HiveMetaStoreClient and upgrade avr…

2021-05-31 Thread GitBox
twalthr commented on pull request #16037: URL: https://github.com/apache/flink/pull/16037#issuecomment-851859090 @lirui-apache Yes, having two commits would be better to review. I think we are also disable spotless for Calcite copied classes. -- This is an automated message from the Apac

[jira] [Comment Edited] (FLINK-22776) Delete casting to byte[] in AbstractJdbcRowConverter class

2021-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354851#comment-17354851 ] luoyuxia edited comment on FLINK-22776 at 6/1/21, 6:31 AM: --- +1

[jira] [Commented] (FLINK-22776) Delete casting to byte[] in AbstractJdbcRowConverter class

2021-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354851#comment-17354851 ] luoyuxia commented on FLINK-22776: -- +1 I think we can delete it. You can sumit pr and

[jira] [Created] (FLINK-22817) About flink1.13 hive integration Kafka SQL

2021-05-31 Thread xingyuan cheng (Jira)
xingyuan cheng created FLINK-22817: -- Summary: About flink1.13 hive integration Kafka SQL Key: FLINK-22817 URL: https://issues.apache.org/jira/browse/FLINK-22817 Project: Flink Issue Type: N

[GitHub] [flink] lirui-apache commented on pull request #16037: [FLINK-22812][hive] Fix HiveConf, HiveMetaStoreClient and upgrade avr…

2021-05-31 Thread GitBox
lirui-apache commented on pull request #16037: URL: https://github.com/apache/flink/pull/16037#issuecomment-851855563 The copied code is formatted by spotless. Perhaps I should disable spotless for this module, so that we can easily compare the diff between copied and original hive files?

[GitHub] [flink] flinkbot commented on pull request #16037: [FLINK-22812][hive] Fix HiveConf, HiveMetaStoreClient and upgrade avr…

2021-05-31 Thread GitBox
flinkbot commented on pull request #16037: URL: https://github.com/apache/flink/pull/16037#issuecomment-851850302 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] JingsongLi commented on a change in pull request #13921: [FLINK-19896][table-blink] Improve first-n-row fetching in the Rank o…

2021-05-31 Thread GitBox
JingsongLi commented on a change in pull request #13921: URL: https://github.com/apache/flink/pull/13921#discussion_r642806420 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecRank.java ## @@ -207

[jira] [Updated] (FLINK-22812) Fix hive issues in sql-connector-hive jars

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22812: --- Labels: pull-request-available (was: ) > Fix hive issues in sql-connector-hive jars > -

[GitHub] [flink] lirui-apache opened a new pull request #16037: [FLINK-22812][hive] Fix HiveConf, HiveMetaStoreClient and upgrade avr…

2021-05-31 Thread GitBox
lirui-apache opened a new pull request #16037: URL: https://github.com/apache/flink/pull/16037 …o for hive 3.1.2 ## What is the purpose of the change Fix some hive issues in flink-sql-connector-hive-3.1.2 ## Brief change log - Fix HiveConf initializa

[jira] [Closed] (FLINK-22796) Update mem_setup_tm documentation

2021-05-31 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-22796. Resolution: Fixed Fixed via - master (1.14): 59fd4c60f4ca664c4ba16480e9700e4f9bb9b8c0 - release-1.

[jira] [Updated] (FLINK-22796) Update mem_setup_tm documentation

2021-05-31 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-22796: - Fix Version/s: 1.13.2 1.14.0 > Update mem_setup_tm documentation > --

[jira] [Updated] (FLINK-22796) Update mem_setup_tm documentation

2021-05-31 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-22796: - Priority: Major (was: Minor) > Update mem_setup_tm documentation >

[jira] [Updated] (FLINK-22796) Update mem_setup_tm documentation

2021-05-31 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-22796: - Affects Version/s: 1.13.1 > Update mem_setup_tm documentation >

[jira] [Updated] (FLINK-22796) Update mem_setup_tm documentation

2021-05-31 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-22796: - Parent: (was: FLINK-19604) Issue Type: Bug (was: Sub-task) > Update mem_setup_tm do

[GitHub] [flink] xintongsong closed pull request #16016: [FLINK-22796] Update mem_setup_tm documentation

2021-05-31 Thread GitBox
xintongsong closed pull request #16016: URL: https://github.com/apache/flink/pull/16016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [flink] flinkbot edited a comment on pull request #15885: [FLINK-22376][runtime] RecoveredChannelStateHandler recycles the buffer if it was created inside and doesn't recycle if it was passed

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #15885: URL: https://github.com/apache/flink/pull/15885#issuecomment-837001445 ## CI report: * 4c1a9dbb3034eb0ac880db84954b2c40fed365c2 UNKNOWN * fc4cedd8a305e6cb1947d3ecdbced6c879b536e3 Azure: [FAILURE](https://dev.azure.com/apache-fl

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354813#comment-17354813 ] Ingo Bürk commented on FLINK-22737: --- Just for completeness, this is how the SQL client

[jira] [Updated] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Bürk updated FLINK-22737: -- Attachment: screenshot-2021-05-31_14-22-43.png > Add support for CURRENT_WATERMARK to SQL > --

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 2d98e97a844ff39a858c9500ff0a8cf49b8ca055 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14820: [FLINK-21085][runtime][checkpoint] Allows triggering checkpoint barrier handler for non-source tasks

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #14820: URL: https://github.com/apache/flink/pull/14820#issuecomment-770327711 ## CI report: * d83bee7799051ef32e0f9ec9e26339b23b7dc057 UNKNOWN * 045971a4900dc6798be00108c8e639e1c77fa18c Azure: [CANCELED](https://dev.azure.com/apache-f

[GitHub] [flink] JasonLeeCoding commented on a change in pull request #16028: [FLINK-22795] Throw better exception when executing remote SQL file in SQL Client

2021-05-31 Thread GitBox
JasonLeeCoding commented on a change in pull request #16028: URL: https://github.com/apache/flink/pull/16028#discussion_r642783697 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java ## @@ -213,6 +214,16 @@ protected static voi

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 2d98e97a844ff39a858c9500ff0a8cf49b8ca055 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16016: [FLINK-22796] Update mem_setup_tm documentation

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16016: URL: https://github.com/apache/flink/pull/16016#issuecomment-850273330 ## CI report: * 8e520a025e21f3f14d789f9326fa5c7782336a43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] JasonLeeCoding commented on a change in pull request #16028: [FLINK-22795] Throw better exception when executing remote SQL file in SQL Client

2021-05-31 Thread GitBox
JasonLeeCoding commented on a change in pull request #16028: URL: https://github.com/apache/flink/pull/16028#discussion_r642775785 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlExecutionException.java ## @@ -0,0 +1,33 @@ +/* + * Lice

[GitHub] [flink] JasonLeeCoding commented on a change in pull request #16028: [FLINK-22795] Throw better exception when executing remote SQL file in SQL Client

2021-05-31 Thread GitBox
JasonLeeCoding commented on a change in pull request #16028: URL: https://github.com/apache/flink/pull/16028#discussion_r642774290 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java ## @@ -205,6 +205,17 @@ public void test

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 2d98e97a844ff39a858c9500ff0a8cf49b8ca055 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16016: [FLINK-22796] Update mem_setup_tm documentation

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16016: URL: https://github.com/apache/flink/pull/16016#issuecomment-850273330 ## CI report: * 8e520a025e21f3f14d789f9326fa5c7782336a43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14820: [FLINK-21085][runtime][checkpoint] Allows triggering checkpoint barrier handler for non-source tasks

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #14820: URL: https://github.com/apache/flink/pull/14820#issuecomment-770327711 ## CI report: * d83bee7799051ef32e0f9ec9e26339b23b7dc057 UNKNOWN * 045971a4900dc6798be00108c8e639e1c77fa18c Azure: [CANCELED](https://dev.azure.com/apache-f

[jira] [Assigned] (FLINK-21905) Hive streaming source should use FIFO FileSplitAssigner instead of LIFO

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-21905: --- Assignee: luoyuxia > Hive streaming source should use FIFO FileSplitAssigner instead of LIFO >

[jira] [Comment Edited] (FLINK-22689) Table API Documentation Row-Based Operations Example Fails

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354785#comment-17354785 ] Jark Wu edited comment on FLINK-22689 at 6/1/21, 4:11 AM: -- Fixe

[jira] [Updated] (FLINK-22689) Table API Documentation Row-Based Operations Example Fails

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-22689: Fix Version/s: 1.13.2 > Table API Documentation Row-Based Operations Example Fails > -

[jira] [Closed] (FLINK-22689) Table API Documentation Row-Based Operations Example Fails

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-22689. --- Fix Version/s: 1.14.0 Resolution: Fixed Fixed in master: 997fa27e462c612f70401939c0fa9b217490dd73 >

[GitHub] [flink] wuchong merged pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
wuchong merged pull request #16036: URL: https://github.com/apache/flink/pull/16036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Closed] (FLINK-21741) Support SHOW JARS statement in SQL Client

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21741. --- Fix Version/s: 1.14.0 Assignee: Nicholas Jiang Resolution: Fixed Implemented in master: 6668

[GitHub] [flink] wuchong merged pull request #16010: [FLINK-21741][sql-client] Support SHOW JARS statement in SQL Client

2021-05-31 Thread GitBox
wuchong merged pull request #16010: URL: https://github.com/apache/flink/pull/16010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [flink] wuchong commented on pull request #16010: [FLINK-21741][sql-client] Support SHOW JARS statement in SQL Client

2021-05-31 Thread GitBox
wuchong commented on pull request #16010: URL: https://github.com/apache/flink/pull/16010#issuecomment-851789262 The failed case is not related to this PR. Will merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] pensz removed a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
pensz removed a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851783298 ` mvn spotless:apply` test success in my local. I will check in an another environment. ``` [INFO] Reactor Summary for Flink : 1.14-SNAPSHOT: [INFO] [INFO]

[jira] [Commented] (FLINK-21905) Hive streaming source should use FIFO FileSplitAssigner instead of LIFO

2021-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354781#comment-17354781 ] luoyuxia commented on FLINK-21905: -- [~jark] Could you assign this issue to me? > Hive

[jira] [Commented] (FLINK-22806) The folder /checkpoint/shared state of FLINKSQL is getting bigger and bigger

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354780#comment-17354780 ] Jark Wu commented on FLINK-22806: - Hi [~yunta], could you post the link here so others c

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

2021-05-31 Thread GitBox
zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-851787011 If you have time, could you help review again? Thanks @lirui-apache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Updated] (FLINK-21086) Make checkpointBarrierHandler Support EndOfPartition

2021-05-31 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-21086: Summary: Make checkpointBarrierHandler Support EndOfPartition (was: CheckpointBarrierHandler Insert barri

[GitHub] [flink] tony810430 commented on pull request #16016: [FLINK-22796] Update mem_setup_tm documentation

2021-05-31 Thread GitBox
tony810430 commented on pull request #16016: URL: https://github.com/apache/flink/pull/16016#issuecomment-851785081 Hi @xintongsong I have addressed your comments. what do you think for these update? -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [flink] pensz commented on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
pensz commented on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851783298 ` mvn spotless:apply` test success in my local. I will check in an another environment. ``` [INFO] Reactor Summary for Flink : 1.14-SNAPSHOT: [INFO] [INFO] Flink :

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 08a786455ddca7efb86a77dae27511f050d728f6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2021-05-31 Thread wangwj (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354777#comment-17354777 ] wangwj commented on FLINK-10205: [~Ryantaocer][~isunjin] Hi, excuse me. After I read thi

[GitHub] [flink] xintongsong commented on a change in pull request #16016: [FLINK-22796] Update mem_setup_tm documentation

2021-05-31 Thread GitBox
xintongsong commented on a change in pull request #16016: URL: https://github.com/apache/flink/pull/16016#discussion_r642757794 ## File path: docs/content/docs/deployment/memory/mem_setup_tm.md ## @@ -98,13 +98,14 @@ See also [how to configure memory for state backends]({{< re

[GitHub] [flink] flinkbot edited a comment on pull request #16034: [FLINK-22794][table-api]Upgrade JUnit Vintage for flink-sql-parser and flink-sql-hive-parser

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16034: URL: https://github.com/apache/flink/pull/16034#issuecomment-851582958 ## CI report: * 777b9e65a26b6dbca69c7a9bae35bb8baf90d327 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 08a786455ddca7efb86a77dae27511f050d728f6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16036: URL: https://github.com/apache/flink/pull/16036#issuecomment-851746085 ## CI report: * 484f4fed68bd22ecfe249e4fc909da2a23e0d826 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15524: [FLINK-21667][runtime] Defer starting ResourceManager to after obtaining leadership.

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #15524: URL: https://github.com/apache/flink/pull/15524#issuecomment-815574117 ## CI report: * f5d1cd207a362b395ad1628b25b40f9abc2caaf9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-22806) The folder /checkpoint/shared state of FLINKSQL is getting bigger and bigger

2021-05-31 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-22806. Resolution: Information Provided > The folder /checkpoint/shared state of FLINKSQL is getting bigger and

[jira] [Comment Edited] (FLINK-22806) The folder /checkpoint/shared state of FLINKSQL is getting bigger and bigger

2021-05-31 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354767#comment-17354767 ] Yun Tang edited comment on FLINK-22806 at 6/1/21, 3:14 AM: --- I

[GitHub] [flink] fsk119 commented on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
fsk119 commented on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851774064 @pensz Hi, the CI test fails. Please run `mvn spotless:apply` to fix the checkstyle problem. -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Commented] (FLINK-22806) The folder /checkpoint/shared state of FLINKSQL is getting bigger and bigger

2021-05-31 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354767#comment-17354767 ] Yun Tang commented on FLINK-22806: -- I noticed that you have already opened related issu

[GitHub] [flink] pensz commented on a change in pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
pensz commented on a change in pull request #16029: URL: https://github.com/apache/flink/pull/16029#discussion_r642753682 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Ap

[GitHub] [flink] xintongsong commented on pull request #15524: [FLINK-21667][runtime] Defer starting ResourceManager to after obtaining leadership.

2021-05-31 Thread GitBox
xintongsong commented on pull request #15524: URL: https://github.com/apache/flink/pull/15524#issuecomment-851772901 @wangyang0918, I've addressed your comments, and rebased for conflict resolving. Please take another look. I've also opened FLINK-22816 for investigating the possibilit

[jira] [Created] (FLINK-22816) Investigate feasibility of supporting multiple RM leader sessions within JM process

2021-05-31 Thread Xintong Song (Jira)
Xintong Song created FLINK-22816: Summary: Investigate feasibility of supporting multiple RM leader sessions within JM process Key: FLINK-22816 URL: https://issues.apache.org/jira/browse/FLINK-22816 P

[GitHub] [flink] fsk119 commented on a change in pull request #16028: [FLINK-22795] Throw better exception when executing remote SQL file in SQL Client

2021-05-31 Thread GitBox
fsk119 commented on a change in pull request #16028: URL: https://github.com/apache/flink/pull/16028#discussion_r642751015 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java ## @@ -205,6 +205,17 @@ public void testExecuteS

[GitHub] [flink] fsk119 commented on a change in pull request #16028: [FLINK-22795] Throw better exception when executing remote SQL file in SQL Client

2021-05-31 Thread GitBox
fsk119 commented on a change in pull request #16028: URL: https://github.com/apache/flink/pull/16028#discussion_r642749269 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java ## @@ -213,6 +214,16 @@ protected static void startC

[GitHub] [flink] fsk119 commented on a change in pull request #16028: [FLINK-22795] Throw better exception when executing remote SQL file in SQL Client

2021-05-31 Thread GitBox
fsk119 commented on a change in pull request #16028: URL: https://github.com/apache/flink/pull/16028#discussion_r642749501 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlExecutionException.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #16034: [FLINK-22794][table-api]Upgrade JUnit Vintage for flink-sql-parser and flink-sql-hive-parser

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16034: URL: https://github.com/apache/flink/pull/16034#issuecomment-851582958 ## CI report: * 777b9e65a26b6dbca69c7a9bae35bb8baf90d327 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 08a786455ddca7efb86a77dae27511f050d728f6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15524: [FLINK-21667][runtime] Defer starting ResourceManager to after obtaining leadership.

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #15524: URL: https://github.com/apache/flink/pull/15524#issuecomment-815574117 ## CI report: * f5d1cd207a362b395ad1628b25b40f9abc2caaf9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] godfreyhe commented on a change in pull request #16024: [FLINK-22038][table-planner-blink] Update TopN to be without rowNumber if rowNumber field is never used by the successor Calc

2021-05-31 Thread GitBox
godfreyhe commented on a change in pull request #16024: URL: https://github.com/apache/flink/pull/16024#discussion_r642744349 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala ## @@ -374,6 +37

[jira] [Comment Edited] (FLINK-16069) Creation of TaskDeploymentDescriptor can block main thread for long time

2021-05-31 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354757#comment-17354757 ] Zhu Zhu edited comment on FLINK-16069 at 6/1/21, 2:54 AM: -- Even

[jira] [Commented] (FLINK-16069) Creation of TaskDeploymentDescriptor can block main thread for long time

2021-05-31 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354757#comment-17354757 ] Zhu Zhu commented on FLINK-16069: - Even if the main thread can have the highest priority

[GitHub] [flink] JasonLeeCoding commented on pull request #16028: [FLINK-22795] Throw better exception when executing remote SQL file in SQL Client

2021-05-31 Thread GitBox
JasonLeeCoding commented on pull request #16028: URL: https://github.com/apache/flink/pull/16028#issuecomment-851766303 @fsk119 Please help me review the code ,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] xintongsong commented on pull request #15524: [FLINK-21667][runtime] Defer starting ResourceManager to after obtaining leadership.

2021-05-31 Thread GitBox
xintongsong commented on pull request #15524: URL: https://github.com/apache/flink/pull/15524#issuecomment-851765702 > What will currently happen if a RM loses the leadership? Will it simply terminate the process and let Yarn start a new process to reapply for the leadership? Yes, e

[GitHub] [flink] wuchong commented on pull request #16034: [FLINK-22794][table-api]Upgrade JUnit Vintage for flink-sql-parser and flink-sql-hive-parser

2021-05-31 Thread GitBox
wuchong commented on pull request #16034: URL: https://github.com/apache/flink/pull/16034#issuecomment-851765396 It seems that the `flink-sql-parser` and `flink-sql-parser-hive` modules are never tested in CI build. I just added them into test modules, cc @twalthr @zentol . -- This is

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 233774d84c03ea4a77b3433cf44dc12dcb3a8814 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-18958) Lose column comment when create table

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-18958: Labels: auto-unassigned pull-request-available (was: auto-unassigned pull-request-available stale-major)

[GitHub] [flink] godfreyhe commented on a change in pull request #15997: [FLINK-22680][table-planner-blink] Fix IndexOutOfBoundsException when apply WatermarkAssignerChangelogNormalizeTransposeRule

2021-05-31 Thread GitBox
godfreyhe commented on a change in pull request #15997: URL: https://github.com/apache/flink/pull/15997#discussion_r642741007 ## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/rules/physical/stream/WatermarkAssignerChangelogNorm

[GitHub] [flink] flinkbot edited a comment on pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16029: URL: https://github.com/apache/flink/pull/16029#issuecomment-851388620 ## CI report: * 233774d84c03ea4a77b3433cf44dc12dcb3a8814 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
flinkbot edited a comment on pull request #16036: URL: https://github.com/apache/flink/pull/16036#issuecomment-851746085 ## CI report: * 484f4fed68bd22ecfe249e4fc909da2a23e0d826 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] fsk119 commented on a change in pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
fsk119 commented on a change in pull request #16029: URL: https://github.com/apache/flink/pull/16029#discussion_r642737314 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the A

[GitHub] [flink] fsk119 commented on a change in pull request #15986: [FLINK-22155][table] EXPLAIN statement should validate insert and query separately

2021-05-31 Thread GitBox
fsk119 commented on a change in pull request #15986: URL: https://github.com/apache/flink/pull/15986#discussion_r642734823 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java ## @@ -844,16 +84

[GitHub] [flink] pensz commented on a change in pull request #16029: [FLINK-22786][sql-client] sql-client can not create .flink-sql-history file

2021-05-31 Thread GitBox
pensz commented on a change in pull request #16029: URL: https://github.com/apache/flink/pull/16029#discussion_r642733457 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliUtils.java ## @@ -109,7 +109,7 @@ public static boolean creat

[GitHub] [flink] flinkbot commented on pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
flinkbot commented on pull request #16036: URL: https://github.com/apache/flink/pull/16036#issuecomment-851746085 ## CI report: * 484f4fed68bd22ecfe249e4fc909da2a23e0d826 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] paul8263 commented on pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
paul8263 commented on pull request #16036: URL: https://github.com/apache/flink/pull/16036#issuecomment-851740041 This issue could be fixed by changing the "as" expression in org/apache/flink/table/api/internal/BaseExpressions.java to as "in" org/apache/flink/table/api/Table.java. I have t

[GitHub] [flink] flinkbot commented on pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
flinkbot commented on pull request #16036: URL: https://github.com/apache/flink/pull/16036#issuecomment-851739474 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] paul8263 commented on pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
paul8263 commented on pull request #16036: URL: https://github.com/apache/flink/pull/16036#issuecomment-851739001 This issue could be fixed by changing the "as" expression in org/apache/flink/table/api/internal/BaseExpressions.java to as "in" org/apache/flink/table/api/Table.java. I have t

[jira] [Updated] (FLINK-22689) Table API Documentation Row-Based Operations Example Fails

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22689: --- Labels: pull-request-available (was: ) > Table API Documentation Row-Based Operations Examp

[GitHub] [flink] paul8263 opened a new pull request #16036: [FLINK-22689][doc] Table API Documentation Row-Based Operations Examp…

2021-05-31 Thread GitBox
paul8263 opened a new pull request #16036: URL: https://github.com/apache/flink/pull/16036 …le Fails ## What is the purpose of the change Correct error sample codes in chapter map and flatmap in docs/content/docs/dev/table/tableApi.md. ## Brief change log - docs/

[GitHub] [flink] SteNicholas commented on a change in pull request #16023: [FLINK-22698][connectors/rabbitmq] Add deliveryTimeout parameter to RabbitMQ source

2021-05-31 Thread GitBox
SteNicholas commented on a change in pull request #16023: URL: https://github.com/apache/flink/pull/16023#discussion_r642718447 ## File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java

[GitHub] [flink] SteNicholas commented on a change in pull request #16023: [FLINK-22698][connectors/rabbitmq] Add deliveryTimeout parameter to RabbitMQ source

2021-05-31 Thread GitBox
SteNicholas commented on a change in pull request #16023: URL: https://github.com/apache/flink/pull/16023#discussion_r642718447 ## File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java

[GitHub] [flink] SteNicholas commented on a change in pull request #16023: [FLINK-22698][connectors/rabbitmq] Add deliveryTimeout parameter to RabbitMQ source

2021-05-31 Thread GitBox
SteNicholas commented on a change in pull request #16023: URL: https://github.com/apache/flink/pull/16023#discussion_r642717539 ## File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java

[jira] [Assigned] (FLINK-22722) Add Documentation for Kafka New Source

2021-05-31 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned FLINK-22722: Assignee: Qingsheng Ren > Add Documentation for Kafka New Source > --

[jira] [Resolved] (FLINK-22722) Add Documentation for Kafka New Source

2021-05-31 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved FLINK-22722. -- Resolution: Fixed Merged to master:  b582991b8b2b8dadb89e71d5002c4a9cc2055e34 > Add Document

  1   2   3   4   >