[GitHub] [flink] flinkbot commented on pull request #15749: [hotfix] Fix typo.

2021-04-25 Thread GitBox
flinkbot commented on pull request #15749: URL: https://github.com/apache/flink/pull/15749#issuecomment-826269994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] cshuo commented on pull request #15747: [FLINK-19449][table-planner] LEAD/LAG cannot work correctly in streaming mode

2021-04-25 Thread GitBox
cshuo commented on pull request #15747: URL: https://github.com/apache/flink/pull/15747#issuecomment-826467428 LGTM, +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Commented] (FLINK-22019) UnalignedCheckpointRescaleITCase hangs on azure

2021-04-25 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331824#comment-17331824 ] Arvid Heise commented on FLINK-22019: - Probably a duplicate of FLINK-22368. > Unali

[GitHub] [flink] flinkbot commented on pull request #15744: [FLINK-22113][table-planner-blink] Implement the column uniqueness checking for TableSourceTable

2021-04-25 Thread GitBox
flinkbot commented on pull request #15744: URL: https://github.com/apache/flink/pull/15744#issuecomment-826244450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] beyond1920 commented on pull request #15760: [FLINK-19606][table-runtime-blink] Introduce WindowJoinOperator and WindowJoinOperatorBuilder.

2021-04-25 Thread GitBox
beyond1920 commented on pull request #15760: URL: https://github.com/apache/flink/pull/15760#issuecomment-826490680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [flink] flinkbot commented on pull request #15751: [FLINK-22074][test] Harden FineGrainedSlotManagerTest#testRequirement…

2021-04-25 Thread GitBox
flinkbot commented on pull request #15751: URL: https://github.com/apache/flink/pull/15751#issuecomment-826300490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] zuston commented on pull request #15750: [FLINK-22294][hive] Hive reading fail when getting file numbers on different filesystem nameservices

2021-04-25 Thread GitBox
zuston commented on pull request #15750: URL: https://github.com/apache/flink/pull/15750#issuecomment-826285152 @lirui-apache Please check it. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] wangwei1025 commented on a change in pull request #15746: [FLINK-17783][Table SQL/Ecosystem]Add array,map,row types support for orc row writer

2021-04-25 Thread GitBox
wangwei1025 commented on a change in pull request #15746: URL: https://github.com/apache/flink/pull/15746#discussion_r619948239 ## File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/vector/RowDataVectorizer.java ## @@ -151,8 +160,114 @@ private static void s

[GitHub] [flink] flinkbot commented on pull request #15750: [FLINK-22294][hive] Hive reading fail when getting file numbers on different filesystem nameservices

2021-04-25 Thread GitBox
flinkbot commented on pull request #15750: URL: https://github.com/apache/flink/pull/15750#issuecomment-826285547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] Tartarus0zm commented on a change in pull request #15341: [FLINK-21923][table-planner-blink] Fix SplitAggregateRule not support both filter, count/sum, avg

2021-04-25 Thread GitBox
Tartarus0zm commented on a change in pull request #15341: URL: https://github.com/apache/flink/pull/15341#discussion_r619822655 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/SplitAggregateRule.scala ## @@ -

[GitHub] [flink] flinkbot edited a comment on pull request #15759: [FLINK-22463][table-planner-blink] Fix IllegalArgumentException in WindowAttachedWindowingStrategy when two phase is enabled for dist

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15759: URL: https://github.com/apache/flink/pull/15759#issuecomment-826494695 ## CI report: * 99b2ac7e2b6705a1bf3b2d087c399bce199380ee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #15748: [hotfix][coordination] Add log for slot allocation in FineGrainedSlot…

2021-04-25 Thread GitBox
flinkbot commented on pull request #15748: URL: https://github.com/apache/flink/pull/15748#issuecomment-826268725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] flinkbot commented on pull request #15746: [FLINK-17783][Table SQL/Ecosystem]Add array,map,row types support for orc row writer

2021-04-25 Thread GitBox
flinkbot commented on pull request #15746: URL: https://github.com/apache/flink/pull/15746#issuecomment-826266967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] JingsongLi commented on pull request #15569: [FLINK-21247][table] Fix problem in MapDataSerializer#copy when there…

2021-04-25 Thread GitBox
JingsongLi commented on pull request #15569: URL: https://github.com/apache/flink/pull/15569#issuecomment-826456129 @cshuo Can you create a PR for release-1.13? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot commented on pull request #15759: [FLINK-22463][table-planner-blink] Fix IllegalArgumentException in WindowAttachedWindowingStrategy when two phase is enabled for distinct ag

2021-04-25 Thread GitBox
flinkbot commented on pull request #15759: URL: https://github.com/apache/flink/pull/15759#issuecomment-826485216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] JingsongLi merged pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2021-04-25 Thread GitBox
JingsongLi merged pull request #13459: URL: https://github.com/apache/flink/pull/13459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [flink] JingsongLi commented on a change in pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg

2021-04-25 Thread GitBox
JingsongLi commented on a change in pull request #14880: URL: https://github.com/apache/flink/pull/14880#discussion_r619963485 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/OverAggregateITCase.scala ## @@ -

[GitHub] [flink] cshuo commented on a change in pull request #15747: [FLINK-19449][table-planner] LEAD/LAG cannot work correctly in streaming mode

2021-04-25 Thread GitBox
cshuo commented on a change in pull request #15747: URL: https://github.com/apache/flink/pull/15747#discussion_r619785598 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/LagAggFunction.java ## @@ -0,0 +1,1

[GitHub] [flink] flinkbot edited a comment on pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #13459: URL: https://github.com/apache/flink/pull/13459#issuecomment-697158140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] godfreyhe commented on pull request #14894: [FLINK-20895][flink-table-planner-blink] support local aggregate push down in blink planner

2021-04-25 Thread GitBox
godfreyhe commented on pull request #14894: URL: https://github.com/apache/flink/pull/14894#issuecomment-826202014 @sebastianliu Thanks for the update, I will review this pr ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink] wuchong merged pull request #8321: [FLINK-12351][DataStream] Fix AsyncWaitOperator to deep copy StreamElement when object reuse is enabled

2021-04-25 Thread GitBox
wuchong merged pull request #8321: URL: https://github.com/apache/flink/pull/8321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [flink] flinkbot edited a comment on pull request #15751: [FLINK-22074][test] Harden FineGrainedSlotManagerTest#testRequirement…

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15751: URL: https://github.com/apache/flink/pull/15751#issuecomment-826303832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] flinkbot edited a comment on pull request #15748: [hotfix][coordination] Add log for slot allocation in FineGrainedSlot…

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15748: URL: https://github.com/apache/flink/pull/15748#issuecomment-826269809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] flinkbot edited a comment on pull request #15760: [FLINK-19606][table-runtime-blink] Introduce WindowJoinOperator and WindowJoinOperatorBuilder.

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15760: URL: https://github.com/apache/flink/pull/15760#issuecomment-826500326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] lirui-apache commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

2021-04-25 Thread GitBox
lirui-apache commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-826324587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For qu

[GitHub] [flink] JingsongLi commented on pull request #15479: [FLINK-19606][table-runtime-blink] Implement streaming window join operator

2021-04-25 Thread GitBox
JingsongLi commented on pull request #15479: URL: https://github.com/apache/flink/pull/15479#issuecomment-826236802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [flink-statefun] tzulitai closed pull request #229: [hotfix][docs] Fix typos in apache-kafka.md and aws-kinesis.md

2021-04-25 Thread GitBox
tzulitai closed pull request #229: URL: https://github.com/apache/flink-statefun/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] galenwarren commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2021-04-25 Thread GitBox
galenwarren commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-826107261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For que

[GitHub] [flink-web] dianfu commented on a change in pull request #436: Add Apache Flink release 1.13.0

2021-04-25 Thread GitBox
dianfu commented on a change in pull request #436: URL: https://github.com/apache/flink-web/pull/436#discussion_r619763615 ## File path: _posts/2021-04-22-release-1.13.0.md ## @@ -0,0 +1,374 @@ +--- +layout: post +title: "Apache Flink 1.13.0 Release Announcement" +date: 2021-

[GitHub] [flink] JingsongLi commented on pull request #15746: [FLINK-17783][Table SQL/Ecosystem]Add array,map,row types support for orc row writer

2021-04-25 Thread GitBox
JingsongLi commented on pull request #15746: URL: https://github.com/apache/flink/pull/15746#issuecomment-826470370 @lirui-apache Can u take a look too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] hehuiyuan edited a comment on pull request #15712: [FLINK-22400][hive connect]fix NPE problem when convert flink object for Map

2021-04-25 Thread GitBox
hehuiyuan edited a comment on pull request #15712: URL: https://github.com/apache/flink/pull/15712#issuecomment-824547963 > Thanks @hehuiyuan for working on this issue. Can we add a test case to cover this? If it only happens for hive-2.0.0, we can just run it for hive-2.0.0 profile.

[GitHub] [flink] flinkbot commented on pull request #15758: [FLINK-21247][table] Fix problem in MapDataSerializer#copy when there exists custom MapData

2021-04-25 Thread GitBox
flinkbot commented on pull request #15758: URL: https://github.com/apache/flink/pull/15758#issuecomment-826470354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] wangwei1025 commented on pull request #15746: [FLINK-17783][Table SQL/Ecosystem]Add array,map,row types support for orc row writer

2021-04-25 Thread GitBox
wangwei1025 commented on pull request #15746: URL: https://github.com/apache/flink/pull/15746#issuecomment-826270772 hi @JingsongLi , could you please help me review this PR? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] JingsongLi merged pull request #15747: [FLINK-19449][table-planner] LEAD/LAG cannot work correctly in streaming mode

2021-04-25 Thread GitBox
JingsongLi merged pull request #15747: URL: https://github.com/apache/flink/pull/15747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [flink] flinkbot commented on pull request #15760: [FLINK-19606][table-runtime-blink] Introduce WindowJoinOperator and WindowJoinOperatorBuilder.

2021-04-25 Thread GitBox
flinkbot commented on pull request #15760: URL: https://github.com/apache/flink/pull/15760#issuecomment-826493595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] godfreyhe closed pull request #15341: [FLINK-21923][table-planner-blink] Fix SplitAggregateRule not support both filter, count/sum, avg

2021-04-25 Thread GitBox
godfreyhe closed pull request #15341: URL: https://github.com/apache/flink/pull/15341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [flink] flinkbot edited a comment on pull request #15750: [FLINK-22294][hive] Hive reading fail when getting file numbers on different filesystem nameservices

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15750: URL: https://github.com/apache/flink/pull/15750#issuecomment-826291209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] flinkbot edited a comment on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-818947931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] ZhangChaoming removed a comment on pull request #15749: [hotfix] Fix typo.

2021-04-25 Thread GitBox
ZhangChaoming removed a comment on pull request #15749: URL: https://github.com/apache/flink/pull/15749#issuecomment-826292398 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [flink] wuchong commented on a change in pull request #15709: [FLINK-22356][hive / filesystem] Fix partition-time commit failure when watermark is defined on TIMESTAMP_LTZ column

2021-04-25 Thread GitBox
wuchong commented on a change in pull request #15709: URL: https://github.com/apache/flink/pull/15709#discussion_r619666563 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java ## @@ -223,6 +225,130 @@ publ

[jira] [Commented] (FLINK-22458) Failed when operating empty catalog table

2021-04-25 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331808#comment-17331808 ] Spongebob commented on FLINK-22458: --- can you explain why this happened and how to avoi

[GitHub] [flink] flinkbot edited a comment on pull request #15758: [FLINK-21247][table] Fix problem in MapDataSerializer#copy when there exists custom MapData

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15758: URL: https://github.com/apache/flink/pull/15758#issuecomment-826479500 ## CI report: * 422de5b7c373f51311b0e8f4f48a1a679e9f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #15755: [FLINK-22318][table] Support RENAME column name for ALTER TABLE state…

2021-04-25 Thread GitBox
flinkbot commented on pull request #15755: URL: https://github.com/apache/flink/pull/15755#issuecomment-826343313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] JingsongLi commented on a change in pull request #15746: [FLINK-17783][Table SQL/Ecosystem]Add array,map,row types support for orc row writer

2021-04-25 Thread GitBox
JingsongLi commented on a change in pull request #15746: URL: https://github.com/apache/flink/pull/15746#discussion_r619943822 ## File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/vector/RowDataVectorizer.java ## @@ -151,8 +160,114 @@ private static void se

[GitHub] [flink] JingsongLi commented on pull request #15752: [FLINK-19606][table-runtime-blink] Refactor JoinConditionWithFullFilters from an inner class in AbstractStreamingJoinOperator to a common

2021-04-25 Thread GitBox
JingsongLi commented on pull request #15752: URL: https://github.com/apache/flink/pull/15752#issuecomment-826526971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [flink] ZhangChaoming commented on pull request #15749: [hotfix] Fix typo.

2021-04-25 Thread GitBox
ZhangChaoming commented on pull request #15749: URL: https://github.com/apache/flink/pull/15749#issuecomment-826292398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [flink] zjffdu commented on pull request #11895: [FLINK-10911][scala-shell] Enable flink-scala-shell with Scala 2.12

2021-04-25 Thread GitBox
zjffdu commented on pull request #11895: URL: https://github.com/apache/flink/pull/11895#issuecomment-826331433 @aalexandrov Thanks for looking into this issue, here's 2 tickets that are related https://issues.apache.org/jira/browse/SPARK-1199 https://issues.apache.org/jira/browse/SPA

[GitHub] [flink] flinkbot edited a comment on pull request #15752: [FLINK-19606][table-runtime-blink] Refactor JoinConditionWithFullFilters from an inner class in AbstractStreamingJoinOperator to a co

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15752: URL: https://github.com/apache/flink/pull/15752#issuecomment-826336806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink-statefun] tzulitai commented on pull request #229: [hotfix][docs] Fix typos in apache-kafka.md and aws-kinesis.md

2021-04-25 Thread GitBox
tzulitai commented on pull request #229: URL: https://github.com/apache/flink-statefun/pull/229#issuecomment-826494017 Thanks, merging this ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [flink] flinkbot edited a comment on pull request #15743: [FLINK-22444][docs] Drop async checkpoint description of state backends in Chinese docs

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15743: URL: https://github.com/apache/flink/pull/15743#issuecomment-826240774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] flinkbot edited a comment on pull request #15569: [FLINK-21247][table] Fix problem in MapDataSerializer#copy when there…

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15569: URL: https://github.com/apache/flink/pull/15569#issuecomment-817675895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] flinkbot edited a comment on pull request #15744: [FLINK-22113][table-planner-blink] Implement the column uniqueness checking for TableSourceTable

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15744: URL: https://github.com/apache/flink/pull/15744#issuecomment-826246674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] JingsongLi commented on a change in pull request #15479: [FLINK-19606][table-runtime-blink] Implement streaming window join operator

2021-04-25 Thread GitBox
JingsongLi commented on a change in pull request #15479: URL: https://github.com/apache/flink/pull/15479#discussion_r619741238 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecWindowJoin.java ## @

[GitHub] [flink] flinkbot edited a comment on pull request #15745: [FLINK-22304][table] Refactor some interfaces for TVF based window to…

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15745: URL: https://github.com/apache/flink/pull/15745#issuecomment-826249839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] galenwarren commented on a change in pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2021-04-25 Thread GitBox
galenwarren commented on a change in pull request #15599: URL: https://github.com/apache/flink/pull/15599#discussion_r619674758 ## File path: flink-filesystems/flink-gs-fs-hadoop/src/main/java/org/apache/flink/fs/gs/utils/BlobUtils.java ## @@ -0,0 +1,63 @@ +/* + * Licensed to

[GitHub] [flink] hameizi commented on pull request #15638: [FLINK-22272][table/catalog]Some scenes can't drop table by hive catalog

2021-04-25 Thread GitBox
hameizi commented on pull request #15638: URL: https://github.com/apache/flink/pull/15638#issuecomment-826234794 @KurtYoung Could you help review this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot edited a comment on pull request #15734: [FLINK-22424][network] Prevent releasing PipelinedSubpartition while Task can still write to it

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15734: URL: https://github.com/apache/flink/pull/15734#issuecomment-825656083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] JingsongLi commented on a change in pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2021-04-25 Thread GitBox
JingsongLi commented on a change in pull request #13459: URL: https://github.com/apache/flink/pull/13459#discussion_r619736459 ## File path: docs/content.zh/docs/connectors/table/filesystem.md ## @@ -149,15 +145,14 @@ a timeout that specifies the maximum duration for which a f

[GitHub] [flink] xuguangheng closed pull request #15700: [FLINK-22113][table-planner-blink] Implement the column uniqueness checking for TableSourceTable

2021-04-25 Thread GitBox
xuguangheng closed pull request #15700: URL: https://github.com/apache/flink/pull/15700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [flink] wydhcws commented on pull request #15742: [FLINK-22442][CEP] Fix Using scala api to change the TimeCharacteristic o…

2021-04-25 Thread GitBox
wydhcws commented on pull request #15742: URL: https://github.com/apache/flink/pull/15742#issuecomment-826180432 add the test in CEPScalaApiPatternStreamTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Assigned] (FLINK-22469) HistoryServer starts with NoSuchFileException

2021-04-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-22469: -- Assignee: Gabor Somogyi > HistoryServer starts with NoSuchFileException > ---

[GitHub] [flink] flinkbot edited a comment on pull request #15709: [FLINK-22356][hive / filesystem] Fix partition-time commit failure when watermark is defined on TIMESTAMP_LTZ column

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15709: URL: https://github.com/apache/flink/pull/15709#issuecomment-824111246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [flink] flinkbot commented on pull request #15742: [FLINK-22442][CEP] Using scala api to change the TimeCharacteristic o…

2021-04-25 Thread GitBox
flinkbot commented on pull request #15742: URL: https://github.com/apache/flink/pull/15742#issuecomment-826095835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [flink] godfreyhe commented on pull request #15479: [FLINK-19606][table-runtime-blink] Implement streaming window join operator

2021-04-25 Thread GitBox
godfreyhe commented on pull request #15479: URL: https://github.com/apache/flink/pull/15479#issuecomment-826225992 cc @JingsongLi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink] flinkbot commented on pull request #15762: [FLINK-22469][runtime-web] Fix NoSuchFileException in HistoryServer

2021-04-25 Thread GitBox
flinkbot commented on pull request #15762: URL: https://github.com/apache/flink/pull/15762#issuecomment-826547862 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot commented on pull request #15761: [FLINK-16077][docs-zh] Translate Custom State Serialization page into Chinese

2021-04-25 Thread GitBox
flinkbot commented on pull request #15761: URL: https://github.com/apache/flink/pull/15761#issuecomment-826546091 ## CI report: * 82a27a5093a81704448c370e7a29894b515b25fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Commented] (FLINK-22318) Support RENAME column name for ALTER TABLE statement

2021-04-25 Thread todd (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331781#comment-17331781 ] todd commented on FLINK-22318: -- Hi [~jark] mysql allows primary key column renaming,indexe

[GitHub] [flink-web] dianfu commented on a change in pull request #437: Add release 1.12.3 (blog post)

2021-04-25 Thread GitBox
dianfu commented on a change in pull request #437: URL: https://github.com/apache/flink-web/pull/437#discussion_r62914 ## File path: _config.yml ## @@ -58,32 +58,32 @@ flink_releases: - version_short: "1.12" binary_release: - name: "Apache Flink 1.12.2" +

[jira] [Comment Edited] (FLINK-22460) Conversion to relational algebra failed due to NOT NULL modifier

2021-04-25 Thread Haiwei Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331775#comment-17331775 ] Haiwei Zhou edited comment on FLINK-22460 at 4/26/21, 6:17 AM: ---

[jira] [Updated] (FLINK-22469) HistoryServer starts with NoSuchFileException

2021-04-25 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-22469: -- Affects Version/s: 1.14.0 > HistoryServer starts with NoSuchFileException > --

[jira] [Commented] (FLINK-22460) Conversion to relational algebra failed due to NOT NULL modifier

2021-04-25 Thread Haiwei Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331775#comment-17331775 ] Haiwei Zhou commented on FLINK-22460: - {code:java} Here is the output of "describe r

[jira] [Updated] (FLINK-22469) HistoryServer starts with NoSuchFileException

2021-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22469: --- Labels: pull-request-available (was: ) > HistoryServer starts with NoSuchFileException > --

[GitHub] [flink] gaborgsomogyi opened a new pull request #15762: [FLINK-22469][runtime-web] Fix NoSuchFileException in HistoryServer

2021-04-25 Thread GitBox
gaborgsomogyi opened a new pull request #15762: URL: https://github.com/apache/flink/pull/15762 ## What is the purpose of the change When history server started initially it throws the following exception: ``` 2021-04-23 23:25:17,487 ERROR org.apache.flink.runtime.webmonitor.hi

[GitHub] [flink-web] AHeise commented on pull request #437: Add release 1.12.3 (blog post)

2021-04-25 Thread GitBox
AHeise commented on pull request #437: URL: https://github.com/apache/flink-web/pull/437#issuecomment-826536674 > @AHeise I guess we should also update the following pages: > > * _config.yaml > > * q/gradle-quickstart.sh, q/quickstart-scala.sh, q/quickstart.sh, q/sbt-q

[jira] [Commented] (FLINK-18199) Translate "Filesystem SQL Connector" page into Chinese

2021-04-25 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331774#comment-17331774 ] Jingsong Lee commented on FLINK-18199: -- Fix via: master: 664b29d62e658415a3ca8fe37

[jira] [Updated] (FLINK-18199) Translate "Filesystem SQL Connector" page into Chinese

2021-04-25 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-18199: - Fix Version/s: 1.14.0 > Translate "Filesystem SQL Connector" page into Chinese > ---

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

2021-04-25 Thread GitBox
zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-826532014 > ``` > Scenarios like kerberos are difficult to cover through unit tests > ``` > > @zuston I'm not sure whether we need kerberos for this. E.g. is it possible to man

[GitHub] [flink] JingsongLi merged pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2021-04-25 Thread GitBox
JingsongLi merged pull request #13459: URL: https://github.com/apache/flink/pull/13459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[jira] [Updated] (FLINK-22446) Relocate dependencies in hive connector uber jar

2021-04-25 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-22446: --- Issue Type: Improvement (was: Task) > Relocate dependencies in hive connector uber jar > --

[jira] [Updated] (FLINK-22469) HistoryServer starts with NoSuchFileException

2021-04-25 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-22469: -- Description: When history server started initially it throws the following exception: {code:ja

[GitHub] [flink] flinkbot commented on pull request #15761: [FLINK-16077][docs-zh] Translate Custom State Serialization page into Chinese

2021-04-25 Thread GitBox
flinkbot commented on pull request #15761: URL: https://github.com/apache/flink/pull/15761#issuecomment-826529276 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] klion26 commented on pull request #12287: [FLINK-16077][docs-zh] Translate Custom State Serialization page into Chinese

2021-04-25 Thread GitBox
klion26 commented on pull request #12287: URL: https://github.com/apache/flink/pull/12287#issuecomment-826529177 @carp84 I'll create a new pr(#15761) for this issue and close this one, please take a look when you're free, sorry for the inconvenience -- This is an automated message from t

[jira] [Updated] (FLINK-22318) Support RENAME column name for ALTER TABLE statement

2021-04-25 Thread todd (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] todd updated FLINK-22318: - Attachment: (was: image-2021-04-26-13-58-19-302.png) > Support RENAME column name for ALTER TABLE statement

[jira] [Updated] (FLINK-22318) Support RENAME column name for ALTER TABLE statement

2021-04-25 Thread todd (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] todd updated FLINK-22318: - Attachment: image-2021-04-26-13-58-19-302.png > Support RENAME column name for ALTER TABLE statement > -

[GitHub] [flink] klion26 closed pull request #12287: [FLINK-16077][docs-zh] Translate Custom State Serialization page into Chinese

2021-04-25 Thread GitBox
klion26 closed pull request #12287: URL: https://github.com/apache/flink/pull/12287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [flink] JingsongLi commented on pull request #15752: [FLINK-19606][table-runtime-blink] Refactor JoinConditionWithFullFilters from an inner class in AbstractStreamingJoinOperator to a common

2021-04-25 Thread GitBox
JingsongLi commented on pull request #15752: URL: https://github.com/apache/flink/pull/15752#issuecomment-826527975 I recommend you configure it: https://ci.apache.org/projects/flink/flink-docs-master/docs/flinkdev/ide_setup/#code-formatting -- This is an automated message from the Ap

[GitHub] [flink] klion26 opened a new pull request #15761: [FLINK-16077][docs-zh] Translate Custom State Serialization page into Chinese

2021-04-25 Thread GitBox
klion26 opened a new pull request #15761: URL: https://github.com/apache/flink/pull/15761 ## What is the purpose of the change Translate Custom State Serialization page into Chinese ## Verifying this change This change is a trivial rework / code cleanup without any t

[GitHub] [flink] lirui-apache commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

2021-04-25 Thread GitBox
lirui-apache commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-826527360 ``` Scenarios like kerberos are difficult to cover through unit tests ``` @zuston I'm not sure whether we need kerberos for this. E.g. is it possible to manually cr

[GitHub] [flink] JingsongLi commented on pull request #15752: [FLINK-19606][table-runtime-blink] Refactor JoinConditionWithFullFilters from an inner class in AbstractStreamingJoinOperator to a common

2021-04-25 Thread GitBox
JingsongLi commented on pull request #15752: URL: https://github.com/apache/flink/pull/15752#issuecomment-826526971 @beyond1920 Compile failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Created] (FLINK-22469) HistoryServer starts with NoSuchFileException

2021-04-25 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-22469: - Summary: HistoryServer starts with NoSuchFileException Key: FLINK-22469 URL: https://issues.apache.org/jira/browse/FLINK-22469 Project: Flink Issue Type: B

[GitHub] [flink] flinkbot edited a comment on pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #13459: URL: https://github.com/apache/flink/pull/13459#issuecomment-697158140 ## CI report: * 01e3a241fd858bb5c13bdd481f9659524f043abf UNKNOWN * dff3d40e963077fe2b8da5f4249090f702555008 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #15760: [FLINK-19606][table-runtime-blink] Introduce WindowJoinOperator and WindowJoinOperatorBuilder.

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15760: URL: https://github.com/apache/flink/pull/15760#issuecomment-826500326 ## CI report: * 1d43ce7ad5aa1b1a53be0e304b1d5b9ed477c3b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15757: [FLINK-22445][python][docs] Add more examples of row-based operations in PyFlink doc

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15757: URL: https://github.com/apache/flink/pull/15757#issuecomment-826471744 ## CI report: * 3e0d896b418ab77a46cd6333dd512d034b56c30e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15749: [hotfix][docs] Fix typo.

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15749: URL: https://github.com/apache/flink/pull/15749#issuecomment-826274666 ## CI report: * 6badad7b096fc3c49603f6af520b876e3b8cf51f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-22468) Make StateFun build with Java 11

2021-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-22468: --- Labels: pull-request-available (was: ) > Make StateFun build with Java 11 > ---

[GitHub] [flink-statefun] tzulitai opened a new pull request #230: [FLINK-22468] Fix Java 11 build by adding dependency to javax.annotations

2021-04-25 Thread GitBox
tzulitai opened a new pull request #230: URL: https://github.com/apache/flink-statefun/pull/230 This enables building StateFun with Java 11, since javax.annotations was removed with JDK 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] michaelli916 commented on a change in pull request #13459: [FLINK-18199] [chinese-translation]: translate FileSystem SQL Connector page into Chinese

2021-04-25 Thread GitBox
michaelli916 commented on a change in pull request #13459: URL: https://github.com/apache/flink/pull/13459#discussion_r619975027 ## File path: docs/content.zh/docs/connectors/table/filesystem.md ## @@ -217,13 +206,15 @@ To define when to commit a partition, providing partition

[GitHub] [flink] flinkbot commented on pull request #15760: [FLINK-19606][table-runtime-blink] Introduce WindowJoinOperator and WindowJoinOperatorBuilder.

2021-04-25 Thread GitBox
flinkbot commented on pull request #15760: URL: https://github.com/apache/flink/pull/15760#issuecomment-826500326 ## CI report: * 1d43ce7ad5aa1b1a53be0e304b1d5b9ed477c3b7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #15759: [FLINK-22463][table-planner-blink] Fix IllegalArgumentException in WindowAttachedWindowingStrategy when two phase is enabled for dist

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15759: URL: https://github.com/apache/flink/pull/15759#issuecomment-826494695 ## CI report: * 99b2ac7e2b6705a1bf3b2d087c399bce199380ee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #15752: [FLINK-19606][table-runtime-blink] Refactor JoinConditionWithFullFilters from an inner class in AbstractStreamingJoinOperator to a co

2021-04-25 Thread GitBox
flinkbot edited a comment on pull request #15752: URL: https://github.com/apache/flink/pull/15752#issuecomment-826336806 ## CI report: * e813ef5fd32db0aff193e39eaae067601695fde2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

  1   2   3   4   5   >