[GitHub] [flink] flinkbot edited a comment on pull request #14738: [FLINK-20947][planner] Fix idle source doesn't work when pushing watermark into the source

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14738: URL: https://github.com/apache/flink/pull/14738#issuecomment-766300412 ## CI report: * ee016150b9a4dce6af1f3e060c4c0708fcfb0940 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-766281483 ## CI report: * 399f06e14079a512d35814508b6f7598d7d175ba Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14738: [FLINK-20947][planner] Fix idle source doesn't work when pushing watermark into the source

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14738: URL: https://github.com/apache/flink/pull/14738#issuecomment-766300412 ## CI report: * ee016150b9a4dce6af1f3e060c4c0708fcfb0940 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #14738: [FLINK-20947][planner] Fix idle source doesn't work when pushing watermark into the source

2021-01-23 Thread GitBox
flinkbot commented on pull request #14738: URL: https://github.com/apache/flink/pull/14738#issuecomment-766300412 ## CI report: * ee016150b9a4dce6af1f3e060c4c0708fcfb0940 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot commented on pull request #14738: [FLINK-20947][planner] Fix idle source doesn't work when pushing watermark into the source

2021-01-23 Thread GitBox
flinkbot commented on pull request #14738: URL: https://github.com/apache/flink/pull/14738#issuecomment-766299296 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] fsk119 opened a new pull request #14738: [FLINK-20947][planner] Fix idle source doesn't work when pushing watermark into the source

2021-01-23 Thread GitBox
fsk119 opened a new pull request #14738: URL: https://github.com/apache/flink/pull/14738 ## What is the purpose of the change *Fix idle source doesn't work when pushing watermark strategy into table source.* ## Brief change log - *Fix the bug.* ## V

[jira] [Closed] (FLINK-21107) Move test base classes from flink-tests to flink-test-utils

2021-01-23 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenqiu Huang closed FLINK-21107. - Resolution: Won't Fix > Move test base classes from flink-tests to flink-test-utils > --

[jira] [Created] (FLINK-21107) Move test base classes from flink-tests to flink-test-utils

2021-01-23 Thread Zhenqiu Huang (Jira)
Zhenqiu Huang created FLINK-21107: - Summary: Move test base classes from flink-tests to flink-test-utils Key: FLINK-21107 URL: https://issues.apache.org/jira/browse/FLINK-21107 Project: Flink

[GitHub] [flink-shaded] HuangXingBo edited a comment on pull request #93: [FLINK-21020][jackson] Bump version to 2.12.1

2021-01-23 Thread GitBox
HuangXingBo edited a comment on pull request #93: URL: https://github.com/apache/flink-shaded/pull/93#issuecomment-765901405 I have tested this flink-shaded version with flink (master version and release-1.12) in my private Azure. the test commit in master: https://github.com/HuangXingB

[GitHub] [flink] flinkbot edited a comment on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-766281483 ## CI report: * 399f06e14079a512d35814508b6f7598d7d175ba Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-766281483 ## CI report: * 399f06e14079a512d35814508b6f7598d7d175ba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-01-23 Thread GitBox
flinkbot commented on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-766281483 ## CI report: * 399f06e14079a512d35814508b6f7598d7d175ba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] wuchong commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese

2021-01-23 Thread GitBox
wuchong commented on pull request #14710: URL: https://github.com/apache/flink/pull/14710#issuecomment-766280734 cc @fsk119 , could you help to review this PR? This is an automated message from the Apache Git Service. To resp

[GitHub] [flink] wuchong commented on a change in pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
wuchong commented on a change in pull request #14735: URL: https://github.com/apache/flink/pull/14735#discussion_r563227615 ## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/runtime/stream/table/TimeAttributesITCase.scala ## @@ -0

[GitHub] [flink] wuchong commented on a change in pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
wuchong commented on a change in pull request #14735: URL: https://github.com/apache/flink/pull/14735#discussion_r563227674 ## File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/runtime/stream/table/TimeAttributesITCase.scala ## @@ -0

[GitHub] [flink] flinkbot commented on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-01-23 Thread GitBox
flinkbot commented on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-766279661 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] mohitpali opened a new pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-01-23 Thread GitBox
mohitpali opened a new pull request #14737: URL: https://github.com/apache/flink/pull/14737 ## What is the purpose of the change _The AWS Glue Schema Registry is a new feature of AWS Glue that allows you to centrally discover, control, and evolve data stream schemas. This request

[GitHub] [flink] RocMarshal commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese

2021-01-23 Thread GitBox
RocMarshal commented on pull request #14710: URL: https://github.com/apache/flink/pull/14710#issuecomment-766276114 @wuchong Could you help me to review this PR? Thank you. This is an automated message from the Apache Git

[GitHub] [flink] flinkbot edited a comment on pull request #14736: [FLINK-21104][network] Ensure that converted input channels start in the correct persisting state.

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14736: URL: https://github.com/apache/flink/pull/14736#issuecomment-766158250 ## CI report: * ea16029a49bbd0716dd2f0c4c4d8fc43e957c316 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-21106) google-java-format Intellij Plugin 1.7.0.5 causes UnsupportedOperationException in IntelliJ

2021-01-23 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias updated FLINK-21106: - Description: There's a problem with {{google-java-format}} Intellij plugin version {{1.7.0.5}} that cau

[jira] [Assigned] (FLINK-21104) UnalignedCheckpointITCase.execute failed with "IllegalStateException"

2021-01-23 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise reassigned FLINK-21104: --- Assignee: Arvid Heise > UnalignedCheckpointITCase.execute failed with "IllegalStateExceptio

[jira] [Commented] (FLINK-21106) google-java-format Intellij Plugin 1.7.0.5 causes UnsupportedOperationException in IntelliJ

2021-01-23 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270736#comment-17270736 ] Matthias commented on FLINK-21106: -- I worked around the issue for now by applying the p

[jira] [Updated] (FLINK-21106) google-java-format Intellij Plugin 1.7.0.5 causes UnsupportedOperationException in IntelliJ

2021-01-23 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias updated FLINK-21106: - Attachment: google-java-format.zip > google-java-format Intellij Plugin 1.7.0.5 causes > UnsupportedOpe

[jira] [Created] (FLINK-21106) google-java-format Intellij Plugin 1.7.0.5 causes UnsupportedOperationException in IntelliJ

2021-01-23 Thread Matthias (Jira)
Matthias created FLINK-21106: Summary: google-java-format Intellij Plugin 1.7.0.5 causes UnsupportedOperationException in IntelliJ Key: FLINK-21106 URL: https://issues.apache.org/jira/browse/FLINK-21106 P

[GitHub] [flink] flinkbot edited a comment on pull request #14736: [FLINK-21104][network] Ensure that converted input channels start in the correct persisting state.

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14736: URL: https://github.com/apache/flink/pull/14736#issuecomment-766158250 ## CI report: * ea16029a49bbd0716dd2f0c4c4d8fc43e957c316 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14735: URL: https://github.com/apache/flink/pull/14735#issuecomment-766094970 ## CI report: * 95137f07f2172150b444e9d3e4ce0b5cece22e2d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14734: URL: https://github.com/apache/flink/pull/14734#issuecomment-766092219 ## CI report: * 721dd38bb286722cbb1a6925dbedbb3614930b20 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #14736: [FLINK-21104][network] Ensure that converted input channels start in the correct persisting state.

2021-01-23 Thread GitBox
flinkbot commented on pull request #14736: URL: https://github.com/apache/flink/pull/14736#issuecomment-766158250 ## CI report: * ea16029a49bbd0716dd2f0c4c4d8fc43e957c316 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Updated] (FLINK-21104) UnalignedCheckpointITCase.execute failed with "IllegalStateException"

2021-01-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21104: --- Labels: pull-request-available test-stability (was: test-stability) > UnalignedCheckpointIT

[GitHub] [flink] flinkbot commented on pull request #14736: [FLINK-21104][network] Ensure that converted input channels start in the correct persisting state.

2021-01-23 Thread GitBox
flinkbot commented on pull request #14736: URL: https://github.com/apache/flink/pull/14736#issuecomment-766156866 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] AHeise opened a new pull request #14736: [FLINK-20654][network] Ensure that converted input channels start in the correct persisting state.

2021-01-23 Thread GitBox
AHeise opened a new pull request #14736: URL: https://github.com/apache/flink/pull/14736 ## What is the purpose of the change When a checkpoint is aborted, the ChannelStatePersister of an input channel is stopped for that checkpoint. A barrier that arrives after that is si

[GitHub] [flink] flinkbot edited a comment on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14735: URL: https://github.com/apache/flink/pull/14735#issuecomment-766094970 ## CI report: * 235d61be4bb5ed158c109a11de845f73c077c0fe Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14735: URL: https://github.com/apache/flink/pull/14735#issuecomment-766094970 ## CI report: * 235d61be4bb5ed158c109a11de845f73c077c0fe Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * de291068835c9b7540c3a0544c6dd589f0c3ada2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-web] AHeise merged pull request #414: Add a warning for corrupt unaligned checkpoints in 1.12 release blog post.

2021-01-23 Thread GitBox
AHeise merged pull request #414: URL: https://github.com/apache/flink-web/pull/414 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink] flinkbot edited a comment on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14735: URL: https://github.com/apache/flink/pull/14735#issuecomment-766094970 ## CI report: * 235d61be4bb5ed158c109a11de845f73c077c0fe Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-762224447 ## CI report: * f26efadf325bb52d3bc8b2711fc83a169ad61ca5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14734: URL: https://github.com/apache/flink/pull/14734#issuecomment-766092219 ## CI report: * 721dd38bb286722cbb1a6925dbedbb3614930b20 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot commented on pull request #14735: URL: https://github.com/apache/flink/pull/14735#issuecomment-766094970 ## CI report: * 235d61be4bb5ed158c109a11de845f73c077c0fe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-762224447 ## CI report: * 5ddc226c2aa4fd063cc173a65eb887f9ac0247ba Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot commented on pull request #14735: URL: https://github.com/apache/flink/pull/14735#issuecomment-766092304 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] anlen321 commented on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-23 Thread GitBox
anlen321 commented on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-766092286 Hi @leonardBang I have submitted the new commit, please help to review it.thanks! This is an automated message

[GitHub] [flink] flinkbot commented on pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-23 Thread GitBox
flinkbot commented on pull request #14734: URL: https://github.com/apache/flink/pull/14734#issuecomment-766092219 ## CI report: * 721dd38bb286722cbb1a6925dbedbb3614930b20 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-762224447 ## CI report: * 5ddc226c2aa4fd063cc173a65eb887f9ac0247ba Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] anlen321 removed a comment on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-23 Thread GitBox
anlen321 removed a comment on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-766091231 > I'll take a look this PR, @wuchong . > > @anlen321 Looks like you fixed the conflicts with `git merge` command, it's recommended to use `git rebase master` comm

[GitHub] [flink] anlen321 commented on pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-23 Thread GitBox
anlen321 commented on pull request #14684: URL: https://github.com/apache/flink/pull/14684#issuecomment-766091231 > I'll take a look this PR, @wuchong . > > @anlen321 Looks like you fixed the conflicts with `git merge` command, it's recommended to use `git rebase master` command to f

[GitHub] [flink] anlen321 closed pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-01-23 Thread GitBox
anlen321 closed pull request #14684: URL: https://github.com/apache/flink/pull/14684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] YuvalItzchakov commented on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on pull request #14735: URL: https://github.com/apache/flink/pull/14735#issuecomment-766090546 @wuchong Please re-check. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [flink] YuvalItzchakov opened a new pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov opened a new pull request #14735: URL: https://github.com/apache/flink/pull/14735 Fix an erroneous NPE created when using a table from a DataStream that did not assign timestamps and watermarks ## Brief change log - Fix direct access to `ctx.timestamp()`, va

[GitHub] [flink] YuvalItzchakov commented on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-766089520 @wuchong I'm going to re-open this PR under a fresh branch. This is an automated message from the Apache

[GitHub] [flink] YuvalItzchakov closed pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov closed pull request #14633: URL: https://github.com/apache/flink/pull/14633 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on a change in pull request #14633: URL: https://github.com/apache/flink/pull/14633#discussion_r563159502 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -909,6 +908,62

[GitHub] [flink] flinkbot commented on pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-23 Thread GitBox
flinkbot commented on pull request #14734: URL: https://github.com/apache/flink/pull/14734#issuecomment-766088540 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-21066) Refactor the CheckpointCoordinator to compute the tasks to trigger/wait/commit dynamically

2021-01-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21066: --- Labels: pull-request-available (was: ) > Refactor the CheckpointCoordinator to compute the

[GitHub] [flink] gaoyunhaii opened a new pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-23 Thread GitBox
gaoyunhaii opened a new pull request #14734: URL: https://github.com/apache/flink/pull/14734 ## What is the purpose of the change This PR refactors the CheckpointCoordinator logic to compute the tasks to trigger/wait/commit dynamically. Previously it is done during compile phase and

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-759451108 ## CI report: * 4740cf1d2d0a16700698f5f2108ee4a310d942dd UNKNOWN * b0e28744da86b772436f806aa24a99f5e7581b6b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on a change in pull request #14633: URL: https://github.com/apache/flink/pull/14633#discussion_r563158546 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -909,6 +908,62

[jira] [Commented] (FLINK-21104) UnalignedCheckpointITCase.execute failed with "IllegalStateException"

2021-01-23 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270662#comment-17270662 ] Arvid Heise commented on FLINK-21104: - Looking into it. > UnalignedCheckpointITCase

[GitHub] [flink] wuchong commented on a change in pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
wuchong commented on a change in pull request #14633: URL: https://github.com/apache/flink/pull/14633#discussion_r563157652 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -909,6 +908,62 @@ obj

[GitHub] [flink] flinkbot edited a comment on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-759451108 ## CI report: * 4740cf1d2d0a16700698f5f2108ee4a310d942dd UNKNOWN * b0e28744da86b772436f806aa24a99f5e7581b6b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on a change in pull request #14633: URL: https://github.com/apache/flink/pull/14633#discussion_r563156638 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -512,18 +512,2

[GitHub] [flink] wuchong commented on a change in pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
wuchong commented on a change in pull request #14633: URL: https://github.com/apache/flink/pull/14633#discussion_r563155612 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -512,18 +512,21 @@ ob

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov edited a comment on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-766080388 @wuchong Apparently not all interfaces of `Context` support `element`. I refactored the code to just do a `null` check on the returned timestamp. Can you please re

[GitHub] [flink] YuvalItzchakov commented on a change in pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on a change in pull request #14633: URL: https://github.com/apache/flink/pull/14633#discussion_r563155265 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -512,18 +512,2

[GitHub] [flink] wuchong commented on a change in pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
wuchong commented on a change in pull request #14633: URL: https://github.com/apache/flink/pull/14633#discussion_r563155187 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala ## @@ -512,18 +512,21 @@ ob

[GitHub] [flink] flinkbot edited a comment on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-759451108 ## CI report: * 4740cf1d2d0a16700698f5f2108ee4a310d942dd UNKNOWN * b0e28744da86b772436f806aa24a99f5e7581b6b Azure: [FAILURE](https://dev.azure.com/apache-fl

[GitHub] [flink] YuvalItzchakov commented on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-766081220 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-20947) Idle source doesn't work when pushing watermark into the source

2021-01-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-20947: Summary: Idle source doesn't work when pushing watermark into the source (was: Unable to trigger Hive par

[GitHub] [flink] YuvalItzchakov edited a comment on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov edited a comment on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-766080388 @wuchong Apparently not all interfaces of `Context` support `hasTimestamp`. I refactored the code to just do a `null` check on the returned timestamp. Can you plea

[GitHub] [flink] YuvalItzchakov commented on pull request #14633: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

2021-01-23 Thread GitBox
YuvalItzchakov commented on pull request #14633: URL: https://github.com/apache/flink/pull/14633#issuecomment-766080388 @wuchong Apparently not all interfaces of `Context` support `hasTimestamp`. I refactored the code to just do a `null` check on the returned timestamp. --

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * ef5b18453605da53ca9c9ce0c7fce9b7361f67a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-shaded] HuangXingBo commented on pull request #93: [FLINK-21020][jackson] Bump version to 2.12.1

2021-01-23 Thread GitBox
HuangXingBo commented on pull request #93: URL: https://github.com/apache/flink-shaded/pull/93#issuecomment-765901405 I have tested this flink-shaded version with flink (master version) in my private Azure. the test commit: https://github.com/HuangXingBo/flink/commit/554cecd092594e155a7

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Created] (FLINK-21105) Rename ExecEdge to InputProperty

2021-01-23 Thread godfrey he (Jira)
godfrey he created FLINK-21105: -- Summary: Rename ExecEdge to InputProperty Key: FLINK-21105 URL: https://issues.apache.org/jira/browse/FLINK-21105 Project: Flink Issue Type: Sub-task C

[jira] [Updated] (FLINK-20435) Refactor ExecNode and ExecEdge

2021-01-23 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-20435: --- Description: Currently, there are many improvements about ExecNode: 1. simplify type parameter of {{

[jira] [Updated] (FLINK-20435) Refactor ExecNode and ExecEdge

2021-01-23 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-20435: --- Description: Currently, there are many improvements about ExecNode: 1. simplify type parameter of {{

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-20435) Refactor ExecNode and ExecEdge

2021-01-23 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-20435: --- Summary: Refactor ExecNode and ExecEdge (was: Refactor ExecNode) > Refactor ExecNode and ExecEdge >

[GitHub] [flink] flinkbot edited a comment on pull request #13377: [FLINK-18592] bugfix for StreamingFileSink

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #13377: URL: https://github.com/apache/flink/pull/13377#issuecomment-691669199 ## CI report: * e50494c67acde3b849686106cf926a28f1b32685 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * 35ecb423c9f73b3797455995731e29b72a380e88 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-21036) Consider removing automatic configuration fo number of slots from docker

2021-01-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270590#comment-17270590 ] Yang Wang commented on FLINK-21036: --- For Kubernetes use case, we suggest our users to

[GitHub] [flink] flinkbot edited a comment on pull request #13377: [FLINK-18592] bugfix for StreamingFileSink

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #13377: URL: https://github.com/apache/flink/pull/13377#issuecomment-691669199 ## CI report: * 5133b8e8e8ab5c63b96f23b024ebef1252f5d128 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] wangjian2019 commented on pull request #13377: [FLINK-18592] bugfix for StreamingFileSink

2021-01-23 Thread GitBox
wangjian2019 commented on pull request #13377: URL: https://github.com/apache/flink/pull/13377#issuecomment-765889444 resolve conflict This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink] flinkbot commented on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot commented on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765889414 ## CI report: * 35ecb423c9f73b3797455995731e29b72a380e88 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #14729: [FLINK-21092][FLINK-21093][FLINK-21094][FLINK-21096][table-planner-blink] Support ExecNode plan serialization/deserialization for `IN

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14729: URL: https://github.com/apache/flink/pull/14729#issuecomment-765399004 ## CI report: * ef724e57e7676c154c8f0d6da93a811e9d411051 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14729: [FLINK-21092][FLINK-21093][FLINK-21094][FLINK-21096][table-planner-blink] Support ExecNode plan serialization/deserialization for `IN

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14729: URL: https://github.com/apache/flink/pull/14729#issuecomment-765399004 ## CI report: * ef724e57e7676c154c8f0d6da93a811e9d411051 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14732: Release 1.12 The Flink task was committed to YARN, but the prompt(NoSuchMethod:Lorg/apache/hadoop/security/UserGroupInformation) fail

2021-01-23 Thread GitBox
flinkbot edited a comment on pull request #14732: URL: https://github.com/apache/flink/pull/14732#issuecomment-765882051 ## CI report: * b866f88656da7ca5f6b962c234f7c2a07d58fe99 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] godfreyhe commented on pull request #14729: [FLINK-21092][FLINK-21093][FLINK-21094][FLINK-21096][table-planner-blink] Support ExecNode plan serialization/deserialization for `INSERT I

2021-01-23 Thread GitBox
godfreyhe commented on pull request #14729: URL: https://github.com/apache/flink/pull/14729#issuecomment-765887150 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink] flinkbot commented on pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
flinkbot commented on pull request #14733: URL: https://github.com/apache/flink/pull/14733#issuecomment-765886914 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Updated] (FLINK-20968) Remove legacy exec nodes

2021-01-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20968: --- Labels: pull-request-available (was: ) > Remove legacy exec nodes > ---

[GitHub] [flink] godfreyhe opened a new pull request #14733: [FLINK-20968][table-planner-blink] Remove legacy exec nodes

2021-01-23 Thread GitBox
godfreyhe opened a new pull request #14733: URL: https://github.com/apache/flink/pull/14733 ## What is the purpose of the change *Since all exec node do not extend from LegacyExecNodeBase, we can remove them (LegacyExecNodeBase, LegacyBatchExecNode and LegacyStreamExecNode). And

[jira] [Updated] (FLINK-21096) Introduce ExecNodeGraphJsonPlanGenerator to serialize ExecNodeGraph to json plan and deserialize json plan to ExecNodeGraph

2021-01-23 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-21096: --- Description: ExecNodeGraphJsonPlanGenerator is an utility class that can generate json plan based o

[jira] [Updated] (FLINK-21096) Introduce ExecNodeGraphJsonPlanGenerator to serialize ExecNodeGraph to json plan and deserialize json plan to ExecNodeGraph

2021-01-23 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-21096: --- Description: ExecNodeGraphJsonPlanGenerator is an utility class that can generate json plan based o