[GitHub] [flink] flinkbot commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-05 Thread GitBox
flinkbot commented on issue #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843#issuecomment-538717105 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14296: --- Labels: pull-request-available (was: ) > SqlNodes in the parser module should use an Option

[GitHub] [flink] buptljy opened a new pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module

2019-10-05 Thread GitBox
buptljy opened a new pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module URL: https://github.com/apache/flink/pull/9843 ## Brief change log - partitionKeyList / columnList / propertyList cannot be null because we initialize them as Sql

[jira] [Comment Edited] (FLINK-14306) flink-python build fails with No module named pkg_resources

2019-10-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945259#comment-16945259 ] Piotr Nowojski edited comment on FLINK-14306 at 10/6/19 6:38 AM: -

[jira] [Commented] (FLINK-14306) flink-python build fails with No module named pkg_resources

2019-10-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945259#comment-16945259 ] Piotr Nowojski commented on FLINK-14306: >From my perspective there is no need t

[GitHub] [flink] xintongsong commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-05 Thread GitBox
xintongsong commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r331772413 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutorR

[GitHub] [flink] xintongsong commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-05 Thread GitBox
xintongsong commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#discussion_r331772405 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutorR

[GitHub] [flink] flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#issuecomment-538594244 ## CI report: * 3560d8fdf99dc8140520bf195a09171708c1c241 : FAILURE [Build](https://travis-ci.com/f

[GitHub] [flink] flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#issuecomment-538594244 ## CI report: * 3560d8fdf99dc8140520bf195a09171708c1c241 : FAILURE [Build](https://travis-ci.com/f

[jira] [Comment Edited] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-05 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945233#comment-16945233 ] Jiayi Liao edited comment on FLINK-14296 at 10/6/19 3:25 AM: -

[GitHub] [flink] flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#issuecomment-538594244 ## CI report: * 3560d8fdf99dc8140520bf195a09171708c1c241 : FAILURE [Build](https://travis-ci.com/f

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-05 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945233#comment-16945233 ] Jiayi Liao commented on FLINK-14296: [~jark] > SqlNodes in the parser module should

[jira] [Comment Edited] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-05 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945233#comment-16945233 ] Jiayi Liao edited comment on FLINK-14296 at 10/6/19 3:12 AM: -

[GitHub] [flink] mr-cloud commented on a change in pull request #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
mr-cloud commented on a change in pull request #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#discussion_r331768873 ## File path: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/userjar/UserJarDfsTe

[GitHub] [flink] wuchong commented on a change in pull request #9823: [FLINK-14273][Table]Add accumulator type to actual type list in AggSqlFunction

2019-10-05 Thread GitBox
wuchong commented on a change in pull request #9823: [FLINK-14273][Table]Add accumulator type to actual type list in AggSqlFunction URL: https://github.com/apache/flink/pull/9823#discussion_r331768610 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/fli

[jira] [Commented] (FLINK-14201) SQL supports redis sink connector

2019-10-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945227#comment-16945227 ] Jark Wu commented on FLINK-14201: - Hi [~xcyu], I would suggest to take {{Elasticsearch6U

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945224#comment-16945224 ] Jark Wu commented on FLINK-14296: - I agree with [~wind_ljy]. {{SqlNodeList}} is a List o

[jira] [Resolved] (FLINK-13382) Port DecimalITCase to unit tests

2019-10-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13382. - Resolution: Fixed 1.10.0: a110cec19c5770fadfc460a8ef4d351a3593190a > Port DecimalITCase to unit tests >

[GitHub] [flink] wuchong closed pull request #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests

2019-10-05 Thread GitBox
wuchong closed pull request #9669: [FLINK-13382] [Table SQL / Planner] Port DecimalITCase to unit tests URL: https://github.com/apache/flink/pull/9669 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [flink] HuangZhenQiu commented on a change in pull request #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
HuangZhenQiu commented on a change in pull request #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#discussion_r331763909 ## File path: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/userjar/UserJarD

[jira] [Updated] (FLINK-14328) JobCluster cannot reach TaskManager in K8s

2019-10-05 Thread Tim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim updated FLINK-14328: Description: I have a Job Cluster which I am running in K8s.  It consists of * job manager deployment (1) * task

[jira] [Created] (FLINK-14328) JobCluster cannot reach TaskManager in K8s

2019-10-05 Thread Tim (Jira)
Tim created FLINK-14328: --- Summary: JobCluster cannot reach TaskManager in K8s Key: FLINK-14328 URL: https://issues.apache.org/jira/browse/FLINK-14328 Project: Flink Issue Type: Bug Reporter

[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032 ## CI report: * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE [Build](htt

[GitHub] [flink] carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#discussion_r331758223 ## File path: flink-state-backends/flink-statebackend-heap-spillable/src

[GitHub] [flink] carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#discussion_r331757816 ## File path: flink-state-backends/flink-statebackend-heap-spillable/src

[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032 ## CI report: * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE [Build](htt

[GitHub] [flink] carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
carp84 commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#discussion_r331757081 ## File path: flink-state-backends/flink-statebackend-heap-spillable/src

[GitHub] [flink] carp84 commented on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
carp84 commented on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-538676755 > Why would this be the case? The only accessing threads should be the Task's main thread and the

[GitHub] [flink] flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-523769032 ## CI report: * 6107a00876759dcef075592c8bfa56764f66b6fa : FAILURE [Build](htt

[GitHub] [flink] carp84 edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
carp84 edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-538673672 > Where exactly do I see the performance comparison? Allow me to quote the conclusion

[GitHub] [flink] carp84 edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
carp84 edited a comment on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-538673672 > Where exactly do I see the performance comparison? Allow me to quote the conclusion

[GitHub] [flink] carp84 commented on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend

2019-10-05 Thread GitBox
carp84 commented on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-538673672 > Where exactly do I see the performance comparison? Allow me to quote the conclusion: "we need

[jira] [Resolved] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese

2019-10-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13037. - Fix Version/s: 1.10.0 Resolution: Fixed 1.10.0: 503ae365437e4cb7580defd7e8e26b72d5beeb18 > Trans

[GitHub] [flink] wuchong closed pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese

2019-10-05 Thread GitBox
wuchong closed pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] wuchong commented on issue #9781: [FLINK-14098] Support multiple statements for TableEnvironment.

2019-10-05 Thread GitBox
wuchong commented on issue #9781: [FLINK-14098] Support multiple statements for TableEnvironment. URL: https://github.com/apache/flink/pull/9781#issuecomment-538658103 > allow multiline statements in sqlQuery() or not ? I agree with @zhengcanbin that allowing multi-statements in `sqlQuer

[GitHub] [flink] wuchong edited a comment on issue #9781: [FLINK-14098] Support multiple statements for TableEnvironment.

2019-10-05 Thread GitBox
wuchong edited a comment on issue #9781: [FLINK-14098] Support multiple statements for TableEnvironment. URL: https://github.com/apache/flink/pull/9781#issuecomment-538658103 > allow multiline statements in sqlQuery() or not ? I agree with @zhengcanbin that allowing multi-statements

[GitHub] [flink] wuchong commented on a change in pull request #9781: [FLINK-14098] Support multiple statements for TableEnvironment.

2019-10-05 Thread GitBox
wuchong commented on a change in pull request #9781: [FLINK-14098] Support multiple statements for TableEnvironment. URL: https://github.com/apache/flink/pull/9781#discussion_r331749718 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/P

[jira] [Resolved] (FLINK-14117) Translate changes on index page to Chinese

2019-10-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-14117. - Fix Version/s: 1.10.0 Resolution: Fixed 1.10.0: https://github.com/apache/flink/commit/fdfa03bd2

[GitHub] [flink] wuchong merged pull request #9815: [FLINK-14117][docs-zh] Translate changes on index page to Chinese

2019-10-05 Thread GitBox
wuchong merged pull request #9815: [FLINK-14117][docs-zh] Translate changes on index page to Chinese URL: https://github.com/apache/flink/pull/9815 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-11046) ElasticSearch6Connector cause thread blocked when index failed with retry

2019-10-05 Thread Suxing Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945072#comment-16945072 ] Suxing Lee commented on FLINK-11046: Another situation that can lead to deadlock is

[GitHub] [flink] wuchong commented on a change in pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese

2019-10-05 Thread GitBox
wuchong commented on a change in pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763#discussion_r331749024 ## File path: docs/concepts/glossary.zh.md ## @@ -25,142 +25,92 @@ under the

[GitHub] [flink] wuchong commented on a change in pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese

2019-10-05 Thread GitBox
wuchong commented on a change in pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763#discussion_r331748922 ## File path: docs/concepts/glossary.zh.md ## @@ -25,142 +25,92 @@ under the

[GitHub] [flink] flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#issuecomment-538594244 ## CI report: * 3560d8fdf99dc8140520bf195a09171708c1c241 : FAILURE [Build](https://travis-ci.com/f

[GitHub] [flink] mr-cloud commented on issue #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
mr-cloud commented on issue #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#issuecomment-538639711 The CI reports a build failure because of the lack of licenses for some files. I added licenses for them now. Please

[GitHub] [flink] flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment.

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9841: [FLINK-14319][api] Register user jar files in execution environment. URL: https://github.com/apache/flink/pull/9841#issuecomment-538594244 ## CI report: * 3560d8fdf99dc8140520bf195a09171708c1c241 : FAILURE [Build](https://travis-ci.com/f

[jira] [Comment Edited] (FLINK-10232) Add a SQL DDL

2019-10-05 Thread Leo Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944458#comment-16944458 ] Leo Zhang edited comment on FLINK-10232 at 10/5/19 10:05 AM: -

[GitHub] [flink] flinkbot edited a comment on issue #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#issuecomment-534565595 ## CI report: * 6bc9773c54eed0b1646ec67413cb3855c1057d87 : FAILURE [Build](https://travis-ci.com/flink-ci/fl

[GitHub] [flink] flinkbot edited a comment on issue #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#issuecomment-534565595 ## CI report: * 6bc9773c54eed0b1646ec67413cb3855c1057d87 : FAILURE [Build](https://travis-ci.com/flink-ci/fl

[GitHub] [flink] flinkbot edited a comment on issue #9760: [FLINK-13982][runtime] Implement memory calculation logics

2019-10-05 Thread GitBox
flinkbot edited a comment on issue #9760: [FLINK-13982][runtime] Implement memory calculation logics URL: https://github.com/apache/flink/pull/9760#issuecomment-534565595 ## CI report: * 6bc9773c54eed0b1646ec67413cb3855c1057d87 : FAILURE [Build](https://travis-ci.com/flink-ci/fl