[GitHub] [flink] zentol merged pull request #8259: [FLINK-12325][metrics] Fix bug in statsd exporter when using negative values

2019-05-08 Thread GitBox
zentol merged pull request #8259: [FLINK-12325][metrics] Fix bug in statsd exporter when using negative values URL: https://github.com/apache/flink/pull/8259 This is an automated message from the Apache Git Service. To respo

[GitHub] [flink] sunjincheng121 commented on issue #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist

2019-05-08 Thread GitBox
sunjincheng121 commented on issue #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist URL: https://github.com/apache/flink/pull/8377#issuecomment-490767978 @flinkbot approve all Merging This is an auto

[jira] [Commented] (FLINK-12363) Refactor legacy rest handlers

2019-05-08 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836141#comment-16836141 ] vinoyang commented on FLINK-12363: -- OK, [~Zentol] Can you tell the plan how to process

[GitHub] [flink] zentol commented on a change in pull request #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist

2019-05-08 Thread GitBox
zentol commented on a change in pull request #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist URL: https://github.com/apache/flink/pull/8377#discussion_r282357816 ## File path: flink-dist/pom.xml ## @@ -588,6 +588,31 @@ under the License.

[jira] [Commented] (FLINK-12363) Refactor legacy rest handlers

2019-05-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836136#comment-16836136 ] Chesnay Schepler commented on FLINK-12363: -- everything in that package is not l

[GitHub] [flink] flinkbot commented on issue #8379: [FLINK-12457][table-planner-blink] Remove char support in blink

2019-05-08 Thread GitBox
flinkbot commented on issue #8379: [FLINK-12457][table-planner-blink] Remove char support in blink URL: https://github.com/apache/flink/pull/8379#issuecomment-490766764 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[jira] [Updated] (FLINK-12457) Remove char support in blink

2019-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12457: --- Labels: pull-request-available (was: ) > Remove char support in blink > ---

[GitHub] [flink] JingsongLi opened a new pull request #8379: [FLINK-12457][table-planner-blink] Remove char support in blink

2019-05-08 Thread GitBox
JingsongLi opened a new pull request #8379: [FLINK-12457][table-planner-blink] Remove char support in blink URL: https://github.com/apache/flink/pull/8379 ## What is the purpose of the change Sql types don't support java char. CharType(InternalType) in blink and CharType of the new

[jira] [Created] (FLINK-12457) Remove char support in blink

2019-05-08 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12457: Summary: Remove char support in blink Key: FLINK-12457 URL: https://issues.apache.org/jira/browse/FLINK-12457 Project: Flink Issue Type: Improvement

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282355354 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[GitHub] [flink] JingsongLi commented on issue #8378: [FLINK-12453][table-planner-blink] Simplify constructor of AggsHandlerCodeGenerator

2019-05-08 Thread GitBox
JingsongLi commented on issue #8378: [FLINK-12453][table-planner-blink] Simplify constructor of AggsHandlerCodeGenerator URL: https://github.com/apache/flink/pull/8378#issuecomment-490764350 LGTM if travis green This is an au

[jira] [Commented] (FLINK-12363) Refactor legacy rest handlers

2019-05-08 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836129#comment-16836129 ] vinoyang commented on FLINK-12363: -- What do you think? [~Zentol] [~till.rohrmann] > Re

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282354267 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[jira] [Commented] (FLINK-12455) Move the packaging of pyflink to flink-dist

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836126#comment-16836126 ] sunjincheng commented on FLINK-12455: - Thanks, [~dian.fu] this issue can be done in

[jira] [Commented] (FLINK-12456) Wrong CharType convertion in type_utils.py

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836120#comment-16836120 ] sunjincheng commented on FLINK-12456: - Thanks for mention this issue. [~lzljs3620320

[GitHub] [flink] wuchong opened a new pull request #8378: [FLINK-12453][table-planner-blink] Simplify constructor of AggsHandlerCodeGenerator

2019-05-08 Thread GitBox
wuchong opened a new pull request #8378: [FLINK-12453][table-planner-blink] Simplify constructor of AggsHandlerCodeGenerator URL: https://github.com/apache/flink/pull/8378 ## What is the purpose of the change Currently, the constructor of `AggsHandlerCodeGenerator` contains sever

[jira] [Updated] (FLINK-12453) StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator

2019-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12453: --- Labels: pull-request-available (was: ) > StreamExecGlobalGroupAggregate construct wrong arg

[GitHub] [flink] flinkbot commented on issue #8378: [FLINK-12453][table-planner-blink] Simplify constructor of AggsHandlerCodeGenerator

2019-05-08 Thread GitBox
flinkbot commented on issue #8378: [FLINK-12453][table-planner-blink] Simplify constructor of AggsHandlerCodeGenerator URL: https://github.com/apache/flink/pull/8378#issuecomment-490759827 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the communi

[jira] [Updated] (FLINK-12456) Wrong CharType convertion in type_utils.py

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12456: Component/s: API / Python > Wrong CharType convertion in type_utils.py > -

[GitHub] [flink] twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282348005 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[GitHub] [flink] twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282347857 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[GitHub] [flink] twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282347087 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[jira] [Assigned] (FLINK-9410) Replace NMClient with NMClientAsync in YarnResourceManager

2019-05-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei reassigned FLINK-9410: --- Assignee: zhangminglei (was: lihongli) > Replace NMClient with NMClientAsync in YarnResourc

[jira] [Created] (FLINK-12456) Wrong CharType convertion in type_utils.py

2019-05-08 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12456: Summary: Wrong CharType convertion in type_utils.py Key: FLINK-12456 URL: https://issues.apache.org/jira/browse/FLINK-12456 Project: Flink Issue Type: Bug

[GitHub] [flink] wuchong commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12

2019-05-08 Thread GitBox
wuchong commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12 URL: https://github.com/apache/flink/pull/8376#issuecomment-490752948 Thanks for digging into this. LGTM. Will merge after travi

[GitHub] [flink] flinkbot commented on issue #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist

2019-05-08 Thread GitBox
flinkbot commented on issue #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist URL: https://github.com/apache/flink/pull/8377#issuecomment-490752300 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review yo

[jira] [Updated] (FLINK-12455) Move the packaging of pyflink to flink-dist

2019-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12455: --- Labels: pull-request-available (was: ) > Move the packaging of pyflink to flink-dist >

[GitHub] [flink] dianfu opened a new pull request #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist

2019-05-08 Thread GitBox
dianfu opened a new pull request #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist URL: https://github.com/apache/flink/pull/8377 ## What is the purpose of the change *This pull request moves the packaging of pyflink to flink-dist for the following reasons: *

[jira] [Updated] (FLINK-12455) Move the packaging of pyflink to flink-dist

2019-05-08 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-12455: Summary: Move the packaging of pyflink to flink-dist (was: Move the package of pyflink to flink-dist) >

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282339745 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282339745 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337775 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282339745 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337926 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337926 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337775 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] HuangZhenQiu commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration

2019-05-08 Thread GitBox
HuangZhenQiu commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-490741884 @xintongsong @tillrohrmann @rmetzger Thanks for the informative comments. The verified the solution end to end.

[jira] [Created] (FLINK-12455) Move the package of pyflink to flink-dist

2019-05-08 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12455: --- Summary: Move the package of pyflink to flink-dist Key: FLINK-12455 URL: https://issues.apache.org/jira/browse/FLINK-12455 Project: Flink Issue Type: Sub-task

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282335432 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282334560 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282334300 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table

[GitHub] [flink] chunweilei commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize

2019-05-08 Thread GitBox
chunweilei commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266#discussion_r282333076 ## File path: flink-dist/src/main/flink-bin/bin/config.sh ## @@ -429,6 +430,11 @@ if [ -z "${

[GitHub] [flink] eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin anot

[GitHub] [flink] eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin anot

[jira] [Updated] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12454: Labels: (was: Python) > Add custom check options for lint-python.sh > --

[jira] [Updated] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12454: Labels: Python (was: ) > Add custom check options for lint-python.sh > --

[jira] [Updated] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12454: Description: At present, int-python.sh has Python compatibility checks and code style checks. By d

[jira] [Created] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
sunjincheng created FLINK-12454: --- Summary: Add custom check options for lint-python.sh Key: FLINK-12454 URL: https://issues.apache.org/jira/browse/FLINK-12454 Project: Flink Issue Type: Sub-tas

[GitHub] [flink] eaglewatcherwb commented on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb commented on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin another rou

[GitHub] [flink] eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin anot

[GitHub] [flink] godfreyhe opened a new pull request #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12

2019-05-08 Thread GitBox
godfreyhe opened a new pull request #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12 URL: https://github.com/apache/flink/pull/8376 ## What is the purpose of the change *Port FlinkRelMetadataQuery into Java t

[jira] [Updated] (FLINK-12392) FlinkRelMetadataQuery does not compile with Scala 2.12

2019-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12392: --- Labels: pull-request-available (was: ) > FlinkRelMetadataQuery does not compile with Scala

[GitHub] [flink] flinkbot commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12

2019-05-08 Thread GitBox
flinkbot commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12 URL: https://github.com/apache/flink/pull/8376#issuecomment-490732935 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Assigned] (FLINK-12392) FlinkRelMetadataQuery does not compile with Scala 2.12

2019-05-08 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-12392: -- Assignee: godfrey he > FlinkRelMetadataQuery does not compile with Scala 2.12 > -

[GitHub] [flink] wenhuitang commented on issue #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang commented on issue #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7805#issuecomment-490729884 Open another PR(https://github.com/apache/flink/pull/8375) due to this pr from unknown repository. So close this one. --

[GitHub] [flink] flinkbot commented on issue #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
flinkbot commented on issue #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8375#issuecomment-490729901 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your p

[GitHub] [flink] wenhuitang closed pull request #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang closed pull request #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7805 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink] wenhuitang opened a new pull request #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang opened a new pull request #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8375 ## What is the purpose of the change This pull request Add readMapReduceTextFile API for HadoopInputs. https://issues.apache.or

[jira] [Updated] (FLINK-12453) StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator

2019-05-08 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-12453: - Description: In generateAggsHandler:  val generator = new AggsHandlerCodeGenerator(   CodeGene

[GitHub] [flink] wenhuitang closed pull request #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang closed pull request #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7810 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [flink] wenhuitang commented on issue #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang commented on issue #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7810#issuecomment-490729368 Open another PR(https://github.com/apache/flink/pull/8374) due to this pr from unknown repository. So close this one.

[jira] [Created] (FLINK-12453) StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator

2019-05-08 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12453: Summary: StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator Key: FLINK-12453 URL: https://issues.apache.org/jira/browse/FLINK-12453 Proj

[GitHub] [flink] flinkbot commented on issue #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
flinkbot commented on issue #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8374#issuecomment-490729202 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] wenhuitang opened a new pull request #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang opened a new pull request #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8374 ## What is the purpose of the change This pull request Add readMapRedTextFile API for HadoopInputs. https://issues.apache.org/jira

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282322682 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[jira] [Assigned] (FLINK-12375) flink-container job jar does not have read permissions

2019-05-08 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-12375: Assignee: Yun Tang > flink-container job jar does not have read permissions > ---

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282321982 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282322716 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282322682 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] tianchen92 commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize

2019-05-08 Thread GitBox
tianchen92 commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266#discussion_r282321092 ## File path: flink-dist/src/main/flink-bin/bin/config.sh ## @@ -429,6 +430,11 @@ if [ -z "${

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282320563 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282320535 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[jira] [Commented] (FLINK-12437) Taskmanager doesn't initiate registration after jobmanager marks it terminated

2019-05-08 Thread Abdul Qadeer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836032#comment-16836032 ] Abdul Qadeer commented on FLINK-12437: -- [~rmetzger] I don't expect a fix to be made

[GitHub] [flink] sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-05-08 Thread GitBox
sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-490388025 @pnowojski , the code has been updated and it relies on the latest version of [PR-7959](https://gi

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-08 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-490712462 @wuchong can you also help take a look at the upgrade? Thanks This is an au

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-08 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-490712398 @flinkbot attention @wuchong This is an automated message from the Apa

[jira] [Commented] (FLINK-12392) FlinkRelMetadataQuery does not compile with Scala 2.12

2019-05-08 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836018#comment-16836018 ] Jark Wu commented on FLINK-12392: - Sure [~twalthr], we will figure it out today. > Flin

[GitHub] [flink] xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490709606 > @xuefuz @lirui-apache thanks for your review! The build failure is unrelated (python api issue). If there's no more c

[GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490695098 Rebased to latest master to resolve conflicts. Will wait for a green build before proceeding --

[jira] [Closed] (FLINK-12417) Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12417. Resolution: Fixed merged in 1.9.0: c954780c9fb2c0cc5b3730caff7e99bacbd534ba > Unify ReadableCatalog and R

[GitHub] [flink] asfgit closed pull request #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
asfgit closed pull request #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365 This is an automated message from the Ap

[GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490692748 @xuefuz @lirui-apache thanks for your review! The build failure is unrelated (python api issue). If there's no more

[GitHub] [flink] bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365#issuecomment-490692552 @xuefuz thanks for your review! ReadableCatalog.java is already deleted. M

[GitHub] [flink] xuefuz commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
xuefuz commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365#issuecomment-490680574 Yes. Let's delete ReadableCatalog.java and the PR is good to go. Thanks. ---

[GitHub] [flink] xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490680873 ok. sounds good. thanks. This is an automated message

[GitHub] [flink] bowenli86 edited a comment on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 edited a comment on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490654662 > Thanks for refactoring the code. It looks much cleaner now. > > However, I still noticed there are st

[GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490654662 > Thanks for refactoring the code. It looks much cleaner now. > > However, I still noticed there are still a l

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282251157 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282251084 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[jira] [Created] (FLINK-12452) alterTable() should ensure existing base table and the new one are of the same type

2019-05-08 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12452: Summary: alterTable() should ensure existing base table and the new one are of the same type Key: FLINK-12452 URL: https://issues.apache.org/jira/browse/FLINK-12452 Project:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282244476 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282239896 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282238893 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/c

[GitHub] [flink] bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365#issuecomment-490639242 > Changes look good to me. However, I wonder if we should get ride of ReadableCat

[GitHub] [flink] StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates

2019-05-08 Thread GitBox
StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates URL: https://github.com/apache/flink/pull/8361#discussion_r282212329 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/Set

[GitHub] [flink] StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates

2019-05-08 Thread GitBox
StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates URL: https://github.com/apache/flink/pull/8361#discussion_r282213460 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/netwo

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282206462 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282205173 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282203125 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282205441 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/cata

  1   2   3   >