[jira] [Created] (FLINK-12116) Args autocast will cause exception for plan transformation in TableAPI

2019-04-04 Thread Xingcan Cui (JIRA)
Xingcan Cui created FLINK-12116: --- Summary: Args autocast will cause exception for plan transformation in TableAPI Key: FLINK-12116 URL: https://issues.apache.org/jira/browse/FLINK-12116 Project: Flink

[GitHub] [flink] klion26 commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-04-04 Thread GitBox
klion26 commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/7987#issuecomment-480127016 thanks for you contribution, LGTM now --

[GitHub] [flink] flinkbot edited a comment on issue #7978: [FLINK-11910] [Yarn] add customizable yarn application type

2019-04-04 Thread GitBox
flinkbot edited a comment on issue #7978: [FLINK-11910] [Yarn] add customizable yarn application type URL: https://github.com/apache/flink/pull/7978#issuecomment-472607121 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review y

[GitHub] [flink] suez1224 commented on issue #7978: [FLINK-11910] [Yarn] add customizable yarn application type

2019-04-04 Thread GitBox
suez1224 commented on issue #7978: [FLINK-11910] [Yarn] add customizable yarn application type URL: https://github.com/apache/flink/pull/7978#issuecomment-480102074 @flinkbot approve architecture This is an automated message

[GitHub] [flink] suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

2019-04-04 Thread GitBox
suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type URL: https://github.com/apache/flink/pull/7978#discussion_r272401341 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ##

[GitHub] [flink] suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

2019-04-04 Thread GitBox
suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type URL: https://github.com/apache/flink/pull/7978#discussion_r272401356 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ##

[GitHub] [flink] suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type

2019-04-04 Thread GitBox
suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type URL: https://github.com/apache/flink/pull/7978#discussion_r272401378 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ##

[jira] [Created] (FLINK-12115) Add support in Flink to persist state in Azure's blob store

2019-04-04 Thread Piyush Narang (JIRA)
Piyush Narang created FLINK-12115: - Summary: Add support in Flink to persist state in Azure's blob store Key: FLINK-12115 URL: https://issues.apache.org/jira/browse/FLINK-12115 Project: Flink

[jira] [Commented] (FLINK-11914) Expose a REST endpoint in JobManager to kill specific TaskManager

2019-04-04 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810193#comment-16810193 ] Shuyi Chen commented on FLINK-11914: Hi [~feng.xu], I dont think we should expose an

[jira] [Updated] (FLINK-12114) Try to perform UDF By Reflection

2019-04-04 Thread dong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dong updated FLINK-12114: - Affects Version/s: (was: 1.7.2) 1.6.5 > Try to perform UDF By Reflection > --

[jira] [Created] (FLINK-12114) Try to perform UDF By Reflection

2019-04-04 Thread dong (JIRA)
dong created FLINK-12114: Summary: Try to perform UDF By Reflection Key: FLINK-12114 URL: https://issues.apache.org/jira/browse/FLINK-12114 Project: Flink Issue Type: Improvement Components

[jira] [Updated] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-04 Thread yankai zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yankai zhang updated FLINK-12113: - Description:   {code:java} interface IS extends Iterator, Serializable { } StreamExecutionEnvir

[jira] [Created] (FLINK-12113) User code passing to fromCollection(Iterator, Class) not cleaned

2019-04-04 Thread yankai zhang (JIRA)
yankai zhang created FLINK-12113: Summary: User code passing to fromCollection(Iterator, Class) not cleaned Key: FLINK-12113 URL: https://issues.apache.org/jira/browse/FLINK-12113 Project: Flink

[GitHub] [flink] flinkbot commented on issue #8113: [FLINK-12112][tests] Properly print process output

2019-04-04 Thread GitBox
flinkbot commented on issue #8113: [FLINK-12112][tests] Properly print process output URL: https://github.com/apache/flink/pull/8113#issuecomment-479912488 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request

[GitHub] [flink] zentol opened a new pull request #8113: [FLINK-12112][tests] Properly print process output

2019-04-04 Thread GitBox
zentol opened a new pull request #8113: [FLINK-12112][tests] Properly print process output URL: https://github.com/apache/flink/pull/8113 ## What is the purpose of the change Fixes an issue in the `AbstractTaskManagerProcessFailureRecoveryTest` where the test, during the process out

[jira] [Updated] (FLINK-12112) AbstractTaskManagerProcessFailureRecoveryTest process output logging does not work properly

2019-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12112: --- Labels: pull-request-available (was: ) > AbstractTaskManagerProcessFailureRecoveryTest proc

[jira] [Commented] (FLINK-12111) TaskManagerProcessFailureBatchRecoveryITCase fails due to removed Slot

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809889#comment-16809889 ] Chesnay Schepler commented on FLINK-12111: -- Unfortunately the process output co

[jira] [Created] (FLINK-12112) AbstractTaskManagerProcessFailureRecoveryTest process output logging does not work properly

2019-04-04 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-12112: Summary: AbstractTaskManagerProcessFailureRecoveryTest process output logging does not work properly Key: FLINK-12112 URL: https://issues.apache.org/jira/browse/FLINK-1211

[jira] [Created] (FLINK-12111) TaskManagerProcessFailureBatchRecoveryITCase fails due to removed Slot

2019-04-04 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-12111: Summary: TaskManagerProcessFailureBatchRecoveryITCase fails due to removed Slot Key: FLINK-12111 URL: https://issues.apache.org/jira/browse/FLINK-12111 Projec

[jira] [Updated] (FLINK-11897) ExecutionGraphSuspendTest does not wait for all tasks to be submitted

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-11897: - Summary: ExecutionGraphSuspendTest does not wait for all tasks to be submitted (was: Ex

[jira] [Closed] (FLINK-11897) ExecutionGraphSuspendTest does not for all tasks to be submitted

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11897. Resolution: Fixed Fix Version/s: 1.8.1 master: 8a12e0f63de90375653a030304522ae0600c

[jira] [Updated] (FLINK-11897) ExecutionGraphSuspendTest does not for all tasks to be submitted

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-11897: - Summary: ExecutionGraphSuspendTest does not for all tasks to be submitted (was: Executi

[GitHub] [flink] zentol merged pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo…

2019-04-04 Thread GitBox
zentol merged pull request #7971: [FLINK-11897][tests] should wait all submitTask methods executed,befo… URL: https://github.com/apache/flink/pull/7971 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-12107) Use Proxy For DataDog Validation

2019-04-04 Thread Luka Jurukovski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809857#comment-16809857 ] Luka Jurukovski commented on FLINK-12107: - > Since this feature is only availabl

[jira] [Closed] (FLINK-12107) Use Proxy For DataDog Validation

2019-04-04 Thread Luka Jurukovski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luka Jurukovski closed FLINK-12107. --- Resolution: Fixed > Use Proxy For DataDog Validation > > >

[jira] [Assigned] (FLINK-12048) ZooKeeperHADispatcherTest failed on Travis

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-12048: Assignee: Till Rohrmann > ZooKeeperHADispatcherTest failed on Travis > --

[jira] [Closed] (FLINK-10746) Need to replace transfer.sh for Travis log upload because it shuts down

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10746. Resolution: Later transfer.sh will continue to work. > Need to replace transfer.sh for Tr

[jira] [Commented] (FLINK-12107) Use Proxy For DataDog Validation

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809831#comment-16809831 ] Chesnay Schepler commented on FLINK-12107: -- I can't reproduce this; I've set up

[GitHub] [flink] sunjincheng121 commented on issue #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on issue #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#issuecomment-47936 Thanks for the update @dianfu! +1 to merged. This is

[jira] [Commented] (FLINK-12107) Use Proxy For DataDog Validation

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809794#comment-16809794 ] Chesnay Schepler commented on FLINK-12107: -- What about the metric traffic itsel

[jira] [Updated] (FLINK-12107) Use Proxy For DataDog Validation

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-12107: - Affects Version/s: (was: 1.8.0) 1.9.0 > Use Proxy For DataDog

[jira] [Updated] (FLINK-12107) Use Proxy For DataDog Validation

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-12107: - Component/s: Runtime / Metrics > Use Proxy For DataDog Validation >

[jira] [Updated] (FLINK-12107) Use Proxy For DataDog Validation

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-12107: - Affects Version/s: 1.8.0 > Use Proxy For DataDog Validation > --

[jira] [Updated] (FLINK-11603) Port MetricQueryService to RpcEndpoint

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-11603: - Summary: Port MetricQueryService to RpcEndpoint (was: Port the MetricQueryService to th

[jira] [Closed] (FLINK-11603) Port MetricQueryService to RpcEndpoint

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-11603. Resolution: Fixed Fix Version/s: 1.9.0 master: 6e8a3f312919f8f088c132b13b727cb2188e

[GitHub] [flink] zentol merged pull request #7927: [FLINK-11603][metrics] Port the MetricQueryService to the new RpcEndpoint

2019-04-04 Thread GitBox
zentol merged pull request #7927: [FLINK-11603][metrics] Port the MetricQueryService to the new RpcEndpoint URL: https://github.com/apache/flink/pull/7927 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] zentol commented on issue #8083: [FLINK-12050][Tests] BlockingShutdownTest fails on Java 9

2019-04-04 Thread GitBox
zentol commented on issue #8083: [FLINK-12050][Tests] BlockingShutdownTest fails on Java 9 URL: https://github.com/apache/flink/pull/8083#issuecomment-479872874 Interesting, the UNIX version has the field, but the windows version doesn't have it. Please access `pid()` via reflection instea

[jira] [Closed] (FLINK-10575) Remove deprecated ExecutionGraphBuilder.buildGraph method

2019-04-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10575. Resolution: Fixed Fix Version/s: 1.9.0 master: cff74d3fe769c4844fc4faeb2ae604778d92

[GitHub] [flink] zentol merged pull request #7950: [FLINK-10575][coordination] Remove deprecated ExecutionGraphBuilder.buildGraph method

2019-04-04 Thread GitBox
zentol merged pull request #7950: [FLINK-10575][coordination] Remove deprecated ExecutionGraphBuilder.buildGraph method URL: https://github.com/apache/flink/pull/7950 This is an automated message from the Apache Git Service.

[GitHub] [flink] zentol commented on issue #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base

2019-04-04 Thread GitBox
zentol commented on issue #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base URL: https://github.com/apache/flink/pull/7780#issuecomment-479871386 went through the `JobSubmissionEnvironment` and made some refactorings. Additionally I rebased the PR.

[GitHub] [flink] dianfu commented on issue #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
dianfu commented on issue #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#issuecomment-479862729 @sunjincheng121 Thanks a lot for your review. Updated the PR accordingly. :) ---

[GitHub] [flink] zentol commented on issue #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base

2019-04-04 Thread GitBox
zentol commented on issue #7780: [FLINK-11593][tests] Check & port TaskManagerTest to new code base URL: https://github.com/apache/flink/pull/7780#issuecomment-479857850 I went through the tests and made a number of changes. Now starting to look into the `JobSubmissionEnvironment`.

[jira] [Commented] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2019-04-04 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809692#comment-16809692 ] Liya Fan commented on FLINK-3273: - [~dawidwys] I see. This issue can only be resolved wit

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272103567 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272103567 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] asfgit closed pull request #8112: [hotfix][table]Improve column operations doc in tableAPI.

2019-04-04 Thread GitBox
asfgit closed pull request #8112: [hotfix][table]Improve column operations doc in tableAPI. URL: https://github.com/apache/flink/pull/8112 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272102359 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] flinkbot edited a comment on issue #8112: [hotfix][table]Improve column operations doc in tableAPI.

2019-04-04 Thread GitBox
flinkbot edited a comment on issue #8112: [hotfix][table]Improve column operations doc in tableAPI. URL: https://github.com/apache/flink/pull/8112#issuecomment-479800278 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review you

[GitHub] [flink] sunjincheng121 commented on issue #8112: [hotfix][table]Improve column operations doc in tableAPI.

2019-04-04 Thread GitBox
sunjincheng121 commented on issue #8112: [hotfix][table]Improve column operations doc in tableAPI. URL: https://github.com/apache/flink/pull/8112#issuecomment-479829421 Thanks for your review @hequn8128 @flinkbot approve all Merging ... --

[jira] [Commented] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2019-04-04 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809678#comment-16809678 ] Dawid Wysakowicz commented on FLINK-3273: - [~fan_li_ya] It is a much bigger effor

[jira] [Commented] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2019-04-04 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809672#comment-16809672 ] Liya Fan commented on FLINK-3273: - Hi [~mxm], thanks a lot for the detailed explanation.

[jira] [Commented] (FLINK-11912) Expose per partition Kafka lag metric in Flink Kafka connector

2019-04-04 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809641#comment-16809641 ] aitozi commented on FLINK-11912: Got it [~suez1224] . Thanks for your explanation, I thi

[jira] [Commented] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2019-04-04 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809634#comment-16809634 ] Maximilian Michels commented on FLINK-3273: --- The idea was to have a Scala-free

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272080191 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskMana

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272080191 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskMana

[jira] [Created] (FLINK-12110) Introduce API point for ShuffleService to get estimation of locally required memory

2019-04-04 Thread Andrey Zagrebin (JIRA)
Andrey Zagrebin created FLINK-12110: --- Summary: Introduce API point for ShuffleService to get estimation of locally required memory Key: FLINK-12110 URL: https://issues.apache.org/jira/browse/FLINK-12110

[GitHub] [flink] hequn8128 removed a comment on issue #8112: [hotfix][table]Improve column operations doc in tableAPI.

2019-04-04 Thread GitBox
hequn8128 removed a comment on issue #8112: [hotfix][table]Improve column operations doc in tableAPI. URL: https://github.com/apache/flink/pull/8112#issuecomment-479810010 @sunjincheng121 Thanks for improving the document. It is clearer to separate the columns operation from the other ones

[GitHub] [flink] hequn8128 commented on issue #8112: [hotfix][table]Improve column operations doc in tableAPI.

2019-04-04 Thread GitBox
hequn8128 commented on issue #8112: [hotfix][table]Improve column operations doc in tableAPI. URL: https://github.com/apache/flink/pull/8112#issuecomment-479810010 @sunjincheng121 Thanks for improving the document. It is clearer to separate the columns operation from the other ones. It's e

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272077394 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272066212 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] flinkbot commented on issue #8112: [hotfix][table]Improve column operations doc in tableAPI.

2019-04-04 Thread GitBox
flinkbot commented on issue #8112: [hotfix][table]Improve column operations doc in tableAPI. URL: https://github.com/apache/flink/pull/8112#issuecomment-479800278 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Created] (FLINK-12109) Flink SQL hangs in StreamTableEnvironment.sqlUpdate, finally lead to java.lang.StackOverflowError

2019-04-04 Thread xu (JIRA)
xu created FLINK-12109: -- Summary: Flink SQL hangs in StreamTableEnvironment.sqlUpdate, finally lead to java.lang.StackOverflowError Key: FLINK-12109 URL: https://issues.apache.org/jira/browse/FLINK-12109 Project

[GitHub] [flink] sunjincheng121 opened a new pull request #8112: [hotfix][table]Improve column operations doc in tableAPI.

2019-04-04 Thread GitBox
sunjincheng121 opened a new pull request #8112: [hotfix][table]Improve column operations doc in tableAPI. URL: https://github.com/apache/flink/pull/8112 ## What is the purpose of the change Move the document of AddColumns/AddOrReplaceColumns/DropColumns/RenameColumns to a separate m

[GitHub] [flink] azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-04 Thread GitBox
azagrebin commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272066212 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NetworkEn

[GitHub] [flink] JingsongLi commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch

2019-04-04 Thread GitBox
JingsongLi commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch URL: https://github.com/apache/flink/pull/8107#discussion_r272061016 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] JingsongLi commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch

2019-04-04 Thread GitBox
JingsongLi commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch URL: https://github.com/apache/flink/pull/8107#discussion_r272060274 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272042362 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/stream/tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272048201 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/Operation

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272046074 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/Projectio

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272042200 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/stream/tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272038390 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/stream

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272055289 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow` defin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272045373 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272041929 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/stream

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272045455 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272044872 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272046322 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/Projectio

[GitHub] [flink] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2019-04-04 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r272037699 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtime/stream

[GitHub] [flink] lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null

2019-04-04 Thread GitBox
lamber-ken commented on issue #7987: [FLINK-11820][serialization] SimpleStringSchema handle message record which value is null URL: https://github.com/apache/flink/pull/7987#issuecomment-479787896 @klion26,cc This is an autom

[jira] [Commented] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2019-04-04 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809581#comment-16809581 ] Liya Fan commented on FLINK-3273: - Hi [~dawidwys], thank you so much for your feedback.

[GitHub] [flink] JingsongLi commented on a change in pull request #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-04 Thread GitBox
JingsongLi commented on a change in pull request #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#discussion_r272034292 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apac

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-04 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-479776062 Thanks @KurtYoung for reviewing, I changed method name and add comments.

[GitHub] [flink] KurtYoung commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch

2019-04-04 Thread GitBox
KurtYoung commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch URL: https://github.com/apache/flink/pull/8107#discussion_r272039981 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/ap

[GitHub] [flink] KurtYoung commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch

2019-04-04 Thread GitBox
KurtYoung commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch URL: https://github.com/apache/flink/pull/8107#discussion_r272038683 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/ap

[GitHub] [flink] KurtYoung commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch

2019-04-04 Thread GitBox
KurtYoung commented on a change in pull request #8107: [FLINK-12094][table-runtime-blink] Introduce sort merge join operator to blink batch URL: https://github.com/apache/flink/pull/8107#discussion_r272036764 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/ap