[GitHub] dianfu commented on issue #7235: [FLINK-10976] [table] Add support for aggregate to table API

dianfu commented on issue #7235: [FLINK-10976] [table] Add support for aggregate to table API URL: https://github.com/apache/flink/pull/7235#issuecomment-451849774 @sunjincheng121 Thanks a lot for the review. Most comments make sense to me. For JavaTableAPIITcase, currently there are also

[GitHub] dianfu commented on a change in pull request #7235: [FLINK-10976] [table] Add support for aggregate to table API

dianfu commented on a change in pull request #7235: [FLINK-10976] [table] Add support for aggregate to table API URL: https://github.com/apache/flink/pull/7235#discussion_r245566320 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala ###

[GitHub] buptljy commented on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

buptljy commented on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#issuecomment-451843969 > > @eaglewatcherwb Thanks for this PR! > > Agree to the "query-server.enable" configuration, but I'm not sure th

[GitHub] eaglewatcherwb edited a comment on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

eaglewatcherwb edited a comment on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#issuecomment-451840930 > @eaglewatcherwb Thanks for this PR! > Agree to the "query-server.enable" configuration, but I'm n

[GitHub] eaglewatcherwb commented on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

eaglewatcherwb commented on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#issuecomment-451840930 > @eaglewatcherwb Thanks for this PR! > Agree to the "query-server.enable" configuration, but I'm not sure

[GitHub] 123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r245554256 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11 +11

[GitHub] 123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

123avi commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r245554256 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11 +11

[jira] [Commented] (FLINK-11220) Can not Select row time field in JOIN query

[ https://issues.apache.org/jira/browse/FLINK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735450#comment-16735450 ] sunjincheng commented on FLINK-11220: - Thanks Fabian, I totally agree manually assi

[GitHub] TisonKun commented on issue #7340: [FLINK-11174] [prometheus] Flink Metrics Prometheus label values supp…

TisonKun commented on issue #7340: [FLINK-11174] [prometheus] Flink Metrics Prometheus label values supp… URL: https://github.com/apache/flink/pull/7340#issuecomment-451818181 @zentol sure I make it an opt-in feature. The change is pushed. Please review when you're free :-) --

[GitHub] wujinhu commented on issue #7384: [FLINK-11012] Introduce abstract superclass for filesystem IT cases

wujinhu commented on issue #7384: [FLINK-11012] Introduce abstract superclass for filesystem IT cases URL: https://github.com/apache/flink/pull/7384#issuecomment-451814460 @StefanRRichter Please help to review this PR, thanks :) -

[jira] [Assigned] (FLINK-8951) Support OVER windows PARTITION BY (rounded) timestamp

[ https://issues.apache.org/jira/browse/FLINK-8951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TANG Wen-hui reassigned FLINK-8951: --- Assignee: TANG Wen-hui > Support OVER windows PARTITION BY (rounded) timestamp > ---

[GitHub] kisimple commented on issue #7401: [hotfix][doc] Fix an error in state_backends

kisimple commented on issue #7401: [hotfix][doc] Fix an error in state_backends URL: https://github.com/apache/flink/pull/7401#issuecomment-451809885 cc @tzulitai This is an automated message from the Apache Git Service. To r

[GitHub] eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#discussion_r245540064 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/Ta

[GitHub] eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

eaglewatcherwb commented on a change in pull request #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#discussion_r245540045 ## File path: flink-core/src/main/java/org/apache/flink/configuration/QueryableSta

[jira] [Assigned] (FLINK-10489) Inconsistent window information for streams with EventTime characteristic

[ https://issues.apache.org/jira/browse/FLINK-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TANG Wen-hui reassigned FLINK-10489: Assignee: TANG Wen-hui > Inconsistent window information for streams with EventTime chara

[GitHub] hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r245535022 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[GitHub] buptljy commented on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS

buptljy commented on issue #7412: [FLINK-10866][Runtime] 1. Explicitly enable qs server and proxy. 2. QS URL: https://github.com/apache/flink/pull/7412#issuecomment-451800098 @eaglewatcherwb Thanks for this PR! Agree to the "query-server.enable" configuration, but I'm not sure that we s

[GitHub] hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

hequn8128 commented on a change in pull request #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according URL: https://github.com/apache/flink/pull/7418#discussion_r245535017 ## File path: docs/dev/connectors/filesystem_sink.md ## @@ -117,11

[GitHub] HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-451798255 @fhueske I refined test cases. Would you please take a last round of review? ---

[GitHub] TisonKun opened a new pull request #7419: [hotfix] [runtime] Remove redundant suppression

TisonKun opened a new pull request #7419: [hotfix] [runtime] Remove redundant suppression URL: https://github.com/apache/flink/pull/7419 ## What is the purpose of the change Remove redundant suppression in `RegisteredRpcConnection.java` ## Verifying this change This cha