[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649250#comment-16649250 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224978930 ## File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/table/descriptors/KafkaV

[jira] [Commented] (FLINK-2491) Checkpointing only works if all operators/tasks are still running

2018-10-13 Thread Congxian Qiu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649234#comment-16649234 ] Congxian Qiu commented on FLINK-2491: - Hi all, what's the status of the issue, is it

[GitHub] yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224976595 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/Fl

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649211#comment-16649211 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua commented on a change in pull requ

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649187#comment-16649187 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224976173 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/Fl

[GitHub] yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224976145 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/in

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649186#comment-16649186 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua commented on a change in pull requ

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649185#comment-16649185 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
yanghua commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224976123 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/in

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649176#comment-16649176 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649174#comment-16649174 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649177#comment-16649177 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649173#comment-16649173 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649167#comment-16649167 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649175#comment-16649175 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649168#comment-16649168 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649166#comment-16649166 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649169#comment-16649169 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649172#comment-16649172 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649165#comment-16649165 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649170#comment-16649170 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649171#comment-16649171 ] ASF GitHub Bot commented on FLINK-9697: --- eliaslevy commented on a change in pull re

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224965055 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224964381 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224964190 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224975662 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224964930 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224964336 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224975802 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224965118 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224964438 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224965110 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224965068 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224964968 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[GitHub] eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
eliaslevy commented on a change in pull request #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#discussion_r224975687 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/

[jira] [Commented] (FLINK-9940) File source continuous monitoring mode: S3 files sometimes missed

2018-10-13 Thread Huyen Levan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649144#comment-16649144 ] Huyen Levan commented on FLINK-9940: [~juanmirocks] Thanks for the link. I was not aw

[jira] [Commented] (FLINK-9878) IO worker threads BLOCKED on SSL Session Cache while CMS full gc

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649106#comment-16649106 ] ASF GitHub Bot commented on FLINK-9878: --- NicoK opened a new pull request #6838: [FL

[GitHub] NicoK opened a new pull request #6838: [FLINK-9878][network][ssl] add more low-level ssl options

2018-10-13 Thread GitBox
NicoK opened a new pull request #6838: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6838 ## What is the purpose of the change This is mostly to tackle bugs like https://github.com/netty/netty/issues/832 (JDK issue during garba

[jira] [Commented] (FLINK-10135) The JobManager doesn't report the cluster-level metrics

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649003#comment-16649003 ] ASF GitHub Bot commented on FLINK-10135: zentol commented on issue #6702: [FLINK

[GitHub] zentol closed pull request #6837: [hotfix][docs] Fix comments in ExecutionConfig.java

2018-10-13 Thread GitBox
zentol closed pull request #6837: [hotfix][docs] Fix comments in ExecutionConfig.java URL: https://github.com/apache/flink/pull/6837 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] zentol commented on issue #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics

2018-10-13 Thread GitBox
zentol commented on issue #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics URL: https://github.com/apache/flink/pull/6702#issuecomment-429552733 Ill merge this on monday and start looking into backporting this to 1.5 and 1.6. --

[jira] [Commented] (FLINK-10541) Removed unused code depends on LocalFlinkMiniCluster

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648999#comment-16648999 ] ASF GitHub Bot commented on FLINK-10541: zentol closed pull request #6835: [FLIN

[jira] [Updated] (FLINK-10541) Removed unused legacy methods in TestBaseUtils

2018-10-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-10541: - Summary: Removed unused legacy methods in TestBaseUtils (was: Removed unused code depe

[jira] [Closed] (FLINK-10541) Removed unused legacy methods in TestBaseUtils

2018-10-13 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-10541. Resolution: Fixed master: e2a5f15e622ee6ed3f0129fb81522c9f6895ecfb > Removed unused lega

[GitHub] zentol closed pull request #6835: [FLINK-10541] [tests] Removed unused code depends on LocalFlinkMiniCl…

2018-10-13 Thread GitBox
zentol closed pull request #6835: [FLINK-10541] [tests] Removed unused code depends on LocalFlinkMiniCl… URL: https://github.com/apache/flink/pull/6835 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[jira] [Commented] (FLINK-9940) File source continuous monitoring mode: S3 files sometimes missed

2018-10-13 Thread Juan Miguel Cejuela (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648989#comment-16648989 ] Juan Miguel Cejuela commented on FLINK-9940: As far as I understand, this bug

[jira] [Commented] (FLINK-10398) Add Tanh math function supported in Table API and SQL

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648986#comment-16648986 ] ASF GitHub Bot commented on FLINK-10398: yanghua commented on a change in pull r

[GitHub] yanghua commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL

2018-10-13 Thread GitBox
yanghua commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6736#discussion_r224962553 ## File path: docs/dev/table/functions.md ## @@ -1219,6 +1219,18 @@ TAN(nume

[jira] [Commented] (FLINK-10398) Add Tanh math function supported in Table API and SQL

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648985#comment-16648985 ] ASF GitHub Bot commented on FLINK-10398: yanghua commented on a change in pull r

[GitHub] yanghua commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL

2018-10-13 Thread GitBox
yanghua commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6736#discussion_r224962479 ## File path: docs/dev/table/functions.md ## @@ -1219,6 +1219,18 @@ TAN(nume

[jira] [Commented] (FLINK-10398) Add Tanh math function supported in Table API and SQL

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648963#comment-16648963 ] ASF GitHub Bot commented on FLINK-10398: xccui commented on a change in pull req

[GitHub] xccui commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL

2018-10-13 Thread GitBox
xccui commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6736#discussion_r224961146 ## File path: docs/dev/table/functions.md ## @@ -1219,6 +1219,18 @@ TAN(numeri

[jira] [Commented] (FLINK-10134) UTF-16 support for TextInputFormat

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648957#comment-16648957 ] ASF GitHub Bot commented on FLINK-10134: XuQianJin-Stars commented on issue #682

[GitHub] XuQianJin-Stars commented on issue #6823: [FLINK-10134] UTF-16 support for TextInputFormat bug refixed

2018-10-13 Thread GitBox
XuQianJin-Stars commented on issue #6823: [FLINK-10134] UTF-16 support for TextInputFormat bug refixed URL: https://github.com/apache/flink/pull/6823#issuecomment-429544772 @fhueske Thank you very much, I hope you can help me review this PR again. Use your precious time.The code logic pass

[jira] [Commented] (FLINK-10527) Cleanup constant isNewMode in YarnTestBase

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648928#comment-16648928 ] ASF GitHub Bot commented on FLINK-10527: yanghua commented on issue #6816: [FLIN

[GitHub] yanghua commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase

2018-10-13 Thread GitBox
yanghua commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase URL: https://github.com/apache/flink/pull/6816#issuecomment-429539752 @tillrohrmann For test case `testTaskManagerFailure`, the current test mode (based on stdout and stderr's special print message)

[jira] [Commented] (FLINK-10220) StreamSQL E2E test fails on travis

2018-10-13 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648915#comment-16648915 ] Hequn Cheng commented on FLINK-10220: - Should we continue to look into this problem

[GitHub] hequn8128 commented on issue #6792: [FLINK-10474][table] Don't translate IN/NOT_IN to JOIN with VALUES

2018-10-13 Thread GitBox
hequn8128 commented on issue #6792: [FLINK-10474][table] Don't translate IN/NOT_IN to JOIN with VALUES URL: https://github.com/apache/flink/pull/6792#issuecomment-429535085 @fhueske Thanks for your review and valuable suggestions. I have addressed all your comments. Best, Hequn --

[jira] [Commented] (FLINK-10474) Don't translate IN with Literals to JOIN with VALUES for streaming queries

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648895#comment-16648895 ] ASF GitHub Bot commented on FLINK-10474: hequn8128 commented on issue #6792: [FL

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0

2018-10-13 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for Kafka 2.0.0 URL: https://github.com/apache/flink/pull/6703#issuecomment-429524696 @aljoscha I have refactored and separated the commits. This is an automated

[jira] [Commented] (FLINK-9697) Provide connector for Kafka 2.0.0

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648838#comment-16648838 ] ASF GitHub Bot commented on FLINK-9697: --- yanghua commented on issue #6703: [FLINK-9

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648787#comment-16648787 ] ASF GitHub Bot commented on FLINK-7243: --- HuangZhenQiu commented on issue #6483: [FL

[GitHub] HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-10-13 Thread GitBox
HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-429517418 @fhueske Add unit test for failure recovery logic. Please review it again after the travis check turns to green. --