[GitHub] klion26 commented on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream

klion26 commented on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream URL: https://github.com/apache/flink/pull/6498#issuecomment-420534659 Hi, @StephanEwen @tzulitai @tillrohrmann Could you

[jira] [Created] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

Shimin Yang created FLINK-10322: --- Summary: Unused instance variable MetricRegistry in ResourceManager Key: FLINK-10322 URL: https://issues.apache.org/jira/browse/FLINK-10322 Project: Flink Issu

[jira] [Commented] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611656#comment-16611656 ] ASF GitHub Bot commented on FLINK-10319: TisonKun commented on issue #6680: [FLI

[GitHub] TisonKun commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway…

TisonKun commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway… URL: https://github.com/apache/flink/pull/6680#issuecomment-420526978 @yanghua thanks for your comment, suppress it. Th

[jira] [Commented] (FLINK-10235) KafkaTableSourceSinkFactoryBase#getFlinkKafkaPartitioner does not compile with Java 9

[ https://issues.apache.org/jira/browse/FLINK-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611655#comment-16611655 ] ASF GitHub Bot commented on FLINK-10235: yanghua commented on issue #6653: [FLIN

[GitHub] yanghua commented on issue #6653: [FLINK-10235][kafka] Explicitly cast custom partitioner classes

yanghua commented on issue #6653: [FLINK-10235][kafka] Explicitly cast custom partitioner classes URL: https://github.com/apache/flink/pull/6653#issuecomment-420526555 +1 This is an automated message from the Apache Git Servi

[jira] [Commented] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611646#comment-16611646 ] ASF GitHub Bot commented on FLINK-10319: yanghua commented on issue #6680: [FLIN

[GitHub] yanghua commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway…

yanghua commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway… URL: https://github.com/apache/flink/pull/6680#issuecomment-420525893 @TisonKun thanks for your contribution, Travis task all failed, one of them showed these errors : ``` 04

[jira] [Commented] (FLINK-10222) Table scalar function expression parses error when function name equals the exists keyword suffix

[ https://issues.apache.org/jira/browse/FLINK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611643#comment-16611643 ] ASF GitHub Bot commented on FLINK-10222: yanghua commented on a change in pull r

[GitHub] yanghua commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix

yanghua commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix URL: https://github.com/apache/flink/pull/6622#discussion_r216907736 ## File path: flink-libraries/flink-tab

[jira] [Created] (FLINK-10321) Make the condition of broadcast partitioner simple

zhijiang created FLINK-10321: Summary: Make the condition of broadcast partitioner simple Key: FLINK-10321 URL: https://issues.apache.org/jira/browse/FLINK-10321 Project: Flink Issue Type: Improv

[jira] [Created] (FLINK-10320) Introduce JobMaster schedule micro-benchmark

陈梓立 created FLINK-10320: --- Summary: Introduce JobMaster schedule micro-benchmark Key: FLINK-10320 URL: https://issues.apache.org/jira/browse/FLINK-10320 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611563#comment-16611563 ] ASF GitHub Bot commented on FLINK-7243: --- HuangZhenQiu commented on issue #6483: [FL

[GitHub] HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format

HuangZhenQiu commented on issue #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-420505649 @lvhuyen Thanks for the quick patch. I think the data conversion should be handled in RowConverter. I will ship a fix tonigh

[jira] [Commented] (FLINK-10222) Table scalar function expression parses error when function name equals the exists keyword suffix

[ https://issues.apache.org/jira/browse/FLINK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611560#comment-16611560 ] ASF GitHub Bot commented on FLINK-10222: walterddr commented on a change in pull

[jira] [Commented] (FLINK-10222) Table scalar function expression parses error when function name equals the exists keyword suffix

[ https://issues.apache.org/jira/browse/FLINK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611559#comment-16611559 ] ASF GitHub Bot commented on FLINK-10222: walterddr commented on a change in pull

[GitHub] walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix

walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix URL: https://github.com/apache/flink/pull/6622#discussion_r216891199 ## File path: flink-libraries/flink-t

[GitHub] walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix

walterddr commented on a change in pull request #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix URL: https://github.com/apache/flink/pull/6622#discussion_r216891057 ## File path: flink-libraries/flink-t

[jira] [Updated] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10319: --- Labels: pull-request-available (was: ) > Avoid requestPartitionState from JM but always try

[jira] [Commented] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611552#comment-16611552 ] ASF GitHub Bot commented on FLINK-10319: TisonKun opened a new pull request #668

[GitHub] TisonKun opened a new pull request #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway…

TisonKun opened a new pull request #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway… URL: https://github.com/apache/flink/pull/6680 …s try retrigger ## What is the purpose of the change Do not requestPartitionState from JM on partition request fail,

[jira] [Created] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

陈梓立 created FLINK-10319: --- Summary: Avoid requestPartitionState from JM but always try retrigger Key: FLINK-10319 URL: https://issues.apache.org/jira/browse/FLINK-10319 Project: Flink Issue Type: Impro

[jira] [Commented] (FLINK-10247) Run MetricQueryService in separate thread pool

[ https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611496#comment-16611496 ] ASF GitHub Bot commented on FLINK-10247: Clark commented on issue #6676: [FL

[GitHub] Clarkkkkk commented on issue #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool

Clark commented on issue #6676: [FLINK-10247][Metrics] Run MetricQueryService in separate thread pool URL: https://github.com/apache/flink/pull/6676#issuecomment-420492672 Hi @tillrohrmann , could you please review this PR when you have time? --

[jira] [Commented] (FLINK-10245) Add DataStream HBase Sink

[ https://issues.apache.org/jira/browse/FLINK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611491#comment-16611491 ] Shimin Yang commented on FLINK-10245: - [~hequn8128], we may make the deduplication a

[jira] [Commented] (FLINK-10245) Add DataStream HBase Sink

[ https://issues.apache.org/jira/browse/FLINK-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611487#comment-16611487 ] Shimin Yang commented on FLINK-10245: - Hi [~hequn8128]，I have been thinking about sh

[jira] [Commented] (FLINK-9913) Improve output serialization only once in RecordWriter

[ https://issues.apache.org/jira/browse/FLINK-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611470#comment-16611470 ] ASF GitHub Bot commented on FLINK-9913: --- zhijiangW commented on issue #6417: [FLINK

[GitHub] zhijiangW commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter

zhijiangW commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter URL: https://github.com/apache/flink/pull/6417#issuecomment-420486898 Thanks for that. I will also try best to monitor the performance changes for these cases later. :) ---

[jira] [Commented] (FLINK-10223) TaskManagers should log their ResourceID during startup

[ https://issues.apache.org/jira/browse/FLINK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611364#comment-16611364 ] ASF GitHub Bot commented on FLINK-10223: Aitozi commented on a change in pull re

[GitHub] Aitozi commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup

Aitozi commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup URL: https://github.com/apache/flink/pull/6679#discussion_r216853295 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerR

[jira] [Updated] (FLINK-9924) Upgrade zookeeper to 3.4.13

[ https://issues.apache.org/jira/browse/FLINK-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9924: -- Description: zookeeper 3.4.13 is being released. ZOOKEEPER-2959 fixes data loss when observer is used ZOOKEEPE

[jira] [Commented] (FLINK-9311) PubSub connector

[ https://issues.apache.org/jira/browse/FLINK-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611065#comment-16611065 ] ASF GitHub Bot commented on FLINK-9311: --- sceee commented on a change in pull reques

[GitHub] sceee commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

sceee commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r216775909 ## File path: docs/dev/connectors/pubsub.md ## @@ -0,0

[jira] [Resolved] (FLINK-10170) Support string representation for map and array types in descriptor-based Table API

[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-10170. -- Resolution: Fixed Fix Version/s: (was: 1.6.0) 1.7.0

[jira] [Commented] (FLINK-10170) Support string representation for map and array types in descriptor-based Table API

[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610870#comment-16610870 ] ASF GitHub Bot commented on FLINK-10170: asfgit closed pull request #6578: [FLIN

[GitHub] asfgit closed pull request #6578: [FLINK-10170] [table] Support string representation for map and array types in descriptor-based Table API

asfgit closed pull request #6578: [FLINK-10170] [table] Support string representation for map and array types in descriptor-based Table API URL: https://github.com/apache/flink/pull/6578 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displa

[jira] [Updated] (FLINK-10299) RowSerializer.copy data value cast exception and use checkpoint function Lead to Could not restart this job

[ https://issues.apache.org/jira/browse/FLINK-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-10299: -- Component/s: Table API & SQL > RowSerializer.copy data value cast exception and use checkpoint

[jira] [Commented] (FLINK-10223) TaskManagers should log their ResourceID during startup

[ https://issues.apache.org/jira/browse/FLINK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610845#comment-16610845 ] ASF GitHub Bot commented on FLINK-10223: yanghua commented on a change in pull r

[GitHub] yanghua commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup

yanghua commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup URL: https://github.com/apache/flink/pull/6679#discussion_r216725459 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManager

[jira] [Commented] (FLINK-10114) Support Orc for StreamingFileSink

[ https://issues.apache.org/jira/browse/FLINK-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610830#comment-16610830 ] vinoyang commented on FLINK-10114: -- [~kkl0u]  I'm dealing with this issue, but the orc

[jira] [Commented] (FLINK-10265) Configure checkpointing behavior for SQL Client

[ https://issues.apache.org/jira/browse/FLINK-10265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610819#comment-16610819 ] vinoyang commented on FLINK-10265: -- hi [~twalthr] Sorry to reply a bit late, because I

[jira] [Assigned] (FLINK-10257) Incorrect CHAR type support in Flink SQL and Table API

[ https://issues.apache.org/jira/browse/FLINK-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng reassigned FLINK-10257: --- Assignee: Hequn Cheng > Incorrect CHAR type support in Flink SQL and Table API > --

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610812#comment-16610812 ] ASF GitHub Bot commented on FLINK-9991: --- TisonKun commented on issue #6450: [FLINK-

[GitHub] TisonKun commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

TisonKun commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#issuecomment-420318613 @xccui so it is still a manual work. Thanks for your work so far and the clarify!

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610809#comment-16610809 ] ASF GitHub Bot commented on FLINK-9991: --- xccui edited a comment on issue #6450: [FL

[GitHub] xccui edited a comment on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

xccui edited a comment on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#issuecomment-420317388 Hi @TisonKun, if there is no conflict, I usually merge a PR with the following steps. - fetch commits of

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610806#comment-16610806 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on issue #6450: [FLINK-999

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610803#comment-16610803 ] ASF GitHub Bot commented on FLINK-10281: yanghua commented on issue #6659: [FLIN

[GitHub] xccui commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

xccui commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#issuecomment-420317388 Hi @TisonKun, if there is no conflict, I usually merge a PR with the following steps. - fetch commits of a PR t

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610804#comment-16610804 ] ASF GitHub Bot commented on FLINK-10281: yanghua closed pull request #6659: [FLI

[GitHub] yanghua commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed

yanghua commented on issue #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed URL: https://github.com/apache/flink/pull/6659#issuecomment-420317010 PR #6671 fixed it more graciously, so closing this PR. thanks @twalthr --

[GitHub] yanghua closed pull request #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed

yanghua closed pull request #6659: [FLINK-10281] [table] Table function parse regular expression contains backslash failed URL: https://github.com/apache/flink/pull/6659 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[jira] [Commented] (FLINK-10229) Support listing of views

[ https://issues.apache.org/jira/browse/FLINK-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610797#comment-16610797 ] ASF GitHub Bot commented on FLINK-10229: yanghua commented on issue #6631: [FLIN

[GitHub] yanghua commented on issue #6631: [FLINK-10229] [sql-client] Support listing of views

yanghua commented on issue #6631: [FLINK-10229] [sql-client] Support listing of views URL: https://github.com/apache/flink/pull/6631#issuecomment-420315730 hi @twalthr , hequn helped me to review this PR, does it look good to you? ---

[GitHub] yanghua commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

yanghua commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-420314869 @Clark , I considered your idea, but it seems "update-mode" belongs `StreamTableDescriptorValida

[jira] [Commented] (FLINK-10258) Allow streaming sources to be present for batch executions

[ https://issues.apache.org/jira/browse/FLINK-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610794#comment-16610794 ] ASF GitHub Bot commented on FLINK-10258: yanghua commented on issue #6675: [FLIN

[jira] [Commented] (FLINK-10222) Table scalar function expression parses error when function name equals the exists keyword suffix

[ https://issues.apache.org/jira/browse/FLINK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610790#comment-16610790 ] ASF GitHub Bot commented on FLINK-10222: yanghua commented on issue #6622: [FLIN

[GitHub] yanghua commented on issue #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix

yanghua commented on issue #6622: [FLINK-10222] [table] Table scalar function expression parses error when function name equals the exists keyword suffix URL: https://github.com/apache/flink/pull/6622#issuecomment-420313214 @xccui and @hequn8128 Can you help to review this PR? It blocks ASC

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610784#comment-16610784 ] ASF GitHub Bot commented on FLINK-9991: --- yanghua commented on issue #6450: [FLINK-9

[GitHub] yanghua commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

yanghua commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#issuecomment-420311006 @xccui OK, Thank you for your reminder, usually I use `git pull --rebase` operation, but this time only shows a sing

[jira] [Commented] (FLINK-10170) Support string representation for map and array types in descriptor-based Table API

[ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610768#comment-16610768 ] ASF GitHub Bot commented on FLINK-10170: twalthr commented on issue #6578: [FLIN

[jira] [Updated] (FLINK-10226) Latency metrics can choke job-manager

[ https://issues.apache.org/jira/browse/FLINK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-10226: --- Fix Version/s: 1.7.0 > Latency metrics can choke job-manager > -

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610767#comment-16610767 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on issue #6450: [FLINK-999

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610777#comment-16610777 ] ASF GitHub Bot commented on FLINK-9991: --- TisonKun commented on issue #6450: [FLINK-

[GitHub] TisonKun commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

TisonKun commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#issuecomment-420310280 Hi @xccui I wonder what is the formal process for merging a PR. In spite of some trivial work that could be merged

[GitHub] xccui commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

xccui commented on issue #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#issuecomment-420307947 Hi @yanghua, please always use `git rebase` instead of `git merge` to eliminate conflicts. I'll help to cherry-pick yo

[GitHub] twalthr commented on issue #6578: [FLINK-10170] [table] Support string representation for map and array types in descriptor-based Table API

twalthr commented on issue #6578: [FLINK-10170] [table] Support string representation for map and array types in descriptor-based Table API URL: https://github.com/apache/flink/pull/6578#issuecomment-420308035 Thank you @tragicjun. The changes look good to me. I will take care of merging t

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610749#comment-16610749 ] ASF GitHub Bot commented on FLINK-10301: pnowojski commented on a change in pull

[GitHub] pnowojski commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

pnowojski commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r216700994 ## File path: flink-streaming-java/src/test/java/org/a

[GitHub] twalthr commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table API

twalthr commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table API URL: https://github.com/apache/flink/pull/6671#issuecomment-420303028 Thank you @hequn8128 and @dawidwys. I found severe problems how escaping was introduced in FLINK-8301. This should not have

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610744#comment-16610744 ] ASF GitHub Bot commented on FLINK-10281: twalthr commented on issue #6671: [FLIN

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610716#comment-16610716 ] ASF GitHub Bot commented on FLINK-10057: TisonKun commented on a change in pull

[GitHub] TisonKun commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

TisonKun commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#discussion_r216692845 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ## @@ -530,6

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610710#comment-16610710 ] ASF GitHub Bot commented on FLINK-10301: NicoK commented on issue #6670: [FLINK-

[GitHub] NicoK commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

NicoK commented on issue #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#issuecomment-420295302 @pnowojski I assume the same thing :) - `BUFFER_SIZE` still uses the default (unle

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610708#comment-16610708 ] ASF GitHub Bot commented on FLINK-10057: StefanRRichter commented on a change in

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610707#comment-16610707 ] ASF GitHub Bot commented on FLINK-10057: StefanRRichter commented on a change in

[GitHub] StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#discussion_r216691577 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ## @@ -

[GitHub] StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#discussion_r216691558 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ## @@ -

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610701#comment-16610701 ] ASF GitHub Bot commented on FLINK-10301: NicoK commented on a change in pull req

[GitHub] NicoK commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

NicoK commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r216690643 ## File path: flink-streaming-java/src/test/java/org/apach

[GitHub] asfgit closed pull request #6674: [hotfix] [runtime] Remove unused legacy exception class

asfgit closed pull request #6674: [hotfix] [runtime] Remove unused legacy exception class URL: https://github.com/apache/flink/pull/6674 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

[ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610687#comment-16610687 ] ASF GitHub Bot commented on FLINK-10301: pnowojski commented on a change in pull

[GitHub] pnowojski commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances

pnowojski commented on a change in pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances URL: https://github.com/apache/flink/pull/6670#discussion_r216686306 ## File path: flink-streaming-java/src/test/java/org/a

[GitHub] StefanRRichter commented on issue #6674: [hotfix] [runtime] Remove unused legacy exception class

StefanRRichter commented on issue #6674: [hotfix] [runtime] Remove unused legacy exception class URL: https://github.com/apache/flink/pull/6674#issuecomment-420291487 LGTM, merging. This is an automated message from the Apach

[jira] [Commented] (FLINK-10275) StreamTask support object reuse

[ https://issues.apache.org/jira/browse/FLINK-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610679#comment-16610679 ] ASF GitHub Bot commented on FLINK-10275: kl0u commented on issue #6643: [FLINK-1

[GitHub] kl0u commented on issue #6643: [FLINK-10275] StreamTask support object reuse

kl0u commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-420289620 Sounds good. This is an automated message from the Apache Git Service. To respo

[GitHub] TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse

TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-420289282 @kl0u Thanks for comments! I would clean this PR and emphases the main changes later. Recently working on other threads, ping here once done

[jira] [Commented] (FLINK-10275) StreamTask support object reuse

[ https://issues.apache.org/jira/browse/FLINK-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610674#comment-16610674 ] ASF GitHub Bot commented on FLINK-10275: TisonKun commented on issue #6643: [FLI

[GitHub] asfgit closed pull request #6677: [hotfix] [kubernetes] correct exception typo

asfgit closed pull request #6677: [hotfix] [kubernetes] correct exception typo URL: https://github.com/apache/flink/pull/6677 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] StefanRRichter commented on issue #6677: [hotfix] [kubernetes] correct exception typo

StefanRRichter commented on issue #6677: [hotfix] [kubernetes] correct exception typo URL: https://github.com/apache/flink/pull/6677#issuecomment-420283134 LGTM, merging This is an automated message from the Apache Git Servic

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610615#comment-16610615 ] Wei-Che Wei commented on FLINK-9486: It's clear to me now. Thanks! > Introduce Timer

[jira] [Closed] (FLINK-10267) [State] Fix arbitrary iterator access on RocksDBMapIterator

[ https://issues.apache.org/jira/browse/FLINK-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-10267. -- Resolution: Fixed Merged in: master: 16dc5978c7 release-1.6: a19e1ee3ba release-1.5: d8e7741bf

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610602#comment-16610602 ] Stefan Richter commented on FLINK-9486: --- Exactly, that's how it is right now. In th

[jira] [Commented] (FLINK-9486) Introduce TimerState in keyed state backend

[ https://issues.apache.org/jira/browse/FLINK-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610597#comment-16610597 ] Wei-Che Wei commented on FLINK-9486: Hi [~srichter], If I didn't misunderstand. The t

[jira] [Commented] (FLINK-10267) [State] Fix arbitrary iterator access on RocksDBMapIterator

[ https://issues.apache.org/jira/browse/FLINK-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610573#comment-16610573 ] ASF GitHub Bot commented on FLINK-10267: asfgit closed pull request #6638: [FLIN

[GitHub] asfgit closed pull request #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator

asfgit closed pull request #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator URL: https://github.com/apache/flink/pull/6638 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[jira] [Commented] (FLINK-10267) [State] Fix arbitrary iterator access on RocksDBMapIterator

[ https://issues.apache.org/jira/browse/FLINK-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610569#comment-16610569 ] ASF GitHub Bot commented on FLINK-10267: StefanRRichter commented on issue #6638

[GitHub] StefanRRichter commented on issue #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator

StefanRRichter commented on issue #6638: [FLINK-10267][State] Fix arbitrary iterator access on RocksDBMapIterator URL: https://github.com/apache/flink/pull/6638#issuecomment-420272898 Thanks for the contribution! Looks good for me as well 👍 Merging.

[jira] [Commented] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610502#comment-16610502 ] ASF GitHub Bot commented on FLINK-9523: --- SokolovMS commented on a change in pull re

  1   2   >