[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread liurenjie1024
Github user liurenjie1024 commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174366242 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,175 @@ +/* + * Licen

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398166#comment-16398166 ] ASF GitHub Bot commented on FLINK-6968: --- Github user liurenjie1024 commented on a di

[jira] [Commented] (FLINK-8919) Add KeyedProcessFunctionWIthCleanupState

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398162#comment-16398162 ] ASF GitHub Bot commented on FLINK-8919: --- Github user liurenjie1024 commented on the

[GitHub] flink issue #5680: [FLINK-8919] Add KeyedProcessFunctionWithCleanupState.

2018-03-13 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/flink/pull/5680 @bowenli86 @fhueske UT added. This class is a utility class which can be the base class of many process function implementations in flink table. Its counterpart for the legacy `Process

[jira] [Commented] (FLINK-8862) Support HBase snapshot read

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398094#comment-16398094 ] ASF GitHub Bot commented on FLINK-8862: --- Github user neoremind commented on the issu

[GitHub] flink issue #5639: [FLINK-8862] [HBase] Support HBase snapshot read

2018-03-13 Thread neoremind
Github user neoremind commented on the issue: https://github.com/apache/flink/pull/5639 @fhueske Thanks for your response. I understand this case. Please take your time, hope this PR can be reviewed in the future and help people who needed. Thanks! ---

[jira] [Commented] (FLINK-8938) Not remove job graph during job master failover

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398081#comment-16398081 ] ASF GitHub Bot commented on FLINK-8938: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #5693: [FLINK-8938] [runtime] not remove job graph during...

2018-03-13 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5693 [FLINK-8938] [runtime] not remove job graph during job master failover ## What is the purpose of the change *This pull request fix a bug that when job master failover, it may delete t

[jira] [Created] (FLINK-8938) Not remove job graph during job master failover

2018-03-13 Thread shuai.xu (JIRA)
shuai.xu created FLINK-8938: --- Summary: Not remove job graph during job master failover Key: FLINK-8938 URL: https://issues.apache.org/jira/browse/FLINK-8938 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-8915) CheckpointingStatisticsHandler fails to return PendingCheckpointStats

2018-03-13 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398055#comment-16398055 ] vinoyang commented on FLINK-8915: - Hi [~gjy] , I just analyzed this issue. The real source

[jira] [Assigned] (FLINK-8915) CheckpointingStatisticsHandler fails to return PendingCheckpointStats

2018-03-13 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-8915: --- Assignee: vinoyang > CheckpointingStatisticsHandler fails to return PendingCheckpointStats > ---

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174339296 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to t

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174338968 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398018#comment-16398018 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398015#comment-16398015 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398020#comment-16398020 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398017#comment-16398017 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398016#comment-16398016 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398019#comment-16398019 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174338993 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to t

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174339810 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/QueryableTableSinkTest.scala --- @@ -0,0 +1,102 @@ +/*

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174339658 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/QueryableTableSinkTest.scala --- @@ -0,0 +1,102 @@ +/*

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174338981 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398001#comment-16398001 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174338955 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to t

[GitHub] flink pull request #5688: [FLINK-6968][Table API & SQL] Add Queryable table ...

2018-03-13 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5688#discussion_r174338947 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398000#comment-16398000 ] ASF GitHub Bot commented on FLINK-6968: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-8910) Introduce automated end-to-end test for local recovery (including sticky scheduling)

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397998#comment-16397998 ] ASF GitHub Bot commented on FLINK-8910: --- Github user sihuazhou commented on a diff i

[GitHub] flink pull request #5676: [FLINK-8910][tests] Automated end-to-end test for ...

2018-03-13 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5676#discussion_r174338580 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BackendRestorerProcedure.java --- @@ -105,6 +105,8 @@ public T creat

[jira] [Commented] (FLINK-6968) Store streaming, updating tables with unique key in queryable state

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397984#comment-16397984 ] ASF GitHub Bot commented on FLINK-6968: --- Github user liurenjie1024 commented on the

[jira] [Commented] (FLINK-8888) Upgrade AWS SDK in flink-connector-kinesis

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397985#comment-16397985 ] ASF GitHub Bot commented on FLINK-: --- Github user tweise commented on the issue:

[GitHub] flink issue #5688: [FLINK-6968][Table API & SQL] Add Queryable table sink.

2018-03-13 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/flink/pull/5688 @twalthr Please help to review this. ---

[GitHub] flink issue #5663: [FLINK-8888] [Kinesis Connectors] Update the AWS SDK for ...

2018-03-13 Thread tweise
Github user tweise commented on the issue: https://github.com/apache/flink/pull/5663 @StephanEwen we are looking to utilize this patch to override discovery using ListShards (initially in our connector extension). I have tested the SDK version change on top of our Flink 1.4 +

[jira] [Commented] (FLINK-6075) ORDER BY *time ASC

2018-03-13 Thread yinhua.dai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397950#comment-16397950 ] yinhua.dai commented on FLINK-6075: --- [~fhueske] Thanks for the explanation. So "ORDER

[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported

2018-03-13 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397874#comment-16397874 ] Fabian Hueske commented on FLINK-6810: -- Hi [~fdiazgon], sure :). I suggest to pick o

[jira] [Commented] (FLINK-8919) Add KeyedProcessFunctionWIthCleanupState

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397869#comment-16397869 ] ASF GitHub Bot commented on FLINK-8919: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5680: [FLINK-8919] Add KeyedProcessFunctionWithCleanupState.

2018-03-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5680 Taking a step back. What's the purpose of this change? It adds a class to the `flink-table` module that is not used anywhere and not part of the public API of the Table API or SQL. Why do we need

[jira] [Commented] (FLINK-6075) ORDER BY *time ASC

2018-03-13 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397849#comment-16397849 ] Fabian Hueske commented on FLINK-6075: -- Hi [~yinhua], that is not a limitation of Cal

[jira] [Commented] (FLINK-8862) Support HBase snapshot read

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397830#comment-16397830 ] ASF GitHub Bot commented on FLINK-8862: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5639: [FLINK-8862] [HBase] Support HBase snapshot read

2018-03-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5639 Thanks for the PR @neoremind. At the moment, the community is busy working on the 1.5 release which means that PRs for 1.5 fixes have priority right now. Also a large contribution such as this on

[jira] [Commented] (FLINK-6810) Add Some built-in Scalar Function supported

2018-03-13 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397512#comment-16397512 ] Fernando Díaz commented on FLINK-6810: -- Hi. I would like to work on any of these. The

[GitHub] flink issue #5663: [FLINK-8888] [Kinesis Connectors] Update the AWS SDK for ...

2018-03-13 Thread kailashhd
Github user kailashhd commented on the issue: https://github.com/apache/flink/pull/5663 Sorry for the delay in this. Confirming that I tested this using kinesalite and kinesis for both the consumer and producer functionality. I had some trouble when connecting this to kinesalite due t

[jira] [Commented] (FLINK-8888) Upgrade AWS SDK in flink-connector-kinesis

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397485#comment-16397485 ] ASF GitHub Bot commented on FLINK-: --- Github user kailashhd commented on the issu

[jira] [Commented] (FLINK-8845) Use WriteBatch to improve performance for recovery in RocksDB backend

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397394#comment-16397394 ] ASF GitHub Bot commented on FLINK-8845: --- Github user bowenli86 commented on a diff i

[jira] [Commented] (FLINK-8845) Use WriteBatch to improve performance for recovery in RocksDB backend

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397393#comment-16397393 ] ASF GitHub Bot commented on FLINK-8845: --- Github user bowenli86 commented on a diff i

[GitHub] flink pull request #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWra...

2018-03-13 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5650#discussion_r174231064 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java --- @@

[jira] [Commented] (FLINK-8845) Use WriteBatch to improve performance for recovery in RocksDB backend

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397392#comment-16397392 ] ASF GitHub Bot commented on FLINK-8845: --- Github user bowenli86 commented on a diff i

[jira] [Commented] (FLINK-8845) Use WriteBatch to improve performance for recovery in RocksDB backend

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397395#comment-16397395 ] ASF GitHub Bot commented on FLINK-8845: --- Github user bowenli86 commented on a diff i

[GitHub] flink pull request #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWra...

2018-03-13 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5650#discussion_r174230739 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java --- @@

[GitHub] flink pull request #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWra...

2018-03-13 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5650#discussion_r174231173 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java --- @@

[GitHub] flink pull request #5650: [FLINK-8845][state] Introduce RocksDBWriteBatchWra...

2018-03-13 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5650#discussion_r174231142 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java --- @@

[jira] [Commented] (FLINK-7521) Remove the 10MB limit from the current REST implementation.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397379#comment-16397379 ] ASF GitHub Bot commented on FLINK-7521: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #5685: [FLINK-7521][flip6] Remove the 10MB limit from the...

2018-03-13 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5685#discussion_r174225988 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FlinkHttpObjectAggregator.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397324#comment-16397324 ] ASF GitHub Bot commented on FLINK-8843: --- Github user GJL commented on the issue:

[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...

2018-03-13 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5632 I'll verify the changes @yanghua ---

[jira] [Assigned] (FLINK-8891) RestServerEndpoint can bind on local address only

2018-03-13 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8891: --- Assignee: Gary Yao > RestServerEndpoint can bind on local address only >

[jira] [Assigned] (FLINK-8843) Decouple bind REST address from advertised address

2018-03-13 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8843: --- Assignee: Gary Yao (was: vinoyang) > Decouple bind REST address from advertised address > --

[jira] [Commented] (FLINK-8934) Cancel slot requests for otherwisely fulfilled requests

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397309#comment-16397309 ] ASF GitHub Bot commented on FLINK-8934: --- Github user asfgit closed the pull request

[jira] [Assigned] (FLINK-8812) Possible resource leak in Flip6

2018-03-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-8812: Assignee: Till Rohrmann > Possible resource leak in Flip6 > ---

[GitHub] flink pull request #5687: [FLINK-8934] [flip6] Properly cancel slot requests...

2018-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5687 ---

[jira] [Closed] (FLINK-8934) Cancel slot requests for otherwisely fulfilled requests

2018-03-13 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8934. Resolution: Fixed Fixed via 1.6.0: 445cdfd57941c4c888a6e73356558fd5f11d443c 1.5.0: 9551c6fa91bc1cc

[jira] [Commented] (FLINK-8934) Cancel slot requests for otherwisely fulfilled requests

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397284#comment-16397284 ] ASF GitHub Bot commented on FLINK-8934: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #5687: [FLINK-8934] [flip6] Properly cancel slot requests of oth...

2018-03-13 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5687 Thanks for the review @zentol. I'll make the naming a bit clearer and then merge the PR. ---

[jira] [Commented] (FLINK-8872) Yarn detached mode via -yd does not detach

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397194#comment-16397194 ] ASF GitHub Bot commented on FLINK-8872: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5672: [FLINK-8872][flip6] fix yarn detached mode command...

2018-03-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5672#discussion_r174194372 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/Flip6DefaultCLI.java --- @@ -40,6 +40,7 @@ public Flip6DefaultCLI(Configuration conf

[GitHub] flink issue #5692: [docs] Fix typo in Python API docs

2018-03-13 Thread florianschmidt1994
Github user florianschmidt1994 commented on the issue: https://github.com/apache/flink/pull/5692 @zentol I found this browsing through the docs ---

[GitHub] flink pull request #5692: [docs] Fix typo in Python API docs

2018-03-13 Thread florianschmidt1994
GitHub user florianschmidt1994 opened a pull request: https://github.com/apache/flink/pull/5692 [docs] Fix typo in Python API docs Rename `Tockenizer` to `Tokenizer` in python docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/

[GitHub] flink pull request #5676: [FLINK-8910][tests] Automated end-to-end test for ...

2018-03-13 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5676#discussion_r174165460 --- Diff: flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java --- @@ -0,0 +1,450 @@ +/*

[jira] [Commented] (FLINK-8910) Introduce automated end-to-end test for local recovery (including sticky scheduling)

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397111#comment-16397111 ] ASF GitHub Bot commented on FLINK-8910: --- Github user sihuazhou commented on a diff i

[jira] [Commented] (FLINK-8910) Introduce automated end-to-end test for local recovery (including sticky scheduling)

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397110#comment-16397110 ] ASF GitHub Bot commented on FLINK-8910: --- Github user sihuazhou commented on a diff i

[GitHub] flink pull request #5676: [FLINK-8910][tests] Automated end-to-end test for ...

2018-03-13 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5676#discussion_r174175230 --- Diff: flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java --- @@ -0,0 +1,450 @@ +/*

[jira] [Commented] (FLINK-8937) Refactor flink end-to-end test skeleton

2018-03-13 Thread Florian Schmidt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397089#comment-16397089 ] Florian Schmidt commented on FLINK-8937: [~aljoscha] any opinions on this? > Refa

[jira] [Created] (FLINK-8937) Refactor flink end-to-end test skeleton

2018-03-13 Thread Florian Schmidt (JIRA)
Florian Schmidt created FLINK-8937: -- Summary: Refactor flink end-to-end test skeleton Key: FLINK-8937 URL: https://issues.apache.org/jira/browse/FLINK-8937 Project: Flink Issue Type: Improve

[jira] [Created] (FLINK-8936) Provide only AWS region or endpoint in line with the SDK

2018-03-13 Thread Kailash Hassan Dayanand (JIRA)
Kailash Hassan Dayanand created FLINK-8936: -- Summary: Provide only AWS region or endpoint in line with the SDK Key: FLINK-8936 URL: https://issues.apache.org/jira/browse/FLINK-8936 Project: Fl

[jira] [Commented] (FLINK-8872) Yarn detached mode via -yd does not detach

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397059#comment-16397059 ] ASF GitHub Bot commented on FLINK-8872: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5672: [FLINK-8872][flip6] fix yarn detached mode command...

2018-03-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5672#discussion_r174161228 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/Flip6DefaultCLI.java --- @@ -40,6 +40,7 @@ public Flip6DefaultCLI(Configuration conf

[jira] [Commented] (FLINK-8913) RocksDB state backend crashes in alpine image

2018-03-13 Thread Joshua Griffith (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397051#comment-16397051 ] Joshua Griffith commented on FLINK-8913: It seems like the official Flink docker i

[jira] [Commented] (FLINK-8802) Concurrent serialization without duplicating serializers in state server.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397015#comment-16397015 ] ASF GitHub Bot commented on FLINK-8802: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #5691: [FLINK-8802] [QS] Fix concurrent access to non-dup...

2018-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5691#discussion_r174150658 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java --- @@ -78,13 +75,

[jira] [Commented] (FLINK-8802) Concurrent serialization without duplicating serializers in state server.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397008#comment-16397008 ] ASF GitHub Bot commented on FLINK-8802: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5691: [FLINK-8802] [QS] Fix concurrent access to non-dup...

2018-03-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5691#discussion_r174148331 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java --- @@ -78,13 +7

[jira] [Commented] (FLINK-8802) Concurrent serialization without duplicating serializers in state server.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396994#comment-16396994 ] ASF GitHub Bot commented on FLINK-8802: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #5691: [FLINK-8802] [QS] Fix concurrent access to non-dup...

2018-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5691#discussion_r174145613 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java --- @@ -78,13 +75,

[jira] [Commented] (FLINK-8802) Concurrent serialization without duplicating serializers in state server.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396988#comment-16396988 ] ASF GitHub Bot commented on FLINK-8802: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5691: [FLINK-8802] [QS] Fix concurrent access to non-dup...

2018-03-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5691#discussion_r174144247 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java --- @@ -78,13 +7

[jira] [Commented] (FLINK-8906) Flip6DefaultCLI is not tested in org.apache.flink.client.cli tests

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396971#comment-16396971 ] ASF GitHub Bot commented on FLINK-8906: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5671: [FLINK-8906][flip6][tests] also test Flip6DefaultC...

2018-03-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5671#discussion_r174142014 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendCancelTest.java --- @@ -39,13 +47,27 @@ /** * Tests for the C

[jira] [Commented] (FLINK-4569) JobRetrievalITCase.testJobRetrieval() does not forward exceptions to parent thread.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396968#comment-16396968 ] ASF GitHub Bot commented on FLINK-4569: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5689: [FLINK-4569][tests] Respect exceptions thrown in t...

2018-03-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5689#discussion_r174140412 --- Diff: flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java --- @@ -119,6 +121,11 @@ public void run() {

[jira] [Commented] (FLINK-8906) Flip6DefaultCLI is not tested in org.apache.flink.client.cli tests

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396965#comment-16396965 ] ASF GitHub Bot commented on FLINK-8906: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5671: [FLINK-8906][flip6][tests] also test Flip6DefaultC...

2018-03-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5671#discussion_r174139638 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -567,7 +567,7 @@ public GetClusterStatusResp

[jira] [Commented] (FLINK-4569) JobRetrievalITCase.testJobRetrieval() does not forward exceptions to parent thread.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396953#comment-16396953 ] ASF GitHub Bot commented on FLINK-4569: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #5689: [FLINK-4569][tests] Respect exceptions thrown in t...

2018-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5689#discussion_r174135885 --- Diff: flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java --- @@ -119,6 +121,11 @@ public void run() { l

[jira] [Commented] (FLINK-8802) Concurrent serialization without duplicating serializers in state server.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396949#comment-16396949 ] ASF GitHub Bot commented on FLINK-8802: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #5691: [FLINK-8802] [QS] Fix concurrent access to non-dup...

2018-03-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5691#discussion_r174133415 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java --- @@ -78,13 +75,

[jira] [Commented] (FLINK-8802) Concurrent serialization without duplicating serializers in state server.

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396943#comment-16396943 ] ASF GitHub Bot commented on FLINK-8802: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #5691: [FLINK-8802] [QS] Fix concurrent access to non-dup...

2018-03-13 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5691#discussion_r174128377 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerHandler.java --- @@ -78,13 +7

[jira] [Commented] (FLINK-8910) Introduce automated end-to-end test for local recovery (including sticky scheduling)

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396934#comment-16396934 ] ASF GitHub Bot commented on FLINK-8910: --- Github user StefanRRichter commented on the

[GitHub] flink issue #5676: [FLINK-8910][tests] Automated end-to-end test for local r...

2018-03-13 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5676 CC @tillrohrmann ---

[jira] [Commented] (FLINK-8919) Add KeyedProcessFunctionWIthCleanupState

2018-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396927#comment-16396927 ] ASF GitHub Bot commented on FLINK-8919: --- Github user fhueske commented on the issue:

  1   2   >