[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-11-25 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5040 Yes. I think it would also be good to support `row(field, 'literal')` on both SQL and Table API so I added that. Not sure if this is necessary but `row(1, 'foo').get('f0')` is also support

[jira] [Commented] (FLINK-8104) Fix Row value constructor

2017-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265928#comment-16265928 ] ASF GitHub Bot commented on FLINK-8104: --- Github user walterddr commented on the issu

[jira] [Updated] (FLINK-8152) Any plans to Upgrade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Meshkovsky updated FLINK-8152: --- Priority: Major (was: Minor) > Any plans to Upgrade to Kafka 1.0.0 > ---

[jira] [Updated] (FLINK-8152) Any plans to Upgrade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Meshkovsky updated FLINK-8152: --- Priority: Minor (was: Critical) > Any plans to Upgrade to Kafka 1.0.0 >

[jira] [Updated] (FLINK-8152) Any plans to Upgrade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Meshkovsky updated FLINK-8152: --- Summary: Any plans to Upgrade to Kafka 1.0.0 (was: Any plans to Updade to Kafka 1.0.0 ) > A

[jira] [Updated] (FLINK-8152) Any plans to Updade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Meshkovsky updated FLINK-8152: --- Description: Guys, Kafka 1.0 should be compatible with lower versions of brokers let me know

[jira] [Updated] (FLINK-8152) Any plans to Updade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Meshkovsky updated FLINK-8152: --- Description: Guys, Kafka 1.0 should be compatible with lower versions of brokers let me know

[jira] [Updated] (FLINK-8152) Any plans to Updade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Meshkovsky updated FLINK-8152: --- Priority: Critical (was: Major) > Any plans to Updade to Kafka 1.0.0 > -

[jira] [Updated] (FLINK-8152) Any plans to Updade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Meshkovsky updated FLINK-8152: --- Environment: None (was: Any plans to offer Kafka 1.0 campatability) > Any plans to Updade to

[jira] [Created] (FLINK-8153) Upgrade to JDK 9

2017-11-25 Thread Paul Meshkovsky (JIRA)
Paul Meshkovsky created FLINK-8153: -- Summary: Upgrade to JDK 9 Key: FLINK-8153 URL: https://issues.apache.org/jira/browse/FLINK-8153 Project: Flink Issue Type: Improvement Environme

[jira] [Created] (FLINK-8152) Any plans to Updade to Kafka 1.0.0

2017-11-25 Thread Paul Meshkovsky (JIRA)
Paul Meshkovsky created FLINK-8152: -- Summary: Any plans to Updade to Kafka 1.0.0 Key: FLINK-8152 URL: https://issues.apache.org/jira/browse/FLINK-8152 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-8151) [Table] removing map value equality check

2017-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265891#comment-16265891 ] ASF GitHub Bot commented on FLINK-8151: --- GitHub user walterddr opened a pull request

[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-25 Thread walterddr
GitHub user walterddr opened a pull request: https://github.com/apache/flink/pull/5070 [FLINK-8151][table]Remove Map type equality comparison. Remove map type equality support as unlike java array, there's no element-wise equality check on Map type. Also small clean up on

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265890#comment-16265890 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK commented on the issue:

[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-25 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4581 (arg - I guess I should really fix my default file template some time...) -> the latest commit fixes the missing license text in the new test file ---

[jira] [Assigned] (FLINK-8151) [Table] removing map value equality check

2017-11-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong reassigned FLINK-8151: Assignee: Rong Rong > [Table] removing map value equality check > -

[jira] [Created] (FLINK-8151) [Table] removing map value equality check

2017-11-25 Thread Rong Rong (JIRA)
Rong Rong created FLINK-8151: Summary: [Table] removing map value equality check Key: FLINK-8151 URL: https://issues.apache.org/jira/browse/FLINK-8151 Project: Flink Issue Type: Bug Com

[jira] [Commented] (FLINK-8116) Stale comments referring to Checkpointed interface

2017-11-25 Thread Ankit Parashar (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265839#comment-16265839 ] Ankit Parashar commented on FLINK-8116: --- Hi, I would like to work on this issue, wou

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265719#comment-16265719 ] ASF GitHub Bot commented on FLINK-8139: --- Github user Aegeaner commented on the issue

[GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...

2017-11-25 Thread Aegeaner
Github user Aegeaner commented on the issue: https://github.com/apache/flink/pull/5065 @fhueske I found `TypeInformation `class has abstract `equals()` and `hashcode()` override methods defined, so any type info must implement these methods. So is reflection check necessary? ---

[GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...

2017-11-25 Thread Aegeaner
Github user Aegeaner commented on the issue: https://github.com/apache/flink/pull/5065 Hi @fhueske , thanks for review. I will update` equals() `and `hashcode() `methods of Row, but I also noticed that in `JoinOperator` and `KeySelector`, they used `RowComparator` to compare row

[jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265708#comment-16265708 ] ASF GitHub Bot commented on FLINK-8139: --- Github user Aegeaner commented on the issue

[GitHub] flink pull request #5069: [FLINK-8149][kinesis] Replace usages of deprecated...

2017-11-25 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/5069 [FLINK-8149][kinesis] Replace usages of deprecated SerializationSchema ## What is the purpose of the change The deprecated `SerializationSchema` in `flink-streaming-java`, has been moved to `flin

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265706#comment-16265706 ] ASF GitHub Bot commented on FLINK-8149: --- GitHub user yew1eb opened a pull request:

[jira] [Commented] (FLINK-8122) Name all table sinks and sources

2017-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265700#comment-16265700 ] ASF GitHub Bot commented on FLINK-8122: --- GitHub user xccui opened a pull request:

[GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...

2017-11-25 Thread xccui
GitHub user xccui opened a pull request: https://github.com/apache/flink/pull/5068 [FLINK-8122] [table] Name all built-in table sinks and sources ## What is the purpose of the change This PR adds names for all built-in table sources and sinks. ## Brief change log