[
https://issues.apache.org/jira/browse/FLINK-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235278#comment-16235278
]
ASF GitHub Bot commented on FLINK-7100:
---
Github user zjureel closed the pull request
Github user zjureel closed the pull request at:
https://github.com/apache/flink/pull/4307
---
[
https://issues.apache.org/jira/browse/FLINK-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235215#comment-16235215
]
Sihua Zhou commented on FLINK-7866:
---
Hi [~till.rohrmann], i saw you have made a PR for
[
https://issues.apache.org/jira/browse/FLINK-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235177#comment-16235177
]
ASF GitHub Bot commented on FLINK-7945:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4935
One other side note:
Please squash your commits into a single one, with an appropriate commit
message (you can refer to the other commits in the codebase as a starter).
`[FLINK-7945][Met
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4935#discussion_r148442662
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -24
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4935#discussion_r148442489
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -24
[
https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235173#comment-16235173
]
ASF GitHub Bot commented on FLINK-7758:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4769
@yew1eb doesn't this also need to be fixed for Kafka connector versions
0.10 and 0.11?
---
[
https://issues.apache.org/jira/browse/FLINK-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235168#comment-16235168
]
ASF GitHub Bot commented on FLINK-7838:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4915
Thanks for the work and reviews @GJL @pnowojski.
I did a pass also, changes LGTM.
Left one last comment regarding the integration test class name.
Other than that, would like to merge this
[
https://issues.apache.org/jira/browse/FLINK-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235167#comment-16235167
]
ASF GitHub Bot commented on FLINK-7838:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r148441559
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,7
GitHub user shuai-xu opened a pull request:
https://github.com/apache/flink/pull/4937
[FLINK-6434] [runtime] cancel slot allocation if request timed out in
ProviderAndOwner
## What is the purpose of the change
This pr adds a cancel slot allocation protocol between Prov
[
https://issues.apache.org/jira/browse/FLINK-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235157#comment-16235157
]
ASF GitHub Bot commented on FLINK-6434:
---
GitHub user shuai-xu opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235154#comment-16235154
]
ASF GitHub Bot commented on FLINK-7732:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4928
Travis passes, merging ...
---
[
https://issues.apache.org/jira/browse/FLINK-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235151#comment-16235151
]
ASF GitHub Bot commented on FLINK-7784:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4910
LGTM, thanks for the work @GJL. Merging this ..
---
[
https://issues.apache.org/jira/browse/FLINK-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou UTC+8 reassigned FLINK-6885:
-
Assignee: Hai Zhou UTC+8
> RMQSource does not support qos, leading to oom
> -
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148437379
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
---
@@ -476,14 +482,13 @@ else if (numSources < paralle
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235130#comment-16235130
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user sihuazhou commented on a diff i
[
https://issues.apache.org/jira/browse/FLINK-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235129#comment-16235129
]
ASF GitHub Bot commented on FLINK-7962:
---
GitHub user dianfu opened a pull request:
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4936
[FLINK-7962] Add built-in support for min/max aggregation for Timestamp
## What is the purpose of the change
*This JIRA adds the built-in support for min/max aggregation for Timestamp.*
Dian Fu created FLINK-7962:
--
Summary: Add built-in support for min/max aggregation for Timestamp
Key: FLINK-7962
URL: https://issues.apache.org/jira/browse/FLINK-7962
Project: Flink
Issue Type: Task
[
https://issues.apache.org/jira/browse/FLINK-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235104#comment-16235104
]
ASF GitHub Bot commented on FLINK-5856:
---
Github user shuai-xu closed the pull reques
Github user shuai-xu closed the pull request at:
https://github.com/apache/flink/pull/3398
---
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235103#comment-16235103
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user sihuazhou commented on a diff i
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148434074
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -878,113 +880,70 @@ private void scheduleEager(Sl
[
https://issues.apache.org/jira/browse/FLINK-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235098#comment-16235098
]
Wei-Che Wei commented on FLINK-7692:
Hi [~Zentol]
I proposed a draft for this issue a
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/4935
cc @zentol @tzulitai please help review the code.
---
GitHub user Aitozi opened a pull request:
https://github.com/apache/flink/pull/4935
[Flink-7945][Metrics&connector]Fix per partition-lag metric lost in kafka
connector
## What is the purpose of the change
*When used KafkaConnector, we cant get per partition lag metric. But
[
https://issues.apache.org/jira/browse/FLINK-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
aitozi updated FLINK-7945:
--
Summary: Per partition-lag metric lost in kafka connector (was:
kafka-connector11 use kafkaConsumer0.9 caused
[
https://issues.apache.org/jira/browse/FLINK-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234932#comment-16234932
]
aitozi commented on FLINK-7945:
---
Before I think the losed metric is caused by the kafka clie
[
https://issues.apache.org/jira/browse/FLINK-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
aitozi updated FLINK-7945:
--
Affects Version/s: 1.3.2
> kafka-connector11 use kafkaConsumer0.9 caused it lost the important metric in
> kafk
[
https://issues.apache.org/jira/browse/FLINK-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234923#comment-16234923
]
ASF GitHub Bot commented on FLINK-7701:
---
Github user NicoK commented on the issue:
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4733
yes, unfortunately this was for netty 4.1 only (it changed the API)...
I rebased the PR to fix the conflict (which I did not have during the
rebase though...)
---
[
https://issues.apache.org/jira/browse/FLINK-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234904#comment-16234904
]
ASF GitHub Bot commented on FLINK-7745:
---
Github user NicoK commented on the issue:
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4758
Added some comments and also found out that the `testOverprovisioned()`
test wasn't really testing what it was supposed to test :( - also fixed now.
---
[
https://issues.apache.org/jira/browse/FLINK-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shuyi Chen reassigned FLINK-7003:
-
Assignee: Shuyi Chen
> "select * from" in Flink SQL should not flatten all fields in the table by
[
https://issues.apache.org/jira/browse/FLINK-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234877#comment-16234877
]
ASF GitHub Bot commented on FLINK-7943:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4921
Thanks for the review @zentol. I've changed the
`RequiredParameters#applyTo` method as you suggested and it was a less
impacting change.
---
[
https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234869#comment-16234869
]
ASF GitHub Bot commented on FLINK-7876:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234870#comment-16234870
]
ASF GitHub Bot commented on FLINK-7745:
---
Github user NicoK commented on a diff in th
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4758#discussion_r148402375
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactoryTest.java
---
@@ -53,9 +64,89 @@ public void verifyAllBuffer
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4872
---
[
https://issues.apache.org/jira/browse/FLINK-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-7100.
--
Resolution: Fixed
Fix Version/s: (was: 1.3.3)
Fixed via d45b941280155a67aed3f3518b2a0
[
https://issues.apache.org/jira/browse/FLINK-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234867#comment-16234867
]
ASF GitHub Bot commented on FLINK-7745:
---
Github user NicoK commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-7876.
Resolution: Fixed
Fix Version/s: 1.4.0
Fixed via d45b941280155a67aed3f3518b2a05eedc1dab2e
>
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4758#discussion_r148402248
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactoryTest.java
---
@@ -53,9 +64,89 @@ public void verifyAllBuffer
[
https://issues.apache.org/jira/browse/FLINK-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234851#comment-16234851
]
ASF GitHub Bot commented on FLINK-7745:
---
Github user NicoK commented on a diff in th
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4758#discussion_r148401163
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactoryTest.java
---
@@ -53,9 +64,89 @@ public void verifyAllBuffer
[
https://issues.apache.org/jira/browse/FLINK-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234844#comment-16234844
]
ASF GitHub Bot commented on FLINK-7960:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234846#comment-16234846
]
ASF GitHub Bot commented on FLINK-7745:
---
Github user NicoK commented on a diff in th
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4933
Thanks for the review @GJL. I've addressed your comments.
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4758#discussion_r148400245
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactoryTest.java
---
@@ -53,9 +64,89 @@ public void verifyAllBuffer
[
https://issues.apache.org/jira/browse/FLINK-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234840#comment-16234840
]
ASF GitHub Bot commented on FLINK-7960:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148399427
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -844,7 +844,7 @@ else if (current == CANCELING || c
[
https://issues.apache.org/jira/browse/FLINK-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234839#comment-16234839
]
ASF GitHub Bot commented on FLINK-7960:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148399116
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java
---
@@ -48,6 +48,8 @@
[
https://issues.apache.org/jira/browse/FLINK-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234836#comment-16234836
]
ASF GitHub Bot commented on FLINK-7943:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4921#discussion_r148398599
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.java
---
@@ -83,82 +82,100 @@ public void add(Option option) thro
[
https://issues.apache.org/jira/browse/FLINK-7921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234714#comment-16234714
]
Greg Hogan commented on FLINK-7921:
---
[~anil.kumar] are you still seeing this issue in yo
[
https://issues.apache.org/jira/browse/FLINK-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234675#comment-16234675
]
ASF GitHub Bot commented on FLINK-7420:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4931
Changes look good all in all.
Missing one last pass for "Replace GenericData.Array by dummy when reading
TypeSerializers"...
---
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148363944
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -1065,6 +1177,46 @@ private void sendUpdatePartition
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148360937
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -126,9 +134,11 @@
/** A future that complete
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234666#comment-16234666
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148360739
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -220,14 +233,54 @@ public long getGlobalModVersion()
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234665#comment-16234665
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234667#comment-16234667
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234664#comment-16234664
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234662#comment-16234662
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234663#comment-16234663
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234668#comment-16234668
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148366967
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/Scheduler.java
---
@@ -133,32 +133,33 @@ public void shutdown() {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148367405
--- Diff: flink-runtime/src/test/resources/log4j-test.properties ---
@@ -16,7 +16,7 @@
# limitations under the License.
###
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148364165
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -1065,6 +1177,46 @@ private void sendUpdatePartition
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148366296
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
---
@@ -476,14 +482,13 @@ else if (numSources < paral
[
https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234611#comment-16234611
]
ASF GitHub Bot commented on FLINK-7951:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4926
+1 to merge this
---
[
https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234612#comment-16234612
]
ASF GitHub Bot commented on FLINK-7951:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4926
Thanks @steveloughran!
I think this approach here should work for then, for now.
---
[
https://issues.apache.org/jira/browse/FLINK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234604#comment-16234604
]
ASF GitHub Bot commented on FLINK-7153:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4916#discussion_r148358215
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -878,113 +880,70 @@ private void scheduleEager(
[
https://issues.apache.org/jira/browse/FLINK-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234597#comment-16234597
]
ASF GitHub Bot commented on FLINK-7778:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4927
@StephanEwen Implemented both suggestions.
---
[
https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234550#comment-16234550
]
ASF GitHub Bot commented on FLINK-7951:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234548#comment-16234548
]
ASF GitHub Bot commented on FLINK-7951:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4926#discussion_r148347804
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
@@ -265,7 +266,8 @@ protected int runApplicationMaster(Con
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4926#discussion_r148347764
--- Diff:
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java
---
@@ -44,7 +44,9 @@
public stat
[
https://issues.apache.org/jira/browse/FLINK-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234546#comment-16234546
]
ASF GitHub Bot commented on FLINK-7958:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4932
true, we can use default methods for this, I was concerned about backwards
compatibilty but forgot about that option.
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4932
I would suggest another solution - rather than adding another interface
'DelimiterProvider', add `getDelimiter()` which returns '.' as an interface
default method to `MetricReporter`. Any reporter
[
https://issues.apache.org/jira/browse/FLINK-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234491#comment-16234491
]
ASF GitHub Bot commented on FLINK-7958:
---
Github user bowenli86 commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234480#comment-16234480
]
ASF GitHub Bot commented on FLINK-7778:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4927
@zentol I like the changes!
Last two points:
1. Does it make sense to add only the non relocated guava classes in
`flink-shaded-curator`? Meaning define a filter in the shading incl
Thalita Vergilio created FLINK-7961:
---
Summary: Docker-Flink with Docker Swarm doesn't work when machines
are in different clouds
Key: FLINK-7961
URL: https://issues.apache.org/jira/browse/FLINK-7961
[
https://issues.apache.org/jira/browse/FLINK-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234440#comment-16234440
]
ASF GitHub Bot commented on FLINK-7951:
---
Github user steveloughran commented on a di
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/flink/pull/4926#discussion_r148328894
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
@@ -265,7 +266,8 @@ protected int runApplicationMaster(C
1 - 100 of 311 matches
Mail list logo
