[jira] [Commented] (FLINK-7100) TaskManager metrics are registered twice

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088460#comment-16088460 ] ASF GitHub Bot commented on FLINK-7100: --- Github user dikei commented on the issue:

[GitHub] flink issue #4307: [FLINK-7100] TaskManager metrics are registered twice

2017-07-14 Thread dikei
Github user dikei commented on the issue: https://github.com/apache/flink/pull/4307 I think this commit broke the task manager page in the web ui for me. Can someone check it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[jira] [Updated] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-14 Thread Xu Pingyong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Pingyong updated FLINK-7201: --- Description: {code:java} java.util.ConcurrentModificationException: null at java.util.HashMa

[jira] [Updated] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-14 Thread Xu Pingyong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Pingyong updated FLINK-7201: --- Description: {code:java} java.util.ConcurrentModificationException: null at java.util.HashMap

[jira] [Commented] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088389#comment-16088389 ] ASF GitHub Bot commented on FLINK-7201: --- GitHub user XuPingyong opened a pull reques

[GitHub] flink pull request #4347: [FLINK-7201] fix concurrency in JobLeaderIdService...

2017-07-14 Thread XuPingyong
GitHub user XuPingyong opened a pull request: https://github.com/apache/flink/pull/4347 [FLINK-7201] fix concurrency in JobLeaderIdService when shutdown the … You can merge this pull request into a Git repository by running: $ git pull https://github.com/XuPingyong/flink FLI

[jira] [Updated] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-14 Thread Xu Pingyong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Pingyong updated FLINK-7201: --- Description: java.util.ConcurrentModificationException: null at java.util.HashMap$HashIterato

[jira] [Updated] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-14 Thread Xu Pingyong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Pingyong updated FLINK-7201: --- Component/s: JobManager > ConcurrentModificationException in JobLeaderIdService >

[jira] [Created] (FLINK-7201) ConcurrentModificationException in JobLeaderIdService

2017-07-14 Thread Xu Pingyong (JIRA)
Xu Pingyong created FLINK-7201: -- Summary: ConcurrentModificationException in JobLeaderIdService Key: FLINK-7201 URL: https://issues.apache.org/jira/browse/FLINK-7201 Project: Flink Issue Type: B

[jira] [Commented] (FLINK-7199) Graph simplification does not set parallelism

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088340#comment-16088340 ] ASF GitHub Bot commented on FLINK-7199: --- GitHub user greghogan opened a pull request

[GitHub] flink pull request #4346: [FLINK-7199] [gelly] Graph simplification does not...

2017-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4346 [FLINK-7199] [gelly] Graph simplification does not set parallelism The Simplify parameter should accept and set the parallelism when calling the Simplify algorithms. You can merge this pull reque

[jira] [Closed] (FLINK-7161) Fix misusage of Double.MIN_VALUE and Float.MIN_VALUE

2017-07-14 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-7161. - Resolution: Fixed Fix Version/s: 1.4.0 > Fix misusage of Double.MIN_VALUE and Float.MIN_VALUE > ---

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-14 Thread zhenzhongxu
Github user zhenzhongxu commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127560857 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -505,

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088220#comment-16088220 ] ASF GitHub Bot commented on FLINK-6998: --- Github user zhenzhongxu commented on a diff

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088216#comment-16088216 ] ASF GitHub Bot commented on FLINK-6998: --- Github user zhenzhongxu commented on a diff

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-14 Thread zhenzhongxu
Github user zhenzhongxu commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r127560753 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java --- @

[jira] [Closed] (FLINK-5271) Refactor the batch SQL tests

2017-07-14 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-5271. -- Resolution: Duplicate FLINK-6617 already done. > Refactor the batch SQL tests > ---

[jira] [Closed] (FLINK-5273) Refactor stream SQL tests

2017-07-14 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-5273. -- Resolution: Fixed > Refactor stream SQL tests > - > > Key: FLINK

[jira] [Created] (FLINK-7200) Make metrics more Datadog friendly

2017-07-14 Thread Robert Batts (JIRA)
Robert Batts created FLINK-7200: --- Summary: Make metrics more Datadog friendly Key: FLINK-7200 URL: https://issues.apache.org/jira/browse/FLINK-7200 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-7199) Graph simplification does not set parallelism

2017-07-14 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-7199: - Summary: Graph simplification does not set parallelism Key: FLINK-7199 URL: https://issues.apache.org/jira/browse/FLINK-7199 Project: Flink Issue Type: Bug

[jira] [Reopened] (FLINK-6964) Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore

2017-07-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reopened FLINK-6964: - Please only close once the fix is merged both on {{release-1.3}} and master, so that we can a

[jira] [Updated] (FLINK-6365) Adapt default values of the Kinesis connector

2017-07-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-6365: Fix Version/s: 1.3.2 1.4.0 > Adapt default values of the Kinesis connector >

[jira] [Commented] (FLINK-6365) Adapt default values of the Kinesis connector

2017-07-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088020#comment-16088020 ] Bowen Li commented on FLINK-6365: - We ran into this issue, too. 100 is too small for SHARD

[jira] [Assigned] (FLINK-6365) Adapt default values of the Kinesis connector

2017-07-14 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-6365: --- Assignee: Bowen Li > Adapt default values of the Kinesis connector >

[jira] [Created] (FLINK-7198) Datadog Metric Reporter reports incorrect host for JobManager

2017-07-14 Thread Robert Batts (JIRA)
Robert Batts created FLINK-7198: --- Summary: Datadog Metric Reporter reports incorrect host for JobManager Key: FLINK-7198 URL: https://issues.apache.org/jira/browse/FLINK-7198 Project: Flink Is

[jira] [Commented] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087865#comment-16087865 ] ASF GitHub Bot commented on FLINK-7197: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...

2017-07-14 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4345#discussion_r127532604 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateGraphIds.java --- @@ -56,7 +56,9 @@ public TranslateGrap

[jira] [Commented] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087859#comment-16087859 ] ASF GitHub Bot commented on FLINK-7197: --- Github user tedyu commented on a diff in th

[GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...

2017-07-14 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4345#discussion_r127532176 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateGraphIds.java --- @@ -56,7 +56,9 @@ public TranslateGraphIds

[jira] [Commented] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087854#comment-16087854 ] ASF GitHub Bot commented on FLINK-7197: --- GitHub user greghogan opened a pull request

[GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...

2017-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4345 [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith() Fix for methods calling the incorrect super function. You can merge this pull request into a Git reposi

[jira] [Assigned] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-14 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan reassigned FLINK-7197: - Assignee: Greg Hogan > Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith() > -

[jira] [Created] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-14 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7197: - Summary: Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith() Key: FLINK-7197 URL: https://issues.apache.org/jira/browse/FLINK-7197 Project: Flink Issue

[jira] [Commented] (FLINK-4641) Support branching CEP patterns

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087676#comment-16087676 ] ASF GitHub Bot commented on FLINK-4641: --- Github user chermenin closed the pull reque

[GitHub] flink pull request #3105: [FLINK-4641] [cep] Support branching CEP patterns

2017-07-14 Thread chermenin
Github user chermenin closed the pull request at: https://github.com/apache/flink/pull/3105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087626#comment-16087626 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087631#comment-16087631 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087628#comment-16087628 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087630#comment-16087630 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087629#comment-16087629 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087633#comment-16087633 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087625#comment-16087625 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087627#comment-16087627 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7185) Activate checkstyle flink-java/io

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087632#comment-16087632 ] ASF GitHub Bot commented on FLINK-7185: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127506234 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java --- @@ -266,42 +269,41 @@ public void ignoreSingleCharPrefixComments(

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127504115 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java --- @@ -21,13 +21,18 @@ import org.apache.flink.annotation.Internal;

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127505784 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/TextOutputFormat.java --- @@ -18,65 +18,73 @@ package org.apache.flink.api.java.io;

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127506011 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CollectionInputFormatTest.java --- @@ -90,18 +94,18 @@ public String toString() { @Te

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127505648 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/TextOutputFormat.java --- @@ -18,65 +18,73 @@ package org.apache.flink.api.java.io;

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127506443 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/FromElementsTest.java --- @@ -18,8 +18,12 @@ package org.apache.flink.api.java.io;

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127504421 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java --- @@ -23,9 +23,32 @@ import org.apache.flink.api.java.ExecutionEnvironme

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127506187 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java --- @@ -224,34 +230,31 @@ private void ignoreInvalidLines(int bufferS

[GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4340#discussion_r127504763 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/PrintingOutputFormat.java --- @@ -18,12 +18,16 @@ package org.apache.flink.api.jav

[jira] [Commented] (FLINK-7174) Bump dependency of Kafka 0.10.x to the latest one

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087618#comment-16087618 ] ASF GitHub Bot commented on FLINK-7174: --- Github user pnowojski commented on the issu

[GitHub] flink issue #4321: [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1

2017-07-14 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4321 @tzulitai could you look at this PR and particularly into last commit (fixup). I'm not a big fan of mocks and mockito based tests and I would really be inclined to just drop this test. --- If you

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087607#comment-16087607 ] ASF GitHub Bot commented on FLINK-6442: --- Github user lincoln-lil commented on the is

[GitHub] flink issue #3829: [FLINK-6442] [table] Extend TableAPI Support Sink Table R...

2017-07-14 Thread lincoln-lil
Github user lincoln-lil commented on the issue: https://github.com/apache/flink/pull/3829 @fhueske, thanks for reviewing this. I read the design doc again, the original idea to support this functionality was doing minimal changes in the current state. Yes, currently a TableSink'

[jira] [Commented] (FLINK-7184) Activate checkstyle flink-java/hadoop

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087606#comment-16087606 ] ASF GitHub Bot commented on FLINK-7184: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4341: [FLINK-7184] Activate checkstyle flink-java/hadoop

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4341#discussion_r127503964 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopOutputFormatTest.java --- @@ -139,10 +141,10 @@ private OutputCommitter s

[jira] [Commented] (FLINK-7190) Activate checkstyle flink-java/*

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087588#comment-16087588 ] ASF GitHub Bot commented on FLINK-7190: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-7190) Activate checkstyle flink-java/*

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087590#comment-16087590 ] ASF GitHub Bot commented on FLINK-7190: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4343: [FLINK-7190] Activate checkstyle flink-java/*

2017-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4343#discussion_r127502548 --- Diff: tools/maven/suppressions-java.xml --- @@ -24,6 +24,9 @@ under the License. + files="ExecutionEnvironment\.java"

[GitHub] flink issue #4343: [FLINK-7190] Activate checkstyle flink-java/*

2017-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4343 @greghogan I agree, expanding the suppression files would be nice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Closed] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-14 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou closed FLINK-7180. - Resolution: Resolved > CoGroupStream perform checkpoint failed > --- >

[jira] [Commented] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-14 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087554#comment-16087554 ] Sihua Zhou commented on FLINK-7180: --- Checked my pom.xml, i'm using Flink 1.3.0 After

[jira] [Updated] (FLINK-7177) DataSetAggregateWithNullValuesRule fails creating null literal for non-nullable type

2017-07-14 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-7177: - Description: For example: {code:title=flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ap

[jira] [Updated] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7180: Fix Version/s: 1.3.2 > CoGroupStream perform checkpoint failed > ---

[jira] [Updated] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7180: Priority: Blocker (was: Major) > CoGroupStream perform checkpoint failed >

[jira] [Commented] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087541#comment-16087541 ] Aljoscha Krettek commented on FLINK-7180: - No problem. Are you 100 % sure that you

[jira] [Closed] (FLINK-6964) Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore

2017-07-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6964. - Resolution: Fixed Fix Version/s: 1.4.0 Merged in 8cff17fcc9. > Fix recovery for incrementa

[jira] [Commented] (FLINK-6964) Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087460#comment-16087460 ] ASF GitHub Bot commented on FLINK-6964: --- Github user StefanRRichter closed the pull

[GitHub] flink pull request #4192: [FLINK-6964] [checkpoint] Fix externalized increme...

2017-07-14 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/4192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Comment Edited] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-14 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087397#comment-16087397 ] Sihua Zhou edited comment on FLINK-7180 at 7/14/17 2:41 PM: [~

[jira] [Commented] (FLINK-7186) Activate checkstyle flink-java/sampling

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087398#comment-16087398 ] ASF GitHub Bot commented on FLINK-7186: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-7180) CoGroupStream perform checkpoint failed

2017-07-14 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087397#comment-16087397 ] Sihua Zhou commented on FLINK-7180: --- [~aljoscha] Sorry to reply late reply, i was on the

[GitHub] flink issue #4339: [FLINK-7186] Activate checkstyle flink-java/sampling

2017-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4339 +1. I'm wondering if we should beef up the `tools/maven/suppressions-java.xml` file to have suppressions per package like flink-runtime, and remove an entry in each PR. Just as a safety preca

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087344#comment-16087344 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087343#comment-16087343 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087346#comment-16087346 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087341#comment-16087341 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087345#comment-16087345 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087342#comment-16087342 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087350#comment-16087350 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087348#comment-16087348 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087349#comment-16087349 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087340#comment-16087340 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087347#comment-16087347 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127446535 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -319,7 +337,7 @@ abstract class BatchTabl

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127460882 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CsvSQLTableSink.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127451116 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -488,19 +499,50 @@ abstract class TableEnviron

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127456171 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala --- @@ -19,9 +19,21 @@ package org.apache.flink.table

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127459823 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/TableWithSQLITCase.scala --- @@ -113,4 +116,31 @@ class Tabl

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127460421 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/UnsupportedSqlTest.scala --- @@ -0,0 +1,53 @@ +/* +

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127449330 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -488,19 +499,50 @@ abstract class TableEnviron

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127448161 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -131,6 +131,25 @@ abstract class StreamT

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127456022 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -488,19 +499,50 @@ abstract class TableEnviron

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127452041 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -488,19 +499,50 @@ abstract class TableEnviron

[GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...

2017-07-14 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3829#discussion_r127448060 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala --- @@ -106,6 +106,24 @@ abstract class BatchTab

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2017-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087339#comment-16087339 ] ASF GitHub Bot commented on FLINK-6951: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2017-07-14 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4150 Hmmm, tricky one. Do parts of the code use different configuration (one instantiates non SSL sockets, the other one assumes SSL sockets)? --- If your project is set up for it, you can reply to t

  1   2   3   >