[jira] [Commented] (FLINK-6938) IterativeCondition should support RichFunction interface

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055236#comment-16055236 ] ASF GitHub Bot commented on FLINK-6938: --- GitHub user wuchong opened a pull request:

[GitHub] flink issue #4135: Flink 6602 -- bug fix

2017-06-19 Thread lmalds
Github user lmalds commented on the issue: https://github.com/apache/flink/pull/4135 Yes, I will. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...

2017-06-19 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4145 [FLINK-6938][FLINK-6939] [cep] Not store IterativeCondition with NFA state and support RichFunction interface The core idea is that the `StateTransition` is unique in a NFA graph. So we store the c

[jira] [Assigned] (FLINK-6922) Enum(Value)SerializerConfigSnapshot uses Java serialization to store enum values

2017-06-19 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-6922: -- Assignee: Tzu-Li (Gordon) Tai > Enum(Value)SerializerConfigSnapshot uses Java s

[jira] [Commented] (FLINK-6936) Add multiple targets support for custom partitioner

2017-06-19 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055230#comment-16055230 ] Xingcan Cui commented on FLINK-6936: For self use, I have added a {{multicast}} method

[GitHub] flink pull request #4121: [FLINK-6904] [cep] Support for quantifier range to...

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6904) Support for quantifier range to CEP's pattern API

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055228#comment-16055228 ] ASF GitHub Bot commented on FLINK-6904: --- Github user asfgit closed the pull request

[jira] [Updated] (FLINK-6939) Not store IterativeCondition with NFA state

2017-06-19 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-6939: --- Fix Version/s: 1.4.0 > Not store IterativeCondition with NFA state > -

[jira] [Updated] (FLINK-6938) IterativeCondition should support RichFunction interface

2017-06-19 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-6938: --- Fix Version/s: 1.4.0 > IterativeCondition should support RichFunction interface >

[jira] [Commented] (FLINK-6948) EnumValueSerializer cannot handle removed enum values

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055221#comment-16055221 ] ASF GitHub Bot commented on FLINK-6948: --- Github user tzulitai commented on the issue

[GitHub] flink issue #4142: [FLINK-6948] Harden EnumValueSerializer to detect changed...

2017-06-19 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4142 The tests are failing due to checkstyle. I'll fix that and address my comments, and run tests locally. If green, will proceed to merge this for `master` and `release-1.3` --- If your project is

[jira] [Updated] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2017-06-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6951: -- Affects Version/s: 1.3.0 Component/s: Kinesis Connector > Incompatible versions of httpcomponents jars

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2017-06-19 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055136#comment-16055136 ] Tzu-Li (Gordon) Tai commented on FLINK-6951: I've replied to the thread. The p

[jira] [Created] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2017-06-19 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6951: - Summary: Incompatible versions of httpcomponents jars for Flink kinesis connector Key: FLINK-6951 URL: https://issues.apache.org/jira/browse/FLINK-6951 Project: Flink Iss

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055105#comment-16055105 ] ASF GitHub Bot commented on FLINK-6682: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4125: [FLINK-6682] [checkpoints] Improve error message in case ...

2017-06-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4125 Thank you so much @zentol . I did learn a lot from those. Also, the code have been updated. Please review. Thanks again. --- If your project is set up for it, you can reply to this email and ha

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055102#comment-16055102 ] ASF GitHub Bot commented on FLINK-6682: --- Github user zhangminglei commented on a dif

[GitHub] flink pull request #4125: [FLINK-6682] [checkpoints] Improve error message i...

2017-06-19 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4125#discussion_r122869047 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java --- @@ -225,7 +225,16 @@ private void assignAtt

[jira] [Commented] (FLINK-6881) Creating a table from a POJO and defining a time attribute fails

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054990#comment-16054990 ] ASF GitHub Bot commented on FLINK-6881: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #4144: [FLINK-6881] [FLINK-6896] [table] Creating a table...

2017-06-19 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4144#discussion_r122852900 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -437,39 +437,64 @@ abstract class

[jira] [Reopened] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reopened FLINK-6930: -- > Selecting window start / end on row-based Tumble/Slide window causes NPE > ---

[jira] [Closed] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6930. Resolution: Fixed Fix Version/s: 1.3.1 Fixed for 1.3.1 with 2321898943c223241794c6a4f38743063

[jira] [Closed] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6602. Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 Fixed for 1.3.1 with c7f6d024

[jira] [Closed] (FLINK-6859) StateCleaningCountTrigger should not delete timer

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6859. Resolution: Fixed Fixed for 1.3.1 with 78b5092dc82fe36412e1d47c1a1fd81ef821d7c6 > StateCleaningCoun

[jira] [Closed] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6886. Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 Fixed for 1.3.1 with 8b91df2b

[jira] [Closed] (FLINK-6941) Selecting window start / end on over window causes field not resolve exception

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6941. Resolution: Fixed Fix Version/s: 1.4.0 1.3.1 Fixed for 1.3.1 with b6d14b91

[jira] [Commented] (FLINK-6881) Creating a table from a POJO and defining a time attribute fails

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054786#comment-16054786 ] ASF GitHub Bot commented on FLINK-6881: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4144: [FLINK-6881] [FLINK-6896] [table] Creating a table...

2017-06-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4144#discussion_r122829892 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -437,39 +437,64 @@ abstract class Stream

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054705#comment-16054705 ] ASF GitHub Bot commented on FLINK-6886: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4137: [FLINK-6941][table]Add validate that the start and...

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4135: Flink 6602 -- bug fix

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4102: [FLINK-6886][table]Fix Timestamp field can not be ...

2017-06-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-6941) Selecting window start / end on over window causes field not resolve exception

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054706#comment-16054706 ] ASF GitHub Bot commented on FLINK-6941: --- Github user asfgit closed the pull request

[jira] [Comment Edited] (FLINK-6402) Consider removing annotation for REAPER_THREAD_LOCK in SafetyNetCloseableRegistry#doRegister()

2017-06-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986965#comment-15986965 ] Ted Yu edited comment on FLINK-6402 at 6/19/17 8:11 PM: Pardon the

[jira] [Commented] (FLINK-6932) Update the inaccessible Dataflow Model paper link

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054292#comment-16054292 ] ASF GitHub Bot commented on FLINK-6932: --- Github user zhangminglei commented on the i

[GitHub] flink issue #4131: [FLINK-6932] [doc] Update inaccessible Dataflow Model pap...

2017-06-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4131 cc @zentol Please take a look. Thank you so much. :cake: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...

2017-06-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4074 @zentol It seems weird why this stuff happened. I have updated the code though. It looks good now. --- If your project is set up for it, you can reply to this email and have your reply appear o

[jira] [Commented] (FLINK-6488) Mark deprecated for 'start-local.sh' and 'stop-local' scripts

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054285#comment-16054285 ] ASF GitHub Bot commented on FLINK-6488: --- Github user zhangminglei commented on the i

[jira] [Updated] (FLINK-6949) Add ability to ship custom resource files to YARN cluster

2017-06-19 Thread Mikhail Pryakhin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Pryakhin updated FLINK-6949: Priority: Critical (was: Major) > Add ability to ship custom resource files to YARN cluster

[jira] [Commented] (FLINK-6896) Creating a table from a POJO and use table sink to output fail

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054220#comment-16054220 ] ASF GitHub Bot commented on FLINK-6896: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4111: [FLINK-6896][table] Fix generate PojoType input result ex...

2017-06-19 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4111 Of course @twalthr , I haven't merged the code and thanks for your new PR. I will have a look tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear o

[jira] [Commented] (FLINK-6418) Support for dynamic state changes in CEP patterns

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054212#comment-16054212 ] ASF GitHub Bot commented on FLINK-6418: --- Github user kl0u commented on the issue:

[GitHub] flink issue #4143: [FLINK-6418][cep] Support for dynamic state changes in CE...

2017-06-19 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4143 Hi @dawidwys ! Thanks for the work. Could you also update the documentation? This will also help the review process. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #4135: Flink 6602 -- bug fix

2017-06-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4135 On more thing. It would be good if you build the flink-table module locally before submitting or updating a PR. The PR fails because some lines exceed the line length limit. Thank you. --- If your

[jira] [Commented] (FLINK-6896) Creating a table from a POJO and use table sink to output fail

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054167#comment-16054167 ] ASF GitHub Bot commented on FLINK-6896: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4111: [FLINK-6896][table] Fix generate PojoType input result ex...

2017-06-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4111 @sunjincheng121 I opened #4144. Feel free to review and test. I really hope that I could cover all cases. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #4144: [FLINK-6881] [FLINK-6896] [table] Creating a table...

2017-06-19 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/4144 [FLINK-6881] [FLINK-6896] [table] Creating a table from a POJO and defining a time attribute fails This PR fixes several issues with POJOs and time attributes. You can merge this pull request into

[jira] [Commented] (FLINK-6881) Creating a table from a POJO and defining a time attribute fails

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054163#comment-16054163 ] ASF GitHub Bot commented on FLINK-6881: --- GitHub user twalthr opened a pull request:

[jira] [Commented] (FLINK-6418) Support for dynamic state changes in CEP patterns

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054161#comment-16054161 ] ASF GitHub Bot commented on FLINK-6418: --- Github user dawidwys commented on the issue

[jira] [Commented] (FLINK-6418) Support for dynamic state changes in CEP patterns

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054160#comment-16054160 ] ASF GitHub Bot commented on FLINK-6418: --- GitHub user dawidwys opened a pull request:

[GitHub] flink issue #4143: [FLINK-6418][cep] Support for dynamic state changes in CE...

2017-06-19 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4143 R: @kl0u --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...

2017-06-19 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/4143 [FLINK-6418][cep] Support for dynamic state changes in CEP patterns Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into considerati

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054146#comment-16054146 ] Fabian Hueske commented on FLINK-6930: -- I'll merge it to 1.3 as well to get the fix i

[jira] [Commented] (FLINK-6896) Creating a table from a POJO and use table sink to output fail

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054145#comment-16054145 ] ASF GitHub Bot commented on FLINK-6896: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #4111: [FLINK-6896][table] Fix generate PojoType input result ex...

2017-06-19 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4111 Hi @twalthr Sounds good, And make sense to me. I think i can do some code review or check some test case when you opened the PR. :) Best, SunJincheng --- If your project is set

[jira] [Commented] (FLINK-6896) Creating a table from a POJO and use table sink to output fail

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054135#comment-16054135 ] ASF GitHub Bot commented on FLINK-6896: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4111: [FLINK-6896][table] Fix generate PojoType input result ex...

2017-06-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4111 @sunjincheng121 Sorry, that I haven't responded earlier. I was on vacation last week. I found a solution that requires less CodeGenerator changes. I found several issues (also regarding Java expressi

[jira] [Commented] (FLINK-6786) Remove duplicate QueryScopeInfoTest

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054128#comment-16054128 ] ASF GitHub Bot commented on FLINK-6786: --- Github user pnowojski commented on a diff i

[GitHub] flink issue #4135: Flink 6602 -- bug fix

2017-06-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4135 thanks for the update @lmalds. I'll add two tests and will merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Commented] (FLINK-6941) Selecting window start / end on over window causes field not resolve exception

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054126#comment-16054126 ] ASF GitHub Bot commented on FLINK-6941: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4137: [FLINK-6941][table]Add validate that the start and end wi...

2017-06-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4137 will merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #4034: [FLINK-6786] [metrics] Deduplicate QueryScopeIntoT...

2017-06-19 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4034#discussion_r122725538 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/metrics/dump/QueryScopeInfoTest.java --- @@ -20,58 +20,140 @@ import org.junit.T

[jira] [Commented] (FLINK-6896) Creating a table from a POJO and use table sink to output fail

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054103#comment-16054103 ] ASF GitHub Bot commented on FLINK-6896: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #4111: [FLINK-6896][table] Fix generate PojoType input result ex...

2017-06-19 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4111 Hi @twalthr I have test this case using the first approach of FLINK-6896. without `as` clause. It's works well. And with the `as` clause, It can be fixed by add a case match in `StreamTableEn

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

2017-06-19 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054078#comment-16054078 ] Fabian Hueske commented on FLINK-6859: -- I'll merge it to 1.3 > StateCleaningCountTri

[jira] [Commented] (FLINK-5892) Recover job state at the granularity of operator

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054070#comment-16054070 ] ASF GitHub Bot commented on FLINK-5892: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #3844: [FLINK-5892] Enable 1.2 keyed state test

2017-06-19 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3844#discussion_r122718852 --- Diff: flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/keyed/KeyedJob.java --- @@ -98,10 +98,9 @@ public static void main(String

[GitHub] flink issue #3712: [FLINK-6281] Create TableSink for JDBC.

2017-06-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3712 Thanks @zentol! I'll have a look at it as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054041#comment-16054041 ] ASF GitHub Bot commented on FLINK-6281: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054032#comment-16054032 ] ASF GitHub Bot commented on FLINK-6888: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4105#discussion_r122712259 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -192,10 +193,14 @@ class BatchTableE

[jira] [Commented] (FLINK-6943) Improve exceptions within TypeExtractionUtils#getSingleAbstractMethod

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054025#comment-16054025 ] ASF GitHub Bot commented on FLINK-6943: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054023#comment-16054023 ] ASF GitHub Bot commented on FLINK-6888: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4140: [FLINK-6943] Improve exceptions within TypeExtract...

2017-06-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4140#discussion_r122711527 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractionUtils.java --- @@ -215,22 +215,33 @@ public static Type extractTypeArgum

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4105#discussion_r122711347 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -358,20 +358,27 @@ abstract class TableEnviron

[GitHub] flink pull request #4140: [FLINK-6943] Improve exceptions within TypeExtract...

2017-06-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4140#discussion_r122707710 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractionUtils.java --- @@ -215,22 +215,33 @@ public static Type extractTypeArgum

[GitHub] flink pull request #4140: [FLINK-6943] Improve exceptions within TypeExtract...

2017-06-19 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4140#discussion_r122708789 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractionUtils.java --- @@ -215,22 +215,33 @@ public static Type extractTypeArg

[jira] [Commented] (FLINK-6943) Improve exceptions within TypeExtractionUtils#getSingleAbstractMethod

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054005#comment-16054005 ] ASF GitHub Bot commented on FLINK-6943: --- Github user dawidwys commented on a diff in

[jira] [Commented] (FLINK-6943) Improve exceptions within TypeExtractionUtils#getSingleAbstractMethod

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053993#comment-16053993 ] ASF GitHub Bot commented on FLINK-6943: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6541) Jar upload directory not created

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053992#comment-16053992 ] ASF GitHub Bot commented on FLINK-6541: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6461) Deprecate web-related configuration defaults in ConfigConstants

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053989#comment-16053989 ] ASF GitHub Bot commented on FLINK-6461: --- Github user zentol commented on a diff in t

[GitHub] flink issue #3894: [FLINK-6541] Improve tmp dir setup in TM/WebMonitor

2017-06-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3894 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[jira] [Commented] (FLINK-6896) Creating a table from a POJO and use table sink to output fail

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053990#comment-16053990 ] ASF GitHub Bot commented on FLINK-6896: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #4111: [FLINK-6896][table] Fix generate PojoType input result ex...

2017-06-19 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4111 @twalthr Thank you for pay attention to this PR. Feel free to left your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flink pull request #3951: [FLINK-6461] Replace usages of deprecated web port...

2017-06-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3951#discussion_r122706584 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -173,7 +173,7 @@ class JobManager( * to run in the

[jira] [Reopened] (FLINK-6859) StateCleaningCountTrigger should not delete timer

2017-06-19 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-6859: - It appears i still didn't merge it. > StateCleaningCountTrigger should not delete timer > ---

[jira] [Commented] (FLINK-5178) allow BlobCache to use a distributed file system irrespective of the HA mode

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053974#comment-16053974 ] ASF GitHub Bot commented on FLINK-5178: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053975#comment-16053975 ] ASF GitHub Bot commented on FLINK-6008: --- Github user zentol commented on the issue:

[GitHub] flink issue #3512: [FLINK-6008] collection of BlobServer improvements

2017-06-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3512 I take it this PR will be subsumed in FLIP-19? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] flink issue #3085: [FLINK-5178] allow BlobCache to use a distributed file sy...

2017-06-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3085 I take it this PR will be subsumed in FLIP-19? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053967#comment-16053967 ] ASF GitHub Bot commented on FLINK-6682: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4125: [FLINK-6682] [checkpoints] Improve error message i...

2017-06-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4125#discussion_r122684131 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java --- @@ -225,7 +225,16 @@ private void assignAttemptSt

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053968#comment-16053968 ] ASF GitHub Bot commented on FLINK-6682: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4125: [FLINK-6682] [checkpoints] Improve error message i...

2017-06-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4125#discussion_r122685535 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java --- @@ -225,7 +225,16 @@ private void assignAttemptSt

[jira] [Commented] (FLINK-6682) Improve error message in case parallelism exceeds maxParallelism

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053966#comment-16053966 ] ASF GitHub Bot commented on FLINK-6682: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #4125: [FLINK-6682] [checkpoints] Improve error message i...

2017-06-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4125#discussion_r122686915 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java --- @@ -225,7 +225,16 @@ private void assignAttemptSt

[GitHub] flink issue #4024: [FLINK-6782][docs] update snapshot documentation to refle...

2017-06-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4024 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[jira] [Commented] (FLINK-6782) Update savepoint documentation

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053963#comment-16053963 ] ASF GitHub Bot commented on FLINK-6782: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6461) Deprecate web-related configuration defaults in ConfigConstants

2017-06-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053962#comment-16053962 ] ASF GitHub Bot commented on FLINK-6461: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #3951: [FLINK-6461] Replace usages of deprecated web port...

2017-06-19 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3951#discussion_r122701964 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -173,7 +173,7 @@ class JobManager( * to run in

  1   2   3   >