[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045848#comment-16045848
]
ASF GitHub Bot commented on FLINK-5776:
---
Github user sunjincheng121 closed the pull
Github user sunjincheng121 closed the pull request at:
https://github.com/apache/flink/pull/3418
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045843#comment-16045843
]
ASF GitHub Bot commented on FLINK-6884:
---
Github user sunjincheng121 commented on the
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4100
HI @fhueske Thanks very much for your reviewing. Update the PR. according
your comments.
Best,
SunJincheng
---
If your project is set up for it, you can reply to this email and h
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045679#comment-16045679
]
ASF GitHub Bot commented on FLINK-6884:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045680#comment-16045680
]
ASF GitHub Bot commented on FLINK-6884:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4100#discussion_r121265361
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -718,16 +718,20 @@ abstract class TableEnviron
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4100#discussion_r121265430
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -936,32 +936,42 @@ class CodeGenerator(
[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045668#comment-16045668
]
Fabian Hueske commented on FLINK-5776:
--
Thanks [~sunjincheng121]. Can you close the P
Github user hsaputra commented on the issue:
https://github.com/apache/flink/pull/4095
@zentol thats just matter of rebasing to feature branches. Not sure how
would you coordinate among all feature branches
---
If your project is set up for it, you can reply to this email and have yo
[
https://issues.apache.org/jira/browse/FLINK-6877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045652#comment-16045652
]
ASF GitHub Bot commented on FLINK-6877:
---
Github user hsaputra commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045626#comment-16045626
]
ASF GitHub Bot commented on FLINK-3551:
---
Github user ch33hau commented on the issue:
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@fhueske very sorry about this decade-long delay... I was working on some
relocation stuff for the past few months.
I have rebased and push a commit for fixing the PR comments:
- Remove
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045587#comment-16045587
]
sunjincheng edited comment on FLINK-6884 at 6/10/17 4:58 PM:
-
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045612#comment-16045612
]
ASF GitHub Bot commented on FLINK-6884:
---
GitHub user sunjincheng121 opened a pull re
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4100
[FLINK-6884][table] Improve confused exception information.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045608#comment-16045608
]
sunjincheng commented on FLINK-6884:
The {{generateResultExpression}} is called by
{{
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045587#comment-16045587
]
sunjincheng edited comment on FLINK-6884 at 6/10/17 3:55 PM:
-
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng reassigned FLINK-6884:
--
Assignee: sunjincheng
> Incompatible TableSource#getReturnType and actual input type should fai
[
https://issues.apache.org/jira/browse/FLINK-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045587#comment-16045587
]
sunjincheng commented on FLINK-6884:
Hi, [~dawidwys] Thanks for your reporting. you ar
Ruben van Vreeland created FLINK-6885:
-
Summary: RMQSource does not support qos, leading to oom
Key: FLINK-6885
URL: https://issues.apache.org/jira/browse/FLINK-6885
Project: Flink
Issue
Dawid Wysakowicz created FLINK-6884:
---
Summary: Incompatible TableSource#getReturnType and actual input
type should fail faster
Key: FLINK-6884
URL: https://issues.apache.org/jira/browse/FLINK-6884
P
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4092
Good catch! The comment same as `DataStream.java`.
+1 to merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
[
https://issues.apache.org/jira/browse/FLINK-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045521#comment-16045521
]
ASF GitHub Bot commented on FLINK-6876:
---
Github user sunjincheng121 commented on the
[
https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045498#comment-16045498
]
mingleizhang edited comment on FLINK-6849 at 6/10/17 11:55 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045498#comment-16045498
]
mingleizhang commented on FLINK-6849:
-
Here is a basic skeleton for the abstract class
[
https://issues.apache.org/jira/browse/FLINK-6488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045494#comment-16045494
]
mingleizhang commented on FLINK-6488:
-
Hey [~Zentol]! I have updated the PR.
> Mark
[
https://issues.apache.org/jira/browse/FLINK-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai updated FLINK-6883:
---
Description:
In the Scala API, serializers are generated using Scala macros (via the
Tzu-Li (Gordon) Tai created FLINK-6883:
--
Summary: Serializer for collection of Scala case classes are
generated with different anonymous class names in 1.3
Key: FLINK-6883
URL: https://issues.apache.org/jira/
[
https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045475#comment-16045475
]
mingleizhang edited comment on FLINK-6849 at 6/10/17 9:49 AM:
--
[
https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045475#comment-16045475
]
mingleizhang edited comment on FLINK-6849 at 6/10/17 9:48 AM:
--
[
https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045475#comment-16045475
]
mingleizhang commented on FLINK-6849:
-
[~tzulitai] [~srichter] I just do a little refa
[
https://issues.apache.org/jira/browse/FLINK-6877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045462#comment-16045462
]
ASF GitHub Bot commented on FLINK-6877:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4095
Please don't merge this or any other runtime related checkstyle PR's over
the weekend. I'm gonna have a chat with @StephanEwen early next week about
which packages we can cover with checkstyle without
[
https://issues.apache.org/jira/browse/FLINK-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045459#comment-16045459
]
mingleizhang commented on FLINK-6849:
-
Yep. [~srichter]. We should have a concrete pla
[
https://issues.apache.org/jira/browse/FLINK-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045431#comment-16045431
]
Hai Zhou commented on FLINK-6860:
-
[~mingmxu] , the website code is at https://github.com
36 matches
Mail list logo
