[
https://issues.apache.org/jira/browse/FLINK-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974177#comment-15974177
]
ASF GitHub Bot commented on FLINK-6196:
---
Github user clarkyzl commented on a diff in
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r112126252
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -135,8 +135,11 @@ abstract class TableFunc
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974156#comment-15974156
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974157#comment-15974157
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974159#comment-15974159
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974152#comment-15974152
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974155#comment-15974155
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974154#comment-15974154
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974160#comment-15974160
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974158#comment-15974158
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974153#comment-15974153
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974161#comment-15974161
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123126
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@ -559,48
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122515
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38 +29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123595
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26 +21
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123170
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@ -559,48
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112121870
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38 +29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123765
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26 +21
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122128
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38 +29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122730
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -66,31 +80,
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122336
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38 +29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122018
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38 +29
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974124#comment-15974124
]
mingleizhang commented on FLINK-6311:
-
[~tzulitai] Thanks for telling me so useful inf
[
https://issues.apache.org/jira/browse/FLINK-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974103#comment-15974103
]
Bowen Li commented on FLINK-5095:
-
I'll spend time in the following few days to see how ot
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Addressed @zentol 's comments. Ready for another round. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3736#discussion_r112115930
--- Diff: flink-metrics/flink-metrics-datadog/pom.xml ---
@@ -0,0 +1,85 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="htt
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3736#discussion_r112115925
--- Diff: docs/monitoring/metrics.md ---
@@ -436,6 +436,38 @@ metrics.reporter.stsd.port: 8125
{% endhighlight %}
+### Datadog (org.apa
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974069#comment-15974069
]
Tzu-Li (Gordon) Tai commented on FLINK-6311:
the {{flink-connector-kinesis}} m
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingleizhang reassigned FLINK-6311:
---
Assignee: mingleizhang
> NPE in FlinkKinesisConsumer if source was closed before run
> --
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974012#comment-15974012
]
mingleizhang commented on FLINK-6311:
-
[~tzulitai] I just watch FlinkKinesisConsumer w
[
https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kurt Young closed FLINK-6149.
-
Resolution: Implemented
Fix Version/s: 1.3.0
> add additional flink logical relation nodes
> --
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974000#comment-15974000
]
ASF GitHub Bot commented on FLINK-6149:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973988#comment-15973988
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tony810430 commented on the iss
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3001
Hi @tzulitai ,
I have rebased it and updated to the public API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973982#comment-15973982
]
hongyuhong commented on FLINK-6232:
---
Hi [~fhueske] i have implement it use normal timest
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3001
Hi @tony810430,
The exposure for union list state was just merged to master.
Could you rebase this? Once rebased I'll do a full review so that we can
finally work towards merging this :)
--
[
https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973954#comment-15973954
]
ASF GitHub Bot commented on FLINK-6250:
---
Github user hongyuhong commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973955#comment-15973955
]
ASF GitHub Bot commented on FLINK-6250:
---
Github user hongyuhong commented on a diff
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112103318
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238 @@
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112105029
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238 @@
[
https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973953#comment-15973953
]
ASF GitHub Bot commented on FLINK-6250:
---
Github user hongyuhong commented on a diff
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112105763
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -1140,6 +1140,202 @@ class SqlITC
[
https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973956#comment-15973956
]
ASF GitHub Bot commented on FLINK-6250:
---
Github user hongyuhong commented on a diff
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112105507
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0 +1,238 @@
[
https://issues.apache.org/jira/browse/FLINK-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai resolved FLINK-6324.
Resolution: Fixed
Fix Version/s: 1.3.0
Resolved for 1.3.0 with
http://git-wi
[
https://issues.apache.org/jira/browse/FLINK-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai resolved FLINK-5991.
Resolution: Fixed
Resolved for 1.3.0 with
http://git-wip-us.apache.org/repos/asf/fl
[
https://issues.apache.org/jira/browse/FLINK-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973949#comment-15973949
]
ASF GitHub Bot commented on FLINK-5991:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3508
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973937#comment-15973937
]
mingleizhang edited comment on FLINK-6130 at 4/19/17 2:36 AM:
--
[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973937#comment-15973937
]
mingleizhang commented on FLINK-6130:
-
[~Zentol] [~till.rohrmann] That makes sense to
Tzu-Li (Gordon) Tai created FLINK-6324:
--
Summary: Refine state access methods in OperatorStateStore
Key: FLINK-6324
URL: https://issues.apache.org/jira/browse/FLINK-6324
Project: Flink
I
[
https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973910#comment-15973910
]
ASF GitHub Bot commented on FLINK-6149:
---
Github user KurtYoung commented on the issu
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3594
Rebased to master and will merge after build check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973846#comment-15973846
]
ASF GitHub Bot commented on FLINK-6242:
---
Github user shaoxuan-wang commented on the
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3735
@fhueske thanks for your feedback.
Yes, we could keep GeneratedAggregations interface very clean as
```
abstract class GeneratedAggregations extends Function {
def setAggregati
[
https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973832#comment-15973832
]
ASF GitHub Bot commented on FLINK-6295:
---
Github user WangTaoTheTonic commented on th
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3709
Ok i think i've got your point.
Now using WeakHashMap, we add entries when the map doesn't contain the
requested EG id, remove invalid entries when GC happens.
By adding `sm
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3736#discussion_r112083224
--- Diff:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java
---
@@ -0,0 +1,30 @@
+/*
+ * Licen
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973662#comment-15973662
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973658#comment-15973658
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973656#comment-15973656
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973659#comment-15973659
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973655#comment-15973655
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973665#comment-15973665
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973664#comment-15973664
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973657#comment-15973657
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973660#comment-15973660
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973661#comment-15973661
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973663#comment-15973663
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112080959
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/RetractionITCase.scala
---
@@ -0,0 +1,310 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112081457
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/RetractionITCase.scala
---
@@ -0,0 +1,310 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112078731
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -41,14 +41,16 @@ class Gr
[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973654#comment-15973654
]
ASF GitHub Bot commented on FLINK-6091:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112078707
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -41,14 +41,16 @@ class Gr
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112080186
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -84,16 +109,38 @@ class G
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112065725
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -129,11 +131,17 @@ cl
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112079294
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -84,16 +109,38 @@ class G
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112078358
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -68,12 +70,35 @@ class Gr
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112065233
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
---
@@ -152,6 +161,7 @@ public void serialize(Row record,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112081928
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/RetractionITCase.scala
---
@@ -0,0 +1,310 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112064885
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -107,6 +107,14
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r112060500
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
---
@@ -152,6 +161,7 @@ public void serialize(Row record,
[
https://issues.apache.org/jira/browse/FLINK-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973569#comment-15973569
]
ASF GitHub Bot commented on FLINK-6032:
---
Github user tedyu commented on a diff in th
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3541#discussion_r112071560
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/SubEvent.java ---
@@ -31,6 +31,18 @@ public double getVolume() {
}
[
https://issues.apache.org/jira/browse/FLINK-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973566#comment-15973566
]
ASF GitHub Bot commented on FLINK-6032:
---
Github user tedyu commented on a diff in th
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3541#discussion_r112071274
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -385,4 +393,25 @@ public int hashC
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3736#discussion_r112065478
--- Diff: flink-metrics/flink-metrics-datadog/pom.xml ---
@@ -0,0 +1,85 @@
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http:/
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3736#discussion_r112065330
--- Diff: docs/monitoring/metrics.md ---
@@ -436,6 +436,38 @@ metrics.reporter.stsd.port: 8125
{% endhighlight %}
+### Datadog (org.apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3736#discussion_r112065890
--- Diff:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java
---
@@ -0,0 +1,30 @@
+/*
+ * Licensed
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3736
If you want to enforce a specific scope config then i would suggest to
instead ignore the configured one (which means not using
`MetricGroup#getMetricIdentifier()`) and instead extracting the variable
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
Great advice. Thanks, @zentol !
My questions to your suggestions:
1. If I make DatadogHttpReport implement MetricReporter interface, shall I
just ignore Histogram and Meter which are
Github user kimlng commented on the issue:
https://github.com/apache/flink/pull/3737
Pulled request accidentally. Need to revert this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user kimlng closed the pull request at:
https://github.com/apache/flink/pull/3737
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user kimlng opened a pull request:
https://github.com/apache/flink/pull/3737
Release 1.2
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account
[
https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973424#comment-15973424
]
ASF GitHub Bot commented on FLINK-6242:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3735#discussion_r112002278
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggReduceGroupFunction.scala
---
@@ -145
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3735#discussion_r111986866
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -263,33 +263,56 @@ class CodeGenerator(
[
https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973421#comment-15973421
]
ASF GitHub Bot commented on FLINK-6242:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3735#discussion_r112002408
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideTimeWindowAggReduceGroupFunction.scala
---
@@ -38,
1 - 100 of 427 matches
Mail list logo
