[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-03-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r107597005 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala --- @@ -0,0 +1,

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937817#comment-15937817 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff

[jira] [Assigned] (FLINK-6101) GroupBy fields with arithmetic expression (include UDF) can not be selected

2017-03-22 Thread lincoln.lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln.lee reassigned FLINK-6101: -- Assignee: lincoln.lee > GroupBy fields with arithmetic expression (include UDF) can not be sele

[jira] [Commented] (FLINK-6089) Implement decoration phase for rewriting predicated logical plan after volcano optimization phase

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937799#comment-15937799 ] ASF GitHub Bot commented on FLINK-6089: --- Github user shaoxuan-wang commented on a di

[GitHub] flink pull request #3564: [FLINK-6089] [table] Implement decoration phase fo...

2017-03-22 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3564#discussion_r107594707 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -162,6 +162,27 @@ abstract class TableEn

[GitHub] flink issue #3599: [FLINK-6174][HA]introduce a new election service to make ...

2017-03-22 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/3599 Hi, @WangTaoTheTonic I think we can improve the reaction of ZookeeperLeaderElectionService on zookeeper connection expired or other errors instead of introducing the AlwaysLeaderService such as add

[GitHub] flink issue #3574: [FLINK-5653] Add processing time OVER ROWS BETWEEN x PREC...

2017-03-22 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3574 Hi, @fhueske Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937702#comment-15937702 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on the

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937699#comment-15937699 ] ASF GitHub Bot commented on FLINK-5654: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107586054 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -119,6 +150,57

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-03-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r107585318 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala --- @@ -0,0

[jira] [Commented] (FLINK-6174) Introduce a leader election service in yarn mode to make JobManager always available

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937694#comment-15937694 ] ASF GitHub Bot commented on FLINK-6174: --- Github user wenlong88 commented on the issu

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937691#comment-15937691 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a d

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937677#comment-15937677 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-03-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r107584162 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala --- @@ -0,0 +1,

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937672#comment-15937672 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-03-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r107583714 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -317,4 +320,193 @@ class SqlITCas

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937661#comment-15937661 ] ASF GitHub Bot commented on FLINK-6117: --- GitHub user zhengcanbin opened a pull reque

[GitHub] flink pull request #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disabl...

2017-03-22 Thread zhengcanbin
GitHub user zhengcanbin opened a pull request: https://github.com/apache/flink/pull/3600 [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work correctly The value of 'zookeeper.sasl.disable' not used in the right way when starting CuratorFramework. When 'zookeeper.sasl.disable'

[jira] [Commented] (FLINK-5990) Add [partitioned] event time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937659#comment-15937659 ] ASF GitHub Bot commented on FLINK-5990: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #3585: [FLINK-5990][table]Add event time OVER ROWS BETWEEN x PRE...

2017-03-22 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3585 Hi @fhueske, in our point of view, register timer should be correlated to the event time of the CURRENT data, but not currentWaterMark (which is correlated to the event time of the PREVIOUS da

[GitHub] flink pull request #3599: [FLINK-6174][HA]introduce a new election service t...

2017-03-22 Thread WangTaoTheTonic
GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/flink/pull/3599 [FLINK-6174][HA]introduce a new election service to make JobManager always available Now in yarn mode, if we use zookeeper as high availability choice, it will create a election service to

[jira] [Commented] (FLINK-6174) Introduce a leader election service in yarn mode to make JobManager always available

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937640#comment-15937640 ] ASF GitHub Bot commented on FLINK-6174: --- GitHub user WangTaoTheTonic opened a pull r

[jira] [Created] (FLINK-6174) Introduce a leader election service in yarn mode to make JobManager always available

2017-03-22 Thread Tao Wang (JIRA)
Tao Wang created FLINK-6174: --- Summary: Introduce a leader election service in yarn mode to make JobManager always available Key: FLINK-6174 URL: https://issues.apache.org/jira/browse/FLINK-6174 Project: Fli

[jira] [Commented] (FLINK-6173) flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414

2017-03-22 Thread Zhenghua Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937601#comment-15937601 ] Zhenghua Gao commented on FLINK-6173: - It may be a trick question of maven-shade-plugi

[jira] [Created] (FLINK-6173) flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414

2017-03-22 Thread Zhenghua Gao (JIRA)
Zhenghua Gao created FLINK-6173: --- Summary: flink-table not pack-in com.fasterxml.jackson.* in after #FLINK-5414 Key: FLINK-6173 URL: https://issues.apache.org/jira/browse/FLINK-6173 Project: Flink

[GitHub] flink issue #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPos#setPo...

2017-03-22 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/3595 @greghogan thanks for the review, I have changed the change test to use explicit buffer size. you are right that currently there is no dependency on this method. We used the ByteArrayOutputStre

[jira] [Commented] (FLINK-6162) Fix bug in ByteArrayOutputStreamWithPos#setPosition

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937546#comment-15937546 ] ASF GitHub Bot commented on FLINK-6162: --- Github user wenlong88 commented on the issu

[jira] [Commented] (FLINK-4953) Allow access to "time" in ProcessWindowFunction.Context

2017-03-22 Thread Manu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937516#comment-15937516 ] Manu Zhang commented on FLINK-4953: --- [~aljoscha], yes, I'd love to. I'll assign it to m

[jira] [Assigned] (FLINK-4953) Allow access to "time" in ProcessWindowFunction.Context

2017-03-22 Thread Manu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manu Zhang reassigned FLINK-4953: - Assignee: Manu Zhang > Allow access to "time" in ProcessWindowFunction.Context >

[jira] [Commented] (FLINK-6159) Add Java/Scala FlinkLauncher

2017-03-22 Thread CanBin Zheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937512#comment-15937512 ] CanBin Zheng commented on FLINK-6159: - Got it, tks > Add Java/Scala FlinkLauncher > -

[jira] [Commented] (FLINK-6172) Potentially unclosed RandomAccessFile in HistoryServerStaticFileServerHandler

2017-03-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937299#comment-15937299 ] Ted Yu commented on FLINK-6172: --- Similar problem exists in StaticFileServerHandler.java > P

[jira] [Created] (FLINK-6172) Potentially unclosed RandomAccessFile in HistoryServerStaticFileServerHandler

2017-03-22 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6172: - Summary: Potentially unclosed RandomAccessFile in HistoryServerStaticFileServerHandler Key: FLINK-6172 URL: https://issues.apache.org/jira/browse/FLINK-6172 Project: Flink

[jira] [Commented] (FLINK-6115) Need more helpful error message when trying to serialize a tuple with a null field

2017-03-22 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937185#comment-15937185 ] Luke Hutchison commented on FLINK-6115: --- bq. Why do you think there is no penalty to

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937108#comment-15937108 ] ASF GitHub Bot commented on FLINK-5654: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107531063 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala --- @@ -0,0

[GitHub] flink pull request #3575: [FLINK-6117]Make setting of 'zookeeper.sasl.disabl...

2017-03-22 Thread zhengcanbin
Github user zhengcanbin closed the pull request at: https://github.com/apache/flink/pull/3575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2252: [FLINK-3466] [runtime] Cancel state handled on state rest...

2017-03-22 Thread liuml07
Github user liuml07 commented on the issue: https://github.com/apache/flink/pull/2252 Is this related to https://issues.apache.org/jira/browse/HADOOP-14214? Thanks, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-6170) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937056#comment-15937056 ] ASF GitHub Bot commented on FLINK-6170: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3597: [FLINK-6170] [metrics] Don't rely on stats snapsho...

2017-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3597 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-6170) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-6170. -- Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 Fixed in d0695c0 (master), 7fbb11

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937042#comment-15937042 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on a diff in

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107517633 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala --- @@ -0,

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107519046 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -29,6 +29,60 @@ class Win

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937041#comment-15937041 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on a diff in

[jira] [Commented] (FLINK-3466) Job might get stuck in restoreState() from HDFS due to interrupt

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937040#comment-15937040 ] ASF GitHub Bot commented on FLINK-3466: --- Github user liuml07 commented on the issue:

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107518911 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala --- @@ -0,

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107518499 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedProcessingOverProcessFunction.scala --- @@ -0,

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937038#comment-15937038 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on a diff in

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937027#comment-15937027 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on a diff in

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937020#comment-15937020 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on a diff in

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107516906 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -119,6 +150,57 @@ cl

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2017-03-22 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937005#comment-15937005 ] Robert Metzger commented on FLINK-5067: --- This JIRA disabled the automatic profile ac

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937003#comment-15937003 ] ASF GitHub Bot commented on FLINK-6117: --- Github user zhengcanbin closed the pull req

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936954#comment-15936954 ] ASF GitHub Bot commented on FLINK-5972: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107506662 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java --- @@ -122,6 +121,19 @@ pu

[GitHub] flink issue #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3587 Thanks a lot for addressing my comments @aljoscha! That's so much cleaner now :-D Really like the refactoring in the fixes. I actually didn't realize the mock stubs and util methods were

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936943#comment-15936943 ] ASF GitHub Bot commented on FLINK-5972: --- Github user tzulitai commented on the issue

[jira] [Commented] (FLINK-5890) GatherSumApply broken when object reuse enabled

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936909#comment-15936909 ] ASF GitHub Bot commented on FLINK-5890: --- Github user greghogan commented on the issu

[GitHub] flink issue #3515: [FLINK-5890] [gelly] GatherSumApply broken when object re...

2017-03-22 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3515 Not an issue of spilling memory but at least three elements are required to trigger two reduces and the error condition depends on which value is returned. @StephanEwen is this a +1? ---

[GitHub] flink pull request #3598: [Flink-6103] LocalFileSystem rename() uses File.re...

2017-03-22 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/3598 [Flink-6103] LocalFileSystem rename() uses File.renameTo() Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-03-22 Thread Flavio Pompermaier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936845#comment-15936845 ] Flavio Pompermaier commented on FLINK-6103: --- Maybe also BlobServerConnection cou

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936803#comment-15936803 ] ASF GitHub Bot commented on FLINK-5972: --- Github user aljoscha commented on the issue

[GitHub] flink issue #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3587 Thanks for the thorough review, @tzulitai! And shame over my head for all the code duplication 😱 I now refactored the contract tests into a base class and addressed all the issu

[jira] [Assigned] (FLINK-5886) Python API for streaming applications

2017-03-22 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-5886: --- Assignee: Zohar Mizrahi > Python API for streaming applications > ---

[jira] [Commented] (FLINK-6167) Consider removing ArchivedExecutionGraph classes

2017-03-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936800#comment-15936800 ] Stephan Ewen commented on FLINK-6167: - If the classes are not used any more I would sa

[jira] [Commented] (FLINK-6170) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936743#comment-15936743 ] ASF GitHub Bot commented on FLINK-6170: --- Github user uce commented on the issue:

[GitHub] flink issue #3597: [FLINK-6170] [metrics] Don't rely on stats snapshot for c...

2017-03-22 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3597 Thanks, will merge after Travis gives a green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (FLINK-6170) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936736#comment-15936736 ] ASF GitHub Bot commented on FLINK-6170: --- Github user aljoscha commented on the issue

[GitHub] flink issue #3597: [FLINK-6170] [metrics] Don't rely on stats snapshot for c...

2017-03-22 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3597 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936706#comment-15936706 ] ASF GitHub Bot commented on FLINK-5972: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107475345 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0 +1,

[jira] [Commented] (FLINK-6170) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936702#comment-15936702 ] ASF GitHub Bot commented on FLINK-6170: --- GitHub user uce opened a pull request:

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107474350 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0 +1,

[GitHub] flink pull request #3597: [FLINK-6170] [metrics] Don't rely on stats snapsho...

2017-03-22 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3597 [FLINK-6170] [metrics] Don't rely on stats snapshot for checkpoint metrics Some checkpoint metrics use the latest stats snapshot to get the returned metric value. In practice, this means that these metr

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936701#comment-15936701 ] ASF GitHub Bot commented on FLINK-5972: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107473789 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0 +1,

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936699#comment-15936699 ] ASF GitHub Bot commented on FLINK-5972: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936684#comment-15936684 ] ASF GitHub Bot commented on FLINK-5972: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107471533 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0 +1,

[jira] [Commented] (FLINK-6151) The zookeeper occur a warning when one node of zookeeper server is down

2017-03-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936682#comment-15936682 ] Stephan Ewen commented on FLINK-6151: - Isn't that ZooKeeper's default behavior? What

[jira] [Closed] (FLINK-6171) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-6171. -- Resolution: Duplicate > Some checkpoint metrics rely on latest stat snapshot > -

[jira] [Assigned] (FLINK-6170) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-6170: -- Assignee: Ufuk Celebi > Some checkpoint metrics rely on latest stat snapshot >

[jira] [Created] (FLINK-6171) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-6171: -- Summary: Some checkpoint metrics rely on latest stat snapshot Key: FLINK-6171 URL: https://issues.apache.org/jira/browse/FLINK-6171 Project: Flink Issue Type: Bu

[jira] [Created] (FLINK-6170) Some checkpoint metrics rely on latest stat snapshot

2017-03-22 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-6170: -- Summary: Some checkpoint metrics rely on latest stat snapshot Key: FLINK-6170 URL: https://issues.apache.org/jira/browse/FLINK-6170 Project: Flink Issue Type: Bu

[jira] [Commented] (FLINK-6159) Add Java/Scala FlinkLauncher

2017-03-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936644#comment-15936644 ] Stephan Ewen commented on FLINK-6159: - As Robert mentioned, the original plan was to h

[jira] [Commented] (FLINK-6168) Make flink-core independent of Avro

2017-03-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936638#comment-15936638 ] Stephan Ewen commented on FLINK-6168: - +1 We can actually do that even before Flink 2

[jira] [Updated] (FLINK-6169) yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error

2017-03-22 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6169: -- Component/s: YARN > yarnClient should be stopped in AbstractYarnClusterDescriptor in case of err

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936580#comment-15936580 ] ASF GitHub Bot commented on FLINK-5654: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #3590: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3590#discussion_r107454410 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -29,6 +29,60 @@ cla

[jira] [Created] (FLINK-6169) yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error

2017-03-22 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6169: - Summary: yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error Key: FLINK-6169 URL: https://issues.apache.org/jira/browse/FLINK-6169 Project: Flink

[jira] [Commented] (FLINK-6115) Need more helpful error message when trying to serialize a tuple with a null field

2017-03-22 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936558#comment-15936558 ] Greg Hogan commented on FLINK-6115: --- Qualifying the following by noting that we are disc

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936555#comment-15936555 ] ASF GitHub Bot commented on FLINK-5972: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936554#comment-15936554 ] ASF GitHub Bot commented on FLINK-5972: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107450020 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java --- @@ -138,7 +138,7 @@ *

[GitHub] flink pull request #3587: [FLINK-5972] Don't allow shrinking merging windows

2017-03-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3587#discussion_r107450009 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorContractTest.java --- @@ -0,0 +1,

[jira] [Created] (FLINK-6168) Make flink-core independent of Avro

2017-03-22 Thread Timo Walther (JIRA)
Timo Walther created FLINK-6168: --- Summary: Make flink-core independent of Avro Key: FLINK-6168 URL: https://issues.apache.org/jira/browse/FLINK-6168 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-5977) Rename MAX_ATTEMPTS_HISTORY_SIZE key

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936542#comment-15936542 ] ASF GitHub Bot commented on FLINK-5977: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3592: [FLINK-5977] Rename MAX_ATTEMPTS_HISTORY_SIZE key

2017-03-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3592 Thanks for the pull request. This has actually already been fixed in https://github.com/apache/flink/commit/81a143f6b42cf39d56a36222d14b5db0cc54addb The commit also retains the old ke

[jira] [Commented] (FLINK-5972) Don't allow shrinking merging windows

2017-03-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936537#comment-15936537 ] ASF GitHub Bot commented on FLINK-5972: --- Github user aljoscha commented on a diff in

  1   2   3   >