[GitHub] flink pull request #2720: [FLINK-4623] Create Physical Execution Plan of a D...

2016-10-28 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2720#discussion_r85633731 --- Diff: flink-libraries/flink-table/src/test/scala/resources/testUnionStream0.out --- @@ -2,3 +2,21 @@ LogicalUnion(all=[true]) LogicalTableScan

[jira] [Commented] (FLINK-4623) Create Physical Execution Plan of a DataStream

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617412#comment-15617412 ] ASF GitHub Bot commented on FLINK-4623: --- Github user wuchong commented on a diff in

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617351#comment-15617351 ] ASF GitHub Bot commented on FLINK-4743: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-10-28 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2686 Hi @tonycox , I think the POWER_DEC could be fixed in Flink side. That's why I said we need to implement a `power(double, BigDecimal)` method in Flink. And bind BuiltInMethods.POWER_DEC to the new

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-10-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617287#comment-15617287 ] Jark Wu commented on FLINK-4469: Actually, the PR can work with {{LATERAL}} at present. {{

[jira] [Comment Edited] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2016-10-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506583#comment-15506583 ] Ted Yu edited comment on FLINK-4534 at 10/29/16 1:02 AM: - Feel fre

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616495#comment-15616495 ] ASF GitHub Bot commented on FLINK-4221: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616494#comment-15616494 ] ASF GitHub Bot commented on FLINK-4221: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616493#comment-15616493 ] ASF GitHub Bot commented on FLINK-4221: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2724: [FLINK-4221] Show metrics in WebFrontend + general...

2016-10-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2724#discussion_r85606565 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java --- @@ -383,25 +384,28 @@ private void conne

[GitHub] flink pull request #2724: [FLINK-4221] Show metrics in WebFrontend + general...

2016-10-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2724#discussion_r85604825 --- Diff: flink-runtime-web/web-dashboard/app/scripts/index.coffee --- @@ -39,6 +39,8 @@ angular.module('flinkApp', ['ui.router', 'angularMoment']) .run (J

[GitHub] flink pull request #2724: [FLINK-4221] Show metrics in WebFrontend + general...

2016-10-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2724#discussion_r85604628 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/socket/SocketWindowWordCount.java --- @@ -30,7 +30,7 @@

[jira] [Commented] (FLINK-4963) Tabulate edge direction for directed VertexMetrics

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616195#comment-15616195 ] ASF GitHub Bot commented on FLINK-4963: --- GitHub user greghogan opened a pull request

[GitHub] flink pull request #2725: [FLINK-4963] [gelly] Tabulate edge direction for d...

2016-10-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2725 [FLINK-4963] [gelly] Tabulate edge direction for directed VertexMetrics The current implementation simply counts edges. We can do one better and tabulate unidirectional (u:v but no v:u) and bidire

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616101#comment-15616101 ] ASF GitHub Bot commented on FLINK-4743: --- GitHub user tonycox reopened a pull request

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-28 Thread tonycox
GitHub user tonycox reopened a pull request: https://github.com/apache/flink/pull/2686 [FLINK-4743] The sqrt/power function not accept the real data types. Add supporting of variety types on "power" function. Add casting for Float and BigDecimal. You can merge this pull request int

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616097#comment-15616097 ] ASF GitHub Bot commented on FLINK-4743: --- Github user tonycox closed the pull request

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-28 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/2686 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615980#comment-15615980 ] ASF GitHub Bot commented on FLINK-4743: --- Github user tonycox commented on the issue:

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-10-28 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2686 Hi @wuchong I agree that users can cast types manually. And that BuiltInMethods.POWER_DEC should be bound power(double, BigDecimal), but it's trouble of Calcite https://issues.apache.org/j

[jira] [Commented] (FLINK-4221) Show metrics in WebFrontend

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615958#comment-15615958 ] ASF GitHub Bot commented on FLINK-4221: --- GitHub user rmetzger opened a pull request:

[jira] [Commented] (FLINK-4910) Introduce safety net for closing file system streams

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615957#comment-15615957 ] ASF GitHub Bot commented on FLINK-4910: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2691: [FLINK-4910] Introduce safety net for closing file...

2016-10-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2691#discussion_r85570641 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java --- @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2724: [FLINK-4221] Show metrics in WebFrontend + general...

2016-10-28 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2724 [FLINK-4221] Show metrics in WebFrontend + general improvements Other included changes: - Removed Properties tab - Renamed plan to overview - Added parallelism to task list Scre

[jira] [Created] (FLINK-4963) Tabulate edge direction for directed VertexMetrics

2016-10-28 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4963: - Summary: Tabulate edge direction for directed VertexMetrics Key: FLINK-4963 URL: https://issues.apache.org/jira/browse/FLINK-4963 Project: Flink Issue Type: Improv

[jira] [Commented] (FLINK-4887) Replace ActorGateway by TaskManagerGateway interface

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615871#comment-15615871 ] ASF GitHub Bot commented on FLINK-4887: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2699: [FLINK-4887] [execution graph] Introduce TaskManagerGatew...

2016-10-28 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2699 Thanks for the review @StephanEwen. You're right that I should have tested the changes on a cluster to make sure that things are actually working. I'll address your comments and then run jobs wi

[jira] [Commented] (FLINK-4887) Replace ActorGateway by TaskManagerGateway interface

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615868#comment-15615868 ] ASF GitHub Bot commented on FLINK-4887: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4887) Replace ActorGateway by TaskManagerGateway interface

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615867#comment-15615867 ] ASF GitHub Bot commented on FLINK-4887: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2699: [FLINK-4887] [execution graph] Introduce TaskManag...

2016-10-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2699#discussion_r85564343 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/StackTraceSampleResponse.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to t

[GitHub] flink pull request #2699: [FLINK-4887] [execution graph] Introduce TaskManag...

2016-10-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2699#discussion_r85564373 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/StackTrace.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Soft

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615842#comment-15615842 ] ASF GitHub Bot commented on FLINK-4743: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-10-28 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2686 According to the question mentioned in the dev mailing. I prefer to approach 2). POWER only works on double. And `power(double, BigDecimal)` is only used to support `SQRT(double)` which is actually

[GitHub] flink pull request #2699: [FLINK-4887] [execution graph] Introduce TaskManag...

2016-10-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2699#discussion_r85562718 --- Diff: flink-tests/src/test/resources/log4j-test.properties --- @@ -18,7 +18,7 @@ # Set root logger level to OFF to not flood build logs

[jira] [Commented] (FLINK-4887) Replace ActorGateway by TaskManagerGateway interface

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615835#comment-15615835 ] ASF GitHub Bot commented on FLINK-4887: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4743) The sqrt/power function not accept the real data types.

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615807#comment-15615807 ] ASF GitHub Bot commented on FLINK-4743: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-10-28 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2686 Hi @fhueske @tonycox , the PR is really good. But I think the true reason of this issue is because the `BuiltInMethods.POWER_DEC` is bound to a wrong method, which should be `power(double,

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615730#comment-15615730 ] Fabian Hueske commented on FLINK-4604: -- Hi [~anmu], thanks for digging into this. Re

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-10-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615695#comment-15615695 ] Fabian Hueske commented on FLINK-4469: -- Thanks [~jark], this is great news! How do w

[jira] [Updated] (FLINK-4962) Improve exception information about operand type inference failure during UDF SQL validation

2016-10-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-4962: --- Summary: Improve exception information about operand type inference failure during UDF SQL validation (was: I

[jira] [Created] (FLINK-4962) Improve exception information about operand type inference failed in UDF SQL validation

2016-10-28 Thread Jark Wu (JIRA)
Jark Wu created FLINK-4962: -- Summary: Improve exception information about operand type inference failed in UDF SQL validation Key: FLINK-4962 URL: https://issues.apache.org/jira/browse/FLINK-4962 Project: Fl

[jira] [Commented] (FLINK-4942) Improve processing performance of HeapInternalTimerService with key groups

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615623#comment-15615623 ] ASF GitHub Bot commented on FLINK-4942: --- Github user kl0u commented on the issue:

[GitHub] flink issue #2702: [FLINK-4942] Improve processing performance of HeapIntern...

2016-10-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2702 Are we sure that this is going to lead to improvements? I understand that both cases have pros and cons, as in one case we pay the price at each arriving timer, while in the other you pay it at once upo

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615598#comment-15615598 ] ASF GitHub Bot commented on FLINK-4563: --- Github user ex00 commented on a diff in the

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615606#comment-15615606 ] ASF GitHub Bot commented on FLINK-4563: --- Github user zentol commented on the issue:

[GitHub] flink issue #2650: [FLINK-4563] [metrics] scope caching not adjusted for mul...

2016-10-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2650 don't cache any filter; we will assume that a single reporter will only pass identical filters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #2650: [FLINK-4563] [metrics] scope caching not adjusted ...

2016-10-28 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/2650#discussion_r85543811 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java --- @@ -169,19 +176,7 @@ public String getMetricIdentifie

[GitHub] flink issue #2650: [FLINK-4563] [metrics] scope caching not adjusted for mul...

2016-10-28 Thread ex00
Github user ex00 commented on the issue: https://github.com/apache/flink/pull/2650 @StephanEwen, @zentol thanks for your comments! Do need caching only first filter or don't cache any filter? --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615536#comment-15615536 ] ASF GitHub Bot commented on FLINK-4563: --- Github user ex00 commented on the issue:

[jira] [Updated] (FLINK-4961) SGD for Matrix Factorization

2016-10-28 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Hermann updated FLINK-4961: - Description: We have started an implementation of distributed stochastic gradient descent for mat

[jira] [Created] (FLINK-4961) SGD for Matrix Factorization

2016-10-28 Thread JIRA
Gábor Hermann created FLINK-4961: Summary: SGD for Matrix Factorization Key: FLINK-4961 URL: https://issues.apache.org/jira/browse/FLINK-4961 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-3617) NPE from CaseClassSerializer when dealing with null Option field

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615505#comment-15615505 ] ASF GitHub Bot commented on FLINK-3617: --- GitHub user chermenin opened a pull request

[GitHub] flink pull request #2723: [FLINK-3617] Simple fix for OptionSerializer.

2016-10-28 Thread chermenin
GitHub user chermenin opened a pull request: https://github.com/apache/flink/pull/2723 [FLINK-3617] Simple fix for OptionSerializer. This fix prevent possible NullPointerException at serialization process, but after deserialization Option variable will be initialized with None value

[GitHub] flink pull request #2700: [FLINK-4933] [exec graph] Don't let the EG fail in...

2016-10-28 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2700#discussion_r85533357 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -917,8 +917,15 @@ class JobManager( case ScheduleOrUp

[jira] [Commented] (FLINK-4933) ExecutionGraph.scheduleOrUpdateConsumers can fail the ExecutionGraph

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615486#comment-15615486 ] ASF GitHub Bot commented on FLINK-4933: --- Github user uce commented on a diff in the

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615479#comment-15615479 ] ASF GitHub Bot commented on FLINK-4563: --- Github user zentol commented on the issue:

[jira] [Created] (FLINK-4960) Enable testing of different re-scaling scenarios in the AbstractStreamOperatorTestHarness to

2016-10-28 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-4960: - Summary: Enable testing of different re-scaling scenarios in the AbstractStreamOperatorTestHarness to Key: FLINK-4960 URL: https://issues.apache.org/jira/browse/FLINK-4960

[GitHub] flink pull request #2650: [FLINK-4563] [metrics] scope caching not adjusted ...

2016-10-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2650#discussion_r85533501 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java --- @@ -169,19 +176,7 @@ public String getMetricIdentif

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615476#comment-15615476 ] ASF GitHub Bot commented on FLINK-4563: --- Github user zentol commented on a diff in t

[GitHub] flink issue #2650: [FLINK-4563] [metrics] scope caching not adjusted for mul...

2016-10-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2650 In hindsight I agree with @StephanEwen that caching the filter may be a bit overkill. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615475#comment-15615475 ] ASF GitHub Bot commented on FLINK-4563: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2650: [FLINK-4563] [metrics] scope caching not adjusted ...

2016-10-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2650#discussion_r85533847 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java --- @@ -101,6 +105,8 @@ public AbstractMetricGroup(Metr

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615477#comment-15615477 ] ASF GitHub Bot commented on FLINK-4563: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2650: [FLINK-4563] [metrics] scope caching not adjusted ...

2016-10-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2650#discussion_r85533745 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java --- @@ -85,9 +86,12 @@ * For example ["host-7

[jira] [Commented] (FLINK-4845) Fix Job Exceptions page

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615458#comment-15615458 ] ASF GitHub Bot commented on FLINK-4845: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #2722: [FLINK-4845] [runtime-web] Fix Job Exception page

2016-10-28 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2722 [FLINK-4845] [runtime-web] Fix Job Exception page You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 4845_exception Alternatively you

[jira] [Assigned] (FLINK-4845) Fix Job Exceptions page

2016-10-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-4845: --- Assignee: Chesnay Schepler > Fix Job Exceptions page > --- > >

[GitHub] flink issue #2711: [backport] [FLINK-4932] [exec graph] Failing in state RES...

2016-10-28 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2711 Code changes and updated figure look good to me. +1 to merge after Travis passes. It makes sense that for instance a job with infinite restarts will only be failed if the job is explicitly suspended or f

[jira] [Commented] (FLINK-4932) Don't let ExecutionGraph fail when in state Restarting

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615441#comment-15615441 ] ASF GitHub Bot commented on FLINK-4932: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4958) Send slot report to RM when registering

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615382#comment-15615382 ] ASF GitHub Bot commented on FLINK-4958: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #2721: [FLINK-4958] [tm] Send slot report to RM when regi...

2016-10-28 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2721 [FLINK-4958] [tm] Send slot report to RM when registering Create a `SlotReport` in the `TaskSlotTable` when trying to register at the `ResourceManager`. The `SlotReport` contains for each `Task

[jira] [Updated] (FLINK-4621) Improve decimal literals of SQL API

2016-10-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-4621: --- Assignee: (was: Jark Wu) > Improve decimal literals of SQL API > --- > >

[jira] [Assigned] (FLINK-4713) Implementing ranking evaluation scores for recommender systems

2016-10-28 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Hermann reassigned FLINK-4713: Assignee: Gábor Hermann > Implementing ranking evaluation scores for recommender systems >

[GitHub] flink issue #2718: [hotfix] Fixes the TimestampedInputSplit.EOS comparison.

2016-10-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2718 @mxm I agree and I am planning to do it as soon as we fix some other design issues with the ContinuousFileReadOperator that concern rescaling. Thanks for the review. --- If your project is set up for

[GitHub] flink issue #2715: Fix timely flatmap issues

2016-10-28 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2715 @manuzhang I added some more fixes because I realised some more stuff is missing. If you want to have a look. (You don't have to, just FYI.) --- If your project is set up for it, you can reply to t

[jira] [Created] (FLINK-4959) Write Documentation for Timely FlatMap Functions

2016-10-28 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-4959: --- Summary: Write Documentation for Timely FlatMap Functions Key: FLINK-4959 URL: https://issues.apache.org/jira/browse/FLINK-4959 Project: Flink Issue Ty

[GitHub] flink pull request #2718: [hotfix] Fixes the TimestampedInputSplit.EOS compa...

2016-10-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2718#discussion_r85523016 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/TimestampedFileInputSplitTest.java --- @@ -90,4 +112,60 @@ public void testIllegalArgumen

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-28 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615302#comment-15615302 ] Anton Mushin commented on FLINK-4604: - For correct calculate standard deviation/varian

[GitHub] flink issue #2718: [hotfix] Fixes the TimestampedInputSplit.EOS comparison.

2016-10-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2718 I think we should get rid of the magic `EOF` split. We should simply set a flag in the reader to stop reading. Until then, this looks like a good fix. --- If your project is set up for it, you can reply

[GitHub] flink pull request #2720: [FLINK-4623] Create Physical Execution Plan of a D...

2016-10-28 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/2720 [FLINK-4623] Create Physical Execution Plan of a DataStream You can merge this pull request into a Git repository by running: $ git pull https://github.com/tonycox/flink FLINK-4623 Alternativ

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-28 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615280#comment-15615280 ] Anton Mushin commented on FLINK-4604: - I found rootcause problems occur only in query

[jira] [Created] (FLINK-4958) Send slot report to RM when registering

2016-10-28 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4958: Summary: Send slot report to RM when registering Key: FLINK-4958 URL: https://issues.apache.org/jira/browse/FLINK-4958 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-4623) Create Physical Execution Plan of a DataStream

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615275#comment-15615275 ] ASF GitHub Bot commented on FLINK-4623: --- GitHub user tonycox opened a pull request:

[GitHub] flink issue #2715: Fix timely flatmap issues

2016-10-28 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/flink/pull/2715 Thanks for pinging me with quick fix. This looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (FLINK-4957) Provide API for TimelyCoFlatMapFunction

2016-10-28 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-4957: --- Summary: Provide API for TimelyCoFlatMapFunction Key: FLINK-4957 URL: https://issues.apache.org/jira/browse/FLINK-4957 Project: Flink Issue Type: Test

[GitHub] flink pull request #2719: [FLINK-4954] [rpc] Discard messages when AkkaRpcAc...

2016-10-28 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2719 [FLINK-4954] [rpc] Discard messages when AkkaRpcActor is in state Processing.STOP When the AkkaRpcActor receives a message while being in state Processing.STOP it will discard it and send

[jira] [Assigned] (FLINK-4712) Implementing ranking predictions for ALS

2016-10-28 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Hermann reassigned FLINK-4712: Assignee: Gábor Hermann > Implementing ranking predictions for ALS > --

[jira] [Commented] (FLINK-4954) Remove stashing from AkkaRpcActor

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615221#comment-15615221 ] ASF GitHub Bot commented on FLINK-4954: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #2717: [FLINK-4956] Enhance StreamTaskTestHarness with ea...

2016-10-28 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/2717 [FLINK-4956] Enhance StreamTaskTestHarness with easy snapshot/restore… Introduces checkpoint/restore facilities in StreamTaskTestHarness to simplify the testing of this functionality. You

[GitHub] flink pull request #2718: [hotfix] Fixes the TimestampedInputSplit.EOS compa...

2016-10-28 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2718 [hotfix] Fixes the TimestampedInputSplit.EOS comparison. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cont_fix Alternatively you can

[GitHub] flink pull request #2716: Fix for [FLINK-4894] [network] Don't request buffe...

2016-10-28 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2716 Fix for [FLINK-4894] [network] Don't request buffer after writing to partition This re-opens #2690. After merging, we noticed that the test were broken by the changed `hasData` check. This is

[jira] [Commented] (FLINK-4894) Don't block on buffer request after broadcastEvent

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615213#comment-15615213 ] ASF GitHub Bot commented on FLINK-4894: --- GitHub user uce opened a pull request:

[jira] [Commented] (FLINK-4956) Introduce convenient methods for testing checkpoint/restore in StreamTaskTestHarness

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615217#comment-15615217 ] ASF GitHub Bot commented on FLINK-4956: --- GitHub user StefanRRichter opened a pull re

[jira] [Created] (FLINK-4956) Introduce convenient methods for testing checkpoint/restore in StreamTaskTestHarness

2016-10-28 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-4956: - Summary: Introduce convenient methods for testing checkpoint/restore in StreamTaskTestHarness Key: FLINK-4956 URL: https://issues.apache.org/jira/browse/FLINK-4956

[GitHub] flink issue #2439: [FLINK-4450]update storm verion to 1.0.0 in flink-storm a...

2016-10-28 Thread liuyuzhong
Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen Fixed. Help me to review it please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-4450) update storm version to 1.0.0

2016-10-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615205#comment-15615205 ] ASF GitHub Bot commented on FLINK-4450: --- Github user liuyuzhong commented on the iss

[GitHub] flink pull request #2715: Fix timely flatmap issues

2016-10-28 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2715 Fix timely flatmap issues R: @manuzhang for review, mostly for the updated Javadoc comment You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljos

[jira] [Created] (FLINK-4955) Add Translations Tests for KeyedStream.flatMap(TimelyFlatMapFunction)

2016-10-28 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-4955: --- Summary: Add Translations Tests for KeyedStream.flatMap(TimelyFlatMapFunction) Key: FLINK-4955 URL: https://issues.apache.org/jira/browse/FLINK-4955 Project: Fl

[GitHub] flink pull request #2713: [FLINK-4445] Add option to ignore unmapped checkpo...

2016-10-28 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2713 [FLINK-4445] Add option to ignore unmapped checkpoint state Backport of #2712 for `release-1.1`. Technically, this adds new behaviour to a bugfix release, but the default behaviour is not chang

[GitHub] flink pull request #2445: [FLINK-4544] Refactor old CPU metric initializatio...

2016-10-28 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/2445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

  1   2   >