[jira] [Commented] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356640#comment-15356640 ] ASF GitHub Bot commented on FLINK-3675: --- Github user stefanobaghino commented on the

[GitHub] flink issue #2187: [FLINK-3675][yarn] improvements to library shipping

2016-06-29 Thread stefanobaghino
Github user stefanobaghino commented on the issue: https://github.com/apache/flink/pull/2187 Awesome, thanks for addressing the issue @mxm! I noticed you added a couple of environment variables, could it make sense to document them? --- If your project is set up for it, you can repl

[jira] [Commented] (FLINK-3792) RowTypeInfo equality should not depend on field names

2016-06-29 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356552#comment-15356552 ] Jark Wu commented on FLINK-3792: Do we need this before 1.1.0 release ? If yes, I can tak

[jira] [Commented] (FLINK-4130) CallGenerator could generate illegal code when taking no operands

2016-06-29 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356540#comment-15356540 ] ramkrishna.s.vasudevan commented on FLINK-4130: --- Oh I see. No problem. > Ca

[jira] [Commented] (FLINK-4130) CallGenerator could generate illegal code when taking no operands

2016-06-29 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356537#comment-15356537 ] Jark Wu commented on FLINK-4130: It seems that cody has pulled a request for this issue:

[jira] [Commented] (FLINK-4130) CallGenerator could generate illegal code when taking no operands

2016-06-29 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356535#comment-15356535 ] ramkrishna.s.vasudevan commented on FLINK-4130: --- I can take this up if the f

[jira] [Commented] (FLINK-3674) Add an interface for EventTime aware User Function

2016-06-29 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356513#comment-15356513 ] ramkrishna.s.vasudevan commented on FLINK-3674: --- [~aljoscha] Thanks for the

[GitHub] flink issue #2182: [Flink-4130] CallGenerator could generate illegal code wh...

2016-06-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2182 Yah... the `isNull$17` is not declared if we do what I said above, and of course will throw compile error. The code looks good to me now, although it looks a little weird that `$nullTerm`

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356385#comment-15356385 ] ASF GitHub Bot commented on FLINK-3943: --- Github user wuchong commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69065352 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -236,6 +236,32 @@ case class Aggregate(

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-29 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2179 This problem appears occasionally when i build source code, but not always. The modified line corrects the right directory of `.git`. In the case where maven using the plugin, this fix is neccessa

[jira] [Commented] (FLINK-4128) compile error about git-commit-id-plugin

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356383#comment-15356383 ] ASF GitHub Bot commented on FLINK-4128: --- Github user gallenvara commented on the iss

[GitHub] flink issue #2182: [Flink-4130] CallGenerator could generate illegal code wh...

2016-06-29 Thread unsleepy22
Github user unsleepy22 commented on the issue: https://github.com/apache/flink/pull/2182 @wuchong although I agree this bug could be fixed by adding `operands.nonEmpty`, there is a problem in generated code, specifically, an undeclared variable will be generated like this: ```

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356225#comment-15356225 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on the issue:

[GitHub] flink issue #1813: [FLINK-3034] Redis Sink Connector

2016-06-29 Thread mjsax
Github user mjsax commented on the issue: https://github.com/apache/flink/pull/1813 @rmetzger What about this failing tests... ``` JMXReporterTest.testJMXAvailability:148 » Runtime Could not start JMX server o... ``` Seems, there is no JIRA -- known issue? -- or no is

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356209#comment-15356209 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2169 Hi @mushketyk, thanks for the PR! I added a few comments inline. Best, Fabian @wuchong, thanks for reviewing! --- If your project is set up for it, you can reply to this email and have y

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69048813 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SetOperationsITCase.scala --- @@ -139,4 +154,105 @@ class UnionIT

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356205#comment-15356205 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356206#comment-15356206 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69048797 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SetOperationsITCase.scala --- @@ -139,4 +154,105 @@ class UnionIT

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69048653 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SetOperationsITCase.scala --- @@ -61,14 +62,28 @@ class UnionITCa

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356202#comment-15356202 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356199#comment-15356199 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356197#comment-15356197 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356196#comment-15356196 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69048442 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/SetOperationsITCase.scala --- @@ -61,14 +62,28 @@ class UnionITCa

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69048368 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/SetOperationsITCase.scala --- @@ -121,4 +121,66 @@ class UnionITCas

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69048325 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/SetOperationsITCase.scala --- @@ -121,4 +121,66 @@ class UnionITCas

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356190#comment-15356190 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69048019 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala --- @@ -1353,6 +1353,16 @@ class DataSet[T: ClassTag](set: JavaDataSet[T]) {

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356188#comment-15356188 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69047875 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -426,6 +426,49 @@ class Table( } /**

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356182#comment-15356182 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69047691 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -426,6 +426,49 @@ class Table( } /**

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356180#comment-15356180 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69047560 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetMinusRule.scala --- @@ -0,0 +1,64 @@ +/* +

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69047378 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetMinus.scala --- @@ -0,0 +1,106 @@ +/* + * L

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69046225 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1193,21 +1196,46 @@ public long count() throws Exception { o

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355986#comment-15355986 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355947#comment-15355947 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69045985 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -236,6 +236,32 @@ case class Aggregate(

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69045241 --- Diff: docs/apis/table.md --- @@ -873,7 +920,7 @@ val result = tableEnv.sql( Limitations -The current version of streaming SQL onl

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69044780 --- Diff: docs/apis/table.md --- @@ -536,6 +536,29 @@ Table result = left.unionAll(right); + Minus + +

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69044111 --- Diff: docs/apis/table.md --- @@ -536,6 +536,29 @@ Table result = left.unionAll(right); + Minus + +

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355944#comment-15355944 ] ASF GitHub Bot commented on FLINK-3943: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69043528 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1193,21 +1196,46 @@ public long count() throws Exception { o

[jira] [Commented] (FLINK-4103) Modify CsvTableSource to implement StreamTableSource

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355942#comment-15355942 ] ASF GitHub Bot commented on FLINK-4103: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2162: FLINK-4103: Modify CsvTableSource to implement StreamTabl...

2016-06-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2162 @fhueske Yes, I can shepherd this PR soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink issue #2162: FLINK-4103: Modify CsvTableSource to implement StreamTabl...

2016-06-29 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2162 Thanks for the PR @smarthi. Looks good to me. I'm traveling right now and do not have my dev machine with me. Can somebody else check this PR as well and merge it? Thanks, Fabian --- If you

[jira] [Commented] (FLINK-4103) Modify CsvTableSource to implement StreamTableSource

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355932#comment-15355932 ] ASF GitHub Bot commented on FLINK-4103: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355920#comment-15355920 ] ASF GitHub Bot commented on FLINK-3942: --- Github user fhueske commented on the issue:

[GitHub] flink issue #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2159 Hi @wuchong, thanks for the update! The PR looks mostly good. I left a few minor comments. Thanks, Fabian --- If your project is set up for it, you can reply to this email and have your rep

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355911#comment-15355911 ] ASF GitHub Bot commented on FLINK-3942: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69039259 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -471,6 +471,32 @@ class Table( } /**

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355907#comment-15355907 ] ASF GitHub Bot commented on FLINK-3942: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69039071 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -446,9 +446,9 @@ class Table( } /**

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355889#comment-15355889 ] ASF GitHub Bot commented on FLINK-3942: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355890#comment-15355890 ] ASF GitHub Bot commented on FLINK-3942: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69037753 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -83,66 +82,68 @@ class DataS

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69037698 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -83,66 +82,68 @@ class DataS

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69036989 --- Diff: docs/apis/table.md --- @@ -535,6 +535,30 @@ Table result = left.unionAll(right); + + Intersect +

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355875#comment-15355875 ] ASF GitHub Bot commented on FLINK-3942: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3942) Add support for INTERSECT

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355876#comment-15355876 ] ASF GitHub Bot commented on FLINK-3942: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69037003 --- Diff: docs/apis/table.md --- @@ -535,6 +535,30 @@ Table result = left.unionAll(right); + + Intersect +

[jira] [Assigned] (FLINK-3873) Add a Kafka TableSink with Avro serialization

2016-06-29 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mushketyk reassigned FLINK-3873: - Assignee: Ivan Mushketyk > Add a Kafka TableSink with Avro serialization > --

[jira] [Commented] (FLINK-3873) Add a Kafka TableSink with Avro serialization

2016-06-29 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355835#comment-15355835 ] Ivan Mushketyk commented on FLINK-3873: --- Thank you for your reply. I'll work on it.

[jira] [Commented] (FLINK-4029) Multi-field "sum" function just like "keyBy"

2016-06-29 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355830#comment-15355830 ] Ivan Mushketyk commented on FLINK-4029: --- Could you please provide an example of how

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

2016-06-29 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r69023616 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java --- @@ -87,1

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 Updated documentation as suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

2016-06-29 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r69022373 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisCommand.java --- @@ -0,

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

2016-06-29 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r69022016 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisCommand.java --- @@ -0,

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-29 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r69021580 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetMinus.scala --- @@ -0,0 +1,106 @@ +/* + *

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r69015248 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355723#comment-15355723 ] ASF GitHub Bot commented on FLINK-3618: --- Github user vasia commented on the issue:

[GitHub] flink issue #2184: [FLINK-3618] [gelly] Rename abstract UDF classes in Scatt...

2016-06-29 Thread vasia
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2184 Thanks a lot @greghogan. Everything looks good. Can you please update the docs too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[jira] [Commented] (FLINK-1759) Execution statistics for vertex-centric iterations

2016-06-29 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355714#comment-15355714 ] Greg Hogan commented on FLINK-1759: --- Are we still looking to add to the web frontend per

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-29 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355673#comment-15355673 ] Vasia Kalavri commented on FLINK-1707: -- Thanks [~joseprupi]. If you could document th

[jira] [Commented] (FLINK-3879) Native implementation of HITS algorithm

2016-06-29 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355664#comment-15355664 ] Vasia Kalavri commented on FLINK-3879: -- You and I are the only Gelly component "sheph

[jira] [Commented] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355580#comment-15355580 ] ASF GitHub Bot commented on FLINK-3675: --- GitHub user mxm opened a pull request:

[GitHub] flink pull request #2187: [FLINK-3675][yarn] improvements to library shippin...

2016-06-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2187 [FLINK-3675][yarn] improvements to library shipping - always ship the lib folder - properly setup the classpath from the supplied ship files - cleanup deploy() method of YarnClusterDescriptor

[jira] [Commented] (FLINK-1337) Create an Amazon EMR Bootstrap Action

2016-06-29 Thread Timur Fayruzov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355546#comment-15355546 ] Timur Fayruzov commented on FLINK-1337: --- I have created a gist for the Flink setup t

[jira] [Commented] (FLINK-3397) Failed streaming jobs should fall back to the most recent checkpoint/savepoint

2016-06-29 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355534#comment-15355534 ] ramkrishna.s.vasudevan commented on FLINK-3397: --- [~uce] Any feedback here. I

[jira] [Commented] (FLINK-4116) Document metrics

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355496#comment-15355496 ] ASF GitHub Bot commented on FLINK-4116: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2158: [FLINK-4116] Metrics documentation

2016-06-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2158#discussion_r68987851 --- Diff: docs/apis/common/index.md --- @@ -1350,3 +1350,397 @@ You may specify program arguments before the job is executed. The plan visualiza the execu

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355493#comment-15355493 ] ASF GitHub Bot commented on FLINK-1550: --- Github user zentol commented on the issue:

[GitHub] flink issue #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2146 That is a known and intended behavior. It is the users responsibility to make sure that no naming conflicts arise, either by providing unique job/task/operator names or modifying the scope formats.

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355475#comment-15355475 ] ASF GitHub Bot commented on FLINK-1550: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68984285 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java --- @@ -0,0 +1,249 @@ +/* + * Licensed to the Apac

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355473#comment-15355473 ] ASF GitHub Bot commented on FLINK-1550: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68983836 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java --- @@ -0,0 +1,249 @@ +/* + * Licensed to the Apac

[jira] [Commented] (FLINK-4116) Document metrics

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355470#comment-15355470 ] ASF GitHub Bot commented on FLINK-4116: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4116) Document metrics

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355468#comment-15355468 ] ASF GitHub Bot commented on FLINK-4116: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4116) Document metrics

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355469#comment-15355469 ] ASF GitHub Bot commented on FLINK-4116: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4116) Document metrics

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355467#comment-15355467 ] ASF GitHub Bot commented on FLINK-4116: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355464#comment-15355464 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #2158: [FLINK-4116] Metrics documentation

2016-06-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2158 The documentation has reached a really good state. I had only some minor comments left. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2146 I've tested the job manager metrics and everything seems to work :-) I noticed, however, that it is not possible to submit two jobs with the same job name and obtaining their metrics. A

[GitHub] flink pull request #2158: [FLINK-4116] Metrics documentation

2016-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2158#discussion_r68981623 --- Diff: docs/apis/common/index.md --- @@ -1350,3 +1350,397 @@ You may specify program arguments before the job is executed. The plan visualiza the

[GitHub] flink pull request #2158: [FLINK-4116] Metrics documentation

2016-06-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2158#discussion_r68981861 --- Diff: docs/apis/common/index.md --- @@ -1350,3 +1350,397 @@ You may specify program arguments before the job is executed. The plan visualiza the

  1   2   3   >