[
https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170415#comment-15170415
]
ASF GitHub Bot commented on FLINK-3179:
---
Github user ramkrish86 commented on a diff
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r54329786
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public DriverSt
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r54329750
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupReduceITCase.java
---
@@ -434,6 +431,95 @@ public void
testCorrectnessOfG
[
https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170413#comment-15170413
]
ASF GitHub Bot commented on FLINK-3179:
---
Github user ramkrish86 commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170412#comment-15170412
]
ASF GitHub Bot commented on FLINK-3179:
---
Github user ramkrish86 commented on the pul
Github user ramkrish86 commented on the pull request:
https://github.com/apache/flink/pull/1553#issuecomment-189599549
@fhueske
Could you give some examples for the above use case where the partition is
an input to more than one function?
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/FLINK-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek resolved FLINK-3527.
-
Resolution: Fixed
Fix Version/s: 1.0.0
Added in
https://github.com/apache/flink/co
[
https://issues.apache.org/jira/browse/FLINK-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170116#comment-15170116
]
ASF GitHub Bot commented on FLINK-3527:
---
Github user aljoscha closed the pull reques
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
[
https://issues.apache.org/jira/browse/FLINK-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek resolved FLINK-3528.
-
Resolution: Fixed
Fix Version/s: 1.0.0
Implemented in
https://github.com/apache/fl
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-3521.
---
Resolution: Fixed
Fix Version/s: 1.0.0
Resolved in http://git-wip-us.apache.org/repos/a
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170066#comment-15170066
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170056#comment-15170056
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189520303
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3526.
-
Resolution: Fixed
Fixed via 64519e1c1593471bc21ef78c7c93591fb75a4fcf
> ProcessingTime Window Assi
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3526.
---
> ProcessingTime Window Assigner and Trigger are broken
>
Aljoscha Krettek created FLINK-3528:
---
Summary: Add Incremental Fold for Non-Keyed Window Operator
Key: FLINK-3528
URL: https://issues.apache.org/jira/browse/FLINK-3528
Project: Flink
Issue
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169729#comment-15169729
]
ASF GitHub Bot commented on FLINK-3526:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169724#comment-15169724
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189465103
Let's merge this and open a follow-up issue for (1)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169723#comment-15169723
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189464956
I think (2) can be done easier if the operator creation code goes into
something more generic, but that is not that urgent.
---
If your project is set up for it, yo
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169714#comment-15169714
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user aljoscha commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169712#comment-15169712
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189463014
1. Is very hard to fix, ditching the non-keyed window operators altogether
and using a dummy key selector would be easier.
---
If your project is set up for it, you ca
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189462738
The `PassThroughFunction` is created because at that point it is not yet
clear what type of `InternalWindowFunction` will be created. I can fix it by
duplicating all th
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169696#comment-15169696
]
ASF GitHub Bot commented on FLINK-3526:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189460270
Okay, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169694#comment-15169694
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189459860
I like this, especially the natural Scala path. Some concerns, though:
1. As noted before, the fold function in the non-keyed window is not
space constant.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189458811
Yes, this is correct. (about the fold() on non-keyed windows)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169691#comment-15169691
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user aljoscha commented on the pull
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1728
[FLINK-3527] Add Scala DataStream.transform()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink scala-transform
Alternatively you
[
https://issues.apache.org/jira/browse/FLINK-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169678#comment-15169678
]
ASF GitHub Bot commented on FLINK-3527:
---
GitHub user aljoscha opened a pull request:
Aljoscha Krettek created FLINK-3527:
---
Summary: Scala DataStream has no transform method
Key: FLINK-3527
URL: https://issues.apache.org/jira/browse/FLINK-3527
Project: Flink
Issue Type: Impr
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169665#comment-15169665
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189454876
May be unrelated to this change, but I think `fold()` for non-keyed windows
is not incremental, meaning it has no constant space requirement.
---
If your project is
[
https://issues.apache.org/jira/browse/FLINK-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-3511.
---
Resolution: Fixed
Fix Version/s: 1.0.0
Resolved in
https://github.com/apache/flink/com
[
https://issues.apache.org/jira/browse/FLINK-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169656#comment-15169656
]
ASF GitHub Bot commented on FLINK-3511:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1725
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1719
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169637#comment-15169637
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user StephanEwen commented on a diff
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189447408
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1723#discussion_r54291015
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/function/AllWindowFunction.scala
---
@@ -0,0 +1,45 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169633#comment-15169633
]
ASF GitHub Bot commented on FLINK-3526:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189447001
It was removed in the first commit that changed the interplay with
StreamTimeCharacteristic
---
If your project is set up for it, you can reply to this email and have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189447041
Looks good, but I need a few more minutes to check this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169634#comment-15169634
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user StephanEwen commented on the pu
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169630#comment-15169630
]
ASF GitHub Bot commented on FLINK-3526:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189446394
That flag was removed during the state refactoring, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189445750
It worked before because of this setProcessingTime flag in the
WindowOperator that would put the current processing time into that timestamp
field.
The changes
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169627#comment-15169627
]
ASF GitHub Bot commented on FLINK-3526:
---
Github user aljoscha commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169622#comment-15169622
]
ASF GitHub Bot commented on FLINK-3526:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189444692
Trigger used unassigned event time before, but the trigger itself is only
used in few cases at all.
---
If your project is set up for it, you can reply to this emai
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169620#comment-15169620
]
ASF GitHub Bot commented on FLINK-3526:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1727#issuecomment-189444303
Which time was the trigger using before?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169614#comment-15169614
]
ASF GitHub Bot commented on FLINK-3521:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169615#comment-15169615
]
ASF GitHub Bot commented on FLINK-3443:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1726#issuecomment-189442780
I am not sure if we should abort the `fail(...)` call in state
`JobStatus.CANCELLING`. A cancelling that is stuck can currently be aborted
through `fail()`...
---
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1723#issuecomment-189442607
Scrolled over the changes, didn't spot anything suspicious
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
[
https://issues.apache.org/jira/browse/FLINK-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169580#comment-15169580
]
ASF GitHub Bot commented on FLINK-3526:
---
GitHub user StephanEwen opened a pull reque
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1727
[FLINK-3526] [streaming] Fix Processing Time Window Assigner and Trigger
Fixed the processing time window assigner to use actual processing time
Fixed the processing time trigger to fire
Stephan Ewen created FLINK-3526:
---
Summary: ProcessingTime Window Assigner and Trigger are broken
Key: FLINK-3526
URL: https://issues.apache.org/jira/browse/FLINK-3526
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169440#comment-15169440
]
ASF GitHub Bot commented on FLINK-3519:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-189400067
Good idea to update these comments.
I am not quite sure even, if Tuple subclasses have to be POJOs.
---
If your project is set up for it, you can reply to t
[
https://issues.apache.org/jira/browse/FLINK-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3525.
-
Resolution: Fixed
Assignee: Stephan Ewen
Fix Version/s: 1.0.0
Fixed via 5e769b383e
[
https://issues.apache.org/jira/browse/FLINK-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3522.
---
> Storm examples "PrintSampleStream" throws an error if called without arguments
> ---
[
https://issues.apache.org/jira/browse/FLINK-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3522.
-
Resolution: Fixed
Fixed via 6a28a6f406379f66215f80a1b5725686838da115
> Storm examples "PrintSampl
[
https://issues.apache.org/jira/browse/FLINK-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3525.
---
> Missing call to super#close() in
> TimestampsAndPeriodicWatermarksOperator#close()
> --
[
https://issues.apache.org/jira/browse/FLINK-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169431#comment-15169431
]
Stephan Ewen commented on FLINK-3525:
-
Thanks for noticing, just fixed it...
> Missin
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169422#comment-15169422
]
ASF GitHub Bot commented on FLINK-3511:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1725#issuecomment-189396303
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
[
https://issues.apache.org/jira/browse/FLINK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169399#comment-15169399
]
ASF GitHub Bot commented on FLINK-3390:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-3390.
--
Resolution: Fixed
Fixed via c2a43c95de9b7616b5249cbb190fc0203030bf40
> Savepoint resume is not
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1720
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-3390:
-
Assignee: Ufuk Celebi
> Savepoint resume is not retried
> ---
>
>
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1720#issuecomment-189385219
Changes look good to me. Good work @uce :-) Will merge it to the master and
the release branch.
---
If your project is set up for it, you can reply to this email a
[
https://issues.apache.org/jira/browse/FLINK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169382#comment-15169382
]
ASF GitHub Bot commented on FLINK-3390:
---
Github user tillrohrmann commented on the p
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1725#issuecomment-189383383
+1 to merge once travis passes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169376#comment-15169376
]
ASF GitHub Bot commented on FLINK-3511:
---
Github user rmetzger commented on the pull
Ted Yu created FLINK-3525:
-
Summary: Missing call to super#close() in
TimestampsAndPeriodicWatermarksOperator#close()
Key: FLINK-3525
URL: https://issues.apache.org/jira/browse/FLINK-3525
Project: Flink
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189375282
+1 to merge this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189375154
I'm okay with not including it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169322#comment-15169322
]
ASF GitHub Bot commented on FLINK-:
---
Github user fhueske commented on the pull r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1721#issuecomment-189372643
Yes @greghogan, that's why I changed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169321#comment-15169321
]
ASF GitHub Bot commented on FLINK-:
---
Github user ggevay commented on the pull re
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1721#issuecomment-189372008
Oops, you are right!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
[
https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169304#comment-15169304
]
ASF GitHub Bot commented on FLINK-:
---
Github user greghogan commented on the pull
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1721#issuecomment-189366853
What if that JoinFunction is chained to a MapFunction that modifies its
inputs? It is the probe-side record which needs protecting, and the example
user function emits
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189353549
Concerning the `maven-antrun-plugin`, I think it wouldn't hurt to include
it. However, it might also simply disappear under all the other maven console
output.
--
[
https://issues.apache.org/jira/browse/FLINK-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169252#comment-15169252
]
ASF GitHub Bot commented on FLINK-3443:
---
GitHub user uce opened a pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1719#issuecomment-189352536
Thanks for the review @zentol, @StephanEwen and @rmetzger. I've changed the
comment.
Concerning the documentation, there is already a note about the `build-
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1726
[FLINK-3443] [runtime] Prevent cancelled jobs from restarting
This is one part of #1669 for which we have consensus I think. It would be
good to have it in the next RC. @rmetzger ran into this issue. It
[
https://issues.apache.org/jira/browse/FLINK-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169244#comment-15169244
]
ASF GitHub Bot commented on FLINK-3511:
---
GitHub user tillrohrmann opened a pull requ
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1725
[FLINK-3511] Create example module for Gelly's examples and move connector
examples to test scope
This PR creates an example module for Gelly's examples. The new module sets
the required depen
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-189326695
I have also added that a subclass of TupleN can only be a POJO. (see
TypeExtractor.java:1686)
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169202#comment-15169202
]
ASF GitHub Bot commented on FLINK-3519:
---
Github user ggevay commented on the pull re
1 - 100 of 231 matches
Mail list logo
