[jira] [Commented] (FLINK-2754) FixedLengthRecordSorter can not write to output cross MemorySegments.

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907350#comment-14907350 ] ASF GitHub Bot commented on FLINK-2754: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: [FLINK-2754] Add a new module for micro benchm...

2015-09-24 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1177#issuecomment-143097828 Yes, the XORShfit benchmark is ready to merge, and i would lead the work about other benchmark refactor. No one should depends on this module, so i think there s

[jira] [Assigned] (FLINK-2561) Sync Gelly Java and Scala APIs

2015-09-24 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-2561: Assignee: Vasia Kalavri > Sync Gelly Java and Scala APIs > -- >

[jira] [Updated] (FLINK-1521) Some Chained Drivers do not respect object-reuse/non-reuse flag

2015-09-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-1521: Assignee: (was: Chesnay Schepler) > Some Chained Drivers do not respect object-reuse/non

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

2015-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

2015-09-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1168#issuecomment-143020279 Great, thank you. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Created] (FLINK-2762) Job Runtime: -1 ms

2015-09-24 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-2762: - Summary: Job Runtime: -1 ms Key: FLINK-2762 URL: https://issues.apache.org/jira/browse/FLINK-2762 Project: Flink Issue Type: Bug Components: other Af

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906714#comment-14906714 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-142999802 Thanks for the review! Just to clarify: I did not apply any changes "just for fun". But I agree that this PR contains more changes as are actually related to this PR. For e

[jira] [Commented] (FLINK-1789) Allow adding of URLs to the usercode class loader

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906566#comment-14906566 ] ASF GitHub Bot commented on FLINK-1789: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-24 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-142975593 @aalexandrov Concerning the folders, you wrote: > The idea is to add support for proper *folders* next to jars when opening an execution environment. Since folders cannot

[jira] [Commented] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906559#comment-14906559 ] Robert Metzger commented on FLINK-2392: --- There was another failure in https://s3.am

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906554#comment-14906554 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-142974060 There are also many whitespace changes in this PR, probably due to the IDE settings, which trim lines in all files that were opened... --- If your project is set up

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906553#comment-14906553 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-142973877 I am curious here, is the `stop()` method implemented differently in any function differently than the `cancel()` method? What would speak against implementin

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-142971028 What would really help to review this is a summary of how it actually works. We currently have to piece that together from the code, which takes quite some time...

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906542#comment-14906542 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906539#comment-14906539 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-142970422 There are some crucial issues still with this pull request: Most importantly, it changes parts that it needs not change, altering system behavior. That manife

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906520#comment-14906520 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-142967362 I've just looked into the implementation of `Task.cancelTask` and there we also spawn a new thread to cancel the task. Thus, the semantics is the same for the `stopE

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906513#comment-14906513 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r40334026 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -452,6 +453,73 @@ public void cancel(JobID jobId) throws Exception

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906511#comment-14906511 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r40333992 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java --- @@ -452,6 +453,73 @@ public void cancel(JobID jobId) throws Exception

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r40333103 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -588,15 +653,16 @@ protected int cancel(String[] args) {

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906501#comment-14906501 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906500#comment-14906500 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r40333050 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -534,7 +536,70 @@ public int compare(JobStatusMessage o1, JobStatusM

[jira] [Created] (FLINK-2761) Prevent instantiation of new ExecutionEnvironments in the Scala Shell

2015-09-24 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2761: --- Summary: Prevent instantiation of new ExecutionEnvironments in the Scala Shell Key: FLINK-2761 URL: https://issues.apache.org/jira/browse/FLINK-2761 Project: Flink

[jira] [Commented] (FLINK-2354) Recover running jobs on JobManager failure

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906491#comment-14906491 ] ASF GitHub Bot commented on FLINK-2354: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-2354] Add job graph and checkpoint reco...

2015-09-24 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1153#issuecomment-142962514 Currently, ZooKeeper only stores the latest added job graph (existing ones are overwritten), whereas in the JobManager the JobGraph is attached to the existing ExecutionGrap

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906484#comment-14906484 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-142961440 @mxm Think of it that the URLs are http URLs to an http server that serves dynamically generated classes... --- If your project is set up for it, you can reply to th

[jira] [Commented] (FLINK-1789) Allow adding of URLs to the usercode class loader

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906489#comment-14906489 ] ASF GitHub Bot commented on FLINK-1789: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-1789) Allow adding of URLs to the usercode class loader

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906485#comment-14906485 ] ASF GitHub Bot commented on FLINK-1789: --- Github user aalexandrov commented on the pu

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-24 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-142960455 @mxm The jars in which folder? The main motivation point of the pull request is to add the option to add a classpaths where one can generate code at runtime. --- If

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r40331106 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -263,7 +268,7 @@ protected int run(String[] args) { c

[GitHub] flink pull request: [FLINK-2432] Custom serializer support

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/962#issuecomment-142958301 @zentol I am not sure anyone has the capacity to dig into this right now. If you feel like this is a good change, I'd say go ahead and merge it... (you are th

[jira] [Commented] (FLINK-2432) [py] Provide support for custom serialization

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906476#comment-14906476 ] ASF GitHub Bot commented on FLINK-2432: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906468#comment-14906468 ] ASF GitHub Bot commented on FLINK-2690: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2690] [api-breaking] [scala api] [java ...

2015-09-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1141#issuecomment-142956414 Yes the reason why I introduced the `CommonCSVInputFormat` instead of unifying it with the `GenericCsvInputFormat` was that we still have the Record API `CsvInputFo

[GitHub] flink pull request: [FLINK-2690] [api-breaking] [scala api] [java ...

2015-09-24 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1141#discussion_r40329651 --- Diff: flink-staging/flink-language-binding/flink-language-binding-generic/src/main/java/org/apache/flink/languagebinding/api/java/common/PlanBinder.java

[jira] [Commented] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906467#comment-14906467 ] ASF GitHub Bot commented on FLINK-2690: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-2653) Enable object reuse in MergeIterator

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906464#comment-14906464 ] ASF GitHub Bot commented on FLINK-2653: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2653] Enable object reuse in MergeItera...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1115#issuecomment-142955571 +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] flink pull request: Fix of the RabbitMQ Java example (added braces...

2015-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: Fix of the RabbitMQ Java example (added braces...

2015-09-24 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/1179#issuecomment-142954095 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[jira] [Commented] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906450#comment-14906450 ] ASF GitHub Bot commented on FLINK-2690: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2690] [api-breaking] [scala api] [java ...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1141#issuecomment-142953065 Looks good to me, feel free to merge. Minor comment: We now have a `GenericCsvInputFormat` and a `CommonCSVInputFormat`. Anything preventing us from unifying

[jira] [Commented] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906446#comment-14906446 ] ASF GitHub Bot commented on FLINK-2690: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2690] [api-breaking] [scala api] [java ...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1141#discussion_r40327817 --- Diff: flink-staging/flink-language-binding/flink-language-binding-generic/src/main/java/org/apache/flink/languagebinding/api/java/common/PlanBinder.java

[GitHub] flink pull request: [FLINK-2754] Add a new module for micro benchm...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1177#issuecomment-142950553 Looks good. This makes only sense to merge, if we move the MemorySegment micro benchmarks and the XORShift benchmarks to this module. @ChengXiangLi Would you

[jira] [Commented] (FLINK-2754) FixedLengthRecordSorter can not write to output cross MemorySegments.

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906439#comment-14906439 ] ASF GitHub Bot commented on FLINK-2754: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2754) FixedLengthRecordSorter can not write to output cross MemorySegments.

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906420#comment-14906420 ] ASF GitHub Bot commented on FLINK-2754: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [utils] Missing getters for ParameterTool

2015-09-24 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/1168#issuecomment-142948084 @rmetzger, sure, somehow I missed those tests. Now fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-2754] FixedLengthRecordSorter can not w...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1178#issuecomment-142947995 Looks good to me! +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-24 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-142944429 Do we have to have a separate list of classpaths in addition to the user classloader or can we have a user classloader which contains all the JARs that a user has provided (e

[jira] [Commented] (FLINK-1789) Allow adding of URLs to the usercode class loader

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906395#comment-14906395 ] ASF GitHub Bot commented on FLINK-1789: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-1789) Allow adding of URLs to the usercode class loader

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906404#comment-14906404 ] ASF GitHub Bot commented on FLINK-1789: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2753) Add new window API to streaming API

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906399#comment-14906399 ] ASF GitHub Bot commented on FLINK-2753: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-2753] [streaming] [api breaking] Add fi...

2015-09-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1175#issuecomment-142943745 I don't favor a particular style, I just think consistency is key here. The google style guide, for example allows single char (T, E, K) and camel case with an affixed

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-24 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-142943052 I just had a look at this pull request. Why don't we treat the JARs in the given folder like the the other jar files that are submitted to the cluster via the BlobManager as

[jira] [Commented] (FLINK-2200) Flink API with Scala 2.11 - Maven Repository

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906392#comment-14906392 ] ASF GitHub Bot commented on FLINK-2200: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-2200) Flink API with Scala 2.11 - Maven Repository

2015-09-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-2200. --- Resolution: Fixed Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/4cadc3d6 >

[GitHub] flink pull request: [FLINK-2200] Add Flink with Scala 2.11 in Mave...

2015-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/885 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-2753) Add new window API to streaming API

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906389#comment-14906389 ] ASF GitHub Bot commented on FLINK-2753: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2753] [streaming] [api breaking] Add fi...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1175#issuecomment-142941895 Not super attached. I like the new style, but I see the point that it is too much style diversity. So let's change it to the style `OUT`, `KEY`, ... ? --- If your p

[jira] [Commented] (FLINK-2753) Add new window API to streaming API

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906385#comment-14906385 ] ASF GitHub Bot commented on FLINK-2753: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-2753] [streaming] [api breaking] Add fi...

2015-09-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1175#issuecomment-142940983 @StephanEwen How attached are you to your Generic Type names? Because in the current code base we have single character uppercase style (T, E, V, C and so on, as is th

[GitHub] flink pull request: Fix of the RabbitMQ Java example (added braces...

2015-09-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1179#issuecomment-142939509 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Created] (FLINK-2760) Avoid uploading of already existing jars from the JobClient

2015-09-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-2760: Summary: Avoid uploading of already existing jars from the JobClient Key: FLINK-2760 URL: https://issues.apache.org/jira/browse/FLINK-2760 Project: Flink Is

[GitHub] flink pull request: [FLINK-2354] Add job graph and checkpoint reco...

2015-09-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1153#issuecomment-142935347 The implication of sessions would only be that Jobs are kept in the "currentJobs" map, even once they are finished. That should transparently work with HA - the jobs

[jira] [Commented] (FLINK-2354) Recover running jobs on JobManager failure

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906371#comment-14906371 ] ASF GitHub Bot commented on FLINK-2354: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: Fix of the RabbitMQ Java example (added braces...

2015-09-24 Thread tipok
GitHub user tipok opened a pull request: https://github.com/apache/flink/pull/1179 Fix of the RabbitMQ Java example (added braces) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tipok/flink master Alternatively you can review a

[jira] [Commented] (FLINK-1789) Allow adding of URLs to the usercode class loader

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906335#comment-14906335 ] ASF GitHub Bot commented on FLINK-1789: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-24 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/593#discussion_r40317151 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -47,6 +47,11 @@ "Class with the p

[jira] [Closed] (FLINK-2755) Cluster Execution - /home/user/udfs.jar

2015-09-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-2755. Resolution: Incomplete Your question should rather go to the u...@flink.apache.org mailing list. Plu

[jira] [Commented] (FLINK-2354) Recover running jobs on JobManager failure

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906316#comment-14906316 ] ASF GitHub Bot commented on FLINK-2354: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2354] Add job graph and checkpoint reco...

2015-09-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1153#issuecomment-142921093 Good to hear. I'll try to review it then. Won't probably before Monday, because tomorrow I'm on vacation. On Wed, Sep 23, 2015 at 8:03 PM, Ufuk Celebi

[jira] [Resolved] (FLINK-2616) Failing Test: ZooKeeperLeaderElectionTest

2015-09-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-2616. -- Resolution: Fixed Fixed via 0d19e94a18a334b6b5843c3ea81e20af096d7f35 > Failing Test: ZooKeeperL

[GitHub] flink pull request: [FLINK-2616] [test-stability] Fixes ZooKeeperL...

2015-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2616) Failing Test: ZooKeeperLeaderElectionTest

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906307#comment-14906307 ] ASF GitHub Bot commented on FLINK-2616: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2616] [test-stability] Fixes ZooKeeperL...

2015-09-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1173#issuecomment-142919125 Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (FLINK-2616) Failing Test: ZooKeeperLeaderElectionTest

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906306#comment-14906306 ] ASF GitHub Bot commented on FLINK-2616: --- Github user tillrohrmann commented on the p

[jira] [Resolved] (FLINK-2751) Quickstart is in documentation but only linked through the Flink homepage

2015-09-24 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park resolved FLINK-2751. Resolution: Fixed Thanks for contribution! Fixed at 1cac3a4bacde2663ef8f92d0c47d68749f1d7a66 and 0

[jira] [Commented] (FLINK-2751) Quickstart is in documentation but only linked through the Flink homepage

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906271#comment-14906271 ] ASF GitHub Bot commented on FLINK-2751: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...

2015-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2751) Quickstart is in documentation but only linked through the Flink homepage

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906264#comment-14906264 ] ASF GitHub Bot commented on FLINK-2751: --- Github user chiwanpark commented on the pul

[GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...

2015-09-24 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1176#issuecomment-142910324 Looks good to merge. I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-2751) Quickstart is in documentation but only linked through the Flink homepage

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906212#comment-14906212 ] ASF GitHub Bot commented on FLINK-2751: --- Github user rerngvit commented on the pull

[GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...

2015-09-24 Thread rerngvit
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1176#issuecomment-142900768 @chiwanpark Thanks for reviewing this issue. I modified the pull request according to your comments. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-2751) Quickstart is in documentation but only linked through the Flink homepage

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906196#comment-14906196 ] ASF GitHub Bot commented on FLINK-2751: --- Github user chiwanpark commented on the pul

[GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...

2015-09-24 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1176#issuecomment-142895387 Hi @rerngvit, I have tested your pull request. Because `setup_quickstart.html` contains "setup" keyword in url, there are two active menus (Quickstart, Setup)

[jira] [Commented] (FLINK-2479) Refactoring of org.apache.flink.runtime.operators.testutils.TestData class

2015-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906183#comment-14906183 ] ASF GitHub Bot commented on FLINK-2479: --- Github user zentol commented on the pull re

[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...

2015-09-24 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1160#issuecomment-142888437 I will shortly add another commit that removes the remaining Record portions in the TestData class and refactors its usages. Originally i planned a separate PR for those,

[jira] [Created] (FLINK-2759) TaskManagerProcessReapingTest fails on Windows

2015-09-24 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-2759: Summary: TaskManagerProcessReapingTest fails on Windows Key: FLINK-2759 URL: https://issues.apache.org/jira/browse/FLINK-2759 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-2758) TaskManagerRegistrationTest fails on Windows

2015-09-24 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-2758: Summary: TaskManagerRegistrationTest fails on Windows Key: FLINK-2758 URL: https://issues.apache.org/jira/browse/FLINK-2758 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/593#discussion_r40303043 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -47,6 +47,11 @@ "Class with the progra

  1   2   >