[GitHub] flink pull request: Parameter Server: Distributed Key-Value store,...

2015-09-21 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1003#issuecomment-142190932 Yes. I agree. I'm currently working on finalizing the interface. Just waiting for another PR to get in. And involving the Job Manager is not strictly nece

[jira] [Commented] (FLINK-2720) Add Storm-CountMetric in flink-stormcompatibility

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901893#comment-14901893 ] ASF GitHub Bot commented on FLINK-2720: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2720][storm-compatibility]Add Storm-Cou...

2015-09-21 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1157#issuecomment-142176942 @mjsax Yes, I got the same example as you :D And I try to add an example to show how to use this FlinkCountMetric by following the example. --- If your proj

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901885#comment-14901885 ] ASF GitHub Bot commented on FLINK-2536: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-21 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1030#issuecomment-142173138 @StephanEwen Hi, I'm very sorry for the poor Java style of mine. And many thanks for your rework.I did a full review about your new fixes and get the points.

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2015-09-21 Thread Daniel Blazevski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901837#comment-14901837 ] Daniel Blazevski commented on FLINK-1745: - Hi [~chiwanpark] and [~till.rohrmann],

[GitHub] flink pull request: [FLINK-2722] Use InetAddress.getLocalHost() as...

2015-09-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/flink/pull/1159#discussion_r40049021 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/NetUtils.java --- @@ -189,9 +191,17 @@ public static InetAddress findConnectingAddress

[jira] [Commented] (FLINK-2722) Use InetAddress.getLocalHost() first when detecting TaskManager IP address

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901816#comment-14901816 ] ASF GitHub Bot commented on FLINK-2722: --- Github user felixcheung commented on a diff

[GitHub] flink pull request: [FLINK-2722] Use InetAddress.getLocalHost() as...

2015-09-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/flink/pull/1159#discussion_r40048959 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/NetUtils.java --- @@ -189,9 +191,17 @@ public static InetAddress findConnectingAddress

[jira] [Commented] (FLINK-2722) Use InetAddress.getLocalHost() first when detecting TaskManager IP address

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901812#comment-14901812 ] ASF GitHub Bot commented on FLINK-2722: --- Github user felixcheung commented on a diff

[jira] [Closed] (FLINK-2717) CombineTaskTest sometimes fails

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2717. --- > CombineTaskTest sometimes fails > --- > > Key: FLINK-2717 >

[jira] [Resolved] (FLINK-2710) SocketTextStreamFunctionTest failure

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2710. - Resolution: Fixed Fix Version/s: 0.10 Reworked and fixed via bd74baef5d0d23ce29ff71bb67f12b

[jira] [Closed] (FLINK-2649) Potential resource leak in JarHelper#unjar()

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2649. --- > Potential resource leak in JarHelper#unjar() > > >

[jira] [Closed] (FLINK-2710) SocketTextStreamFunctionTest failure

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2710. --- > SocketTextStreamFunctionTest failure > > > Key: FLI

[jira] [Closed] (FLINK-2648) CombineTaskTest.testCancelCombineTaskSorting

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2648. --- > CombineTaskTest.testCancelCombineTaskSorting > > >

[jira] [Closed] (FLINK-2724) Object reuse not respected in GroupReduceCombineDriver and ReduceCombineDriver

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2724. --- > Object reuse not respected in GroupReduceCombineDriver and ReduceCombineDriver > ---

[jira] [Resolved] (FLINK-2724) Object reuse not respected in GroupReduceCombineDriver and ReduceCombineDriver

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2724. - Resolution: Fixed Fixed via f3809d8272e9b1f611770cdfb71fe17c3feb08e6 > Object reuse not respected

[jira] [Resolved] (FLINK-2717) CombineTaskTest sometimes fails

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2717. - Resolution: Fixed Assignee: Stephan Ewen Fix Version/s: 0.10 Fixed via 435ee4ebb5e

[jira] [Resolved] (FLINK-2649) Potential resource leak in JarHelper#unjar()

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2649. - Resolution: Fixed Fix Version/s: 0.10 Fixed via 5e6175d6eadf62d7493e0b2d3c925c802f95ae69 >

[jira] [Commented] (FLINK-2648) CombineTaskTest.testCancelCombineTaskSorting

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901453#comment-14901453 ] Stephan Ewen commented on FLINK-2648: - Did a more thorough rework of the memory releas

[jira] [Resolved] (FLINK-2648) CombineTaskTest.testCancelCombineTaskSorting

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2648. - Resolution: Fixed Fixed via 435ee4ebb5ec2ac0086e1a5136125ecc1d7c89a8 > CombineTaskTest.testCancel

[jira] [Commented] (FLINK-2649) Potential resource leak in JarHelper#unjar()

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901452#comment-14901452 ] ASF GitHub Bot commented on FLINK-2649: --- Github user asfgit closed the pull request

[GitHub] flink pull request: FLINK-2649 Potential resource leak in JarHelpe...

2015-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2683) Add utilities for heap-backed keyed state in time panes

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901398#comment-14901398 ] ASF GitHub Bot commented on FLINK-2683: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2683] [runtime] Add dedicated operator ...

2015-09-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1147#issuecomment-142107041 Actually, I think the tests are okay. The triggers are part of some tests only, because this is a unit test that checks many features independently. - Ther

[GitHub] flink pull request: [FLINK-2683] [runtime] Add dedicated operator ...

2015-09-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1147#issuecomment-142098571 Thanks for the pointer with the tests, will have a look and fix this... --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-2683) Add utilities for heap-backed keyed state in time panes

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901324#comment-14901324 ] ASF GitHub Bot commented on FLINK-2683: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2683) Add utilities for heap-backed keyed state in time panes

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901323#comment-14901323 ] ASF GitHub Bot commented on FLINK-2683: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2683] [runtime] Add dedicated operator ...

2015-09-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1147#issuecomment-142098492 Concerning Watermarks: I think that is the assumption right now, yes. Since the operators produce records with timestamps based on their processing time, the

[jira] [Created] (FLINK-2725) Max/Min/Sum Aggregation of mutable types

2015-09-21 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-2725: - Summary: Max/Min/Sum Aggregation of mutable types Key: FLINK-2725 URL: https://issues.apache.org/jira/browse/FLINK-2725 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-2724) Object reuse not respected in GroupReduceCombineDriver and ReduceCombineDriver

2015-09-21 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2724: --- Summary: Object reuse not respected in GroupReduceCombineDriver and ReduceCombineDriver Key: FLINK-2724 URL: https://issues.apache.org/jira/browse/FLINK-2724 Project: F

[jira] [Commented] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-21 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901238#comment-14901238 ] Maximilian Michels commented on FLINK-2392: --- Thanks. That'll prove to be very us

[jira] [Resolved] (FLINK-2713) Custom StateCheckpointers should be included in the snapshots

2015-09-21 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora resolved FLINK-2713. --- Resolution: Fixed > Custom StateCheckpointers should be included in the snapshots > --

[jira] [Commented] (FLINK-2713) Custom StateCheckpointers should be included in the snapshots

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901098#comment-14901098 ] ASF GitHub Bot commented on FLINK-2713: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2713] [streaming] Set state restore to ...

2015-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2479) Refactoring of org.apache.flink.runtime.operators.testutils.TestData class

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901087#comment-14901087 ] ASF GitHub Bot commented on FLINK-2479: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...

2015-09-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1160#issuecomment-142061495 That is very nice, thanks for the initiative, @zentol Hope to be able to have a look over it, soon. Looks in principle correct, but cannot hurt to have anot

[GitHub] flink pull request: Pull Request

2015-09-21 Thread JonathanH5
Github user JonathanH5 commented on the pull request: https://github.com/apache/flink/pull/1156#issuecomment-142059639 Hi, I see 5 different types of comments that need to be considered for the new pull request: * rename pull request: [FLINK-1719] [ml] Add Multinomial Naive Bayes

[jira] [Commented] (FLINK-1719) Add naive Bayes classification algorithm to machine learning library

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901073#comment-14901073 ] ASF GitHub Bot commented on FLINK-1719: --- Github user JonathanH5 commented on the pul

[GitHub] flink pull request: [FLINK-2479] Refactor runtime.operators.* test...

2015-09-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/1160 [FLINK-2479] Refactor runtime.operators.* tests This PR refactors most runtime.operators tests to use the TupleGenerator introduced in FLINK-2105. The changes made can generally be summed up

[jira] [Commented] (FLINK-2479) Refactoring of org.apache.flink.runtime.operators.testutils.TestData class

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901068#comment-14901068 ] ASF GitHub Bot commented on FLINK-2479: --- GitHub user zentol opened a pull request:

[jira] [Reopened] (FLINK-2648) CombineTaskTest.testCancelCombineTaskSorting

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reopened FLINK-2648: --- The test failed again: {code} CombineTaskTest.testCancelCombineTaskSorting:195 null {code} in http

[jira] [Created] (FLINK-2723) CopyableValue method to copy into new instance

2015-09-21 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-2723: - Summary: CopyableValue method to copy into new instance Key: FLINK-2723 URL: https://issues.apache.org/jira/browse/FLINK-2723 Project: Flink Issue Type: New Featur

[jira] [Commented] (FLINK-2710) SocketTextStreamFunctionTest failure

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901046#comment-14901046 ] Stephan Ewen commented on FLINK-2710: - Will do a rework of the tests and the source fu

[jira] [Commented] (FLINK-2722) Use InetAddress.getLocalHost() first when detecting TaskManager IP address

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900925#comment-14900925 ] Robert Metzger commented on FLINK-2722: --- Pushed fix for 0.9.2 in http://git-wip-us.

[jira] [Updated] (FLINK-2722) Use InetAddress.getLocalHost() first when detecting TaskManager IP address

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-2722: -- Fix Version/s: 0.9.2 > Use InetAddress.getLocalHost() first when detecting TaskManager IP addres

[jira] [Commented] (FLINK-2722) Use InetAddress.getLocalHost() first when detecting TaskManager IP address

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900919#comment-14900919 ] ASF GitHub Bot commented on FLINK-2722: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request: [FLINK-2722] Use InetAddress.getLocalHost() as...

2015-09-21 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1159 [FLINK-2722] Use InetAddress.getLocalHost() as first approach when detecting the TMs own ip/hostname A user reported a connection issue with Netty being unable to connect to a TaskManager to subsc

[jira] [Commented] (FLINK-2685) TaskManager deadlock on NetworkBufferPool

2015-09-21 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900917#comment-14900917 ] Ufuk Celebi commented on FLINK-2685: I've looked into the generated optimizer plan for

[jira] [Created] (FLINK-2722) Use InetAddress.getLocalHost() first when detecting TaskManager IP address

2015-09-21 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-2722: - Summary: Use InetAddress.getLocalHost() first when detecting TaskManager IP address Key: FLINK-2722 URL: https://issues.apache.org/jira/browse/FLINK-2722 Project: F

[jira] [Commented] (FLINK-2710) SocketTextStreamFunctionTest failure

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900859#comment-14900859 ] Stephan Ewen commented on FLINK-2710: - May happen if the socket already fails in {{ope

[jira] [Closed] (FLINK-2536) Add a retry for SocketClientSink

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2536. --- > Add a retry for SocketClientSink > > > Key: FLINK-2536

[jira] [Assigned] (FLINK-2710) SocketTextStreamFunctionTest failure

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reassigned FLINK-2710: --- Assignee: Stephan Ewen > SocketTextStreamFunctionTest failure > -

[jira] [Resolved] (FLINK-2536) Add a retry for SocketClientSink

2015-09-21 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2536. - Resolution: Fixed Implemented in fd354ba4dbd2a76688992b0a092ccc78b61f1088 and b9663c40754f522648f

[jira] [Commented] (FLINK-2649) Potential resource leak in JarHelper#unjar()

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900821#comment-14900821 ] ASF GitHub Bot commented on FLINK-2649: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: FLINK-2649 Potential resource leak in JarHelpe...

2015-09-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1151#issuecomment-142014868 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink pull request: Pull Request

2015-09-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1156#issuecomment-142014791 How about closing this pull request, doing some cleanup, a good name, and reopening a new one? --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900816#comment-14900816 ] ASF GitHub Bot commented on FLINK-2536: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1030#issuecomment-142014348 I reworked this quite heavily during merging. There were a lot of issues that were against good Java style: - Variables in the classes, rather than in methods

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900814#comment-14900814 ] ASF GitHub Bot commented on FLINK-2536: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1030 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: Merge remote-tracking branch 'apache/master'

2015-09-21 Thread aminouvic
Github user aminouvic closed the pull request at: https://github.com/apache/flink/pull/1158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] flink pull request: Merge remote-tracking branch 'apache/master'

2015-09-21 Thread aminouvic
GitHub user aminouvic opened a pull request: https://github.com/apache/flink/pull/1158 Merge remote-tracking branch 'apache/master' You can merge this pull request into a Git repository by running: $ git pull https://github.com/aminouvic/flink master Alternatively you can rev

[jira] [Commented] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900750#comment-14900750 ] Robert Metzger commented on FLINK-2392: --- I've set the logging up for apache/flink. J

[jira] [Created] (FLINK-2721) Add Tuple meta information

2015-09-21 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created FLINK-2721: -- Summary: Add Tuple meta information Key: FLINK-2721 URL: https://issues.apache.org/jira/browse/FLINK-2721 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-2720) Add Storm-CountMetric in flink-stormcompatibility

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900723#comment-14900723 ] ASF GitHub Bot commented on FLINK-2720: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2720][storm-compatibility]Add Storm-Cou...

2015-09-21 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1157#discussion_r39972364 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyContext.java --

[jira] [Commented] (FLINK-2683) Add utilities for heap-backed keyed state in time panes

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900719#comment-14900719 ] ASF GitHub Bot commented on FLINK-2683: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-2683] [runtime] Add dedicated operator ...

2015-09-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1147#issuecomment-141986160 If the operators don't react to watermarks and don't forward watermarks that means that any downstream operators cannot rely on watermarks. --- If your project is set

[jira] [Commented] (FLINK-2720) Add Storm-CountMetric in flink-stormcompatibility

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900718#comment-14900718 ] ASF GitHub Bot commented on FLINK-2720: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2720][storm-compatibility]Add Storm-Cou...

2015-09-21 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1157#issuecomment-141985771 This looks promising. However, how can `CountMetric` be used (without any changes to the Spout/Bolt code within Flink? Right now it seems, that the user has to replace `Co

[jira] [Commented] (FLINK-1789) Allow adding of URLs to the usercode class loader

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900707#comment-14900707 ] ASF GitHub Bot commented on FLINK-1789: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...

2015-09-21 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/593#issuecomment-141983001 I agree. Lets wait until https://github.com/apache/flink/pull/858 is merged. As far as I understood Stephan, this PR depends on #858. --- If your project is set up for

[GitHub] flink pull request: [FLINK-2720][storm-compatibility]Add Storm-Cou...

2015-09-21 Thread HuangWHWHW
GitHub user HuangWHWHW opened a pull request: https://github.com/apache/flink/pull/1157 [FLINK-2720][storm-compatibility]Add Storm-CountMetric for storm metrics I added the Storm-CountMetric for the first step about storm metrics. 1.Do a wrapper `FlinkCountMetric` for the CountMe

[jira] [Commented] (FLINK-2720) Add Storm-CountMetric in flink-stormcompatibility

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900686#comment-14900686 ] ASF GitHub Bot commented on FLINK-2720: --- GitHub user HuangWHWHW opened a pull reques

[jira] [Commented] (FLINK-2618) ExternalSortITCase failure

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900682#comment-14900682 ] Robert Metzger commented on FLINK-2618: --- I observed another failure: https://s3.ama

[jira] [Commented] (FLINK-2683) Add utilities for heap-backed keyed state in time panes

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900679#comment-14900679 ] ASF GitHub Bot commented on FLINK-2683: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-2683] [runtime] Add dedicated operator ...

2015-09-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1147#issuecomment-141973240 I don't think the unit tests are correct. I was playing around with the tests while adding the integration of the timer service into the StreamTask. I noticed that most

[jira] [Created] (FLINK-2720) Add Storm-CountMetric in flink-stormcompatibility

2015-09-21 Thread Huang Wei (JIRA)
Huang Wei created FLINK-2720: Summary: Add Storm-CountMetric in flink-stormcompatibility Key: FLINK-2720 URL: https://issues.apache.org/jira/browse/FLINK-2720 Project: Flink Issue Type: New Featu

[jira] [Commented] (FLINK-2612) ZooKeeperLeaderElectionITCase failure

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900674#comment-14900674 ] Robert Metzger commented on FLINK-2612: --- Another case: https://s3.amazonaws.com/arc

[GitHub] flink pull request: Pull Request

2015-09-21 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1156#issuecomment-141967992 The commit history needs a cleanup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900606#comment-14900606 ] Robert Metzger commented on FLINK-2392: --- This is another occurrence of the {{testJav

[jira] [Commented] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900589#comment-14900589 ] Till Rohrmann commented on FLINK-2392: -- Haven't seen this one before: {code} Failed

[jira] [Commented] (FLINK-2283) Make grouped reduce/fold/aggregations stateful using Partitioned state

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900585#comment-14900585 ] ASF GitHub Bot commented on FLINK-2283: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2283] [streaming] Make grouped reduce/f...

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1155#discussion_r39965297 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/UdfStreamOperatorCheckpointingITCase.java --- @@ -0,0 +1,267 @@ +/* + *

[jira] [Commented] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900582#comment-14900582 ] Robert Metzger commented on FLINK-2392: --- The problem here is that the CliFrontend is

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964749 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/MultinomialNaiveBayes.scala --- @@ -0,0 +1,900 @@ +/* + * Lic

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964672 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/MultinomialNaiveBayes.scala --- @@ -0,0 +1,900 @@ +/* + * Lic

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964588 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964618 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964582 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964615 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964603 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964537 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964553 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[jira] [Commented] (FLINK-2283) Make grouped reduce/fold/aggregations stateful using Partitioned state

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900574#comment-14900574 ] ASF GitHub Bot commented on FLINK-2283: --- Github user gyfora commented on the pull re

[GitHub] flink pull request: Pull Request

2015-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1156#discussion_r39964510 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/classification/MultinomialNaiveBayesValidation.scala --- @@ -0,0 +1,422 @@ +/*

[GitHub] flink pull request: [FLINK-2283] [streaming] Make grouped reduce/f...

2015-09-21 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1155#issuecomment-141957390 @aljoscha A custom StateCheckpointer should be used in this case, there were some issues that I fixed in https://github.com/apache/flink/pull/1154 regarding this. -

[jira] [Commented] (FLINK-1719) Add naive Bayes classification algorithm to machine learning library

2015-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900571#comment-14900571 ] ASF GitHub Bot commented on FLINK-1719: --- Github user uce commented on the pull reque

[GitHub] flink pull request: Pull Request

2015-09-21 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1156#issuecomment-141955459 Hey Jonathan, could you change the title of this pull request to match the JIRA issue it relates to? A better title could be: [FLINK-1719] [ml] Add naive Bayes classificatio

  1   2   3   >