[GitHub] flink pull request: [FLINK-2691] fix broken links to Python script...

2015-09-16 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1140#issuecomment-140979385 Nice catch! Looks good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-2691) Broken links to Python script on QuickStart doc

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791638#comment-14791638 ] ASF GitHub Bot commented on FLINK-2691: --- Github user chiwanpark commented on the pul

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791372#comment-14791372 ] ASF GitHub Bot commented on FLINK-2622: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-16 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-140934136 Yes, I will take a fix for the comments:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...

2015-09-16 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1131#issuecomment-140933982 Many thanks! This solved a big problem of mine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-2691) Broken links to Python script on QuickStart doc

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791339#comment-14791339 ] ASF GitHub Bot commented on FLINK-2691: --- GitHub user felixcheung opened a pull reque

[GitHub] flink pull request: [FLINK-2691] fix broken links to Python script...

2015-09-16 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/flink/pull/1140 [FLINK-2691] fix broken links to Python script on QuickStart doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/felixcheung/flink quickstar

[jira] [Updated] (FLINK-2691) Broken links to Python script on QuickStart doc

2015-09-16 Thread Felix Cheung (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Cheung updated FLINK-2691: Affects Version/s: 0.9 Component/s: Documentation > Broken links to Python script on Quick

[jira] [Created] (FLINK-2691) Broken links to Python script on QuickStart doc

2015-09-16 Thread Felix Cheung (JIRA)
Felix Cheung created FLINK-2691: --- Summary: Broken links to Python script on QuickStart doc Key: FLINK-2691 URL: https://issues.apache.org/jira/browse/FLINK-2691 Project: Flink Issue Type: Bug

[GitHub] flink pull request: Hits

2015-09-16 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-140903149 Thanks for the explanation @mfahimazizi. So, if you put the edge label inside the message that you send in the messaging function, then you will know which values to add

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791168#comment-14791168 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140901671 Thanks. I agree with you. Just wanted to get a second opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791165#comment-14791165 ] ASF GitHub Bot commented on FLINK-2566: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140901138 #1046 seems to be almost done. Porting to the ExecutionConfig, shouldn't be too hard. I'd rather try to drive #1046 forward and merge it first, but it's up to you. ---

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140899681 I use the config that is introduced in #1046 already... See TODO in StormWrapperSetupHelper.java and StormWrapperSetupHelperTest.java ... Not sure if it is cleaver to merg

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791144#comment-14791144 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791134#comment-14791134 ] ASF GitHub Bot commented on FLINK-2566: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140898273 Tricky bug :-) If it does not depend on #1046, why not merge it? Or would you like to have somebody else looking over the code? --- If your project is set up for

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140895609 Fixed. Please let me know if I can merge this. Or should I wait for #1046 ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791124#comment-14791124 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2357) New JobManager Runtime Web Frontend

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791112#comment-14791112 ] ASF GitHub Bot commented on FLINK-2357: --- GitHub user StephanEwen opened a pull reque

[GitHub] flink pull request: [FLINK-2357] Add the new web dashboard and mon...

2015-09-16 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1139 [FLINK-2357] Add the new web dashboard and monitoring REST API This pull request adds two new big features: The monitoring REST API and the web dashboard. It is joint work by @iampeter

[jira] [Commented] (FLINK-2622) Scala DataStream API does not have writeAsText method which supports WriteMode

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791072#comment-14791072 ] ASF GitHub Bot commented on FLINK-2622: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2622][streaming]add WriteMode for write...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1098#issuecomment-140877442 Hi @HuangWHWHW, your PR #1131 has been merged. Can you update this PR and remove those changes? Thanks! --- If your project is set up for it, you can reply to th

[GitHub] flink pull request: Hits

2015-09-16 Thread mfahimazizi
Github user mfahimazizi commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-140871748 Hey @vasia, Thank you. sorry it is "calculate node values". first we label the edge as 'H' (hub score), then undirected the graph and label the new edges as '

[jira] [Commented] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791026#comment-14791026 ] ASF GitHub Bot commented on FLINK-2595: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2640][yarn] integrate off-heap configur...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1132#issuecomment-140869851 Thanks for the update. I will merge this PR tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-2640) Integrate the off-heap configurations with YARN runner

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791035#comment-14791035 ] ASF GitHub Bot commented on FLINK-2640: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1137#issuecomment-140868278 Hi @tedyu, Thanks for the pull request! It's good to merge after the the indention is fixed. --- If your project is set up for it, you can reply to this email an

[jira] [Commented] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791021#comment-14791021 ] ASF GitHub Bot commented on FLINK-2595: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1137#discussion_r39676482 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java --- @@ -46,13 +46,16 @@ public void testWithURLClassLoader() {

[jira] [Commented] (FLINK-2576) Add outer joins to API and Optimizer

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791008#comment-14791008 ] ASF GitHub Bot commented on FLINK-2576: --- GitHub user jkovacs opened a pull request:

[GitHub] flink pull request: Feature/flink 2576

2015-09-16 Thread jkovacs
GitHub user jkovacs opened a pull request: https://github.com/apache/flink/pull/1138 Feature/flink 2576 This PR implements [FLINK-2576](https://issues.apache.org/jira/browse/FLINK-2576) (Adding the outer join operator to the optimizer and Java/Scala APIs, previously part of [FLINK

[jira] [Commented] (FLINK-2684) Make TypeInformation non-serializable again by removing Table API's need for it

2015-09-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790874#comment-14790874 ] Chesnay Schepler commented on FLINK-2684: - FLINK-2690 presents a possible use-case

[jira] [Commented] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-16 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790869#comment-14790869 ] Chesnay Schepler commented on FLINK-2690: - It appears that FLINK-2684 collides wit

[GitHub] flink pull request: [FLINK-2557] TypeExtractor properly returns Mi...

2015-09-16 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1045#issuecomment-140810066 I've removed the refactoring commit and did a rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[jira] [Commented] (FLINK-2557) Manual type information via "returns" fails in DataSet API

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790756#comment-14790756 ] ASF GitHub Bot commented on FLINK-2557: --- Github user zentol commented on the pull re

[jira] [Updated] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-16 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park updated FLINK-2690: --- Description: A user reports {{CsvInputFormat}} cannot find the field of derived POJO class. (http://m

[jira] [Updated] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-16 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park updated FLINK-2690: --- Description: A user report {{CsvInputFormat}} cannot find the field of derived POJO class. (http://ma

[jira] [Created] (FLINK-2690) CsvInputFormat cannot find the field of derived POJO class

2015-09-16 Thread Chiwan Park (JIRA)
Chiwan Park created FLINK-2690: -- Summary: CsvInputFormat cannot find the field of derived POJO class Key: FLINK-2690 URL: https://issues.apache.org/jira/browse/FLINK-2690 Project: Flink Issue Ty

[jira] [Commented] (FLINK-2613) Print usage information for Scala Shell

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790707#comment-14790707 ] ASF GitHub Bot commented on FLINK-2613: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14789551#comment-14789551 ] ASF GitHub Bot commented on FLINK-2583: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-2613] Print usage information for Scala...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1106#discussion_r39654250 --- Diff: flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala --- @@ -212,6 +214,52 @@ class ScalaShellITSuite

[jira] [Commented] (FLINK-2613) Print usage information for Scala Shell

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790708#comment-14790708 ] ASF GitHub Bot commented on FLINK-2613: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2613] Print usage information for Scala...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1106#discussion_r39654142 --- Diff: flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala --- @@ -212,6 +214,52 @@ class ScalaShellITSuite

[jira] [Commented] (FLINK-2613) Print usage information for Scala Shell

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790694#comment-14790694 ] ASF GitHub Bot commented on FLINK-2613: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-2613] Print usage information for Scala...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1106#discussion_r39653423 --- Diff: flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupIT.scala --- @@ -0,0 +1,60 @@ +/* + * Licen

[jira] [Commented] (FLINK-2670) Unstable CombineTaskTest

2015-09-16 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790690#comment-14790690 ] Matthias J. Sax commented on FLINK-2670: It's up to you. If you think it was a one

[GitHub] flink pull request: [FLINK-2613] Print usage information for Scala...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1106#discussion_r39652554 --- Diff: flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupIT.scala --- @@ -0,0 +1,60 @@ +/* + * Licen

[jira] [Commented] (FLINK-2613) Print usage information for Scala Shell

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790679#comment-14790679 ] ASF GitHub Bot commented on FLINK-2613: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790675#comment-14790675 ] ASF GitHub Bot commented on FLINK-2595: --- GitHub user tedyu opened a pull request:

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790672#comment-14790672 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1135#issuecomment-140795134 I know. See dev mailing list "Java 8 JDK issue". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/flink/pull/1137 FLINK-2595 Unclosed JarFile may leak resource in ClassLoaderUtilsTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/flink master Alternat

[jira] [Updated] (FLINK-2595) Unclosed JarFile may leak resource in ClassLoaderUtilsTest

2015-09-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-2595: -- Description: Here is related code: {code} try { new JarF

[GitHub] flink pull request: [FLINK-2566] FlinkTopologyContext not populate...

2015-09-16 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1135#discussion_r39652292 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java --- @

[jira] [Commented] (FLINK-2566) FlinkTopologyContext not populated completely

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790669#comment-14790669 ] ASF GitHub Bot commented on FLINK-2566: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1134#discussion_r39650722 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/IntegerTypeInfo.java --- @@ -18,15 +18,33 @@ package org.apache.flink.a

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790639#comment-14790639 ] ASF GitHub Bot commented on FLINK-2637: --- Github user chiwanpark commented on a diff

[jira] [Commented] (FLINK-2689) Reusing null object for joins with SolutionSet

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790633#comment-14790633 ] ASF GitHub Bot commented on FLINK-2689: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...

2015-09-16 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/1136 [FLINK-2689] [runtime] Fix reuse of null object for solution set Joins and CoGroups Reuse object can become null if not match is found in the hash table. The next look-up will happen with a null-va

[jira] [Commented] (FLINK-2659) Object reuse in UnionWithTempOperator

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790606#comment-14790606 ] ASF GitHub Bot commented on FLINK-2659: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-2640) Integrate the off-heap configurations with YARN runner

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790590#comment-14790590 ] ASF GitHub Bot commented on FLINK-2640: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2640][yarn] integrate off-heap configur...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1132#issuecomment-140784493 LGTM, except for one minor issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] flink pull request: [FLINK-2659] Fix object reuse in UnionWithTemp...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1130#issuecomment-140788192 Thanks for the patch, looks good. Will merge this tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-2659) Object reuse in UnionWithTempOperator

2015-09-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790540#comment-14790540 ] Fabian Hueske commented on FLINK-2659: -- Hi [~greghogan], thanks for the PR. I gave y

[jira] [Updated] (FLINK-2659) Object reuse in UnionWithTempOperator

2015-09-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-2659: - Assignee: Greg Hogan > Object reuse in UnionWithTempOperator > ---

[GitHub] flink pull request: [FLINK-2410] [java api] PojoTypeInfo is not co...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/943#issuecomment-140773221 So this PR can be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Commented] (FLINK-2410) PojoTypeInfo is not completely serializable

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790536#comment-14790536 ] ASF GitHub Bot commented on FLINK-2410: --- Github user fhueske commented on the pull r

[jira] [Closed] (FLINK-1851) Java Table API does not support Casting

2015-09-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-1851. Resolution: Implemented Implemented with 7bea90150309156536558d94cb5c244369af81b9 > Java Table API

[jira] [Resolved] (FLINK-2641) Integrate the off-heap memory configuration with the TaskManager start script

2015-09-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske resolved FLINK-2641. -- Resolution: Implemented Implemented with 76a40d59e6623cfbc6e265d26da4e739e5e7ed18 > Integrate t

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1134#issuecomment-140771931 Thanks for the fast update, LGTM. Will merge this tomorrow unless somebody speaks up. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790526#comment-14790526 ] ASF GitHub Bot commented on FLINK-2637: --- Github user fhueske commented on the pull r

[jira] [Created] (FLINK-2689) Reusing null object for joins with SolutionSet

2015-09-16 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-2689: Summary: Reusing null object for joins with SolutionSet Key: FLINK-2689 URL: https://issues.apache.org/jira/browse/FLINK-2689 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1084#discussion_r39640862 --- Diff: .travis.yml --- @@ -19,9 +19,9 @@ matrix: - jdk: "oraclejdk7" # this will also deploy a uberjar to s3 at some point env: PROFIL

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14781425#comment-14781425 ] ASF GitHub Bot commented on FLINK-2583: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-16 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1084#discussion_r39640472 --- Diff: .travis.yml --- @@ -19,9 +19,9 @@ matrix: - jdk: "oraclejdk7" # this will also deploy a uberjar to s3 at some point env: PROFIL

[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-1851) Java Table API does not support Casting

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14778037#comment-14778037 ] ASF GitHub Bot commented on FLINK-1851: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-2641) Integrate the off-heap memory configuration with the TaskManager start script

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14778065#comment-14778065 ] ASF GitHub Bot commented on FLINK-2641: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2641] integrate off-heap memory configu...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-1851] Add support for casting in Table ...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1134#discussion_r39634683 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/ValueTypeInfoTest.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to t

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1134#discussion_r39634744 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala --- @@ -20,6 +20,8 @@ package org.apache.flink.api.scal

[jira] [Commented] (FLINK-2410) PojoTypeInfo is not completely serializable

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769013#comment-14769013 ] ASF GitHub Bot commented on FLINK-2410: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2410] [java api] PojoTypeInfo is not co...

2015-09-16 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/943#issuecomment-140757194 The test is included in the PR #1134. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769008#comment-14769008 ] ASF GitHub Bot commented on FLINK-2637: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1134#issuecomment-140756486 Thanks for reviewing @fhueske and @rmetzger. I addressed the comments and updated the PR. --- If your project is set up for it, you can reply to this email and hav

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769004#comment-14769004 ] ASF GitHub Bot commented on FLINK-2637: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1134#discussion_r39634911 --- Diff: flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RenamingProxyTypeInfo.scala --- @@ -31,7 +32,8 @@ import org.apa

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769000#comment-14769000 ] ASF GitHub Bot commented on FLINK-2637: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768998#comment-14768998 ] ASF GitHub Bot commented on FLINK-2637: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2670) Unstable CombineTaskTest

2015-09-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768989#comment-14768989 ] Stephan Ewen commented on FLINK-2670: - I added an extra test for the critical part (th

[GitHub] flink pull request: [FLINK-1851] Add support for casting in Table ...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/592#issuecomment-140752002 Looks good. Will merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768982#comment-14768982 ] ASF GitHub Bot commented on FLINK-2637: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-1851) Java Table API does not support Casting

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768984#comment-14768984 ] ASF GitHub Bot commented on FLINK-1851: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1134#discussion_r39633196 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoField.java --- @@ -68,4 +72,24 @@ private void readObject(ObjectInputStream in

[GitHub] flink pull request: [FLINK-2637] [api-breaking] [scala, types] Add...

2015-09-16 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1134#discussion_r39632768 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeinfo/NumericTypeInfo.java --- @@ -18,16 +18,36 @@ package org.apache.flink

[jira] [Commented] (FLINK-2637) Add abstract equals, hashCode and toString methods to TypeInformation

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768975#comment-14768975 ] ASF GitHub Bot commented on FLINK-2637: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2641) Integrate the off-heap memory configuration with the TaskManager start script

2015-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768972#comment-14768972 ] ASF GitHub Bot commented on FLINK-2641: --- Github user fhueske commented on the pull r

  1   2   >