[GitHub] flink pull request: [FLINK-2077] [core] Rework Path class and add ...

2015-08-30 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1035 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2077) Rework Path class and add extend support for Windows paths

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723038#comment-14723038 ] ASF GitHub Bot commented on FLINK-2077: --- Github user gallenvara closed the pull requ

[GitHub] flink pull request: [FLINK-2596] Failing Test: RandomSamplerTest

2015-08-30 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1080#issuecomment-136276551 Looks good to merge. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[jira] [Commented] (FLINK-2596) Failing Test: RandomSamplerTest

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723001#comment-14723001 ] ASF GitHub Bot commented on FLINK-2596: --- Github user chiwanpark commented on the pul

[jira] [Commented] (FLINK-2596) Failing Test: RandomSamplerTest

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723000#comment-14723000 ] ASF GitHub Bot commented on FLINK-2596: --- GitHub user ChengXiangLi opened a pull requ

[jira] [Assigned] (FLINK-2596) Failing Test: RandomSamplerTest

2015-08-30 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li reassigned FLINK-2596: Assignee: Chengxiang Li > Failing Test: RandomSamplerTest > ---

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721935#comment-14721935 ] ASF GitHub Bot commented on FLINK-2590: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-30 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136245681 @rmetzger +1. I think add a test is helpful. Otherwise can you give us a infomation that prove the 'id = (counter << shifter) + taskId; ' will never generate the

[GitHub] flink pull request: [FLINK-2125][streaming] Delimiter change from ...

2015-08-30 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1077#issuecomment-136243644 Hi, Generally this is a good idea to receive all buffer once instead get a char every time. And you can see my PR:https://github.com/apache/flink/pull/992

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721932#comment-14721932 ] ASF GitHub Bot commented on FLINK-2125: --- Github user HuangWHWHW commented on the pul

[jira] [Commented] (FLINK-2545) NegativeArraySizeException while creating hash table bloom filters

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721931#comment-14721931 ] ASF GitHub Bot commented on FLINK-2545: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-08-30 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-136243437 Nice job, @greghogan , you just pointed out the root cause and the solution. I add the logic to skip latest buckets as @StephanEwen suggested, and add related unit

[GitHub] flink pull request: [FLINK-2125][streaming] Delimiter change from ...

2015-08-30 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/1077#discussion_r38282466 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/functions/SocketTextStreamFunctionTest.java ---

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721923#comment-14721923 ] ASF GitHub Bot commented on FLINK-2125: --- Github user HuangWHWHW commented on a diff

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721918#comment-14721918 ] ASF GitHub Bot commented on FLINK-2525: --- Github user ffbin commented on the pull req

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-08-30 Thread ffbin
Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1046#issuecomment-136241503 @mjsax @StephanEwen I have finish the code changes. 1.serialize Storm Config as a byte[] into the Flink configuration 2.extend ExclamationTopology such that the numb

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-08-30 Thread ankurcha
Github user ankurcha commented on a diff in the pull request: https://github.com/apache/flink/pull/948#discussion_r38281174 --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/SchedulerUtils.scala --- @@ -0,0 +1,348 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721881#comment-14721881 ] ASF GitHub Bot commented on FLINK-1984: --- Github user ankurcha commented on a diff in

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2015-08-30 Thread ankurcha
Github user ankurcha commented on the pull request: https://github.com/apache/flink/pull/948#issuecomment-136236719 @rmetzger I have finally got some time to work on this again. Let me address your question one by one: > Why did you decide to start the JobManager alongside the

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721880#comment-14721880 ] ASF GitHub Bot commented on FLINK-1984: --- Github user ankurcha commented on the pull

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-30 Thread jamescao
GitHub user jamescao opened a pull request: https://github.com/apache/flink/pull/1079 [FLINK1919] add HCatOutputFormat [FLINK1919] Add `HCatOutputFormat` for Tuple data types for java and scala api also fix a bug for the scala api's `HCatInputFormat` for hive complex types.

[jira] [Commented] (FLINK-1681) Remove the old Record API

2015-08-30 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721746#comment-14721746 ] Stephan Ewen commented on FLINK-1681: - Migrated a set of tests from the deprecated API

[GitHub] flink pull request: FLINK-1737: Kronecker product

2015-08-30 Thread daniel-pape
GitHub user daniel-pape opened a pull request: https://github.com/apache/flink/pull/1078 FLINK-1737: Kronecker product This is preparational work related to FLINK-1737: Adds an implementation of outer/Kronecker product which can subsequently be used to compute the sample covariance

[jira] [Commented] (FLINK-1737) Add statistical whitening transformation to machine learning library

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721710#comment-14721710 ] ASF GitHub Bot commented on FLINK-1737: --- GitHub user daniel-pape opened a pull reque

[jira] [Resolved] (FLINK-2543) State handling does not support deserializing classes through the UserCodeClassloader

2015-08-30 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2543. - Resolution: Fixed Fixed via bf8c8e54094151348caedd3120931516f76c3cf3 and 0ba53558f9b56b1e17c84ab8

[jira] [Closed] (FLINK-2543) State handling does not support deserializing classes through the UserCodeClassloader

2015-08-30 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2543. --- > State handling does not support deserializing classes through the > UserCodeClassloader > -

[jira] [Commented] (FLINK-2543) State handling does not support deserializing classes through the UserCodeClassloader

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721659#comment-14721659 ] ASF GitHub Bot commented on FLINK-2543: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2543] Fix user object deserialization f...

2015-08-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721638#comment-14721638 ] ASF GitHub Bot commented on FLINK-2125: --- GitHub user ogokal opened a pull request:

[GitHub] flink pull request: [FLINK-2125][streaming] Delimiter change from ...

2015-08-30 Thread ogokal
GitHub user ogokal opened a pull request: https://github.com/apache/flink/pull/1077 [FLINK-2125][streaming] Delimiter change from char to string I tried to change based on the previous comments. I hope it is sufficient enough. You can merge this pull request into a Git repository b

[GitHub] flink pull request:

2015-08-30 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/554b77bcd9ed66d57d99d4990774a43f35f6a835#commitcomment-12965891 I think this is a good addition. In the future (Hadoop not present), we may have to go for reflection, true. --- If your proj

[GitHub] flink pull request:

2015-08-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/commit/554b77bcd9ed66d57d99d4990774a43f35f6a835#commitcomment-12965859 Currently, flink-runtime has a dependency on Hadoop, so I can assume its always available. Even for a binary Flink release wit

[GitHub] flink pull request:

2015-08-30 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/554b77bcd9ed66d57d99d4990774a43f35f6a835#commitcomment-12965831 At some points there were thoughts about a "hadoop-free" version. How would this play together? --- If your project is set up

[jira] [Commented] (FLINK-2475) Rename Flink Client log file

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721542#comment-14721542 ] ASF GitHub Bot commented on FLINK-2475: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2475] Rename Flink Client log file

2015-08-30 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1074#issuecomment-136152037 Test fails in instable yarn-test. Should be ready to get merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Created] (FLINK-2598) NPE when arguments are missing for a "-m yarn-cluster" job

2015-08-30 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-2598: - Summary: NPE when arguments are missing for a "-m yarn-cluster" job Key: FLINK-2598 URL: https://issues.apache.org/jira/browse/FLINK-2598 Project: Flink Is

[jira] [Commented] (FLINK-2584) ASM dependency is not shaded away

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721504#comment-14721504 ] ASF GitHub Bot commented on FLINK-2584: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136131482 I saw that curator has a netty dependency. If we are running into netty conflicts because of curator's netty dependency, it's very easy to just shade curator's netty

[jira] [Commented] (FLINK-2584) ASM dependency is not shaded away

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721503#comment-14721503 ] ASF GitHub Bot commented on FLINK-2584: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-30 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1076#issuecomment-136131254 Nice work :) This needs to go into the milestone branch as well. What do you mean with "We can easily integrate curator's netty into the jar file."? --- If your pr

[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...

2015-08-30 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1076 [FLINK-2584] Check for unshaded classes in fat jar and shade curator This PR is an addition for FLINK-2584, removing the transitive guava dependencies from the fat jar introduced by Apache Curator.

[jira] [Commented] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721489#comment-14721489 ] ASF GitHub Bot commented on FLINK-2590: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2590] fixing DataSetUtils.zipWithUnique...

2015-08-30 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1075#issuecomment-136129581 Thanks a lot for the contribution. Can you add a test case for the method to make sure the issue is not re-introduced again when somebody else is changing the code?

[jira] [Commented] (FLINK-2584) ASM dependency is not shaded away

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721488#comment-14721488 ] ASF GitHub Bot commented on FLINK-2584: --- GitHub user rmetzger opened a pull request:

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721481#comment-14721481 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-08-30 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r38270665 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -411,6 +411,23 @@ class TaskManager(