[jira] [Closed] (FLINK-2487) the array has out of bounds

[ https://issues.apache.org/jira/browse/FLINK-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Saputra closed FLINK-2487. Resolution: Cannot Reproduce Closing this for now since we need more information to repro. Please re

[jira] [Commented] (FLINK-1901) Create sample operator for Dataset

[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692943#comment-14692943 ] ASF GitHub Bot commented on FLINK-1901: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: [FLINK-1901] [core] Create sample operator for...

Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/949#issuecomment-130175707 Hi, @tillrohrmann , it's ready for review now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692880#comment-14692880 ] ASF GitHub Bot commented on FLINK-2509: --- Github user hsaputra commented on the pull

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-130154250 Agree with Max, this should be useful. Other than small nit on message +1 --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692879#comment-14692879 ] ASF GitHub Bot commented on FLINK-2509: --- Github user hsaputra commented on a diff in

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/1008#discussion_r36825210 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java --- @@ -198,12 +199,26 @@

[GitHub] flink pull request: [FLINK-2512]Add client.close() before throw Ru...

GitHub user ffbin opened a pull request: https://github.com/apache/flink/pull/1009 [FLINK-2512]Add client.close() before throw RuntimeException In line 129, it close client in finally{} before throw exception. But in line 105, it throw exception without close client. So I thi

[jira] [Commented] (FLINK-2512) Add client.close() before throw RuntimeException

[ https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692814#comment-14692814 ] ASF GitHub Bot commented on FLINK-2512: --- GitHub user ffbin opened a pull request:

[jira] [Created] (FLINK-2512) Add client.close() before throw RuntimeException

fangfengbin created FLINK-2512: -- Summary: Add client.close() before throw RuntimeException Key: FLINK-2512 URL: https://issues.apache.org/jira/browse/FLINK-2512 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-2162) Implement adaptive learning rate strategies for SGD

[ https://issues.apache.org/jira/browse/FLINK-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692488#comment-14692488 ] Ventura Del Monte commented on FLINK-2162: -- I implemented all the strategies that

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692332#comment-14692332 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130091134 @mxm, @sachingoel0101 get your point. Being consistent with the remaining API is a valid argument. I would be OK with calling the abstract classes `RichInputFormat` and `

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-130078564 Okay. I'll hold off on making any changes right now. We should reach at a consensus first. --- If your project is set up for it, you can reply to this email and h

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14687386#comment-14687386 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on the

[jira] [Commented] (FLINK-2511) Potential resource leak due to unclosed InputStream in FlinkZooKeeperQuorumPeer.java

[ https://issues.apache.org/jira/browse/FLINK-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682473#comment-14682473 ] Henry Saputra commented on FLINK-2511: -- Looks like we have some potential non close s

[jira] [Resolved] (FLINK-2511) Potential resource leak due to unclosed InputStream in FlinkZooKeeperQuorumPeer.java

[ https://issues.apache.org/jira/browse/FLINK-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-2511. Resolution: Fixed Fix Version/s: 0.10 Good catch! Thanks! Fixed via d8d0748. Since we now r

[jira] [Assigned] (FLINK-2511) Potential resource leak due to unclosed InputStream in FlinkZooKeeperQuorumPeer.java

[ https://issues.apache.org/jira/browse/FLINK-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-2511: -- Assignee: Ufuk Celebi > Potential resource leak due to unclosed InputStream in > FlinkZooKeepe

[jira] [Created] (FLINK-2511) Potential resource leak due to unclosed InputStream in FlinkZooKeeperQuorumPeer.java

Ted Yu created FLINK-2511: - Summary: Potential resource leak due to unclosed InputStream in FlinkZooKeeperQuorumPeer.java Key: FLINK-2511 URL: https://issues.apache.org/jira/browse/FLINK-2511 Project: Flink

[GitHub] flink pull request: [FLINK-2437] Fix default constructor detection...

Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/960#issuecomment-130050479 OK, I re-added the changes to remove the double "class". (Note, that the 3rd bullet in the opening comment refers to this doubling.) --- If your project is set up for it,

[jira] [Commented] (FLINK-2437) TypeExtractor.analyzePojo has some problems around the default constructor detection

[ https://issues.apache.org/jira/browse/FLINK-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682411#comment-14682411 ] ASF GitHub Bot commented on FLINK-2437: --- Github user ggevay commented on the pull re

[GitHub] flink pull request: Hits

Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-130016029 @vasia , I guess the guys already finished the IMPRO3 course. What is the status of this PR @mfahimazizi? Do you have time to address the comments? Are you st

[jira] [Commented] (FLINK-1520) Read edges and vertices from CSV files

[ https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682279#comment-14682279 ] ASF GitHub Bot commented on FLINK-1520: --- Github user andralungu commented on the pul

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-130014300 Saw this "I will also update the documentation " afterwards... Sorry! --- If your project is set up for it, you can reply to this email and have your reply appear on G

[jira] [Commented] (FLINK-1520) Read edges and vertices from CSV files

[ https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682282#comment-14682282 ] ASF GitHub Bot commented on FLINK-1520: --- Github user andralungu commented on the pul

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-130013958 Hi @vasia, Not sure whether this comment was issued for me... Nevertheless I left some suggestions inline. All in all, it covers the problems discussed in the

[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...

Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-130003492 I guess the only request that was not fulfilled for this PR was to squash the commits. Then it should be fine. --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-2451) Cleanup Gelly examples

[ https://issues.apache.org/jira/browse/FLINK-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682230#comment-14682230 ] ASF GitHub Bot commented on FLINK-2451: --- Github user andralungu commented on the pul

[GitHub] flink pull request: [FLINK-2451] [gelly] examples and library clea...

Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/1000#issuecomment-130002982 Apart from the minor comment, this looks good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (FLINK-2451) Cleanup Gelly examples

[ https://issues.apache.org/jira/browse/FLINK-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682220#comment-14682220 ] ASF GitHub Bot commented on FLINK-2451: --- Github user andralungu commented on a diff

[GitHub] flink pull request: [FLINK-2451] [gelly] examples and library clea...

Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/1000#discussion_r36779494 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/GatherSumApplyITCase.java --- @@ -86,26 +72,35 @@ public void testConnectedC

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682030#comment-14682030 ] ASF GitHub Bot commented on FLINK-2509: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-129955067 Good comment, will adjust this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-2510) KafkaConnector should access partition metadata from master/cluster

[ https://issues.apache.org/jira/browse/FLINK-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681994#comment-14681994 ] Stephan Ewen commented on FLINK-2510: - Currently blocked by [FLINK-2386] > KafkaConne

[jira] [Created] (FLINK-2510) KafkaConnector should access partition metadata from master/cluster

Stephan Ewen created FLINK-2510: --- Summary: KafkaConnector should access partition metadata from master/cluster Key: FLINK-2510 URL: https://issues.apache.org/jira/browse/FLINK-2510 Project: Flink

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1008#issuecomment-129947817 This is great and will be very helpful while debugging! Only the output is very hard to read. How about this? Just some new lines and indention: ``` Cannot load user

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681990#comment-14681990 ] ASF GitHub Bot commented on FLINK-2509: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2499) start-cluster.sh can start multiple TaskManager on the same node

[ https://issues.apache.org/jira/browse/FLINK-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681926#comment-14681926 ] Chen He commented on FLINK-2499: +1, not only warning, we need to track each started TM so

[jira] [Comment Edited] (FLINK-2501) [py] Remove the need to specify types for transformations

[ https://issues.apache.org/jira/browse/FLINK-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681911#comment-14681911 ] Chesnay Schepler edited comment on FLINK-2501 at 8/11/15 3:02 PM: --

[jira] [Commented] (FLINK-2501) [py] Remove the need to specify types for transformations

[ https://issues.apache.org/jira/browse/FLINK-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681911#comment-14681911 ] Chesnay Schepler commented on FLINK-2501: - yes. modified (2) would mean that you h

[jira] [Commented] (FLINK-2501) [py] Remove the need to specify types for transformations

[ https://issues.apache.org/jira/browse/FLINK-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681906#comment-14681906 ] Stephan Ewen commented on FLINK-2501: - Can the Java API always think as Tuple2 (key/va

[jira] [Comment Edited] (FLINK-2501) [py] Remove the need to specify types for transformations

[ https://issues.apache.org/jira/browse/FLINK-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680732#comment-14680732 ] Chesnay Schepler edited comment on FLINK-2501 at 8/11/15 2:49 PM: --

[jira] [Commented] (FLINK-2509) Improve error messages when user code classes are not found

[ https://issues.apache.org/jira/browse/FLINK-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681842#comment-14681842 ] ASF GitHub Bot commented on FLINK-2509: --- GitHub user StephanEwen opened a pull reque

[GitHub] flink pull request: [FLINK-2509] Add class loader info to exceptio...

GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1008 [FLINK-2509] Add class loader info to exception message when user code classes are not found This pull request adds the following type of info to the exception message: ``` Cannot l

[jira] [Created] (FLINK-2509) Improve error messages when user code classes are not found

Stephan Ewen created FLINK-2509: --- Summary: Improve error messages when user code classes are not found Key: FLINK-2509 URL: https://issues.apache.org/jira/browse/FLINK-2509 Project: Flink Issu

[jira] [Closed] (FLINK-2423) Properly test checkpoint notifications

[ https://issues.apache.org/jira/browse/FLINK-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-2423. - Resolution: Implemented Fix Version/s: 0.10 Via 10ce2e2. > Properly test checkpoint notifi

[jira] [Commented] (FLINK-2423) Properly test checkpoint notifications

[ https://issues.apache.org/jira/browse/FLINK-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681827#comment-14681827 ] ASF GitHub Bot commented on FLINK-2423: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2423] [streaming] ITCase for checkpoint...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/980 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681802#comment-14681802 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-129875331 @mxm Ok, I`ll add a test. There is a little difficult that I can`t get the retry times in test since the retry is a local variable. So can I add a function

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-129864531 @HuangWHWHW `retryForever` is just a convenience variable for `maxRetry < 0`. Your fix is correct because the loop will only execute if `maxRetry > 0` and thus not execute at

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681771#comment-14681771 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull reque

[jira] [Created] (FLINK-2508) Confusing sharing of StreamExecutionEnvironment

Stephan Ewen created FLINK-2508: --- Summary: Confusing sharing of StreamExecutionEnvironment Key: FLINK-2508 URL: https://issues.apache.org/jira/browse/FLINK-2508 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-2477) Add test for SocketClientSink

[ https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681711#comment-14681711 ] ASF GitHub Bot commented on FLINK-2477: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2477][Add]Add tests for SocketClientSin...

Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/977#issuecomment-129854454 @StephanEwen Hi, I push a new fix about the exception. Would you please to check whether it`s correct? And there is another PR(https://github.com/apache/fli

[jira] [Commented] (FLINK-2507) Rename the function tansformAndEmit in org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector

[ https://issues.apache.org/jira/browse/FLINK-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681708#comment-14681708 ] ASF GitHub Bot commented on FLINK-2507: --- Github user ffbin commented on the pull req

[GitHub] flink pull request: [FLINK-2507]Rename the function tansformAndEmi...

Github user ffbin commented on the pull request: https://github.com/apache/flink/pull/1007#issuecomment-129854098 @chiwanpark Thank you very much. I submit code in linux and modify the permissions Incorrectly.I will submit again,. --- If your project is set up for it, you can reply t

[jira] [Commented] (FLINK-2423) Properly test checkpoint notifications

[ https://issues.apache.org/jira/browse/FLINK-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681704#comment-14681704 ] ASF GitHub Bot commented on FLINK-2423: --- Github user mbalassi commented on the pull

[GitHub] flink pull request: [FLINK-2423] [streaming] ITCase for checkpoint...

Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/980#issuecomment-129851909 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] flink pull request: [FLINK-2507]Rename the function tansformAndEmi...

Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1007#issuecomment-129850783 Why the permissions of file are changed from 644 to 755? Other changes seems good. --- If your project is set up for it, you can reply to this email and have your re

[jira] [Commented] (FLINK-2507) Rename the function tansformAndEmit in org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector

[ https://issues.apache.org/jira/browse/FLINK-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681694#comment-14681694 ] ASF GitHub Bot commented on FLINK-2507: --- Github user chiwanpark commented on the pul

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-129849477 Yes, existing formats should converted to "rich" formats. The name `Abstract..` makes more sense if it becomes the new default way of interfacing with the rich input/output f

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681689#comment-14681689 ] ASF GitHub Bot commented on FLINK-1819: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2386) Implement Kafka connector using the new Kafka Consumer API

[ https://issues.apache.org/jira/browse/FLINK-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681686#comment-14681686 ] ASF GitHub Bot commented on FLINK-2386: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [WIP][FLINK-2386] Add new Kafka Consumers

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/996#issuecomment-129849082 I'll take a stab at checking out this monster ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-129847518 I'm in favor of making the existing formats "rich". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681674#comment-14681674 ] ASF GitHub Bot commented on FLINK-1819: --- Github user fhueske commented on the pull r

[jira] [Closed] (FLINK-2277) In Scala API delta Iterations can not be set to unmanaged

[ https://issues.apache.org/jira/browse/FLINK-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2277. --- > In Scala API delta Iterations can not be set to unmanaged >

[jira] [Resolved] (FLINK-2277) In Scala API delta Iterations can not be set to unmanaged

[ https://issues.apache.org/jira/browse/FLINK-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2277. - Resolution: Fixed Fix Version/s: 0.10 Fixed via f50ae26a2fb4a0c7f5b390e2f0f5528be9f61730 T

[jira] [Resolved] (FLINK-2500) Some reviews to improve code quality

[ https://issues.apache.org/jira/browse/FLINK-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2500. - Resolution: Fixed Fixed via b42fbf7a81c5b57dcf9760825edb175ffd944fb2 Thank you for the contributi

[jira] [Closed] (FLINK-2500) Some reviews to improve code quality

[ https://issues.apache.org/jira/browse/FLINK-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2500. --- > Some reviews to improve code quality > > > Key: FLI

[jira] [Closed] (FLINK-2502) FiniteStormSpout documenation does not render correclty

[ https://issues.apache.org/jira/browse/FLINK-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2502. --- > FiniteStormSpout documenation does not render correclty > --

[jira] [Resolved] (FLINK-2502) FiniteStormSpout documenation does not render correclty

[ https://issues.apache.org/jira/browse/FLINK-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2502. - Resolution: Fixed Fix Version/s: 0.10 Fixed via 5bb855bac7441701495ce47db7ba03ab0e0c6963 >

[GitHub] flink pull request: [FLINK-2500][Streaming]remove a unwanted "if" ...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1001 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2277) In Scala API delta Iterations can not be set to unmanaged

[ https://issues.apache.org/jira/browse/FLINK-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681626#comment-14681626 ] ASF GitHub Bot commented on FLINK-2277: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-2500) Some reviews to improve code quality

[ https://issues.apache.org/jira/browse/FLINK-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681629#comment-14681629 ] ASF GitHub Bot commented on FLINK-2500: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-2357) New JobManager Runtime Web Frontend

[ https://issues.apache.org/jira/browse/FLINK-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681628#comment-14681628 ] ASF GitHub Bot commented on FLINK-2357: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2277] In Scala API delta Iterations can...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1005 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2502] FiniteStormSpout documenation doe...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1002 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2502) FiniteStormSpout documenation does not render correclty

[ https://issues.apache.org/jira/browse/FLINK-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681627#comment-14681627 ] ASF GitHub Bot commented on FLINK-2502: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2357] Update Node installation instruct...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1006 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2507]Rename the function tansformAndEmi...

GitHub user ffbin opened a pull request: https://github.com/apache/flink/pull/1007 [FLINK-2507]Rename the function tansformAndEmit I think the function name "tansformAndEmit" in ' org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector' is a wrong spelling, it should be

[jira] [Commented] (FLINK-2507) Rename the function tansformAndEmit in org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector

[ https://issues.apache.org/jira/browse/FLINK-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681622#comment-14681622 ] ASF GitHub Bot commented on FLINK-2507: --- GitHub user ffbin opened a pull request:

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-129834217 Okay. I think maybe calling them `Rich` maybe an overkill. I will change the names to `Abstract`. Do we keep the existing formats *non-rich* or would it be oka

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681603#comment-14681603 ] ASF GitHub Bot commented on FLINK-1819: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2277] In Scala API delta Iterations can...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1005#issuecomment-129831692 Thanks! I know it is extra code, but allowing existing code to continue running without recompile is something that people really appreciate. Mergin

[jira] [Commented] (FLINK-2277) In Scala API delta Iterations can not be set to unmanaged

[ https://issues.apache.org/jira/browse/FLINK-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681600#comment-14681600 ] ASF GitHub Bot commented on FLINK-2277: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-129830222 Okay, so how about calling the abstract base class`AbstractInputFormat` and have it implement the runtime context and leaves the other methods abstract? --- If your

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681594#comment-14681594 ] ASF GitHub Bot commented on FLINK-1819: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2477][Add]Add tests for SocketClientSin...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/977#issuecomment-129829151 Looks much better. Two more comments: 1. It would be good to print the exception in addition to failing the test, because otherwise the tests only fails and g

[jira] [Commented] (FLINK-2477) Add test for SocketClientSink

[ https://issues.apache.org/jira/browse/FLINK-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681592#comment-14681592 ] ASF GitHub Bot commented on FLINK-2477: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-1819) Allow access to RuntimeContext from Input and OutputFormats

[ https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681584#comment-14681584 ] ASF GitHub Bot commented on FLINK-1819: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-1819][core]Allow access to RuntimeConte...

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/966#issuecomment-129826022 @StephanEwen @fhueske The `Rich` prefix might seem a bit odd but it is a naming convention that is consistent with the user-defined functions which have the RuntimeContex

[jira] [Commented] (FLINK-2277) In Scala API delta Iterations can not be set to unmanaged

[ https://issues.apache.org/jira/browse/FLINK-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681580#comment-14681580 ] ASF GitHub Bot commented on FLINK-2277: --- Github user PieterJanVanAeken commented on

[GitHub] flink pull request: [FLINK-2277] In Scala API delta Iterations can...

Github user PieterJanVanAeken commented on the pull request: https://github.com/apache/flink/pull/1005#issuecomment-129817057 I changed the implementation to overloaded methods and I added one for integer based keyFields, a method I overlooked in my previous commit. --- If your proje

[jira] [Commented] (FLINK-2502) FiniteStormSpout documenation does not render correclty

[ https://issues.apache.org/jira/browse/FLINK-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681563#comment-14681563 ] ASF GitHub Bot commented on FLINK-2502: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2502] FiniteStormSpout documenation doe...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1002#issuecomment-129805634 Looks good, will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (FLINK-2277) In Scala API delta Iterations can not be set to unmanaged

[ https://issues.apache.org/jira/browse/FLINK-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681562#comment-14681562 ] ASF GitHub Bot commented on FLINK-2277: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2277] In Scala API delta Iterations can...

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1005#issuecomment-129805238 I like the change, but I would like to change it to an overloaded method, rather than adding a parameter with default value. In the current way, it breaks th

[jira] [Commented] (FLINK-2357) New JobManager Runtime Web Frontend

[ https://issues.apache.org/jira/browse/FLINK-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681559#comment-14681559 ] ASF GitHub Bot commented on FLINK-2357: --- Github user StephanEwen commented on the pu

  1   2   >