[
https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638272#comment-14638272
]
Chengxiang Li commented on FLINK-1901:
--
Thanks,[~till.rohrmann], i got it now. This m
[
https://issues.apache.org/jira/browse/FLINK-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637602#comment-14637602
]
ASF GitHub Bot commented on FLINK-2205:
---
Github user ebautistabar commented on the p
Github user ebautistabar commented on the pull request:
https://github.com/apache/flink/pull/927#issuecomment-123860972
Hi @fhueske, @StephanEwen, I wasn't aware of that. Just picked a starter
issue to get my feet wet.
I've added the other suggested change, in case you decide
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637385#comment-14637385
]
niraj rai commented on FLINK-1818:
--
Thanks Max for mentoring me.. Really appreciate your
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123815171
@rainiraj Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels resolved FLINK-1818.
---
Resolution: Implemented
> Provide API to cancel running job
>
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637347#comment-14637347
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user mxm commented on the pull reque
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637346#comment-14637346
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637329#comment-14637329
]
Stephan Ewen commented on FLINK-2373:
-
That is definitely a good idea. Would you be up
[
https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels closed FLINK-2388.
-
Resolution: Fixed
Thanks for your help, [~ebautistabar]!
> JobManager should try retrievi
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/930
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
[
https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637274#comment-14637274
]
ASF GitHub Bot commented on FLINK-2388:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637254#comment-14637254
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user mxm commented on the pull reque
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123802868
Thanks @rainiraj. I think we can merge your changes with some small
adjustments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637251#comment-14637251
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240436
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
boole
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240453
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
boole
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240432
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
boole
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637250#comment-14637250
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/642#discussion_r35240445
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -421,6 +426,50 @@ public JobSubmissionResult run(JobGraph jobGraph,
boole
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637249#comment-14637249
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637248#comment-14637248
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637083#comment-14637083
]
Aljoscha Krettek commented on FLINK-2393:
-
I guess you meant "no state backup for
[
https://issues.apache.org/jira/browse/FLINK-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637068#comment-14637068
]
ASF GitHub Bot commented on FLINK-2385:
---
GitHub user StephanEwen opened a pull reque
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/933
[FLINK-2385] [scala api] Add parenthesis to Scala 'distinct' transformation.
The operation is not side-effect free. It does not mutate the original
DataSet, but defines distributed computation.
Stefano Bortoli created FLINK-2394:
--
Summary: HadoopOutFormat OutputCommitter is default to
FileOutputCommiter
Key: FLINK-2394
URL: https://issues.apache.org/jira/browse/FLINK-2394
Project: Flink
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/917#issuecomment-123757309
Looks good. +1 to merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637064#comment-14637064
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user StephanEwen commented on the pu
Stephan Ewen created FLINK-2393:
---
Summary: Add a "stateless at-least-once" mode for streaming
Key: FLINK-2393
URL: https://issues.apache.org/jira/browse/FLINK-2393
Project: Flink
Issue Type: Ne
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123756855
Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123756678
@kl0u Sure, I've sent you an email.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/917#issuecomment-123755971
Addressed the following comments: Corrected order of visibility and
abstract modifiers. Removed the lazy log field from `FlinkActor`. Now all
implementing subclasses
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637059#comment-14637059
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user tillrohrmann commented on the p
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/858#issuecomment-123755792
It should just add more nodes to the ExecutionGraph. Existing ones should
not be modified. For batch, I think the assumption is that it needs to be
finished. For streaming, I
[
https://issues.apache.org/jira/browse/FLINK-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637045#comment-14637045
]
ASF GitHub Bot commented on FLINK-2097:
---
Github user mxm commented on the pull reque
[
https://issues.apache.org/jira/browse/FLINK-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637038#comment-14637038
]
ASF GitHub Bot commented on FLINK-2097:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/858#issuecomment-123754538
I think right now, it pretty much behaves as if someone started a new job,
with the "grown" execution graph.
---
If your project is set up for it, you can reply to t
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123752371
Hi @mxm. Thanks a lot!
I don't have your email unfortunately.
Could you somehow send it to me?
---
If your project is set up for it, you can reply to this email and
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/917#issuecomment-123751721
Do you mean `JobManager.getJobManagerGateway`? This is only a temporary
solution to obtain an `ActorGateway` for the JobManager for which you have to
know the curren
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637031#comment-14637031
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user tillrohrmann commented on the p
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123745096
Hi @kl0u, I'm sorry that my changes overlap so much with yours. Let me know
if you have any questions. I think you have my email address?
---
If your project is set up for i
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/930#discussion_r35219511
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -687,61 +687,23 @@ class JobManager(
message match {
[
https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637011#comment-14637011
]
ASF GitHub Bot commented on FLINK-2388:
---
Github user mxm commented on a diff in the
Github user rainiraj commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-123741223
Hi Max, all your comment feedback have been incorporated in the new pull
request. Please review them.
Thanks
Niraj
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637008#comment-14637008
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user rainiraj commented on the pull
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123738197
Hello,
The latest changes are pretty invasive and have a big overlap with the ones
in my pull request.
More specifically, the abstraction of the AccumulatorRegi
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/917#issuecomment-123737269
* I chose to call the method `decorateMessage` because it not necessarily
only attaches leader session IDs. In the future we might use this method for
something othe
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636970#comment-14636970
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user tillrohrmann commented on the p
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/917#issuecomment-123736731
Is the `JobManagerGateway` a temporary solution?
If I understood it correctly, in the full-fledged integration with
Zookeeper, an actor that wants to send a messag
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636966#comment-14636966
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/917#discussion_r35216181
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/FlinkActor.scala ---
@@ -19,34 +19,30 @@
package org.apache.flink.runtime
i
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636964#comment-14636964
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636951#comment-14636951
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/917#discussion_r35215346
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/FlinkActor.scala ---
@@ -19,34 +19,30 @@
package org.apache.flink.runtime
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636945#comment-14636945
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/917#discussion_r35214927
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/akka/FlinkUntypedActor.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache S
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/858#issuecomment-123726241
I just had a look at the JobManager in a different context and thought
about the following, which might be relevant here: when submitting a new
JobGraph, which is attached to
[
https://issues.apache.org/jira/browse/FLINK-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636922#comment-14636922
]
ASF GitHub Bot commented on FLINK-2097:
---
Github user uce commented on the pull reque
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/917#issuecomment-123723565
The `leaderSessionID` in the JobManager is constant. Can it not change over
time? An example would be when a JobManager looses the ZooKeeper connection
(network parti
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636917#comment-14636917
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user StephanEwen commented on the pu
Github user ebautistabar commented on a diff in the pull request:
https://github.com/apache/flink/pull/930#discussion_r35212342
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -687,61 +687,23 @@ class JobManager(
message
[
https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636909#comment-14636909
]
ASF GitHub Bot commented on FLINK-2388:
---
Github user ebautistabar commented on a dif
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/917#discussion_r35212080
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/FlinkActor.scala ---
@@ -19,34 +19,30 @@
package org.apache.flink.runtime
i
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636904#comment-14636904
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/917#issuecomment-123720593
The mechanism looks good, all in all.
Some comments:
- I think it makes the code more understandable, if the
`decorateMessage()` method would be called
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636900#comment-14636900
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user StephanEwen commented on the pu
[
https://issues.apache.org/jira/browse/FLINK-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636894#comment-14636894
]
ASF GitHub Bot commented on FLINK-2332:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/917#discussion_r35211408
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/akka/FlinkUntypedActor.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache So
[
https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636867#comment-14636867
]
ASF GitHub Bot commented on FLINK-2388:
---
Github user mxm commented on the pull reque
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/930#issuecomment-123710720
Merging this later on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
[
https://issues.apache.org/jira/browse/FLINK-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax closed FLINK-2304.
--
Resolution: Fixed
> Add named attribute access to Storm compatibility layer
> --
[
https://issues.apache.org/jira/browse/FLINK-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels resolved FLINK-2218.
---
Resolution: Fixed
> Web client cannot distinguesh between Flink options and program ar
[
https://issues.apache.org/jira/browse/FLINK-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636858#comment-14636858
]
ASF GitHub Bot commented on FLINK-2218:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/904
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Matthias J. Sax created FLINK-2392:
--
Summary: Instable test in flink-yarn-tests
Key: FLINK-2392
URL: https://issues.apache.org/jira/browse/FLINK-2392
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636854#comment-14636854
]
ASF GitHub Bot commented on FLINK-2218:
---
Github user mxm commented on the pull reque
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-123707491
Yes, please open a JIRA. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
[
https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-1658.
---
Resolution: Fixed
Fix Version/s: 0.10
FIxed in
https://github.com/apache/flink/commit/
[
https://issues.apache.org/jira/browse/FLINK-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636828#comment-14636828
]
ASF GitHub Bot commented on FLINK-1658:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/929
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
[
https://issues.apache.org/jira/browse/FLINK-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636825#comment-14636825
]
ASF GitHub Bot commented on FLINK-2243:
---
Github user mjsax commented on the pull req
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/853#issuecomment-123705638
Can you also extend documentation for this feature? (I followed a
"only-1-sentence-in-1-line" approach; please do the same). I would suggest to
open a new section "Flink ex
[
https://issues.apache.org/jira/browse/FLINK-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636812#comment-14636812
]
ASF GitHub Bot commented on FLINK-2218:
---
Github user mjsax commented on the pull req
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-123703823
Ok. So this PR can be merged, I guess. I will open a JIRA for the failing
test.
---
If your project is set up for it, you can reply to this email and have your
reply appea
[
https://issues.apache.org/jira/browse/FLINK-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636807#comment-14636807
]
ASF GitHub Bot commented on FLINK-2218:
---
Github user mxm commented on the pull reque
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-123702675
The yarn tests build fine on my machine with your branch. Seems to be a
general issue within the YARN tests.
---
If your project is set up for it, you can reply to this emai
[
https://issues.apache.org/jira/browse/FLINK-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636798#comment-14636798
]
ASF GitHub Bot commented on FLINK-2205:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/927#issuecomment-123700358
The job manager UI is under rework right now, there is a new version coming
up, see here:
https://github.com/apache/flink/tree/master/flink-runtime-web
[
https://issues.apache.org/jira/browse/FLINK-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636797#comment-14636797
]
ASF GitHub Bot commented on FLINK-2322:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/928#issuecomment-123700349
Maybe your vim is set to replace tabs with spaces, but in the files that
you changed there are definitely spaces now.
---
If your project is set up for it, you can repl
[
https://issues.apache.org/jira/browse/FLINK-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636776#comment-14636776
]
ASF GitHub Bot commented on FLINK-2391:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/932#discussion_r35205049
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyBuilder.java
---
[
https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636774#comment-14636774
]
ASF GitHub Bot commented on FLINK-2388:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/930#discussion_r35204984
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -687,61 +687,23 @@ class JobManager(
message match {
[
https://issues.apache.org/jira/browse/FLINK-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636770#comment-14636770
]
ASF GitHub Bot commented on FLINK-2391:
---
Github user mjsax commented on a diff in th
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/932#issuecomment-123692979
I can reproduce the bug. But the fix is incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/932#discussion_r35204796
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyBuilder.java
---
[
https://issues.apache.org/jira/browse/FLINK-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636768#comment-14636768
]
ASF GitHub Bot commented on FLINK-2391:
---
Github user mjsax commented on the pull req
[
https://issues.apache.org/jira/browse/FLINK-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636764#comment-14636764
]
ASF GitHub Bot commented on FLINK-2388:
---
Github user mxm commented on a diff in the
1 - 100 of 166 matches
Mail list logo
