[
https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584886#comment-14584886
]
Vasia Kalavri commented on FLINK-1520:
--
I don't think it'll be a lot of duplicate cod
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-111762942
Then shouldn't we throw an exception like we do in degrees with a "The edge
src/trg id is invalid" or something, instead of hiding the exception?
---
If your project is se
[
https://issues.apache.org/jira/browse/FLINK-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584885#comment-14584885
]
ASF GitHub Bot commented on FLINK-2178:
---
Github user vasia commented on the pull req
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-111761198
Yup, exactly! The use case was: I modified something in the edge data set,
called groupReduceOnNeighbors on the result and got NPE, exception that could
have been avoi
[
https://issues.apache.org/jira/browse/FLINK-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584883#comment-14584883
]
ASF GitHub Bot commented on FLINK-2178:
---
Github user andralungu commented on the pul
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/770#issuecomment-111760796
+1 except the minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
[
https://issues.apache.org/jira/browse/FLINK-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584882#comment-14584882
]
ASF GitHub Bot commented on FLINK-2149:
---
Github user vasia commented on the pull req
[
https://issues.apache.org/jira/browse/FLINK-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584881#comment-14584881
]
ASF GitHub Bot commented on FLINK-2149:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/770#discussion_r32374939
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasure.java
---
@@ -66,34 +63,47 @@ public static void main(S
[
https://issues.apache.org/jira/browse/FLINK-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584877#comment-14584877
]
ASF GitHub Bot commented on FLINK-2178:
---
Github user vasia commented on the pull req
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-111760267
Hey @andralungu,
I'm not sure I understand this one. It's a coGroup of vertices with the
edges. For the vertex iterator to be empty, doesn't it mean that there's an
[
https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584874#comment-14584874
]
Andra Lungu commented on FLINK-1520:
Yup, I am not happy with the argument passing, as
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-111759442
Hi @shghatge! Thank you for the PR!
I left you a couple of comments. Let us know if you have questions :)
---
If your project is set up for it, you can reply to this em
[
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584870#comment-14584870
]
ASF GitHub Bot commented on FLINK-2093:
---
Github user vasia commented on the pull req
[
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584867#comment-14584867
]
ASF GitHub Bot commented on FLINK-2093:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/818#discussion_r32374715
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1234,6 +1234,18 @@ public void coGroup(Iterable> edge,
Iterable> edg
[
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584866#comment-14584866
]
ASF GitHub Bot commented on FLINK-2093:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/818#discussion_r32374703
--- Diff: docs/libs/gelly_guide.md ---
@@ -240,6 +240,7 @@ Graph networkWithWeights =
network.joinWithEdgesOnSource(v
+* Difference: Ge
[
https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584855#comment-14584855
]
Vasia Kalavri commented on FLINK-1520:
--
Hi [~andralungu],
you are right, we need a w
[
https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584855#comment-14584855
]
Vasia Kalavri edited comment on FLINK-1520 at 6/13/15 10:44 PM:
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584852#comment-14584852
]
niraj rai commented on FLINK-1818:
--
Hi [~mjsax] Yes, I will submit another pull request i
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/832
[FLINK-2152] Added zipWithIndex
This PR adds the zipWithIndex utility method to Flink's DataSetUtils as
described in the mailing list discussion:
http://apache-flink-mailing-list-archive.1008284
[
https://issues.apache.org/jira/browse/FLINK-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584840#comment-14584840
]
ASF GitHub Bot commented on FLINK-2152:
---
GitHub user andralungu opened a pull reques
[
https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584836#comment-14584836
]
ASF GitHub Bot commented on FLINK-1818:
---
Github user mjsax commented on the pull req
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-111755816
Any news on this PR? I thinks it is a nice feature? @rainiraj do you still
work on this?
---
If your project is set up for it, you can reply to this email and have your
re
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/573#issuecomment-111755768
Any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
[
https://issues.apache.org/jira/browse/FLINK-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584835#comment-14584835
]
ASF GitHub Bot commented on FLINK-2175:
---
Github user mjsax commented on the pull req
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-111755732
Any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-2203.
---
Resolution: Fixed
Resolved in
https://github.com/apache/flink/commit/f8e12b20d925c3f6f2476932
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584783#comment-14584783
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111741260
Thanks, nice work. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584782#comment-14584782
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584671#comment-14584671
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user Shiti commented on the pull req
Github user Shiti commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111723371
@aljoscha I have made the suggested changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584641#comment-14584641
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111717366
I had some more remarks, sorry for being so picky. :sweat_smile:
Other than that, I think the change looks really good now!
---
If your project is set up for i
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584637#comment-14584637
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584639#comment-14584639
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32371128
--- Diff:
flink-staging/flink-table/src/test/scala/org/apache/flink/api/table/typeinfo/RowSerializerTest.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32371124
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowSerializer.scala
---
@@ -102,20 +119,39 @@ class RowSerializer(fiel
[
https://issues.apache.org/jira/browse/FLINK-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584610#comment-14584610
]
Johannes Günther commented on FLINK-2208:
-
My first guess is that the IBM JDK is n
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584596#comment-14584596
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user Shiti commented on the pull req
Github user Shiti commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111709239
@aljoscha I have updated the RowSerializerTest to use SerializerTestBase
and reverted to using while loops in RowSerializer
---
If your project is set up for it, you can r
[
https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584586#comment-14584586
]
Andra Lungu commented on FLINK-1520:
Hey [~vkalavri]],
To my knowledge, you cannot de
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111701489
The changes look good except for comments I had about the loops.
For the tests, did you try doing it as in TraversableSerializerTest.scala.
Here, we override dee
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584572#comment-14584572
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user aljoscha commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584568#comment-14584568
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584567#comment-14584567
]
ASF GitHub Bot commented on FLINK-2203:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32369781
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowSerializer.scala
---
@@ -74,11 +79,16 @@ class RowSerializer(fieldS
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32369782
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowSerializer.scala
---
@@ -89,11 +99,16 @@ class RowSerializer(fieldS
51 matches
Mail list logo
