[jira] [Closed] (FLINK-1826) Remove the code never be executed in function getNumPages

2015-04-04 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-1826. - Resolution: Not a Problem > Remove the code never be executed in function getNumPages > --

[GitHub] flink pull request: [FLINK-1826]Remove the redundant codes never b...

2015-04-04 Thread matadorhong
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/569#issuecomment-89706960 OK. I accept it. I will close the PR. Thanks for your answer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-1826) Remove the code never be executed in function getNumPages

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396033#comment-14396033 ] ASF GitHub Bot commented on FLINK-1826: --- Github user matadorhong commented on the pu

[GitHub] flink pull request: [FLINK-1826]Remove the redundant codes never b...

2015-04-04 Thread matadorhong
Github user matadorhong closed the pull request at: https://github.com/apache/flink/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-1826) Remove the code never be executed in function getNumPages

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396034#comment-14396034 ] ASF GitHub Bot commented on FLINK-1826: --- Github user matadorhong closed the pull req

[jira] [Commented] (FLINK-1808) Omit sending checkpoint barriers when the execution graph is not running

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395830#comment-14395830 ] ASF GitHub Bot commented on FLINK-1808: --- Github user mbalassi commented on the pull

[GitHub] flink pull request: [FLINK-1808] Send barrier requests only when t...

2015-04-04 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/551#issuecomment-89620475 Thanks for the fix, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-1800) Add a "Beta" badge in the documentation to components in flink-staging

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395829#comment-14395829 ] ASF GitHub Bot commented on FLINK-1800: --- Github user mbalassi commented on the pull

[GitHub] flink pull request: [FLINK-1800][docs] Add beta badge to component...

2015-04-04 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/555#issuecomment-89620103 +1 for Ufuk's suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Commented] (FLINK-1824) Allow missing types for DataStreams

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395828#comment-14395828 ] ASF GitHub Bot commented on FLINK-1824: --- Github user mbalassi commented on the pull

[GitHub] flink pull request: [FLINK-1824] [streaming] Support added for mis...

2015-04-04 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/567#issuecomment-89619837 LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1825]Fix the constructor comments with ...

2015-04-04 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/568#issuecomment-89618942 LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-1825) Fix the constructor comments with correct parameter in DefaultMemoryManager

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395827#comment-14395827 ] ASF GitHub Bot commented on FLINK-1825: --- Github user mbalassi commented on the pull

[jira] [Commented] (FLINK-1826) Remove the code never be executed in function getNumPages

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395825#comment-14395825 ] ASF GitHub Bot commented on FLINK-1826: --- Github user mbalassi commented on the pull

[GitHub] flink pull request: [FLINK-1826]Remove the redundant codes never b...

2015-04-04 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/569#issuecomment-89617988 Hey, I personally like that the check is performed there even though it is currently redundant. It is true that the `DefaultMemoryManager` is for internal usage, but I th

[jira] [Assigned] (FLINK-1670) Collect method for streaming

2015-04-04 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay reassigned FLINK-1670: -- Assignee: Gabor Gevay > Collect method for streaming > > >

[jira] [Created] (FLINK-1829) Conflicting Jackson version in the Flink POMs

2015-04-04 Thread Alexander Alexandrov (JIRA)
Alexander Alexandrov created FLINK-1829: --- Summary: Conflicting Jackson version in the Flink POMs Key: FLINK-1829 URL: https://issues.apache.org/jira/browse/FLINK-1829 Project: Flink Iss

[jira] [Commented] (FLINK-1828) Impossible to output data to an HBase table

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395714#comment-14395714 ] ASF GitHub Bot commented on FLINK-1828: --- Github user fpompermaier commented on the p

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/571#issuecomment-89570344 Removed comments and commented code as suggested by Fabian. Do I have also to create a JIRA ticket about mapred.output.dir parameter? I think that it can be defaulted

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/571#issuecomment-89559472 Looks good to me, except for some comments that should be removed. Regarding the `mapred.output.dir` parameter I am not sure whether this is generally expected for

[jira] [Commented] (FLINK-1828) Impossible to output data to an HBase table

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395711#comment-14395711 ] ASF GitHub Bot commented on FLINK-1828: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-1828) Impossible to output data to an HBase table

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395710#comment-14395710 ] ASF GitHub Bot commented on FLINK-1828: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r27768585 --- Diff: flink-staging/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteExample.java --- @@ -0,0 +1,197 @@ +/* + * Licensed

[jira] [Commented] (FLINK-1828) Impossible to output data to an HBase table

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395709#comment-14395709 ] ASF GitHub Bot commented on FLINK-1828: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r27768581 --- Diff: flink-staging/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteExample.java --- @@ -0,0 +1,197 @@ +/* + * Licensed

[jira] [Commented] (FLINK-1828) Impossible to output data to an HBase table

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395707#comment-14395707 ] ASF GitHub Bot commented on FLINK-1828: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/571#discussion_r27768571 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopOutputFormatBase.java --- @@ -66,6 +67,8 @@ public HadoopOutputFormatBase

[jira] [Commented] (FLINK-1828) Impossible to output data to an HBase table

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395694#comment-14395694 ] ASF GitHub Bot commented on FLINK-1828: --- GitHub user fpompermaier opened a pull requ

[GitHub] flink pull request: Fixed Configurable HadoopOutputFormat (FLINK-1...

2015-04-04 Thread fpompermaier
GitHub user fpompermaier opened a pull request: https://github.com/apache/flink/pull/571 Fixed Configurable HadoopOutputFormat (FLINK-1828) See https://issues.apache.org/jira/browse/FLINK-1828 You can merge this pull request into a Git repository by running: $ git pull https://

[jira] [Created] (FLINK-1828) Impossible to output data to an HBase table

2015-04-04 Thread Flavio Pompermaier (JIRA)
Flavio Pompermaier created FLINK-1828: - Summary: Impossible to output data to an HBase table Key: FLINK-1828 URL: https://issues.apache.org/jira/browse/FLINK-1828 Project: Flink Issue Typ

[GitHub] flink pull request: Fix issue where Windows paths were not recogni...

2015-04-04 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/491#issuecomment-89548376 I checked what are [valid absolute paths on windows](https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx#paths). Summary: A pat

[jira] [Created] (FLINK-1827) Move test classes in test folders and fix scope of test dependencies

2015-04-04 Thread Flavio Pompermaier (JIRA)
Flavio Pompermaier created FLINK-1827: - Summary: Move test classes in test folders and fix scope of test dependencies Key: FLINK-1827 URL: https://issues.apache.org/jira/browse/FLINK-1827 Project:

[jira] [Updated] (FLINK-951) Reworking of Iteration Synchronization, Accumulators and Aggregators

2015-04-04 Thread Markus Holzemer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Holzemer updated FLINK-951: -- Affects Version/s: (was: 0.6-incubating) 0.9 > Reworking of Iteration

[jira] [Commented] (FLINK-951) Reworking of Iteration Synchronization, Accumulators and Aggregators

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395630#comment-14395630 ] ASF GitHub Bot commented on FLINK-951: -- Github user markus-h closed the pull request a

[GitHub] flink pull request: Reworking of Iteration Synchronization, Accumu...

2015-04-04 Thread markus-h
Github user markus-h closed the pull request at: https://github.com/apache/flink/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: Reworking of Iteration Synchronization, Accumu...

2015-04-04 Thread markus-h
Github user markus-h commented on the pull request: https://github.com/apache/flink/pull/36#issuecomment-89529411 This change is continued in https://github.com/apache/flink/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-951) Reworking of Iteration Synchronization, Accumulators and Aggregators

2015-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395628#comment-14395628 ] ASF GitHub Bot commented on FLINK-951: -- GitHub user markus-h opened a pull request:

[GitHub] flink pull request: [FLINK-951] Reworking of Iteration Synchroniza...

2015-04-04 Thread markus-h
GitHub user markus-h opened a pull request: https://github.com/apache/flink/pull/570 [FLINK-951] Reworking of Iteration Synchronization, Accumulators and Aggregators Iteration synchronization through JobManager Unification of Accumulators and Aggregators (removal of former Aggre