[jira] [Created] (FLINK-1405) Startup fails under Windows

2015-01-14 Thread Thomas Jejkal (JIRA)
Thomas Jejkal created FLINK-1405: Summary: Startup fails under Windows Key: FLINK-1405 URL: https://issues.apache.org/jira/browse/FLINK-1405 Project: Flink Issue Type: Bug Component

[jira] [Commented] (FLINK-1183) Generate gentle notification message when Flink is started with Java 6

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278338#comment-14278338 ] ASF GitHub Bot commented on FLINK-1183: --- Github user ajaybhat commented on the pull

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

2015-01-14 Thread ajaybhat
Github user ajaybhat commented on the pull request: https://github.com/apache/flink/pull/296#issuecomment-70046292 Thanks for the comments. Do you think the new message is better? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: https://issues.apache.org/jira/browse/FLINK-13...

2015-01-14 Thread msdevanms
GitHub user msdevanms opened a pull request: https://github.com/apache/flink/pull/312 https://issues.apache.org/jira/browse/FLINK-1388 https://issues.apache.org/jira/browse/FLINK-1388 You can merge this pull request into a Git repository by running: $ git pull https://github.co

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278333#comment-14278333 ] ASF GitHub Bot commented on FLINK-1388: --- GitHub user msdevanms opened a pull request

[jira] [Commented] (FLINK-1388) POJO support for writeAsCsv

2015-01-14 Thread Ajay Bhat (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278307#comment-14278307 ] Ajay Bhat commented on FLINK-1388: -- Hi, Does it make sense to use Jackson's Dataformat CS

[GitHub] flink pull request: Remove dup code fromRemoteExecutor#executePlan...

2015-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-1328) Rework Constant Field Annotations

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277815#comment-14277815 ] ASF GitHub Bot commented on FLINK-1328: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-14 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/311 [FLINK-1328] Reworked semantic annotations This PR is based on #83 Open Issues: - Naming of class annotations (`ConstantFields`, `ConstantFieldsExcept`, `ReadFields`, ...) and API method

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277717#comment-14277717 ] ASF GitHub Bot commented on FLINK-1395: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22971739 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. 0.5.1 + --- End diff -

[jira] [Commented] (FLINK-1402) Remove extra extend Serializable in InputFormat interface

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277684#comment-14277684 ] ASF GitHub Bot commented on FLINK-1402: --- Github user hsaputra commented on the pull

[GitHub] flink pull request: FLINK-1402 - Remove Serializable extends from ...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/306#issuecomment-69992202 I don't remember if there any best practice about this, so If we think it is useful we could keep this style and maybe document it? But I don't think it is good practi

[jira] [Commented] (FLINK-1402) Remove extra extend Serializable in InputFormat interface

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277660#comment-14277660 ] ASF GitHub Bot commented on FLINK-1402: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: FLINK-1402 - Remove Serializable extends from ...

2015-01-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/306#issuecomment-69989899 I also find it quite helpful to have Serialised repeated in such cases. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277653#comment-14277653 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968923 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. 0.5.1 + --- End diff -

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277647#comment-14277647 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-69988955 Ok, I looked at the existing LICENSE and NOTICE files and they don't contain any entries for apache licences projects. jodatime and the kaffee serialisers are also apache

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277644#comment-14277644 ] ASF GitHub Bot commented on FLINK-1395: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968592 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. 0.5.1 + --- End diff -

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277635#comment-14277635 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968315 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/KryoGenericTypeSerializerTest.scala --- @@ -125,6 +133,7 @@ class KryoGenericTypeSeri

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277634#comment-14277634 ] ASF GitHub Bot commented on FLINK-1395: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968293 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java --- @@ -99,6 +104,7 @@ public void testCopy() {

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69976328 +1 for some utilities. I'm not sure however where to put it. Should we add another maven module? Make it part of the current "flink-java" ? Or start it as a github

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277526#comment-14277526 ] ASF GitHub Bot commented on FLINK-1398: --- Github user rmetzger commented on the pull

[jira] [Commented] (FLINK-1400) In local mode, the default TaskManager won't listen on the data port.

2015-01-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277522#comment-14277522 ] Stephan Ewen commented on FLINK-1400: - I think you can also locally start a job manage

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/296#issuecomment-69971212 +1 gentler and informative =) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[jira] [Commented] (FLINK-1183) Generate gentle notification message when Flink is started with Java 6

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277455#comment-14277455 ] ASF GitHub Bot commented on FLINK-1183: --- Github user hsaputra commented on the pull

[jira] [Commented] (FLINK-1183) Generate gentle notification message when Flink is started with Java 6

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277444#comment-14277444 ] ASF GitHub Bot commented on FLINK-1183: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/296#issuecomment-69970228 How about setting the message to something like "Warning: You are running Flink with Java 6, which is not maintained any more by Oracle or the OpenJDK communi

[GitHub] flink pull request: Remove dup code fromRemoteExecutor#executePlan...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/307#issuecomment-69969896 Thanks @StephanEwen, will merge to master EOD if no one beats me to it. Don't think this is needed to be in 0.8.x branch for now. --- If your project is set up for i

[GitHub] flink pull request: Small cleanup on code after branch for 0.8 rel...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/302#issuecomment-69969666 I agree this should not be merged for 0.8.0 release. We should keep it in master for 0.9 and maybe included when we need 0.8.x rebase from master. --- If your project is

[GitHub] flink pull request: Small cleanup on code after branch for 0.8 rel...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/302#issuecomment-69968650 Good cleanups! The 0.8.0 release has a few release candidates out already and at this point I would suggest to fix what we find there, but not add any other co

[GitHub] flink pull request: FLINK-1402 - Remove Serializable extends from ...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/306#issuecomment-69967270 Ah ok, thanks for the info Stephen, good to know it was intentional. Do you want to keep this pattern? --- If your project is set up for it, you can reply to this ema

[jira] [Commented] (FLINK-1376) SubSlots are not properly released in case that a TaskManager fatally fails, leaving the system in a corrupted state

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277425#comment-14277425 ] ASF GitHub Bot commented on FLINK-1376: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-14 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/310 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure This PR introduces SharedSlots as being a special Slot type and as such being released properly in c

[GitHub] flink pull request: Remove dup code fromRemoteExecutor#executePlan...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/307#issuecomment-69967981 This change looks good to be merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-1402) Remove extra extend Serializable in InputFormat interface

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277415#comment-14277415 ] ASF GitHub Bot commented on FLINK-1402: --- Github user hsaputra commented on the pull

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277402#comment-14277402 ] ASF GitHub Bot commented on FLINK-1398: --- Github user FelixNeutatz commented on the p

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69966273 I am really open about the place of this functionality, but I'd really love to have it. Shall we start a package in flink-java? --- If your project is set up for it

[jira] [Commented] (FLINK-1402) Remove extra extend Serializable in InputFormat interface

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277397#comment-14277397 ] ASF GitHub Bot commented on FLINK-1402: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: FLINK-1402 - Remove Serializable extends from ...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/306#issuecomment-69965915 I think this is fine to merge. FYI: I sometimes repeat the `Serializable` interface in the list of superinterfaces (even when redundant) as a form of documenta

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277394#comment-14277394 ] ASF GitHub Bot commented on FLINK-1398: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69965449 I like the idea of having good utilities. There is always a bit of a trade-off between having the right utilities, and adding so many functions that the API be

[jira] [Commented] (FLINK-1376) SubSlots are not properly released in case that a TaskManager fatally fails, leaving the system in a corrupted state

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277385#comment-14277385 ] ASF GitHub Bot commented on FLINK-1376: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-14 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/309 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure This PR introduces SharedSlots as being a special Slot type and as such being released properly in c

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277379#comment-14277379 ] ASF GitHub Bot commented on FLINK-1395: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-69964529 Good work. Here are some comments/questions - jodatime has many classes beyond `DateTime`, such as for example `LocalDate`. Should we register them all? They

[jira] [Assigned] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz reassigned FLINK-1398: Assignee: Felix Neutatz > A new DataSet function: extractElementFromTuple > ---

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277362#comment-14277362 ] Felix Neutatz commented on FLINK-1398: -- @Fabian: you can see my second implementation

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277356#comment-14277356 ] ASF GitHub Bot commented on FLINK-1395: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22956572 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/KryoGenericTypeSerializerTest.scala --- @@ -125,6 +133,7 @@ class KryoGenericTypeS

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277348#comment-14277348 ] ASF GitHub Bot commented on FLINK-1398: --- Github user FelixNeutatz commented on the p

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69962411 The simple map function implementation reduces the code to 26 lines. I think that this is more reasonable :) --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277342#comment-14277342 ] ASF GitHub Bot commented on FLINK-1395: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22955775 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java --- @@ -99,6 +104,7 @@ public void testCopy() {

[GitHub] flink pull request: Add [FLINK-1376] Add proper shared slot releas...

2015-01-14 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Add [FLINK-1376] Add proper shared slot releas...

2015-01-14 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/300#issuecomment-69958460 I found the error and fixed it. I'll close this PR and open a new one rebased on the latest 0.8 release candidate. --- If your project is set up for it, you can repl

[jira] [Commented] (FLINK-1376) SubSlots are not properly released in case that a TaskManager fatally fails, leaving the system in a corrupted state

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277304#comment-14277304 ] ASF GitHub Bot commented on FLINK-1376: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-1376) SubSlots are not properly released in case that a TaskManager fatally fails, leaving the system in a corrupted state

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277305#comment-14277305 ] ASF GitHub Bot commented on FLINK-1376: --- Github user tillrohrmann closed the pull re

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69952101 Good question, I thought it would be nice to have it implemented "natively", but I can also setup the same thing using a simple map function if this is preferred --

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277239#comment-14277239 ] ASF GitHub Bot commented on FLINK-1398: --- Github user FelixNeutatz commented on the p

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277226#comment-14277226 ] Fabian Hueske commented on FLINK-1398: -- I am not sure how useful / how much needed su

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277141#comment-14277141 ] ASF GitHub Bot commented on FLINK-1398: --- Github user zentol commented on the pull re

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69940866 Why did you make a new operator instead of implementing it as a simple map function? --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-1398) A new DataSet function: extractElementFromTuple

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277105#comment-14277105 ] ASF GitHub Bot commented on FLINK-1398: --- GitHub user FelixNeutatz opened a pull requ

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/308 [FLINK-1398] Introduce extractSingleField() in DataSet This is a prototype how we could implement extractSingleField() for DataSet. Let's discuss :) You can merge this pull request into a Git r

[jira] [Created] (FLINK-1404) Trigger recycling of buffers held by historic intermediate result partitions

2015-01-14 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-1404: -- Summary: Trigger recycling of buffers held by historic intermediate result partitions Key: FLINK-1404 URL: https://issues.apache.org/jira/browse/FLINK-1404 Project: Flink

[jira] [Commented] (FLINK-1403) Streaming api doesn't support output file named with "file://" prefix

2015-01-14 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277073#comment-14277073 ] Márton Balassi commented on FLINK-1403: --- Hey, Thanks for posting the issue. We have

[jira] [Commented] (FLINK-1381) Only one output splitter supported per operator

2015-01-14 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277061#comment-14277061 ] Gyula Fora commented on FLINK-1381: --- Hey, So the problem is that the splitting is tied

[jira] [Created] (FLINK-1403) Streaming api doesn't support output file named with "file://" prefix

2015-01-14 Thread Mingliang Qi (JIRA)
Mingliang Qi created FLINK-1403: --- Summary: Streaming api doesn't support output file named with "file://" prefix Key: FLINK-1403 URL: https://issues.apache.org/jira/browse/FLINK-1403 Project: Flink

[jira] [Commented] (FLINK-1381) Only one output splitter supported per operator

2015-01-14 Thread Mingliang Qi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276984#comment-14276984 ] Mingliang Qi commented on FLINK-1381: - Is there any problem of moving the split functi

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276930#comment-14276930 ] ASF GitHub Bot commented on FLINK-1320: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...

2015-01-14 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/290#issuecomment-69921554 We could implement a DataInputDeserializer variant, which directly operates on `MemorySegment` instances to circumvent this. I agree that this should not be part of this PR.

[GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...

2015-01-14 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/290#issuecomment-69920591 @uce Yes, it will be copied from off-heap to heap first. There are also other places like the `EventSerializer` where this is the case. I guess it depends on the amount of dat

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276923#comment-14276923 ] ASF GitHub Bot commented on FLINK-1320: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...

2015-01-14 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/290#issuecomment-69917694 Nice :-) Regarding the DataInputDeserializer: You are right that it is currently not used, but I think with off-heap memory enabled the buffers will always be copied to a heap

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276915#comment-14276915 ] ASF GitHub Bot commented on FLINK-1320: --- Github user uce commented on the pull reque

[jira] [Commented] (FLINK-1320) Add an off-heap variant of the managed memory

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276911#comment-14276911 ] ASF GitHub Bot commented on FLINK-1320: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...

2015-01-14 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/290#issuecomment-69917146 I made some finally changes that were required for the current master. Also, I ran all integration tests with direct memory allocation enabled. Any objections for merging this

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276888#comment-14276888 ] ASF GitHub Bot commented on FLINK-1389: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-69913057 Thank you for the feedback. I'll rework the pull request soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-69902764 I think its more important to have a smooth user experience. The ExecutionEnvironment is not used anywhere else, kryo is already a dependency of "flink-java", so I don

[jira] [Commented] (FLINK-1399) Add support for registering Serializers with Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276805#comment-14276805 ] ASF GitHub Bot commented on FLINK-1399: --- Github user rmetzger commented on the pull

[jira] [Commented] (FLINK-1399) Add support for registering Serializers with Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276754#comment-14276754 ] ASF GitHub Bot commented on FLINK-1399: --- Github user aljoscha commented on the pull

[jira] [Commented] (FLINK-1399) Add support for registering Serializers with Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276753#comment-14276753 ] ASF GitHub Bot commented on FLINK-1399: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-69897430 But I also see that option 2 is more discoverable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-69897397 The reason I don't like option 2 is that it introduces knowledge about Kryo at the ExecutionEnvironment while it is right now agnostic of types and serialisers. --- If

[jira] [Commented] (FLINK-1399) Add support for registering Serializers with Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276744#comment-14276744 ] ASF GitHub Bot commented on FLINK-1399: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-14 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-69896334 I agree with @rmetzger, but I can see why @aljoscha likes the first suggestion more ;) --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (FLINK-1399) Add support for registering Serializers with Kryo

2015-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276743#comment-14276743 ] ASF GitHub Bot commented on FLINK-1399: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-69896090 The second option (env) is probably better because people will see the method when their IDE suggests method names. --- If your project is set up for it, you can reply t

[jira] [Commented] (FLINK-1400) In local mode, the default TaskManager won't listen on the data port.

2015-01-14 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276731#comment-14276731 ] Aljoscha Krettek commented on FLINK-1400: - You can, with a hack. You start a clust

[jira] [Commented] (FLINK-1400) In local mode, the default TaskManager won't listen on the data port.

2015-01-14 Thread Sergey Dudoladov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276710#comment-14276710 ] Sergey Dudoladov commented on FLINK-1400: - It's a bit confusing since the Job Mana

[jira] [Commented] (FLINK-1397) JobManager web interface log file access doesn't work on YARN

2015-01-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276706#comment-14276706 ] Robert Metzger commented on FLINK-1397: --- Fix in 0.8: http://git-wip-us.apache.org/re

[jira] [Resolved] (FLINK-1397) JobManager web interface log file access doesn't work on YARN

2015-01-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-1397. --- Resolution: Fixed Fix Version/s: 0.9 0.8 Resolved in http://git-wip-